[00:08:36] awjr: Is it OK if I just disable that test everywhere [00:08:48] awjr: nevermind [00:08:53] :) [00:09:03] awjr: I see you already took care of it while I was talking to Trevor :) [00:11:13] kaldari: how will your vacation work with q4 planning ? [00:11:18] i'm seeing them stack right next to each otehr [00:11:32] lemme look [00:15:17] tfinc: actually, I can come in on April 3 [00:15:40] check with awjr about the timing [00:15:54] MaxSem: do you remember where on graphite i can find the alpha/beta opt-in numbers? [00:16:05] tfinc: it looks like the planning meeting also overlaps with the monthly metrics meeting [00:16:25] awjr: ^ [00:16:42] aye, we can either do planning stuff in the afternoon or on tuesday instead [00:16:55] awjr, tfinc: Tuesday would be awesome [00:17:16] so maybe shift it from wed, thurs to tues, wed? [00:17:38] kaldari: lemme double check what folks said about availability and i'llg et back to you - im in a mtg now [00:17:52] awjr, search for "MediaWiki.stats.mobile" [00:18:35] thanks MaxSem [00:18:42] MaxSem: do you know if there are cumulative numbers anywhere? [00:35:46] kaldari: big table, if you can make it. No developer represent =[ [00:36:02] on my way... [01:03:59] kaldari: tu/weds should be fine for the quarterly planning. im just waiitng for confirmation from rachel about rescheduling [01:04:10] thanks! [01:49:06] hey awjr: We need to stick some new cards in the iteration after next for the typography updates that we're doing for the design team. I guess that means we would need to create a new iteration card and set that up right? [01:50:18] awjr: bingle bugs are flowing [01:51:17] tfinc you mean bugello? [01:51:25] yes [01:51:26] kaldari: you are corrrect [01:51:28] ah good tfinc [01:51:35] still grappling with bingle issues [01:51:48] kaldari: i may have already created one tho [01:51:56] its caught up nicely [01:52:16] looks like it'll be iteration R____ [01:52:18] kaldari: indeed [01:52:38] kaldari: the card already exists [01:52:45] yep, found it, thanks! [01:52:46] :D [02:32:43] (03CR) 10JGonera: QA: Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112675 (owner: 10Zfilipin) [12:01:45] yurik, yt? [13:04:45] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113281 (owner: 10MaxSem) [15:24:59] (03PS1) 10Yuvipanda: Fix crashes with NavDrawer when running in Strict Mode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113367 [15:25:01] (03PS1) 10Yuvipanda: Re-login if session cookies have expired [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113368 [15:36:17] (03PS1) 10Yuvipanda: Do not crash when user has changed password [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113370 [15:53:01] (03PS2) 10Zfilipin: Adding Cucumber tests First cucumber test for checking the banners on Wikipedia Zero. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/106709 (owner: 10Mayankmadan) [15:58:31] (03PS3) 10Zfilipin: Adding Cucumber tests First cucumber test for checking the banners on Wikipedia Zero. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/106709 (owner: 10Mayankmadan) [16:09:18] (03CR) 10MaxSem: [C: 032] Clean up SkinMinerva to pass mwcodesniffer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112939 (owner: 10Awjrichards) [16:09:57] (03Merged) 10jenkins-bot: Clean up SkinMinerva to pass mwcodesniffer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112939 (owner: 10Awjrichards) [17:41:41] hey yurik, mind taking a look at https://gerrit.wikimedia.org/r/113255 ? [17:43:04] MaxSem, looking [18:07:16] aww, no brio [18:07:17] n [18:07:21] * YuviPanda waves at violetto [18:07:40] *waves back at YuviPanda* [18:07:44] tfinc: I fixed all your crashes. Awaiting review, though [18:09:09] violetto: just wanted to say - I'll be sleep in about 1h20m :) [18:10:00] YuviPanda: whatcha been up to [18:10:21] violetto: fixing some crashes, finishing up on editing [18:10:39] violetto: might do some cleanup now (have 'no saved pages', 'no history' messages when they are empty) [18:11:40] violetto: I have the same login error behavior now. I am going to let mhurd figure out the exact tweening for the 'shake' animation and then get it from him [18:14:20] YuviPanda: im just preparing the infobox prototype so i can do some testing [18:14:25] violetto: ah, sweet [18:14:46] YuviPanda: the 2-layer idea [18:15:10] violetto: right. I would love to see prototypes, although I am currently not convinced that is a good idea. [18:15:17] violetto: oh, also. [18:15:25] violetto: i wanted to show you something [18:15:45] YuviPanda: ok [18:15:47] violetto: https://play.google.com/store/apps/details?id=animaonline.android.wikiexplorer [18:15:54] violetto: that's a new 'wikipedia app' that was released a few days ago [18:16:14] violetto: has reasonably good reviews, but I tried it out and feel that we are already better :) [18:16:28] violetto: they also collapse all infoboxes, but in a terrible, terrible way [18:16:30] violetto: try it out! [18:17:27] (03PS3) 10JGonera: Fix missing overlay header in RTL languages on Android 2.3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112822 [18:18:53] YuviPanda: downloading [18:19:10] violetto: try it out [18:21:37] YuviPanda: i will today, there's a giant app icon staring at me until the screen died, very slow start up [18:21:54] violetto: for your phone or the app? [18:22:19] YuviPanda: for the app. there's ads in that apP! [18:22:34] violetto: yup! I've notified legal as well :) [18:22:42] violetto: I personally think it sucks, but other people seem rather happy [18:23:40] YuviPanda: did you read the reviews? [18:23:56] it's a great way to see wht people are looking for, not just this wikipedia app, but other ones as well [18:24:24] kenanwang__, https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1640 is done, see the post with the same title on mobile-tech, can be moved to accepted [18:25:01] violetto: yep, some but not all [18:25:22] kenanwang__, https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1589 is done as I demonstrated during the showcase [18:26:15] signed off jgonera [18:26:40] thanks [18:27:26] violetto: 'By far the best Wikipedia app. This app puts the official app to shame. Its faster, beautifully designed, with features like reading lists and such it's highly recommended!' [18:27:47] YuviPanda: ha [18:28:09] violetto: 'Main Page not looking too good ' [18:28:39] violetto: so we do need a first page expericne [18:28:46] violetto: it also is about 7$ or so to 'unlock' everything :) [18:29:18] violetto: I'll also note that 'follows Android guidelines (Holo Design)' is a major + point for it :) [18:29:43] violetto: it takes two clicks to follow a link. THAT IS SO WEIRD [18:32:01] kenanwang__: ping? [18:32:12] tfinc: I emailed you a latest build. [18:32:23] thanks YuviPanda [18:32:24] YuviPanda: thanks [18:32:44] kenanwang__: the design refinements we discussed on the wednesday meeting would need their own cards, probably. I'll put them in the backlog [18:33:07] kenanwang__: you can test edits by switching to the testwiki. That is available in the language selector from 'settings' [18:33:46] kenanwang__: I'll also be on for about an hour more. [18:33:56] tfinc: do let me know if this is better. I'll be on for an hour and then off [18:38:36] YuviPanda: that two clicks is weird [18:40:39] violetto: yup [18:40:42] violetto: but people like it, apparently [18:41:06] violetto: some folks I've talked to love it, because it lets them continue reading the article they were reading and keep the one they were going to navigate to in a 'queue' that they can read later [18:41:35] YuviPanda: i have to commend them for being brave [18:43:10] YuviPanda: see, one behavior that isn't normal but turns out people love [18:43:17] YuviPanda: not that i love it though, i found it annoying [18:43:21] violetto: me too :) [18:43:28] violetto: we can try that out if you want :P [18:43:38] YuviPanda: yeah i'd rather try other brave things [18:43:42] violetto: :P :D [18:44:05] violetto: although the underlying concept of a 'reading list' - things you want to read but haven't gotten to yet, sounds very useful/interesting and something we might want to morph 'saved pages' to [18:44:07] eventually [18:44:08] at leats [18:44:09] YuviPanda: i only wish my team mates agree :P [18:44:29] violetto: :P you only have to convince them :D [18:44:36] violetto: also, I was thinking of something yesterday [18:44:36] YuviPanda: yeah we should make saved pages more interesting [18:44:47] violetto: like how you have 'beta' and 'alpha' in web, right [18:44:51] YuviPanda: that convincing game [18:44:53] violetto: we could have something similar in the apps too. [18:45:02] YuviPanda: we should totally! [18:45:11] YuviPanda: can't convince someone who's already convinced himself [18:45:14] violetto: would you rather have me do something just because you told me to, rather than because I am convinced that is the right thing to do? :) [18:45:15] *back to DESIGNING* [18:45:18] violetto: :D [18:45:19] violetto: ok [18:47:14] YuviPanda: my daily work life is about doing stuff i dont fully agree with not because im doing it blindly but becuase im willing to try it out becuase i KNOW im not always right in what's "right" [18:49:56] violetto: We could, once we have a 'beta' *inside* the app that people can activate, try it out there [18:50:18] violetto: so you go to settings, turn 'beta' on, and then you get those [18:50:26] YuviPanda: that'd be awesome! [18:50:34] violetto: we could even make it more granular, and track how many people turn it on - similar to BetaFeatures on desktop [18:50:40] violetto: I'd be *completely* willing to do that there :) [18:50:56] YuviPanda: how can we make that happen [18:51:51] violetto: the beta 'switch' as such is not too hard. A day's work at worst. [18:52:32] violetto: but the 'put the infobox behind a tap' is a fair bit more work. [18:52:40] greg-g: https://bugzilla.wikimedia.org/show_bug.cgi?id=61385 [18:53:30] YuviPanda: im going to do some testing that's why [18:55:04] violetto: I'd definitely be up for putting that in after the first release is out [18:55:31] violetto: my passion tells me at least that the infobox restyling is higher priority than hiding it behind a tap. I'd love to spend a couple of weeks on restyling [18:57:09] YuviPanda: makes me wonder what kenanwang__ think about it [18:57:25] tfinc: thanks [18:57:47] tfinc: indeed, it'll eventually come down to him [18:57:54] * YuviPanda pokes kenanwang__ [18:58:53] tfinc: think you'll have time to try out the new build anytime soon? [18:58:57] chrismcmahon: saw some test failures over night, looks like maybe a suace labs issue? [18:59:01] tfinc: there isn't much UX changes, just less crashes [18:59:07] at least less known crashes [18:59:13] YuviPanda: not within the next hour or two. it'll be later afternoon before i get to it [18:59:29] tfinc: ok! Email me issues? [18:59:37] i'll email mobile-tech [18:59:41] tfinc: ah, yes :) [19:02:00] awjr, jgonera: So both Jared and Erik want me to do a lightning deploy of https://gerrit.wikimedia.org/r/#/c/113383/ even though it doesn't meet our lightning deployment criteria. Is that OK with everyone? [19:02:00] dr0ptp4kt: I don't think I can get to it before monday :( sorry! [19:02:27] YuviPanda, that implies it will be done at 00:00 on tuesday, right? ;) [19:02:27] dr0ptp4kt: also, is there any way for me to test it? I think I'll be more comfortable if there's a way for me to setup the server to trigger me as 'on'/'off' [19:02:36] dr0ptp4kt: you will get at least some comments :D [19:02:47] dr0ptp4kt: it makes me uncomfortable becasue I've no way of testing both cases [19:02:48] *because [19:03:24] awjr: I think beta itself had an issue overnight [19:04:32] Yuvipanda violetto I need to get a better idea of what ideas are happening with infoboxes. [19:05:24] In general I agree that restyling is more interesting than hiding but I understand that the proposal isn't that simple [19:06:07] kenanwang__: I think they're orthogonal. You can hide with / without restyling, you can restyle with / without hiding [19:06:19] kenanwang__: I think the more interesting thing here is to have an 'experimental features' mode insidethe app [19:06:24] kenanwang__: i can show you what we're talking about later. [19:06:26] kenanwang__: that lets us experiment with things like that [19:06:30] kenanwang__: are you in today? [19:06:46] kenanwang__: so that we can build out these things without too much risk [19:06:50] kenanwang__: im also making a prototype so we can test it with users [19:07:03] YuviPanda, the patch for the outbound header - the one that yurik created for VCL instead of origin app servers - is in a holding pattern atm, iirc. thus, i think the best thing to do is: (1) set breakpoints, and (2) connect a phone that has both a cellular and a wifi connection, then (3) add/drop connections. the best way i've found to compel a dropped connection is to use another devices that supports wifi tethering - makes it easy to [19:07:03] effectively makea network appear and disappear. [19:07:35] dr0ptp4kt: I am wondering if I can set it up locally (or on labs) and hit that instead [19:07:39] I think the idea of having a vector for testing experimental features is great [19:07:45] YuviPanda: likewise, starting from having no available wifi to having wifi is a good test [19:08:12] For the specific feature were discussing let's talk today I'm heading in now violetto [19:09:04] kenanwang__: ok! [19:10:52] kenanwang__: I'll be off in about 20-30 mins. Email me if you have any questions about the sign off [19:18:23] YuviPanda, if you want to go through local setup lemme know [19:19:09] dr0ptp4kt: have you considererd setting up a vagrant role? :D [19:19:09] dr0ptp4kt: that'll make my (and other people's?) life so much easier :) [19:20:10] dr0ptp4kt: https://github.com/montehurd/apps-ios-wikipedia/commits/navBarDark [19:20:16] hey mhurd [19:20:23] mhurd: had any time to check out the 'shake' effects? [19:20:24] YuviPanda: hey! [19:20:51] kaldari: is there an email thread or something where the request is being coordinated? [19:20:53] YuviPanda: hehe not yet [19:20:55] for the LD i mean [19:21:00] mhurd: ok! [19:21:10] YuviPanda: maybe this afternoon [19:21:26] kaldari: and a followup - is this mobile related or do they just need someone to push the button? [19:21:27] YuviPanda, we sort of have support for this sort of stuff on en.m.wikipedia.beta.wmflabs.org. for example, try http://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page?X-CS=250-99 (normally you put the X-CS: 250-99 header in place instead of tacking as URL param, because that's how Varnish tags the request for the app origin server) [19:22:00] dr0ptp4kt: oh, so if we want to have a unit test, we can totally just use that and hit betalabs? [19:22:20] awjr: not mobile related [19:23:01] kenanwang__: wanna block off a few minutes for hangout for ios signoffs? [19:23:12] kaldari: ok, then i guess we can't refer them to our norms :) i leave it to your discretion pending the other stuff on your plate [19:23:24] YuviPanda, yeah, although i think we need to intentionally add a header for the positive test and just not have the header for the negative test [19:23:39] dr0ptp4kt: hmm, that would just 'mostly' work :) [19:24:36] (03PS1) 10Mhurd: Separate "navBarStyle" and "navBarMode" properties. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113388 [19:25:43] okay, about that S60 bug: I couldn't repro it in neither 3rd or 5th edition emulators, and I really want to sniff WTF is going on [19:25:57] chrismcmahon: i am seeing test results from enwiki and other hosts that say things like 'Uh-oh. Could not find link to Sauce Labs job URL. [19:25:58] Unable to pick a platform for the provided browser (RuntimeError)' [19:26:07] eg https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/304/testReport/junit/(root)/Footer%20links%20resolve/View_Edit_history_link_resolves/ [19:26:37] (03PS2) 10Dr0ptp4kt: Add basic Wikipedia Zero support for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113176 [19:29:23] tfinc: I got an email from jobvite/emily about clarifications a candidate asked, and responded. Can you check with Emily that that is all the actions I needed to do? [19:30:12] YuviPanda: that email didn't make it to me so give me some context [19:30:44] tfinc: forwarded. [19:30:57] tfinc: that's weird becuase it explicitly mentioned your name as someone it would be forwarded to [19:32:27] YuviPanda: jobvite is mysterious at best [19:32:38] tfinc: indeed. :) [19:32:48] tfinc: can you confirm with emily it'll eventually make its way to the candidate? [19:32:56] sure [19:33:02] i'll do that once i get into the office [19:33:17] meeting marathon this morning. almost done with it [19:33:25] tfinc: thanks! [19:33:25] * YuviPanda pokes moizsyed [19:33:56] tfinc: :) [19:34:12] greg-g: what's a good time for the lightning deployment [19:34:29] anytime, really [19:34:33] kaldari: wait, which one? [19:34:46] well, either really, just are you doing both? (mobile bug and typography) [19:35:28] Reedy: have you tried the new android app at all? [19:35:36] Nope...? [19:35:46] Reedy: I just emailed you a build :) [19:36:03] Reedy: has editing! anonymous and logged in. And sucks much lesser than the old app. [19:36:50] (03PS3) 10Dr0ptp4kt: Add basic Wikipedia Zero support for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113176 [19:37:17] greg-g: yes, I'll be doing both [19:38:17] kaldari: cool, so, ori/bryan are doing a no-op scap test right now, but after they're done you can go [19:39:01] dr0ptp4kt, around? [19:40:00] heh, no-op turned into i10n updates :) [19:40:01] i noticed we have a problem with banners - CSS was adjusted for mobile, now leaving a white border [19:40:18] mhurd: https://github.com/dr0ptp4kt/apps-ios-wikipedia/tree/zero-ios [19:40:33] yurik, mmhm, i'm here [19:41:00] dr0ptp4kt, want to take a pick? [19:41:15] or i could try to dig through it [19:41:27] (rebooting) [19:42:12] Reedy: try it out and file bugs? :) [19:42:18] when you have time, of course [19:43:14] Apparently it doesn't want to install [19:43:26] Do I need to remove the old one? [19:43:29] Reedy:yup [19:52:41] dr0ptp4kt, back [19:54:10] yurik, i can look at it if you're busy [19:54:34] dr0ptp4kt, only if you have a few spare cycles :) I'm looking at MaxSem patch [19:55:20] (03PS4) 10Dr0ptp4kt: Add basic Wikipedia Zero support for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113176 [19:58:23] (03PS2) 10Mhurd: Separate "navBarStyle" and "navBarMode" properties. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113388 [20:03:58] ori: ping me whenever your scap testing is done [20:04:09] kaldari: it's done [20:04:14] thanks [20:04:42] greg-g: is 1-2pm PST fine for the deployment? ori is done. [20:04:59] I'm about to get lunch [20:14:57] off to sleep then. night :) [20:27:57] need information for developing wiki newss app for android? [20:42:59] ergh [20:43:09] http://imgur.com/3SoSqbE [20:43:12] argh [20:43:39] is that from the s60 MaxSem? [20:43:44] yup [20:44:16] :( [20:44:41] and that's a WebKit based browser [20:44:59] I'm currently trying to get an even older emulator to work [20:45:08] with a creepier browser [20:45:13] heh [20:58:40] anybody want to review the VectorBeta change (it's easy): https://gerrit.wikimedia.org/r/#/c/113383/ [21:06:29] kaldari: came up to battle insomnia, patch looked good enough :) [21:06:46] rapid [21:07:20] kaldari: :) [21:07:24] kaldari: BE BOLD and all that [21:07:32] kaldari: plus this was always going to happen anyway :) [21:07:54] gawdddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd [21:08:35] no matter hows hard does S60 suck, its emulators suck billion times harder [21:09:44] so after I found an appropriate version and went all the way to install it despite DOA installer, it doesn't connect to interwebs [21:21:51] (03PS5) 10Dr0ptp4kt: Add basic Wikipedia Zero support for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113176 [21:27:44] dr0ptp4kt: hey, you in office? is kaldari there (at least nominally) today? [21:28:11] greg-g, i'm here. kaldari was here. not sure where he is at the moment. do you want me to look for him? [21:28:12] dr0ptp4kt: if so, when he's back within arm's reach, tell him that he's ok to deploy his fixes now. the site is back up :) [21:32:24] can someone in office check to see if they can reproduce the S60 crash with our test devices? [21:50:23] i am unable to edit in stable and beta on enwiki in an iOS simulator [21:50:35] can someone dbl check that editing works in real iOS? [21:50:38] jgonera: kaldari ^? [21:50:58] checking... [21:53:24] seems to be working fine for me [21:53:39] ok phew [21:53:52] i've run into a number of instances now where things dont work quite right in the ios simulator :( [21:54:02] makes me wish i had an actual ios device [21:54:13] awjr, checking [21:54:24] tested in stable and beta, no problems [21:54:46] thanks kaldari [21:55:03] moizsyed, vbamba is kaity|away in the office today? [21:55:04] it's really strange, i can tap on the watch star and that works, but pencil icons and photo upload are totally unresponsive [21:55:18] jgonera: havent seen her [21:55:32] huh section collapsing doesn't seem to work either [21:55:34] awjr, seems like the simulator doesn't handle the hashchange event perhaps? [21:55:36] silly simulator [21:55:39] uh [21:56:09] kaldari: did dr0ptp4kt poke you? [21:56:09] oh, now collapsing is working [21:56:12] maybe you're right jgonera [21:56:19] greg-g: yes, thanks! [21:56:24] np [21:56:45] kaldari: also, do you happen to know if there is a wiki page describing the plan for typography -> Vector? [21:57:01] sorry, you're just my current point of contact about these things, so you get ALL THE QUESTIONS [21:57:25] greg-g: I believe the design team is working on one. Might want to ask in #wikimedia-deisgn [21:58:47] gah, yac [22:25:13] > mobile-frontend-last-modified-months: Result of expression 'rule.split('@')[0].trim' [undefined] is not a function [22:25:19] is known? fixed? [22:25:52] MaxSem, it seems ok to me, with the possible exception of the continue style you use [22:26:14] thanks! and what's wrong with it? [22:26:43] we now have a much better "continue" -- just set "continue=" with the empty value on the first request [22:27:22] this way you never need to know the names of the internal continuation parameters [22:27:42] MaxSem, http://www.mediawiki.org/wiki/API:Query#Continuing_queries [22:28:04] ah:) [22:28:11] that quote is from 2014021410014214 fyi. back in a bit [22:28:56] MaxSem, i think we should implement some generic functions as part of the core api to pack/unpack multiple continue values into one parameter [22:29:14] this way you will have an easier time to return it as part of your own continuation [22:29:34] Idon't have my own continuation [22:29:55] just proxying the underlying llcontinue [22:30:07] MaxSem, you do - line 53 [22:30:36] you take whatever continuation is returned from internal call and pass it out [22:30:56] yeah, I don't consider it mine:) [22:31:17] in reality i think we should have some function "getContinuationValue" which will escape all the values in the "continue" branch [22:31:31] i will have to think of a better way i think, but its fine for now [22:31:44] you do need a $this->die... [22:31:50] on line 56 [22:32:10] otherwise looks good [22:33:25] MaxSem, although, why do we need that hook there? [22:33:45] yurik, so that zero can mangle the links if needed [22:35:12] MaxSem, oh, me silly, i thought it mangles it as part of getMobileUrl() [22:35:46] MaxSem, do you think it might be better to have just one hook call than? [22:35:54] with an array of all links? [22:36:16] never mind [22:36:19] i'm slow :( [22:36:25] need coffee [22:37:20] MaxSem, last thing that actually might be useful :) -- it might be slightly more efficient to pass in a list of pageids instead of titles for the faux call [22:38:12] right [22:38:39] getMobileUrl() only changes the domain but does not add zero warnings btw [22:38:55] yes, i realized that, thx [22:40:25] (03PS1) 10JGonera: Remove !important styles for .content img [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113475 [23:18:21] kenanwang__, vbamba I was thinking that if it's easy, we should also add undo/redo support in mobile VE... right now if you delete e.g. a template or something else not editable, you can't undo and you have to abandon your edit [23:23:14] kaldari, can you check https://gerrit.wikimedia.org/r/#/c/111146/ today? I'm afraid it's going to need rebasing again [23:23:35] sure [23:43:16] jgonera: yes [23:43:24] jared mentioned that also