[04:56:18] Special:Diff is in core ;) [10:39:40] * YuviPanda waves at MaxSem [10:39:41] around? [10:43:43] (03CR) 10Yuvipanda: "@Nicole: Thanks for the comments :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113772 (owner: 10Yuvipanda) [10:52:00] (03PS2) 10Yuvipanda: Display message when no saved pages exist [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113803 [10:52:02] (03PS2) 10Yuvipanda: Show a message when no items are present in History [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113805 [10:52:04] (03PS3) 10Yuvipanda: Hide keyboard when login screen exits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113772 [10:52:06] (03PS2) 10Yuvipanda: Hide keyboard when edit activity exits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113773 [10:52:08] (03PS1) 10Yuvipanda: Cleanup imports to prefer .* imports [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113938 [11:08:25] YuviPanda, hi [11:08:39] MaxSem: ugh, I was going to ask you something but I forgot [14:37:46] * YuviPanda waves at brion [15:24:16] (03PS1) 10Yuvipanda: [WIP] Style tester [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113969 [15:24:41] (03CR) 10Yuvipanda: [C: 04-2] "WIP" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113969 (owner: 10Yuvipanda) [15:36:38] * YuviPanda pokes brion [15:36:47] rowr [15:36:50] it's CR time [15:36:55] :D [15:36:57] yay [15:56:39] (03PS1) 10Yuvipanda: Hide search results when emptied [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113973 [15:57:18] (03CR) 10Brion VIBBER: [C: 032 V: 032] "seems slightly less crashy :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113181 (owner: 10Yuvipanda) [15:59:07] (03CR) 10Brion VIBBER: [C: 032 V: 032] Clear anon tokens (if any) once you log in [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113268 (owner: 10Yuvipanda) [16:01:06] brion: would you be going to the office today? [16:01:31] YuviPanda: wasn't planning to no [16:01:35] brion: ok [16:01:37] * brion double-checks calendar [16:02:07] ooh quarterly review meetings tomorrow though [16:02:14] oh? [16:02:45] brion: I just noticed it. it's probably way too late for me [16:03:02] i'll probably sit in but i gotta be on some irc meetings at the same time :D [16:04:08] YuviPanda: sometimes i see crashes in PageViewFragment.onSaveInstanceState -- webView is null so can't call webView.getScrollY() [16:04:22] brion: that should've been fixed by that first patch you merged [16:04:37] well that one wasn't :D [16:04:42] but i can't trigger it every time... [16:05:16] brion: hmm, grr. what were you doing when it happened? [16:05:16] weird [16:05:30] i set the handset down and the crash popped up [16:05:36] which usually means 'it rotated' [16:06:11] brion: right. I tried that a few times and couldn't repro it [16:06:27] brion: ooooh, that might be the other rotate related crash, which is fixed in a later commit that hasn't been merged yet [16:06:30] although that isn't webview related [16:06:34] well [16:06:39] we'll see if i see it again later :D [16:06:53] ok [16:07:12] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix crashes with NavDrawer when running in Strict Mode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113367 (owner: 10Yuvipanda) [16:09:31] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Looks workable. :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113368 (owner: 10Yuvipanda) [16:11:35] (03CR) 10Brion VIBBER: [C: 04-1] "Saving as anon if session expired is a very bad failure mode -- anon exposes user IP which we don't ever want to do without clear warning." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113370 (owner: 10Yuvipanda) [16:11:40] (03CR) 10Cmcmahon: [C: 031] The first Selenium test: banners [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/106709 (owner: 10Mayankmadan) [16:12:24] brion: in that case I'll just take that patch out of the series for now. [16:12:39] ok [16:12:57] brion: well, actually. [16:13:03] brion: the acceptance criteria says 'do not crash ever' [16:13:08] heh [16:13:20] brion: I think it's okay to do this, mark it a fixme, and then put a 'handle password change' in the backlog [16:13:21] can we abort the save without crashing? [16:13:37] cause i'd much rather abort without crashing than save as anon [16:14:02] brion: I agree as well, but that'll make me add layout code etc and that'll have to be removed later. [16:14:11] brion: let me check. in the meantime I'll get this patch out of the series [16:14:17] ok [16:14:31] (03PS3) 10Yuvipanda: Display message when no saved pages exist [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113803 [16:14:32] brion: done [16:14:33] (03PS2) 10Yuvipanda: Cleanup imports to prefer .* imports [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113938 [16:14:35] (03PS2) 10Yuvipanda: Hide search results when emptied [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113973 [16:14:37] (03PS3) 10Yuvipanda: Show a message when no items are present in History [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113805 [16:14:38] whee [16:14:39] (03PS4) 10Yuvipanda: Hide keyboard when login screen exits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113772 [16:14:41] (03PS3) 10Yuvipanda: Hide keyboard when edit activity exits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113773 [16:15:02] brion: I'm looking into that now [16:16:57] (03PS2) 10Yuvipanda: Do not crash when user has changed password [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113370 [16:16:58] brion: this should do? [16:18:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] Hide keyboard when login screen exits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113772 (owner: 10Yuvipanda) [16:18:32] looking [16:19:42] that should do [16:19:55] (03CR) 10Brion VIBBER: [C: 032 V: 032] Do not crash when user has changed password [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113370 (owner: 10Yuvipanda) [16:20:16] brion: let me rebase the rest now [16:20:17] ooh i forgot my coffee in the other room brb [16:20:21] ok [16:20:42] (03PS4) 10Yuvipanda: Display message when no saved pages exist [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113803 [16:20:44] (03PS3) 10Yuvipanda: Cleanup imports to prefer .* imports [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113938 [16:20:44] done [16:20:46] (03PS3) 10Yuvipanda: Hide search results when emptied [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113973 [16:20:48] (03PS4) 10Yuvipanda: Show a message when no items are present in History [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113805 [16:20:50] (03PS4) 10Yuvipanda: Hide keyboard when edit activity exits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113773 [16:37:18] (03CR) 10Brion VIBBER: [C: 032 V: 032] Hide keyboard when edit activity exits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113773 (owner: 10Yuvipanda) [16:39:20] (03CR) 10Brion VIBBER: [C: 032 V: 032] Display message when no saved pages exist [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113803 (owner: 10Yuvipanda) [16:40:53] (03CR) 10Brion VIBBER: [C: 032 V: 032] Show a message when no items are present in History [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113805 (owner: 10Yuvipanda) [16:47:16] (03CR) 10Brion VIBBER: [C: 032 V: 032] Cleanup imports to prefer .* imports [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113938 (owner: 10Yuvipanda) [16:55:38] (03CR) 10Brion VIBBER: [C: 032 V: 032] Hide search results when emptied [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/113973 (owner: 10Yuvipanda) [16:56:26] brion: woo, thanks :) [16:56:48] \o/ [16:57:02] brion: any update on the twn stuff? [16:57:26] YuviPanda: last i heard siebrand still had to look over our config. i'll check in [16:57:36] brion: you should poke aharoni [16:57:40] * YuviPanda pokes aharoni [16:57:59] YuviPanda: to set up for android we need a qq file don't we? [16:58:04] brion: we already have one [16:58:07] brion: values-qq [16:58:12] * aharoni would poke nikerabbit, but he hopped away. [16:58:12] ah good [16:58:15] brion: I need to update some [17:07:16] aharoni: we'll poke him again when he's back :D [17:22:24] (03CR) 10Brion VIBBER: [C: 032 V: 032] Separate "navBarStyle" and "navBarMode" properties. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113388 (owner: 10Mhurd) [17:23:53] hello ? [17:23:59] * YuviPanda waves at average [17:24:03] hey YuviPanda [17:24:05] hi average [17:24:11] hi stddev [17:24:28] I'm working on UDFs to provide Mobile with Device/Browser/OS stats [17:24:41] I need your help on a particular topic [17:24:58] Is there a reference statistic of Device families world-wide ? [17:25:08] I was only able to find this http://www.ibtimes.com/samsung-apple-or-nokia-whats-most-popular-brand-mobile-phones-your-country-map-1471036 [17:25:10] average: hmm, MaxSem or jgonera might be able to help better there [17:25:22] MaxSem , jgonera come forth :) [17:25:46] * MaxSem runs away [17:26:06] average: jgonera isn't online yet [17:26:15] http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm [17:26:55] MaxSem: I know the underlying code for that .. we're trying to build something more accurate [17:27:06] here is the current state of affairs https://office.wikimedia.org/wiki/Analytics/Internal/BrowserDeviceDetection [17:27:12] mmm 0.05% Blackberry - KILL KILL KILL [17:28:14] please feel free to comment on sections 1.1 , 1.2 , 1.3 in the Talk page [17:28:38] but for now, I would really need a reference point on Device family distribution world-wide [17:28:58] if someone knows of a study somewhere or an article that describes that, please let me know [17:29:23] average, I don't believe that we have 7% of Android 0.4 :) [17:29:46] ah, it's 4.0 [17:29:54] MaxSem: the dataset for those statistics is 1h of unsampled mobile stream [17:30:04] MaxSem: yes, it's 4.0 [17:30:43] what's the difference between uaparser_os and dclass_os? [17:30:54] MaxSem: see section 1.1 [17:31:49] uh, Java [17:32:27] MaxSem: uaparser is a library for device identification we're using ( jgonera's code for mobile stats was based on uaparser AFAIK) and dclass is a different library that does the same thing [17:32:34] but uaparser and dclass work in different ways [17:32:54] so that's why the numbers differ [17:33:21] so in principle 3 percentages should be detected: browser, layout engine and platform [17:35:27] the scope for us is currently : 1) Device family 2) OS name 3) OS major version 4) OS minor version 5) Browser name 6) Browser major version [17:37:22] MaxSem: by platform you mean OS. There is no way(that I know of at this time) to extract layout engine. But you do get the browser(as mentioned above) [17:39:07] average, au contraire - layout engine is easier than most of the rest, because the number of major players is very small - WebKit, Gecko, IE and the rest (not really important to differ between these) [17:39:59] MaxSem: touche ! maybe you can infer it then ? [17:40:42] from the browser I mean [17:41:48] MaxSem: blink too! :) [17:43:14] average, e.g. Opera switched from Presto to WebKit/Blink at one point, NetFront also switched to WebKit [17:44:12] MaxSem: ok, so you can have like ranges of versions of browsers, and you can infer the layout engine from that, right ? [17:46:07] hmm [18:03:34] ok, I have to go, please let me know if you know of a world-wide device family statistic that you have access to [18:03:37] thanks [18:04:39] awjr: if juliusz doesn't show up, I can cover the SoS [18:14:20] (03CR) 10Kaldari: [C: 032] Fix missing overlay header in RTL languages on Android 2.3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112822 (owner: 10JGonera) [18:15:04] (03Merged) 10jenkins-bot: Fix missing overlay header in RTL languages on Android 2.3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112822 (owner: 10JGonera) [18:15:08] awjr: when you say "cards on the wall", which cards are you talking about? [18:24:21] (03PS1) 10Cmcmahon: See Bug 61504 for description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113997 [18:24:38] kenanwang__: I sent you a new build [18:27:19] (03PS2) 10Cmcmahon: Maintenance for Chrome race condition. See Bug 61504 for description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113997 [18:27:55] * YuviPanda pokes brion [18:28:21] (03PS3) 10Cmcmahon: Maintenance for Chrome race condition. See Bug 61504 for description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113997 [18:28:27] brion: can you check https://www.mediawiki.org/wiki/API:Account_creation and see if it is accurate? [18:29:53] YuviPanda: looks correct-ish except that it doesn't mention the ConfirmEdit extension's additional behavior with the captcha prompt... yet :D [18:30:03] brion: edit! edit! edit! :) [18:30:42] moment, gotta get online for scrum of scrums :D [18:31:23] brion: ok :) [18:46:59] chrismcmahon1, what is the number of the bug? [18:47:26] hi jgonera https://bugzilla.wikimedia.org/show_bug.cgi?id=61504 [18:48:32] YuviPanda, mhurd: https://www.mediawiki.org/wiki/API:Account_creation <- updated [18:48:40] chrismcmahon1, ok, we'll have a look at it [18:48:41] thanks [18:48:43] jgonera: average wanted to talk to you [18:48:57] average? [18:49:08] also here's my sample test client code: https://github.com/brion/api-createaccount [18:49:15] jgonera: I forgot his real name. he works with the analytics team. check -analytics? [18:49:30] in theory you should support both simple text and image captchas, but in practice we'll only use images :) [18:49:39] brion: right [18:50:06] ok, I'll talk to him later, gotta run to the office for the mw ui hack meeting [18:50:07] YuviPanda, jgonera: Stefan Petrea [18:50:21] MaxSem: ah, ok! [18:50:47] brion: awesome! thanks! [18:52:25] jgonera: it might not be a bug, and I can work around it in the test, but it does seem to be new behavior with the BACK button in Chrome [18:54:03] chrismcmahon1, interesting, I don't think we changed anything with the back button recently, maybe a small change in Chrome? [18:55:59] brion: i added a couple comments to adam's zero patch https://gerrit.wikimedia.org/r/#/c/113176/ [18:57:17] brion: not sure if i added them correctly though... [19:00:04] kaldari: 'cards on the wall' referred to cards on the scrum of scrums dependency wall [19:00:18] http://tinyurl.com/mxu73yl [19:00:26] awjr: thanks [19:00:58] Didn't realize scrum of scrums had its own mingle project :) [19:01:11] aye - it's super lightweight tho [19:01:25] it is handy for quickly visualizing the inter-team dependencies [19:01:44] mhurd: inline comments? you have to leave a review for them to actually save. :) you don't have to touch the CR +1/-1/etc though can just comment alone [19:07:09] brion: ah! thanks! [19:07:57] (03CR) 10Mhurd: "Added a couple comments..." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113176 (owner: 10Dr0ptp4kt) [19:42:00] kenanwang__: ping? [19:42:58] brion: YuviPanda: tfinc: kenanwang__: did you see the front-end android task email from nicole? looks like hooking up basic *back end* network stuff took the entire 3 hrs. i guess this sounds about right - especially if you've not interacted with the api before. any thoughts? [19:43:21] mhurd: i'm in a meeting. will look at after [19:43:32] tfinc: k [19:48:41] she brings up good points in the email. seems to have good awareness of the challenges related to the async nature of the tas...k [19:48:49] "task..." [19:49:36] mhurd: pm [19:54:25] dr0ptp4kt: oh hai [20:02:40] * YuviPanda pokes kenanwang__ [20:04:14] hey YuviPanda Just got out of meetings. Gonna look at the build now [20:04:21] kenanwang__: ok! [20:04:30] brion: around? [20:09:33] yo [20:10:44] brion: pm? [20:10:52] sure [20:23:50] brion: can you record a new iOS and Android video to demo at the quarterly review ? [20:23:55] major features and such [20:29:29] tfinc: for the meeting tomorrow? [20:29:30] sure [20:50:11] mhurd: https://www.mediawiki.org/wiki/Requests_for_comment/Passwords [20:50:41] YuviPanda: brion I signed off the cards and filed a few bugs [20:50:48] woot [20:51:45] kenanwang__: hmm, weird. it does remember the page for me. are you backgrounding it by hitting 'back' or by hitting 'recent apps' icon? [20:52:01] the home button [20:52:19] kenanwang__: what device is this? [20:52:29] kenanwang__: and this is the build I just sent you titled 'feb 18th' right? [20:53:09] ugh my firefox is being super flaky today [20:53:18] might be time to downgrade from nightly for a while :) [20:58:25] yeah YuviPanda the email that you sent today [20:58:35] It's on a Nexus4 [20:58:57] eh, there's no video link for retrospective [20:59:28] althought I noticed that the login screen doesn't include any of the changes that we talked about during the design review [20:59:40] so I dunno if it's for sure up to date [21:00:12] MaxSem: there is now [21:00:14] sorry bout that [21:02:06] jgonera: kaldari retrospective [21:04:26] mhurd: around? [21:04:31] YuviPanda: ya! [21:04:34] mhurd: pm? [21:04:38] YuviPanda: ya! [21:07:07] *implementing lunch extension* brb [21:07:26] mhurd: heh :) [21:07:48] hehe [22:05:13] brion: you about [22:05:15] ? [22:05:16] awjr: trying to set up on a new system [22:05:25] kaldari: ahha np [22:05:42] Al Pacino got a teleconferencing upgrade [22:05:45] zero guys are looking for you to discuss feasibility for a feature [22:06:11] tfinc: yo [22:06:22] yurik: dr0ptp4kt --^ [22:07:20] tfinc: ? [22:07:37] yurik: Adele just came down asking me to connect you guys with brion [22:07:41] hence my message [22:07:50] * brion waves [22:10:15] tfinc: brandon :) [22:10:20] hi brion :) [22:10:28] no questions for you [22:10:34] it was bblack we needed [22:10:43] ahh, that makes it different. he's at an offsite with all the other designers [22:10:51] hehe ok [22:10:53] oh [22:10:55] bblack [22:11:06] jeez. you guys need to give me full names next time [22:11:26] tfinc: we were pinging him online already :)) [22:11:39] yurikR: great. any luck ? [22:11:42] nope :) [22:11:54] although it should have been a frow :( [22:11:56] frown [22:17:05] awjr, the battery in the keyboard died after we rebooted... Chip's on it [22:17:28] (03CR) 10Brion VIBBER: [C: 031] "Monte, any objection to going ahead with a merge and patching things up later? Or do you want to tweak it a bit first?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113176 (owner: 10Dr0ptp4kt) [22:18:12] >_< [22:18:55] brion: merge now and patch later sounds good :) [22:19:03] ok let's ... rolllllll [22:19:09] brion: yay! [22:19:14] mhurd: brion heading to sleep :) [22:19:25] zz_yuvipanda: have a good rest!!! [22:19:32] mhurd: I'll try to finish up the next task over that etherpad when I wake up. feel free to take a shot at it now as well :) [22:19:44] zz_yuvipanda: k! :) [22:20:27] (03CR) 10Brion VIBBER: [C: 032 V: 032] ""Doesn't explode!" Let's merge now before we drift out of sync again and we'll see what we need to patch up in a bit. :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/113176 (owner: 10Dr0ptp4kt) [22:20:42] zz_yuvipanda: nighty night! [22:28:23] https://etherpad.wikimedia.org/p/MobileWeb-IterationName [22:38:41] (03PS1) 10Mhurd: When editing captcha is visible, editing window is now properly hidden. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/114090 [22:38:51] brion: ^ small patch [22:41:04] woot [22:48:19] (03CR) 10Brion VIBBER: [C: 032 V: 032] When editing captcha is visible, editing window is now properly hidden. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/114090 (owner: 10Mhurd) [22:51:48] yurikR: yo [23:26:50] (03PS1) 10Yurik: Disable api with 401 [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/114102 [23:27:09] dr0ptp4kt: urgent +2 ^ [23:29:23] (03CR) 10Dr0ptp4kt: [C: 032] Disable api with 401 [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/114102 (owner: 10Yurik) [23:29:25] (03Merged) 10jenkins-bot: Disable api with 401 [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/114102 (owner: 10Yurik) [23:52:37] jgonera: When I try to instantiate the client from a test script, I get "uninitialized constant MediawikiApi::Client (NameError)". The command I'm trying is client = MediawikiApi::Client.new("http://core.local/api.php"). new() is supposed to map to initialize() automatically, right? [23:53:06] kaldari, yes, new maps to initialize