[00:28:19] jgonera: vibha is in the "batcave" [00:28:36] jgonera: and invites us to her lair [00:28:48] kaity, that sounds scary! [00:53:54] MaxSem: have a back-end bugfix for you to review: https://gerrit.wikimedia.org/r/#/c/114375 [01:18:20] kaldari, any preference as to what I should review first? [01:22:09] jgonera: I'm still working on the Story 1628 patch, so you can skip that one for now [01:22:12] (03CR) 10JGonera: [C: 032] Making back button flippable in RTL languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114364 (owner: 10Kaldari) [01:22:52] (03Merged) 10jenkins-bot: Making back button flippable in RTL languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114364 (owner: 10Kaldari) [01:22:55] you can also review https://gerrit.wikimedia.org/r/#/c/114004/ if you like (in VisualEditor) [01:23:01] jgonera: ^ [01:23:11] ok [01:23:20] jgonera: i was just reading your report on https://bugzilla.wikimedia.org/show_bug.cgi?id=61400 - i presume you don't have $wgMobileUrlTemplate set? [01:24:08] awjr, I don't [01:24:33] i suspect the problem is browser caching [01:24:45] have you looked at network requests when you've had the bad behavior? [01:25:38] or not [01:25:53] i just tried it locally and see what you describe [01:25:54] awjr, let me check again, although I have Chrome's inspector open all the time which disables cache [01:26:29] yeah, that doesn't seem right [01:26:52] awjr, just checked again, still same behavior with cache turned off [01:27:30] can you reproduce it? [01:27:32] that is weird [01:27:33] yes [01:27:40] it used to work :( [01:27:47] yeah, I know ;) [01:27:54] but last time i played with it was probably when i wrote it : [01:29:03] it at least sets the mf_useformat cookie... [01:31:35] (03CR) 10JGonera: [C: 032] Fixing formatting of language button in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114181 (owner: 10Kaldari) [01:31:39] (03PS2) 10Kaldari: Story 1628: Fix some of the mobile VE toolbar styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113496 [01:32:15] (03Merged) 10jenkins-bot: Fixing formatting of language button in stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114181 (owner: 10Kaldari) [01:34:18] kaldari, when you have some time, it would be nice to merge this https://gerrit.wikimedia.org/r/#/c/113475/ (fixes overlays in VE) [01:35:07] this one is pretty small too: https://gerrit.wikimedia.org/r/#/c/114113/ [01:35:33] looking [01:36:31] (03PS3) 10Kaldari: Story 1628: Fix some of the mobile VE toolbar styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113496 [01:37:42] (03PS4) 10Kaldari: Story 1628: Fix some of the mobile VE toolbar styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113496 [01:39:01] (03CR) 10jenkins-bot: [V: 04-1] Story 1628: Fix some of the mobile VE toolbar styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113496 (owner: 10Kaldari) [01:42:18] jgonera: who's Nicole Sullivan? [01:43:08] apparently, either an actress or Jon's CSS idol (www.stubbornella.org) [01:43:12] kaldari, ^ [01:45:36] kaldari, maybe Jon's mysterious comment can be understood by carefully analyzing http://www.brainyquote.com/quotes/authors/n/nicole_sullivan.html [01:53:06] (03CR) 10Kaldari: [C: 04-1] "I think we need to keep the max-width so that large images don't cause scrollbars on small phones." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113475 (owner: 10JGonera) [01:57:38] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113496 (owner: 10Kaldari) [02:02:21] (03CR) 10Kaldari: [C: 032] Hygiene: Remove this.canHide from editor overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114113 (owner: 10JGonera) [02:03:02] (03Merged) 10jenkins-bot: Hygiene: Remove this.canHide from editor overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114113 (owner: 10JGonera) [02:06:37] (03PS1) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114389 [02:12:35] (03PS2) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114389 [02:12:54] brion: i tried to manually correct as many merge conflicts as possible for the android stuff to account for the last 16 days of drift, and the thing seems to magically still run. https://gerrit.wikimedia.org/r/114389 [02:13:59] so i don't think we need https://gerrit.wikimedia.org/r/#/c/110665/ anymore, although you'll want to go back through your comments on that perhaps if you're doing a second pass on the code (i saw Yuvi's request for that earlier) [02:14:18] i'm going to head out [02:21:44] (03PS1) 10Awjrichards: Ensure checkToggleView() fires at appropriate time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114392 [02:22:47] jgonera: ^ should fix it [08:47:19] (03PS1) 10Yuvipanda: Refactor captcha handling into its own Handler [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114440 [09:36:32] (03PS1) 10Yuvipanda: Refactor out code that did non-empty validation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114444 [09:37:10] (03PS1) 10Yuvipanda: Don't pass title to RefreshCaptcha when Site would do [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114445 [09:56:00] (03PS2) 10Yuvipanda: Refactor out code that did non-empty validation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114444 [09:56:02] (03PS2) 10Yuvipanda: Don't pass title to RefreshCaptcha when Site would do [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114445 [14:59:02] brion: around? [15:09:32] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=61663 [15:09:39] MaxSem: I think it's not too late to fix it? [15:09:45] hopefully, at least [15:10:12] MaxSem: we could check API logs! [15:10:32] FUUUU [15:10:49] MaxSem: I pushed a pathc [15:10:51] *patch [15:11:47] yuvipanda, what about "warning" [15:11:48] ? [15:12:17] MaxSem: hmm, I don't know if other API methods use that as well. They usually just put things in 'error' [15:12:21] let me check action=edit [15:12:46] MaxSem: but yeah, let's make that ucfirst too [15:13:07] MaxSem: needtoken is also NeedToken [15:13:17] lololo [15:14:17] MaxSem: updated. [15:14:19] MaxSem: can you grep logs? [15:14:29] in process [15:14:49] MaxSem: ok! [15:19:42] maxsem@fluorine:/a/mw-log$ grep createaccount api.log | wc -l [15:19:42] 8898 [15:19:54] F~~L [15:20:02] MaxSem: ... [15:20:23] MaxSem: too late, eh? [15:20:43] who that might be? [15:20:53] MaxSem: unsure. can you check individual ones? [15:21:04] MaxSem: this has been working in the cluster only for a few weeks now, and that wasn't even widely announced [15:21:05] also, ask yurik and anomie? [15:21:10] MaxSem: yeah, I'll add them [15:36:20] yuvipanda, also boo for 61580 [15:36:39] MaxSem: :D [15:36:40] per license, you're not supposed to give a fuck:P [15:38:18] MaxSem: heh, following the spirit of the license there I see :P [15:47:40] bleh yuvipanda [15:47:42] maxsem@fluorine:/a/mw-log$ grep action=createaccount api.log | wc -l [15:47:42] 25 [15:47:49] much less scary [15:48:00] MaxSem: who are all these people who make API requests with the string createaccount in them? [15:48:04] MaxSem: and I bet all 25 of those is me [15:48:06] and monte [15:48:36] why do ppl request so many tokens though? [15:48:49] with createaccount? [15:48:58] yep [15:48:59] because I am just getting past the stage where I actually use it :P [15:49:08] plus my unit test also just requests the token :P [15:49:14] 'unit' test [17:41:12] (03Abandoned) 10MaxSem: WIP: Zerofy lang and variant links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113255 (owner: 10MaxSem) [17:41:19] yurik, ^^^ [17:47:47] awjr_away: are you really away? [17:51:14] MaxSem, just make sure that in case of non-js, your special page that shows langlinks gets properly handled by zero (which should wrap langlinks with its own special: from, to [17:56:06] brion: hey! [17:56:23] heyyyy [17:56:39] brion: so we found out that the account create API returned inconsistent results. [17:56:42] chrismcmahon: i was but not anymore :) [17:56:53] brion: 'success' instead of 'Success' and 'needtoken' instead of 'NeedToken' :) [17:57:02] brion: just got merged and in the process of being deployed :) [17:57:10] brion: but unrelated there are lots of android patches [17:58:00] ruhroh mw.org looks broken [17:58:26] hi awjr apropos of our conversation earlier, I am starting to wonder if something funky is going on with mobile editing: http://mobile-reportcard.wmflabs.org/#edits_daily-graphs-tab The browser tests are back to green but those limn lines are not trending back up. [17:59:37] yuvipanda: heh yeah i saw (api tweak) [17:59:52] ah the wonders that nobody notices when an API is unusable for months and months because it's missing the captcha support ;) [17:59:58] brion: hehe :D [18:00:08] chrismcmahon: im not very familiar with how those graphs get generated but i do not htink it is in real time [18:00:19] brion: we grepped the logs. 25 requests, mostly from me and monte I presume [18:00:22] awjr: OK, just checking [18:00:25] juliusz (when he gets in) or kaldari may be able to tell you more [18:00:36] brion: I created the first user account, btw :) [18:00:38] brion: works fine [18:00:46] \o/ [18:01:02] chrismcmahon: i do know that it always looks like something is totally f'd 'today' [18:01:04] so, that is normal :) [18:01:09] brion: so if the captcha is wrong, it returns an error code. Edit returns new captcha + error code [18:01:26] I seemed to have missed the conversation [18:01:27] awjr: heh. SNAFU indeed. [18:01:49] hahaha [18:01:58] brion: so wondering if we should fix that to return error code *and* captcha? [18:02:42] awjr: this is an object lesson about how browser tests are only one piece of a whole DevOps monitoring network. (of which we could use more better) [18:02:54] totally chrismcmahon [18:03:10] awjr and chrismcmahon, those graphs are computed according to their configuration [18:03:25] i should hope so [18:03:27] for that specific tab, most are scheduled to re-run the query every 30 minutes [18:03:31] and then rsync the results [18:03:44] that makes sense [18:03:58] one problem is that limn doesn't cache-bust files coming from remote servers through its proxy [18:03:59] yuvipanda: does edit return an error response, or an edit response with a non-success result? [18:04:05] so as the day goes on 'today' should look better and better, milimetric? [18:04:05] brion: non-success [18:04:08] brion: not [18:04:13] ok [18:04:15] usually whatever 'today' is always looks like everything's broken [18:04:16] brion: so I am wondering if we should emulate that [18:04:17] yeah, but see note above awjr [18:04:22] yeah it looked more complicated to extend it to return the alternate result [18:04:26] ahha [18:04:29] but i don't think it would be super hard [18:04:31] so chances are if you aren't clearing your cache, you're getting cached datafiles [18:04:38] oh i see [18:04:40] if you want to extend it further .... now 's the time i guess :D [18:04:46] force refresh should be sufficient, milimetric? [18:04:51] the other solution would be to set the cache headers on that static file site [18:04:58] brion: yeah, that'll be super nice. it'll also reduce the number of requests when your captcha fails. now it's 2. Already captcha image serves are slow [18:05:02] well, chrome doesn't have force refresh [18:05:02] appears to be, numbers seem to go up when i do that [18:05:07] but yeah, like, clear cache, refresh [18:05:13] brion: think you can take that on now? :D [18:05:13] aye [18:05:19] brion: if we are breaking backwards compat, NOW IS THE TIME! :) [18:05:35] but awjr: definitely champion cache-busting for remote files [18:05:39] I don't think it should be crazy hard [18:05:47] fo sho [18:05:49] * Niya watches with popcorn in hand [18:06:08] brion: although, if a token is only valid for one request after getting the token, we might have to perform it again anyway [18:06:20] hmmmm good point [18:06:20] brion: I don't know if the token is for one *successful* request or *one* request [18:06:33] i would think it's for one individual request, but you know i'm not actually sure [18:06:41] brion: can you check? [18:07:47] * yuvipanda hands Niya some more Popcorn with chilli. [18:08:08] brion: we should also investigate why requesting the captcha image itself is slow. They aren't generated on demand are they? [18:08:50] no they're pregenerated [18:08:55] how slow's it being? [18:09:04] it may be that the script that fetches one is just slow :P [18:09:16] brion: at least 4-5s. fetching a thumb is faster [18:09:37] brion: I wonder if they are cached in varnish [18:10:18] weird [18:11:05] brion: I could look at the code that's hit and see if there's any way to optimize it [18:12:52] yuvipanda: yeah it may have gotten more inefficient when switched to media backends or something [18:13:01] brion: yeah, I'm talking to chris on -dev [18:13:05] the code to pick one might be fetching too much [18:13:08] brion: I'll investigate. [18:13:17] whee [18:13:43] brion: I'll also file a bug :) [18:14:01] brion: can you look at the android patches now? :) I'll send a meaty one before you're done looking at the current ones :0 [18:14:08] will do [18:14:16] brion: \o/ [18:18:45] mhurd: hey! [18:18:55] mhurd: changes to the account creation API might be afoot :) see email to mobile-tech [18:19:07] yuvipanda: just replied to it! good catch!!!! [18:19:19] so i feel like i'm being a noob, but i always end up with these mvn errors ._. :: [ERROR] Failed to execute goal on project wikipedia: Could not resolve dependencies for project org.wikimedia:wikipedia:apk:1.0-SNAPSHOT: Could not find artifact com.android.support:support-v4:jar:18.0.+ in tools-repository (https://tools.wmflabs.org/android-maven-repo/) -> [Help 1] [18:19:22] mhurd: :) I'm talking to brion, we migh thave some further tweaks [18:19:53] and i'm not quite sure what to do (because i can certainly find it there >_>) [18:20:02] Niya: oh, right. I need to update the README :| let me give you the command to run [18:20:02] yuvipanda: so glad you guys are so on top of things :) [18:20:12] Niya: mvn install -Dmaven.wagon.http.ssl.insecure=true -Dmaven.wagon.http.ssl.allowall=true -U [18:20:35] Niya: the https cert in tools.wmflabs.org is somehow not recognized as valid by Java, and craps out :( [18:21:00] Niya: I really should fix the README. it's a mess. [18:21:21] mhurd: :) I'll keep you notified of further breaking changes. [18:21:31] yuvipanda: lol [18:21:35] mhurd: :) [18:21:38] :) [18:22:40] MaxSem: ping? think you can do a small LD? :) Greg's okay with it. [18:23:00] I can. when? [18:23:01] mhurd: right now, testwiki will return 'Success' but enwiki will return 'success'. I'm working on getting that fixed [18:23:06] MaxSem: today? [18:23:19] greg-g: ^ LD window for the API thing? [18:23:26] yes [18:24:19] MaxSem: https://gerrit.wikimedia.org/r/#/c/114473/ and https://gerrit.wikimedia.org/r/#/c/114484/ [18:24:26] greg-g: is the testwiki deploy done? [18:24:30] blasted microusb cables keep migrating [18:25:02] * brion dreams of wireless usb [18:25:20] yuvipanda: ah. thanks i'll keep an eye out for that. oh, are you using any naming convention for the testing accounts you create to make it easier to remove them en-mass later? [18:25:23] brion: you know that the next USB version will *gasp* go in both ways? :) [18:25:35] :) [18:25:36] yuvipanda: unpossible! [18:25:43] mhurd: we can't really remove them :) Call them -test- to be safe [18:25:43] what!? [18:25:58] yuvipanda: k. sounds good [18:25:59] mhurd: having unidentified multiple accounts is liable to get you banned :P So make it super obvious it is you creating them :) [18:26:18] mhurd: also remember there's a per-IP limit on account creation ;) you can easily make the office not be able to create accounts :) [18:26:27] i just name them like 'Test account 84239847' [18:26:30] yuvipanda: oh god not that again :) [18:26:32] or 'Brion Testaccount 23487' [18:26:44] mhurd: you can also hit en.wikipedia.beta.wmflabs.org - same code, but nobody gives a shit what goes on there :) [18:26:49] brion: yeah, i call it yuvipanda-testing-1 [18:26:50] lol [18:27:02] Niya: :) MW is weird and mysterious and in parts quite sucky. [18:28:56] XD [18:29:28] Niya: we're working on it! I swear :) [18:30:16] hmm, logging out is taking forever for some reason [18:30:48] brion: on the app? [18:30:52] yeah [18:30:57] brion: weird. is usually fast [18:30:57] ok quit and restarted it and it went fine [18:30:59] yuvipanda: do you get a weird localisation cache error when editing test wiki? [18:30:59] WEIRD [18:31:04] if i see that again i'll try and track it donw [18:31:16] mhurd: no, but they're trying out new deploy tools today so might be an issue there. [18:31:56] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Stub form should have a second password confirmation field, but we'll amke sure that's in later. :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114141 (owner: 10Yuvipanda) [18:32:28] brion: I'm going to talk to may about that, see if we can not have the 'repeat password' thing [18:32:39] Niya: let me know if the mvn command I gave you worked :) [18:33:06] yuvipanda: yeah, it's still giving me the same error =( [18:33:22] Niya: even with the -U at the end? [18:34:44] yuvipanda: yeah =/ it checks the others fine, an then it says: [WARNING] The POM for com.android.support:support-v4:jar:18.0.+ is missing, no dependency information available [18:35:02] (03PS1) 10Yuvipanda: Actually create the account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114508 [18:35:18] yuvipanda: it downloads the support jars, but then throws up that error o.o; [18:35:18] Niya: hmm, I remember running into that and somehow fixing it. let me try in a moment when I'm done with this patch series. [18:35:33] yuvipanda: sure sure =D [18:35:59] Caused by: org.wikipedia.editing.EditingException: Exception Caught: No localisation cache found for English. Please run maintenance/rebuildLocalisationCache.php. [18:36:02] heh [18:36:07] brion: heh. [18:36:18] brion: switch to enwiki? :D [18:40:58] yuvipanda: just looking more carefully at the errors, it looks like the package name is ... well, the url it's hitting is off. it says it's trying to download "/com/android/support/..." but in the repo it's under "/android/support/..." [18:41:24] Niya: ah, hmmm. perhaps one of the packages depends on com.android.support and isn't finding it [18:41:35] I bet that's crouton, since that is the one I added recently [18:41:51] * yuvipanda checks [18:42:15] Niya: yes, that's crouton! :) let me fix [18:42:44] yuvipanda: =D [18:50:45] MaxSem, just added you to https://gerrit.wikimedia.org/r/#/c/113655/. I'm talking with ori about it in 4 hours to see if he can think of any additional tweaks. i've tried to optimize as much as possible, but in the absence of esi, i can't think of any way to do is-https-zero-rated checks more efficiently. [18:51:21] (03PS2) 10Yuvipanda: Actually create the account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114508 [18:51:47] Niya: fixed it! patch coming up. [18:51:56] Niya: thanks for spotting that! saved me a bit of time hunting around :) [18:52:31] yuvipanda: =D thanks for helping! *goes to try it* [18:52:40] (03PS1) 10Yuvipanda: Pick up android support library from appropriate place [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114513 [18:52:41] dr0ptp4kt, looking [18:52:41] Niya: patch is here ^ [18:52:51] Niya: can you check that out and try? [18:53:01] Niya: worked for me - build was fine, just failing tests :) [18:53:52] hey violetto! [18:58:38] yuvipanda: success! [18:58:48] Niya: whee! :) [18:59:14] brion: can you merge https://gerrit.wikimedia.org/r/#/c/114513/? Non dependent on other patches and hence not blocked by testwiki being done :) [19:00:15] yeah moment [19:04:10] yuvipanda: do you use eclipse or intellij or something else to develop with? [19:04:49] Niya: I use IntelliJ. brion does too, I believe [19:04:57] intellij yeah [19:04:59] Niya: I keep an eye on Android Studio, but it doesn't seem stable enough for me yet [19:05:01] Niya: what do you use? [19:05:09] never liked eclipse for android, it explodes too much :D [19:05:26] i often use eclipse, but it is so unhappy with the project D= [19:05:27] (03CR) 10Awjrichards: [C: 032] Handle situation when user registration is unknown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113281 (owner: 10MaxSem) [19:05:30] (03CR) 10Brion VIBBER: [C: 032 V: 032] Pick up android support library from appropriate place [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114513 (owner: 10Yuvipanda) [19:05:48] Niya: yeah, none of us have tried to use this with Eclipse, so I am guessing it will be a mess :( [19:05:55] Niya: how is Eclipse's maven support? [19:05:56] (it is pretty much like, this will never work! and i'm like, yeah but it does >_>) [19:06:12] (03Merged) 10jenkins-bot: Handle situation when user registration is unknown [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113281 (owner: 10MaxSem) [19:06:34] Niya: :) I started out trying eclipse, but am glad I quit that :) [19:07:00] Niya: you should try IntelliJ if you haven't! I need a lot of convincing to make my primary dev tool be one that's not totally open source, and IntelliJ makes the cut [19:07:02] yuvipanda: i'm not sure. i'm torn between trying to see if it can work and just going to intellj because "ain't nobody got time for that" [19:07:38] yeah, i do like intellj -- the community edition will work then? [19:07:43] (03CR) 10MaxSem: [C: 032] "!!!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114392 (owner: 10Awjrichards) [19:07:48] Niya: yup, community edition is more than good enough :) [19:08:00] yuvipanda: awesome =D [19:08:12] Niya: do try to document the steps - we can rewrite the README! :) I'll be able to help with any roadblocks on IntelliJ import as well [19:08:19] (03Merged) 10jenkins-bot: Ensure checkToggleView() fires at appropriate time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114392 (owner: 10Awjrichards) [19:08:33] Niya: the current README for IntelliJ is accurate-ish, but a lot of the steps just aren't necessary anymore. [19:09:06] yuvipanda: okay. yeah, i'll follow along and try to edit as i go [19:09:20] (03PS1) 10Awjrichards: Re-enable browser tests on enwiki for search-specialpages.feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114517 [19:09:23] yuvipanda: then i can brush up on my gerrit skills [19:09:32] Niya: :) have you used gerrit before? [19:10:19] yuvipanda: only a couple of times. i feel like i made a couple small patches for aokp at one point but i can't for the life of me remember what i did now x.x [19:10:28] Niya: :D [19:13:05] the new app looks really snazzy! and editing! [19:13:38] Niya: YES! So much better! :) [19:18:53] Niya: I'll need to spend some time making it work in 2.3 though [19:19:53] yuvipanda: are you thinking of something like abs? [19:20:04] Niya: we already use AppCompat for ActionBar [19:20:22] yuvipanda: ah, okay =D [19:20:23] yuvipanda: did something deployed since yesterday cause json results to come back formatted a bit differently? [19:20:33] mhurd: which results? [19:20:43] yuvipanda: search results [19:21:06] mhurd: oh, shouldn't have. why? [19:21:17] mhurd: if you are on testwiki, it is experiencing an outage now. enwiki should be fine [19:21:20] mhurd: what are you seeing? [19:23:28] yuvipanda: gonna poke around a bit more... could be my code - but something seems off... [19:23:54] mhurd: ah! right. let me know if anything's off and I'll poe the appropriate people [19:24:00] yuvipanda: what's நண்றி ? :) [19:24:06] aharoni: 'Thanks' ;) [19:24:09] yuvipanda: will do [19:24:14] aharoni: although I've a sinking feeling I got the second 'character' wrong [19:24:34] aharoni: also your last email didn't go to the list [19:30:07] yuvipanda: thanks / nevermind [19:30:15] aharoni: :) [19:30:33] aharoni: I've been trying to use it in appropriate contexts for a while now. Just that appropriate contexts are so rare. [19:33:37] yuvipanda: நன்றிwhich looks so close o.o [19:34:19] Niya: yeah, it is my native language and I still can't figure out where you use the one with two loops and where you use it with three. [19:34:38] they sound the same! at least to me. [19:35:02] yuvipanda: oh gosh XD i'd be hopelessly lost [19:35:35] Niya: heh, I am :) I remember trying to write my name in Tamil once and halfway subconsciously switched to writing in english. :D [19:35:36] yuvipanda: oh gosh, they do sound the same o.o [19:35:49] XD [19:35:54] yeah. people who love the language to bits tell me it is different but I can't make it out at all! [19:38:40] yuvipanda: i think that was the first time i've heard tamil spoken (thanks google translate) [19:39:13] Niya: :) The songs are beautiful! [19:41:35] yuvipanda: so the good news is that everything just worked in intellij! i'm warry of taking any of the error fixing out, unless it was stuff that's been changed in the code and so people shouldn't ever get it now(?) (specifically the dependencies error from Javascriptinterface) [19:42:15] yuvipanda: do you have a suggestion for something to listen to that i might find on, say, youtube? =D [19:44:28] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add a task to do pre-flight request for account creation + test [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114332 (owner: 10Yuvipanda) [19:46:23] (03CR) 10Brion VIBBER: [C: 032 V: 032] Separate captcha layout into own file [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114333 (owner: 10Yuvipanda) [19:48:27] (03CR) 10Brion VIBBER: [C: 032 V: 032] Refactor captcha handling into its own Handler [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114440 (owner: 10Yuvipanda) [19:48:51] brr, lost scrollback [19:48:53] stupid internet [19:49:31] Niya: yeah, we should take those out [19:49:38] Niya: the JavaScriptInterface stuff was fixec [19:49:40] *fixed [19:50:50] (03CR) 10Brion VIBBER: [C: 032 V: 032] Refactor out code that did non-empty validation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114444 (owner: 10Yuvipanda) [19:51:13] Niya: https://www.youtube.com/watch?v=YR12Z8f1Dh8 is what I was listening to a few mins ago. Fun and nice, and not 'fully' tamil. [19:51:27] yuvipanda: okay. i also added a tiny section about configuring logcat filters [19:51:37] Niya: \o/ sweet [19:51:57] Niya: you also don't need to setup java-mwapi manually anymore. That has been automated too [19:52:12] Niya: so most of the 'hairy' parts there were fixed. [19:53:21] (03CR) 10Brion VIBBER: [C: 032 V: 032] Don't pass title to RefreshCaptcha when Site would do [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114445 (owner: 10Yuvipanda) [19:54:30] yuvipanda: awesome. same for the "v4" errors? [19:54:37] Niya: yeah! [19:55:05] Niya: on a clean machine, mvn install with the appropriate params followed by an import into IntelliJ should 'just work' [19:55:08] and if not we should fix it :) [19:56:10] Niya: (re: Tamil) https://www.youtube.com/watch?v=OfDyd1vFTWc&list=PLL4wzxyi1ZDoD5ucW1sT2QwaSX-vL-c-D is the current playlist I'm listening to [19:56:36] yuvipanda: =D [19:58:10] yuvipanda: okay, so all that stuff at the top about updating javascript and svg is automatic and not needed. (like, i know *I* didn't do it) [19:58:18] yuvipanda: that's what you were saying? [19:58:51] Niya: oh no, those are only if you update the JS / SVGs - like, if you make an edit to the JS you need to do that. Same with the SVG - if you changed the icons you would do that. [19:58:59] Niya: unrelated to building the app itself. we should probably move them to the bottom [19:59:24] okay [20:07:58] there is one error that pops up in intellij. "Error when importing module '~apklib-android.support_compatibility-v7-appcompat_19.0.0' [20:08:24] Niya: yeah, but that doesn't seem to affect anything. I think it prevents it from stepping into code there, and perhaps in auto-generating variable names [20:08:44] yuvipanda: yeah. okay. [20:08:48] yeah it's missing the source for the module? but seems to build fine [20:08:56] brion: yeah, that's a debugging aid I think [20:09:15] be nice to fix it if we can but meh [20:10:30] "result": "success", [20:10:34] \o/ [20:10:36] hmm [20:10:47] let's make sure that creating an account also logs you in in future :D [20:10:54] brion: yeah, I'll be on it now. [20:11:17] (03CR) 10Brion VIBBER: [C: 032 V: 032] "wooo it works!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114508 (owner: 10Yuvipanda) [20:19:35] brion: thoughts on the captcha change? [20:19:55] yuvipanda: the case tweak? fine by me [20:20:02] brion: no, I mean the captcha tweak [20:20:04] existing api users should be roughly nil and you've already posted to the mailing list [20:20:12] hm which tweak is that then? [20:20:15] brion: when it is wrong, respond with a non-success response than [20:20:21] ah [20:20:22] (03PS2) 10MaxSem: Add $wgMFCollapseSectionsByDefault config var to allow disabling auto section collapse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113758 (owner: 10Brion VIBBER) [20:20:33] (03CR) 10MaxSem: [C: 032] Add $wgMFCollapseSectionsByDefault config var to allow disabling auto section collapse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113758 (owner: 10Brion VIBBER) [20:21:01] (03CR) 10jenkins-bot: [V: 04-1] Add $wgMFCollapseSectionsByDefault config var to allow disabling auto section collapse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113758 (owner: 10Brion VIBBER) [20:21:02] yuvipanda: should be doable [20:21:17] ughhhhhhhhhhhhhhhhhhhhhhh [20:21:23] brion: think you can take it up this week/sprint? :D [20:21:32] brion: then I won't have to implement the terrible 2 request solution [20:21:34] my dev wiki ceased to have any JS in Firefox [20:22:09] hehe ok [20:22:12] any ideas why this might be happening? [20:22:48] MaxSem: scap gone wrong, perhaps? :P [20:24:20] firefox is picky about mime types, double check there's nothing blocking the headers from load.php? [20:26:28] my head may explode, it is so loud in my house :( [20:27:12] the trick is that it doesn't even attempt to download scripts [20:31:28] (03PS3) 10MaxSem: Add $wgMFCollapseSectionsByDefault config var to allow disabling auto section collapse [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113758 (owner: 10Brion VIBBER) [20:32:20]