[00:07:20] kaldari, fix deployed [00:07:33] MaxSem: Thanks! [00:07:55] I'll test [00:09:06] MaxSem: Looks good [00:09:18] :) [00:24:22] (03PS3) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114389 [00:26:39] (03CR) 10Kaldari: [C: 032] Remove height: auto !important styles for .content img [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113475 (owner: 10JGonera) [00:27:17] (03Merged) 10jenkins-bot: Remove height: auto !important styles for .content img [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113475 (owner: 10JGonera) [00:27:53] (03PS5) 10Kaldari: Story 1628: Fix some of the mobile VE toolbar styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113496 [00:34:00] awjr: hey, not seeing bugello doing its job again [00:34:10] ruhroh [00:34:12] will look shortly tfing [00:34:14] er [00:34:16] tfinc [00:34:22] thanks [00:46:01] MaxSem: hey did you need me to look at anything for the lightning deploy? [00:46:05] I was invited [00:46:20] kenanwang__, kaldari verified it [00:46:37] ok cool! [00:46:41] (03PS4) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114389 [00:53:05] (03PS1) 10Kaldari: Fixing font size in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114672 [01:03:08] awjr: whats the thought on bugello ? [01:03:18] tfinc haven't gotten to it yet [01:03:21] ok [01:06:38] ok tfinc, im looking into bugello now [01:06:42] thanks [01:09:22] tfinc theres a stuck bugello jsub job from the 17th which is blocking bugello from running [01:09:28] lemme see if i can kill them [01:09:37] er actually i dont know how to do that [01:09:47] yuvipanda: MaxSem do you guys know how to kill jsub jobs on labs? [01:10:05] sorry, I don't [01:11:27] ah [01:11:29] qdel [01:12:30] ok tfinc, jobs are unstuck and looks like bugs are flowing again [01:12:36] yup. i see them now [01:12:41] awjr: what broke it? [01:12:45] * awjr shrugs [01:12:50] i haven't seen that before [01:12:58] there havent been code changes [01:13:02] maybe something funky on tool labs [01:13:20] there were two jobs stuck in the queue, one for apps, one for zero - both around the same time on the 17th [01:13:41] i dont really know much about jsub [01:14:33] tfinc i'll keep an eye on it over the next few runs, but i suspect it was something freakish and out of my control [01:14:41] thanks [01:23:15] "Nexus 6 release date Nears" [01:31:00] Reedy: i/o is in June [01:31:10] Yup [01:31:16] the'll line up close to that [01:31:23] mhurd: leaving in 30min [01:31:42] tfinc: sounds good [01:32:50] tfinc: bugello's run 4 times now on its own with no problem [01:32:58] great [01:53:09] (03PS2) 10JGonera: Add EditorApi#prependText [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114366 [01:53:11] (03PS2) 10JGonera: Refactor PhotoApi tests and error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114367 [01:53:13] (03PS1) 10JGonera: Use EditorApi in PhotoApi to add image to page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114681 [02:04:10] mhurd: packing up [11:01:24] (03PS1) 10Yuvipanda: Add repeat password textbox to create account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114726 [11:02:21] (03PS2) 10Yuvipanda: Add repeat password textbox to create account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114726 [11:23:04] (03PS1) 10Yuvipanda: Use saripaar for validation before submitting [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114730 [11:45:19] (03PS2) 10Yuvipanda: Use saripaar for validation before submitting [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114730 [11:47:31] (03PS1) 10Yuvipanda: Display errors inline in Login form as well [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114732 [11:57:53] (03PS1) 10Yuvipanda: Treat titles as HTML rather than text [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114733 [15:48:11] (03PS1) 10Yuvipanda: Handle user account creation errors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114750 [16:37:02] brion: yuvipanda do either of you have admin rights on the wikimedia repository in github? [16:37:22] i'd like to transfer my bingle repository to the org account [16:37:46] but according to https://help.github.com/articles/how-to-transfer-a-repository it looks like i need admin rights in wikimedia to do so [16:55:13] awjr: i mifhr lwmmw xhwxk [16:55:17] ugh ican't type today [16:55:40] hahaha [16:57:11] awjr: ok looks like i have to add you as an org admin? [16:57:13] let's see if i can do that [16:58:10] awjr: ok i've added you, see if it lets you transfer now [16:58:14] cool [16:59:25] ok brion i think it worked [17:00:29] brion: so to add maintainers - do i need to create a 'team'? [17:01:06] brion, #wikimedia-office [17:06:39] jgonera, #wikimedia-office [17:07:40] MaxSem, has it started yet? [17:07:45] yes [17:08:32] any URL to what Gabriel is talking about? [17:08:47] jgonera, https://www.mediawiki.org/wiki/Requests_for_comment/HTML_templating_library/KnockoutProposal [18:07:37] brion: around? [18:07:45] yo [18:07:55] brion: code review! :) [18:14:41] (03CR) 10Brion VIBBER: [C: 04-1] "It still lets me submit, and even register, if the passwords don't match. Should catch that pre-submit." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114726 (owner: 10Yuvipanda) [18:14:58] brion: that's the next patch. [18:15:03] brion: I used a validation library [18:15:04] :PPPP [18:15:27] (03CR) 10Yuvipanda: "That's in the next patch, using a library" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114726 (owner: 10Yuvipanda) [18:15:58] brion: standup! [18:17:08] (03CR) 10Brion VIBBER: "android-apt-compiler: /Users/brion/src/wiki/apps-android-wikipedia/wikipedia/gen-external-apklibs/android.support_compatibility-v7-appcomp" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114730 (owner: 10Yuvipanda) [18:17:46] brion: do a rebuild? [18:19:09] yuvipanda: hello! [18:19:18] my goldmine disappeared! [18:19:33] (03CR) 10Brion VIBBER: [C: 032 V: 032] "ok that compile error was temporary. works :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114730 (owner: 10Yuvipanda) [18:19:47] (03CR) 10Brion VIBBER: [C: 032 V: 032] "ok confirmed working" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114726 (owner: 10Yuvipanda) [18:23:40] vbamba: yeah, found that :) It should re-appear shortly. I created too many pages and they started paginating [18:25:24] okie =] [18:25:28] thank you [18:26:54] vbamba: gold mine should be back now [18:27:06] quiddity: http://chicken.wmflabs.org/wiki/Main_Page should have suffidcient links to test :) [18:30:13] tfinc: I sent you a new build [18:30:23] yuvipanda: thanks. i'll test adhoc today as i'm in and out of meetings [18:30:24] hmm Mac owners, how do you use vim if you don't have an ins key?:) [18:30:32] tfinc: yeah, sweet [18:30:37] also being distracted by mens olympic hockey final [18:30:39] MaxSem: why would I ever need INS with vim? [18:30:47] MaxSem: just use i! [18:30:50] to switch to insert mode [18:30:50] MaxSem: and esc [18:31:09] MaxSem: tapping 'i' also switches to insert mode :) [18:31:47] vbamba: can you verify that the page works now? [18:31:58] ewww [18:32:24] also, vim sucks:} [18:32:26] MaxSem: point of vim is to never have to use the arrow keys or somesuch. [18:32:38] MaxSem: heh. I've Vim keybindings for PHPStorm, IntelliJ and WebStorm. :D [18:32:45] perv [18:33:24] MaxSem: hehe [18:33:47] tfinc: do uninstall the old version before installing the new one [18:34:17] yuvipanda: still valid https://trello.com/c/zPXdBwCb/14-android-dev-version-searching-from-menu-doesn-t-dismiss-menu [18:34:21] also, using PhpStorm AND WebStorm????:P [18:34:37] tfinc: hmm, I've tried yesterday *and* today and can't reproduce them at all :| [18:34:43] yuvipanda: checking [18:34:57] still valid: https://trello.com/c/UTHnM5LQ/15-android-dev-version-changing-to-landscape-mode-i-lose-my-position [18:35:19] still valid: https://trello.com/c/EWYfk6l7/16-android-dev-version-no-edit-button-for-lead-section [18:35:28] still valid https://trello.com/c/fpJPb1nl/17-android-dev-version-when-i-m-logged-in-i-can-t-tell-who-i-m-logged-in-as [18:35:38] chicken chicken chicken [18:35:53] still valid: https://trello.com/c/nghezV1n/19-android-can-t-tap-w-after-search-query-has-been-entered [18:35:57] tfinc: I'm specifically interested in the crashes. [18:36:09] tfinc: since that's the ones I majorly fixed. [18:36:15] no point in me validating the rest as all the bugs thus far are still issues [18:36:21] tfinc: also can you tell me what you mean by "can't tap W" [18:36:38] yuvipanda: have you tried the steps i put in the bug ? [18:37:01] tfinc: yeah, and it opens for me. [18:37:17] doesn't for me. do we need to ship you a nexus4 ? [18:37:25] tfinc: oh, hmm. I see what you mean. they are hidden under the search term. [18:37:29] search results. [18:37:34] let me rewrite it. [18:37:45] so all of the bugs thus far are valid [18:37:46] tfinc: I was majorly concerned about the crash reports you sent me. [18:37:59] tfinc: and that is what I was trying to reproduce. apologies for not being clear. [18:38:26] yuvipanda: new crash report coming your way for on landscape change [18:38:33] wat. gaaah [18:39:10] tfinc: did you rotate it just once? many times? [18:39:23] I've twisted and turned it around multiple times and it's still fine. gaaaah [18:39:25] heisenbug [18:39:35] twice after some browsing [18:39:39] let me keep using it [18:39:46] ok [18:39:56] I'll trace through it again. [18:40:00] this is frustrating [18:40:21] more specifically . browse around 3-4 articles. scroll to section 3 or 4 and then do a landscape change [18:40:24] tfinc: thanks for doing the tests! I should've been clear that the things I weren't able to repro were the crashes, not the other ones. [18:40:28] tfinc: hmm, right. [18:40:38] second on landscape crash report coming your way [18:40:49] tfinc: I'm going to instrument them with more debug info and try it out. [18:40:51] yuvipanda: yes. that wasn't clear. i took that as the bugs and crashes [18:41:00] tfinc: yeah, sorry about that. [18:41:01] let me mail kenan to prioritize the bugs then [18:41:06] tfinc: ok [18:42:35] yuvipanda: qq [18:42:48] do you know if any changes made from last night are merged onto chicken [18:43:54] vbamba: i can check! [18:43:55] moment [18:46:10] vbamba: I just updated it to the absolute latest code, merged or unmerged. [18:46:40] vbamba: so new ones since yesterday are contrast improvements, 'increase space between link and popup' and some changes to the triangle/pokey thing [18:47:36] yeah, they dont reflect in the current build [18:47:43] maybe I shoudl do a hard refresh? [18:48:11] vbamba: yeah. I just updated it. [18:49:23] (03PS1) 10Yuvipanda: Hide search results if drawer is opened [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114767 [19:02:17] brion: hey! [19:02:19] brion: prio! [19:02:39] moment [19:02:50] this has been a busy irc meeting morning :D [19:05:05] tfinc hey I went up to r61 heading back down [19:05:43] kenanwang__: gotcha. i changed us down to r31 so that we wouldn't have to travel as much. sorry about that [19:08:14] https://www.mediawiki.org/wiki/Q3_mobile_app_timeline [19:15:40] jgonera: about that breakage yesterday, did the fix get into master? I'm seeing the same sort of issue today on beta labs https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/lastCompletedBuild/testReport/ [19:16:13] chrismcmahon1, the CSS-related breakage? [19:16:54] jgonera: yes, here is a screen shot from just now: https://saucelabs.com/jobs/24d4cb0af5de423b9b705735180eafb0 [19:17:24] chrismcmahon1, the fix has been merged. maybe beta labs or caching issues? [19:17:42] jgonera: thanks, just checking. rather looks like caching now you mention it [19:23:34] yuvipanda: i could get one of these http://www.huehd.com/ to deal with discussion like today [19:23:46] tfinc: yeah, could be useful. [19:23:51] yuvipanda: have you seen others that would fit this ? [19:24:19] awjr: heads up that were looking at adjustable cameras to show remote staff whats draw in a journal or on paper [19:24:41] tfinc: I've a friend who just uses a regular webcam attached to hangout on a separate machine, but that was a while ago [19:24:52] cool tfinc [19:25:03] tfinc: but that was terrible resolution. this seems better :) [19:25:15] tfinc: any paticular model(s)? [19:25:25] awjr: scroll up [19:25:31] http://www.huehd.com/ [19:25:50] tfinc: I could reproduce the crash now. I had Android setup to aggressively clear memory, which was masking this. [19:26:03] tfinc: I'll get that fixed, now that I can repro it [19:26:59] wow tfinc that looks pretty cool [19:28:06] awjr: have you seen others ? [19:28:16] no tfinc, but i haven't really looked [19:28:28] do you think that would work for whiteboards as well? [19:28:58] tfinc: heh, this is frustrating :) [19:29:17] tfinc: you guys just dropped video and audio. [19:29:18] tfinc: back now. [19:29:21] it looks like there may be some incompatibility issues with mac - or at least some of the fancier features (eg zoom) only works with windows [19:35:48] yuvipanda: here is another option http://www.amazon.com/IPEVO-Point-View-USB-Camera/dp/B002UBPBTC/ref=sr_1_1?ie=UTF8&qid=1393011304&sr=8-1&keywords=usb+camera [19:35:59] first one looks simpler [19:36:43] yeah [19:40:29] dr0ptp4kt, is Kaldari in the office? [19:40:54] jgonera: kaldari mentioned during our kickoff on monday that he'd be out today [19:41:04] oh, right, I forgot [19:41:05] thanks [19:41:08] np [20:00:13] yuvipanda: hey! [20:00:25] Can you run a quick check for me? [20:00:34] I definitely can't see any changes from last night [20:00:54] jgonera: sorry for delay, didn't see him. ah, i see awjr responded. what a guy. [20:01:03] \o/ [20:05:03] vbamba: which change exactly are you looking for? [20:08:47] brion: ping [20:08:54] brion: I'll be off in 20. Code Review plz? [20:15:29] mhurd: testflight acquired by appl!?! [20:15:42] yuvipanda: ? rly? [20:15:56] mhurd: http://techcrunch.com/2014/02/21/rumor-testflight-owner-burstly-is-being-acquired-by-apple/ [20:16:04] huh [20:16:16] interesting [20:16:57] yuvipanda: going to grab some foooood [20:17:03] mhurd: ok [20:17:06] I'll be out shortly [20:17:19] k. have a good night / weekend! [20:17:33] mhurd: you too! [20:41:31] * yuvipanda gently pokes brion again [20:49:01] moment [20:49:05] was lunching :) [20:56:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] Display errors inline in Login form as well [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114732 (owner: 10Yuvipanda) [21:03:27] (03PS1) 10Yuvipanda: Handle back button properly when overlay is open [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114777 [21:03:39] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Note that the ToC view needs to be adjusted for this as well." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114733 (owner: 10Yuvipanda) [21:06:50] brion: good catch! Pushed up patch to fix [21:06:55] (03PS1) 10Yuvipanda: Handle minimal HTML in headings in ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114779 [21:06:57] woot [21:09:43] (03CR) 10Brion VIBBER: [C: 032 V: 032] Handle user account creation errors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114750 (owner: 10Yuvipanda) [21:10:47] oh nice, pitivi's running a fundraiser for pushing it to 1.0 http://fundraiser.pitivi.org/ [21:11:04] the current dev version (not the POS that's in latest Ubuntu distro) is actually mostly usable :D [21:11:21] i've been using it for the demo vids [21:12:58] (03CR) 10Brion VIBBER: [C: 032 V: 032] "This doesn't hide the "No results found" banner if the search didn't come up with results. Can add that later." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114767 (owner: 10Yuvipanda) [21:15:07] (03CR) 10Brion VIBBER: [C: 032 V: 032] Handle back button properly when overlay is open [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114777 (owner: 10Yuvipanda) [21:16:18] (03CR) 10Brion VIBBER: [C: 032 V: 032] Handle minimal HTML in headings in ToC [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114779 (owner: 10Yuvipanda) [21:18:21] (03PS5) 10Brion VIBBER: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114389 (owner: 10Dr0ptp4kt) [21:19:46] (03CR) 10Brion VIBBER: [C: 04-1] "I see references to RandomArticleIdTask etc which appear to be missing, so it doesn't build." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114389 (owner: 10Dr0ptp4kt) [21:20:08] brion, argh, sorry, hang on [21:20:10] dr0ptp4kt: did some files fail to make it into the commit? [21:20:13] no worries :) [21:20:15] it happens [21:20:35] brion, got sloppy not using git status w/ ios tooling doing git adds for me. [21:20:46] hehe [21:20:49] yeah i always do a git status [21:20:54] never know what gets left out :) [21:21:49] do git commit -p!!! \o/ [21:22:08] huh, git status doesn't say anything...brion, i'll backup those files real quick, pull down your rebase, add, then go [21:22:34] kk, sleep for realz [21:22:38] thanks for the merges, brion [21:26:33] dr0ptp4kt: ok... [21:26:38] (03PS1) 10Yuvipanda: Persist Account creation status info across rotates [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114783 [21:26:39] brion: final patch! ^ [21:26:49] "sleep for reals" my ass [21:26:51] :DD [21:26:55] hehe [21:27:07] it's hard to go to sleep with uncommited changes [21:27:13] (03PS6) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114389 [21:28:55] (03CR) 10Brion VIBBER: [C: 032 V: 032] Persist Account creation status info across rotates [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114783 (owner: 10Yuvipanda) [21:29:08] (03PS7) 10Dr0ptp4kt: WIP: Add Wikipedia Zero detection and GUI features. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114389 [21:29:42] dr0ptp4kt: woo it builds now :D [21:29:47] lemme take a quick pass through [21:30:08] * dr0ptp4kt wipes sweat from brow [21:32:56] MaxSem, want to work on the minifier now? [21:33:13] jgonera, wheee [21:33:41] So. [21:33:49] you need https://gerrit.wikimedia.org/r/#/c/74293/ for core [21:34:07] and then in LS: require_once( "$IP/extensions/Minifier/Minifier.php" ); [21:34:07] $wgMinifierHosts = array( 'localhost:8888' ); [21:34:19] where was the repo again? [21:34:30] extensions/Minifier [21:35:15] the server is run with node server/app.js [21:35:43] (03PS1) 10Yuvipanda: Hide 'No Results found' message as well when hiding search results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114785 [21:36:50] MaxSem, require Minifier.php too, right? [21:37:02] ^^^ [21:37:09] oh [21:37:10] sorry [21:37:44] dr0ptp4kt: ok it's not exploding for me, this is good sign. :D i say we merge it now and do more explicit testing of the zero side in a bit once we have a better idea how to do that regularly [21:38:14] MaxSem, do I have to run update.php? [21:38:22] no [21:38:46] MaxSem, getting "A database query error has occurred. This may indicate a bug in the software." [21:38:49] investigating... [21:39:04] that's unrelated core updates [21:39:06] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Doesn't explode. :D We'll test the zero side of things more aggressively after some more polish & checkins with adam about how to actually" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114389 (owner: 10Dr0ptp4kt) [21:39:27] well, what do I do about it? should I rebase your patch? [21:39:30] congrats dr0ptp4kt you're no longer on the rebase train :D [21:40:26] brion: i sent up one more patch [21:40:34] brion: thanks! i'll figure out something for testing. yuvi suggested some puppet role definition. once we get ip addresses unfrozen, we'll actually be able to do real user testing on the production infra. granted, for the bdd stuff, and to some extent even a more replete basic unit test layout (where possible) test infra would be nicer, though [21:40:44] * brion smothers zz_yuvipandaaaaa with a pillow [21:40:48] ssssh.... sleep now... [21:40:52] yesss [21:41:16] (03CR) 10Brion VIBBER: [C: 032 V: 032] Hide 'No Results found' message as well when hiding search results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114785 (owner: 10Yuvipanda) [21:41:47] MaxSem, do you know how to get around those DB errors? [21:41:52] I'm not getting them on master [21:42:03] pull master and you will;) [21:42:16] brion, for the time being, we'll need to have you over for pizza so you can use the one ip that got into the frozen ip set before the freezing :) [21:42:28] Now trying to recall where I stopped last time:) [21:42:31] \o/ [21:43:56] brion, one more question: those dudes in africa were hoping to get a test build with the w0 stuff baked in. we have anything slated for before the end of february on releasesDOT that would have that? [21:44:51] dr0ptp4kt: do we have a build scheduled for next wednesday? or the one after that... i get so lost when days shift :) [21:44:59] anyway i can easily make one out of band [21:45:03] brion, hardy har, good point [21:45:14] brion, i can wait :) [21:45:44] spiff. let's give it a couple days for polish and other fixes and make one wednesday whether that's our schedule or our halftime :) [21:46:12] MaxSem, ugh... [21:46:17] thank you, teacher. [21:46:24] er....master [21:46:25] jgonera, ? [21:47:01] MaxSem, ok, so why is your patch based off a broken master? ;) [21:47:24] why broken? [21:47:35] well, I get DB errors both with latest master and your patch [21:47:53] my patch does not introduce any DB interactions [21:48:03] however, core changes regardless of it [21:48:06] MaxSem, ok, nevermind, I see, fixed [21:49:35] MaxSem, "Error: ENOENT, no such file or directory 'settings.json'" [21:49:40] what should I put in there? [21:49:52] settings.json.sample [21:51:04] hm, so it seems to work [21:51:40] MaxSem, didn't you say it didn't work? [21:52:10] still unsure, was long ago [21:52:23] now it seems not to compress at all [21:54:02] MaxSem, it does for me [21:54:45] I mean, JS on the page is compressed, not sure if by your minifier ;) [21:55:16] purge your caches:) [21:56:01] MaxSem, I have browser cache disabled [21:56:01] jgonera, btw: you can try minification by hand by going to http://localhost:8888/ [21:56:20] RL cache is stored in memcached or APC or DB [21:56:37] ah, right [21:56:39] "500 Error: /home/jgonera/www/extensions/Minifier/server/views/layout.jade:1 > 1| doctype 5 2| html 3| head 4| title= title `doctype 5` is deprecated, you must now use `doctype html`" [21:57:07] umm, let me update my modules [21:57:56] aha, now see it too [21:58:06] MaxSem, just had to do what it says [21:58:15] guess we should pin versions once it gets stabler [21:58:58] yep [22:01:08] https://gerrit.wikimedia.org/r/114790 [22:03:07] hmm, next problem: try minifying invalid JS [22:03:48] there's try-catch but it doesn't work so request eventually times out [22:05:27] ok, wait, first thing first, how do I purge RL cache? [22:05:43] I remember I did that once in a shitty hacky way, but maybe there's a better way? [22:05:46] MaxSem, ^ [22:10:24] jgonera, depends on your $wgMainCacheType [22:10:49] restart memcached or TRUNCATE table objectcache; [22:14:24] MaxSem, restarted memcached ($wgMainCacheType = CACHE_MEMCACHED;) and I still get minified JS, judging by one-letter var names, that's minified by UglifyJS [22:14:28] let me double check [22:15:41] yep, it definitely works for me [22:15:57] if I disable your extension it's minified in a different way [22:16:39] 108KB vs. 143KB in the request I'm comparing [22:16:59] (I'm loading the mobile version) [22:17:27] uhhh [22:18:26] it doesn't work for you? [22:18:37] disabled all caches... [22:21:27] must be browser cache fooling me [22:22:21] in Chrome you can disable it permanently if the inspector is open [22:22:28] hah. works indeed [22:22:32] ;) [22:22:46] I do get a timeout on erroneous JS [22:23:48] brb [22:42:53] (03PS1) 10Mhurd: Fixes for nav bar night mode for iOS 6. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/114889 [22:43:14] brion: ^ stuff and things! [22:44:18] \o/ [22:44:46] (03PS1) 10Zfilipin: QA: Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114890 [22:49:55] MaxSem, I'm back, are you working on the Minifier now? [22:50:01] yep [22:50:09] the timeouts or something else? [22:51:55] jgonera, just committed https://gerrit.wikimedia.org/r/114891 [22:55:39] MaxSem, does it fix anything? the timeout is still there [22:55:59] MaxSem, you know what I would really like to see there though? ;) [22:56:10] ? [22:56:14] tests [22:57:04] booring [22:57:07] MaxSem, I'll get more familiar with the codebase and we can work on it again next week, does it sound OK? [22:57:09] hah [22:57:13] not really [22:57:15] yep [22:57:22] and JS has some nice testing tools [22:57:33] but I guess we'd use QUnit to stay consistent [22:57:37] one question [22:57:51] I see you're using the cluster module, but the docs says it's experimental [22:58:09] do you know if parsoid handling workers in the same way? [22:58:14] that's ok - half of node is so [22:58:20] haha [22:58:41] well, if it's experimental even by node's standards, then it should be concerning, right? [22:59:45] ok, Parsoid is also doing that and it hasn't exploded so I guess it's fine [23:00:17] where's parsoid service residing now? it not a subdirectory of the extension anymore:P [23:00:27] nope, there's a separate repo [23:00:28] wait [23:00:58] ssh://USER@gerrit.wikimedia.org:29418/mediawiki/services/parsoid [23:01:55] thanks [23:02:24] (03CR) 10Zfilipin: "All MobileFrontend Jenkins jobs will fail until this commit is merged:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114890 (owner: 10Zfilipin) [23:02:36] (03PS2) 10Mhurd: Fixes for nav bar night mode for iOS 6. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/114889 [23:02:46] brion: ^ small amendment [23:03:28] ok [23:11:55] jgonera, do core qunit tests all pass for you atm? [23:12:12] let me see [23:13:12] I see 3 tablesorter failures [23:15:44] wow, they are slow as hell... [23:16:10]