[03:11:12] Are there any android application projects expected to be taken up at gsoc this year? [05:33:14] hey Niya. [05:33:24] sorry, was away. [05:33:50] oh, no worries =D [05:34:02] i asked and then i realised it was the weekend XD [05:36:05] Niya: heh :) Was out playing ingress [05:37:03] =D [05:42:16] Niya: hmm, I think we only need to do setTypeFace in one of the constructurs, and the others will probably call that [05:42:27] Niya: I was too lazy to find out which one :D [05:43:59] Niya: I also messed up naming. Some of them are Stylized* and some are Styled* [05:44:02] next week i'd like to pick your and brion(?)'s brain about the app. // ah, okay XD yeah, i *feel* like since it uses the xml to do it android probably always calls the one but idk x.x [05:49:27] Niya: yeah, i'll look at the source to figure it out [05:52:50] yuvipanda: okay~ [05:53:41] Niya: from http://grepcode.com/file/repository.grepcode.com/java/ext/com.google.android/android/1.5_r4/android/widget/EditText.java, I think it's ok if we put it just in the constructor with the three params [05:59:30] yuvipanda: *nod* i wanted to do a similar thing to them, using the this() syntax to chain the constructors together so all the code just had to be in the one, but, in the app, the second constructor (or first with only a context?) was being called [06:00:01] yuvipanda: and it was breaking things (since i didn't know what parameter to use for defStyle) [06:00:08] Niya: ah, hmm, right [06:00:16] Niya: that's a good thing about android, we can always peek at the source :) [06:01:40] yuvipanda: yeah. and that's what i did, but what they do, i think that com.android.internal stuff is protected or ... not exposed? maybe i just had a brain fart when i tried to duplicate it [06:02:02] Niya: nah, they are on the repo. grepcode.com is pretty good at finding it :) [06:02:22] Niya: I will merge this one, I guess we can have another patch fixing the class names and then one preventing the duplication [06:03:09] (03CR) 10Yuvipanda: [C: 032 V: 032] "Wooo! :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/114929 (owner: 10Nicole) [06:03:12] Niya: \o/ merged :) [06:03:13] thanks [06:03:22] \o/ [06:03:37] oh, i seriously did just brain fart. XD [06:03:58] i've got another thing i'm working on which just has a bunch of little cleanup stuff [06:04:20] so i could add the rename/constructor stuff, if you think that'll work? [06:04:47] Niya: yeah, should. [06:04:59] yuvipanda: a lot of it is just calling the wikipedia-zero stuff with the class name rather than an instance variable, since they're static methods. [06:05:31] yuvipanda: things of that nature. mostly interesting so i get to peek at a lot of code XD] [06:08:24] yuvipanda: which do you prefer, anyway? "Styled" or "Stylized" since it's split 50/50 right now XD [06:08:54] Niya: Styled [06:09:06] yuvipanda: okay =D [06:15:52] Niya: the code isn't too well documented, mostly because I'm the only person doing most of it :( Do poke me if something seems fishy [06:16:05] the zero code is the only thing I haven't checked too much [06:16:19] yuvipanda: *nods* [06:16:39] Niya: I should hook this into our continuous integration system [06:17:20] yuvipanda: the big things i have questions about are lifecycle stuff. a bunch of behaviors are sort of unexpected? [06:17:58] Niya: the lifecycle code is a mess, I need to get that sorted out [06:18:05] yuvipanda: oh, yeah =D i wanted to try and compile with more thorough lint checks but i'm not very good with maven x.x [06:18:48] Niya: what weird behaviors? [06:19:02] yuvipanda: okay. yeah, then i'll do a little bit more reading/testing things in the code, and then i'll be better prepared to chat about stuff. [06:19:09] Niya: ok! :) [06:19:27] yuvipanda: things like, search, click on a search results, and then hit back, and it exits the app rather than going back to the search results [06:19:56] yuvipanda: actually, almost all of the "odd" behaviour is related to back button presses. XD [06:20:19] yuvipanda: i'm *that* user who's like, oh that was neat *back* [06:20:44] Niya: hmm, so the search stuff and the pages handle back presses by themselves, and so might have weirdish behavior now and then [06:21:31] Niya: hmm, so if I am looking at a search result, then tap the result, and then see it, and tap back, I don't know if I'd expect to see the search result [06:23:16] yuvipanda: oh? hm. i think the reason i think of it like that is like, say i look up "nicole", and i get a bunch of results who are singers. if i tap one, and it's not the one i wanted, i'd think to hit back and try the next result down? [06:24:21] Niya: hmm, true. but if I were reading about say, 'Stained glasses of Europe', search for 'Renaissance', read that article, and then tap 'back', I'd expect to go back to ' Stained glasses of Europe', no? [06:24:33] Niya: matches what happens with a browser too. hitting back doesn't get you to the addressbar [06:24:54] Niya: but one of the things we can do is to show the search results if I tap on the searchbar. [06:25:11] Niya: so that way if you want to try the next one, you can just tap the search bar again and get it [06:25:57] yuvipanda: ah *nods* that is true... hmm... [06:27:33] yuvipanda: i think what it is for me is that, before i open a page, and it's just the search bar, i think of the search results *as* my page [06:28:19] yuvipanda: because, as you say, after you go to a page, search, and click a result, the expected result of pressing back is to go to the previous page [06:29:41] yuvipanda: eventually is it going to show a wikipedia like front page when loading, with news, featured article, etc...? [06:30:33] Niya: yeah, the designers are working on something [06:31:51] yuvipanda: okay. i think, now that you've explained that scenario, that's the sort of oddity in my mind, so that will probably be cleared up [06:33:20] yuvipanda: the other thing, off the top of my head, is exiting the app and coming back doesn't restore the state. (so if i'm reading about cats, press back on mistake, i have to search and load the page again) -- i'm guessing that's just something that hasn't been gotten to yet [06:34:32] yuvipanda: oh, and there's a specific situation... search for an article, open it, tap on the action bar icon to pop out the drawer, then press back. i expect the drawer to close, but it ends up exiting [06:34:42] Niya: ah, yeah. that is a bug [06:35:14] Niya: and the 'resume' behavior when you fully exit and come back is undecided yet. Would be done with the 'start page' [06:35:33] yuvipanda: okay =D [06:53:34] Niya: the tests don't all pass either. I need to figure that one out. [06:57:32] yuvipanda: did you see my email that acra composed in part? about the javascript hook method thing? [06:58:11] Niya: yeah :) That happens when an image fails to load. It tries to find a local variant, but the code that did that was synchronous JS. I killed all sync JS stuff a while back, so I need to replace it with async stuff [06:58:22] Niya: I could've stubbed it and made it silently fail, but having itbe louder feels better [07:00:11] yuvipanda: ah, okay. =)