[04:59:08] <grrrit-wm>	 (03PS1) 10Nicole: Small fixes/cleanup [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115101 
[08:00:34] <grrrit-wm>	 (03PS1) 10Yuvipanda: Add task to get a preview + tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115115 
[08:04:53] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032 V: 032] "Nice catches! Thanks for the patch! :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115101 (owner: 10Nicole)
[08:05:17] <grrrit-wm>	 (03PS2) 10Yuvipanda: Add task to get a preview + tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115115 
[09:19:46] <Niya_>	 zz_yuvipanda: oh~ so many passing int tests! =D
[10:03:25] <zz_yuvipanda>	 Niya_: hey! :)
[10:03:33] <YuviPanda>	 Niya_: I think there's a couple that are failing. I need to check
[10:03:37] <YuviPanda>	 Niya_: I merged your patch! Thanks :)
[11:11:56] <grrrit-wm>	 (03PS1) 10Yuvipanda: Fix crash when rotating phone with multiple pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115136 
[13:40:45] <grrrit-wm>	 (03PS1) 10Yuvipanda: Add 'preview' functionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115158 
[13:41:47] <grrrit-wm>	 (03PS2) 10Yuvipanda: Fix crash when rotating phone with multiple pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115136 
[13:41:49] <grrrit-wm>	 (03PS2) 10Yuvipanda: Add 'preview' functionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115158 
[13:41:51] <grrrit-wm>	 (03PS3) 10Yuvipanda: Add task to get a preview + tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115115 
[13:41:53] <grrrit-wm>	 (03PS1) 10Yuvipanda: Cleanup webviews when we no longer require them [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115159 
[14:19:46] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 032] Using @custom-browser Cucumber tag instead of @user_agent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113776 (owner: 10Zfilipin)
[14:19:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Using @custom-browser Cucumber tag instead of @user_agent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113776 (owner: 10Zfilipin)
[16:49:54] <YuviPanda>	 hey brion
[17:54:28] <Niya_>	 YuviPanda: yeah, for me the abuse filter test is failing when i checked last night. (and sure =)
[17:56:00] <YuviPanda>	 Niya_: yeah, I think that fails because on the server, if you trigger more than 5% or somesuch number, the filter gets disabled 
[17:56:08] <YuviPanda>	 and needs to be re-enabled later on
[17:56:14] <YuviPanda>	 so if enough people ran those tests... :)
[17:56:41] <Niya_>	 ahha! that makes sense.
[17:57:05] <YuviPanda>	 Niya_: do the others pass?
[17:57:18] <YuviPanda>	 Niya_: I need to figure out a way to do the login one properly. username and password, ugh
[17:58:27] <Niya_>	 YuviPanda: i haven't tried editing the abusefilter one to stop it from throwing (or looking at the script to continue if the process crashes)
[17:58:45] <Niya_>	 YuviPanda: for that one, i ended up just putting in my actual credentials >_>
[17:58:47] <YuviPanda>	 Niya_: ah, right.
[17:58:58] <YuviPanda>	 Niya_: yeah, I do that too. 
[18:00:18] <Niya>	 YuviPanda: what would be cool is to have the login info in a .gitignore file so we can set it (override it?) once and then not worry about it
[18:00:47] <YuviPanda>	 Niya: yup! But need to not have it in a res/* so that it will compile without it
[18:01:24] <YuviPanda>	 Niya: I found out after a while that you can't .gitignore a commited file to just ignore further changes
[18:01:53] <Niya>	 YuviPanda: yeah, i was afraid of that =(
[18:04:07] <YuviPanda>	 Niya: yeah. 
[18:04:15] <YuviPanda>	 Niya: I merged your patch! :)
[18:05:46] <Niya>	 YuviPanda: i saw! thanks \o/
[18:05:50] <kenanwang__>	 Hey awjr sorry I'm late stuck in traffic
[18:11:35] <awjr>	 kenanwang__: ping me when you're at a place where you can more easily go over the bugs
[18:12:55] <jgonera>	 kaldari, abusefilter in uploads has 5 patches, starts with this one: https://gerrit.wikimedia.org/r/#/c/114366/ I'd be grateful for review today if you have time
[18:13:07] <jgonera>	 anything from your patches you want me to start with?
[18:13:10] <kaldari>	 ok
[18:13:30] <kaldari>	 jgonera: https://gerrit.wikimedia.org/r/#/c/113496/
[18:13:36] <kenanwang__>	 awjr I'm looking now
[18:13:56] <YuviPanda>	 MaxSem: ping?
[18:14:02] <kaldari>	 jgonera: and https://gerrit.wikimedia.org/r/#/c/114672/
[18:14:05] <MaxSem>	 pong
[18:14:52] <kenanwang__>	 1722 won't fix
[18:15:33] <brion>	 standup?
[18:17:27] <kenanwang__>	 responded to 1722 awjr let's backlog
[18:17:45] <awjr>	 kk
[18:21:39] <YuviPanda>	 MaxSem: can you give me a  very rough estimate of https://bugzilla.wikimedia.org/show_bug.cgi?id=61704
[18:21:47] <YuviPanda>	 MaxSem: like, 'days', 'weeks', 'months'?
[18:22:13] <MaxSem>	 days?
[18:22:19] <YuviPanda>	 MaxSem: hmm, ok.
[18:22:27] <MaxSem>	 if htere were a card and it were priorized;)
[18:22:37] <YuviPanda>	 MaxSem: of course :) I'll get that happening :)
[18:22:44] * YuviPanda  pokes awjr

[18:22:56] * awjr  pokes YuviPanda back

[18:23:11] <YuviPanda>	 awjr: can you help make a card for https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 and can we steal some of MaxSem's time for it?
[18:24:28] <YuviPanda>	 awjr: I just talked to kenanwang__ on standup, he's ok with it too :)
[18:24:36] <brion>	 wheee stealing time
[18:24:39] <awjr>	 YuviPanda: you read my mind
[18:24:44] <brion>	 ok heading into the office, see y'all shortly
[18:24:50] <awjr>	 YuviPanda: i'll create the card but let kenanwang__ prioritize it accordingly
[18:24:51] <YuviPanda>	 awjr: can you make the cards? :D
[18:24:53] <YuviPanda>	 awjr: sure!
[18:24:57] <YuviPanda>	 awjr: I'll poke him and make sure he does
[18:26:01] <awjr>	 YuviPanda kenanwang__ https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1725
[18:26:47] <kenanwang__>	 got it
[18:26:58] <kenanwang__>	 next iteration yes/
[18:26:58] <kenanwang__>	 ?
[18:27:47] <kenanwang__>	 awjr just finished other standup back to bugs
[18:27:57] <awjr>	 thanks kenanwang__ - timing on the card is up to you
[18:28:42] <YuviPanda>	 kenanwang__: sooner the better! :)
[18:34:21] <MaxSem>	 ugh, this bisect makes no sense
[18:40:12] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] Add EditorApi#prependText (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114366 (owner: 10JGonera)
[18:43:41] <kenanwang__>	 awjr done with bugs
[18:43:47] <awjr>	 awesome thanks kenanwang__
[18:46:44] <grrrit-wm>	 (03CR) 10Kaldari: [C: 04-1] "Please add some of your commit summary explanation of the error conventions to the file comments in PhotoApi.js. This explanation would be" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114367 (owner: 10JGonera)
[18:47:58] <violetto>	 kenanwang__ mhurd i added the video i sent to yuvi this morning
[18:48:06] <violetto>	 to the trello card
[18:51:05] <mhurd>	 violetto: that looks cool!!
[18:54:25] <flyingclimber>	 YuviPanda: if you can get me that build before 3pm local then i can try it out on pubs trans to my appointment 
[18:55:21] <YuviPanda>	 tfinc: I already sent you one
[18:55:29] <YuviPanda>	 tfinc: can you just check now if it crashes yet?
[18:55:31] <YuviPanda>	 s/yet/still/
[18:56:16] <YuviPanda>	 kenanwang__: sent you a build too
[18:58:47] <violetto>	 mhurd: ya!
[18:59:30] <YuviPanda>	 violetto: this is the one with the talk thing too, right?
[18:59:38] <violetto>	 YuviPanda: yeah
[18:59:43] <YuviPanda>	 violetto: \o/
[19:00:11] <tfinc>	 YuviPanda: off to a good start. no crashes yet
[19:00:25] <tfinc>	 i'll resume testing in the afternoon
[19:00:30] <YuviPanda>	 tfinc: sweet :)
[19:00:39] * MaxSem  bashes his head against the wall

[19:01:38] <MaxSem>	 I tried repeating a bisect, but it both times came up that S60 was broken by https://gerrit.wikimedia.org/r/#/c/106315/
[19:01:45] <MaxSem>	 FFFFFUUUUUUUU
[19:02:02] <tfinc>	 YuviPanda: a good sign of it not crashing is me looking at the clock and seeing that ive gone through 5 levels of wikipedia sine my first search result and i just noticed the tiem
[19:02:02] <YuviPanda>	 oh wow
[19:02:04] <tfinc>	 time*
[19:02:09] <YuviPanda>	 violetto: :)
[19:02:10] <YuviPanda>	 err
[19:02:11] <YuviPanda>	 tfinc:  :)
[19:03:13] <violetto>	 YuviPanda: proof you talk to me too much
[19:03:30] <YuviPanda>	 violetto: heh, there is no such thing as a dev talking to the designer too much :P
[19:03:42] <YuviPanda>	 violetto: if you prefer, I can setup meetings for you instead :D
[19:03:59] <violetto>	 YuviPanda: you can set up all the meetings you want, i just won't be in it 
[19:04:03] <violetto>	 YuviPanda: ;P!
[19:04:12] <YuviPanda>	 violetto: :D
[19:05:26] <tfinc>	 YuviPanda: all good things come to an end. not crash but the app is now frozen mid scroll 
[19:05:43] <YuviPanda>	 tfinc: how many pages did you get to?
[19:05:51] <YuviPanda>	 tfinc: and what page is this?
[19:05:53] <tfinc>	 20-25
[19:06:24] <YuviPanda>	 tfinc: switch to another app and tell me if that feels 'slow'?
[19:06:31] <YuviPanda>	 I will have to spend some time doing perf stuff
[19:06:40] <tfinc>	 YuviPanda: .. and it recovered 
[19:06:55] <YuviPanda>	 tfinc: hmm, go a few more artciles forward, see if it freezes still
[19:07:58] <tfinc>	 YuviPanda: it "feels" sluggish when i browse japanese wikipedia articles 
[19:08:15] <YuviPanda>	 tfinc: right. scroll stutters, tapping things feels weird?
[19:08:28] <tfinc>	 YuviPanda: yeah, just a little
[19:08:35] <tfinc>	 its very slight 
[19:08:49] <YuviPanda>	 tfinc: yeah, the fix for the crashes reduced performance by a bit. I need to fix that.
[19:09:07] <YuviPanda>	 tfinc: however, for now, I figured non-crashy is better than fast but crashy
[19:09:34] <tfinc>	 YuviPanda: fast but crashy is useless 
[19:09:38] <YuviPanda>	 tfinc: yup
[19:09:42] <tfinc>	 crash prone*
[19:09:56] <YuviPanda>	 tfinc: how is the japanese character rendering?
[19:10:11] <YuviPanda>	 tfinc: the bug about ToC not being visible on 'back' pages should also be fixed now
[19:11:47] <violetto>	 kenanwang__: i'd love to show you what's happening with the prototype so far! if you have time im on the other side
[19:12:39] <kaldari>	 awjr: I can no longer close any card previews in Mingle (tried in both Firefox and Chrome). Have you noticed this problem as well?
[19:21:11] <YuviPanda>	 mhurd: btw, violetto just tried out previewing on the android build. was apparently not 10s but faster
[19:21:43] <mhurd>	 on wifi?
[19:21:51] <YuviPanda>	 violetto: ^
[19:22:14] <YuviPanda>	 mhurd: for me on wifi it's about 5-6s, about 7s on (good) 3G
[19:22:22] <YuviPanda>	 but not bad, I thought it'll be a lot worse
[19:24:50] * YuviPanda  pokes violetto

[19:25:07] <tfinc>	 YuviPanda: when you updated the WLM app as a volunteer did you rev https://play.google.com/store/apps/details?id=org.wikilovesmonuments ?
[19:25:31] <tfinc>	 i have someone from WMF RU asking me to do some work on it and i'm going to let him know the state of it
[19:25:34] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix crash when rotating phone with multiple pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115136 (owner: 10Yuvipanda)
[19:26:41] <YuviPanda>	 tfinc: the keys for that are with WM NL
[19:26:59] <YuviPanda>	 effietsanders has it, I think
[19:27:09] <tfinc>	 YuviPanda: WM NL has our signing keys ?
[19:27:17] <YuviPanda>	 tfinc: no, they have it for org.wikilovesmonuments
[19:27:21] <YuviPanda>	 tfinc: those aren't our keys
[19:27:25] <tfinc>	 ok .. you scared me there
[19:27:35] <YuviPanda>	 tfinc: heh
[19:27:44] <tfinc>	 YuviPanda: are they doing any new dev on it? and who's the contact ?
[19:27:47] <YuviPanda>	 tfinc: ours was org.wikipedia.wlm or somesuch.
[19:28:18] <YuviPanda>	 tfinc: there isn't really any dev on it. I fixed up some stuff last time, and that's it. Effietsanders is the person to contact to figure out what to do, I think
[19:28:29] <tfinc>	 YuviPanda: pm me their contact info 
[19:28:34] <YuviPanda>	 tfinc: moment
[19:29:20] <YuviPanda>	 tfinc: done
[19:29:29] <matanya>	 YuviPanda: any new build? i have some time for testing now
[19:29:41] <YuviPanda>	 matanya: woo! yes, let me email you now
[19:29:47] <YuviPanda>	 matanya: pm your email again please?
[19:30:25] <YuviPanda>	 matanya: done!
[19:30:29] <matanya>	 thanks
[19:30:45] <YuviPanda>	 matanya: yw :) file bugs or email me (and I'll file the bugs) :)
[19:30:51] <violetto>	 YuviPanda: mhurd late to the party
[19:31:04] <violetto>	 but mine was 2seconds on a template heavy section
[19:31:08] <violetto>	 on wifi
[19:31:12] <YuviPanda>	 violetto: can you try on 3G?
[19:31:20] <violetto>	 i dont have 3g anymore
[19:31:27] <YuviPanda>	 violetto: do you have 2G? :)
[19:31:30] <violetto>	 hahaha
[19:31:35] <violetto>	 unfortunately not!
[19:31:41] <YuviPanda>	 violetto: I'll do the swipe thing anyway tomorrow and see how it feels like
[19:31:42] <violetto>	 no more sim card
[19:31:47] <violetto>	 yeah
[19:31:47] <mhurd>	 violetto: on your phone i think u can disable 4g under network settings
[19:31:58] <YuviPanda>	 violetto: how are we going to make it discoverable?
[19:32:25] <violetto>	 YuviPanda: swiping?
[19:32:57] <YuviPanda>	 violetto: yeah? like, how to say 'hey you could swipe and there are things!'
[19:33:15] <violetto>	 animation when you first land into edit mode
[19:33:35] <YuviPanda>	 violetto: ah, hmm.
[19:33:38] <violetto>	 let me show you
[19:33:41] <YuviPanda>	 violetto: ok
[19:35:15] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Cleanup webviews when we no longer require them [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115159 (owner: 10Yuvipanda)
[19:35:33] <violetto>	 YuviPanda: when you first download and open yahoo weather it does it very well
[19:35:43] <violetto>	 i got distracted by someone when it opened the first time so
[19:36:58] <YuviPanda>	 violetto: ah, hmm. ok
[19:37:39] <YuviPanda>	 violetto: ok, I'm going to be off in about 10mins
[19:38:25] <matanya>	 YuviPanda: ready to serve :)
[19:38:34] <YuviPanda>	 matanya: \o/
[19:38:35] <matanya>	 writing?
[19:38:46] <YuviPanda>	 matanya: hopefully this will come out with top notch rtl support from day 1
[19:38:48] <YuviPanda>	 matanya: hmm?
[19:39:05] <matanya>	 the new bugs already found...
[19:39:16] <violetto>	 YuviPanda: im trying to demonstrate with a video
[19:39:21] <YuviPanda>	 matanya: ah, ok!
[19:39:23] <YuviPanda>	 violetto: ok!
[19:39:49] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Add task to get a preview + tests [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115115 (owner: 10Yuvipanda)
[19:39:53] <matanya>	 after searching in the search box clicking done does nothing
[19:40:05] <YuviPanda>	 matanya: ah, right. you need to tap on a result
[19:40:11] <YuviPanda>	 matanya: i wonder what 'done' should do. just hide?
[19:40:28] <matanya>	 no, go to the exact match
[19:40:37] <matanya>	 if exists
[19:40:54] <matanya>	 which did in my case
[19:41:12] <YuviPanda>	 matanya: right
[19:41:17] <matanya>	 and if not, search
[19:41:32] <matanya>	 if this is possible
[19:42:09] <YuviPanda>	 matanya: right
[19:42:09] <matanya>	 bug 2 : templates or left aligned
[19:42:10] <violetto>	 YuviPanda: uploading
[19:42:35] <violetto>	 YuviPanda: https://drive.google.com/file/d/0By-mxPQtZwJbbHVhMy1faUVyQjQ/edit?usp=sharing
[19:42:59] <grrrit-wm>	 (03PS1) 10Yuvipanda: Make the preview task POST [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115223 
[19:43:12] <matanya>	 bug 3 : nice catch: undefined when getting to disambig page
[19:43:41] <YuviPanda>	 violetto: hmm, a bit too subtle but we can test it out and see how it is
[19:43:51] <YuviPanda>	 violetto: I'll get some cleanup stuff done and then get to this.
[19:43:53] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 04-1] "Section edit links for subsections show up in the preview, that probably needs fixing. :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115158 (owner: 10Yuvipanda)
[19:44:04] <YuviPanda>	 brion: ok, let me do that in the next commit
[19:44:14] <brion>	 ok, should be an easy css tweak
[19:44:33] <YuviPanda>	 brion: is it .edit-page?
[19:44:43] <YuviPanda>	 brion: also our parser is fucking stupid for doing that, but :)
[19:44:45] <matanya>	 brion: million +1's on your ogg.js stuff
[19:45:24] <grrrit-wm>	 (03PS3) 10Mhurd: Groundwork for account creation interface. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/114889 
[19:45:34] <brion>	 uh, not sure
[19:46:27] <matanya>	 YuviPanda: so far all is left aligned :/
[19:46:37] <YuviPanda>	 matanya: all content?
[19:46:41] <matanya>	 yes
[19:46:43] <YuviPanda>	 matanya: bugs with screenshots would be amazingreat
[19:47:06] <matanya>	 what is bugzilla product, mobile?
[19:47:24] <brion>	 matanya: thanks :D  it's a fun project, and it's going better than i originally expected. :) still looking at Flash as an alternative for old IE versions though 
[19:47:24] <brion>	 since the JS relies on newer things like canvas and typed arrays
[19:47:53] <YuviPanda>	 matanya: 'wikipedia app'
[19:47:58] <matanya>	 i don't expect it to work on IE <10
[19:48:07] <brion>	 YuviPanda: yeah <a href="#editor/1" data-section="1" class="edit-page">Edit</a>
[19:48:07] <brion>	 chrome remote web inspector wins again!
[19:48:12] <YuviPanda>	 matanya: yeah
[19:48:13] <YuviPanda>	 err
[19:48:14] <YuviPanda>	 brion: yeah
[19:48:31] <YuviPanda>	 brion: we should strip it in the server, maybe.
[19:48:35] * YuviPanda  pokes MaxSem

[19:48:46] * MaxSem  poked

[19:49:46] <grrrit-wm>	 (03PS1) 10Yuvipanda: Hide editlinks in preview [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115228 
[19:49:58] <brion>	 maybe yeah
[19:50:05] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Crashes if I try to preview an edit while offline. :(" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115158 (owner: 10Yuvipanda)
[19:50:35] <YuviPanda>	 MaxSem: action=parse has a mobileformat parameter, but that doesn't strip out the editlinks
[19:51:00] <YuviPanda>	 brion: i'll add crash resiliency in another patch too :)
[19:51:21] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Looks good other than those breakages. :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115158 (owner: 10Yuvipanda)
[19:51:53] <YuviPanda>	 brion: editlinks should be fixed in that patch
[19:52:02] <MaxSem>	 YuviPanda, should it?
[19:52:18] <YuviPanda>	 MaxSem: it should!
[19:52:26] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok, section fix is in another patch and not-crashing-when-exception is coming later. Woo!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115158 (owner: 10Yuvipanda)
[19:53:04] <brion>	 hehe ok
[19:58:56] <matanya>	 YuviPanda: 61867
[19:59:19] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Make the preview task POST [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115223 (owner: 10Yuvipanda)
[19:59:21] <matanya>	 both bugs on same page
[19:59:56] <matanya>	 hope this is what you meant
[20:00:31] <YuviPanda>	 matanya: hmm, got it.
[20:00:36] <YuviPanda>	 i think it is missing dir and lang
[20:01:28] <matanya>	 you see the duplicate disambig issue with the undefind there?
[20:02:21] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Hide editlinks in preview [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115228 (owner: 10Yuvipanda)
[20:02:52] <YuviPanda>	 matanya: hmm, I think that's happening to all pages without sections
[20:02:54] <YuviPanda>	 and just one content
[20:03:07] <matanya>	 so a seperate bug
[20:03:18] <YuviPanda>	 matanya: yeah. 
[20:03:27] <brion>	 ok i gotta grab food fast before 12:30 meeting. catch ya later
[20:03:47] <matanya>	 you can describe it better :)
[20:04:04] <YuviPanda>	 matanya: oooh, seems to be a bug in MobileFrontend!
[20:04:06] <YuviPanda>	 matanya: let me file it
[20:04:29] * matanya  is happy with catch

[20:04:55] <awjr>	 kaldari: i haven't noticed the card preview issue with Mingle
[20:04:59] <awjr>	 (sorry was in a mtg)
[20:05:24] <awjr>	 kaldari: but now that im looking closer - i think i see what you mean - where clicking the 'x' doesn't close the card?
[20:05:52] <awjr>	 i had never noticed the 'x' on the card previews before - if i click somewhere outside of the area of the preview, the card closes
[20:05:57] <YuviPanda>	 matanya: https://bugzilla.wikimedia.org/show_bug.cgi?id=61868
[20:06:00] <YuviPanda>	 MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=61868
[20:06:55] <matanya>	 YuviPanda: another one: unable to edit section 0
[20:07:16] <YuviPanda>	 matanya: yeah, that's already there. we're going to redo the edit action to be something else (not pencil icon next to section title) that should fix it
[20:07:35] <matanya>	 ok
[20:10:19] <YuviPanda>	 matanya: I think I know what the content left aligned issue is. I'll get that fixed tomorrow
[20:11:07] <YuviPanda>	 matanya: so basically I need to set the directionality from the language. I guess I'll just get a list of RTL languages and do that
[20:12:40] <matanya>	 YuviPanda: 61869
[20:13:32] <matanya>	 YuviPanda: usability question: where is the cursor when searching?
[20:14:39] <YuviPanda>	 matanya: sorry, got a powercut :( Anything I missed?
[20:14:51] <matanya>	 <matanya> YuviPanda: 61869
[20:14:51] <matanya>	 <matanya> YuviPanda: usability question: where is the cursor when searching?
[20:15:01] <YuviPanda>	 matanya: you should be able to see it as you type?
[20:15:01] <YuviPanda>	 no?
[20:15:02] * YuviPanda  looks

[20:15:24] <YuviPanda>	 matanya: yeah, I see a blinking cursor there
[20:15:28] <YuviPanda>	 matanya: do you not see it?
[20:15:48] <matanya>	 when loading the app, no cursor
[20:16:02] <matanya>	 only after start to type
[20:17:14] <YuviPanda>	 matanya: I see a cursor as soon as I tap the search bar
[20:17:19] <YuviPanda>	 matanya: until you search there's no cursor
[20:17:55] <matanya>	 YuviPanda: rtl or ltr?
[20:18:25] <YuviPanda>	 matanya: lr
[20:18:26] <YuviPanda>	 ltr
[20:18:33] <YuviPanda>	 hmm, that shouldn't be affected by RTL
[20:18:36] <YuviPanda>	 matanya: what phone are you on?
[20:18:47] <matanya>	 tablet
[20:19:10] <matanya>	 i tap the search box and no cursor until i type
[20:19:44] <YuviPanda>	 matanya: what tablet? and what version of android?
[20:19:49] <YuviPanda>	 matanya:  a screenshot + bug would be helpful!
[20:20:13] <matanya>	 k14.1.1
[20:20:21] <matanya>	 *k1
[20:20:25] <YuviPanda>	 matanya: ah, hmm. might be that.
[20:20:31] <YuviPanda>	 I'll look into that too. 
[20:20:32] <matanya>	 with android 4.1.1
[20:20:53] <matanya>	 can't screenshot something missing :)
[20:23:29] <YuviPanda>	 matanya: heh :D Just file a bug then
[20:24:03] <matanya>	 it is hard for me to describe this :) let me think about it
[20:25:00] <matanya>	 oh, a major bug: can't edit unless end of line
[20:25:37] <kaldari>	 awjr: ah, well at least there's a way to close them, which helps :)
[20:25:48] <YuviPanda>	 matanya: what do you mean 'end of line'?
[20:26:32] <matanya>	 the cursor is blinking in the end of any given line, but i can't move it
[20:26:57] <YuviPanda>	 matanya: oh? in the edit window?
[20:27:02] <YuviPanda>	 you should be able to tap elsewhere to move it?
[20:27:26] <matanya>	 yes, it doesn't work
[20:27:36] <YuviPanda>	 matanya: oh that's weird. I jsut tried it and it works :|
[20:27:42] <YuviPanda>	 matanya: anyway, file bugs? I've to go hit the bed now :(
[20:27:53] <matanya>	 sure, good night
[20:28:05] <YuviPanda>	 matanya: thanks for helping test! And sorry I can't be up now :(
[20:28:19] <matanya>	 np
[20:28:35] <YuviPanda>	 :)
[20:28:42] <YuviPanda>	 violetto: mhurd night!
[20:28:57] <violetto>	 YuviPanda: night!
[20:33:11] <grrrit-wm>	 (03PS1) 10Yuvipanda: Add 'showPassword' functionality to Create Account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115245 
[20:33:28] <YuviPanda>	 did my patch get through
[20:33:30] <YuviPanda>	 ?
[20:33:50] <YuviPanda>	 did
[20:34:10] <YuviPanda>	 nichg
[21:34:38] <grrrit-wm>	 (03PS3) 10Kaldari: Add EditorApi#prependText [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114366 (owner: 10JGonera)
[21:34:56] <grrrit-wm>	 (03PS3) 10JGonera: Refactor PhotoApi tests and error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114367 
[21:35:02] <grrrit-wm>	 (03PS2) 10JGonera: Use EditorApi in PhotoApi to add image to page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114681 
[21:35:07] <grrrit-wm>	 (03PS2) 10JGonera: Create a reusable AbuseFilterPanel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114907 
[21:35:12] <grrrit-wm>	 (03PS2) 10JGonera: Story 1629: Captcha and AbuseFilter support in lead photo uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114908 
[21:35:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add EditorApi#prependText [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114366 (owner: 10JGonera)
[21:35:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Refactor PhotoApi tests and error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114367 (owner: 10JGonera)
[21:36:20] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use EditorApi in PhotoApi to add image to page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114681 (owner: 10JGonera)
[21:36:39] <jgonera>	 kaldari, I'll have a look at it in a moment
[21:36:51] <grrrit-wm>	 (03PS4) 10Kaldari: Add EditorApi#prependText [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114366 (owner: 10JGonera)
[21:36:57] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Create a reusable AbuseFilterPanel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114907 (owner: 10JGonera)
[21:37:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Story 1629: Captcha and AbuseFilter support in lead photo uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114908 (owner: 10JGonera)
[21:38:06] <grrrit-wm>	 (03PS4) 10JGonera: Refactor PhotoApi tests and error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114367 
[21:38:10] <grrrit-wm>	 (03PS3) 10JGonera: Use EditorApi in PhotoApi to add image to page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114681 
[21:38:14] <grrrit-wm>	 (03PS3) 10JGonera: Create a reusable AbuseFilterPanel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114907 
[21:38:19] <grrrit-wm>	 (03PS3) 10JGonera: Story 1629: Captcha and AbuseFilter support in lead photo uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114908 
[21:38:34] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Add EditorApi#prependText [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114366 (owner: 10JGonera)
[21:39:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use EditorApi in PhotoApi to add image to page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114681 (owner: 10JGonera)
[21:39:27] <kaldari>	 jgonera: I wanted to go ahead and merge your first patch so that I didn't conflict with it in my changes
[21:39:54] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Create a reusable AbuseFilterPanel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114907 (owner: 10JGonera)
[21:39:56] <kaldari>	 I rebased the other changes, so you'll need to update locally
[21:40:02] <jgonera>	 kaldari, I see
[21:40:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Story 1629: Captcha and AbuseFilter support in lead photo uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114908 (owner: 10JGonera)
[21:40:25] <kaldari>	 jgonera: hope that doesn't cause a mess for you locally
[21:40:56] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add EditorApi#prependText [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114366 (owner: 10JGonera)
[21:41:00] <jgonera>	 should be fine if I do --skip when rebasing
[21:42:23] <kaldari>	 jgonera: I also have to mess with the prepended save message for the redlinks story
[21:45:47] <jgonera>	 I see, I'll be in the office in 5 min
[22:15:50] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Stop processing if user taps 'x' before page loads. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/115313 
[22:27:11] <grrrit-wm>	 (03PS4) 10JGonera: Use EditorApi in PhotoApi to add image to page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114681 
[22:27:13] <grrrit-wm>	 (03PS5) 10JGonera: Refactor PhotoApi tests and error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114367 
[22:27:15] <grrrit-wm>	 (03PS4) 10JGonera: Create a reusable AbuseFilterPanel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114907 
[22:27:17] <grrrit-wm>	 (03PS4) 10JGonera: Story 1629: Captcha and AbuseFilter support in lead photo uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114908 
[22:27:52] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use EditorApi in PhotoApi to add image to page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114681 (owner: 10JGonera)
[22:28:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Create a reusable AbuseFilterPanel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114907 (owner: 10JGonera)
[22:29:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Story 1629: Captcha and AbuseFilter support in lead photo uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114908 (owner: 10JGonera)
[22:51:29] <grrrit-wm>	 (03PS5) 10JGonera: Use EditorApi in PhotoApi to add image to page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114681 
[22:51:31] <grrrit-wm>	 (03PS5) 10JGonera: Create a reusable AbuseFilterPanel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114907 
[22:51:33] <grrrit-wm>	 (03PS5) 10JGonera: Story 1629: Captcha and AbuseFilter support in lead photo uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114908 
[22:52:25] <grrrit-wm>	 (03CR) 10JGonera: "I added some docs in I5e5130c2dd88454800bb57af7be4c2158e45a348 because the error format changed slightly in there." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114367 (owner: 10JGonera)
[23:04:19] <kaldari>	 kenanwang__: After we ask the user "Are you sure you want to create a new page on [project name]?", if they choose "Cancel". what action do we take? Do we put them back in the editor or do we exit out of the editor completely? I'm guessing we put them back in the editor and let them choose whether to refine the content further or back out of the edit completely, but I wanted to confirm with you.
[23:05:39] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Fixing font size in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114672 (owner: 10Kaldari)
[23:06:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fixing font size in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114672 (owner: 10Kaldari)
[23:09:35] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "In general looks good, but I have a few comments." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113496 (owner: 10Kaldari)
[23:10:09] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Cleanup naming convention for special page RL modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111146 
[23:10:35] <jgonera>	 kaldari, I rebased my changes and added docs for PhotoApi in the last commit
[23:10:43] <jgonera>	 also, please merge this one: https://gerrit.wikimedia.org/r/#/c/111146/
[23:11:11] <kaldari>	 cool, will rereview in a bit
[23:11:45] <dennyvrandecic>	 just want to ping about https://gerrit.wikimedia.org/r/#/c/112921/ before it gets stale (maybe brion ?)
[23:12:15] <brion>	 dennyvrandecic: still on my todo list :D i'm tracking down a weird bug that disappears in the debugger, it's ...... distracting ;)
[23:12:26] <brion>	 lemme take a quick peek tho
[23:13:31] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Ok this looks about right but I'll have to test it. Putting that on my todo list for tomorrow if I don't get to it today. Thanks again!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic)
[23:13:56] <dennyvrandecic>	 brion: thx!
[23:14:11] <brion>	 woot
[23:16:11] <dennyvrandecic>	 don't tell me my unrelated patch fixed your weird bug? ;)
[23:16:29] <grrrit-wm>	 (03PS1) 10Brion VIBBER: Avoid "leaked window" errors by dismissing popups, not just hiding them, on success [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115317 
[23:16:33] <brion>	 dennyvrandecic: alas no
[23:16:38] <brion>	 that would have been great tho ;)
[23:16:38] <dennyvrandecic>	 pity
[23:17:00] <brion>	 yeah so i just fixed an unrelated bug that cluttered my debug logs. that's something :D
[23:17:12] <brion>	 dennyvrandecic: how's google treating you?
[23:17:21] <brion>	 i assume they have far more resources for their knowledge graph system than we do :DD
[23:17:24] <dennyvrandecic>	 brion: the food's dangerously good
[23:17:27] <brion>	 hehehe
[23:17:49] <dennyvrandecic>	 brion: and the technical resources available are rather amazing
[23:17:53] <brion>	 nice
[23:19:10] <dennyvrandecic>	 in short, quite happy. it is a very different (and thus enlightening) perspective than academia or wikimedia
[23:19:52] <dennyvrandecic>	 but then again, I was happy at academia and wikimedia as well, so this might not be a differentiator ;)
[23:20:19] <brion>	 :)
[23:20:25] <brion>	 glad you're enjoying the private sector!
[23:33:38] <jgonera>	 kaldari, I merged your changes to mediawiki_api to my branch. do you want to work on create_user or should I add it?
[23:35:14] <kaldari>	 jgonera: I'm in the middle of the redlink changes right now, so might be better for you to add it unless you're also working on other things at the moment.
[23:35:47] <jgonera>	 kaldari, I might add it later, it's not that we need it right now, my question was more general ;)
[23:36:45] <kaldari>	 if you don't care about the speed, I would love to work on it to learn more
[23:41:10] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Shorten text in <option> for preferred language. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/115320 
[23:41:36] <kaldari>	 kenanwang__: question for you in the backscroll ^