[00:11:13] (03PS1) 10Brion VIBBER: Only add event handler once; after edit we may reload multiple times [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115321 [00:11:34] i keep fixing bugs that aren't my bug ;) [00:11:40] it's gotta be in here somewhere :D [00:14:25] awjr: are you around? about lunch tomorrow, not sure if you saw I have a short conflict at 1PM [00:14:36] chrismcmahon: heya yup [00:14:56] chrismcmahon: is thursday better? [00:15:18] chrismcmahon: or weds? [00:15:22] im pretty flexible this week [00:15:24] kenanwang__: you around? [00:16:10] Hey I'm in meetings [00:16:24] awjr: wed would be good but you seem to have a thing at 2. tomorrow a little after 1 might be best [00:17:00] Can you ask the question again I don't see it [00:17:45] chrismcmahon: i am confused - it looks like you have something from 1-2 tomorrow? [00:18:53] awjr: I have a 12:30-1PM AZ meeting tomorrow I can't miss [00:19:18] chrismcmahon: ah ok - i see now, sorry was looking at the wrong cal [00:19:34] chrismcmahon: i put 1-3 because it takes a while to get around town :) [00:20:03] so i was budgeting for any travel + some extra buffer [00:20:09] awjr: I have a 3PM but I can cancel that one [00:20:22] chrismcmahon: what time would be good for you to meet for lunch? [00:20:45] awjr: between 1 and 1:30 [00:20:54] perfect chrismcmahon [00:21:32] chrismcmahon: anywhere in particular you'd like to meet up? [00:22:10] chrismcmahon: or genres? [00:23:14] awjr: I hadn't really thought that far. there are a lot of options in the craycroft/sunrise to pima/country club corridor. if you don't have an idea offhand, I might spend some time on yelp this evening :-) [00:23:58] chrismcmahon: sounds good - i am not as familiar with restaurants between us, i'll take a look tonight as well [00:48:01] (03PS1) 10Kaldari: Story 1685: Improve red links support in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 [00:48:42] (03CR) 10jenkins-bot: [V: 04-1] Story 1685: Improve red links support in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 (owner: 10Kaldari) [00:51:57] (03PS2) 10Kaldari: Story 1685: Improve red links support in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 [00:52:41] (03CR) 10jenkins-bot: [V: 04-1] Story 1685: Improve red links support in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 (owner: 10Kaldari) [00:56:02] (03CR) 10Kaldari: [C: 04-1] "need to move confirmation step" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 (owner: 10Kaldari) [01:11:26] (03PS3) 10Kaldari: Story 1685: Improve red links support in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 [01:12:45] * zz_yuvipanda looks around [01:12:52] aw, brion just quit [01:23:49] (03PS6) 10Kaldari: Story 1628: Fix some of the mobile VE toolbar styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113496 [01:24:13] hey brion [01:24:22] brion: https://gerrit.wikimedia.org/r/#/c/115245/? [01:24:23] :) [01:24:39] moment [01:24:48] yuvipanda: i think i tracked down the hides-after-edit bug [01:24:57] it doesn't break for you because your internet is too slow [01:25:09] brion: ohhhhh?!! [01:25:10] hahaha [01:25:26] it's the cross-fade with the progress indicator [01:26:31] brion: aaaahh [01:26:39] about to commit :D [01:26:44] brion: :) [01:26:45] swell [01:29:59] (03PS1) 10Brion VIBBER: Fix "page goes blank after saving" bug [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115328 [01:31:19] (03CR) 10Yuvipanda: [C: 032 V: 032] Avoid "leaked window" errors by dismissing popups, not just hiding them, on success [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115317 (owner: 10Brion VIBBER) [01:35:17] (03CR) 10Yuvipanda: [C: 04-1] "We should perhaps round up all such event handlers and just move them to a single method (like 'setupMessageHandlers') and call them from " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115321 (owner: 10Brion VIBBER) [01:35:34] (03CR) 10Yuvipanda: [C: 032 V: 032] "Can't test, but seems fair! :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115328 (owner: 10Brion VIBBER) [01:35:36] brion: ^ [01:36:06] (03CR) 10Kaldari: [C: 04-1] Refactor PhotoApi tests and error handling (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114367 (owner: 10JGonera) [01:36:34] moment [01:43:32] yuvipanda: you mean round up all the handlers in PageViewFragment specifically? [01:43:43] it's just the one, plus the global Utils.addUtilityMethodsToBridge [01:44:13] i can encapsulate em in a method if you want tho :D [01:44:31] (03PS2) 10Brion VIBBER: Only add event handler once; after edit we may reload multiple times [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115321 [01:45:12] brion: yeah, that'll be enough [01:45:14] brion: you still about ? [01:45:25] brion: our big lifecycle methods make me unwary [01:45:26] tfinc: yep i finally wrapped up that hidden page bug :D [01:45:33] yuvipanda: understandable [01:45:36] ok, 'weary', I think. unwary is the wrong word [01:45:39] brion: thats great. i cant wait to see it in the build [01:45:52] we'll have to do a once-over and just do some refactoring cleanup [01:45:55] :D [01:45:58] brion: mike godwin is trying to get us together with some of his cohorts [01:46:10] tfinc: oh yeah i have a mail from him in my queue [01:46:26] (03CR) 10Yuvipanda: [C: 032 V: 032] "\o/" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115321 (owner: 10Brion VIBBER) [01:46:40] brion: yeah :) [01:46:51] brion: now for https://gerrit.wikimedia.org/r/#/c/115245/? :) [01:46:55] (03PS2) 10Yuvipanda: Add 'showPassword' functionality to Create Account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115245 [01:49:37] yuvipanda: it still has that font-change on the placeholder text that the one on the login screen does [01:49:41] but we can fix that later [01:49:56] brion: yeah, easier to fix now because they are in one spot [01:50:10] brion: I guess we should set them to monospace regardless? or to regular open sans regardless? [01:50:20] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Note this has the same issue as the login form with the placeholder text changing fonts when we change state, but we can fix that later." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115245 (owner: 10Yuvipanda) [01:50:30] probably should be always open sans yeah [01:50:50] (03PS2) 10Brion VIBBER: Fix "page goes blank after saving" bug [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115328 [01:50:58] ^ rebased [01:51:01] yuvipanda: ^ [01:52:08] (03CR) 10Yuvipanda: [C: 032 V: 032] Fix "page goes blank after saving" bug [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115328 (owner: 10Brion VIBBER) [01:52:13] brion: \o/ done [01:52:17] VoV [01:52:24] brion: :) [01:52:38] brion: so the only open chain I can think of is erroring out on preview, right? [01:52:46] yeah [01:52:49] ok [01:52:50] swell [01:52:51] that should be straightforward to fix [01:52:54] just catch the error ;) [01:52:56] brion: how's twn going? we're about a month off :( [01:52:57] *exception [01:53:10] yuvipanda: i'll set it up tomorrow morning [01:53:15] brion: yeah, but I want to abstract that out. We've that code in about 4 places now, I think [01:53:26] blissfully free of surprise meetings [01:53:38] brion: heh :) [01:53:51] brion: I'll be in https://en.wikipedia.org/wiki/Ooty tonight :) [01:54:09] heh [01:54:45] yuvipanda: ok i'm gonna escape from the office now :D [01:54:47] catch ya later [01:56:17] (03PS1) 10Dr0ptp4kt: Bring user to last page viewed on browser restart. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/115330 [03:22:05] (03PS1) 10JGonera: Fix overlay header shifting on iOS in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115337 [03:28:58] (03PS6) 10JGonera: Use EditorApi in PhotoApi to add image to page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114681 [03:29:00] (03PS6) 10JGonera: Refactor PhotoApi tests and error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114367 [03:29:02] (03PS6) 10JGonera: Create a reusable AbuseFilterPanel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114907 [03:29:04] (03PS6) 10JGonera: Story 1629: Captcha and AbuseFilter support in lead photo uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114908 [14:22:48] i need to develop wikimedia commons app [14:22:56] how can i start ? [14:23:01] need help [14:27:00] nr_: Isn't zz_yuvipanda already working on that? [14:28:00] i dont know ? [14:28:07] i have some good ideas for that [14:29:40] nr_: see https://git.wikimedia.org/summary/apps%2Fandroid%2Fcommons.git [14:30:09] thnx [14:30:23] nr_: This too - https://www.mediawiki.org/wiki/Apps/Commons [14:31:08] i have seen this [14:31:28] who is mentor of this app ? [14:33:28] nr_: mentor? All I know is that yuvi and brion are working on this! [14:34:38] thnx [14:34:52] nr_: yw :) [14:35:41] I touched file from flickr on my Android App, and suddenly it was broken, is this known? [18:03:22] yurik_, i guess let's skip the standup seeing as dan can't make it [18:16:54] brion: heya! [18:17:00] hey hey [18:19:30] dr0ptp4kt: are you guys joining? [18:22:54] yurikR, did you just send this at 10:19 am pacific time? or was it delayed? [18:31:53] mhurd: no hangout link? [18:31:54] for the budget meet? [18:32:38] YuviPanda: tomasz just added and mailed link [18:32:48] mhurd: ah ok [18:33:25] awjr: you about ? [18:33:40] tfinc: one sec, on the phone [18:34:06] awjr: i'm on the lookout for juliusz but you may be able to fill in if he doesn't show [18:36:21] awjr: i just added you to the invite [18:37:59] Test [18:38:28] tfinc: back [18:38:35] tfinc: eh fill in for what? [18:38:36] kenanwang: Test success! [18:38:41] awjr: budgeting planning for next year [18:38:49] ah yeah i see the invite [18:38:49] ok [18:38:50] awjr: i mailed about it last week [18:39:03] awjr: you can attend and relay it to juliusz [18:39:13] hehe YuviPanda was seeing if I changed my nick on desktop if it also changed it on the app [18:39:47] kenanwang: IRCCloud? [18:39:49] kenanwang: did it? [18:39:53] yep [18:39:56] kenanwang: nice! :) [18:40:02] it's great thanks for the recommendation [18:40:09] tfinc: ok - i dont think i got an email about this last week, what was the subject? (just looking for any more context) [18:40:58] just sent you an email awjr [18:41:03] oy, look like it never left my drafts folder [18:41:06] just sent it [18:41:07] my bad [18:52:20] hi awjr any thoughts on a lunch place? [18:57:26] awjr: YuviPanda : https://etherpad.wikimedia.org/p/MobileResourcePlanning [18:57:55] im just taking light notes [19:02:56] aharoni: around? [19:03:07] preved [19:03:29] aharoni: so, how do I detect if a language is RTL? [19:03:39] like, is there a canonical list of wiki languages that are RTL? [19:04:11] In MediaWiki on the PHP side you can do something like $wgLang->isRtl() [19:04:18] and also ->getDir() [19:04:35] aharoni: ah, but in general? I need to implement this clientside in Java [19:04:38] chrismcmahon: i have a few ideas - is there a genre you're hungry for? [19:04:53] YuviPanda: you may just have to make a hardcoded list :( [19:05:02] brion: yeah, sounds like it :( [19:05:15] aharoni: do you have a list of wikipedias that are primarily RTL content? [19:05:27] YuviPanda: In MW JS it's not built in AFAIK, [19:05:29] HOWEVER [19:05:41] aharoni: I've to implement this in Java, btw :D [19:05:58] in ULS we have a big JSON file with info about all the languages that Wikipedia supports and then some. [19:06:10] oh [19:06:10] awjr: I am a happy omnivore. [19:06:26] aharoni: wait, is this all the languages we have *content* in? or the languages our UI is supported in? [19:06:28] YAML, actually, and we convert it JSON every time we change it. [19:06:41] YuviPanda: it includes all of them and more [19:06:48] aharoni: ah, hmm. [19:06:51] I could probably steal that [19:06:55] yes, please. [19:07:07] aharoni: although I was hoping you would tell me something like 'oh, there are just 11 of those, here is a list' :P [19:07:11] and we have a utils file there with functions for querying it. [19:07:19] LOL [19:07:39] Well ACTUALLY, if you want to be Very Lazy, [19:07:55] there's this thing that I wrote for you once long time ago in Pune, [19:08:04] it's somewhere there in the code of the old Wikipedia App. [19:08:09] but please don't be Very Lazy. [19:08:30] chrismcmahon: here are three that sound good to me: http://www.yelp.com/biz/beyond-bread-tucson-2, http://www.yelp.com/biz/curry-leaf-tucson, http://www.yelp.com/biz/ds-island-grill-ja-tucson-2 [19:09:23] excellent sandwiches, solid indian, or unknown carribean :) [19:11:20] awjr: I'd go for Beyond Bread myself. I actually went to D's once, it was OK, not much in the way of ambiance though. My only suggestion might be the little restaurant in the Whole Foods at Craycroft & River, they make a great burger, chicken sandwich, sushi and some other stuff. (and they have a great beer list) [19:11:33] awjr: so I think Beyond Bread then [19:12:11] chrismcmahon: sounds great. i think i had d's once too but from a food truckā€¦ [19:12:20] chrismcmahon: what time do you think you can get over there? [19:13:57] awjr: according to google maps, I'd say about 1:15 or 1:20ish [19:14:04] perfect chrismcmahon [20:08:38] (03CR) 10Brion VIBBER: "couple quick inline ntoes" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/114889 (owner: 10Mhurd) [20:09:33] (03CR) 10JGonera: [C: 032] Story 1628: Fix some of the mobile VE toolbar styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113496 (owner: 10Kaldari) [20:09:37] (03Merged) 10jenkins-bot: Story 1628: Fix some of the mobile VE toolbar styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113496 (owner: 10Kaldari) [20:18:54] (03CR) 10JGonera: [C: 04-1] "I can't save a new page. The green submit button doesn't do anything. I also can't get out of the editor because X and browser back don't " (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 (owner: 10Kaldari) [20:19:52] (03CR) 10JGonera: [C: 032] Finish comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114639 (owner: 10MaxSem) [20:20:30] (03Merged) 10jenkins-bot: Finish comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114639 (owner: 10MaxSem) [20:21:40] (03CR) 10JGonera: [C: 032] Ensure SkinAfterBottomScripts hook gets called [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114653 (owner: 10MaxSem) [20:22:15] (03Merged) 10jenkins-bot: Ensure SkinAfterBottomScripts hook gets called [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114653 (owner: 10MaxSem) [20:44:53] brion: yo [20:44:57] can you respond to mikes email ? [21:34:41] kaldari: we were wondering whether you and/or bsitu would be interested in giving us (i.e. Research) a tutorial/brownbag on designing notifications via the Echo API (similar to the one you'll be giving in Zurich) [21:39:12] brion: which stories are you picking up today ? [21:39:40] kenanwang: the todo column in the current sprint is too unruly to be useful. can you prune it ? [21:39:47] https://trello.com/b/eEdBblMK/mobile-app-sprint-25-core-workflows [21:39:47] tfinc: lemme poke through em [21:41:25] tfinc I can take a look, we haven't been really addressing new bugs as they come in because it's sorta hard to differentiate new from old [21:41:52] let's make sure we triage and label bugs as we triage so that we can differentiate [21:41:58] kenanwang: good call [21:43:11] tfinc: grabbed the API tweak and some tidying we need to do on the Andorid translatewiki setup [21:44:59] brion: thanks. do make sure to drag those over so that i know what your focusing on. otherwise i have no clue where your efforts are going. eager to see tomorrows build [21:45:08] ok :D [21:48:01] DarTar: You may find https://www.mediawiki.org/wiki/Echo_(Notifications)/Developer_guide useful [21:51:43] kaldari: awesome, I haven't looked at this page in a while [21:51:55] passing it along [22:12:03] brion: getting close on the acct creation stuff. do you want me to just amend the refactor patch with the acct creation stuff? [22:12:22] mhurd: yeah go ahead [22:12:27] brion: will do! [22:12:33] excellent [22:37:37] brion: where are the docs on the account creation api? [22:38:11] tfinc: https://www.mediawiki.org/wiki/API:Account_creation [22:44:30] thanks [22:44:59] (03PS1) 10Kaldari: Story 1643: Final tweak on talk page styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115523 [22:47:01] (03PS2) 10Kaldari: Story 1643: Final tweak on talk page styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115523 [22:49:20] (03CR) 10Kaldari: [C: 032] Refactor PhotoApi tests and error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114367 (owner: 10JGonera) [22:49:57] (03Merged) 10jenkins-bot: Refactor PhotoApi tests and error handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114367 (owner: 10JGonera) [22:50:21] (03PS3) 10Kaldari: Story 1643: Final tweak on talk page styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115523 [22:59:49] bbiab, updating... [23:16:38] kaldari: I moved our sync to tomorrow [23:16:52] ok [23:16:59] Would you have any time to review the OPED draft and look at the FOSS fonts questions today? [23:17:42] If we independently examine it today, then tomorrow we can address the open questions [23:20:48] (03PS4) 10Kaldari: Story 1685: Improve red links support in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 [23:23:27] (03CR) 10Kaldari: [C: 032] Hygiene: Use accept attribute in uploads file input tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113067 (owner: 10JGonera) [23:24:02] (03Merged) 10jenkins-bot: Hygiene: Use accept attribute in uploads file input tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113067 (owner: 10JGonera) [23:44:37] is anyone using vagrant for MF development? jgonera? [23:44:39] derp [23:45:41] i've started playing around with it but am finding that clicking the 'mobile view' link doesn't actually set the mf_useformat cookie like it's supposed to [23:45:47] i can't figure out why [23:47:44] the server appears to be responding with the correct cookie info, but the browser doesn't appear to actually set it [23:48:31] anybody else experienced this? MaxSem kaldari jgonera? [23:48:45] awjr, I use vagrant, but not for MF [23:49:13] haven't used vagrant [23:52:19] * awjr grumbles [23:55:36] awjr, I had the same problem [23:55:44] that's why I gave up on it for now [23:55:45] jgonera: did you ever figure it out? [23:55:46] k [23:55:59] yeah it works fine for me in other environments [23:57:01] what do you mean by other environments? [23:57:45] jgonera: i mean it works fine for me in my usual dev environment [23:57:54] oh, right, same for me [23:57:58] same versions of MF and MW core [23:57:59] yeah [23:58:02] maybe the port is the issue? [23:58:28] i was wondering about that, but the set cookie response header has the port present in the hostname [23:59:13] this is what is ee in the response header: . Set-Cookie:mf_useformat=true; expires=Sun, 24-Aug-2014 23:58:35 GMT; path=/; domain=127.0.0.1:8080 [23:59:13] " [23:59:13] [23:59:13] [23:59:13] RFC 6265, which replaces RFC 2965, eliminates the Port parameter in the Set-Cookie header (because almost nobody actually used it in practice), and makes it very explicit that cookies on the same host ARE NOT distinquishable by ports anymore." [23:59:19] http://stackoverflow.com/questions/1612177/are-http-cookies-port-specific [23:59:29] so maybe the port shouldn't be there and that's the problem? [23:59:55] hmm