[00:00:15] oh, or actually the port should not be part of domain [00:00:21] yeah i think you're right [00:00:24] but if anything, a separate parameter [00:00:26] i see that in the comments on php.net/setcookie [00:00:36] 'When using your cookies on a webserver that is not on the standard port 80, you should NOT include the :[port] in the "Cookie domain" parameter, since this would not be recognized correctly.' [00:00:44] there is no port param in setcookie [00:00:49] i think we jsut need to strip the port num out of the hostname [00:00:53] right [00:01:14] i wonder if this is a problem elsewhere [00:01:24] i mean, other MW components trying to set cookies [00:01:35] probably not in production, but maybe for some third parties [00:05:00] there are a few really good reasons why i wrote setUseFormatCookie() the way i did but of course i can't remember them all now [00:05:11] ;) [00:05:42] usually in MW you would use WebResponse::setCookie() for this kinda stuff but we don't use that [00:05:55] i think we needed more control over setting cookie domains [00:06:33] it doesn't seem like it a very common need though [00:06:50] it=it's [00:07:37] what are we using right now to set it? [00:07:45] just php's setcookie [00:08:03] im fixing it now so it iwll work with vagrant but iw ant to make sure i dont fix it in a way that causes breakage elsewhere [00:08:29] there were/are a lot of subtleties around the cookie handling for this stuff which took a lot of itme to get wrong and im afraid of breaking it :p [00:08:43] lol i mean 'took a lot of time to get right' [00:14:59] i think things have evolved to a point where we can safely use WebResponse::setcookie() [00:25:51] (03CR) 10Kaldari: [C: 032] "Looks like this doesn't break anything (that wasn't already broken)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111146 (owner: 10Jdlrobson) [00:26:27] (03Merged) 10jenkins-bot: Hygiene: Cleanup naming convention for special page RL modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111146 (owner: 10Jdlrobson) [00:29:59] /topic awjr: there were/are a lot of subtleties around the cookie handling for this stuff which took a lot of itme to get wrong [00:30:15] hehehe [00:30:24] that was a funny slip [00:30:29] that is actually true [00:30:33] it just took even more time to get right :) [00:31:04] (03PS1) 10Kaldari: Adding an explanation to MobileSpecialPageFeed abstract class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115544 [00:31:33] (03PS2) 10Kaldari: Hygiene: Adding an explanation to MobileSpecialPageFeed abstract class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115544 [00:35:17] (03PS1) 10JGonera: Improve saving in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115549 [00:35:19] (03PS1) 10JGonera: Change header message when saving in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115550 [01:05:53] (03CR) 10Kaldari: [C: 032] Hygiene: Remove a FIXME from PhotoUploaderButton [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113050 (owner: 10JGonera) [01:06:56] (03Merged) 10jenkins-bot: Hygiene: Remove a FIXME from PhotoUploaderButton [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113050 (owner: 10JGonera) [01:14:24] (03PS4) 10Mhurd: Account creation interface and network operations. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/114889 [01:58:51] dr0ptp4kt: hey adam [01:58:59] dfoy, hello [02:13:30] (03PS1) 10Awjrichards: Update setUseFormatCookie() to use WebResponse::setcookie() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115556 [02:14:15] (03PS2) 10Awjrichards: Update setUseFormatCookie() to use WebResponse::setcookie() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115556 [03:11:14] (03Abandoned) 10Jhall: [QA] WIP Spoof physical geolocation for browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103512 (owner: 10Jhall) [04:27:56] (03CR) 10JGonera: [C: 032] Update setUseFormatCookie() to use WebResponse::setcookie() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115556 (owner: 10Awjrichards) [04:28:37] (03Merged) 10jenkins-bot: Update setUseFormatCookie() to use WebResponse::setcookie() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115556 (owner: 10Awjrichards) [18:16:25] brion: can you hear me? [18:37:55] YuviPanda: I can catch you up later if you like [18:38:09] if you're not feeling too hot right now [18:39:57] ok i'm gonna run into the office shortly for real this time... should make it in time for the iteration review mtg [19:09:02] kaldari: did you say you were looking at https://bugzilla.wikimedia.org/show_bug.cgi?id=61835 ? [19:09:16] yes [19:09:45] just assigned the bug to myself [19:10:30] kaldari: thanks :) [19:36:33] vbamba: so many cameras [19:38:23] YuviPanda: how is the audio ? [19:38:31] tfinc: usable. [19:38:42] this is the first time i'm using a chat 150 in this room [19:38:49] tfinc: ok, it started skipping now [19:38:53] a second or so now and then [19:39:04] YuviPanda: thats cause i was typing so it muted me :) [19:39:06] i told it to not too [19:40:58] tfinc: ah :) [19:40:59] ok [19:43:45] YuviPanda: has has the audio been since ? [19:43:58] how* [19:44:34] tfinc: yeah, very usable. not very different from the other rooms. [19:44:41] great [19:44:44] tfinc: quite very ncie [19:44:58] i was betting on just needing one chat 150 in this room [19:58:19] (03PS11) 10Jdlrobson: Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [19:58:39] (03CR) 10jenkins-bot: [V: 04-1] Adds a deep link to a mobile app if so configured [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [20:01:24] (03CR) 10Jdlrobson: [C: 031] "Needs a rebase and can't verify it does what it is suppose to do - deferring to Brion." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [20:26:50] tfinc: my battery is going to die in a few mins now [20:28:07] (03CR) 10Jdlrobson: [C: 04-1] "On a side note - kaity: kaldari awjr why are we asking "Are you sure you want to create a new page on Wikipedia?" when a new page is creat" (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 (owner: 10Kaldari) [20:30:20] jdlrobson: I agree. At least the language should be changed to something less intimidating sounding, like "Create page? Yes/cancel" [20:30:56] jdlrobson: I've talked with kenan about this too [20:32:46] jdlrobson: or a more helpful bit of information like "Before you save your new page, make sure you have: •links •references etc." [20:33:32] (03CR) 10Jdlrobson: [C: 04-1] "I'm a bit confused. This seems to make the button on alpha smaller not wider... Also isn't the point of mw-ui-block to make buttons wide -" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115523 (owner: 10Kaldari) [20:33:49] kaity: yeh that would make more sense if instead of a confirmation it was some kind of helpful checklist. [20:33:55] so is this a phase 1? [20:37:25] (03CR) 10Kaldari: "Yeah, that was specifically discussed at the estimation meeting. I'll elaborate in the commit summary..." (038 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 (owner: 10Kaldari) [20:41:42] how can I bind to #anchor changes in jQuery? [20:42:29] MaxSem: $(document).bind('hashchange') i think [20:42:44] $(window) rather [20:42:45] whee - thanks, brion:) [20:42:47] https://developer.mozilla.org/en-US/docs/Web/API/Window.onhashchange [20:56:33] awjr, I'll be 5 minutes late for the review and estimation [21:07:43] https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1520 [21:11:42] jdlrobson: MaxSem kaldari jgonera: http://hatjitsu.wmflabs.org/22040 [21:24:57] YuviPanda: hey [21:36:52] (03CR) 10Denny Vrandecic: Adds a deep link to a mobile app if so configured (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112921 (owner: 10Denny Vrandecic) [21:42:08] YuviPanda: thanks again for the api example... hooking it up now [21:44:55] YuviPanda: mhurd: how is our build looking today? [21:52:02] tfinc: if my patch passes review should be good to go. will ping brion when i see him come online [21:52:14] k [21:53:01] tfinc: moiz asked about getting ios build - i don't think i can add people. can u if he's not already? [21:55:00] just forward him the email when it goes out [21:55:15] the enterprise distribution doesn't require sign up [21:55:33] that was our big reason for signing up for it [22:22:00] tfinc: *i forgot people can just go to the announcement on the list for builds* [22:22:12] tfinc: no much simpler [22:27:03] tfinc: preview story is coming along pretty quickly - already have the basics hooked up [22:30:21] kaldari: do you know if a bug ever got filed for content being off center in mobile on tablet? [22:30:56] kaity: That was fixed last week and should probably land on en.wiki tomorrow [22:31:08] cool thanks! [22:31:23] (03PS1) 10MaxSem: Intercept new links in MF overlays [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/115809 [22:44:19] kaldari: https://gerrit.wikimedia.org/r/#/c/111147/ didn't seem to get merged btw? [22:44:24] awjr: lol at loomio comment [22:44:43] :p [22:45:20] (03PS1) 10Kaldari: Make sure highlighted VE tools don't overlap bottom border [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115812 [22:45:39] (03CR) 10Jdlrobson: [C: 032] Hygiene: Adding an explanation to MobileSpecialPageFeed abstract class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115544 (owner: 10Kaldari) [22:46:34] (03Merged) 10jenkins-bot: Hygiene: Adding an explanation to MobileSpecialPageFeed abstract class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115544 (owner: 10Kaldari) [22:59:57] (03CR) 10Jdlrobson: [C: 032] Improve saving in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115549 (owner: 10JGonera) [23:00:34] (03Merged) 10jenkins-bot: Improve saving in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115549 (owner: 10JGonera) [23:01:30] (03PS3) 10Jdlrobson: Using @custom-browser Cucumber tag instead of @user_agent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113776 (owner: 10Zfilipin) [23:02:11] (03CR) 10Jdlrobson: [C: 032] "I rebased on behalf of @Zfilipin" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113776 (owner: 10Zfilipin) [23:02:58] (03Merged) 10jenkins-bot: Using @custom-browser Cucumber tag instead of @user_agent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/113776 (owner: 10Zfilipin) [23:03:44] (03CR) 10Kaldari: "Not sure what to say about this one. Moiz wants the button to not be full width (mw-ui-block), but he thinks the regular width is too smal" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115523 (owner: 10Kaldari) [23:03:58] jdlrobson: ^ [23:04:04] (03CR) 10Jdlrobson: [C: 032] Change header message when saving in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115550 (owner: 10JGonera) [23:04:46] (03Merged) 10jenkins-bot: Change header message when saving in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115550 (owner: 10JGonera) [23:07:51] awjr: does bingle handle moving cards from awaiting final code review to ready for sign off? [23:08:01] no jdlrobson [23:08:10] awjr: :( [23:08:27] though that would probably need to be handled by the non-existent geringle [23:09:05] jdlrobson: i think it would be particularly challenging, especially since one card may have many patchsets [23:09:22] but it would be nice [23:09:29] kaldari: http://tools.wmflabs.org/styleguide/ [23:14:15] YuviPanda: u still up? [23:29:47] (03PS4) 10Kaldari: Story 1643: Final tweak on talk page styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115523 [23:33:51] (03CR) 10Jdlrobson: [C: 032] Use EditorApi in PhotoApi to add image to page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114681 (owner: 10JGonera) [23:34:28] (03Merged) 10jenkins-bot: Use EditorApi in PhotoApi to add image to page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114681 (owner: 10JGonera) [23:35:22] (03CR) 10Jdlrobson: [C: 032] Make sure highlighted VE tools don't overlap bottom border [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115812 (owner: 10Kaldari) [23:35:58] (03Merged) 10jenkins-bot: Make sure highlighted VE tools don't overlap bottom border [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115812 (owner: 10Kaldari) [23:37:56] (03CR) 10Jdlrobson: [C: 032] Story 1643: Final tweak on talk page styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115523 (owner: 10Kaldari) [23:38:31] (03Merged) 10jenkins-bot: Story 1643: Final tweak on talk page styling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115523 (owner: 10Kaldari) [23:42:14] (03PS7) 10JGonera: Story 1629: AbuseFilter support in lead photo uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114908 [23:52:42] kenanwang: are you around? [23:53:08] got some q's, i'm at the big table on the other side if you have time [23:55:14] (03CR) 10Jdlrobson: [C: 032] Fix overlay header shifting on iOS in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115337 (owner: 10JGonera) [23:56:11] (03Merged) 10jenkins-bot: Fix overlay header shifting on iOS in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115337 (owner: 10JGonera)