[00:03:42] mhurd: hey are you free? [00:03:55] we're at the big table if youre free to chitchat [00:04:51] violetto: ya [00:05:00] mhurd: come over! [00:10:39] chrismcmahon: is it possible to use sub directories in step_definitions folder? I'm noticing a pattern of file disorganization and I think having folders would help this problem. For instance we have things in common_article_steps that should be in editor_steps [00:12:04] jdlrobson: this is pretty close to what i had http://www.amazon.com/ACE-Deluxe-Wrist-Brace-Right/dp/B005YU8VBQ [00:12:11] YuviPanda has mine now [00:14:26] jdlrobson: better to refactor the files themselves I think [00:14:50] jdlrobson, jgonera: looks like something recently merged broke redlinks from working in master. Debugging now. [00:14:59] jdlrobson: message the QA mail list? I know Zeljko has definite opinions about that sort of thing [00:15:03] chrismcmahon: i want to avoid this happening in future rather than reacting to it. chrismcmahon: we had the same issue in our JavaScript and reorganizing files helped a lot with this [00:15:09] chrismcmahon: ok will do [00:15:18] kaldari, I'm not sure if I understand [00:15:21] at moment though i was just curious if it was possible off the top of your head [00:15:32] kaldari, oh, I see [00:15:44] jgonera: If you click on a redlink on beta labs, it just says redirecting to editor forever [00:15:52] I see [00:27:19] kaldari, thanks, will have a look in a moment if jdlrobson doesn't before me [16:55:19] hi mobilefolk, I'd like to ask for some eyes for this one: https://bugzilla.wikimedia.org/show_bug.cgi?id=62004 [17:04:57] web guys are probably not at the office yet but lemme take a peek :) [17:08:06] chrismcmahon: works for me as a user on current master [17:08:25] did the html structure change from what the test expects maybe? [17:09:51] brion: not sure what's going on, I was just about to attach a screen shot [17:10:53] chrismcmahon: whoa it's definitely broken on en.m.wikipedia.beta.wmflabs.org [17:11:03] brion: ok, good :-) [17:11:04] http://en.m.wikipedia.beta.wmflabs.org/wiki/0.160069379996449#editor/0 <- just shows "Starting a new page using the URL" [17:11:38] on another page, it shows content text but all the UI is still missing [17:11:44] brion: that is the correct text for that page, but I see no way to edit the page [17:11:54] yeah it's broke [17:12:04] works fine on my local on master, maybe it's outdated [17:12:20] brion: fwiw, no fatal errors on beta from MF [17:12:55] brion: I'll ask hashar, but the 3-minute update on beta labs for master branch has been pretty reliable [17:15:14] actually, I am pretty sure it is correct because this is a new issue as of what went to master and beta labs late yesterday, the overnight test build failed [17:20:44] hi brion! [17:20:50] pandaaaaa [17:20:51] I sent up a couple of patches [17:21:19] excellent. lemme coffee up and i'll look over em [17:21:52] brion: :) [17:30:25] yuvipanda: your patches seem to need rebasing :( https://gerrit.wikimedia.org/r/#/c/115871/ [17:32:03] brion: did we get a build for android out last night ? i only saw an iOS email [17:32:35] ah no lemme finish that up before we pile on more patches [17:32:54] * brion syncs up git [17:33:29] brion: gaah [17:33:51] brion: wait for a couple of minutes, let's send it out with these? [17:34:07] ok :) [17:35:16] ah yeah the logs-you-in-on-create fix will be nice [17:36:13] hmm i wonder if samsung will ever actually ship these tizen phones: http://arstechnica.com/gadgets/2014/02/hands-on-with-samsungs-tizen-os-a-impressively-capable-android-clone/ [17:38:37] (03PS2) 10Yuvipanda: Make sure dir attribute is set on RTL pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115871 [17:38:39] (03PS2) 10Yuvipanda: Hide softkeyboard when exiting create account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115874 [17:38:41] (03PS2) 10Yuvipanda: Login the user right after they create an account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115872 [17:38:43] (03PS2) 10Yuvipanda: Make sure sidebar says log in only if user is logged out [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115873 [17:39:13] brion: ^ [17:39:31] whee [17:45:53] yuvipanda: payload.toString(4) ? [17:45:56] whats the 4 mean [17:46:22] ah indent factor [17:46:31] in obj-c you wouldn't have this problem ;) [17:46:43] because the method name would be toStringWithIntentFactor: :P [17:46:47] brion: heh, just debug :) [17:46:47] *Indent [17:46:52] lol [17:47:51] brion: :) [17:49:14] i'm really practicing my hebrew typing with these rtl tests [17:49:17] brion: I'll talk to may today about how to surface errors in the login-after-acct-creation patch [17:49:18] brion: heh :) [17:49:27] only thing i know how to type is 'jerusalem' though [17:49:31] and that only by repetition :P [17:49:31] yuvipanda: okay :D [17:49:56] violetto: :P [17:51:11] (03CR) 10Brion VIBBER: [C: 032 V: 032] "hebrew article & preview appears RTL yay" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115871 (owner: 10Yuvipanda) [17:51:16] hi violetto [17:51:32] yuvipanda: sup [17:53:04] violetto: so, question. [17:53:15] violetto: in create account, when you create an account, we need to make some more requests to log you in [17:53:28] violetto: and those can have errors - like 'too many attempts' or 'network'. Where should we display those? [17:53:52] yuvipanda: remember the top banner you showed us? [17:54:09] the thin banner at the top of the screen [17:54:40] violetto: yeah [17:54:56] violetto: but then what action can the user take? his account creation was successful, but just the login isn't [17:54:57] yuvipanda: last we said we're using that [17:55:06] yuvipanda: hmm [17:55:20] well you can retry if it was a network error [17:55:41] brion: how many times? at some point we need to give up [17:55:49] brion: long spinners that seem to keep spinning make the app look broken [17:55:52] well *we* give up [17:55:54] the user doesn't have to [17:56:41] brion: yeah, agree, but we just need to indicate that something's wrong. [17:56:44] what kind of actions we want the user to take? [17:56:50] after seeing an error [17:56:52] (03CR) 10Brion VIBBER: [C: 04-1] "java: /Users/brion/src/wiki/apps-android-wikipedia/wikipedia/src/main/java/org/wikipedia/createaccount/CreateAccountActivity.java:178: can" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115872 (owner: 10Yuvipanda) [17:59:50] brion: updated [17:59:52] (03PS3) 10Yuvipanda: Hide softkeyboard when exiting create account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115874 [17:59:54] (03PS3) 10Yuvipanda: Login the user right after they create an account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115872 [17:59:56] (03PS3) 10Yuvipanda: Make sure sidebar says log in only if user is logged out [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115873 [18:00:14] violetto: 'retry logging in' and 'try again later (you can log in from the sidebar menu)' [18:00:17] tx [18:00:37] awjr: heads up for https://bugzilla.wikimedia.org/show_bug.cgi?id=62004 . I think MF gets deployed today [18:01:23] thanks for the head's up chrismcmahon [18:01:30] yuvipanda: that would mean they successfully created account, but just cannot log in at that time [18:01:34] correct? [18:01:40] violetto: yup! [18:01:48] yuvipanda: lemme think.. [18:02:08] jdlrobson: have you seen this? https://bugzilla.wikimedia.org/show_bug.cgi?id=62004 [18:02:35] awjr: of course - i'm the all seeing bug eye ;-) [18:02:43] :) [18:03:14] our very own sauron [18:03:35] awjr: i think it's related to jgonera's iOS fix [18:04:06] are you able to reproduce locally? brion said he couldn't, i haven't quite gotten to testing it yet [18:04:30] i coulnd't on master [18:04:38] don't know if beta labs is running master or a branch tho [18:04:44] check Special:Version [18:04:47] it should be running master [18:04:48] should be master [18:04:51] though it may be out of sync [18:05:03] yuvipanda: i imagine our message will be somewhere along the lines of "your account has been created, but we are experiencing errors logging you in. Try again or you can log in on the left menu" [18:05:13] violetto: yeah, that sounds about right [18:05:14] awjr: I thought of that, this bug got introduced overnight so master update is likely working properly [18:05:18] violetto: I just don't know where to put that [18:05:37] violetto: since your account creation is done, so you don't want to put that on top of the account creation form. [18:05:48] and im imagining we can bring them to another screen that says "account creation successful" with a big successful icon [18:05:53] yuvipanda: yeah [18:06:16] no still unable to replicate on master [18:06:18] this is what is weird [18:06:19] yuvipanda: let me draw something up [18:06:23] violetto: sweet [18:06:36] yeah i wonder if there's something else interfering [18:06:44] although now betalabs seems totally unresponsive to me right now [18:06:46] ah there we go [18:07:07] yeah, betalabs is indeed at current head of master [18:07:22] jdlrobson: why do you suspect jgonera's ios fix? [18:07:30] jgonera: https://bugzilla.wikimedia.org/show_bug.cgi?id=62004 [18:07:32] as that was the last thing to touch the header awjr [18:07:52] chrismcmahon: is it possible to git bisect on betalabs? [18:07:54] MF seems to be at master per Special:Version https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FMobileFrontend.git/d735ff615a19949fac3311879e28cf18f87ebdaf [18:08:15] brion: think you can merge? :D [18:08:27] 01:03, 27 February 2014 [18:08:41] isn't it again a caching issue with beta labs? [18:09:44] jgonera: does seem so [18:09:50] jgonera: with debug=true it works [18:10:00] (03CR) 10Brion VIBBER: [C: 04-1] "After creating the account I got a progress indicator saying "Logging in..." but the menu still shows "Log in" as though it hasn't updated" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115872 (owner: 10Yuvipanda) [18:10:03] chrismcmahon: ^^ [18:10:12] the css doesn't seem to be loading [18:10:28] brion: we'll probably be killing the entire 'logging in' thing once violetto draws up a UX, so I think that's ok [18:10:49] yuvipanda: ....? [18:10:52] you mean it won't log you in? [18:10:54] that sounds bad [18:11:07] plus then we can just discard this rev instead of merging it? [18:11:10] brion: no, we'll have a small screen/dialog saysing 'account creation sucscess! logging you in now...' and we can put errors there also [18:11:20] brion: this actually logs you in, just the way of notifying the user would change [18:11:29] ok well that doesn't seem to be related to it failing to update the menu does it? [18:11:50] debug=true does not solve the problem for me [18:11:53] i can't for instance create an account and then immediately log out [18:11:57] awjr: it doesn't? mm [18:12:02] brion: oh wait [18:12:04] brion: aaah, I got confused [18:12:05] in fact i may be seeing something different than what's described [18:12:07] brion: that's fixed in the next patch [18:12:21] brion: it's in the series :) [18:12:21] when i tap the pencil icon, i see a screen that just says 'Starting a new page using the URL' [18:12:23] why's that not in the same patchhhhhhhhhh :) [18:12:38] "break stuff" followed by "unbreak stuff" is always painful to review [18:12:53] jgonera: jdlrobson are you guys in stable? [18:13:00] awjr: yup [18:13:07] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok apparently that's fixed in the next commit. Sigh." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115872 (owner: 10Yuvipanda) [18:13:09] brion: smaller commits are better :) plus they are logically unrelated :) [18:13:16] brion: I'll make sure to mention it in the commit message next time [18:13:45] (03PS5) 10Kaldari: Story 1685: Improve red links support in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 [18:13:57] awjr: opacity: 0; is the reason [18:14:02] yuvipanda: something like that https://www.dropbox.com/s/npwqg1evuwbj025/Screenshot%202014-02-27%2010.13.51.png [18:14:04] jgonera: jdlrobson chrismcmahon this is what im seeing: http://imgur.com/saFyzgP,SBy1GTm [18:14:08] i'm currently debugging why that doesn't get overriden [18:14:14] awjr: yeh i'm seeing that without debug=true [18:14:23] jdlrobson: the second image in that set has debug=true [18:14:29] and its the same issue [18:14:33] awjr: gimme 10 minutes i almost have the fix [18:14:37] cool [18:14:42] violetto: that's good! But I think we can use this for showing progress too [18:15:04] that's a great idea [18:15:15] (03PS6) 10Kaldari: Story 1685: Improve red links support in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 [18:15:16] when user taps retry? turns into progress [18:15:19] yuvipanda: [18:15:33] awjr: it is jgonera's patch [18:15:39] maybe we should just revert for now? [18:15:41] violetto: there's a progress bar now, says 'loggging in'. we can instead have this say 'account createion scucess! logging you in now...' [18:15:48] i'm just not sure why [18:15:48] unless there's an obvious fix [18:15:53] violetto: and then if it fails we change the message and icons [18:15:53] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make sure sidebar says log in only if user is logged out [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115873 (owner: 10Yuvipanda) [18:16:00] awjr can you type in there? Is it a text area? [18:16:09] jgonera: yes [18:16:15] yuvipanda: can you show me how that looks [18:16:17] but it is not a new page :p [18:16:28] violetto: let me send you a build [18:16:29] oh [18:16:29] lol [18:16:29] huh [18:16:35] but the actual text of the page is 'Starting a new page…' [18:16:38] http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=0.9345566971473819&campaign=random [18:16:42] >_< [18:16:43] okay [18:17:04] violetto: wait, you probably can't create account on office wifi, mhurd's got it blocked again :P [18:17:08] violetto: want to hangout? [18:17:08] just fyi... (11:09:10 AM) logmsgbot: !log bd808 Started scap: testwiki to php-1.23wmf16 and rebuild l10n cache [18:17:35] Reedy: we've got an issue with MobileFrontend on betalabs - can you hold off on pushing changes for a few minutes? i think we're close to a fix [18:17:38] yuvipanda: yeah [18:17:45] violetto: ok moment [18:17:54] oh actually that's bryan davis [18:18:03] awjr: Reedy is not around, greg-g either. it's bd808 deploying today [18:18:29] chrismcmahon: aye, just realized that thanks [18:18:32] violetto: I'm calling [18:19:21] awjr: are you 100% sure it doesn't work without debug = true? http://en.m.wikipedia.beta.wmflabs.org/wiki/Forty-seven_Ronin?debug=true#editor/0 [18:19:25] violetto: says you aren't available :( [18:19:26] (03CR) 10Brion VIBBER: [C: 032 V: 032] Hide softkeyboard when exiting create account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/115874 (owner: 10Yuvipanda) [18:19:34] brion: \o/ build tiem :) [18:19:43] awjr browser cache disabled? [18:19:43] brion: can you also poke kenanwang about getting the stories signed off [18:19:44] yuvipanda: was lookginf ro headphones [18:19:46] woo [18:19:54] ok, i got bryan to hold off on deploying beyond test2 [18:19:55] awjr: it's definitely cache related [18:20:18] jdlrobson: debug=true still does not work for me [18:20:23] wtf [18:20:50] jdlrobson: http://imgur.com/Pzsvb17 [18:21:33] awjr: try localStorage.clear() [18:21:42] jdlrobson: wait im an idiot [18:21:47] i was putting the query after the hash [18:21:49] awjr: i figured ;-) [18:21:52] :p [18:21:58] putting ?debug=true before the hash works [18:22:17] brion: gonna put together a patch for the bugs u found [18:22:24] haha [18:23:27] i have no idea how cache stuff works with betalabs; whats the TTL for RL caching? [18:23:34] ok [18:24:00] awjr: maybe merging a new patch will fix it :) [18:24:00] so should we assume we're good if we touch the files after deploy? [18:24:22] (03CR) 10Jdlrobson: [C: 032] Story 1629: AbuseFilter support in lead photo uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114908 (owner: 10JGonera) [18:24:58] (03Merged) 10jenkins-bot: Story 1629: AbuseFilter support in lead photo uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/114908 (owner: 10JGonera) [18:25:07] jgonera: anyway to summarize what i discovered - it seems the visible class never gets added to overlay-header-container [18:25:07] jgonera: it's your call [18:25:13] (or it gets removed) [18:25:24] jgonera: as tech lead :) [18:26:12] violetto: woo! [18:26:14] jdlrobson what do you mean by never? Even with debug=true? [18:26:20] jgonera: without debug=true [18:26:24] this is why the header is invisible [18:26:47] oh yeah, sure, new CSS, old template [18:27:07] him maybe our templates mess up RL cache [18:27:29] jgonera: i'm not sure why it would be removed [18:27:32] I say we're good and in the worst case we touch the files [18:27:33] if you inspect the template it is still there [18:27:49] jgonera: let bd808 know in #wikimedia-operations [18:27:51] it is? [18:27:56] let me see [18:28:15] :( [18:28:27] actually no [18:28:28] that's a lie [18:28:32] mw.template.get( 'modules/editor/EditorOverlayBase' ).text > no visible class jgonera [18:28:43] so yeh there's probably an issue in template RL caching [18:28:49] which wouldn't surprise me [18:28:49] well, that's what I'm saying [18:28:51] ok build announce mail to mobile-tech [18:28:54] brion: \o/ [18:28:55] tfinc: https://releases.wikimedia.org/mobile/android/apps-android-wikipedia-sprint25.apk [18:29:13] jdlrobson: jgonera do you think touching or changing the template file would work? [18:29:14] wait.. wtf [18:29:28] force an update to last modified [18:30:05] getModifiedTime for MFResourceLoaderModule.php is totally wrong! [18:30:15] yuvipanda: https://www.dropbox.com/s/xz50l8rsv5ftaj2/Screenshot%202014-02-27%2010.29.51.png [18:30:17] it seems to check i18n file to check for updates [18:30:25] yuvipanda: that's what we talked about right [18:30:41] violetto: yeah, pretty much [18:30:41] huh [18:30:58] violetto: although we can't say '40%' - we can't give any percentages so we'll just have to put an indeterminate spinner there or somesuch [18:31:17] yuvipanda: i see. ok [18:31:42] We've had this code since july erggg [18:31:58] jgonera: basically MFResourceLoaderModule.php::getModifiedTime is used for RL caching [18:32:16] ours updates only every time there is an i18n or MobileFrontend.php change [18:32:20] this is extremely hacky [18:32:27] it pays no attention to file changes or template changes [18:32:34] i'm on it [18:33:53] violetto: we might also want to emphasize that it failed in some way. [18:34:09] jdlrobson, earlier than July, in July MaxSem only fixed paths for those files [18:34:13] yuvipanda: do you have examples? [18:34:22] ergg [18:35:10] jdlrobson, ergg indeed, but at least we know what's going on ;) [18:35:16] jgonera: i'm fixing it now [18:35:31] in mean time if you can find when that was introduced that would be useful [18:35:41] it would explain a lot of our caching issues [18:35:55] violetto: of what? [18:36:04] violetto: i meant, adding an icon or somesuch? [18:36:35] yuvipanda: you said emphasize it failed in some way, did you mean a different error message? [18:36:45] oh changing check to soemthing else? [18:36:46] violetto: no, I meat not have the tick for both of them? [18:36:48] violetto: yeah [18:37:44] jdlrobson, are you getting inspiration from ResourceLoaderFileModule's version of this method? [18:37:51] jgonera: exactly [18:38:32] yeah, if anything we could show them a graphic like this https://www.dropbox.com/s/gn66mfgsevbt0is/Screenshot%202014-02-27%2010.38.12.png to show them where left nav to log in [18:38:49] i dont want to show anything negative for something small [18:38:59] violetto: hmm, ok [18:39:05] violetto: fine, this is good enough :) [18:39:09] yuvipanda: yeah showing solution instead of problem [18:39:26] violetto: I'll just animate the text out and then animate the error message in, and I think that should be enough [18:39:34] violetto: can you make a card and put it on the design board? [18:40:03] yuvipanda: yip yip [18:40:11] violetto: \o/ sweet! [18:40:25] violetto: brion would've sent out a build now, do try it for the rest of the stuff :) [18:40:37] jdlrobson, potentially b016ce10 but I'm still checking [18:41:11] yuvipanda: i weel! [18:42:08] violetto: I've no shoes on :P [18:42:33] yuvipanda: me neither! [18:42:43] violetto: wooo for having neither fancy nor unfancy shoes! :) [18:43:12] jdlrobson, yeah, it's b016ce10, it's been like that since January 2013, i.e. since we had MFResourceLoaderModule [18:43:24] yuvipanda: lol! [18:43:30] argggh how did that go unnoticed for so long [18:43:32] yuvipanda: can't wait for you to be here [18:43:45] violetto: college still is fumbling with the goddamned certificate :( [18:44:02] yuvipanda: do you need me to kick down some doors? [18:44:13] vbamba: hey! You should poke Oliver for stats about how many people have the gadget on [18:44:30] violetto: I wish. if I kick an actual door down they will probably want to talk about that to me for 2 weeks and delay the cert [18:44:43] yuvipanda: i'll kick em [18:44:58] violetto: I'll send you an address [18:45:15] yuvipanda: i'll send a broken door postcard [18:45:51] violetto: :D can you also poke vibha to try out the new build? [18:46:10] vbamba: !! ;P [18:46:18] yuvipanda: when i get to work i'll ask her [18:46:24] violetto: ok! [18:48:27] brion: have a sec to review crash fix? [18:49:07] (03PS1) 10Mhurd: Fix for iOS 6 account creation crash. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/115950 [18:49:15] brion: ^ [18:53:03] jgonera: jdlrobson i am not seeing the problem on test2wiki - did you guys do anything special there, or did it just work? [18:53:33] awjr: it's probably because i18n changes happen there [18:53:41] in beta labs changes are pushed straight away [18:53:44] jdlrobson: i dont follow [18:53:57] awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=62010 [18:54:13] mhurd: lemme look [18:54:16] ahha [18:54:32] ok jdlrobson jgonera can one of you follow up to the email i sent to mobile-tech about the issue? [18:54:51] awjr: it's all in the bug report [18:54:57] https://bugzilla.wikimedia.org/show_bug.cgi?id=62010 < i just added a comment [18:55:15] jdlrobson: i don't think everyone on mobile-tech is glued to the bug report or necessarily getting updates [18:55:20] just respond quickly to the email to close the loop [18:55:24] awjr: well they should be :) [18:56:06] MaxSem: any reason you did it the hacky way (looking at https://gerrit.wikimedia.org/r/#/c/46885/9/includes/modules/MFResourceLoaderModule.php now and you say Per IRC discussion, please use ../../MobileFrontend.php here) [18:56:32] what a nice bug to have found [18:56:59] (03PS1) 10Jdlrobson: Update last modified time when a template or file changes in MFResourceLoaderModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 [18:57:09] ^ fix there awjr chrismcmalunch MaxSem jgonera [18:57:10] chrismcmalunch, thanks again [18:57:16] brion: having trouble reproducing the ios 6 search bug you were seeing... hmmm... [18:57:29] jgonera: i saw you gave bryan the go-ahead on deploy - can you keep an eye out for when changes get pushed to mediawiki.org so we can ensure things are OK there? i think he's waiting to do that til after lunch [18:57:44] (03CR) 10Brion VIBBER: Fix for iOS 6 account creation crash. (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/115950 (owner: 10Mhurd) [18:58:40] awjr, I see, ok [18:58:46] brion: updating based on your comment no keychain error [18:58:56] "on" [18:59:01] jdlrobson: not everyone on the team is in a position to be glued to bugzilla and as a team we agreed a long time ago that the mailing list is the definitive place of communication [18:59:17] jdlrobson, hmm. __FILE__ in that context is the code file which is not directly related to module content [18:59:25] thanks jgonera [18:59:35] awjr: i still think they should be but i've sent a mail linking to the bug report [18:59:52] mhurd: ok confirmed it fixes the crash \o/ [18:59:53] mhurd: you got the preview API stuff right? [18:59:55] thanks jdlrobson [18:59:58] RL timestamps are supposed to change when content changes, not some code related to them [19:00:11] YuviPanda: yes! thank you again!!! [19:00:14] MaxSem: https://gerrit.wikimedia.org/r/115952 is how it should have been implemented [19:00:23] brion: yay! [19:00:34] mhurd: :) [19:00:34] search bug still totally there tho :( [19:00:47] brion: hmmm on en wiki? [19:00:51] Originally the timestamp only needed to change when a template file or a message changed but now it inherits from ResourceLoaderFileModule it also needs to pay attention to file changes [19:01:08] aharoni: I just reused your hack from the old app :) [19:01:10] some how we were paying attention to nothing directly related to the module (relying on i18n message changes) [19:01:11] mhurd: i'm on test atm.... it seems to happen when i type too fast [19:01:16] if i type real slow i don't get the bug [19:01:17] makes sense [19:01:24] maybe something's failing to pass a cancel through [19:01:28] brion: ah. i'll try that [19:02:34] brion: can you send the new release to mobile-l as well ? [19:02:42] i'd like to see some volunteers on it [19:02:44] sure moment [19:02:55] jdlrobson, http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-mobile/20130206.txt [19:04:05] [19:06:27] MaxSem: so can we live with this screwup or could you make an adjustment that does the job? [19:04:05] [19:06:52] can't think of a sane way... down with it for now [19:04:06] lol [19:04:12] famous last words [19:04:34] "I'll cut the red wire..." [19:04:39] lol [19:05:09] "This bear is tame..." [19:05:34] "Don't worry, this gun is not loaded..." [19:05:37] brion: looks like search ops are being cancelled properly... [19:05:51] "Yeah, that water is clean" [19:06:32] (03PS2) 10Mhurd: Fix for iOS 6 account creation crash. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/115950 [19:07:12] brion: ^ i uncommented that one keychain NSLog [19:08:12] tfinc: sent [19:08:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for iOS 6 account creation crash. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/115950 (owner: 10Mhurd) [19:08:46] brion: was the ios6 behavior you're seeing in the simulator or on device? [19:09:37] mhurd: device [19:09:46] lemme test in sim and see if it does it [19:10:34] interesting. i'm not seeing it on simulator [19:10:43] lemme try another device [19:10:50] brion: ooooh! cool! i will test on device.... [19:11:28]