[00:00:11] (03CR) 10Jdlrobson: [C: 04-1] "Caching implications" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115978 (owner: 10MaxSem) [00:02:19] jdlrobson: as currently written, are tests passing for you? [00:02:33] yes but if i uncomment the test case i want to work it fails [00:03:10] jdlrobson: do you by chance have a link to api documentation for the mock stuff? im having a hard time finding anything besides the cursory explanation of test doubles in the phpunit docs [00:03:39] awjr: nope.. going in blind. My experience in PHPUnit is pretty mininal [00:04:06] ergh ok, so i have no idea what $mock::staticExpects($this->any())->method( 'safeFilemtime' )->will($this->returnValue(42)); is supposed to really do... [00:04:44] and further i can't find a method called getTemplateLastModifiedTime anywhere - am i missing something? [00:05:07] (03CR) 10Jcf2000: "Actually, scratch that. It'll be better if you open the task up for someone else. I don't really have much time on my hands anymore, so I " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000) [00:05:10] but i am eager to help :) [00:05:36] (03CR) 10Jdlrobson: [C: 04-1] "This is extremely hacky. I'm convinced there is a better way then resorting to hiding in CSS." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115995 (owner: 10MaxSem) [00:06:49] (03CR) 10MaxSem: "Removing it in MobileFormatter would go against our goal to get rid of HTML transformations." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115995 (owner: 10MaxSem) [00:06:56] jdlrobson, ^ [00:08:28] MaxSem: we override section edit links on non-file pages - why can't this be any different? [00:08:53] because we don't parse commons pages ourselves [00:09:00] we just get what we get [00:09:02] jdlrobson: im happy to help with the mock stuff but i need some more explanation [00:09:19] anyway MaxSem i'll take a look soon - i'm currently in an RFC review [00:09:33] awjr: i know nothing more than the fact that the test fails when i uncomment those 2 lines [00:10:06] jdlrobson: can you explain to me what $mock::staticExpects($this->any())->method( 'safeFilemtime' )->will($this->returnValue(42)); is supposed to do? [00:10:15] jdlrobson: also, i can't find a method called getTemplateLastModifiedTime anywhere - am i missing something? [00:11:30] awjr: where are you seeing getTemplateLastModifiedTime ? [00:11:56] https://gerrit.wikimedia.org/r/#/c/115952/2/tests/modules/MFResourceLoaderModuleTest.php line 173 [00:11:57] (03CR) 10Jdlrobson: Update last modified time when a template or file changes in MFResourceLoaderModule (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 (owner: 10Jdlrobson) [00:12:04] jdlrobson: ^^ [00:12:16] awjr: whoops that should be safeFilemtime [00:12:53] (03CR) 10Jdlrobson: Update last modified time when a template or file changes in MFResourceLoaderModule (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 (owner: 10Jdlrobson) [00:12:59] awjr: added some notes ^ [00:16:39] i wonder if the problem is that safeFilemtime is a protected static method [00:16:54] what's weird is that the test doubles doc says you can't mock static methods [00:17:04] but http://sebastian-bergmann.de/archives/883-Stubbing-and-Mocking-Static-Methods.html suggests otherwise [00:31:13] awjr: it sounds like they introduced it and then threw it away :( [00:31:26] i'm very confused [00:31:39] (03PS1) 10Kaldari: Story 1732: Some preliminary clean-up for new licensing messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116016 [00:32:19] (03CR) 10Awjrichards: [C: 04-1] "I don't think what you're trying to do is really achievable. See inline comments. You may need to abandon unit tests for this." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 (owner: 10Jdlrobson) [00:35:07] jdlrobson: yeah, i think it's best to ditch that stuff [00:36:26] conceptually, i dont like that approach anyway. it seems rather fragile to me and ultimately not like a particularly useful unit test [00:37:50] awjr: so i'm confused - jgonera wants unit tests … how do i proceed with this - this is quite an important part of our stack so we probably should have some sort of coverage :) [00:37:54] is PHP really that bad? ;-) [00:37:58] (03CR) 10Awjrichards: "Further, I agree with Max. What you're working with isn't realistically testable, at least not in a non-fragile, hacky way. I say ditch it" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 (owner: 10Jdlrobson) [00:38:17] jdlrobson: it's not php's fault [00:38:36] but the components you're relying on in mediawiki make what you're trying to do inherently not testable [00:38:42] or at least inherently not unit-testable [00:39:33] generally speaking, MW was not written in a way that makes it particularly unit testable [01:12:04] kaity: That's great for us, but won't work for 3rd parties. [01:12:28] kaldari: can we do it anway? [01:12:49] kaity: We could make it configurable [01:25:51] violetto: can I have an SVG for https://bugzilla.wikimedia.org/show_bug.cgi?id=58622 please? :) [01:27:01] (03CR) 10Jdlrobson: [C: 032] Story 1685: Improve red links support in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 (owner: 10Kaldari) [01:27:47] (03Merged) 10jenkins-bot: Story 1685: Improve red links support in Beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115326 (owner: 10Kaldari) [01:41:49] (03CR) 10Kaldari: [C: 04-1] Make special pages always have a route from desktop to mobile (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115955 (owner: 10Jdlrobson) [01:44:16] (03PS1) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [01:46:36] prtksxna: here now [01:46:40] are you still there? [01:49:33] vbamba: kaity: jgonera: leaving in 10 [01:49:50] mhurd, got it [17:52:23] qgil: Hello. Could you please give me a list of all possible projects for Google Summer of Code? I would like to work as an Android app developer. [17:54:36] Avishek: have you looked at http://www.mediawiki.org/wiki/Summer_of_Code_2014 [18:04:14] hi all, I am kalyan. I am a android developer and web developer. I would like to contribute to wikipedia mobile apps. Kindly guide me to contribute to wiki code base. thanks in advance [18:04:52] I actually set up my android project environment by reffering to this github link https://github.com/wikimedia/apps-android-wikipedia [18:05:01] kalyan: thanks. [18:06:29] Avishek: can u please guide me how i can start with contributing? [18:09:49] YuviPanda, ^ [18:10:57] kalyan: even i am a beginner. [18:11:06] @Avishek: oh okay [18:15:10] ?? can anyone spend few minutes to help me out? [18:16:09] kalyan: the guys who work on the apps are all in a mtg right now [18:16:20] they should be done in ~15 mins or so and will likely be able to help you out then [18:16:47] awjr: oh okay thank you [18:16:56] i will wait thanks once again [18:17:01] np kalyan [18:17:21] people to look out for in particular are YuviPanda, brion, and mhurd [18:18:40] okay i actually personally know yuvi panda and i just pinged him but since u said they r in mtg he is not replying so i will wait and ask guidance from hime [18:18:53] awjr: thanks for telling! :) I am in the same fix! [18:18:59] :) [18:19:13] kalyan: same here! [18:19:21] :) [18:21:11] awjr: I had sent a mail to YuviPanda, but he has'nt replied yet. [18:21:47] Avishek: i heard rumors earlier today that he is having connectivity problems. he is generally *really* good at replying to stuff, so you may just need to wait a bit :) [18:22:08] awjr: It has been 2 days..:) [18:22:21] okay! [18:23:43] Avishek: oh :( [18:23:57] well, hopefully he will be responsive here in the channel soon [18:24:37] awjr: yes, hopefully. :) [18:31:00] kalyan: i may have missed your question, but was there something in particular you needed help with? [18:31:37] Niya : yeah i would like to start contributing to wikipedia android app developement [18:32:06] kalyan: ah, and you're looking for where to start *nods* [18:32:09] i am experienced in both Native android and Phonegap cordova web app development [18:32:23] @Niya : exactly [18:32:39] kalyan: let me give you a link to start out~ [18:33:36] Niya: okay! :) that will be helpful [18:34:16] Niya : and i actually setup my android dev environment from this repo [18:34:16] kalyan: there's a native app that's in development and the gerrit page for it is here: https://gerrit.wikimedia.org/r/#/admin/projects/apps/android/wikipedia [18:34:30] =D [18:36:27] Niya: thanks Niya. First I should go through the documentation in that link? [18:37:30] kalyan: yeah, follow the readme to get the project setup and compiling [18:37:46] kalyan: i just recently updated it so it *should* be accurate [18:38:18] kalyan: if you have questions poke the channel ;) [18:39:00] Niya : thank you so much Niya! :) I will look into it and will come back [18:39:16] kalyan: =D [18:40:46] Niya: I am more of a beginner , but ready to learn new things..:) I have been taking a course on Coursera and know just the basics. Is there anything for me? [18:41:48] Avishek: i don't have answers to difficult questions, only easy ones XD i can say "here is the code" and "here are th issues list" but not much else, sadly ^^ [18:42:02] *the [18:43:27] Niya: oh.. okay..:) [18:43:27] jdlrobson, I know why I messed up upload progress, I'll push a fix soon [18:44:27] Niya : I already followed the readme instructions and i setup the dev environment just 15 min back :) so i ready with the environment with app running in my phone [18:44:27] jgonera: k [18:44:53] brion: heya - there are a few folks interested in getting started with app development; kalyan and avishek [18:45:05] \o/ [18:45:29] hi folks [18:45:34] they're trying to figure out where to begin. niya's given some pointers, but would you mind walking them through it? [18:45:40] brion : hi brion! :) [18:45:41] be happy to help :) [18:46:03] android or iOS? [18:46:05] brion: Hi! [18:46:15] brion: android! [18:46:21] wool the freedom choice :) [18:46:23] brion : i am basically a android and cordova developer brion! [18:46:23] *wooo [18:46:28] cool [18:46:50] brion: :) [18:49:31] brion: I am a beginner.. I have been doing a course on Coursera and know the basics..:) [18:50:21] any trouble building/running so far? [18:51:01] (03PS1) 10Jdlrobson: Include revId in MobileWebEditing schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116139 [18:51:09] brion: none so far. [18:51:14] brion : no prob! documentation was very clear and i got the app running in my phone [18:51:18] awesome :D [18:51:30] brion : :) [18:52:06] (03CR) 10jenkins-bot: [V: 04-1] Include revId in MobileWebEditing schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116139 (owner: 10Jdlrobson) [18:54:04] (03PS3) 10Jdlrobson: Make special pages always have a route from desktop to mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115955 [18:55:55] (03CR) 10Jdlrobson: "Err... there is no jshint error here. I'm very confused." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116139 (owner: 10Jdlrobson) [18:56:02] brion : is there any guide which explains the project flow and i can see as a new commer > [18:56:03] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116139 (owner: 10Jdlrobson) [18:57:13] ^ Krinkle any idea why jshint would complain about an unused variable that is in fact used? [18:57:42] kalyan: so far we're mostly poking at it internally so there's not a lot of public-facing docs [18:57:55] kalyan: can you see our current work board at https://trello.com/b/eEdBblMK/mobile-app-sprint-25-core-workflows or does it force you to log in and such? [18:57:56] jdlrobson: it's not used [18:58:06] L43 Krinkle [18:58:08] this.editCount = user.getEditCount(); [18:58:39] brion : oh okay! i would love to start contributing if it possible to get a chance! [18:58:58] great :D [18:59:11] lemme see if there's a good place to start putting together some good notes on getting involved [18:59:34] my local jshint doesn't complain [18:59:50] brion : okay thank you ! :) but will it take more time for public developers to start contribute in? [19:00:08] kalyan: oh we can start taking patches now :D [19:00:13] it's just not documented very well ;) [19:00:58] brion : oh okay brion! i will be waiting to get a heads up with contributing! :( [19:01:22] Krinkle: i'm updating my jshint to v2.1.11 [19:01:30] i think it's a bug [19:01:43] jdlrobson: I can't reproduce it on jshint.com [19:05:06] trying locally [19:05:10] not on v2.4.x [19:05:53] doesn't happen locally with v2.1.11 either [19:05:54] strange [19:06:02] Krinkle: very weird [19:06:17] kalyan: Avishek: i'm throwing some updated info into https://www.mediawiki.org/wiki/Wikimedia_Apps/Wikipedia/2014_rewrite [19:06:22] please feel free to add questions and ideas! [19:06:27] jdlrobson: It's a different comit [19:06:53] (03PS2) 10Jdlrobson: Include revId in MobileWebEditing schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116139 [19:06:59] Krinkle: different commit? [19:07:01] brion: sure! [19:07:05] hm.. no [19:07:21] brion : thanks brain! :) will look into it and come back! :) [19:07:41] (03CR) 10jenkins-bot: [V: 04-1] Include revId in MobileWebEditing schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116139 (owner: 10Jdlrobson) [19:08:02] jdlrobson: [19:08:02] jgonera: are you ok with ditching these tests after awjr and MaxSem's input btw? https://gerrit.wikimedia.org/r/#/c/115952/ [19:08:02] https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-jslint/ws/javascripts/modules/editor/EditorOverlay.js/*view*/ [19:08:10] in the workspace, that line you quoted doens't exist [19:08:27] was this recently added? [19:08:35] or maybe recently removed? [19:08:46] wah? mm [19:08:48] it runs on the merge commit, not on the commit parent you worked on locally [19:08:53] jdlrobson, I can't say I'm fully OK, but let's leave them out. could you possibly add a FIXME there? maybe someone will come up with something some day... [19:08:55] yeah, that's it [19:08:57] it's not there in master [19:08:59] :) [19:09:03] ahh i see wha you mean [19:09:08] and your change removes the other use [19:09:13] so it become unused as of that change [19:09:16] jdlrobson: jgonera the other option is to take the first approach MaxSem described [19:09:38] awjr, what is it? [19:10:04] jgonera: max said in one of the comments "we could theoretically create a couple of files, set TS for them and test if output is the same, however this does not guarantee that result will work in practice because of complex interactions with other parts of RL. That's why core has no tests for that." [19:10:08] Krinkle: super odd - yeh i can now see the problem locally when i rebase [19:10:11] meh, I think a test would be very formal in this case [19:10:16] so jenkins runs against the patch set rebased? [19:10:21] _needlessly_ formal [19:10:28] but i 100% agree with MaxSem on this [19:10:30] jdlrobson: not rebased, but the effect is the same, it runs on the state as if it was merged [19:10:36] i seeeee [19:10:39] that was a little confusing :) [19:10:41] the functionality here is not written in a way to write sound unit tests against [19:10:48] which is by design, if your change and something else since you started working is incompatible, we want to catch that [19:10:53] Krinkle: i wonder if there is anyway to make that more obvious [19:11:00] which is also why jenins fails if there is a merge conflict [19:11:01] which is the case with a lot of MW code [19:11:15] ok, let's do it without a test then, but next time something fails there, we have to figure this out and if necessary pull in an RL dev into this ;) [19:11:40] yeah, the other option is to change how RL is written so it can actually be testable :) [19:11:46] (03PS3) 10Jdlrobson: Include revId in MobileWebEditing schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116139 [19:11:47] awjr: that would be nice [19:11:47] unit testable, i should say [19:12:05] I don't know, we test the intend (you propose a change to the master branch, the change is applied locally on jenkins and then the tests run) [19:12:06] it would be nice indeed [19:12:06] RL is a pretty big part of mediawiki so untestable code there is pretty bad [19:12:24] jdlrobson: much of mw core is like that [19:12:30] brb [19:12:36] the fact that is happens makes sense and should be pretty obvious, but as for how to make it more visible, I'd say that's to upstream gerrit/jenkins/zuul to deal with if needed. [19:12:39] awjr: broken windows need to be fixed otherwise people will break more windows [19:12:55] Krinkle: i'll have to have a think about this some more [19:13:01] chrismcmahon and i have chatted a bit about this kind of stuff - i think we'd both like to see someone with unit testing expertise be able to help drive the changes in mw core necessary for that [19:13:08] i agree jdlrobson [19:13:14] it's the industry standard, I never really thought about it. [19:13:30] Krinkle: i guess the only thing to do is do a rebase on a failed test [19:13:50] jdlrobson: besides the legacy code, there is also the social problem that there are a lot of core developers who are anti-unit testing [19:14:02] awjr: vandals with bricks :( [19:14:04] that's why i think we need a champion who can help drive this stuff [19:14:09] why would anyone be anti unit testing? [19:14:23] jdlrobson: there are a few endless conversations about it on wikitech [19:14:26] sigh [19:14:27] wikitech-l that is [19:16:57] awjr: i'm going to leave the test that checks last modified time for modules with no templates [19:17:06] (03PS3) 10Jdlrobson: Update last modified time when a template or file changes in MFResourceLoaderModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 [19:17:08] ^ better than nothing :) [19:18:28] MaxSem: https://gerrit.wikimedia.org/r/#/c/115997/ < where is the core code that is introducing this? Do you know? [19:18:47] cc yurik [19:18:56] sorry yurik that was meant to be YuviPanda [19:19:24] jdlrobson, "being worked on" [19:19:35] MaxSem: ? [19:19:40] is there is a bug report? [19:19:43] see the commit message [19:20:14] MaxSem: i see no bug number [19:20:37] YuviPanda haven't submitted one [19:20:47] it would be helpful as i have no context of what the issue is [19:22:20] brion : hi brion, i just installed the app's apk in my phone and one thing i noticed was when i open any topics by searching in search box, The page unnecessarily scrolling horizontally it looks odd from user experience perspective [19:22:29] jdlrobson, now returning to https://gerrit.wikimedia.org/r/115995 ... [19:22:32] (03CR) 10Jdlrobson: [C: 04-1] "Yuvi can you open a bug or point to a discussion so we can update the commit message with this ? - it's impossible to know where you are s" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115997 (owner: 10MaxSem) [19:22:42] jdlrobson, WTF? [19:22:50] kalyan: i think we still have to fix some style issues that can cause wide pages yeah [19:23:01] I now need a BZ ticket to fix a bug? [19:23:07] brion : okay brion! [19:23:09] MaxSem: i've asked for a more meaningful commit message [19:23:09] kalyan: can you file a bug and include an example page so we can add it to the backlog? [19:23:13] i think this is fair [19:23:20] the current commit message is only clear to Yuvi and you [19:23:24] we also still have to synchronize the CSS between the two platforms :D [19:23:28] jdlrobson, I think the message is quite clear [19:23:43] brion : sure brion i will do it now! :) [19:24:30] MaxSem: the core problem will never get fixed if no bug is raised for it [19:25:00] mw-editsection is a part of the skin no? [19:25:09] we suppress them on MobileFrontend in the skin itself so why can't we do that here [19:25:27] that requires some core changes to do properly [19:25:37] * YuviPanda looks around [19:25:49] seriously, you're commenting as if you haven't looked at commit message [19:26:22] YuviPanda: Did you have a chance to confirm if abuse filter is triggered before captcha? [19:26:28] vbamba: no, not yet [19:26:40] vbamba: will try to get that done tomorrow :) [19:26:53] No worries at all, Ive added a comment to the trello card so we can track it. [19:27:09] thanks for following up - all this research must cut into your dev time [19:27:42] one last q - Do you know someone who could answer questions around the extract of an article? [19:28:20] vbamba: ok! :) [19:28:37] vbamba: MaxSem wrote that extension (TextExtracts) so he should be able to [19:28:59] * MaxSem waves to vbamba [19:30:24] MaxSem: jdlrobson that commit message looks okay to me? Just because it was the app that was affected doesn't mean it is app specific [19:30:24] MaxSem: : that requires some core changes to do properly < sure but what's the bug report for that? [19:30:53] jdlrobson: FYI: https://bugzilla.wikimedia.org/show_bug.cgi?id=62069 [19:31:03] (03CR) 10MaxSem: "Ping." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115995 (owner: 10MaxSem) [19:31:51] YuviPanda: that's because you hit the issue. I have no idea where you are seeing this issue - srsly in the time you guys have been discussing it a bug against core could have been raised or noted in this commit or the code…. really not difficult [19:32:11] meh [19:42:50] MaxSem: ! [19:43:06] vbamba: waving back (from under an umbrella in the rain) [19:43:19] Sidenote: SF is lovely today [19:43:28] I want to understand how much content we receive in the extract =] [19:43:53] MaxSem: Can I pick your brain about both image querying and extracts? [19:44:14] vbamba, sure [19:44:31] MaxSem: What is action=mobileview? https://gerrit.wikimedia.org/r/#/c/115997/ [19:45:18] kaldari, it is oh shit...P [19:46:34] (03PS1) 10MaxSem: Kill WAP and dance on its grave [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116147 [19:47:12] MaxSem: ah found https://www.mediawiki.org/wiki/Extension:MobileFrontend#action.3Dmobileview [19:50:43] (03PS3) 10MaxSem: Regression: remove edit section links from action=parse&mobileformat output [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115997 [19:51:05] (03CR) 10Kaldari: "Looks OK to me, but would be good to have a better explanation in the commit summary." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115997 (owner: 10MaxSem) [19:51:33] kaldari, just expanded it:)^^^ [19:51:40] thanks! [19:53:15] MaxSem: did edit links start showing up recently in those API requests for some reason? [19:53:31] kaldari, yes, it's a regression [19:54:53] (03CR) 10Kaldari: [C: 032] "Looks good to me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115997 (owner: 10MaxSem) [19:54:55] (03CR) 10Jdlrobson: "I've seen your comment. I've spent the morning talking with Brion to understand more about how the magic commons file page works and how t" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115995 (owner: 10MaxSem) [19:55:20] MaxSem: Some rare PHP changes to review if you're interested: https://gerrit.wikimedia.org/r/#/c/116016/ [19:57:06] (03CR) 10MaxSem: "I know that workflow. And I don't think that sticking skins into this equation would be a good idea." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115995 (owner: 10MaxSem) [19:57:46] kaldari, why are you killing /** @var ?:) [19:58:12] brion : Hi brion, I created the bug in bugzilla and bug id is 62070... :) [19:58:16] MaxSem: is the /** important for doc parsing? [19:58:37] kaldari, I thought it is - that's what PhpStorm does [19:58:52] MaxSem: it was just inconsistant, some were using /* and some were using /** [19:59:12] kalyan: thanks! [19:59:14] MaxSem: I'll change them both to /** to be safe. [19:59:36] brion : :) happy to help! :) [20:02:16] (03CR) 10jenkins-bot: [V: 04-1] Kill WAP and dance on its grave [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116147 (owner: 10MaxSem) [20:03:01] (03PS2) 10Kaldari: Story 1732: Some preliminary clean-up for new licensing messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116016 [20:03:18] MaxSem: change it to match coding conventions for var docs [20:03:27] er, I changed it... [20:05:18] (03PS2) 10MaxSem: Kill WAP and dance on its grave [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116147 [20:05:51] brion : In table of contents if we go into any topic and scroll down the page, the Action Bar is getting hidden... is this the expected behaviour? [20:07:11] (03CR) 10MaxSem: [C: 04-1] "1 little concern, looks good otherwise." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116016 (owner: 10Kaldari) [20:09:58] kalyan: yes, it auto-reshows when you scroll back up [20:10:00] or it should :D [20:10:40] google calls it the 'quick return' pattern [20:10:52] http://www.androiduipatterns.com/2012/08/an-emerging-ui-pattern-quick-return.html [20:11:08] brion : Yeah its showing :) i just want to confirm whether its the usecase :) [20:11:11] or rather, some guy calls it that. dunno what google calls it :D [20:11:14] yep [20:11:19] oh okay thanks for info :) [20:11:34] (03Merged) 10jenkins-bot: Regression: remove edit section links from action=parse&mobileformat output [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115997 (owner: 10MaxSem) [20:14:45] (03PS2) 10MaxSem: [Card 703] Promote lazy languages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115978 [20:23:11] (03CR) 10MaxSem: Update last modified time when a template or file changes in MFResourceLoaderModule (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 (owner: 10Jdlrobson) [20:28:17] (03PS3) 10MaxSem: Kill WAP and dance on its grave [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116147 [20:44:49] YuviPanda: hey is there any chance we'll end up with multiple strings.xml files to localize? [20:44:50] i can simplify the translatewiki config if we're only ever going to need the one [20:48:12] (03PS1) 10JGonera: [WIP] Remove mobile media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116156 [20:48:27] (03CR) 10JGonera: [C: 04-2] "Experiment, do not merge." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116156 (owner: 10JGonera) [20:48:46] MaxSem, brion: do you know who moderates mobile-l ? need a msg approval [20:49:06] eh, no idea. tfinc? [20:52:17] dunno [20:52:20] maybe nobody :D [20:52:48] yurikR: https://lists.wikimedia.org/mailman/listinfo/mobile-l says tfinc [20:56:52] its ok, canceled and posted to -tech [20:58:53] ewwwwwwwwwwwwwwwwwwwwwwwwww, mysql on staging is broken [21:09:40] (03PS1) 10JGonera: Regression: Make upload progress visible again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116158 [21:27:23] (03CR) 10Jdlrobson: Update last modified time when a template or file changes in MFResourceLoaderModule (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 (owner: 10Jdlrobson) [21:43:54] (03CR) 10Jdlrobson: "See https://bugzilla.wikimedia.org/show_bug.cgi?id=62071 - this is a bug in core that should be fixed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115995 (owner: 10MaxSem) [21:45:04] yurik: I think I have access [21:46:17] yurik: apparently not :) [21:49:48] jdlrobson: no worries, i canceled that email and resent it to the -tech [22:01:56] lol, we broke MW logging:P [22:06:37] https://gist.github.com/MaxSem/6ddb606a48203e06e679 [22:06:42] :D:D:D [22:14:16] (03CR) 10Jdlrobson: [C: 032] "Face ppaalllm." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116158 (owner: 10JGonera) [22:14:32] (03PS1) 10Jdlrobson: QA: Protect against bug 62030 happening again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116167 [22:14:45] (03CR) 10Jdlrobson: [C: 04-2] "Don;t work" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116167 (owner: 10Jdlrobson) [22:14:52] (03Merged) 10jenkins-bot: Regression: Make upload progress visible again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116158 (owner: 10JGonera) [22:17:05] awjr, https://bugzilla.wikimedia.org/show_bug.cgi?id=62078 [22:17:31] awjr, looks like was caused by your https://gerrit.wikimedia.org/r/#/c/114392/ [22:19:45] damn [22:22:13] hmm that's odd, the mobile view link on test2wiki should point to test2.m.wikipedia.org, not provide a mobileaction=toggle_view_mobile query param [22:24:18] MaxSem: Would you have a second to look at http://chicken.wmflabs.org/wiki/Main_Page [22:24:37] Have some questions about the image querrying as seen on this server [22:25:48] vbamba, yes? [22:40:23] (03PS3) 10Jdlrobson: Card 703: Promote lazy languages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115978 (owner: 10MaxSem) [22:40:36] (03CR) 10Jdlrobson: [C: 032] Card 703: Promote lazy languages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115978 (owner: 10MaxSem) [22:41:34] (03Merged) 10jenkins-bot: Card 703: Promote lazy languages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115978 (owner: 10MaxSem) [22:43:33] argh [22:45:21] MaxSem: can you explain what's up with lines 615-625 of MoblieContext? [22:45:24] mhurd: i really see what you mean now. this is going to be an interesting decision to make [22:45:30] for page history [22:45:35] err .. browsing history [22:45:40] tfinc: ya! fun stuff :) [22:45:40] its functioning just like you explained [22:45:47] or at least explain the use case? [22:46:07] it seems weird to me that we'd call shouldDisplayMobileVeiew() in getMobileUrl() [22:46:19] but that's the source of the recursion [22:46:26] awjr, it's for Zero [22:46:51] does it need to be wrapped in shouldDisplayMobileView() :? [22:47:01] if zero is firing that, isn't mobile view implicit? [22:48:05] mmm, I'm pretty sure there's a reason for it. yurik ^^^^ [22:48:14] hehe yeah probably [22:49:17] MaxSem: it looks like zero safeguards this with if ( $this->isZeroSubdomain ) [22:50:06] and it seems to me that hook should be able to run whether or not we are in mobile view, because the whole point of that method is to deliver an appropriate mobile URL that may be used from somewhere like desktop-view [22:52:32] ergh my connection is going in and out [22:52:33] MaxSem: did you see my messages? [22:52:38] 3:49 [22:52:38] awjr [22:52:39] 3:49 [22:52:40] MaxSem: it looks like zero safeguards this with if ( $this->isZeroSubdomain ) [22:52:41] 3:49 [22:52:42] Krinklee [~Krinkle@ec2-50-112-50-28.us-west-2.compute.amazonaws.com] entered the room. [22:52:46] 3:50 [22:52:47] awjr [22:52:49] 3:50 [22:52:49] and it seems to me that hook should be able to run whether or not we are in mobile view, because the whole point of that method is to deliver an appropriate mobile URL that may be used from somewhere like desktop-view [22:52:58] yep [22:56:24] MaxSem: im hesitant to change that without an OK from yurik [22:57:02] awjr, considering https://gist.github.com/MaxSem/6ddb606a48203e06e679 we can't wait [22:57:02] MaxSem: i guess the other option is to move the checkToggleView() call elsewhere, but it would need to happen before the first shouldDisplayMobileView() gets called and im not sure where we could guarantee that [22:57:55] meh, i think the scope of this is actually pretty small [22:58:22] and i dont want to risk breaking zero which would cause probably bigger problems :p [22:58:51] MaxSem: can you think of another place we could safely put checkToggleView()? [23:00:49] (03PS1) 10Jdlrobson: Be more specific in dependencies on mobile.newusers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116171 [23:02:29] mhurd: i'm seeing some nice stability on this build and less weird issues. good job [23:02:38] MaxSem: if not, let's just revert my change for now and we can reimplement it later when we can ensure zero compatibility [23:02:46] tfinc: awesomeness! thanks!!! [23:02:48] mhurd: i'm getting more lost in the content and thinking about new features rather then things not working right [23:02:56] :) [23:05:20] awjr, doing it via $wgExtensionFunctions sounds prone to errors [23:05:37] aye [23:05:45] MaxSem: i've got a nasty hack [23:05:46] one sec [23:11:33] mhurd: overall i feel were at a really nice stable point with iOS and we can build on top of it [23:11:51] YuviPanda: on Android i think were moving forward but we still have those rough spots to iron out [23:12:54] jdlrobson: CAFFEINE [23:13:25] violetto: YESSS [23:14:46] mhurd: do we already have a bug about how redirects cause the edit pencil to now work ? [23:15:29] tfinc: i had added a note to a related edit bug about suspicions that redirects are to blame [23:16:39] yeah, you can see it happen easily with https://en.m.wikipedia.org/wiki/Seattle%2C_Washington [23:16:48] mhurd: i'll file a bug and you can resolve if its a dupe [23:17:00] tfinc: thanks! sounds good [23:17:05] (03PS1) 10Brion VIBBER: Let's just set a reasonable size in dp for the captcha image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116173 [23:18:25] vbamba, so what should I look at? [23:18:31] ...on that page [23:21:18] MaxSem: i've got a couple of hacks but they're really nasty and i dont feel good about submitting them [23:21:30] MaxSem: what do you think we should do? [23:22:27] awjr, I say revert and think calmly lqater [23:22:46] MaxSem: wise :) [23:23:56] MaxSem: https://gerrit.wikimedia.org/r/#/c/116174/ [23:24:33] (03CR) 10MaxSem: [C: 032] Revert "Ensure checkToggleView() fires at appropriate time" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116174 (owner: 10Awjrichards) [23:24:35] (03CR) 10jenkins-bot: [V: 04-1] Revert "Ensure checkToggleView() fires at appropriate time" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116174 (owner: 10Awjrichards) [23:25:05] (03PS2) 10Awjrichards: Revert "Ensure checkToggleView() fires at appropriate time" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116174 [23:26:01] (03CR) 10Awjrichards: "Recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116174 (owner: 10Awjrichards) [23:27:15] MaxSem: sorry had to run for meetings [23:27:19] MaxSem: back now [23:28:23] Could you hover over a few links? You will see images in some of them. [23:28:57] for the portrait ones, we query for 250 width, for the landscape ones, we query for 250 height [23:29:19] I wanted to understand what happens when you query for a specific size [23:29:30] man it's getting hella story here - is it getting nasty in SF yet? [23:31:30] MaxSem: can you +2 again? https://gerrit.wikimedia.org/r/#/c/116174/ [23:31:54] (03CR) 10MaxSem: [C: 032] Revert "Ensure checkToggleView() fires at appropriate time" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116174 (owner: 10Awjrichards) [23:32:30] (03Merged) 10jenkins-bot: Revert "Ensure checkToggleView() fires at appropriate time" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116174 (owner: 10Awjrichards) [23:35:40] (03PS2) 10Brion VIBBER: Let's just set a reasonable size in dp for the captcha image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116173 [23:36:22] (03PS1) 10MaxSem: Revert "Ensure checkToggleView() fires at appropriate time" [extensions/MobileFrontend] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116175 [23:36:43] (03CR) 10MaxSem: [C: 032 V: 032] Revert "Ensure checkToggleView() fires at appropriate time" [extensions/MobileFrontend] (wmf/1.23wmf16) - 10https://gerrit.wikimedia.org/r/116175 (owner: 10MaxSem) [23:57:15] vbamba, you're requesting thumbsize, which is the largest dimension of the image [23:57:59] basically, you get a pic where both dimensions are no larger than 250 [23:59:17] (03PS1) 10Awjrichards: Ensure checkToggleView() fires at appropriate time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116180 [23:59:37] (03CR) 10Awjrichards: [C: 04-2] "-2 pending review from Zero team" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116180 (owner: 10Awjrichards)