[00:02:13] <grrrit-wm>	 (03PS1) 10Jdlrobson: Ensure a toast shows when uploading an invalid file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116181 
[00:09:54] <jdlrobson>	 jgonera awjr any idea what "Create a list of tests that depend on existing wiki pages (specifying what page they rely on and why)." means in https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1687 ?
[00:10:44] <jgonera>	 jdlrobson, well, Test A, page: Barack Obama, why: infobox
[00:10:59] <jdlrobson>	 jgonera: this is already documented in README.txt
[00:11:04] <jdlrobson>	 I did a full audit already
[00:11:31] <jdlrobson>	 under the setup section
[00:11:41] <jgonera>	 jdlrobson, not really, it doesn't say why
[00:11:50] <jgonera>	 also, I suspect it's not entirely up-to-date
[00:11:51] <jdlrobson>	 it's pretty trivial to work out why
[00:11:53] <dr0ptp4kt>	 awjr, just replied to your email
[00:12:03] <jgonera>	 jdlrobson, I'm not saying it's a complicated spike ;)
[00:12:04] <jdlrobson>	 jgonera: i did it just before i left for vacation so i'd be surprised if it's not up to date
[00:12:22] <jgonera>	 jdlrobson, if you don't feel like doing it, I can do it later
[00:12:43] <jdlrobson>	 jgonera: i'm not saying i don't feel like it - i'm just saying it's not clear to me what additional work is needed
[00:12:51] <jdlrobson>	 is the purpose of this to use the API stuff you've been working on?
[00:12:57] <jgonera>	 yes
[00:13:01] <jdlrobson>	 it seems orthogonal to an audit of existing test coverage
[00:13:11] <jdlrobson>	 also is test coverage specific to browser tests or also unit tests?
[00:13:34] <jdlrobson>	 also is it stable only or also beta/alpha?
[00:13:53] <jgonera>	 jdlrobson, I'm not sure what audit of test coverage we're talking about
[00:14:22] <jgonera>	 tests missing in stable, pages for all current tests
[00:14:25] <jdlrobson>	 https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1687 jgonera  "What tests are missing?"
[00:14:36] <jdlrobson>	 ok so i can ignore thinks like talk etc?
[00:14:51] <jdlrobson>	 also if watch list php code has no unit tests do i state that?
[00:14:58] <grrrit-wm>	 (03PS1) 10Brion VIBBER: When following links with hash/fragments on them, jump to the anchor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116184 
[00:15:01] <jdlrobson>	 or are we only interested in watir tests?
[00:15:04] <jgonera>	 I think we can focus on browser tests
[00:15:10] <jdlrobson>	 ok cool thanks for the clarification
[00:15:14] <vbamba>	 MaxSem:  got it
[00:15:30] <vbamba>	 what happens when the largest image available is like  50 X 50 px?
[00:20:42] <jdlrobson>	 mmm seems like an issue with diff view MaxSem ? https://en.m.wikipedia.org/wiki/Special:MobileDiff/597595271
[00:20:46] <jdlrobson>	 nothing green
[00:21:04] <jdlrobson>	 and https://en.m.wikipedia.org/wiki/Special:MobileDiff/597595051
[00:22:34] <dr0ptp4kt>	 awjr, see email. go ahead and redploy
[00:22:37] <dr0ptp4kt>	 MaxSem^
[00:24:36] <MaxSem>	 dr0ptp4kt, thanks - no need to deploy as the bug has been fixed with revert so far
[00:26:46] <dr0ptp4kt>	 MaxSem, cool
[00:26:52] <dr0ptp4kt>	 i rephrased
[00:26:55] <dr0ptp4kt>	 on the email thread
[00:33:54] <awjr>	 thanks dr0ptp4kt, i think we can probably let the change go out with the train next week and see what happens
[00:34:24] <awjr>	 dr0ptp4kt: would you mind commenting on the patchset itself?
[00:35:18] <MaxSem>	 jdlrobson, what do you mean by "no green"? there's plenty of green in these diffs
[00:35:35] <jdlrobson>	 MaxSem: I can't see any green
[00:35:43] <jdlrobson>	 maybe because of my rights?
[00:36:22] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 031] "Does not seem to break ZeroRatedMobileAccess on localhost (rewritten "Desktop" URL seems to be the same form). Worst case, Desktop footer " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116180 (owner: 10Awjrichards)
[00:36:27] <dr0ptp4kt>	 ^awjr
[00:36:33] <awjr>	 thanks dude
[00:37:39] <MaxSem>	 aha, so revdel works
[00:43:47] <tfinc>	 seeing this get reviewed makes me very happy https://gerrit.wikimedia.org/r/#/c/116184/
[00:46:32] <dr0ptp4kt>	 yurik, you around?
[00:54:02] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Only send zero-rated message for app if images also zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/116189 
[00:56:03] <grrrit-wm>	 (03PS2) 10Dr0ptp4kt: Only send zero-rated message for app if images also zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/116189 
[00:58:32] <grrrit-wm>	 (03PS3) 10Dr0ptp4kt: Only send zero-rated message for app if images also zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/116189 
[00:58:42] <dr0ptp4kt>	 yurik^ review, por favor
[01:19:13] <vbamba>	 MaxSem:  No hurry, whenever you get to my question - what happens when the largest image available is like  50 X 50 px?
[01:19:46] <MaxSem>	 images smaller than 100px never appear in PageImages results
[02:23:33] <grrrit-wm>	 (03PS8) 10Dr0ptp4kt: HTTPS UI for applicable Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik)
[02:25:59] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 04-1] "Don't merge yet. Review, though, please." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik)
[02:27:54] <dr0ptp4kt>	 ^yurik, next week when you have time, review, por favor
[12:07:58] <grrrit-wm>	 (03PS9) 10Dr0ptp4kt: HTTPS UI for applicable Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik)
[12:09:46] <grrrit-wm>	 (03PS10) 10Dr0ptp4kt: HTTPS UI for applicable Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik)
[17:29:13] <kalyan>	 brion : hi brion! I eagerly waiting to contribute brion! any updates?
[20:30:00] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 04-1] "Haven't fully checked it out but can you add a PageTitle constructor that doesn't take fragment as a parameter? That should help avoid a w" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116184 (owner: 10Brion VIBBER)