[15:46:00] <grrrit-wm>	 (03PS2) 10Brion VIBBER: When following links with hash/fragments on them, jump to the anchor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116184 
[15:46:19] <grrrit-wm>	 (03CR) 10Brion VIBBER: "How's this?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116184 (owner: 10Brion VIBBER)
[16:39:45] <dr0ptp4kt>	 YuviPanda, you around?
[16:57:10] <grrrit-wm>	 (03CR) 10Nicole: "Just a tiny comment." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116184 (owner: 10Brion VIBBER)
[16:59:34] <grrrit-wm>	 (03PS3) 10Brion VIBBER: When following links with hash/fragments on them, jump to the anchor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116184 
[17:00:24] <grrrit-wm>	 (03CR) 10Brion VIBBER: "Indeed. :)" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116184 (owner: 10Brion VIBBER)
[17:05:20] <Niya>	 brion: =D :: i'm lazy and haven't unpacked my dev box yet so i didn't run it though ^^;
[17:05:28] <brion>	 :D
[17:10:41] <YuviPanda>	 hey brion
[17:10:43] <YuviPanda>	 hey Niya :)
[17:10:54] <brion>	 hey YuviPanda 
[17:10:57] <YuviPanda>	 just got off a crazy tree house :D
[17:11:02] <YuviPanda>	 doing code review now
[17:11:27] <brion>	 hehe nice
[17:11:32] <Niya>	 hey Yuvi~ =D
[17:11:34] <brion>	 i'm gonna grab some eats and head into the office
[17:11:45] <YuviPanda>	 brion: ok! :)
[17:12:38] <brion>	 spent the weekend building gtk+ apps on mac
[17:12:44] <brion>	 i may be insane :)
[17:13:14] <Niya>	 haha
[17:14:20] <YuviPanda>	 brion: I saw some elephants, slept in a tree house overlooking a stream, saw some fireflies, got lost in the dark in a forest with no GPS or trails, and tried some interesting culinary experiments :)
[17:14:29] <YuviPanda>	 I think I'm just making up for the following weekends of Java
[17:15:09] <brion>	 haha
[17:17:32] <Niya>	 =o
[17:26:17] <YuviPanda>	 brion: doing code review now!
[17:49:19] <grrrit-wm>	 (03PS1) 10Cmcmahon: Read in another language is a link not a button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116511 
[17:51:45] <grrrit-wm>	 (03PS2) 10Jdlrobson: QA: Read in another language is a link not a button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116511 (owner: 10Cmcmahon)
[17:51:52] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] QA: Read in another language is a link not a button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116511 (owner: 10Cmcmahon)
[17:53:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: Read in another language is a link not a button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116511 (owner: 10Cmcmahon)
[17:55:04] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032 V: 032] "A fair bit hacky, but better experience for now." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116173 (owner: 10Brion VIBBER)
[17:55:47] <Niya>	 YuviPanda: we're supposed to chat in a moment -- i'm just going to take an allergy thing so i hopefully don't sneeze continuously XD
[17:56:28] <YuviPanda>	 Niya: wait, we are? My calendar says something else :|
[17:56:51] <violetto>	 YuviPanda: …………………………………………..
[17:57:06] <violetto>	 YuviPanda: switch place?
[17:57:15] <YuviPanda>	 violetto: hmm?
[17:58:05] <violetto>	 YuviPanda: fireflies
[17:58:11] <YuviPanda>	 violetto: aaah :D
[17:58:16] <YuviPanda>	 violetto: they were amazing, I tell you
[17:58:20] <YuviPanda>	 violetto: we also heard frogs all night
[17:58:45] <violetto>	 YuviPanda: frogs.......
[17:58:54] <violetto>	 YuviPanda: did you see rabbits
[17:58:57] <violetto>	 white rabbits
[17:59:01] <violetto>	 ;P
[17:59:12] <YuviPanda>	 violetto: yeah, but they were in cages :(
[17:59:16] <YuviPanda>	 violetto: we did see free kingfishers
[18:00:18] <violetto>	 YuviPanda: i saw hummingbirds for the first time in my life a couple of weeks ago :]
[18:00:53] <YuviPanda>	 violetto: wooo! i've not seen those yet
[18:01:08] <YuviPanda>	 violetto: I saw a giant flying squirrel
[18:01:16] <violetto>	 YuviPanda: whattt
[18:01:21] <YuviPanda>	 violetto: it was a leopard/tiger reserve, and we didn't find those
[18:01:26] <YuviPanda>	 violetto: also saw amazing sunset :P
[18:01:27] <violetto>	 YuviPanda: never seen a flying one
[18:01:34] <YuviPanda>	 violetto: they don't fly, sortof glide with huge tails
[18:01:42] <violetto>	 YuviPanda: sounds like a eventful day
[18:01:51] <violetto>	 YuviPanda: i just sat around eating dim sum all weekend
[18:01:58] <YuviPanda>	 violetto: eventful week. We'll be seeing elephants and bison tomorrow :P
[18:02:04] <violetto>	 BISONNNNNN
[18:02:11] <violetto>	 YuviPanda: i love bisons..
[18:02:13] <YuviPanda>	 violetto: I'll take pictures for you!
[18:02:15] <awjr>	 MaxSem: standup?
[18:02:15] <YuviPanda>	 violetto: i know!
[18:02:18] <violetto>	 thanks ..
[18:02:19] <YuviPanda>	 violetto: this is 'Indian bison' I'm told
[18:02:26] <violetto>	 YuviPanda: googling
[18:02:45] <violetto>	 YuviPanda: looks like a typical cow
[18:02:48] <YuviPanda>	 violetto: I'm at 'Waynad'. google that also
[18:02:55] <YuviPanda>	 violetto: idk, haven't seen them yet
[18:03:37] <violetto>	 YuviPanda: did you go through the squiggly road?
[18:03:48] <violetto>	 or see elephants crossing?
[18:03:52] <YuviPanda>	 violetto: all the roads I've been on in the last few days have been very squiggly
[18:03:58] <YuviPanda>	 violetto: not to mention very awesome
[18:04:19] <violetto>	 YuviPanda: until someone throws up D:
[18:04:27] <YuviPanda>	 violetto: yeah, nobody did
[18:04:29] <YuviPanda>	 violetto: do you? 
[18:04:34] <violetto>	 YuviPanda: http://www.vythiriresort.com/images/sub_banner/vythiri_resort_wayanad.jpg
[18:04:41] <violetto>	 no i wouldn't
[18:04:59] <YuviPanda>	 violetto: heh yeah. we're staying in less expensive places
[18:05:21] <violetto>	 YuviPanda: did you see the waterfalls yet?
[18:05:47] <YuviPanda>	 violetto: not yet, should do in the next few days sometime
[18:05:58] <YuviPanda>	 violetto: or might not. who knows.
[18:06:08] <YuviPanda>	 violetto: I was writing code in the bus that was going on the bendy road
[18:06:11] <violetto>	 YuviPanda: so you;ll be at wayanad for a few days?
[18:06:21] <YuviPanda>	 violetto: I don't know. maybe another day or two.
[18:07:03] <violetto>	 YuviPanda: alot of animals in the wild? 
[18:08:09] <YuviPanda>	 violetto: this is off season so they are usually not seen much
[18:10:02] <grrrit-wm>	 (03CR) 10Yuvipanda: When following links with hash/fragments on them, jump to the anchor (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116184 (owner: 10Brion VIBBER)
[18:13:35] <YuviPanda>	 hmm, no brion yet
[18:13:36] <YuviPanda>	 hey mhurd
[18:13:50] <mhurd>	 YuviPanda: hey! brion just got here
[18:13:56] <matanya>	 YuviPanda: any new builds?
[18:14:00] <YuviPanda>	 mhurd: woo!
[18:14:08] <YuviPanda>	 matanya: yeah, there was one that should've fixed the issue with rtl
[18:14:12] <YuviPanda>	 matanya: let me get you a link
[18:14:15] <matanya>	 thanks
[18:14:36] <matanya>	 i also updated to android 4.2.2 for better testing
[18:15:00] <YuviPanda>	 matanya: woo!
[18:15:55] <YuviPanda>	 matanya: Public Android build at https://releases.wikimedia.org/mobile/android/apps-android-wikipedia-sprint25.apk 
[18:16:00] <YuviPanda>	 matanya: we posted to mobile-l I think
[18:16:20] <matanya>	 not subscribed to there, have 56 ml atm
[18:17:42] <YuviPanda>	 matanya: heh :)
[18:17:50] <YuviPanda>	 matanya: I will just ping you on IRC every time we do one then :)
[18:17:58] <awjr>	 jdlrobson kaldari what has been the problem with the rig in the standup area?
[18:18:13] <jdlrobson>	 awjr: i couldn't get the mouse or keyboard to respond. I guess it got fixed
[18:18:25] <matanya>	 i just added a notify script to releases.wikimedia.org, so no need :)
[18:18:29] <awjr>	 jdlrobson: huh, yeah, apps is doing hteir standup there now and dont seem to be having any problems
[18:18:31] <kaldari>	 awjr: also it really sucks now since there are no accounts on it
[18:18:46] <jdlrobson>	 yeh i'll ask tomasz when he gets back
[18:18:55] <kaldari>	 awjr: you always have to log in as guest and set up everything from scratch, which takes forever
[18:18:58] <awjr>	 kaldari: jdlrobson is it still a chromebox or did they swap about the box?
[18:19:31] <kaldari>	 awjr: I think it's a mac mini now
[18:19:37] <awjr>	 oh i see
[18:20:12] <kaldari>	 awjr: yes, please complain about it. let me know if I can help
[18:20:31] <awjr>	 kaldari: will do, im already writing an email to IT :)
[18:21:41] <jdlrobson>	 awjr: it's now a mac mini yeh
[18:24:39] <tfinc>	 YuviPanda: brion: what's the level of work on https://bugzilla.wikimedia.org/show_bug.cgi?id=61867 ?
[18:24:45] <jdlrobson>	 milimetric: is there anyway to change our limn graphs so they don't include the current day?  http://mobile-reportcard.wmflabs.org/#edits_daily-graphs-tab
[18:24:51] <tfinc>	 i see a patch is already in CR
[18:25:17] <tfinc>	 i'm moving it to the CR column
[18:25:19] <YuviPanda>	 tfinc: yeah, that was merged
[18:25:28] <milimetric>	 hm, jdlrobson - not super easily
[18:25:30] <YuviPanda>	 tfinc: I marked the bug as resolved
[18:25:34] <YuviPanda>	 tfinc: the one in 'to do' was for iOS, not android
[18:25:36] <tfinc>	 YuviPanda: please move it to ready for sign off then 
[18:25:38] <tfinc>	 ahh
[18:25:39] <tfinc>	 ok
[18:25:39] <jdlrobson>	 milimetric: can we make it super easy..? :)
[18:25:40] <YuviPanda>	 tfinc: the android patch got merged, I don't know about iOS
[18:25:43] <YuviPanda>	 tfinc: the android card is in ready for signoff
[18:25:46] <tfinc>	 mhurd: what's the level of work to fix that in iOS ?
[18:25:51] <milimetric>	 but it seems like the better fix is to change the cache header on the server hosting the datafiles
[18:26:10] <jdlrobson>	 YuviPanda: is the "Successful logins (per day)" graph serving any purpose? http://mobile-reportcard.wmflabs.org/graphs/successful-logins
[18:26:14] <milimetric>	 and yes, we can make it easier, but that's probably not easy :)
[18:27:03] <YuviPanda>	 jdlrobson: yeah, it's new user logins per day. so if a bunch of new people get the app and sign in, we see a spike. they only have to sign in once, ever
[18:27:10] <YuviPanda>	 jdlrobson: although I do not know if anyone is looking at it
[18:27:11] <YuviPanda>	 I'm not
[18:27:13] <mhurd>	 tfinc: was that the rtl lang card?
[18:27:21] <tfinc>	 mhurd: yes
[18:27:48] <mhurd>	 tfinc: best guess is 2 to 3 story points
[18:27:56] <tfinc>	 mhurd: k
[18:28:09] <mhurd>	 rebooting for software update
[18:30:40] <tfinc>	 brion: i'm betting this this is the old app https://bugzilla.wikimedia.org/show_bug.cgi?id=62113 can you respond ?
[18:31:18] <YuviPanda>	 hey vbamba
[18:31:35] <YuviPanda>	 vbamba: oliver responded to the question about canned edit summaries but I saw he hadn't cc'd you or other folks. I just sent it to mobile-tech
[18:31:57] <brion>	 tfinc: yeah old app
[18:34:48] <YuviPanda>	 brion: saw my comments on the fragments patchset?
[18:35:16] <brion>	 not yet
[18:35:34] <YuviPanda>	 brion: ok!
[18:35:43] <brion>	 YuviPanda: do we use those section ids for jumping to sections from the toc or anything?
[18:36:03] <YuviPanda>	 brion: even if we do, we can modify those too to just use the anchor instead of id
[18:36:18] <brion>	 mmmm could do
[18:37:14] <tfinc>	 brion: consider the bugs in prioritized order 
[18:37:25] <brion>	 ok
[18:37:29] <awjr>	 dr0ptp4kt: yurik MaxSem per the WAP email thread, since there appear to be lingering questions about whether not to revert the change, it might be worthwhile to have dan definitively comment on the thread one way or the other to settle the debate
[18:38:04] <awjr>	 if i were in faidon's shoes, the ambiguity would leave me feeling rather frustrated
[18:38:17] <brion>	 YuviPanda: yep it's being used for that
[18:38:24] <YuviPanda>	 brion: yeah, we can change that too
[18:38:26] <brion>	 YuviPanda: want me to change it to use anchor?
[18:38:29] <YuviPanda>	 brion: lesser DOM elements the better!
[18:38:30] <YuviPanda>	 brion: yeah
[18:38:53] <brion>	 ok moment
[18:44:48] * MaxSem  scratches his head, looking at 4 browsers he's using at the same time

[18:45:49] <dr0ptp4kt>	 awjr, looks like yuri said no need to revert as well. any need for another email?
[18:46:48] <awjr>	 dr0ptp4kt: ah yeah, just saw his response. up to you guys but IMO a definitive word from Dan wouldn't hurt.
[18:49:06] <YuviPanda>	 MaxSem: only 4? 
[18:49:33] <MaxSem>	 YuviPanda, goddamn Yandex refuses to start
[18:49:43] <YuviPanda>	 MaxSem: you use Yandex?
[18:50:06] <MaxSem>	 and I nuked Safari out of disgust to AppStore's review policy
[18:50:20] <YuviPanda>	 :D
[18:50:36] <YuviPanda>	 MaxSem: safari on windows has been dead for a while anyway 
[18:51:18] <MaxSem>	 YuviPanda, Yandex is actually the only browser besides Opera that knows how to draw a shitload of tabs
[18:55:04] <MaxSem>	 hmm, is there really no key binding customization extension for Chrome that does not suck?
[18:57:11] <grrrit-wm>	 (03PS1) 10MaxSem: Fix linking on Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116524 
[18:59:01] <grrrit-wm>	 (03PS4) 10Brion VIBBER: When following links with hash/fragments on them, jump to the anchor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116184 
[18:59:08] <brion>	 YuviPanda: ^
[19:00:57] <YuviPanda>	 brion: looking
[19:05:57] <grrrit-wm>	 (03PS3) 10Kaldari: Story 1732: Some preliminary clean-up for new licensing messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116016 
[19:12:34] <grrrit-wm>	 (03PS1) 10Mhurd: Edit changes can now be previewed. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/116528 
[19:12:49] <mhurd>	 brion: ^
[19:13:12] <brion>	 wooooohooooo
[19:15:22] <YuviPanda>	 brion: do you have a test page you use for the fragments?
[19:16:08] <brion>	 YuviPanda: so far the one mentioned in the bug
[19:16:20] <brion>	 ROM Hacking, find the street fighter whatever link
[19:16:21] <YuviPanda>	 brion: oh, right
[19:17:52] <vbamba>	 YuviPanda:  got Oliver's Notes! thanks for forwarding to the group
[19:18:22] <YuviPanda>	 vbamba: oo! :)
[19:20:22] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032 V: 032] "Seems to work! \o/" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116184 (owner: 10Brion VIBBER)
[19:20:30] <YuviPanda>	 brion: \o/
[19:20:31] <brion>	 woot
[19:20:33] <YuviPanda>	 brion: I'll be off in a bit
[19:21:36] <brion>	 ok
[19:21:38] <YuviPanda>	 ok I'm off now!
[19:21:39] <YuviPanda>	 :P
[19:23:36] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Fix linking on Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116524 (owner: 10MaxSem)
[19:24:17] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix linking on Special:History [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116524 (owner: 10MaxSem)
[20:42:33] <grrrit-wm>	 (03PS1) 10MaxSem: Display content in its intended directionality [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116538 
[20:44:16] <MaxSem>	 no Kenan today?
[20:59:15] <awjr|lunch>	 coreect MaxSem, he's back tomorrow
[21:55:38] <jgonera>	 awjr, I can't drag https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1689 to awaiting code review
[21:55:57] <awjr>	 o_O
[21:56:09] <jgonera>	 related patchset is https://gerrit.wikimedia.org/r/#/c/116635/ (for the mandatory comment)
[21:56:13] <awjr>	 doh
[21:56:20] <awjr>	 stupid transitions
[21:58:39] <awjr>	 jgonera: try again?
[21:59:01] <tfinc>	 jgonera: see my notes on your comments? just go ahead and edit
[22:11:44] <mhurd>	 tfinc: i'll see if those videos can be attachd to trello cards...
[22:16:13] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Clarify purpose of page actions tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116639 
[22:16:15] <grrrit-wm>	 (03PS1) 10Jdlrobson: QA: Refactor tests involving drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116640 
[22:16:17] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Use toast terminology [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116641 
[22:16:19] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Consolidate page actions in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116642 
[22:16:21] <grrrit-wm>	 (03PS1) 10Jdlrobson: QA: Actually ensure we test the watch star feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116643 
[22:16:23] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Use inherited ArticlePage properties for search elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116644 
[22:22:42] <grrrit-wm>	 (03PS2) 10Jdlrobson: Ensure checkToggleView() fires at appropriate time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116180 (owner: 10Awjrichards)
[22:23:12] <grrrit-wm>	 (03CR) 10Jdlrobson: Ensure checkToggleView() fires at appropriate time (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116180 (owner: 10Awjrichards)
[22:23:35] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "Fixed whitespace issue myself. +2ing" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116180 (owner: 10Awjrichards)
[22:24:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ensure checkToggleView() fires at appropriate time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116180 (owner: 10Awjrichards)
[22:28:16] <jgonera>	 awjr, who should I poke about JS patches in core? should I just add Krinkle or someone else as a reviewer?
[22:29:04] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Some preliminary clean-up for new licensing messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116016 (owner: 10Kaldari)
[22:29:14] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Some preliminary clean-up for new licensing messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116016 (owner: 10Kaldari)
[22:29:20] <mhurd>	 tfinc: looks like trello has a 10mb attachement limit - i downsampled mays videos to come in under 10mb and they attached nicely :)
[22:29:38] <mhurd>	 violetto: ^ (re: https://trello.com/c/Rlu3HxLA/6-design)
[22:30:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Some preliminary clean-up for new licensing messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116016 (owner: 10Kaldari)
[22:33:52] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Display content in its intended directionality [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116538 (owner: 10MaxSem)
[22:34:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Display content in its intended directionality [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116538 (owner: 10MaxSem)
[22:35:20] <awjr>	 jgonera: js patches in general, or do you have patches focussing on a specific core component?
[22:36:55] <jdlrobson>	 https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1708 < awjr tut tut not keeping mingle up to date ;-)
[22:37:27] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] Ensure a toast shows when uploading an invalid file (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116181 (owner: 10Jdlrobson)
[22:37:29] <awjr>	 whoop
[22:37:30] <awjr>	 s
[22:37:40] <awjr>	 i blame last minute check in and conversation on friday :p
[22:38:53] <awjr>	 jgonera: the short version of the answer to your question is assign Krinkle for now, though there may be better people to poke for specific components of core (though who specifically would require some thought). if something's not getting any response, scrum of scrums is a good place to harass folks to review
[22:40:16] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Hygiene: Clarify purpose of page actions tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116639 (owner: 10Jdlrobson)
[22:41:12] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] QA: Refactor tests involving drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116640 (owner: 10Jdlrobson)
[22:42:29] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Hygiene: Use toast terminology [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116641 (owner: 10Jdlrobson)
[22:45:41] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Hygiene: Consolidate page actions in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116642 (owner: 10Jdlrobson)
[22:45:56] <grrrit-wm>	 (03PS2) 10Jdlrobson: Ensure a toast shows when uploading an invalid file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116181 
[22:47:39] <grrrit-wm>	 (03PS3) 10Jdlrobson: Ensure a toast shows when uploading an invalid file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116181 
[22:50:27] <grrrit-wm>	 (03PS4) 10Jdlrobson: Ensure a toast shows when uploading an invalid file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116181 
[22:51:40] <grrrit-wm>	 (03PS1) 10Brion VIBBER: Work in progress: save scroll position by element instead of raw offset [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116653 
[23:02:30] <mhurd>	 tfinc: violetto: brion: any thoughts on the new "best practice" card i just added to the design assets board regarding video mockups? https://trello.com/c/HwprA2r7/69-when-attaching-videos-for-user-interaction-mockups-aim-for-less-than-10mb-file-size-so-the-video-can-be-directly-attached-to-the
[23:04:40] <jdlrobson>	 jgonera: please pretty please https://gerrit.wikimedia.org/r/116181
[23:08:26] <grrrit-wm>	 (03PS4) 10Jdlrobson: Update last modified time when a template or file changes in MFResourceLoaderModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 
[23:08:26] <brion>	 mhurd: nice. videos ftw!
[23:08:28] <brion>	 small videos :)
[23:08:45] <jdlrobson>	 ^ awjr jgonera guys we still haven't merged the fix to this serious bug that was causing issues on beta labs
[23:09:10] <grrrit-wm>	 (03PS4) 10Jdlrobson: Make special pages always have a route from desktop to mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115955 
[23:11:09] <jgonera>	 tfinc, is Victor's movie about Wikipedia Zero somewhere?
[23:11:19] <jdlrobson>	 jgonera: i have it - let me dig it out
[23:12:09] <jdlrobson>	 http://www.change.org/petitions/the-1-generous-thing-mobile-providers-could-do-to-help-kids-all-over-the-world?share_id=bXZnsfHYrm&utm_campaign=twitter_link_action_box&utm_medium=twitter&utm_source=share_petition < jgonera 
[23:19:07] <grrrit-wm>	 (03CR) 10Kaldari: [C: 032] Make special pages always have a route from desktop to mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115955 (owner: 10Jdlrobson)
[23:19:32] <jgonera>	 jdlrobson, why did you change L31 back at https://gerrit.wikimedia.org/r/#/c/116181/1..4/tests/browser/features/step_definitions/uploads_steps.rb ?
[23:19:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make special pages always have a route from desktop to mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115955 (owner: 10Jdlrobson)
[23:25:04] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] QA: Actually ensure we test the watch star feature (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116643 (owner: 10Jdlrobson)
[23:26:26] <kaldari>	 vbamba: Here's the fun project I worked on over the weekend: http://tools.wmflabs.org/svg-map-maker/
[23:26:35] <kaldari>	 vbamba: Now I just need to make a version for the whole world
[23:26:46] <kaldari>	 vbamba: and get more sleep
[23:28:03] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Hygiene: Use inherited ArticlePage properties for search elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116644 (owner: 10Jdlrobson)
[23:29:39] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Be more specific in dependencies on mobile.newusers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116171 (owner: 10Jdlrobson)
[23:30:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Be more specific in dependencies on mobile.newusers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116171 (owner: 10Jdlrobson)
[23:40:14] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Ensure a toast shows when uploading an invalid file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116181 (owner: 10Jdlrobson)
[23:40:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ensure a toast shows when uploading an invalid file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116181 (owner: 10Jdlrobson)
[23:41:45] <jdlrobson>	 awjr: did kenan get back to you about signing stuff off?
[23:42:13] <awjr>	 jdlrobson: he mentioned he will do his best while on vacation to work through the signoff column before tomorrow
[23:42:14] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Clarify purpose of page actions tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116639 
[23:42:17] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Clarify purpose of page actions tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116639 (owner: 10Jdlrobson)
[23:42:29] <grrrit-wm>	 (03PS2) 10Jdlrobson: QA: Refactor tests involving drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116640 
[23:42:33] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] QA: Refactor tests involving drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116640 (owner: 10Jdlrobson)
[23:42:40] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Use toast terminology [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116641 
[23:42:44] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Use toast terminology [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116641 (owner: 10Jdlrobson)
[23:42:49] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Consolidate page actions in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116642 
[23:42:53] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Hygiene: Consolidate page actions in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116642 (owner: 10Jdlrobson)
[23:43:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Clarify purpose of page actions tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116639 (owner: 10Jdlrobson)
[23:43:52] <vbamba>	 kaldari:  very clean =]
[23:43:59] <vbamba>	 i could use this
[23:44:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: Refactor tests involving drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116640 (owner: 10Jdlrobson)
[23:45:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Use toast terminology [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116641 (owner: 10Jdlrobson)
[23:46:10] <kaldari>	 jdlrobson: sent you a stack of money
[23:46:17] <awjr>	 o_O
[23:46:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Consolidate page actions in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116642 (owner: 10Jdlrobson)
[23:47:00] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Use inherited ArticlePage properties for search elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116644 
[23:47:06] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Use inherited ArticlePage properties for search elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116644 (owner: 10Jdlrobson)
[23:49:51] <jgonera>	 awjr, why do we change from Host to Location in https://gerrit.wikimedia.org/r/#/c/115844/1 ?
[23:50:30] <vbamba>	 kaldari:  got time to talk about Typography stuff?
[23:50:53] <awjr>	 jgonera: because you can more accurately get the 'host' out of the location than out of the 'host' header (at least for our purposes)
[23:51:12] <awjr>	 jgonera: in MW Vagrant for instance, the host header would say '127.0.0.1:8080'
[23:51:34] <jgonera>	 so the host is there, right?
[23:53:15] <awjr>	 in the location header?
[23:53:28] <awjr>	 location header contains the full URL
[23:53:34] <awjr>	 so it's easier to parse all the bits out
[23:53:49] <kaldari>	 vbamba: sure
[23:53:54] <awjr>	 jgonera: ^^
[23:54:29] <jgonera>	 you mean you can't use wfParseUrl on what Host contains?
[23:55:04] <awjr>	 no
[23:55:29] <awjr>	 jgonera: i mean, yes tthat is what i mean - no you cannot use wfParseUrl on what host contains
[23:57:18] <jgonera>	 awjr, so my only concern is that I'm not sure if MW always returns an absolute URL in the Location header
[23:57:25] <awjr>	 interesting
[23:57:32] <jgonera>	 I mean, according to HTTP it should, but browsers accept relative ones too
[23:57:44] <jgonera>	 but I guess it doesn't matter in this case
[23:57:52] <awjr>	 jgonera: that is a good point
[23:57:53] <jgonera>	 I can imagine this could only happen on a redirect
[23:58:09] <awjr>	 jgonera: let me finish up what im doing right now and i can look into it a litlte further
[23:58:14] <jgonera>	 ok, thanks
[23:58:23] <awjr>	 it would be crappy but not terribly surprising to have the location header not behave as expected
[23:58:47] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] Fix internal domain handling to ensure various cookies get properly set (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115844 (owner: 10Awjrichards)
[23:59:02] <jgonera>	 maybe I'm overly cautious though
[23:59:38] <jgonera>	 jdlrobson, rebase https://gerrit.wikimedia.org/r/#/c/116644/