[00:01:58] jgonera: nah, it's totally legit. i've been bitten by surprising header values before :) [00:05:04] okkiiiiieeeee - Heading Over [00:25:21] (03PS1) 10Dr0ptp4kt: Change "No thanks" to "Dismiss" for Wikipedia Zero dialog. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116668 [00:28:11] mhurd: can you seed this a bit https://etherpad.wikimedia.org/p/FlowAsAService ? [00:33:48] awjr: jgonera: I assume you meant https://gerrit.wikimedia.org/r/#/c/116037/ ? [00:34:47] tfinc: ya! [00:37:50] (03PS1) 10Kaldari: Hygiene: Add a FIXME to migrate to mw-ui-button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116672 [00:37:55] hmm mobile editing doesn't seem to handle the creation of redirects very well [00:44:13] Krinkle, yes, thanks [00:49:22] awjr, in what circumstances? [00:49:59] jgonera: in my local instance, i created a redirect which resulted in some weird behavior [00:50:25] awjr, raise a bug if it looks serious [00:50:32] jgonera: yup [00:59:45] Krinkle, what is the guideline for multiple vars? is "var\n\ta = 1,\n\tb = 2;" ok? [01:00:08] jgonera: yes [01:00:16] ok [01:14:38] jgonera: i actually think it would be better to use $wgServer rather than the location header [01:14:57] i dont know why i didnt think of that to begin with [01:14:57] where does $wgServer [01:15:00] 's value come from [01:15:09] it's a config value [01:15:16] if it's not set in LocalSettings.php it gets autodetected [01:15:33] WebRequest::detectServer() [01:21:42] (03PS2) 10Jdlrobson: QA: Actually ensure we test the watch star feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116643 [01:21:44] (03PS3) 10Jdlrobson: Hygiene: Use inherited ArticlePage properties for search elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116644 [01:21:46] (03PS1) 10Jdlrobson: Hygiene: Make left navigation item selection more generic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116679 [01:21:48] (03PS1) 10Jdlrobson: Hygiene: Remove redundant test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116680 [01:21:50] (03PS1) 10Jdlrobson: QA: Update tests for basic version of mobile site. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116681 [01:44:09] (03PS2) 10Awjrichards: Fix internal domain handling to ensure various cookies get properly set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115844 [01:56:44] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Make left navigation item selection more generic (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116679 (owner: 10Jdlrobson) [02:07:18] (03CR) 10Jdlrobson: QA: Actually ensure we test the watch star feature (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116643 (owner: 10Jdlrobson) [02:14:31] (03PS1) 10JGonera: Use fixed header emulation only on iPad, not iPhone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116690 [02:18:27] (03PS2) 10Jdlrobson: Hygiene: Remove redundant test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116680 [02:18:29] (03PS2) 10Jdlrobson: QA: Update tests for basic version of mobile site. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116681 [02:18:31] (03PS2) 10Jdlrobson: Hygiene: Make left navigation item selection more generic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116679 [02:18:33] (03PS3) 10Jdlrobson: QA: Actually ensure we test the watch star feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116643 [02:18:35] (03PS4) 10Jdlrobson: Hygiene: Use inherited ArticlePage properties for search elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116644 [02:18:37] (03PS1) 10Jdlrobson: Hygiene: Group together main menu navigation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 [02:18:45] (03CR) 10jenkins-bot: [V: 04-1] QA: Actually ensure we test the watch star feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116643 (owner: 10Jdlrobson) [02:19:53] (03CR) 10Jdlrobson: [C: 04-1] "Add comment pointing to associated bug report." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116672 (owner: 10Kaldari) [02:20:59] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116643 (owner: 10Jdlrobson) [02:22:16] where did jenkins go.. o_O https://gerrit.wikimedia.org/r/#/c/116643/3 [02:22:22] i can't get him bavk [02:27:41] (03CR) 10JGonera: [C: 032] QA: Actually ensure we test the watch star feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116643 (owner: 10Jdlrobson) [02:28:19] (03Merged) 10jenkins-bot: QA: Actually ensure we test the watch star feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116643 (owner: 10Jdlrobson) [02:28:57] (03PS1) 10Jdlrobson: Hygiene: Remove need in QA tests for LogoutPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116696 [02:32:40] (03PS1) 10Jdlrobson: Hygiene: Rename QA file to use underscores [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116697 [02:32:42] (03PS1) 10Jdlrobson: Hygiene: Kill meaningless create_article.feature browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116698 [02:32:46] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Rename QA file to use underscores [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116697 (owner: 10Jdlrobson) [02:32:52] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Kill meaningless create_article.feature browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116698 (owner: 10Jdlrobson) [02:33:28] (03PS2) 10Jdlrobson: Hygiene: Kill meaningless create_article.feature browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116698 [02:33:30] (03PS2) 10Jdlrobson: Hygiene: Rename QA file to use underscores [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116697 [02:33:32] (03PS2) 10Jdlrobson: Hygiene: Remove need in QA tests for LogoutPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116696 [03:17:30] (03PS1) 10Vikassy: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116706 [04:02:59] (03PS1) 10Vikassy: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/116716 [14:36:53] (03CR) 10Yuvipanda: [C: 032 V: 032] Change "No thanks" to "Dismiss" for Wikipedia Zero dialog. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116668 (owner: 10Dr0ptp4kt) [14:38:27] (03CR) 10Yuvipanda: [C: 04-2] "I'm not sure if this is the right approach. We should investigate what the default browser does and just copy that. Lots of other apps als" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116653 (owner: 10Brion VIBBER) [16:05:24] hi vbamba [16:08:11] hey YuviPanda [16:08:38] hey brion! [16:08:53] YuviPanda: do we only need the one strings.xml for android or is there a possibility we might have to localize multiple strings files? [16:09:11] brion: we can split them up later if we want, but right now only strings.xml I believe. [16:09:18] brion: we can also condense them if we want [16:09:21] ok one is easier :) [16:09:32] nike's just checking if i need the infrastructure for multiple files [16:09:35] when we only have one for now [16:09:58] brion: yeah, one's enough. we can always force ourselves to just have one [16:10:01] brion: also I -2'd one patch [16:10:06] heh [16:11:12] brion: I think that approach in the patch will just lead us down a rabbit hole of sorts :D Will it work for preview, abuse filter, or other webview things we have in the future? [16:11:30] who knows, man. who knows [16:11:35] brion: :D [16:11:58] brion: I have a feeling we're missing a trick somewhere. we should be able to just let the webview not destroy and re-create itself [16:12:24] well that'll only work as long as we keep the web view around [16:12:27] which reminds me [16:12:36] do we ever discard web views from things on the back stack? [16:12:45] if i click 100 links deep, do we have 100 web views in memory? [16:13:55] brion: yeah, we do. that needs fixing, and I think this will need to get fixed with that. [16:14:02] brion: that reminds me [16:14:09] (03PS1) 10Yuvipanda: Revert "Cleanup webviews when we no longer require them" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116752 [16:14:16] brion: ^ fixes a crash [16:14:20] brion: a *segfault* [16:15:17] (03CR) 10Brion VIBBER: [C: 032 V: 032] Revert "Cleanup webviews when we no longer require them" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116752 (owner: 10Yuvipanda) [16:15:23] nice [16:15:24] brion: yeah, sweet. [16:15:44] brion: so the problem is that I don't fully understand how fragments' state in the backstack are handled. [16:15:50] brion: so replacing them is a problem [16:16:02] brion: also, I just found out that webview has a method called 'saveState' and 'restoreState' :| [16:16:02] lol [16:16:07] hah nice [16:16:11] brion: so try that? [16:16:16] worth a shot eh [16:16:36] brion: yeah [16:16:59] brion: I don't like the crrent solution. it also means we've to cross the bridge with data during phone rotate which sucks [16:17:18] yeah it's sub ideal [16:17:22] but i thought it would be fun to try :D [16:17:29] brion: :D indeed! [16:20:16] brion: I realized you need to maintain zoom as well, not just scroll :P [16:20:30] detaisl [16:20:41] brion: yeah :D [17:52:57] YuviPanda, thanks for the +2 on the verbiage update [17:58:22] (03PS1) 10Brion VIBBER: Remove stray whitespace from strings.xml [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116766 [17:59:17] (03CR) 10Brion VIBBER: [C: 032 V: 032] "translatewiki extracts the spaces from indentation, which it maybe should or shouldn't but let's just take em out here on this end" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116766 (owner: 10Brion VIBBER) [18:02:37] jdlrobson: kaldari kaity|away kickoff? [18:02:43] anyone seen kenan or juliusz? [18:03:18] Awjr: 2 minutes away [18:03:32] k MaxSem and i are waiting [18:05:36] awjr: r31 is taken [18:05:58] jdlrobson: looks like the room reserved for this is r35 [18:06:06] ahh turns out we are in r35 awjr i'm there with kenanwang who is setting u [18:06:14] my calendar invite must have been out of date [18:07:53] dr0ptp4kt: :) yw! [18:08:13] brion: self merge that is ok [18:08:36] didn't think you'd mind that one ;) [18:10:15] brion: :D [18:10:30] brion: can you try out the saveState things later? [18:10:48] yeah iv[e started fiddling with it [18:10:53] currently crashing, needs more work ;) [18:12:22] moar coffee, brb [18:12:32] brion: wooo! [18:13:33] hey vbamba [18:19:57] hey mhurd! [18:20:04] YuviPanda! [18:20:19] mhurd: I saw the flow meeting, I think it's a bit too late for me. I guess you can handle it? rope in brion too if you want [18:21:03] YuviPanda: would you have a few minutes for adding questions/points/asks to https://etherpad.wikimedia.org/p/FlowAsAService ? [18:21:32] mhurd: looking [18:25:52] mhurd: we should probably rename it as well. 'Service' has a very specific meaning in the current mediawiki climate (things like Parsoid, the Offline Renderer, Mathoid, etc that run as separate processes). This is mostly about making sure there is a clean API, so we should rename it that way to set easier expectations [18:26:47] mhurd: legoktm knows a good amount about the API and also works on Flow (I think?). He should also be able to help :) [18:27:14] I am :P [18:27:21] YuviPanda: good point about service [18:27:23] mhurd: we're currently in the process of re-writing the entire API [18:27:36] legoktm: Did we already implement flow in pywikibot? [18:27:51] mhurd: legoktm is also an iOS user and is WMF staff and is on the beta :P [18:27:59] multichill: no, I'm re-writing the API first :P [18:28:11] That sounds like a good order of doing things :P [18:28:26] mhurd: I added some things to the etherpad [18:28:32] mhurd: legoktm https://etherpad.wikimedia.org/p/FlowAsAService [18:28:35] legoktm: awesome! [18:28:42] YuviPanda: thanks! [18:29:01] mhurd: poke legoktm with background questions if you have 'em :) [18:29:16] legoktm: So https://www.mediawiki.org/wiki/Z%C3%BCrich_Hackathon_2014#Flow_for_bot_developers is a bit useless? [18:29:40] multichill: if it is done with the API as is, I suppose it'll just be people bitching about the API sucking? :P [18:29:49] hehe [18:29:57] multichill: it should be done by then [18:30:02] multichill: would you be at the hackathon? [18:30:20] I plan to go there yes [18:30:30] multichill: woo! Would be nice to meet again! :) [18:30:37] Would be nice to have the pywikibot part of flow also up and running by than. [18:30:37] vbamba: around? [18:30:50] YuviPanda: yeah! [18:31:07] We have a lot of notification bots that could be rewritten to insert things in flow [18:31:43] multichill: someone has suggested that flow intercept action=edit§ion=new API requests auto automatically convert them into Flow [18:32:14] legoktm: And I suppose you shot that person? [18:32:25] https://etherpad.wikimedia.org/p/MobileWeb-IterationName [18:32:31] Doing that in the api is just nasty [18:32:50] multichill: ha, nope. [18:33:02] https://bugzilla.wikimedia.org/show_bug.cgi?id=57989 for the record [18:33:18] For the uncategorized image notification I just left the message once and than added the additional messages to the first one [18:33:33] Would be nice if that is possible in flow too to prevent from overflowing people [18:35:42] mhurd: YuviPanda thanks for seeding https://etherpad.wikimedia.org/p/FlowAsAService [18:35:49] YuviPanda: i saw the you declined [18:35:52] too late for you? [18:36:00] tfinc: np [18:36:04] tfinc: yeah, it's a bit late for me. Plus my hand has been acting up as well. [18:36:12] YuviPanda: :( [18:36:18] tfinc: I talked to legoktm (who is rewriting the most important part of flow for us - the API) and mhurd about it [18:36:29] mhurd: yeah, it's started shaking by itself now :'( [18:36:41] mhurd: I'm freaking out a bit, but I'll be fine. Have a doctor's appointment on monday [18:37:13] YuviPanda: oh man. ya def get rest now [18:37:34] bbl [18:39:26] YuviPanda: k. as long as mhurd can represent you well [18:39:38] tfinc: yeah, I think I've told him enough things :) [18:39:51] mhurd: Did you check my notes on etherpad [18:40:13] YuviPanda: yes - thanks!! [18:41:08] mhurd: off now! [18:41:14] YuviPanda: have a good night! [18:47:33] (03CR) 10Jdlrobson: [C: 032] Use fixed header emulation only on iPad, not iPhone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116690 (owner: 10JGonera) [18:48:18] (03Merged) 10jenkins-bot: Use fixed header emulation only on iPad, not iPhone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116690 (owner: 10JGonera) [19:06:17] (03CR) 10JGonera: [C: 032] Fix internal domain handling to ensure various cookies get properly set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115844 (owner: 10Awjrichards) [19:06:58] (03Merged) 10jenkins-bot: Fix internal domain handling to ensure various cookies get properly set [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115844 (owner: 10Awjrichards) [19:11:21] (03PS2) 10Jdlrobson: Hygiene: Group together main menu navigation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 [19:11:23] (03PS1) 10Jdlrobson: QA: Simplify article page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116778 [19:12:14] (03CR) 10JGonera: [C: 032] Hygiene: Remove need in QA tests for LogoutPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116696 (owner: 10Jdlrobson) [19:12:35] (03CR) 10JGonera: [C: 032] Hygiene: Rename QA file to use underscores [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116697 (owner: 10Jdlrobson) [19:13:07] (03Merged) 10jenkins-bot: Hygiene: Remove need in QA tests for LogoutPage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116696 (owner: 10Jdlrobson) [19:13:24] (03CR) 10JGonera: [C: 032] Hygiene: Kill meaningless create_article.feature browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116698 (owner: 10Jdlrobson) [19:14:21] (03Merged) 10jenkins-bot: Hygiene: Rename QA file to use underscores [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116697 (owner: 10Jdlrobson) [19:14:23] (03Merged) 10jenkins-bot: Hygiene: Kill meaningless create_article.feature browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116698 (owner: 10Jdlrobson) [19:14:28] (03CR) 10JGonera: [C: 032] Hygiene: Remove redundant test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116680 (owner: 10Jdlrobson) [19:20:11] (03PS2) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [19:20:31] jdlrobson: What's the URL of your live style guide again? [19:20:34] (03CR) 10JGonera: [C: 04-1] "Just a few comments. I'm glad you're doing this, it has been on my TODO list for a long time." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116681 (owner: 10Jdlrobson) [19:29:39] (03PS3) 10Jdlrobson: Hygiene: Remove redundant test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116680 [19:29:41] (03PS3) 10Jdlrobson: QA: Update tests for basic version of mobile site. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116681 [19:29:43] (03PS3) 10Jdlrobson: Hygiene: Make left navigation item selection more generic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116679 [19:29:45] (03PS5) 10Jdlrobson: Hygiene: Use inherited ArticlePage properties for search elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116644 [19:29:58] (03CR) 10Jdlrobson: [C: 032] "Not sure why jenkins didn't kick in" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116680 (owner: 10Jdlrobson) [19:30:21] (03PS3) 10Jdlrobson: Hygiene: Group together main menu navigation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 [19:30:40] kaldari: tools.wmflabs.org/styleguide/ [19:30:43] thanks [19:33:14] (03PS2) 10Jdlrobson: QA: Simplify article page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116778 [19:34:33] (03CR) 10JGonera: "Comments in patchset 2." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 (owner: 10Jdlrobson) [19:39:14] (03CR) 10JGonera: [C: 032] QA: Update tests for basic version of mobile site. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116681 (owner: 10Jdlrobson) [19:46:36] (03CR) 10JGonera: [C: 04-1] Hygiene: Group together main menu navigation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 (owner: 10Jdlrobson) [19:48:34] (03CR) 10JGonera: [C: 032] Hygiene: Make left navigation item selection more generic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116679 (owner: 10Jdlrobson) [19:49:08] (03CR) 10JGonera: [C: 032] Hygiene: Use inherited ArticlePage properties for search elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116644 (owner: 10Jdlrobson) [19:49:33] (03CR) 10JGonera: [C: 032] Hygiene: Remove redundant test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116680 (owner: 10Jdlrobson) [19:49:51] (03Merged) 10jenkins-bot: Hygiene: Use inherited ArticlePage properties for search elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116644 (owner: 10Jdlrobson) [19:50:28] (03Merged) 10jenkins-bot: Hygiene: Make left navigation item selection more generic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116679 (owner: 10Jdlrobson) [19:50:41] You folks are evil. Just converted over to varnish, saw the Varnish link on this page: http://www.mediawiki.org/wiki/Extension:MobileFrontend/Configuring_browser_auto-detection got ALL kinds of excited. Not found. :| [19:50:47] (03CR) 10JGonera: [C: 032] QA: Simplify article page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116778 (owner: 10Jdlrobson) [19:50:59] (03Merged) 10jenkins-bot: Hygiene: Remove redundant test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116680 (owner: 10Jdlrobson) [19:51:29] (03Merged) 10jenkins-bot: QA: Update tests for basic version of mobile site. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116681 (owner: 10Jdlrobson) [19:52:04] (03Merged) 10jenkins-bot: QA: Simplify article page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116778 (owner: 10Jdlrobson) [19:54:13] awjr, MaxSem do you know where that file that Ulfr_ is looking for is now? [19:54:19] can't see it in https://git.wikimedia.org/tree/operations%2Fpuppet/145d3b765b6fce5f9fc19a4adb4cf49ea80dc6f8/templates%2Fvarnish [19:54:29] original link is https://gerrit.wikimedia.org/r/gitweb%3Fp%3Doperations/puppet.git;a%3Dblob;f%3Dtemplates/varnish/device-detection.inc.vcl.erb;hb%3DHEAD [19:55:06] jgonera, it's gone - we deprecated WAP [19:55:43] MaxSem: How do I make MobileFrontend and Varnish play nicely then? [19:56:06] Ulfr_, that file was only for WAP device detection [19:56:07] MaxSem, but it's not about WAP I guess, it's about redirecting to mobile from Varnish [19:56:31] where do we have the other rules then? [19:56:54] Ulfr_, it's in the beginning of text_frontend [19:57:05] sub mobile_redirect [19:57:40] MaxSem: Sorry, little lost. I've got a mediawiki install that has a reverse proxy setup that I would like to be vaguely mobile friendly [19:58:02] I can bushwhack with apache configs on my lonesome but it looked like you folks had something ready to go for a setup like mine [19:58:05] Ulfr_, so do you actually need varnish? [19:58:19] MaxSem: Yuh, installs faster than squid and makes parsoid happy [19:59:08] Get a fair amount of traffic, have 3 load balanced frontends [19:59:20] in addition to mobile support, Varnish needs a few other tweaks to work properly with MW [19:59:48] Ulfr_, uh - got what you want [20:00:02] Seems to have taken to mine just fine, I swapped squid out for varnish and it's running swimmingly [20:00:08] hehe, you're our first third-party user with varnish [20:00:13] Oh god. [20:00:16] sooo [20:00:20] * Ulfr_ hates feeling like patient 0 [20:00:32] we've been #0, youre #1 [20:00:47] Oddly, I feel better. [20:01:21] if you have a separate mobile domain, just set X-WAP: no header for it [20:01:46] (this header will become configurable at a later point) [20:02:11] MaxSem: In terms of what, domain? [20:02:22] ? [20:02:44] sorry, I know apache and haproxy configs, not too sure what X-WAP is though [20:02:59] I have a mobile.wikidoc.org domain set up though, doesn't really point anywhere I don't think [20:03:32] it's a custom header we use to tell "hey MF, you're free to act" [20:03:58] MaxSem: Gotcha. This is in Varnish? [20:05:04] sub vcl_recv { [20:05:05] set req.http.X-WAP = 'no'; [20:05:05] } [20:05:22] MaxSem: o7 [20:07:37] I'm not dense, I promise, I just started using varnish like, yesterday. [20:07:46] and my old squid config didn't like it when I changed stuff [20:22:25] (03PS4) 10MaxSem: Kill WAP and dance on its grave [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116147 [20:35:52] MaxSem: What's next? [20:40:07] set up mobile domain? [20:40:21] then try it [20:50:19] (03Abandoned) 10Brion VIBBER: Work in progress: save scroll position by element instead of raw offset [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116653 (owner: 10Brion VIBBER) [20:51:14] MaxSem: o7 [20:51:23] ow-seven? [20:51:36] http://www.urbandictionary.com/define.php?term=o7 [20:51:44] i really need to make that urban dictionary bot... [20:53:12] It's a little guy saluting [20:53:16] the o is the head, 7 is the arm [20:56:27] I've cleaned up https://www.mediawiki.org/wiki/Extension:MobileFrontend/Configuring_browser_auto-detection#Webserver.2Fproxy-cache_device_detection meanwhile [21:04:22] jgonera: i tightened up that last bullet point as it was hard to read [21:05:21] jgonera: starting a sentence with Push is a bit awkward. hmm i wonder if we can use something else [21:08:24] MaxSem: Sorry, really lost atm. Was there a file that already had device detection built in? [21:08:51] Ulfr_, once again: that file was for WAP only. gone now [21:10:32] see https://www.mediawiki.org/wiki/Extension:MobileFrontend/Configuring_browser_auto-detection#Webserver.2Fproxy-cache_device_detection for a VCL example [21:10:52] note: I haven't set this up from scratch either:) [21:11:31] MaxSem: Heh, I thought not. It seemed really scary. How do I direct mobile clients from the main domain to the mobile domain? [21:12:59] Ulfr_, https://git.wikimedia.org/blob/operations%2Fpuppet/145d3b765b6fce5f9fc19a4adb4cf49ea80dc6f8/templates%2Fvarnish%2Ftext-frontend.inc.vcl.erb#L23 [21:13:56] MaxSem: I owe you many beers/sodas. [21:17:53] tfinc, I changed "push" to simply "use" [21:19:18] awjr: are the QA tests still mailing us? I'm getting issues locally which make me suspect they might be not - can't find chris to check [21:19:42] good question jdlrobson - now that you mention it, i havent seen jenkins failure emails in a while, which is weird [21:19:54] jgonera: what about "Use and evolve .. " ? [21:20:25] so that they know we can get involved in w3c conversations [21:20:25] tfinc, hm, I guess I know what you mean but it kind of sounds like if we were working on W3C drafts ;) [21:20:27] let me think [21:20:37] have we done that recently? [21:20:44] i know amir pointed to one a bit ago that spun out of our discussions [21:22:19] (03PS1) 10Jdlrobson: Hygiene: Lint the cucumber tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116863 [21:22:30] jdlrobson: the last failure message i got was on feb 18... [21:22:35] awjr: same [21:22:43] about the time juliusz asked them not to be sent to mobile-l [21:22:52] and according to https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/ there are failure [21:22:52] s [21:23:21] https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/338/ < [21:23:23] yup [21:23:31] chris is out sick today [21:23:55] which leave zeljko, although he works odd hours (at least relative to us) [21:24:32] good catch jdlrobson, i was just assuming that we had resolved the failure issues :p [21:24:40] i wasn't so confident.. [21:24:59] to be fair, i wasn't really conscious of the lack of emails [21:28:03] tfinc, I don't know, unless we can actually point to something significant, like a draft that was started because of something we did, I'd not mention it. Maybe I'd somehow say that we're trying to be innovative and creative with web standards, but I'm not sure how to word that [21:28:40] tfinc: would 4 or 5 of the 4inch lightning cables be ok? $12 a piece on monoprice... [21:31:44] YuviPanda, ping [21:32:16] MaxSem: yuvi's hand was acting up and he turned in early today [21:33:39] (03PS2) 10Jdlrobson: Hygiene: Lint the cucumber tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116863 [21:35:09] ^ awjr that should fix the builds [21:36:28] MaxSem: Great success! [21:37:26] mhurd, thanks - just wanted to discuss https://bugzilla.wikimedia.org/show_bug.cgi?id=61704 [21:37:32] Ulfr_, works? [21:37:43] MaxSem: As well as it can at the moment [21:38:11] My AWS interface service is having a case of the downs atm, so I've only got two frontends and only one has the config, but I rolled the dice enough times to get the mobile skin to appear [21:41:10] mhurd: order what you guys need [21:41:32] tfinc: sounds good. i just found a 15% off coupon code too :) [21:43:29] jgonera: i'm fine posting it as is. made one edit. going to send it to emily [21:46:24] tfinc, OK, we'll reiterate on it [21:53:41] (03PS1) 10Brion VIBBER: Preserve activity & web view state across rotation etc [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116867 [21:55:01] (03PS4) 10Jdlrobson: Hygiene: Group together main menu navigation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 [21:59:43] (03CR) 10JGonera: [C: 04-1] "Tracking clicks in Nearby and Log out doesn't seem to work. Also, if you're logged out and click on Watchlist, it also doesn't log it." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 (owner: 10Jdlrobson) [22:09:39] (03PS1) 10Jdlrobson: Hygiene: Kill "I go to the" common step in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116871 [22:16:26] jdlrobson: What bug report are you referring to in https://gerrit.wikimedia.org/r/#/c/116672/? [22:33:58] (03PS2) 10Kaldari: Hygiene: Add a FIXME to migrate to mw-ui-button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116672 [22:46:38] (03PS1) 10Mhurd: User is automatically logged in after account creation. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/116894 [22:46:46] brion: ^ yay! [22:47:03] woot [22:53:09] (03PS1) 10Jdlrobson: QA: Kill Image resolves test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116898 [22:53:11] (03PS1) 10Jdlrobson: Hygiene: One final big round of QA hygiene [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116899 [22:53:13] (03PS1) 10Jdlrobson: Hygiene: Kill that 'I am on the User login page' rule in QA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116900 [22:53:15] (03PS1) 10Jdlrobson: Hygiene: Kill pointless external link test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116901 [22:54:29] (03PS3) 10Jdlrobson: Hygiene: Add a FIXME note to migrate to mw-ui-button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116672 (owner: 10Kaldari) [22:58:15] (03CR) 10Jdlrobson: [C: 032] "I meant in the comment itself but never mind not important" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116672 (owner: 10Kaldari) [22:58:48] (03PS2) 10Jdlrobson: QA: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116706 (owner: 10Vikassy) [22:58:55] (03Merged) 10jenkins-bot: Hygiene: Add a FIXME note to migrate to mw-ui-button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116672 (owner: 10Kaldari) [23:01:37] (03Abandoned) 10Jdlrobson: On "File does not exist" disable edit, enable upload [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104324 (owner: 10Jcf2000) [23:02:19] (03CR) 10Jdlrobson: "Ping. Is this still being worked on?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112675 (owner: 10Zfilipin) [23:06:16] (03CR) 10Jdlrobson: [C: 04-1] "Theo so sorry for the slow reply - this could be related to https://bugzilla.wikimedia.org/62010" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108300 (owner: 10Theopolisme) [23:10:46] (03CR) 10Jdlrobson: "Is this still being worked on? If I don't hear back from you I will abandon this patchset so someone else can take a look at it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104906 (owner: 10M4tx) [23:16:09] (03CR) 10Jdlrobson: [C: 032] QA: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116706 (owner: 10Vikassy) [23:16:40] kaldari: jgonera the QA tests are currently failing [23:16:50] (03Merged) 10jenkins-bot: QA: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116706 (owner: 10Vikassy) [23:16:57] Can you look at https://gerrit.wikimedia.org/r/116863 to fix them [23:16:58] (03PS1) 10Kaldari: Fixing height of tool link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116904 [23:17:28] Would be good to have some more confidence going into thursdays deploy :) [23:24:55] jdlrobson: Most of the step definitions that it's claiming are unused are actually used. [23:31:18] i've asked around to find someone else with access to cloudbees so we can get mobile-tech added for mobliefrontend test failure notifications [23:31:29] tfinc: interesting spdy performance breakdown charts: https://blog.twitter.com/2013/cocoaspdy-spdy-for-ios-os-x [23:31:29] but as far as i can tell chris and zeljko are the only ones [23:31:54] jgonera: jdlrobson kaldari any insight into the current test failures - particularly enwiki? i havent had a chance to dig yet [23:32:06] mhurd: nice. respond on the thread with it [23:32:16] awjr: jdlrobson: Can you look at https://gerrit.wikimedia.org/r/116863 to fix them [23:32:25] tfinc: ah. good idea [23:32:31] awjr: i'm doing some massive refactorings and i made some oversights [23:32:54] jdlrobson: ill look at that patchset - will that fix all the failures? [23:33:00] in theory yes [23:33:03] ok [23:33:08] awjr: where do you go to see test failures on en.wiki? [23:33:23] kaldari: until we get mail notifications again, you can look on cloudbees directly [23:33:25] link in one sec... [23:33:33] https://wmf.ci.cloudbees.com [23:33:41] thanks! [23:33:44] here's the enwiki-specific one: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.org-linux-firefox/ [23:47:41] jdlrobson: what does this do - specifically the -f stepdefs? bundle exec cucumber --dry-run -f stepdefs [23:55:14] (03CR) 10Awjrichards: [C: 04-1] "I haven't yet run the tests with this change (i'm in the midst of running all tests on current master), but in the meantime there are some" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116863 (owner: 10Jdlrobson)