[00:05:26] <jgonera>	 awjr, that's not the part that fixes it, it only shows steps that are not used anywhere AFAIK
[00:06:55] <grrrit-wm>	 (03CR) 10Jdlrobson: Hygiene: Lint the cucumber tests (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116863 (owner: 10Jdlrobson)
[00:15:34] <grrrit-wm>	 (03CR) 10Awjrichards: Hygiene: Lint the cucumber tests (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116863 (owner: 10Jdlrobson)
[00:16:05] <jdlrobson>	 awjr: i really don't understand the need to document an external script
[00:16:15] <jdlrobson>	 What if the arguments change?
[00:16:42] <jdlrobson>	 and the whole point of this script is to mask them from the inner workings of it
[00:16:48] <awjr>	 i don't think it's a need, it's a nicety
[00:17:11] <jdlrobson>	 and it looks like "I click the upload button and stage image file " needs to be written
[00:17:12] <awjr>	 when i see a script executing external applications, i like to know what they do
[00:17:15] <jdlrobson>	 as it is a single step
[00:17:33] <jdlrobson>	 i'll explore that
[00:18:38] <awjr>	 jdlrobson: at the very least, explain what your script does
[00:19:31] <jdlrobson>	 i thought with the Makefile and the message it prints to the console and the commit it was clear it lints - how would you suggest i make this clearer?
[00:22:58] <awjr>	 well, what are you trying to achieve with that script?
[00:23:22] <awjr>	 all it says is 'checking status of cucumber tests' - what does that mean?
[00:27:51] <jdlrobson>	 Would Linting cucumber tests make more sense?
[00:28:46] <awjr>	 i dont know, i still don't understand what you are trying to achieve
[00:28:56] <awjr>	 i assume it's valuable though :)
[00:33:35] <grrrit-wm>	 (03CR) 10Awjrichards: Hygiene: Lint the cucumber tests (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116863 (owner: 10Jdlrobson)
[00:33:56] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Wrap QA arguments in quotes to match other test coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116911 
[00:33:58] <grrrit-wm>	 (03PS1) 10Jdlrobson: Proper edit handling in case of redirects where page does not exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116912 
[00:37:20] <jdlrobson>	 So awjr in respect to I click the upload button and stage image file it's trickier than you think
[00:37:35] <jdlrobson>	 so Watir basically sends this all in a single event
[00:37:47] <jdlrobson>	 saying I click the button and select file foo.png is not true
[00:37:52] <jdlrobson>	 as it doesn't actually simulate that event
[00:38:08] <jdlrobson>	 as in no file selector dialogue ever appears
[00:38:16] <grrrit-wm>	 (03CR) 10Brion VIBBER: User is automatically logged in after account creation. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/116894 (owner: 10Mhurd)
[00:38:23] <jdlrobson>	 it's as if it's triggering an event on the element with a file attached
[00:38:42] <awjr>	 ergh
[00:38:45] <mhurd>	 brion: gah! forgot to localize!
[00:38:50] <brion>	 :D
[00:38:53] <mhurd>	 hehe
[00:39:02] <awjr>	 s/and/to
[00:39:04] <awjr>	 jdlrobson: ^
[00:39:53] <jdlrobson>	 awjr: what am i looking at?
[00:40:08] <awjr>	 in the step/feature
[00:40:12] <awjr>	 replace the word 'and' with 'to'
[00:40:19] <awjr>	 that way it's clear it's one single step
[00:40:24] <jdlrobson>	 okay yeh that was my original thought
[00:40:30] <jdlrobson>	 i thought you were asking for 2 distinct steps
[00:40:38] <awjr>	 either would suffice :)
[00:41:06] <awjr>	 but if you can't do 2 steps since it's procedurally treated as one, i think that's the sensible thing to do
[00:41:40] <awjr>	 im having problems getting slenium to properly log in to my instance
[00:41:42] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Lint the cucumber tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116863 
[00:41:44] <jdlrobson>	 k done
[00:41:46] <awjr>	 i have the env variables set
[00:41:59] <awjr>	 but login fails, resulting in tests failing
[00:42:41] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "Seems to work yay! Localization can be another commit. :)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/116894 (owner: 10Mhurd)
[00:45:32] <jdlrobson>	 awjr: have you got the account setup?
[00:45:41] <jdlrobson>	 where are you testing against?
[00:45:41] <awjr>	 yeah, i can log in with the same credentials manually
[00:45:45] <awjr>	 locally
[00:45:54] <jdlrobson>	 what happens in the simulation?
[00:46:16] <awjr>	 wtf
[00:46:18] <awjr>	 it just worked
[00:46:22] <awjr>	 i made 0 changes
[00:46:27] * awjr  shrugs

[00:46:28] <awjr>	 oh
[00:46:34] <awjr>	 i wonder if i was hitting the login attempt limit
[00:47:09] <awjr>	 it would be nice to have a script to set up everything you need for the cucumber tests
[00:47:34] <awjr>	 ensure the page is there, create the users… i think you should be able to do it all programatically
[01:00:27] <jdlrobson>	 awjr: this is what jgonera was working on
[01:00:38] <jdlrobson>	 (with the spike)
[01:00:51] <jdlrobson>	 and yes it would be nice - it's been a constant pain point since day 1 :)
[01:03:30] <mhurd>	 jgonera: kaity: heading to the bouldering place in dogpatch at 6 if you're interested
[01:04:07] <kaity>	 thanks mhurd!
[01:04:13] <kaity>	 can't today though
[01:05:21] <mhurd>	 kaity: no worry! prob heading there next tues too
[01:11:27] <grrrit-wm>	 (03PS3) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 
[01:11:43] <awjr>	 jeez it takes a long time to run all the browser tests
[01:12:10] <awjr>	 jdlrobson: tests with your latest patchset are running and i am seeing some failures
[01:12:17] <jdlrobson>	 awjr: what with?
[01:12:21] <jgonera>	 awjr, yes, we have means of doing it now, but we need to refactor the tests
[01:12:21] <awjr>	 are they all passing for you locally?
[01:12:42] <jdlrobson>	 have you looked at browser/README.wiki ?
[01:12:44] <awjr>	 jdlrobson: here's one:  Scenario: I cannot upload a lead photo to the Main Page                                      # features/pageactions_logged_in.feature:11
[01:12:44] <awjr>	     When I click on the upload icon                                                            # features/step_definitions/lead_photo_steps.rb:1
[01:12:44] <awjr>	     Then I see a toast with message "You do not have permission to add an image to this page." # features/step_definitions/common_article_steps.rb:77
[01:12:44] <awjr>	       expected "No image is needed on this page." to match "You do not have permission to add an image to this page." (RSpec::Expectations::ExpectationNotMetError)
[01:12:44] <awjr>	       ./features/step_definitions/common_article_steps.rb:78:in `/^I see a toast with message "(.*)"$/'
[01:12:45] <awjr>	       features/pageactions_logged_in.feature:13:in `Then I see a toast with message "You do not have permission to add an image to this page."'
[01:13:04] <awjr>	 yes
[01:13:13] <jdlrobson>	 awjr: yeh so those don't match README from sound of it
[01:13:13] <awjr>	 although ti is possible i missed something, there is a lot in there
[01:13:24] <awjr>	 jdlrobson: Scenario: Receive notification message - Edit Icon
[01:13:49] <jdlrobson>	 Main Page should be protected from whoever MEDIAWIKI_USER is
[01:14:59] <awjr>	 there are a bunch more but i should wait til the tests finish, it will be easier
[01:16:02] <jdlrobson>	 but yeh there are loads of caveats with this - if you log in as Selenium user on beta labs you'll see how the server version differs from locally
[01:16:17] <awjr>	 yeah
[01:16:32] <awjr>	 hmm all the ve-related tests fail…
[01:16:41] <jdlrobson>	 awjr: you probably haven't got VE setup
[01:16:43] <awjr>	 VE/core are up to date and parsoid is running
[01:16:45] <awjr>	 i do
[01:16:55] <awjr>	 parsoid appears to be working
[01:16:58] <awjr>	 but for some reason VE isnt
[01:17:11] <awjr>	 the footer feature tests failed
[01:17:11] <jdlrobson>	 awjr: that patch set doesn't touch VE as far as i'm aware..
[01:17:13] <awjr>	 keeping failed
[01:17:19] <awjr>	 pageactions failed
[01:17:42] <awjr>	 jdlrobson: you are correct
[01:17:42] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Lint the cucumber tests (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116863 (owner: 10Jdlrobson)
[01:17:58] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Lint the cucumber tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116863 
[01:18:18] <jdlrobson>	 the footer tests are being removed
[01:18:35] <jdlrobson>	 see https://gerrit.wikimedia.org/r/#/c/116899/ later commit
[01:18:57] <jdlrobson>	 i've spent last day of experimentation time sorting them out as they were just way too messed up
[01:20:16] <jdlrobson>	 anyway awjr i urge you to be brave and merge - you will see green again :)
[01:20:19] <jdlrobson>	 ;-)
[01:20:33] <awjr>	 im just reconciling some things jdlrobson
[01:20:42] <awjr>	 jdlrobson: do all the tests pass for you locally?
[01:20:54] <jdlrobson>	 awjr: the ones that previously passed still pass for me yes
[01:21:02] <jdlrobson>	 it's a loaded question ;-)
[01:21:09] <awjr>	 and the ones that previously failed?
[01:21:10] <awjr>	 :p
[01:21:20] <awjr>	 i am concerned about the page actions test failing for me
[01:21:32] <jdlrobson>	 i can take a screenshot of those passing if that helps
[01:21:41] <awjr>	 no, i trust you
[01:21:48] <awjr>	 i just want to know why they're failing for me
[01:22:28] <jdlrobson>	 it sounds like permissioning prioblems
[01:22:37] <jdlrobson>	 if you look at your errors they complain the message is different
[01:22:52] <jdlrobson>	 No image is needed is a different error from You do not have permission to add an image to this page
[01:23:11] <jdlrobson>	 If you protect the page involved from your MEDIAWIKI USER they should pass
[01:23:11] <kaldari>	 jdlrobson, awjr: I get some message match failures because my wiki isn't named "Wikipedia", in case that helps.
[01:23:28] <jdlrobson>	 kaldari: yeh i added a note to the README in this very patchset
[01:23:39] <jdlrobson>	 https://gerrit.wikimedia.org/r/#/c/116863/4/tests/browser/README.mediawiki
[01:23:39] <awjr>	 yeah i took care of that one already
[01:24:43] <jdlrobson>	 awjr: http://imgur.com/ywNft14
[01:26:02] <grrrit-wm>	 (03PS1) 10Kaldari: Hygiene: Better set-up instructions for selenium tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116916 
[01:26:33] <jdlrobson>	 anyway i gotta go..
[01:28:12] <grrrit-wm>	 (03CR) 10Awjrichards: [C: 032] Hygiene: Lint the cucumber tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116863 (owner: 10Jdlrobson)
[01:28:16] <jdlrobson>	 \o/
[01:28:21] <grrrit-wm>	 (03Abandoned) 10Kaldari: Hygiene: Better set-up instructions for selenium tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116916 (owner: 10Kaldari)
[01:28:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: Lint the cucumber tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116863 (owner: 10Jdlrobson)
[01:35:06] <grrrit-wm>	 (03PS1) 10Kaldari: Hygiene: More selenium set-up instructions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116917 
[01:35:19] <kaldari>	 awjr: also https://gerrit.wikimedia.org/r/#/c/116917/
[01:36:18] <grrrit-wm>	 (03CR) 10Awjrichards: [C: 032] Hygiene: More selenium set-up instructions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116917 (owner: 10Kaldari)
[01:36:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Hygiene: More selenium set-up instructions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116917 (owner: 10Kaldari)
[01:54:34] <kaldari>	 awjr: Do the keepgoing.feature tests work for you?
[01:55:34] <kaldari>	 They fail for me due to having captchas turned on to pass the other tests :P
[01:56:44] <kaldari>	 jgonera: Do you have any idea how to solve a captcha in a selenium test??
[01:56:54] <jgonera>	 kaldari, disable it
[01:57:01] <awjr>	 lol
[01:57:18] <awjr>	 kaldari: the keepgoing tests are WIP
[01:57:25] <awjr>	 they are, i think, expected to fail
[01:57:29] <awjr>	 you can run selenium to ignore WIP tests
[01:58:58] <awjr>	 with the -w flag
[01:59:16] <awjr>	 htey will still show up as failures, although with a friendly message saying they were expected to fail
[01:59:34] <awjr>	 i gotta jet, hasta mañana
[02:00:10] <kaldari>	 awjr: yeah, that makes sense
[08:33:01] <grrrit-wm>	 (03CR) 10Zfilipin: "Apologies for being slow, I was on vacation last week, still catching up. I am still working on this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112675 (owner: 10Zfilipin)
[10:50:22] <grrrit-wm>	 (03CR) 10Zfilipin: [C: 032] Updated Ruby version from 2.1.0 to 2.1.1 [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/116716 (owner: 10Vikassy)
[10:50:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Updated Ruby version from 2.1.0 to 2.1.1 [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/116716 (owner: 10Vikassy)
[17:15:38] <aharoni>	 YuviPanda: "Send Yuvi a crash report" will sound pretty cool in Hebrew.
[17:15:43] <YuviPanda>	 aharoni: :D
[17:43:26] <aharoni>	 YuviPanda: This sounds like an old Chinese proverb:
[17:43:29] <aharoni>	 During development this enables code execution of W0 things.
[17:43:40] <aharoni>	 Oh, actually,
[17:43:43] <aharoni>	 this is my font.
[17:43:51] <aharoni>	 It makes it look like "Wo".
[17:44:04] <aharoni>	 "Wo things" is mysterious, "W0" is fairly clear.
[17:45:04] <aharoni>	 YuviPanda: ... and the app is translated to Hebrew.
[17:45:10] <aharoni>	 (Android.)
[17:58:50] <jdlrobson>	 awjr: if you're not too sick can you run bingle?
[18:01:06] <MaxSem>	 standup anyone?
[18:15:33] <grrrit-wm>	 (03CR) 10Yurik: [C: 032] "won't deploy this manually - no hurry, will auto-deploy with chu chu train" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/116189 (owner: 10Dr0ptp4kt)
[18:15:36] <grrrit-wm>	 (03Merged) 10jenkins-bot: Only send zero-rated message for app if images also zero-rated. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/116189 (owner: 10Dr0ptp4kt)
[18:27:37] <grrrit-wm>	 (03PS1) 10Jdlrobson: Hygiene: Remove unused function in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117007 
[18:39:43] <grrrit-wm>	 (03PS1) 10Jdlrobson: Add password reset link from desktop on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 
[18:47:51] <MaxSem>	 YuviPanda, yt?
[18:48:33] <brion>	 yuvi may still be obtaining foods
[18:48:51] <MaxSem>	 yep, checking if he's back
[18:56:54] <grrrit-wm>	 (03PS1) 10Jdlrobson: i18n: Tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117012 
[19:00:17] <grrrit-wm>	 (03PS1) 10Jdlrobson: Update attribution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117013 
[19:00:43] <grrrit-wm>	 (03PS2) 10Jdlrobson: Update attribution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117013 
[19:01:32] <brion>	 YuviPanda: poke poke
[19:01:39] <YuviPanda>	 MaxSem: in an interview
[19:01:42] <YuviPanda>	 brion: in an interview now
[19:01:43] * brion  assumes YuviPanda was run over by a motor rickshaw

[19:01:46] <brion>	 ah ok later :D
[19:02:00] <tfinc>	 jdlrobson: jgonera were in r31
[19:48:20] <tfinc>	 kaldari: https://www.mediawiki.org/wiki/Talk:Wikimedia_Engineering/Maps_%26_Geo_Team
[20:00:38] <YuviPanda>	 brion: MaxSem wassup?
[20:03:14] <MaxSem>	 YuviPanda, wanted to discuss https://gerrit.wikimedia.org/r/#/c/116872/ to understand the situation better
[20:07:08] <YuviPanda>	 MaxSem: tell me
[20:09:06] <jgonera>	 http://hatjitsu.wmflabs.org/80415
[20:11:02] <YuviPanda>	 MaxSem: lost connection :( did i miss anything
[20:13:35] <MaxSem>	 YuviPanda, no. noticed Brad left another comment on the bug
[20:19:29] <YuviPanda>	 MaxSem: ah, ok
[20:19:37] <YuviPanda>	 MaxSem: yeah, I think it's a fair bit of work from what anomie said
[20:20:50] * YuviPanda  pokes brion

[20:28:30] <YuviPanda>	 hi violetto
[20:28:36] <violetto>	 YuviPanda!
[20:28:51] <YuviPanda>	 violetto!
[20:29:33] <violetto>	 YuviPanda: sup traveller
[20:30:06] <YuviPanda>	 violetto: know if anything changed with the canned edits stuff?
[20:31:14] <violetto>	 YuviPanda: apparently we're just doing free-form now
[20:31:26] <violetto>	 not sure about the full story
[20:33:57] <YuviPanda>	 violetto: ok
[20:34:06] <YuviPanda>	 violetto: can you ask her to send out an email?
[20:40:04] <jdlrobson>	 jgonera: are we going to lightning deploy the broken upload progress bar. I'm seeing it on mediawiki.org and it's a pain
[20:40:27] <jgonera>	 jdlrobson, sure, have you got someone to do it or should I do it?
[20:40:43] <jdlrobson>	 i'm just wondering if we wanted to or not.
[20:40:54] <brion>	 there, got my ssl cert updated on brionv.com :D
[20:40:56] <jgonera>	 sorry, I read "we are"
[20:40:58] <brion>	 YuviPanda: whassup
[20:41:04] <YuviPanda>	 brion: you pinged?
[20:41:06] <jgonera>	 jdlrobson, yes, I think we should
[20:41:23] <brion>	 YuviPanda: need some review at some point on a couple bits
[20:41:30] <brion>	 if you don't have time today i'll poke you tomorrow :D
[20:41:54] <brion>	 https://gerrit.wikimedia.org/r/#/c/116867/ for orientation change & https://gerrit.wikimedia.org/r/#/c/116170/ for captcha result format change
[20:41:58] <jgonera>	 MaxSem, how do we schedule a lightning deployment?
[20:42:16] <MaxSem>	 jgonera, by poking greg-g
[20:45:17] <YuviPanda>	 brion: ah, looking
[20:45:37] <YuviPanda>	 brion: the captcha one, I'd want someone else to take a look. legoktm or hoo or csteipp maybe? It's security related and I don't want to touch it :P
[20:45:39] <YuviPanda>	 brion: looking at orientation one
[20:45:52] <brion>	 heh ok
[20:47:02] <YuviPanda>	 brion: can you poke those people, or maybe MaxSem to take a look?
[20:47:18] * brion  adds some reviewers

[20:47:40] <YuviPanda>	 brion: poke them on IRC too, that helps
[20:55:01] <violetto>	 vbamba can you send out an email about the edit summary outcome, what we're doing, not doing, etc? YuviPanda's curious too.
[20:55:10] <jdlrobson>	 haha tests exploded
[20:57:33] <jdlrobson>	 kaldari / jgonera can you take a look at the remaining QA hygiene patches I have - it will make my job of fixing the QA tests a lot easier
[20:57:43] <jgonera>	 jdlrobson, we're in a meeting
[20:57:54] <jdlrobson>	 well kaldari then :)
[20:59:15] <dr0ptp4kt>	 YuviPanda and mhurd i can add your ips for w0 testing now. gotta head into a meeting, but wanted to let you know. i just tested on both android and ios and it's looking decent
[21:03:06] <YuviPanda>	 dr0ptp4kt: sweet! Don't have a stable IP yet, will figure it out
[21:04:49] <dr0ptp4kt>	 no problem, not a huge deal if it's not super stable. if it's stable for long enough that will be good enough. alright, gotta go. ttyl
[21:06:43] <YuviPanda>	 dr0ptp4kt: ttyl! take care!
[21:09:26] <grrrit-wm>	 (03PS5) 10Jdlrobson: Hygiene: Group together main menu navigation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 
[21:11:37] <dr0ptp4kt>	 yurik, my connection is shaky. just in case...
[21:12:21] <yurik>	 dr0ptp4kt, don't shake it
[21:14:05] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Kill "I go to the" common step in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116871 
[21:20:07] <kenanwang>	 tfinc: hey can you help me with something for metrics tomorrow? How to present with a tablet tomorrow?
[21:20:18] <tfinc>	 kenanwang: what would you like to do ?
[21:20:27] <tfinc>	 tablet hooked up to hangout ?
[21:26:06] <kenanwang>	 Can I screenshare on iPad or a nexus tablet?
[21:26:45] <kenanwang>	 In the past I've use reflector to share my screen via airplay
[21:26:54] <kenanwang>	 tfinc: ^
[21:27:19] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 04-1] "Cucumber is completely agnostic as to whether a step is preceded by Given, When or Then. See https://github.com/cucumber/cucumber/wiki/Gi" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116871 (owner: 10Jdlrobson)
[21:27:20] <tfinc>	 brion: what works best for tablets these days ?
[21:27:35] <tfinc>	 brion: do we have an hdmi connection that kenanwang could use ?
[21:27:55] <brion>	 kenanwang: easiest thing is to AirPlay an iPad to an AppleTV connected to the TV
[21:28:03] <brion>	 and let the hangout camera just record the screen
[21:28:12] <brion>	 second-easiest thing is to hook it up by direct hdmi, i'll get a cable of ryou
[21:28:15] <YuviPanda>	 tfinc: kenanwang for nexus tablet you can also pre-record high quality video from the tablet itself.
[21:28:25] <YuviPanda>	 if it doesn't need to be live
[21:28:29] <brion>	 yes if you're brave :)
[21:28:34] <YuviPanda>	 heh :)
[21:28:39] <YuviPanda>	 brion: there's also https://code.google.com/p/android-screen-monitor/ which I still use
[21:28:47] <brion>	 yeah but hella slow for tablet
[21:28:50] <tfinc>	 YuviPanda: how is your hand feeling today?
[21:29:04] <YuviPanda>	 tfinc: not tremory :) soaked it in hot water for a bit before going to sleep.
[21:29:10] <tfinc>	 take it easy
[21:29:12] <YuviPanda>	 tfinc: have an appointment on monday
[21:29:15] <YuviPanda>	 tfinc: yeah :)
[21:29:42] * YuviPanda  pokes vbamba

[21:30:11] <brion>	 kenanwang: i have a bag of HDMI adapters for phones/tablets
[21:30:23] <brion>	 it includes the necessary adapters for iPad and nexus 10
[21:30:28] <brion>	 feel free to borrow it :D
[21:30:37] <YuviPanda>	 brion: I just looked at https://gerrit.wikimedia.org/r/#/c/116867/
[21:30:47] <YuviPanda>	 brion: that'll cause other problems no? the webview isn't the only thing there...
[21:30:49] <kenanwang>	 Ok Brion I'll poke you later
[21:31:06] <kenanwang>	 YuviPanda: take care of that hand!
[21:31:14] <YuviPanda>	 brion: also did you try the saveState thing? since that will work for both rotates adn kills
[21:31:26] <YuviPanda>	 kenanwang: I am! :) Thank you :)
[21:32:17] <brion>	 YuviPanda: doesn't save content state!
[21:32:25] <brion>	 it shows the base .html file only, none of the injected content
[21:33:17] <YuviPanda>	 brion: bah, that's useless :|
[21:33:39] <brion>	 yeah srsly
[21:34:11] <grrrit-wm>	 (03PS1) 10Mhurd: Fix for save no longer working if initial save attempt failed. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117089 
[21:34:17] <mhurd>	 brion: boop ^
[21:34:24] <brion>	 \o/
[21:34:58] <YuviPanda>	 brion: I wonder what the other consequences will be.
[21:35:08] <YuviPanda>	 brion: I'll look into it and read up some more before doing this?
[21:35:36] <brion>	 YuviPanda: well we don't vary our layout based on the size/orientation
[21:35:42] <brion>	 so i think it's fairly safe
[21:35:46] <YuviPanda>	 brion: true, so it seems ok.
[21:35:48] <brion>	 but def check into it
[21:35:51] <YuviPanda>	 still, I want to be absolutely sure.
[21:36:00] <YuviPanda>	 that there won't be weird side effects with things like leaked whatevers
[21:36:06] <brion>	 heh yeah
[21:36:18] <YuviPanda>	 violetto: I'm going to sleep now, but try to poke vbamba in person :P
[21:42:04] <violetto>	 vbamba!
[21:42:06] <violetto>	 ^
[21:42:11] <violetto>	 YuviPanda: ok
[21:42:14] <violetto>	 gnite!
[21:42:32] <violetto>	 vbamba: im in meetings all day might not be able to catch ya
[21:47:14] <vbamba>	 violetto: YuviPanda sending out email briefly
[21:47:46] <YuviPanda>	 vbamba: sweet
[21:48:50] <vbamba>	 kaldari: Did you move the fonts audit table?
[21:49:22] <vbamba>	 I cant find it anymore - can you please link me? Im trying to tie all the loose ends for the typography FAQ.
[21:58:09] <mhurd>	 vbamba: on the "latest design assets" board i created a new "wikitext editing preview" (https://trello.com/c/zHmmH2xT/74-design) list and attached your mockup from yesterday - i also cropped the edit summary screens out from the "wikitext editing" (https://trello.com/c/dSXteqIw/2-design) cover image since those parts are part of the preview screen. does that sound ok?
[21:59:27] <jgonera>	 greg-g, so what should I do if we want a lightning deployment?
[22:07:42] <mhurd>	 tfinc: hey in trello near top of page there's a "burndown chart" link that will enable some agile/scrum stuff... have you played with this? 
[22:07:54] <mhurd>	 i just clicked it for first time
[22:08:03] <tfinc>	 mhurd: its never worked right so i turned it off
[22:08:37] <mhurd>	 tfinc: i see :(
[22:09:04] <vbamba>	 mhurd:  good for now. Posting an update shortly.
[22:09:43] <mhurd>	 vbamba: cool thanks!
[22:13:39] <grrrit-wm>	 (03CR) 10Mhurd: "Added comments pin-pointing the lines fixing the core issue." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117089 (owner: 10Mhurd)
[22:43:04] <jdlrobson>	 chrismcmahon: little confused by your -1
[22:43:43] <jdlrobson>	 i'm merging lots of rules that mean the same thing
[22:44:10] <jdlrobson>	 and switching to use Given statements for existing tests, as the When implies the user takes an action which they do not
[22:44:18] <chrismcmahon>	 jdlrobson:  you said "It looks like a "When" is being used when it should be a  "Given"".  I just wanted you to make sure to read the docs and understand that Cucumber doesn't care which one of Given/When/Then precedes a statement
[22:44:35] <jdlrobson>	 i meant in the context of describing a test
[22:44:41] <chrismcmahon>	 jdlrobson: nothing wrong with what you did, but I it had nothing to do with whether the test passed or failed
[22:44:49] <jdlrobson>	 As i understood it I should use When, when the user takes an account e.g. clicks a button
[22:45:02] <jdlrobson>	 since all these tests use it in a statement that the user happens to be on the page it feels more like a Given
[22:45:12] <jdlrobson>	 as the user is not searching and going to the page or clicking a link
[22:47:08] <chrismcmahon>	 jdlrobson:  yep, I'll take back my -1, I was just concerned that you might thing whether a step was preceeded by Given When or Then would have some effect on whether the test passes or fails
[22:47:15] <chrismcmahon>	 think, even
[22:47:43] <jdlrobson>	 ok cool - just a misunderstanding then :)
[22:48:05] <chrismcmahon>	 or an And for that matter
[22:53:19] <chrismcmahon>	 seems like something jgonera and/or awjr should chime in on, since it is a style thing, a global change to how the Mobile team envisions the flow of these tests. 
[22:53:39] <chrismcmahon>	 link: https://gerrit.wikimedia.org/r/#/c/116871/
[22:55:48] <grrrit-wm>	 (03PS2) 10Jdlrobson: Hygiene: Kill pointless external link test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116901 
[23:03:13] <grrrit-wm>	 (03CR) 10Cmcmahon: "taking away my -1 but suggesting that Mobile team members review and merge for code and style reasons" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116871 (owner: 10Jdlrobson)
[23:03:39] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Kill "I go to the" common step in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116871 
[23:03:41] <grrrit-wm>	 (03PS3) 10Jdlrobson: Hygiene: Kill pointless external link test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116901 
[23:03:43] <grrrit-wm>	 (03PS2) 10Jdlrobson: QA: Kill Image resolves test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116898 
[23:08:26] <grrrit-wm>	 (03PS6) 10Jdlrobson: Hygiene: Group together main menu navigation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 
[23:09:30] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "need to rebase. I'm waiting for some CR before doing this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116899 (owner: 10Jdlrobson)
[23:10:37] <grrrit-wm>	 (03PS2) 10Jdlrobson: Add password reset link from desktop on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 
[23:23:45] <tfinc>	 MaxSem: does the GeoData service have any other clients besides us with Mobile Web ?
[23:23:48] <tfinc>	 specifically external 
[23:25:55] <MaxSem>	 tfinc, hard to tell. after an API goes live everyone can start using it for their own needs
[23:26:10] <tfinc>	 MaxSem: what do we see in the way of client IP's ?
[23:26:29] <tfinc>	 MaxSem: DarTar was curious to know if we have any external clients 
[23:26:35] <grrrit-wm>	 (03PS4) 10Jdlrobson: Hygiene: Consolidate steps for visiting pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116871 
[23:27:01] <violetto>	 mhurd: hey remember the top navigation we talked about regarding icon sizes, colors, etc. Just wondering if you're planing to get them done before the end of the sprint, or in the navigation sprint?
[23:27:27] <MaxSem>	 since nearby also results in requests from various IPs, you can't tell them apart. also, api.log does not have IPs
[23:27:42] <DarTar>	 MaxSem, tfinc - and I imagine we don't have anything in place like an authenticated application key, right?
[23:27:44] <mhurd>	 violetto: was aiming to hack at it a bit later this week
[23:28:00] <DarTar>	 (or plans to introduce one)
[23:28:04] <MaxSem>	 no
[23:28:05] <mhurd>	 violetto: so hopefully this sprint :)
[23:28:08] <tfinc>	 DarTar: correct. the MediaWiki api doesn't have keys
[23:28:17] <tfinc>	 i've lamented that ever since i saw it
[23:28:22] <MaxSem>	 our API is free for all to use
[23:28:22] <DarTar>	 agreed
[23:28:26] <violetto>	 mhurd: okay, thanks!
[23:28:47] <DarTar>	 MaxSem: yes, but it makes our understanding of who uses it very limited
[23:29:12] <MaxSem>	 I don't think that API keys help our goal of making reuse as simple as possible
[23:29:39] <DarTar>	 they definitely make the job of filtering out bogus traffic nearly impossible
[23:29:47] <DarTar>	 but I appreciate it's a complex problem
[23:30:35] <DarTar>	 see, we can't even showcase who are the best (institutional?) projects reusing our data/APIs because we have no clue about who they are
[23:31:06] <DarTar>	 that would definitely help towards the goal of supporting reuse
[23:34:41] <grrrit-wm>	 (03PS1) 10Jdlrobson: QA: Fix breaking tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117109 
[23:36:30] <DarTar>	 MaxSem, tfinc: the #1 answer people gave in a consultation we ran in 2011 about Wikimedia APIs/open data sources to the question: "Why are you not using data from X or Y" is "I didn't have a clue this data existed". I would argue that showcasing who is doing cool/important stuff with our APIs is as important towards promoting its use as making it easy to access.
[23:40:31] <tfinc>	 DarTar: I agree. and i'd take it one step forward that use of the API through these tools should affect its evolution 
[23:41:33] <tfinc>	 making it evolve relative to product needs
[23:42:11] <DarTar>	 tfinc: absolutely
[23:42:17] <MaxSem>	 hmm, from non-scientifical glaring at logs grepped, nearby is not even the primary  user
[23:42:31] <DarTar>	 I'm really happy we're having these discussions :)
[23:42:42] <tfinc>	 absolutely :)
[23:42:47] <tfinc>	 MaxSem: who do you see ?
[23:43:07] <MaxSem>	 AWS:)
[23:43:31] <tfinc>	 that's going to make it even hard to ID then
[23:43:40] <tfinc>	 even more reason to have API keys 
[23:47:26] <DarTar>	 I'm really interested in unpacking the implications that application keys are conflicting with freedom of use (not now, but I am making a mental note to self about this)
[23:50:06] <tfinc>	 DarTar: i wonder if it stems from the idea that you don't need a wikipedia account to read/write, why would you need an equivalent for the api? <-- that's my guess. i like api keys and support adding them so i can only speculate 
[23:50:16] <tfinc>	 MaxSem: --^
[23:50:36] <MaxSem>	 yes
[23:50:56] <DarTar>	 I can think of cases of popular open APIs getting a lot of traction after publishing numbers of unique applications they support
[23:51:27] <DarTar>	 we need to avoid the fallacy that an API key is a first step towards a restriction of use
[23:52:15] <DarTar>	 moizsyed: just gave me a pointer to a timeline of changes in the Twitter API showing that the introduction of mandatory keys was functional to monetization
[23:52:41] <DarTar>	 so, yeah: we need to take that argument seriously
[23:52:57] <MaxSem>	 feel free to start a RFC
[23:53:00] <moizsyed>	 http://computationalculture.net/article/objects-of-intense-feeling-the-case-of-the-twitter-api  MaxSem: you will like this especially
[23:54:10] <MaxSem>	 moizsyed, haven't seen a single mention of API keys
[23:54:12] <DarTar>	 MaxSem: an RFC is definitely the best way to start the discussion ;)
[23:55:52] <moizsyed>	 MaxSem: well, its more about API design and enforcing limitations and how it can lead to unnecessary control 
[23:56:33] <DarTar>	 good food for thought for the data/developer hub session we're hosting in Zurich
[23:56:47] <MaxSem>	 after finding IPs in api.log and sorting on them, I see a few  major users
[23:57:40] <MaxSem>	 one of them responsible for ~17% of all searches
[23:58:28] <DarTar>	 qchris recently did some analysis on the breakdown of API requests