[00:00:04] but wearing the analytics hat, not knowing whether an API edit is a bot edit or an edit from a gadget/power tool or whether an API request should be counted as a pageview makes my life really hard [00:00:12] grep geosearch api.log | grep -oP '(?<=GET ).+?(?=T)' | sort | uniq -c | sort -rn [00:03:56] DarTar: do we have any numbers on tablet traffic/ [00:03:57] ? [00:04:18] kenanwang, http://stats.wikimedia.org/wikimedia/squids/SquidReportClients.htm [00:04:34] (03CR) 10Jdlrobson: [C: 032] Fixing height of tool link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116904 (owner: 10Kaldari) [00:05:14] (03Merged) 10jenkins-bot: Fixing height of tool link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116904 (owner: 10Kaldari) [00:13:15] (03CR) 10JGonera: [C: 04-1] Update last modified time when a template or file changes in MFResourceLoaderModule (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 (owner: 10Jdlrobson) [00:17:04] jdlrobson, what about my other comments in https://gerrit.wikimedia.org/r/#/c/116035/3 ? [00:17:18] (not inline) [00:18:03] yeh i couldn't replicate. I'll take another look in a minute [00:18:13] hm [00:31:36] (03PS1) 10Jdlrobson: Fix nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117126 [00:35:45] (03PS1) 10Dr0ptp4kt: Set searchbar (localized) "Search Wikipedia" if W0 transitions to off. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117127 [00:36:50] brion or mhurd, could i get a quick review and +2 on ^ hoping to get it done before any code drift. pretty simple [00:37:02] moment [00:38:28] dr0ptp4kt: couple issues - adding comments... [00:38:49] oh noes [00:43:53] mhurd: did you save the comments? [00:44:04] just making sure, it's easy to forget to actually post the inline ones :D [00:44:36] brion: ah - good point! couple note then i'll post :) [00:44:41] :D [00:44:44] *more notes* [00:45:47] thanks guys. if i had a nickel for every time i thought i posted comments. [00:46:11] or added files! [00:49:26] (03CR) 10Mhurd: "Added a couple comments." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117127 (owner: 10Dr0ptp4kt) [00:49:35] dr0ptp4kt: brion ^ [00:50:26] (03PS2) 10Jdlrobson: Fix nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117126 [00:54:22] dr0ptp4kt: oh, in navcontroller.m the search field is know as "self.textField" [00:54:51] dr0ptp4kt: if that helps :) [00:59:33] yes, yes, of course [00:59:35] mhurd [01:02:11] mhurd, of what you recall of the code, is there any risk the text would be set to "Search Wikipedia" when we really want it to say "Search Wikipedia Zero"? [01:02:25] that is, if we put in the default: case of setNavBarMode [01:09:54] dr0ptp4kt: hmm... i guess you could have setNavBarMode check the zero flag and set the placeholder text accordingly. then wherever you want to update the search placeholder to reflect the zero state you would change the zero state then setNavBarMode to NAVBAR_MODE_SEARCH to make it update. does that make sense? [01:10:38] (03PS4) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [01:11:17] (03CR) 10jenkins-bot: [V: 04-1] Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 (owner: 10Jdlrobson) [01:11:58] (03PS5) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [01:12:08] mhurd, sorry i was being lazy. i just checked, and sure enough putting the text in there without a conditional check would result in the search string saying "Search Wikipedia" instead of "Search Wikipedia Zero" say if a user went to login after W0 went on, and then logged in or clicked the 'X'. [01:12:40] mhurd, to answer your question... [01:12:45] dr0ptp4kt: one thing to keep in mind is that the nav bar's search box may be used for other things which will have different placeholder text in the future - that's why i was thinking NavController's the place to put it [01:12:54] oh [01:13:13] i would know that if i wasn't sickboy [01:13:23] (not trainspotting, just a cold) [01:14:27] the way it's structured now, we could use the nav text field in a different manner for different modes much in the same way the nav buttons can be used in different ways by diff modes [01:24:55] mhurd, is there any risk there that we end up overriding the actually intended navBarMode? or is that field guaranteed to be safe enough that we can overwrite the text? got a minute to talk on video? [01:27:52] i was thinking about the places where navBarMode actually isn't in search mode, yet the w0 state changes [01:27:58] (03CR) 10Kaldari: [C: 032] QA: Kill Image resolves test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116898 (owner: 10Jdlrobson) [01:29:13] (03Merged) 10jenkins-bot: QA: Kill Image resolves test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116898 (owner: 10Jdlrobson) [01:29:55] account creation, login, preview-n-save, sectioneditor. it's fine if one of those is already in viewWillDisappear, but it seems risky if whatever it is that happens in those isn't invoking viewWillDisappear. do we run any risk of squashing the ui when the user is in those modes? [01:30:03] not sure if that makes sense [01:30:19] i'm okay however we do it, just trying to stave off unintended consequences [01:30:27] greg-g, are you there? [01:30:59] MaxSem, how do you usually contact greg-g? e-mail? [01:31:31] mhurd ^^^ [01:32:05] (03CR) 10Kaldari: [C: 032] Hygiene: Kill pointless external link test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116901 (owner: 10Jdlrobson) [01:33:06] (03Merged) 10jenkins-bot: Hygiene: Kill pointless external link test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116901 (owner: 10Jdlrobson) [01:34:11] mhurd, you wanna just cover this tomorrow morning when we're both fresh? :) [01:34:50] i'm guessing i'll still need to work from home to avoid infecting people, but no matter [01:37:57] (03CR) 10Kaldari: [C: 04-1] Hygiene: Consolidate steps for visiting pages (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116871 (owner: 10Jdlrobson) [01:38:30] dr0ptp4kt: that sounds good! sorry was chatting :) [01:38:56] mhurd, no problem. in any matter, there's a solution, we'll figure it out tomorrow. you have a good night. you going climbing? [01:41:19] (03CR) 10Dr0ptp4kt: "Adding comments so we can remember for face-to-face." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117127 (owner: 10Dr0ptp4kt) [01:42:13] mhurd, alright, will talk with you later. have a good night, and thanks for reviewing! [01:42:20] s/later/tomorrow/ [01:48:01] vbamba: https://www.mediawiki.org/wiki/Typography_refresh/Font_choice#Body_font_evaluation [01:52:17] thank you! [07:34:11] Hey YuviPanda! [07:34:14] are you there? [08:05:27] poke YuviPanda [08:06:20] ok, going to bed, will try and catch you in the morning. Trello cards are updated with Edit Summary. [10:13:24] (03CR) 10Yuvipanda: [C: 032 V: 032] "I'm a bit reluctant, since this will not surface many other issues that might pop up from not handling the activity lifecycle properly, bu" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/116867 (owner: 10Brion VIBBER) [16:53:58] (03PS2) 10Zfilipin: Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/114932 [16:54:00] (03CR) 10Cmcmahon: [C: 032] Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/114932 (owner: 10Zfilipin) [16:57:20] (03CR) 10Zfilipin: [C: 032] Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/114932 (owner: 10Zfilipin) [16:59:11] (03Merged) 10jenkins-bot: Cloudbees Jenkins jobs are now created using Jenkins Job Builder [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/114932 (owner: 10Zfilipin) [17:26:10] jdlrobson: poke [17:26:15] * jdlrobson waves [17:26:29] wonder if you like to look at https://gerrit.wikimedia.org/r/#/c/101895/ again ? [17:26:52] i need to fix docs/hooks.txt [17:28:26] I can look at it but it's less of a problem now that mobile doesn't render any portal code [17:29:03] LGTM so if you fix up the other comments i'll test and +1/2 [17:29:40] looks like daniel approves [17:29:41] (03CR) 10Swalling: [C: 04-1] "Tested locally and looks about right: http://i.imgur.com/m3PcaMA.png" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 (owner: 10Jdlrobson) [17:29:53] if you have any follow up suggestions, i can make another patch [17:30:40] no, he did +2 verify [17:31:22] StevenW: you there? is "Your username will be adjusted to "Thisisuser" due to technical restrictions." your doing? [17:31:24] it's broken mobile [17:31:38] Not my doing. I -1'd it for UX reasons [17:31:52] Tyler Romeo +2'd after MatmaRex et al +1'd [17:32:20] jdlrobson: feel free to revert it. Jared and I hate that patch and I did not remove my -1. Erik also proposed an alternative suggestion which they ignored. [17:32:21] jdlrobson: you looking at the MF test failures now? [17:32:30] chrismcmahon: yws [17:32:42] chrismcmahon StevenW all errors seem to be suppressed because of it [17:32:57] you mean errors displayed to users? Like CAPTCHA failure etc> [17:32:59] thought so. that "Thisisuser" looked bizarre [17:34:22] StevenW: like the red error boxes on wrong input for login: missing field, wrong password, all that is gone for mf [17:34:32] StevenW: exactly [17:34:36] no captcha failures [17:34:59] jdlrobson: that's unacceptable [17:35:05] StevenW: what's the patch? [17:35:41] jdlrobson: https://gerrit.wikimedia.org/r/#/c/114400/ [17:36:18] They said API behavior should have remained unchanged, so if MFE login/signup is using the API it shouldn't have impacted it? [17:36:39] StevenW: i'm a little confused why it is suppressing our errors [17:36:50] It shouldn't be. [17:56:51] jdlrobson: create an account with a lower-case username on the main site to see what's going on: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:UserLogin&returnto=Main+Page&type=signup [17:58:24] chrismcmahon: yeh https://gerrit.wikimedia.org/r/117234 [17:58:37] jdlrobson: I think we have a case to revert that change based on unforeseen side-effects to MF [17:58:38] chrismcmahon: i know exactly what's going on but most mobile browsers will trigger this [17:58:51] chrismcmahon: yup that's what that patch does :) [17:59:01] ok good you reverted [17:59:07] probably should file a bug for it [18:02:03] brb [18:03:06] YuviPanda: brion : waiting on you guys on the hangout [18:03:24] tfinc: yeah, attempting to join [18:13:56] aaargh poor users https://test.wikipedia.org/w/index.php?title=Special:Captcha/image&wpCaptchaId=1136532798 [18:15:18] hi vbamba! [18:19:51] jdlrobson: https://gerrit.wikimedia.org/r/#/c/116871/ [18:32:02] (03PS5) 10Jdlrobson: Hygiene: Consolidate steps for visiting pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116871 [18:32:04] (03PS2) 10Jdlrobson: Hygiene: Wrap QA arguments in quotes to match other test coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116911 [18:32:28] mhurd: violetto tfinc I just lost you guys for a few secs [18:32:37] mhurd: back now [18:32:39] YuviPanda: okay [18:32:40] YuviPanda: yay! [18:32:44] YuviPanda: amusing. we lost you but kept brion [18:32:45] violetto: what did i miss? [18:32:49] tfinc: heh. [18:32:50] :) [18:34:30] YuviPanda: thinking about putting benefits of logging in when the user is logged out on left navigation [18:34:37] violetto: ok! [18:34:42] brb coffee [18:34:43] (03PS1) 10Jdlrobson: Hygiene: Correct wording of URL check in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117242 [18:35:14] ^ kaldari fixed those patches for you [18:35:22] yay [18:36:40] YuviPanda: can you review https://trello.com/c/cVzvNgXf/16-result-format-tweak-for-createaccount-api ? [18:36:50] YuviPanda: specifically https://gerrit.wikimedia.org/r/116170 [18:37:01] YuviPanda: it got a +1 from csteipp :) [18:37:05] tfinc: I talked to brion about it, I don't think I should merge it. It's security related, and I've no experience in that extension. [18:37:12] (03PS4) 10Jdlrobson: Include revId in MobileWebEditing schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116139 [18:37:39] brion: who do we need for a +2 ? [18:38:08] i guess i'll poke csteipp to test it if i can :) [18:38:24] jdlrobson: not sure what happened here but I don't think the revert merged https://gerrit.wikimedia.org/r/#/c/117234/ [18:39:06] chrismcmahon: maybe try +2ing again [18:39:10] it could just be queued up [18:40:15] jdlrobson: weird, it merged *just* as I +2'd again the messages look odd now [18:40:25] chrismcmahon: hah [18:40:40] at least the result is as needed :) [18:52:19] jdlrobson, please look at discussion in #-dev [18:58:46] (03CR) 10Kaldari: [C: 032] Hygiene: Consolidate steps for visiting pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116871 (owner: 10Jdlrobson) [18:59:32] (03PS3) 10Jdlrobson: Add password reset link from desktop on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 [19:00:17] (03CR) 10Jdlrobson: "I linked directly to Special:PasswordReset - it's probably more useful then the long essay on the desktop site..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 (owner: 10Jdlrobson) [19:03:02] (03CR) 10Kaldari: [C: 04-1] Hygiene: Correct wording of URL check in QA tests (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117242 (owner: 10Jdlrobson) [19:03:51] dr0ptp4kt, are we having a meeting? [19:04:10] yurik, i'm checking with dan right now [19:05:03] (03CR) 10Jdlrobson: Hygiene: Correct wording of URL check in QA tests (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117242 (owner: 10Jdlrobson) [19:06:35] yurik: dan says no meeting due to the metrics meeting. i'm going to listen on that passively [19:16:05] hey mhurd [19:16:15] hi vbamba [19:16:20] * YuviPanda pokes pokes vbamba [19:17:03] * YuviPanda pokes vbamba some more [19:17:55] (03CR) 10Kaldari: [C: 032] Hygiene: Correct wording of URL check in QA tests (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117242 (owner: 10Jdlrobson) [19:20:10] heloo! [19:20:13] YuviPanda: [19:20:50] poke YuviPanda [19:21:15] vbamba: hello! [19:21:22] vbamba: you poked me a few hours ago, I think? [19:24:23] brion: ping? [19:24:33] YuviPanda: yo [19:24:56] ok finally we are both here [19:24:57] (03CR) 10Swalling: [C: 031] "LGTM http://i.imgur.com/a93Dx14.png (tested in Chrome using devtools emulation of iOS7/iPhone 5)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 (owner: 10Jdlrobson) [19:25:07] brion: so I am wondering - should we set the orientationchange thing to all activities? we don't vary on layout, and we have webviews elsewhere too [19:25:10] vbamba: woo! yes [19:25:41] YuviPanda: hmmmm, maybe we should [19:26:02] Did you see the Edit Summary update? [19:26:22] vbamba: yeah, and I was wondering if I could convince you to make it even more simpler :) [19:26:25] vbamba: at least for now. [19:27:18] vbamba: which is just 'autocomplete'. You start typing, and if it similar to a summary you had typed before, it just pops up in an autocomplete list type thing, and you can select it [19:27:27] vbamba: if not, you type it, and it is available in the autocomplete next time [19:28:57] vbamba: also the 'select multiple things' type control I see now is a bit unlike how edit summaries tend to be used - you do one thing per edit usually, from what I see. [19:31:10] vbamba: are you here? [19:31:24] vbamba: ^ [19:32:10] Yup [19:32:24] I think we could do that, but for that the keyboard has to come up [19:32:29] which is what im trying to avoid [19:33:16] When the keyboard comes up, its an overlay taking over the overlay behind it [19:33:47] vbamba: as Maryana said in the email, I think prominently suggesting edit summaries that we picked rather than ones that the user themselves previously used is just going to be confusing and not a 'good match', since most edit summaries can't be so simply categorized [19:35:11] The logic for these edit summaries is that they match the tasks done by getting started [19:35:28] vbamba: and I think having the keyboard up is ok too. We shouldn't set the expectation that they just need to 'pick one' - productive collaboration requires that you write proper edit summaries that explain why you did what you did, and that's inherently a typing activity [19:35:32] vbamba: we don't have getting started :) [19:35:49] sure - we don't have it [19:36:26] Think about it - what other categories would you create? [19:36:51] vbamba: I wouldn't :) Just let it be freeform, and have autocomplete so you wouldn't have to retype things [19:36:59] vbamba: if I'm on a 'fix all the typos!' binge, I don't need to retype them [19:37:40] hmm. Ya I get your point. [19:38:09] can you exaplin the workflow you have in mind? [19:38:13] explain* [19:38:25] vbamba: moment [19:38:29] sure [19:39:29] vbamba: so, looking at the 'editing signed in workflow.png' on https://trello.com/c/dSXteqIw/2-design [19:39:36] ok [19:39:59] vbamba: on the preview screen, just get rid of the 'Fixed Typos/Grammar', 'Linked words', etc. Replace with textbox. That is all. [19:40:32] vbamba: we'll make the entire bottom overlay bounce in to make sure it isn't ignored. [19:41:02] thats not the point Yuvi - a slide up is sufficient. we dont need gimmicks. [19:41:12] Back to your idea [19:41:21] ok lets get rid of the tags - can you explain how it works without that ? [19:41:22] vbamba: that's all my idea is. just remove the canned entries. [19:41:39] explain what the user does [19:41:46] vbamba: okay, so I make an edit. [19:41:47] vbamba: hit 'save' [19:41:50] vbamba: it shows me preview [19:42:06] ok [19:42:12] good so far [19:42:14] =] [19:43:13] i may notice a drawer slide up with 'explain how you added to this article' [19:43:19] so i tap on it [19:43:36] it takes over preview - keyboard comes up [19:43:40] vbamba: then it shows me at the bottom that I need to do an edit summary, and has a textbox. it also explains why I need to do an edit summary (to help other editors understand what you are doing). So I type one in. So for example, I start typing 'Removed space before fullstop'. Since I had previously removed a space before a fullstop on another article two days ago, it shows up an 'autocomplete list', so I just tap tha [19:43:40] t instead of typing it. Then I hit 'save' and continue [19:44:07] vbamba: yeah, and you can always hit the 'back' button (android system wide back) to get rid of the keyboard. [19:44:40] vbamba: look at https://en.wikipedia.org/w/index.php?namespace=0&tagfilter=&target=Main+Page&hideliu=1&limit=500&title=Special%3ARecentChangesLinked - that's just edits made by anon editors to article pages. Of the ones that have an edit summary, most can't be picked up from a canned one. [19:45:22] vbamba: oh, also - an edit summary isn't 100% required. If I removed a space before a fullstop, I don't actually need to have a summary there. It's good to have one, and if you do major changes you need to explain it, but you don't need to do a 100char edit summary for a 2char edit [19:46:21] vbamba: also, I could just implement it and show you :) Since it's only one step away from your mockup. [19:46:22] Thats a really good point [19:46:34] that we shouldnt even carry an edit summary if its a minor edit [19:46:50] vbamba: yeah! if you look at the link I gave you, not all of them have summaries [19:46:57] vbamba: and the ones that do can't really be categorized easily [19:47:00] most of them dont have summaries [19:47:04] vbamba: that's also what Maryana and Oliver were saying [19:47:12] vbamba: yeah, they only mention which section was edited which we do automatically [19:48:32] I did check about this early on. Didnt we say that at the preview stage we dont know the size of the change - we dont know if its a minor edit until the edit has been submitted? [19:48:50] if we do - that would be pretty good [19:49:11] we could be much smarter if we knew size of change at the preview stage [19:49:13] vbamba: hmm? we can't decide if it is a 'minor' edit. Changing someone's 'number of children' from 3 to 4 isn't a minor edit :) [19:49:22] vbamba: we can't decide minor / major from size of change [19:49:25] true true [19:49:50] Adding info about a spouse isnt minor =] [19:50:07] but..i guess for now we are working off how 'minor edit tagging works' in the watchlist [19:50:08] vbamba: indeed. Changing a 'he' to 'she' is not minor either :) [19:50:24] vbamba: it works when people check a box saying 'minor edit' in the desktop editor? [19:50:39] vbamba: we don't expose that in mobile web. You can't mark an edit as 'minor' from mobile web at all [19:50:41] I totally agree with you - context of change is more important than bytes [19:50:53] ya - mobile web automatically does that [19:51:04] but it only factors bytes added removed [19:51:11] vbamba: oh that sounds terrible :| [19:51:24] technical limitations [19:51:27] MaxSem: ^ what algorithm do we use to automatically mark something as 'minor'? [19:52:06] there's none [19:52:24] MaxSem: do we automatically mark some edits as minor on mobile web? [19:52:31] do we? [19:52:44] * MaxSem doubts this [19:52:49] MaxSem: vbamba says we do. That sounds wrong to me. [19:53:03] vbamba: I highly doubt it, the community would've been making noises about it if it were. I can verify it as well [19:53:27] Cn you verify? [19:53:37] this is an insane thing to do automatically [19:53:37] vbamba: moment [19:53:42] MaxSem: I agree [19:53:42] Perhaps Im wrong. [19:55:09] vbamba: MaxSem I just checked the code. it doesn't set 'minor' anywhere [19:55:22] vbamba: MaxSem so you can't actually mark the edit as minor anywhere on mobile web, and no autodetection is done [19:56:05] and that is fine [19:56:17] Just wondering - How do the 'm tags' appear then? Cos we dont surface the minor edit option in the mobile workflow [19:56:32] vbamba: they can appear only from edits in desktop. can't appear from mobile [19:56:42] vbamba: all edits from mobile are tagged as 'mobile', which is different from 'm' [19:57:32] YuviPanda: looking at some article histories, just a sec [19:57:38] vbamba: ok [19:58:58] vbamba: https://en.wikipedia.org/w/index.php?namespace=0&tagfilter=mobile+edit&hideanons=1&limit=500&title=Special%3ARecentChanges 500 edits made from mobile. not one is marked 'm' [20:01:33] ok, I stand corrected. I thought we did tag for minor edits coming from mobile. but what you say makes sense. [20:01:51] 'minor' can only be decided by the editor [20:02:07] vbamba: yeah! [20:02:16] So coming back to the edit workflow [20:02:29] youre right that only the editor can decide whether this deserves a summary or not [20:03:00] We can get the copy to indicate that [20:03:49] vbamba: yep. and just make it a textbox. so they can type in a summary if they want to, or just leave it if not [20:04:16] but yuvi a new user wouldnt know what to do with that or how to describe their change [20:04:27] its really confusing for people who have never seen this before [20:04:36] i wouldnt know what to start typing [20:04:44] vbamba: they can't be productive users without learning. we need to teach them, not hide it from them assuming it is too complicated for them. that feels rather patronizing. [20:04:49] vbamba: they can just ignore it then. [20:04:56] completely agree [20:05:04] but you have to help them understand right? [20:05:23] until i start typing - i have no idea what to do. that seems a bit late. [20:05:44] vbamba: hmm? tthere is text there that says 'describe the changes you made so other editors can understand' [20:05:50] vbamba: how does that not come up until you type? [20:06:16] vbamba: again, I think chat is perhaps not the best medium for this. How about I implement it - which is basically just the workflow you have minus the canned edit summaries, and then we can talk about it? [20:06:34] sure, or we can do a quick hangout in 5 mts? [20:06:53] vbamba: sure, we could do that too. But I have nothing to show right now :) [20:09:39] I just wanted to tell you what I think the issue is [20:09:43] vbamba: sure! [20:09:59] vbamba: before that, have you read the emails from Oliver and Maryana? [20:10:04] gimme 2 mts, calling you on hangout [20:10:08] vbamba: sure! [20:10:10] we will keep it short [20:10:14] vbamba: ok! [20:28:20] calling you back, sorry computer died [20:31:47] vbamba: :) [20:35:12] https://docs.google.com/a/wikimedia.org/spreadsheet/ccc?key=0AlEIL4N8KjNndHp1LTlmbkFqRkV0amNIRUhxaHdmV1E&usp=drive_web#gid=2 [20:47:03] (03PS1) 10Kaldari: Updating getLeadSection() in application.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117310 [20:47:06] kaldari: https://gerrit.wikimedia.org/r/#/c/116911/2 [20:59:15] (03CR) 10Kaldari: [C: 032] Hygiene: Wrap QA arguments in quotes to match other test coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116911 (owner: 10Jdlrobson) [21:01:57] (03Merged) 10jenkins-bot: Hygiene: Wrap QA arguments in quotes to match other test coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116911 (owner: 10Jdlrobson) [21:02:34] (03Merged) 10jenkins-bot: Hygiene: Consolidate steps for visiting pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116871 (owner: 10Jdlrobson) [21:03:43] (03Merged) 10jenkins-bot: Hygiene: Correct wording of URL check in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117242 (owner: 10Jdlrobson) [21:04:59] yurik: hi [21:05:04] YuviPanda: ^ [21:05:10] http://lists.wikimedia.org/pipermail/mobile-l/2014-March/006551.html [21:05:15] sigh [21:05:22] I couldn't find the new version in iTunes or Google Play [21:05:43] kaldari: can you lightning deploy today? [21:05:54] sure [21:06:08] odder: http://lists.wikimedia.org/pipermail/mobile-l/2014-February/006537.html [21:06:51] jdlrobson: somehow I forgot to merge the change at the top of your QA stack, so I didn't notice that none of them had actually merged :P [21:07:36] jgonera kaldari: this is the change that needs to be LDed - https://gerrit.wikimedia.org/r/#/c/117234/ [21:07:40] i mailed about it on mobile-l [21:09:36] odder: that's also a terrible title. it talks about the wikipedia app [21:10:47] o_0 [21:11:53] odder: yeah, I know. [21:19:44] odder, YuviPanda, yurik sorry for any confusion on the title [21:19:55] dr0ptp4kt: <3 :) [21:37:35] (03PS1) 10Yuvipanda: Add 'Send Feedback' iten to left nav [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/117323 [21:37:38] brion: mhurd ^ [21:37:50] tfinc: ^ just implemented 'send feedback' button. [21:37:50] whee [21:37:57] YuviPanda: nice!!! [21:37:58] (03PS1) 10Jdlrobson: WIP: Anonymous editing in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117324 [21:38:19] (03CR) 10Jdlrobson: [C: 04-2] "Needs more work" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117324 (owner: 10Jdlrobson) [21:38:21] jdlrobson: just curious - can you enable alpha without logging in? [21:38:24] ah it's so easy to launch an email dialog :D [21:38:32] brion: :D yeah! [21:38:42] YuviPanda: yeh. Alpha and beta are user agnostic [21:38:48] YuviPanda: also ?mobileaction=alpha [21:38:49] jdlrobson: ah, sweet! [21:39:20] YuviPanda: mobile beta/alpha is different from BetaFeatures in this way - anonymous users are really useful to test against [21:39:35] this is the main reason why i'm not so keen on mobile using BetaFeatures exclusively at this time [21:39:45] jdlrobson: yeah, that makes perfect sense. [21:42:21] brion: any time to poke this? https://gerrit.wikimedia.org/r/#/c/117089/ [21:42:46] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add 'Send Feedback' iten to left nav [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/117323 (owner: 10Yuvipanda) [21:43:00] looking [21:43:11] brion: sweet [21:44:36] mhurd: so that basically moves some ops to another queue and makes sure things get started/stopped properly [21:44:48] looks ok :D [21:45:28] brion: oh, yeah, the q stuff is really just hygiene - the 2 lines i commented actually fix the bug [21:45:38] aho [21:45:53] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for save no longer working if initial save attempt failed. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117089 (owner: 10Mhurd) [21:46:05] brion: yay! thanks! [21:46:09] :D [21:46:35] brion: i just had an eager moiz wanting a build :D [21:46:38] lets get it to him ~ [21:46:39] ! [21:46:47] mhurd: --^ [21:47:07] tfinc: I implemented a 'send feedback' link on the android app. now to just find testers... :D [21:47:32] (03PS2) 10Jdlrobson: Hygiene: Updating getLeadSection() in application.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117310 (owner: 10Kaldari) [21:47:37] (03CR) 10Jdlrobson: [C: 032] Hygiene: Updating getLeadSection() in application.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117310 (owner: 10Kaldari) [21:47:51] (03PS2) 10Jdlrobson: QA: Fix breaking tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117109 [21:48:02] kaldari: key one needs merging still :D^ [21:49:04] tfinc: ok i sent him an invite [21:49:09] brion: thanks [21:49:10] i like that, eager moiz.. that'll be my new irc handle [21:49:12] YuviPanda: nice [21:49:14] :D [21:49:23] thanks brion [21:51:22] eek sigh - mobile-l regression jgonera https://m.mediawiki.org/wiki/Special:Watchlist?mobileaction=stable [21:51:29] cc kaldari [21:51:35] nasty [21:52:12] moizsyed: ok you should shortly get an email with the install link [21:52:16] let me know if you have any problems! [21:52:42] jdlrobson, do we have a fix yet? [21:52:52] or do we know what caused this? [21:52:57] not yet jgonera i just raised a bug and mailed it to the lightning deploy thread [21:53:02] i really need to sort these tests out [21:53:04] there is a lot of broken shit [21:53:08] ok [21:53:28] I'll take a look at all the bugs we have and will schedule an LD [21:54:20] (03PS2) 10Jdlrobson: Hygiene: Remove unused function in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117007 [21:55:55] chrismcmahon: did the login credentials for beta labs change recently? [21:56:10] jdlrobson: shouldn't have [21:56:12] did we start using another user? [21:56:13] mm [21:56:20] i'm trying to work out why a load of tests are failing [21:56:26] jdlrobson: looking [21:58:02] jdlrobson: Selenium_user logs in just fine. lemme finish this email and I'll look [21:58:56] chrismcmahon: this seems to fail due to the password field being empty which is strange.. https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/306/testReport/junit/(root)/Page%20diff/Added_and_removed_content/ [22:02:24] moizsyed: free? [22:02:36] violetto: sure [22:02:48] moizsyed: mobile area [22:03:50] brion: not sure if this was sent your way already, but moiz email address (for test flight) is msyed@wikimedia.org [22:04:01] mhurd: already sent thx :D [22:04:12] cool! [22:09:40] (03PS2) 10Jdlrobson: Hygiene: One final big round of QA hygiene [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116899 [22:09:48] jdlrobson: I'm killing all the current build so we can see where we're at with MF/beta [22:10:11] chrismcmahon: thanks much appreciated [22:10:46] seem to be a mix of bad tests and broken things and changes in the environment variables e.g. whether a page needs a lead photo, where a user has an edit count [22:15:45] (03PS3) 10Jdlrobson: QA: Rewrite tests for main menu navigation and footer links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116899 [22:17:37] YuviPanda: brion mhurd : so kenan recommend either http://www.ipevo.com/prods/Point-2-View-USB-Camera or http://www.ipevo.com/prods/IPEVO-Ziggi-HD-USB-Document-Camera for us [22:17:41] violetto: --^ [22:17:43] thoughts ? [22:17:54] i dislike the first camera we got so im sending it back [22:18:05] tfinc: hmm, I've no experience with any of those, so I'm going to let you guys pick :) [22:18:43] tfinc: those look pretty great! [22:20:10] violetto: i'll leave it to you which one your likely to use more [22:20:10] the pricier one has a neat anti-glare attachement too... [22:20:27] (03CR) 10Jdlrobson: [C: 04-1] "In rebase hell" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 (owner: 10Jdlrobson) [22:24:50] jdlrobson, you learn something new everyday, too bad that sometimes it takes an hour of banging your head against the wall [22:25:12] empty() in jQuery empties the element and removes all callbacks from its child elements [22:25:24] so it basically runs remove() on each child... [22:30:20]