[00:00:35] ok [00:00:40] video? [00:07:30] (03PS12) 10Dr0ptp4kt: HTTPS UI for applicable Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik) [00:16:27] jdlrobson, I added you to https://gerrit.wikimedia.org/r/#/c/99586/ (compact personal bar), see also further patches [00:16:28] it's still messy though [00:17:44] (03PS13) 10Dr0ptp4kt: HTTPS UI for applicable Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik) [00:21:17] jgonera: it's marked as WIP [00:21:24] that's why i didn't touch it [00:21:35] jdlrobson, yes, as I told you, it's not finished [00:21:48] so i'm confused - you are looking for a sanity check? [00:21:57] I'm giving you a link so you can see it since what jorm is working on will depend on it [00:22:33] jdlrobson, if you want to do a sanity check, have some comments on the general idea, then I'd also appreciate it [00:32:44] jdlrobson: looks like test failures have mellowed how [00:32:47] s/how/out... [00:32:56] only two failures now on betalabs [00:34:25] awjr: \o/ [00:34:35] looking at them now awjr [00:34:41] on The requested resource () is not available. o_O [00:34:55] https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/399/testReport/Basic%20site%20for%20legacy%20devices//Able_to_access_left_navigation_in_basic_non_JavaScript_site/ < awjr can you view that? [00:35:46] i see a 404 [00:35:51] is that what im supposed to be seeing? [00:35:59] awjr: just saw that, and those two are the ones that are not tracking Sauce job IDs properly. Not sure what makes those unique... [00:36:06] huh [00:36:14] perahps that's part of what chrismcmahon was talking about earlier [00:36:22] i'm running those tests against beta labs now to see what's going on [00:36:31] they both pass.. [00:36:35] kk at the very least, this looks a helluva lot better [00:37:40] (03PS14) 10Dr0ptp4kt: HTTPS UI for applicable Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik) [00:39:07] @custom-browser tag problem awjr ? [00:39:56] awjr: jdlrobson the console output looks fairly normal, looks like the tests connected and ran, Jenkins just lost the output destination https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/399/testReport/ we'll figure it out. [00:40:19] (03PS15) 10Dr0ptp4kt: HTTPS UI for applicable Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik) [00:41:21] chrismcmahon: any idea what the issues/steps are that failed? [00:41:50] jdlrobson: no, I'm about to see if anything about those 2 tests seems unique, updating to latest MF now [00:41:57] huh i dont know anything about the @custom-browser tag [00:42:23] thats the only feature file it appears in [00:42:24] awjr: so these tests set the user agent to be opera mini [00:42:28] it tests the basic site [00:42:33] so i'm curious if something there is broken [00:42:42] oh funky [00:43:01] kaldari: when we heading to oakland? [00:43:12] dunno [00:43:22] when do you want to head to oakland? [00:43:47] when does it start? [00:43:49] leave at 5.30? [00:45:21] (03PS1) 10Mhurd: Migrate strings to qqq file. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117628 [00:45:37] brion: dr0ptp4kt: ^ [00:45:50] awjr: lol i swear you send that mail about Arizona time every daily savings reminder :) [00:46:37] jdlrobson: can pretty much guarantee it is that @custom-browser tag that is the problem. what are you trying to accomplish with that? [00:46:41] hahaha i do, i hope someday joady will just include it in future emails [00:46:42] whee [00:47:06] greg-g: i guess my email about moving conversations out of " Gerrit Commit Wars" failed miserably :) [00:47:47] brion: that should be most of 'em with the exeption any i've got set via storyboards. can do separate pass for those if that sounds good [00:49:14] kaldari: 5.30 work? [00:50:03] chrismcmahon: so i guess the @custom-brower tag is related to "I am using user agent "(.+)" given step [00:50:17] it's supposed to force a user agent [00:50:24] jdlrobson awjr we run builds according to target env and browser. a) we have no support for opera mini and b) if we did it would not work in the firefox build and c) that tag is not associated with any code at all, there is just a Given statement that may or may not succeed in setting a user agent. that no_javascript_site.feature is just not going to dtrt without more work [00:50:28] maybe that doesn't work on cloudbees? [00:50:44] chrismcmahon: it doesn't need to run in opera mini it just needs to spoof the user agent ^ [00:51:49] it was setup from the time of michelle, but the test seems to have been passing until i rewrote it to actually test was it claimed to be testing :) [00:53:11] jdlrobson: you are a trusting soul [00:53:32] chrismcmahon: it works for me when i run locally [00:53:38] (against beta labs) [00:53:50] we could tag it to only run on a local browser and take a closer look at how the environment differs? [00:53:58] jdlrobson: 5:30 sounds good. you wanna eat in SF or Oakland? [00:54:04] kaldari: Oakland~ [00:54:14] cool, there should be lots of food trucks there [00:54:14] i never get to eat in Oakland! is violetto still coming? [00:54:27] jdlrobson: just remove the @custom-browser tag completely. it won't hurt anything, and it might actually dtrt [00:54:43] mhurd: sounds good, i'll test in a bit :D [00:54:56] brion: cool thx! [00:56:33] chrismcmahon: ok i'll do a patch now [00:57:43] (03PS1) 10Jdlrobson: Hygiene: Remove mysterious @custom-browser tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117632 [00:57:44] ^ chrismcmahon [00:57:53] jdlrobson: I think we might have to do some code archaeology to make those tests work again [00:58:02] chrismcmahon hehe :) [00:58:14] on the plus side everything is looking more clean in qa land now [00:58:20] lots of reuse and generic rules [00:58:59] kaldari jdlrobson what time? [00:59:13] leave at 5.30 violetto1 ? [00:59:27] my friends gonna join us there [01:01:28] jdlrobson: sounds good [01:03:59] (03PS16) 10Dr0ptp4kt: HTTPS UI for applicable Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik) [01:04:07] you guys going to 12th street? [01:05:13] (03PS17) 10Dr0ptp4kt: HTTPS UI for applicable Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik) [01:18:33] (03PS18) 10Dr0ptp4kt: HTTPS UI for applicable Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik) [01:19:56] (03PS7) 10Kaldari: Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [01:20:04] (03CR) 10jenkins-bot: [V: 04-1] Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [01:21:53] (03PS8) 10Kaldari: QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [01:21:55] (03PS8) 10Kaldari: Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [01:25:40] jorm: not sure - kaldari ? [19:14:27] i need guidlines for gsoc proposal of commons app , i have some ideas for commons app .