[10:31:29] (03CR) 10MaxSem: [C: 04-1] Add password reset link from desktop on mobile (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 (owner: 10Jdlrobson) [13:37:38] (03CR) 10Zfilipin: [C: 032] Hygiene: Remove unused function in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117007 (owner: 10Jdlrobson) [13:38:23] (03Merged) 10jenkins-bot: Hygiene: Remove unused function in QA tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117007 (owner: 10Jdlrobson) [14:15:35] (03PS1) 10Zfilipin: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117857 [14:16:32] (03PS2) 10Zfilipin: QA: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117857 [16:44:20] (03CR) 10Jdlrobson: [C: 04-1] "Is it not better to be explicit about the page being tested? As if a test runs on a random page then the results could be inconsistent dep" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117857 (owner: 10Zfilipin) [16:59:37] (03PS4) 10Jdlrobson: Add password reset link from desktop on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 [17:00:35] (03CR) 10Jdlrobson: Add password reset link from desktop on mobile (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 (owner: 10Jdlrobson) [17:12:24] jdlrobson, the image bug is caused by the lack of height: auto !important [17:12:37] jdlrobson, it was removed because with this rule VE is completely messed up [17:27:31] hi brion [17:27:59] yo yo [17:29:33] brion: if i remember correctly from friday, adam's patch (https://gerrit.wikimedia.org/r/#/c/117127/) will be no longer needed once the qqq update (which i'll amend in a minute) gets merged [17:30:59] (03CR) 10Kaldari: [C: 04-1] Fix nearby pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117126 (owner: 10Jdlrobson) [17:34:41] (03PS2) 10Mhurd: Migrate strings to qqq file. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117628 [17:37:07] jdlrobson_, not sure if you got those messages: [17:37:12] the image bug is caused by the lack of height: auto !important [17:37:16] it was removed because with this rule VE is completely messed up [17:37:46] jgonera: sure. but we can limit styling to viewing page content area no? [17:37:52] since VE is in an overlay.. [17:38:57] (03PS3) 10Mhurd: Migrate strings to qqq file. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117628 [17:39:21] (03CR) 10Cmcmahon: "Jon, this is just moving existing code to a shared code repo. If you need a random page, this is the right way to get a random page." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117857 (owner: 10Zfilipin) [17:40:31] (03CR) 10Jdlrobson: "Chris yes I understand what it's doing but these tests do not need a random page and I'm suggesting they should stop relying on a random p" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117857 (owner: 10Zfilipin) [17:41:27] (03CR) 10Mhurd: "I amended to make capitalization consistent based on Siebrand's comment." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117628 (owner: 10Mhurd) [17:42:43] brion: ^ should be good i think. (we'll be getting proper icons next sprint for the menu items) [17:42:52] ah great :D [17:42:53] icons++ [17:43:50] (03PS3) 10Jdlrobson: Update attribution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117013 [17:46:33] (03CR) 10Kaldari: [C: 032] Include revId in MobileWebEditing schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116139 (owner: 10Jdlrobson) [17:47:18] (03Merged) 10jenkins-bot: Include revId in MobileWebEditing schema [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116139 (owner: 10Jdlrobson) [17:48:25] jdlrobson_, not really, as far as I remember we set .content to VE's div, just like in regular editor preview, to achieve consistent styles [17:48:46] jgonera: well we have control over our skin HTML no.. ;-) [17:49:02] you mean adding one more class? [17:49:15] not necessarily [17:49:20] but what about those images in VE then? they will be squished... [17:49:25] I mean [17:49:34] we already having existing classes i'd be extremely surprised if we were not able to restrict the rule to not apply to VE [17:49:34] article image with inline styles edited in VE [17:49:45] jgonera: are they squashed in VE? if so that sounds like a VE bug [17:49:52] yeah, but then VE stops being WYSIWYG [17:49:53] no... [17:50:11] jgonera: i don't know the solution as i haven't looked, i'm just saying there is one somewhere [17:50:14] I suppose they are, for the same reason they are in mobile [17:50:23] stripping inline styles? [17:50:43] jgonera: well images never used to be squished in mobile so i know it is possible :) [17:51:00] jdlrobson_, because we had this rule I suppose [17:52:52] jdlrobson_, maybe a patch to core so that it stops adding width and height attributes to img tags? [17:53:23] maybe but right now i think fixing the problem in the mobile skin is more important than fixing it in VE so we should revert whatever change introduced the problem [17:53:28] (since VE is in alpha) [17:53:33] no [17:53:42] VE becomes completely unusable with this [17:53:47] no way of testing it [17:53:51] or working on it [17:54:01] jgonera: well i'm sorry but imo it's unacceptable to have a broken reader mode [17:54:05] unless we test it on pages with plain text only [17:54:11] at least only add this rule in alpha [17:54:17] add/remove [17:54:19] remove? [17:54:23] maybe [17:54:37] that's an option, but we have to think how to fix it long term [17:54:39] chrismcmahon: So I removed the @custom-browser tag on friday - can we see if merging this https://gerrit.wikimedia.org/r/117632 fixes those breaking tests? [17:54:57] it probably won't but it won't hurt anything [17:55:20] and chrismcmahon did you see my follow up to your comment about the random page stuff? [17:55:20] mhurd: can we move our meeting by about 30mins? DST has thrown me off and I need to finish up a bunch of things [17:55:31] (03CR) 10Cmcmahon: [C: 032] Hygiene: Remove mysterious @custom-browser tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117632 (owner: 10Jdlrobson) [17:55:35] YuviPanda: ya! [17:56:06] jdlrobson_: yes. I'll test out your patch and if we can remove RandomPage completely and abandon the other commit, I think that's fine [17:56:07] mhurd: sweet :) cya in 30 then! [17:56:14] chrismcmahon: sweet! thanks! [17:56:30] chrismcmahon: i just worry that if we tie tests to random pages we will get unexpected results [17:56:47] jdlrobson_: understood [17:57:02] YuviPanda: oh, is that the editing goal meeting? isn't that tomorrow? [17:57:11] (03Merged) 10jenkins-bot: Hygiene: Remove mysterious @custom-browser tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117632 (owner: 10Jdlrobson) [17:57:50] mhurd: oh? no, you had set it for today :P [17:57:57] mhurd: you can move it to tomorrow too, that's fine :) [17:58:04] mhurd: at least my calendar tells me it is today? [17:58:12] YuviPanda: calendar shows it on tuesday... [17:58:36] YuviPanda: does yours show monday? [17:58:37] mhurd: gaaah, nevermind, that's my misreading. [17:58:54] mhurd: no, it shows tuesday, but then most things that are on your monday show as tuesday to me, and I kinda misread the time [17:59:13] mhurd: confused time for showcase with this. nevermind then :) Let's do it at that time itself on tuesday [17:59:18] mhurd: no change! sorry for the confusion! :) [17:59:57] mhurd: not sure if you missed those, but i just misread things. nevermind [18:00:08] YuviPanda: no worry! [18:00:13] mhurd: :) [18:06:35] is kenan around today for sign off? [18:10:48] jdlrobson_: afaik he should be in today; i just poked him about joining IRC but according to his calendar he's in back-to-back meetings almost all day [18:10:56] or at least is marked as busy [18:11:08] ken an is becoming a bit of a unicorn ;-) [18:11:36] he should be joining irc shortly [18:19:01] MaxSem: trying to review your minify stuff but can't get it setup locally [18:19:07] trying to reverse engineer and failing [18:19:33] kenanwang: are you coming into the office today? [18:19:57] (03CR) 10Kaldari: [C: 04-1] Story 1714: Revert back to using VisualEditors toolbar buttons (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117446 (owner: 10Jdlrobson) [18:20:06] jdlrobson_: yep heading in right now [18:20:17] kenanwang: sweet. when's a good time to grab you to sign some stuff off? [18:20:32] (03CR) 10Kaldari: "Also needs to be rebased." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117446 (owner: 10Jdlrobson) [18:22:38] jdlrobson_, needs https://gerrit.wikimedia.org/r/#/c/74293/ for core [18:23:39] jdlrobson_, then copy settings.json.sample to settings.json [18:25:09] jdlrobson_: 230 [18:25:19] kenanwang: ok i'll set that up [18:25:37] MaxSem: ah the core change gives this more context [18:25:42] should document that :) [18:26:23] should just prepare the few bits and pieces and submit for RFC [18:27:01] (03PS2) 10Jdlrobson: Story 1714: Revert back to using VisualEditors toolbar buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117446 [18:27:27] what happened to the 'terms of use' link in the footer on test2 and mediawiki.org? [18:27:49] it appears to be missing [18:27:55] jgonera: jdlrobson_ kenanwang kaldari MaxSem ^ [18:28:05] eh [18:28:07] although it is present on betalabs [18:28:10] and enwiki [18:28:16] awjr: one second - i know how to sort that out [18:29:12] awjr jdlrobson_ : I believe it's dependant on a local MediaWiki message being set [18:29:22] http://en.m.wikipedia.beta.wmflabs.org/wiki/MediaWiki:mobile-frontend-terms-url < awjr [18:29:23] although it seems to work by magic on en.wiki :P [18:30:40] so is it supposed to be missing on test2 and mediawiki.org, or is that a bug? [18:30:40] we should probably restrict that test so it doesn't run on mediawiki.org [18:30:46] if it's supposed to be missing, then we should update the tests [18:30:53] same with test2 jdlrobson_ [18:31:01] test2 now has it [18:31:12] awjr: it's not supposed to be missing, maybe just no one has set it there [18:31:29] the main thing it protects is that we don't accidentally remove a terms of use link on enwiki [18:31:34] so in theory it only needs to run there [18:31:44] jdlrobson_: another thing we need to add the test set-up instructions [18:31:58] kaldari: it's already in there [18:32:01] * Edit MediaWiki:mobile-frontend-terms-text with text 'Terms of use' [18:32:24] ah cool [18:33:01] https://en.m.wikipedia.org/wiki/MediaWiki:Mobile-frontend-terms-text [18:33:04] it's set on en.wiki [18:33:20] Talking of QA tests - all these still need review https://gerrit.wikimedia.org/r/116900, https://gerrit.wikimedia.org/r/117371, https://gerrit.wikimedia.org/r/117370, https://gerrit.wikimedia.org/r/116692 [18:34:01] (03Abandoned) 10Jdlrobson: Add an ability to change the copyright warning in editor and uploader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/104906 (owner: 10M4tx) [18:34:13] (03CR) 10Kaldari: [C: 032] Update attribution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117013 (owner: 10Jdlrobson) [18:34:52] (03Merged) 10jenkins-bot: Update attribution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117013 (owner: 10Jdlrobson) [18:34:57] (03Abandoned) 10Jdlrobson: In alpha mode, save and restore the set of open sections in the history [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/103845 (owner: 10Pcc) [18:35:27] (03CR) 10Kaldari: [C: 032] Story 1714: Revert back to using VisualEditors toolbar buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117446 (owner: 10Jdlrobson) [18:35:47] (03CR) 10Siebrand: [C: 04-1] "Thanks. I'm not yet familiar with this project's file layout, so please forgive me for adding comments in stages." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117628 (owner: 10Mhurd) [18:36:04] (03Merged) 10jenkins-bot: Story 1714: Revert back to using VisualEditors toolbar buttons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117446 (owner: 10Jdlrobson) [18:37:32] MaxSem: what should $wgMinifierHosts be set to? [18:38:14] MaxSem: the error "exception 'MWException' with message 'Error requesting minification: Invalid URL: $1' in /Users/jrobson/Sites/w/extensions/Minifier/Minifier.body.php:32" could be more useful [18:38:28] jdlrobson_, $wgMinifierHosts = array( 'localhost:8888' ); [18:38:44] MaxSem: thanks - could you add a README to help with this sort of thing? [18:39:04] will do [18:39:35] YuviPanda, is there any interest in the wikimedia community for the Mobile Viewing application of WikiNews? [18:40:16] (03CR) 10Mhurd: "This patch includes context for the added strings here: https://gerrit.wikimedia.org/r/#/c/117628/3/Wikipedia-iOS/qqq.lproj/Localizable.st" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117628 (owner: 10Mhurd) [18:40:28] MaxSem: I'm not convinced it's running your minified now. If I turn the node server off it still minifies... [18:40:41] caching [18:40:49] oh wait now i'm convinced :) [18:40:59] I am Venkatesh, a gsoc participant. I have tried to contact pizero and Laura Hale, as written in the project ideas page. But I got no proper response from them. :( [18:41:05] what, errors in your face?) [18:42:16] (03CR) 10Siebrand: [C: 031] "Oh, right! I overlooked that, Monte. Thanks for pointing it out. L10n LGTM!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117628 (owner: 10Mhurd) [18:44:21] jgonera: jdlrobson_ MaxSem anything you want to show off at the showcase today? add to the agenda: https://etherpad.wikimedia.org/p/MobileShowcase [18:45:10] coderbrahmin, try #wikinews-en - we the mobile people can help you in general but we don't know Wikinews [18:45:16] brion: siebrand +1'ed the qqq patch :) [18:47:00] awjr: https://bugzilla.wikimedia.org/show_bug.cgi?id=62294 never got picked up by bingle [18:47:03] and it's quite a serious bug :) [18:47:08] ruhroh [18:47:19] i guess it didn't get picked up since i made a patch right away [18:47:20] but thus it is not being tracked [18:47:29] awjr, not really [18:47:32] jdlrobson_: likely [18:48:22] jdlrobson_, do you have abusefilter on your instance? [18:48:32] jgonera: yes [18:48:58] jdlrobson_, could you show it during the showcase? I don't have it on my home instance... [18:49:04] that is, if we really want to show it [18:49:15] not sure if it's that exciting [18:49:18] kaldari, ^ [18:49:30] jdlrobson_: yeah bingle will only pick bugs up if their status is 'unconfirmed' or 'new' [18:50:15] it currently runs every 5 mins so if i a bug gets reported and then the status changed to something other than unconfrimed or new before it runs, it won't get picked up [18:55:07] (03CR) 10preilly: "How is it okay to remove a copyright line without permission?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117013 (owner: 10Jdlrobson) [19:02:53] brion: hangout is up and ready for you to join [19:06:05] (03CR) 10preilly: Update attribution (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117013 (owner: 10Jdlrobson) [19:14:36] (03CR) 10preilly: "To be fair I don't mind at all and I think that it should be WMF copyright. I'm just curious as I didn't think you could just remove the l" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117013 (owner: 10Jdlrobson) [19:18:57] (03CR) 10preilly: Update attribution (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117013 (owner: 10Jdlrobson) [19:32:01] thanks MaxSem . I'll try my luck there as well. If needed, can I bounce ideas off you as well? [19:32:23] frankly, I'm not a wikinewsie:) [19:49:13] (03PS1) 10preilly: Restore erroneously removed copyright notice from https://gerrit.wikimedia.org/r/#/c/117013/3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117918 [19:49:58] (03CR) 10preilly: "Take a look at: https://gerrit.wikimedia.org/r/#/c/117918/1" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117013 (owner: 10Jdlrobson) [19:51:11] (03CR) 10preilly: [C: 031] Restore erroneously removed copyright notice from https://gerrit.wikimedia.org/r/#/c/117013/3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117918 (owner: 10preilly) [19:57:39] James_F, kenanwang do you feel like we have enough things to talk about to have a meeting evaluating collaboration between mobile and VE? I think we should postpone it until we're closer to finishing the link inspector on mobile [19:58:49] awjr, tfinc ^ [20:02:34] kenanwang, James_F, ping [20:02:36] jgonera: do you feel there's not been enough time for us to know whether or not things are working both from our perspective as well as VE's? [20:03:12] (03CR) 10Kaldari: [C: 04-1] "The correct way to do attribution in the i18n file is to add a list of authors to the en array:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117918 (owner: 10preilly) [20:03:35] awjr, I guess. I mean, I don't have any issues so far, so if the VE team doesn't have issues either then there's not much to discuss [20:03:38] jgonera: awjr James_F I also think it's a good idea to postpone a week [20:05:33] (03CR) 10preilly: "Well strictly speaking 17 U.S. Code § 101 doesn't apply so cleanly. I'd like to have the copyright restored." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117918 (owner: 10preilly) [20:07:53] brion: how did the showcase go? [20:07:59] that's why GPL is evil [20:08:04] kenanwang, awjr any decision on this? I'd like to know if I can go to the office now ;) [20:08:25] was hoping to hear from James_F [20:08:27] jgonera: Happy to postpone. [20:08:31] :) [20:08:34] ^^ kenanwang / awjr [20:08:41] ok, i'll reschedule it for next week jgonera kenanwang James_F [20:08:46] thanks awjr [20:08:47] np [20:08:59] thart's why eg SVN doesn't allow copyright notices in its sources [20:11:46] (03CR) 10preilly: "Okay I've just read: http://en.wikipedia.org/wiki/Copyright_notice and it appears that @Kaldari is correct there is no need for the copyri" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117918 (owner: 10preilly) [20:12:13] MaxSem: oh, another 'we should put copyright notices' discussion? [20:12:14] (03Abandoned) 10preilly: Restore erroneously removed copyright notice from https://gerrit.wikimedia.org/r/#/c/117013/3 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117918 (owner: 10preilly) [20:12:26] ^^^^ [20:12:55] James_F: jgonera kenanwang i rescheduled for next weds [20:13:59] (03CR) 10preilly: "I've abandoned my change as I've just read: http://en.wikipedia.org/wiki/Copyright_notice and it appears that @Kaldari is correct there is" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117013 (owner: 10Jdlrobson) [20:16:28] ok [20:16:30] awjr: Thanks. [20:17:09] (03CR) 10preilly: "Also I just wanted to clarify that I think every single person that has contributed to this extension should be recognized for all of thei" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117918 (owner: 10preilly) [21:23:47] awjr|lunch: i'm taking another pass at https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/404/testReport/ since we are still not passing [21:24:36] those basic site links still give me a 404 :( [21:25:21] awjr: "Error saving settings. Please make sure you have cookies enabled." [21:25:25] this is why the VE tests are failing [21:25:35] for some reason the browser can't opt into alpha [21:25:36] or beta [21:25:40] (cc chrismcmahon [21:25:55] hmm if that were the case though other tests would be failing too [21:26:10] unless it's something specific to that test [21:27:07] jdlrobson: do you have any idea what's going on with the basic site tests? [21:27:30] awjr: not really - but as a short term measure we could limit them to local browser tests [21:27:30] leave that with me [21:28:00] awjr: jdlrobson I know what's wrong with the basic site tests (in a general way). they used the @user_agent hook, which first we broke, and then last week Zeljko and I deleted the support for it altogether [21:28:11] we broke it a while ago [21:28:21] oh nos [21:28:25] can we reinstate it chrismcmahon ? [21:28:32] anyway, Zeljko and I deleted a whole bunch of contradictory code [21:28:40] yes we can restore it but we [21:29:01] but we'll probably need to make it work in a better way [21:29:22] (the code was a mess) [21:33:01] chrismcmahon: any idea why there are so many more failures with the chrome browser tests? [21:33:22] awjr: ChromeDriver has been broken for a while [21:33:47] chrismcmahon: is there any value in keeping those tests running then? it seems to just be extra noise [21:34:00] awjr: upstream bug I haven't tracked down. this has happened before and it tends to sort itself. it is noisy [21:34:24] awjr: I have so much noise right now, legacy of changing from Jenkins templates to job-builder also [21:34:33] awjr: I am taming that this week [21:35:46] and moving build tags [21:36:51] (03PS2) 10Yuvipanda: Offer to open in the app only for m. domains [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/117834 [21:37:32] (03CR) 10Yuvipanda: "@Siebrand: Whoops, it was an accidental commit. Removed those lines from the commit now." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/117834 (owner: 10Yuvipanda) [21:37:36] brion: ^ minor patch [21:37:42] dr0ptp4kt: ^ I believe this used to irritate you a lot :) [21:38:23] YuviPanda :) [21:38:30] awjr :) [21:38:47] jdlrobson: fwiw, I don't think we're doing canned edit summaries. There are some emails about this, but sadly thy aren't on mobile-tech or mobile-l. I'll ask the relevant people and forward to -l [21:38:55] eh dr0ptp4kt? [21:40:11] YuviPanda: just reply on the thread. If it's not public it didn't happen but my understanding from the demo and Vibha's latest email is that it is happening.. [21:40:12] awjr, i think irc messages got out of sequence. glad that the app's protocol handling for wikipedia urls is more friendly [21:40:31] heh no worries dr0ptp4kt :) [21:40:46] jdlrobson: yeah, I asked the people involved, and I'll respond with relevant quotes when I hear back from them. [21:40:58] jdlrobson: if they respond negatively, I'll respond by myself instead :) [21:43:39] jdlrobson: awjr if you want to see what's broken about the no_javascript_site tests, see common_steps.rb lines 1-6. [21:43:50] chrismcmahon: looking :) [21:45:34] chrismcmahon: what is session_id used for? That step definition doesn't really make sense to me.. i'm guessing this is your point? [21:46:19] jdlrobson: session_id is the session id of the Sauce labs jobs. this was never a very nice hack, and it's busted since all of that is now shared code [21:46:27] ergg that is hacky [21:46:28] thus the 404 from the Jenkins job [21:47:06] jdlrobson: I'm writing a BZ under QA so I don't lose track of this [21:47:30] Ibfffd98be98f1f8f3641eb003e9394da9452be72 seems to have introduced this [21:47:31] sadly commit message not very descriptive [21:47:46] jdlrobson: last week I mentioned "software archaeology" I are doing software archaelology now [21:47:59] chrismcmahon: what do you recommend doing in the meantime - commenting out this test?? [21:48:14] is there a tag to make the test only run locally? [21:49:43] (03CR) 10Jdlrobson: Fix nearby pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117126 (owner: 10Jdlrobson) [21:49:46] jdlrobson: to make the test not run in the build, remove the target environment tags at the top of the .feature file [21:49:54] chrismcmahon: ok got it [21:50:17] jdlrobson: not sure if you saw this, but those tests are actually running, you can see in the console output. got a couple of failures: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/lastCompletedBuild/console [21:50:48] I'm not sure they're really accepting the useragent string properly though [21:54:12] chrismcmahon: do you have a bug number for traking this issue? [21:56:09] https://bugzilla.wikimedia.org/show_bug.cgi?id=62512 [21:56:37] even if we make it work again, only Firefox will spoof a user agent. [21:56:56] I lack any sense of how valuable this test is [21:57:48] chrismcmahon: the test is really valuable [21:58:10] we basically run 2 sites on mobile - basic (without JavaScript) and the flashy site [21:58:18] Zero uses the former a lot of the time [21:59:21] (03PS1) 10Jdlrobson: QA: Rewrite now missing rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118017 [21:59:23] (03PS1) 10Jdlrobson: QA: Stop no JS site test running on Cloudbees [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118018 [21:59:26] ^ chrismcmahon reviews appreciated! :) [22:00:21] is it possible to make that test happen w/o spoofing a user agent? [22:00:47] like is there some way with cloudbees to disable javascript? [22:03:37] (03PS2) 10Cmcmahon: QA: Stop no JS site test running on Cloudbees [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118018 (owner: 10Jdlrobson) [22:04:26] awjr: yeh that's a possible idea, but the spoofing gives us more coverage as it also tests are RL code. [22:05:01] jdlrobson: updated, the .feature file is not code, so making comments doesn't really help. I just blew out the tags line [22:05:47] chrismcmahon: hmm? [22:05:55] chrismcmahon: i can't have comments in .feature files? [22:06:25] chrismcmahon: i don't get what's wrong with that patch [22:06:33] the comment is there to make sure we revisit those tags in future :-) [22:07:00] That file has FIXME's on L4/5 are you saying that comments need to be in a block? [22:07:20] jdlrobson: Jenkins is still going to pick up the tags, it doesn't care if there is a "#" in front of the line. Cucumber is not Ruby, it parses .feature files independently. [22:07:35] really? mmmmm [22:07:43] so is there anyway we can have a comment that is ignored? [22:07:47] (03CR) 10Jdlrobson: [C: 04-1] QA: Stop no JS site test running on Cloudbees (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118018 (owner: 10Jdlrobson) [22:07:48] ^ alos [22:07:49] jdlrobson: a .feature file is not Ruby and is not read by the Ruby interpreter. it is read by Jenkins and Cucumber [22:08:01] so no comments are allowed in that file chrismcmahon ? [22:08:57] jdlrobson: for the Cucumber parser, anything above the first occurrence of "Feature:" is not parsed. [22:09:25] jdlrobson: for Jenkins, I don't really know. just remove the target env tags and they won't be read. [22:10:07] chrismcmahon: so how can i achieve this FIXME in this file and satisfy every thing that reads it? [22:10:11] actually, I do. Jenkins reads the whole .feature file, because it is possible to tag individual Scenarios [22:10:20] (03PS4) 10Jdlrobson: Hygiene: Kill that 'I am on the User login page' rule in QA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116900 [22:10:25] remove all target env tags [22:11:01] chrismcmahon: but i'm saying i want to make sure we reinstate them later and would like to have a comment in the feature file - are you saying to me this is impossible? [22:11:18] awjr: can you +2 this change based on the fact siebrand has +1ed it ? https://gerrit.wikimedia.org/r/#/c/117012 [22:11:51] or merge my patchset [22:12:04] (03PS6) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [22:12:20] (03PS3) 10Jdlrobson: Proper edit handling in case of redirects where page does not exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116912 [22:12:44] chrismcmahon: i still don't feel like your answering my question.. [22:13:12] jdlrobson: you can't put a Ruby #comment in a Cucumber .feature file. it is apples and oranges. [22:13:24] chrismcmahon: so what effect does https://gerrit.wikimedia.org/r/#/c/118018/2/tests/browser/features/no_javascript_site.feature have? [22:13:28] Since it is not a comment [22:13:33] it's a line "FIXME: Uncomment when bug 62512 is resolved" [22:13:43] is FIXME treated like Feature ? [22:13:56] it's just a string [22:14:01] Could it be FIXME: Add tags @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @test2.m.wikipedia.org when bug 62512 is resolved [22:14:16] chrismcmahon: or would those be picked up as tags? [22:14:30] jdlrobson: no, because jenkins will read "@en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @test2.m.wikipedia.org" and try to run the tests. [22:14:41] ok but FIXME: Add tags en.m.wikipedia.beta.wmflabs.org en.m.wikipedia.org test2.m.wikipedia.org when bug 62512 is resolved [22:14:43] would be fine? [22:14:51] jdlrobson: no [22:14:54] no? [22:15:07] jdlrobson: remove the target env tags completely [22:15:15] chrismcmahon: i /understand/ that [22:15:17] Jenkins doesn't know from FIXME [22:15:25] i'm trying to understand how the parser works [22:15:35] you say it's just a string - but it seems the string doesn't get picked up by the parser [22:16:38] If I had Feature: @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @test2.m.wikipedia.org would jenkins run those too? [22:16:46] (as if they were tags) [22:16:59] jdlrobson: yes, but Cucumber would barf on that line [22:17:29] So why doesn't cucumber barf on the line you've added "FIXME: Uncomment when bug 62512 is resolved" [22:18:03] jdlrobson: because the FIXME line does not begin with "Feature" or Scenario" [22:19:38] okay but Jenkins knows nothing about Feature or Scenario [22:19:42] and it just looks for @ symbols? [22:19:55] so I could have @en.m.wikipedia.org at the bottom of the feature file and it would still work? [22:20:27] mhurd: i want to card agin on the design board. its making too hard to read designs that had been finalized a bit ago [22:20:34] mhurd: objections ? [22:20:52] (03CR) 10Awjrichards: [C: 032] i18n: Tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117012 (owner: 10Jdlrobson) [22:20:56] tfinc: i don't understand the question [22:21:05] chrismcmahon: sorry i'm keen to make sure i completely understand this for future :-) and i'm keen to wrap this up so the tests pass again [22:21:19] mhurd: i want to turn off card aging [22:21:29] (03Merged) 10jenkins-bot: i18n: Tweaks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117012 (owner: 10Jdlrobson) [22:21:35] thanks awjr [22:21:37] tfinc: ah! no objection from me [22:22:22] tfinc: "i want to card agin" was kind of cryptic ;) [22:22:34] mhurd: ha, yeah that got cut off [22:22:38] also chrismcmahon why doesn't Jenkins barf on L4 and L5 - should they also be deleted? [22:23:49] jdlrobson: they should probably be deleted, but Jenkins only cares about @foo tags. not sure why Cucumber tolerates those #FIXME lines [22:24:02] ok i'll clean that up now [22:24:50] chrismcmahon: also can you take a look at https://gerrit.wikimedia.org/r/#/c/118017/1 ? [22:25:18] chrismcmahon: not really sure how to deal with FIXME's in features though.. [22:25:22] they are useful [22:26:05] (03PS3) 10Jdlrobson: QA: Stop no JS site test running on Cloudbees [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118018 [22:26:11] ^ chrismcmahon trust that is better? [22:26:45] (03CR) 10Cmcmahon: [C: 032] QA: Rewrite now missing rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118017 (owner: 10Jdlrobson) [22:27:09] jdlrobson: fwiw, I think FIXMEs aren't very nice, would rather see clean code and a BZ ticket [22:27:24] (03Merged) 10jenkins-bot: QA: Rewrite now missing rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118017 (owner: 10Jdlrobson) [22:27:50] chrismcmahon: Agreed FIXME's are nasty - but that's their value in my opinion. They encourage hard things to get fixed as they are in the code itself rather than in Bugzilla [22:27:56] but i understand this is a divided camp :) [22:28:26] (03CR) 10Cmcmahon: [C: 032] "don't run this in the build for now" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118018 (owner: 10Jdlrobson) [22:28:26] from my perspective though the code is the thing, so it should be a reference for everything [22:29:02] (03Merged) 10jenkins-bot: QA: Stop no JS site test running on Cloudbees [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118018 (owner: 10Jdlrobson) [22:29:49] (03CR) 10Cmcmahon: [C: 032] Hygiene: Kill that 'I am on the User login page' rule in QA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116900 (owner: 10Jdlrobson) [22:30:01] thanks chrismcmahon \o/ hope this turns those green! [22:30:26] (03Merged) 10jenkins-bot: Hygiene: Kill that 'I am on the User login page' rule in QA [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116900 (owner: 10Jdlrobson) [22:49:05] MaxSem: Y U ABANDON [22:49:53] YuviPanda: how are your hands today ? [22:50:03] s/hands/wrists [22:50:29] tfinc: better. I have painkillers now. And a cream thingy. [22:50:37] * tfinc ponders wether he and greg-g will have to regulate and tell YuviPanda to put down the keyboard [22:50:48] tfinc: not today! [22:52:25] YuviPanda, UNSALVAGEABLE [22:52:44] MaxSem: awww [22:53:39] and Brad's advice was problematic too [22:53:52] (03CR) 10Cmcmahon: [C: 032] Hygiene: Kill RandomPage in favour of ArticlePage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117371 (owner: 10Jdlrobson) [22:54:02] will have to think further about it [22:54:54] (03Abandoned) 10Cmcmahon: QA: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117857 (owner: 10Zfilipin) [23:19:32] anyone willing to pull the trigger? :D https://gerrit.wikimedia.org/r/#/c/116147/ [23:20:46] MaxSem: :( [23:21:10] DarTar: hey can you check this out - https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1699 [23:21:35] we added revids to the schema but I wanted to make sure that it makes sense to you before signing off [23:24:31] MaxSem: I always am [23:24:37] dr0ptp4kt: can i have permission to do so [23:25:29] kaldari: https://gerrit.wikimedia.org/r/117008 ! [23:25:37] or MaxSem [23:25:40] i fixed your issue! [23:26:13] MaxSem, jdlrobson, that's ok. [23:26:28] ok MaxSem reviewing ;-) [23:32:57] kenanwang, jdlrobson: I saw it, but it's not yet in prod right? [23:33:08] (rebids added to schema) [23:33:08] DarTar: it's on beta labs [23:33:43] DarTar: we don't' have EventLogging there though i guess? [23:33:44] I love that my mac os spellchecker autoreplaces rev_ids with rebids [23:33:51] not sure if it can be logged to some text file [23:34:25] we have a separate EL instance but I have no idea where to find the data [23:34:46] (03CR) 10Jdlrobson: [C: 032] "Make Max dance." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116147 (owner: 10MaxSem) [23:35:30] (03Merged) 10jenkins-bot: Kill WAP and dance on its grave [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116147 (owner: 10MaxSem) [23:35:41] jdlrobson: can you guys check with Ori where the data lives? I checked the log db and didn't see any event and I doubt it's in the JSON dumps on stat1 [23:35:47] (03PS9) 10Jdlrobson: QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 [23:36:00] I can ping him if that helps [23:36:07] DarTar: yeh he's not in office [23:36:16] so if you could ping him that would be great [23:36:23] (03PS4) 10Jdlrobson: Fix nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117126 [23:36:44] jdlrobson: will do [23:36:45] awjr: we never got https://bugzilla.wikimedia.org/62294 into mingle.. [23:37:30] jdlrobson: feel free to add it, i wont be able to adjust bingle to pick it up before the end of today [23:38:30] awjr: ok [23:45:56] (03PS1) 10Dr0ptp4kt: Shake it up. Shake to get a random article. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 [23:49:28]