[00:01:09] (03PS2) 10Jdlrobson: Remember user choice (mobile/desktop) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117699 (owner: 10Kelson) [00:01:12] (03PS3) 10Jdlrobson: Remember user choice (mobile/desktop) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117699 (owner: 10Kelson) [00:01:34] (03CR) 10jenkins-bot: [V: 04-1] Remember user choice (mobile/desktop) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117699 (owner: 10Kelson) [00:02:26] (03CR) 10Jdlrobson: [C: 04-1] "Existing tests in tests/MobileContextTest.php fail for me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117699 (owner: 10Kelson) [00:02:50] brion: how goes working on https://trello.com/c/EWYfk6l7/11-android-dev-version-no-edit-button-for-lead-section ? [00:02:59] (03CR) 10Jdlrobson: "(To run the tests locally run" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117699 (owner: 10Kelson) [00:03:19] (03PS7) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [00:30:37] (03PS1) 10Kaldari: Make sure Minerva is registered as a valid skin. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118037 [00:32:50] (03PS2) 10Kaldari: Make sure Minerva is registered as a valid skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118037 [00:35:09] (03PS3) 10Kaldari: Make sure Minerva is registered as a valid skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118037 [00:35:14] (03CR) 10jenkins-bot: [V: 04-1] Make sure Minerva is registered as a valid skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118037 (owner: 10Kaldari) [00:35:20] (03PS4) 10Kaldari: Make sure Minerva is registered as a valid skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118037 [00:44:53] (03PS5) 10Kaldari: Make sure Minerva is registered as a valid skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118037 [01:01:39] (03CR) 10Jdlrobson: [C: 04-1] Make sure Minerva is registered as a valid skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118037 (owner: 10Kaldari) [01:03:21] (03PS6) 10Kaldari: Make sure Minerva is registered as a valid skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118037 [01:03:48] (03PS7) 10Jdlrobson: Make sure Minerva is registered as a valid skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118037 (owner: 10Kaldari) [01:04:16] (03CR) 10Jdlrobson: [C: 032] Make sure Minerva is registered as a valid skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118037 (owner: 10Kaldari) [01:04:58] \o/ [01:05:26] (03Merged) 10jenkins-bot: Make sure Minerva is registered as a valid skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118037 (owner: 10Kaldari) [01:11:13] heads up awjr MaxSem tfinc http://en.wikipedia.beta.wmflabs.org/wiki/Forty-seven_Ronin?useskin=minerva is going to work soon :D [01:11:22] now in fact :D [01:11:55] jdlrobson: today us a good day to see the word useskin=minerva [01:11:57] :) [01:12:10] we just suppress it in Special:Preferences [01:12:22] i'll send an update to mobile-l [01:12:58] actually i'll do that tomorrow i want to go home now [01:18:40] jdlrobson: thanks for the good work. when do i get to see this live ? [01:18:50] i want to see people testing various pages with it [01:18:55] tfinc: kaldari hit the switch [01:19:09] thursday on mediawiki.org, a week on enwiki [01:19:09] excellent. then it'll be fun to see in ja as well :D [01:19:26] just before i take off then [01:20:05] (03PS1) 10Kaldari: Remove CSS for oojs-ui that is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118047 [01:20:33] (03PS2) 10Kaldari: Remove CSS for oojs-ui that is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118047 [01:21:30] (03PS3) 10Kaldari: Remove CSS for oojs-ui that is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118047 [07:39:47] (03PS1) 10Yuvipanda: Use .equals not == for comparing strings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118054 [08:10:43] prtksxna: hello! are you there? [08:10:53] is chicken down? [08:11:03] was just doing some quick testing for navigation popups [08:13:48] prtksxna: no worries, it works [08:13:58] everything is looking quite nice [08:26:42] vbamba: o/ [08:26:57] vbamba: Everything *should* be working fine [08:34:19] (03CR) 10Zfilipin: [C: 04-1] Hygiene: Address QA FIXME (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117370 (owner: 10Jdlrobson) [08:42:41] (03PS1) 10Yuvipanda: Add simple Edit Summary option to preview window [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118057 [08:46:30] Hello! [08:46:47] I sent you and YuviPanda a svcreenshot [08:46:57] * yuvipanda|web waves at vbamba [08:47:07] YuviPanda =] [08:47:08] vbamba: sorry, other account is having issues at the moment [08:47:24] YuviPanda: said this should not be happening on chicken either [08:47:31] vbamba: let me show you a screenshot of the edit summary stuff I have. [08:47:43] vbamba: oh, it will be happening on chicken. betalabs it shouldn't be happening. [08:48:15] YuviPanda: are you certain? [08:48:17] vbamba: we don't have the co-ordinate handling extension deployed on chicken, which is why this is happening. I can fix it later this week when I have ti me. [08:48:32] no no its fine, as long as you are certain [08:48:40] vbamba: yeah. quite certain :) [08:49:18] this kind of thing is supposed to be handled in design review - but if you are certain then i trust you [08:49:50] vbamba: :) I'll fix it on chicken also in a few days [08:50:19] vbamba: https://www.dropbox.com/s/7q9seve7uozfequ/Screenshot_2014-03-11-14-19-01.png for now. [08:50:37] vbamba: I can talk about this when you wake up if you want too :) No urgency. [08:50:53] looks good! [08:51:22] talk tomorrow? Think the help text can carry some examples? [08:51:35] vbamba: oh definitely. I was going to ask you to help figure out where to putthose [08:51:51] vbamba: I'll finish up the autocomplete stuff also and mail you a build so you can feel/test it and figure things out [08:51:51] excellent [08:51:54] talk tomorrow then [08:52:00] vbamba: good night! [08:52:44] prtksxna: ping? can you try enabling the 'geodata' role on chicken? [08:52:53] prtksxna: you know a few people have said the popup can be smaller, but we can always change that. I'm really excited to see what people say - whether the behavior is intrusive or 'just in time and good enough' [08:54:31] We could set a smaller char limit and see if that meets the information needs of the user. [08:54:38] anyhow, more tomorrow! [08:54:44] :^) [08:54:45] hmm [08:54:50] yuvipanda|web: pong [08:54:56] adios! [08:55:07] prtksxna: bong [08:55:49] vbamba: o/ [08:55:54] oh [08:56:21] YuviPanda: I am enabling…just a second [08:56:44] prtksxna: ok [08:57:08] prtksxna: you might also have to purge the page vibha pointed to (append ?action=purge to the URL of the target pages) [08:58:02] yuvipanda|web: You mean on chicken? [08:58:10] prtksxna: ya [08:58:20] drat [09:00:47] prtksxna: bah, stupid keyboard misbehaving. brb [09:27:50] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116156 (owner: 10JGonera) [09:31:29] (03PS1) 10Yuvipanda: Make sure section header is specified by default in edit summary [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118059 [09:53:59] (03PS2) 10Yuvipanda: Add simple Edit Summary option to preview window [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118057 [09:58:24] (03Abandoned) 10Yuvipanda: Make sure section header is specified by default in edit summary [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118059 (owner: 10Yuvipanda) [15:43:51] (03PS3) 10Zfilipin: QA: Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112675 [15:45:57] (03CR) 10Zfilipin: "I am not sure what to do here. Should we just abandon this commit?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112675 (owner: 10Zfilipin) [17:18:28] (03CR) 10Siebrand: [C: 032 V: 032] "No Jenkins here, it seems." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118098 (owner: 10L10n-bot) [17:20:25] Hi, I'm asked if there are plans for an update to the iOS Wikipedia app that better integrates into the iOS 7 interface. Can you help? [17:21:37] YuviPanda: hey! [17:22:18] pajz: yes! we are ~80% done with just such an update [17:22:55] brion: hey! [17:23:03] mhurd, great :). already have some rough release date in mind? [17:23:30] mornin [17:24:32] pajz: the rough timeline is here: https://www.mediawiki.org/wiki/Q3_mobile_app_timeline [17:24:49] pajz: aiming for 1st market release late april [17:24:49] (03CR) 10Jdlrobson: [C: 04-1] Remove CSS for oojs-ui that is no longer needed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118047 (owner: 10Kaldari) [17:25:16] brion: up to a bit o' review? :) [17:25:28] it's review o' clock! [17:25:50] mhurd, thanks a lot! [17:25:50] brion: haha well here ya go: https://www.mediawiki.org/wiki/Q3_mobile_app_timeline [17:25:50] oops [17:25:50] try this one: https://gerrit.wikimedia.org/r/#/c/117628/ [17:26:33] pajz: you're welcome! [17:26:46] mhurd: oh -- Xcode 5.1 final is out if you haven't already updated to it [17:27:08] brion: ah! will do so now! hopefully my diff viewer crash is gone!!! [17:27:14] one hopes :D [17:27:26] and iOS 7.1 final as well [17:27:33] i upgraded all my machines, no explosions so far :D [17:27:47] brion: yay! [17:32:57] * brion looks for stray strings :D [17:33:29] (03PS1) 10Nemo bis: [Keep going] Make linkification advice less newbie-error-prone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118103 [17:35:19] ok looks good [17:35:36] bah gerrit signed me out [17:35:45] WHY COOKIES NO FOREVER [17:35:55] (03CR) 10Brion VIBBER: [C: 032 V: 032] Migrate strings to qqq file. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117628 (owner: 10Mhurd) [17:36:13] hehe https://gerrit.wikimedia.org/r/#/c/118027/ - shake to random :D [17:36:15] i gotta try this [17:38:29] (03CR) 10Brion VIBBER: [C: 04-1] "I love the random feature, but I'm not so hot on the shake activation; I worry it's hard to discover on purpose and easy to trigger by acc" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 (owner: 10Dr0ptp4kt) [17:39:14] mhurd: there was a note that https://gerrit.wikimedia.org/r/#/c/117127/ might not be needed with the other localization update patch in? is that correct or should i try to poke it? [17:41:57] (03CR) 10Dr0ptp4kt: "On it." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 (owner: 10Dr0ptp4kt) [17:44:35] brion: adam's on it [17:44:42] spiff [17:44:46] (03Abandoned) 10Dr0ptp4kt: Set searchbar (localized) "Search Wikipedia" if W0 transitions to off. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/117127 (owner: 10Dr0ptp4kt) [17:45:05] brion ^ [17:45:12] (abandoned) [17:45:16] ok [17:45:38] brion: i had same concern and adam's adding random to the menu for now until we can talk more about shakiness :) [17:48:14] whee [17:52:49] (03PS1) 10Jdlrobson: Ensure the languages button is present after an edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118104 [17:52:55] (03PS1) 10Jdlrobson: Docs: Update the README file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118105 [17:53:20] mhurd: hey! [17:53:31] YuviPanda: yo! [17:54:27] mhurd: chat in about 5min I think? [17:54:35] YuviPanda: ya [17:57:03] hey brion [17:57:08] hey hey [17:57:14] brion: I finally got a couple of patches in. lots more talking these days [17:57:21] whee [17:57:25] * brion breaks out some review-fu [17:59:54] (03PS2) 10Jdlrobson: i18n: Make linkification advice less newbie-error-prone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118103 (owner: 10Nemo bis) [18:00:00] (03CR) 10Jdlrobson: [C: 032] "Thanks Nemo!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118103 (owner: 10Nemo bis) [18:00:08] (03CR) 10Brion VIBBER: "Hmm... will this reliably pick up the redirect so an en.wikipedia.org link will be able to bring up the app?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/117834 (owner: 10Yuvipanda) [18:00:19] brion: yeah seems to [18:00:38] (03Merged) 10jenkins-bot: i18n: Make linkification advice less newbie-error-prone [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118103 (owner: 10Nemo bis) [18:00:47] YuviPanda: so if i understand with Chrome or Browser that'll first open the browser, then redirect you and prompt you to open Wikipedia [18:00:55] brion: ah, hmm [18:00:56] with Firefox, I don't think the redirect will prompt you [18:01:05] brion: in a meeting with monte, so brb [18:01:08] ok [18:01:16] i'll peek at the others in the meantime [18:03:25] brion: ok! I can make that undependent if we want [18:04:11] (03CR) 10Brion VIBBER: [C: 031] "(needs decoupling from possibly broken parent commit)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118054 (owner: 10Yuvipanda) [18:04:21] (03PS1) 10Jdlrobson: QA: Actually run KeepGoing tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118108 [18:04:35] ^ awjr i see you removed the tags but you only needed to remove the testwiki tag [18:04:51] android:textColor="#666" omg :) [18:05:02] brion: :P [18:05:07] hmm i think i had a reason [18:06:45] jdlrobson: keepgoing is being a/b tested, right? [18:06:52] awjr: no [18:07:09] orly [18:07:18] not that one anyway [18:07:59] oh, then i misinterpreted what was going on [18:08:01] logic is: inBetaOrAlpha && mw.config.get( 'wgMFKeepGoing' ) && ( this.editCount === 0 || inKeepGoingCampaign ) [18:08:07] i removed all the env tags because i thought it was getting a/b tested [18:08:23] confusingly it's being beta tested from left nav [18:08:26] but not in this context [18:08:33] ok that makes sense [18:08:57] (03CR) 10Awjrichards: [C: 032] QA: Actually run KeepGoing tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118108 (owner: 10Jdlrobson) [18:09:12] jdlrobson: while we're on the subject, any thoughts about the ve-related test failure? [18:09:38] (03Merged) 10jenkins-bot: QA: Actually run KeepGoing tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118108 (owner: 10Jdlrobson) [18:10:17] awjr: i'm looking into it - seems to be usually due to timeouts.. [18:10:52] we could just extend the timeouts to be considerably larger when it comes to VE [18:10:57] jdlrobson: yeah, i had seen problems previously with that and VE, things can take quite a while particularly locally and on betalabs [18:11:07] that might be worth a shot [18:12:58] (03CR) 10Brion VIBBER: "java.lang.ClassNotFoundException: Didn't find class "org.wikipedia.styledviews.StyledAutocompleteEditText" on path: DexPathList[[zip file " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118057 (owner: 10Yuvipanda) [18:13:07] brion: bah, let me add [18:13:23] :D [18:15:34] YuviPanda: https://en.wikipedia.org/w/index.php?title=Charik&curid=13110153&diff=599164710&oldid=589134070 [18:15:35] awjr: patch on the way [18:18:22] awjr: jdlrobson beta labs was very slow earlier, but that's been fixed. there were a lot of bogus timeouts [18:19:00] chrismcmahon: the mobile/ve-related timeouts aren't really a new thing, we've been seeing that on betalabs for a long time [18:19:21] hopefully beta will be a bit zippier today [18:19:40] it was exceptionally slow from yesterday until this morning [18:19:54] (03PS1) 10Jdlrobson: Hygiene: Lift and shift editor code to correct step files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118115 [18:19:56] (03PS1) 10Jdlrobson: QA: Avoid VisualEditor timeout test failures on beta labs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118116 [18:20:00] ^ chrismcmahon awm-bot2 this won't hurt though [18:20:04] awjr: rather [18:20:10] heh [18:20:14] cool chrismcmahon [18:20:21] Should definitely test that the overlay closes before checking for the toast [18:22:26] mhurd: https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Guild_of_Copy_Editors [18:23:20] mhurd: https://en.wikipedia.org/w/index.php?namespace=0&tagfilter=&hideliu=1&title=Special%3ARecentChanges [18:23:23] (03PS3) 10Jdlrobson: Hygiene: Move I click the watch star to appropriate home [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117370 [18:23:31] also chrismcmahon awjr https://gerrit.wikimedia.org/r/#/c/117371/ is +2ed but none of its dependencies are - https://gerrit.wikimedia.org/r/#/c/116692/7 and https://gerrit.wikimedia.org/r/#/c/117370/ [18:24:13] (03CR) 10Jdlrobson: Hygiene: Move I click the watch star to appropriate home (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117370 (owner: 10Jdlrobson) [18:24:23] mhurd: https://en.wikipedia.org/w/index.php?title=Shutter_Island_(film)&curid=13950959&diff=599168613&oldid=598110995 [18:25:11] (03PS1) 10Jdlrobson: Enable Special:MobileMenu for Vector skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118118 [18:27:01] mhurd: https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Climbing [18:32:41] brion: rebased and updated [18:32:42] (03PS2) 10Yuvipanda: Use .equals not == for comparing strings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118054 [18:32:44] (03PS3) 10Yuvipanda: Add simple Edit Summary option to preview window [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118057 [18:32:47] (03CR) 10Cmcmahon: [C: 032] Hygiene: Move I click the watch star to appropriate home [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117370 (owner: 10Jdlrobson) [18:34:01] (03Merged) 10jenkins-bot: Hygiene: Move I click the watch star to appropriate home [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117370 (owner: 10Jdlrobson) [18:34:03] (03CR) 10Cmcmahon: [C: 032] Hygiene: Group together main menu navigation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 (owner: 10Jdlrobson) [18:34:15] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Group together main menu navigation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 (owner: 10Jdlrobson) [18:34:38] (03CR) 10MaxSem: Enable Special:MobileMenu for Vector skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118118 (owner: 10Jdlrobson) [18:35:41] (03CR) 10MaxSem: [C: 032] Docs: Update the README file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118105 (owner: 10Jdlrobson) [18:35:42] YuviPanda: time now? [18:35:47] mhurd: sure [18:35:58] mhurd: loading up gmail, moment [18:36:40] mhurd: am calling [18:36:40] now [18:41:17] mhurd: http://browserify.org/ [18:42:48] mhurd: https://github.com/wikimedia/apps-android-wikipedia/tree/master/www/js [18:47:50] mhurd: https://github.com/wikimedia/apps-android-wikipedia/tree/master/www [18:48:04] mhurd: https://github.com/wikimedia/apps-android-wikipedia/blob/master/www/Gruntfile.js [18:49:39] mhurd: https://github.com/wikimedia/apps-android-wikipedia/blob/master/wikipedia/assets/bundle.js [18:50:51] YuviPanda: lost u? [18:50:56] no audio [18:51:53] mhurd: I must have lost you [18:52:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] Use .equals not == for comparing strings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118054 (owner: 10Yuvipanda) [18:54:59] mhurd: https://github.com/wikimedia/apps-android-wikipedia/tree/master/www/less [18:55:34] mhurd: https://github.com/wikimedia/apps-android-wikipedia/blob/master/www/Gruntfile.js#L57 [19:03:03] (03CR) 10Brion VIBBER: [C: 032 V: 032] "it worrrrks" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118057 (owner: 10Yuvipanda) [19:03:21] brion: mhurd and me just talked about sharing iOS and Android code [19:04:35] YuviPanda: for the JS, the CSS< or some combo? [19:04:46] brion: both [19:04:49] nice [19:04:52] brion: yeah [19:05:10] do we need to add a repo for the shared code and git submodule it, or something? [19:07:53] brion: yeah, probably. can live in android for now. [19:08:01] brion: eventually they will mostly live in extensions/MobileApp [19:08:31] ok [19:08:47] so are we going to fetch them at first runtime, or include an initial version? [19:08:56] initial display won't do much if we're offline anyway so may as well fetch them i guess :D [19:12:23] brion: initial version, then update now and then [19:12:25] brion: we don't lose much and it should be easy enough [19:12:42] excellent [19:13:32] brion: YuviPanda: errands/lunchtime! back in hr [19:13:42] ooh it is lunchtime isn't it [19:13:46] * brion nom nom nom [19:13:47] mhurd: you are going to be back as Human Resources? :P [19:13:51] brion: ya! [19:13:59] heh [19:14:07] YuviPanda: lol [19:14:15] *hour* [19:21:40] (03PS3) 10Dr0ptp4kt: Shake to get a random article. See bullet points. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 [19:23:05] ^ brion, i'm actually going to follow up with a different patchset, mhurd recommended just making 'Random' a tappable thing in the settings so that the user can get a random article that way for the time being. so i'll set it up so that it isn't actually a setting (app nor settings app app-specific), but rather a tappable thing. [19:23:57] dr0ptp4kt: sounds good [19:38:19] hi violetto [20:08:18] hi violetto [20:12:35] (03PS1) 10Yuvipanda: [WIP] Add bundle output JS for iOS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118137 [20:14:14] hi violetto1 [20:15:45] violetto1: sup [20:19:26] sup [20:19:33] YuviPanda: whatcha workin on [20:19:39] hi violetto [20:19:43] i mean, hi violetto1 [20:20:42] YuviPanda: are you still at bhopal [20:20:58] violetto1: I am. here for a week. found a place with good internet. [20:21:12] violetto1: am reading through the page you sent me. woo! [20:21:29] (03PS4) 10Dr0ptp4kt: Random articles. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 [20:22:17] violetto: the entire left drawer thing is super confusing since we will be having a completely different thing for the first release [20:22:19] violetto1: ^ [20:22:33] violetto: but it's fine. I like the page! :) [20:22:49] YuviPanda: ya! im thinking about things hollistically. it'll be tailored for mvp on trello [20:22:58] YuviPanda: but that's like eventually [20:23:09] violetto1: yeah, that makes sense. We should mention that in the top of the page somewhere prominently to prevent people complaining though [20:23:25] YuviPanda: okay [20:23:32] violetto1: that this is a 'end' goal, and not a 'what we are working on right now for the immediately next release' thing [20:23:47] YuviPanda: okay that's a good idea [20:24:05] violetto1: yeah. you can also say 'for what we are working on right now see trello' [20:24:22] oh yeah, that'll be great [20:24:25] YuviPanda: [20:24:28] violetto1: :) [20:25:08] violetto1: I also like the numbered images to make it easier to refer to them. Dunno how much work it is for you tho [20:25:30] YuviPanda: do once and then copy paste! [20:25:37] violetto1: :) [20:26:09] but clarity = happier readers ;P [20:26:14] violetto1: :) [20:26:19] YuviPanda: worth the work so it's fine [20:26:22] brion & mhurd: https://gerrit.wikimedia.org/r/118027 ready for review. mhurd, i believe this is what you were looking for? [20:26:32] gotta change connections [20:26:40] excellent [20:26:42] lemme test [20:26:49] violetto1: :) [20:27:13] hey vbamba [20:27:27] hi YuviPanda [20:28:35] vbamba: https://www.dropbox.com/s/7q9seve7uozfequ/Screenshot_2014-03-11-14-19-01.png [20:30:17] oh nice, looking [20:30:29] where does a user type in the summary? [20:30:46] where it says 'Heloo world' ? [20:30:49] vbamba: the bottom. tapping any part of it puts the focus on the edit-text. [20:30:57] vbamba: that's just the preview. It's a junk page I use to test on [20:32:42] (03CR) 10Brion VIBBER: [C: 04-1] "It seems to try to load pages from en.wikipedia.org even though my language setting is on test and it's fetching random titles from test.." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 (owner: 10Dr0ptp4kt) [20:34:39] vbamba: I just picked a random grey for the text there (#666). I also am working on making it 'slide in' [20:34:39] vbamba: there's also some comments/questions from me/may on the design trello board about the editing workflow for anons [20:36:08] YuviPanda: so tapping anywhere in that field will bring up the keyboard? [20:36:18] vbamba: yup. [20:37:09] Do you know if there a character limit to the edit summary in desktop? [20:37:36] vbamba: maybe 255, I don't know. I am checking now. [20:38:54] yeah, doesnt let me paste beyond a point [20:38:57] checking how many chars [20:39:07] vbamba: 255bytes. [20:39:08] (03CR) 10Kaldari: [C: 032] QA: Avoid VisualEditor timeout test failures on beta labs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118116 (owner: 10Jdlrobson) [20:39:11] vbamba: I just checked. [20:39:16] vbamba: I can add that limit here too. [20:39:20] same thing for you? [20:39:31] 255 bytes - do we know how that maps to characters? [20:39:32] vbamba: I just checked the code :D [20:39:42] (03CR) 10Brion VIBBER: "Hmm no it's loading from the right domain, or ..... should be .... but frequently I see an error:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 (owner: 10Dr0ptp4kt) [20:39:45] YuviPanda: smarter than me =] [20:39:53] vbamba: not particularly. It depends on language, and which characters are being used in that language. [20:40:46] I dont think this is a priority for now, cos most summaries on article pages seem small enough [20:41:03] vbamba: yeah, and I am pretty sure I can actually limit it to 255bytes directly in code without having to worry about char -> byte conversion. [20:41:11] vbamba: good catch though. I wasn't thinking about it :) [20:41:14] but do you think we should have a character counter visible below the field? [20:41:23] or shd we just stop dead once you hit 255 chars? [20:41:31] like desktop has no indication [20:41:47] vbamba: we should just stop. I think that's fair enough. 255 bytes is a lot, and most people don't hit it. [20:41:49] (03CR) 10Yurik: [C: 032] HTTPS UI for applicable Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik) [20:41:53] (03CR) 10Kaldari: Remove CSS for oojs-ui that is no longer needed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118047 (owner: 10Kaldari) [20:41:55] (03Merged) 10jenkins-bot: HTTPS UI for applicable Wikipedia Zero configurations. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/113655 (owner: 10Yurik) [20:42:02] I dont think its high priority, Im ok with just truncating at 255 bytes for now [20:42:10] ok, resolved! [20:42:20] jdlrobson: Please see comment at https://gerrit.wikimedia.org/r/#/c/118047/3/less/modules/editor/VisualEditorOverlay.less. Thanks [20:42:28] making a note on trello card [20:42:29] will do kaldari ! [20:42:51] vbamba: :) [20:42:51] ok, what are the anon edit questions? [20:43:36] vbamba: see comments from me and may at https://trello.com/c/zHmmH2xT/74-design [20:48:15] looking, just a minute [20:48:35] Benefits of Signing in has new copy - I reviewed this with kenan [20:48:41] Adding to Trelli [20:51:42] (03PS1) 10Yuvipanda: Don't let users type more than 255char long edit summary [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118198 [20:52:10] vbamba: sweet [20:52:23] vbamba: have a makeshift 255char limit implemented ^ [20:55:50] vbamba: also, for edit summary - I am going to be adding a 1. slide up animation when it first shows, 2. Autocomplete for previously entered edit summaries. [20:55:53] vbamba: anything else? [20:56:04] nice, ive added all the copy options - Kenan is currently recommending that we go with A [20:56:44] YuviPanda: can you show me how it works once you have it up? [20:56:53] the autocomplete stuff you describe [20:57:04] vbamba: I like A too, except for 'co-editors'. Maybe it's just my brain, but it doesn't really seem to register properly. 'other editors' perhaps? [20:57:06] vbamba: yeah, sure! [20:57:26] vbamba: it's the same as desktop, really. Once you enter an edit summary once, the next time you start typing it your browser autocompletes it for you [20:57:41] ok, sure. [20:59:02] vbamba: alright, let me finish up autocomplete. I can send you a build after that. do you have an android device? [20:59:26] vbamba: also, the card mentions 'sound effects'. [20:59:49] vbamba: I thought we wanted to have sound effects only when you save an edit? [21:17:36] YuviPanda: Just talking to mhurd, replying to other comments in a few [21:18:08] (03PS1) 10JGonera: Remove display: none for link inspector in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118203 [21:18:21] vbamba: ah, ok! :) [21:22:21] (03PS1) 10JGonera: Remove unnecessary surface padding in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118204 [21:22:43] mhurd: https://gerrit.wikimedia.org/r/#/c/118137/ [21:26:58] kaldari, jdlrobson a very small patch that I need to work on the link inspector: https://gerrit.wikimedia.org/r/#/c/118203/ [21:27:28] another one: https://gerrit.wikimedia.org/r/118204 [21:27:28] both CSS only [21:31:29] (03CR) 10Kaldari: [C: 032] Remove unnecessary surface padding in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118204 (owner: 10JGonera) [21:32:39] (03CR) 10Kaldari: [C: 032] Remove display: none for link inspector in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118203 (owner: 10JGonera) [21:33:14] netsplit [21:33:24] (03Merged) 10jenkins-bot: Remove display: none for link inspector in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118203 (owner: 10JGonera) [21:33:26] (03Merged) 10jenkins-bot: Remove unnecessary surface padding in VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118204 (owner: 10JGonera) [21:38:32] YuviPanda: thanks for the commit link! will try to hack at it in next few days :) [21:39:55] mhurd: :) [21:39:55] ok! [21:43:45] mhurd - 'A Specific summary for important changes helps co editors quickly review your edits. Or you could select from the tags below' [21:56:07] (03PS5) 10Jdlrobson: Fix nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117126 [21:57:39] (03PS9) 10Jdlrobson: Hygiene: Group together main menu navigation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 [21:58:05] (03CR) 10Jdlrobson: [C: 032] "Chris +2ed simply rebased." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 (owner: 10Jdlrobson) [21:58:43] (03Merged) 10jenkins-bot: Hygiene: Group together main menu navigation tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116692 (owner: 10Jdlrobson) [22:03:07] (03PS2) 10Jdlrobson: Docs: Update the README file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118105 [22:03:20] (03CR) 10Jdlrobson: [C: 032] "Cherry picked so this can be merged" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118105 (owner: 10Jdlrobson) [22:04:02] (03Merged) 10jenkins-bot: Docs: Update the README file [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118105 (owner: 10Jdlrobson) [22:07:59] (03CR) 10Cmcmahon: [C: 032] Hygiene: Lift and shift editor code to correct step files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118115 (owner: 10Jdlrobson) [22:08:38] (03Merged) 10jenkins-bot: Hygiene: Lift and shift editor code to correct step files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118115 (owner: 10Jdlrobson) [22:08:41] (03Merged) 10jenkins-bot: QA: Avoid VisualEditor timeout test failures on beta labs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118116 (owner: 10Jdlrobson) [22:09:44] (03PS2) 10Jdlrobson: Hygiene: Kill RandomPage in favour of ArticlePage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117371 [22:09:46] (03PS1) 10Jdlrobson: Hygiene: Remove undefined test and unused rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118209 [22:09:48] (03CR) 10Dr0ptp4kt: "To get this thing running, I did need to set the "CurrentArticleDomain" keypath to "en" in AppDelegate.m. The reason being that it wasn't " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 (owner: 10Dr0ptp4kt) [22:10:17] (03PS8) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [22:10:31] (03CR) 10Jdlrobson: "Bueller..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 (owner: 10Jdlrobson) [22:14:18] (03CR) 10Jdlrobson: [C: 032] "My bad I needed to update core." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118047 (owner: 10Kaldari) [22:14:55] (03Merged) 10jenkins-bot: Remove CSS for oojs-ui that is no longer needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118047 (owner: 10Kaldari) [22:16:59] brion, just got back on irc. i responded on https://gerrit.wikimedia.org/r/#/c/118027/ [22:17:30] ^mhurd, i named you in the response [22:17:42] just throw foam things at me [22:19:38] (03CR) 10Mhurd: "I'll kick the tires on this and see if I can unwrap that weird behavior after I wrap these last 2 sprint stories." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 (owner: 10Dr0ptp4kt) [22:20:02] thx mhurd [22:20:11] dr0ptp4kt: np! [22:20:53] whee [22:22:32] running a search first doesn't seem to help much for me... i can instrument the random path to log the page it's trying to load, and i can search for that page afterwards... [22:22:37] (03PS6) 10Jdlrobson: Fix nearby pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117126 [22:23:05] (03CR) 10Jdlrobson: Fix nearby pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117126 (owner: 10Jdlrobson) [22:23:24] sometimes it just doesn't come up... weird [22:24:18] whoops, now i've got validation errors in my coredata [22:24:22] ok i don't know what the hell happened :D [22:26:07] (03PS10) 10Kaldari: QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [22:26:09] (03PS9) 10Kaldari: Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [22:26:14]