[00:13:30] (03PS1) 10Dr0ptp4kt: Random articles. Because people like it on Android, too. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118221 [00:25:02] violetto: https://gerrit.wikimedia.org/r/#/c/117903/3 < i'm going to need some nice svg icons from you for these. are you up for the job? [00:33:45] (03PS2) 10Dr0ptp4kt: Random articles. Because Androids like it, too. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118221 [00:56:01] (03PS10) 10Kaldari: Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [00:56:29] (03CR) 10jenkins-bot: [V: 04-1] Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [10:31:24] (03Abandoned) 10MaxSem: Suppress edit links from a remote repository on file pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115995 (owner: 10MaxSem) [13:05:05] [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/Gj4vqw [13:05:05] 13WikipediaMobile/06master 14b184d5e 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [15:35:52] prtksxna: give address [15:36:15] zz_yuvipanda: Pick it up from https://gist.github.com/prtksxna/f834f63646d8b66e230f [15:36:38] prtksxna: oh come on. just paste? it is in different json fields [15:36:46] prtksxna: i'm on phone [15:37:01] ugh, irc and phone [15:37:27] zz_yuvipanda: B-16, First floor, Anand Vihar Society, 19-A Road, Khar Danda, Khar (West), Mumbai [15:37:41] zz_yuvipanda: I could guess the pin code but I don't think that is a good idea [15:37:49] prtksxna: heh [15:37:59] prtksxna: ty [15:38:13] zz_yuvipanda: Let me know if you are shipping something [16:13:20] hi jdlrobson [16:14:13] https://gerrit.wikimedia.org/r/#/c/101895/ has comments resolved and ready for review again [16:59:41] hmm having camera problems; going to log out and back in [17:00:41] jdlrobson: thanks [17:02:45] jdlrobson: standup? [17:03:05] tech problems? [17:04:47] (03CR) 10Yurik: Add support for https partners (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/114133 (owner: 10Yurik) [17:09:06] (03PS3) 10Yurik: Add support for https partners [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/114133 [17:10:42] (03PS4) 10Yurik: Add support for https partners [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/114133 [17:16:38] jdlrobson, is there any progress on the Firefox OS app? just asking for the SoS [17:17:08] jgonera: yes it's still waiting on code review from us like all my other stuff :) [17:17:18] https://gerrit.wikimedia.org/r/#/c/111485/ [17:17:28] We got the help we needed from the VE team [17:17:39] jdlrobson, ok, I see, but the stuff that's in gerrit is fully working/final? [17:18:08] nothing is final but yes it seems to be working but we won't know until its on production [17:18:53] ok [17:19:35] brion: meh, hangouts seems to be shit today. I'll just mail in notes [17:19:45] yeah it's pretty flaky [17:20:11] (03CR) 10Dr0ptp4kt: [C: 032] "We'll revisit the two outstanding comments on the commented code when we get to ESI." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/114133 (owner: 10Yurik) [17:20:25] jdlrobson: kaldari: same technical problems with the set up today? [17:20:36] (03Merged) 10jenkins-bot: Add support for https partners [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/114133 (owner: 10Yurik) [17:20:37] no different [17:20:39] i'll poke chip again about the oit ticket [17:21:05] awjr: yeh loads [17:21:14] ethernet cable wasn't been shown as connected [17:21:15] brion: email'd [17:21:20] couldn't get the spekaer/mic to work [17:21:22] working now [17:21:25] awjr: at first we weren't able to get any internet access. We had to change how everything was plugged in to get it to work, but then we didn't have audio [17:21:27] after more fiddling [17:21:44] milimetric: you there? [17:22:21] yep, hi [17:22:31] milimetric: so how do i force limn to stop using a cache [17:22:44] zz_yuvipanda: please mail in your status when you get back on [17:22:48] tfinc: i just did [17:22:50] for some reason old csv data is showing on my local instance [17:22:51] limn's not using a cache, the browser is caching those external urls [17:22:53] thank you [17:23:04] so it's more - how do you get limn to bust those caches [17:23:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] Update pullfiles to account for new package name [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118211 (owner: 10Yuvipanda) [17:23:18] ok, lemme actually look into this - it might not be hard [17:23:21] oh wait milimetric i think i [17:23:22] last I tried it was tricky [17:23:24] 'v worked it out [17:23:32] brion: I've the autocomplete almost working with its own contentprovider and stuff :) [17:23:36] if you just kill the browser cache everything's fine [17:23:37] right? [17:23:39] sweet [17:23:44] or was this something else... [17:25:04] YuviPanda: heya! [17:25:08] hi mhurd [17:25:10] https://gerrit.wikimedia.org/r/118305 < milimetric review appreciated [17:25:16] milimetric: i forgot to regenerate the datasource [17:25:38] YuviPanda: may can't make design refine right? [17:25:52] mhurd: yeah, we should cancel it [17:26:07] mhurd: we should also probably reschedule it to be once every other week [17:26:09] i think [17:26:18] YuviPanda: ya - i have to get this edit summary submitted for noon code cutoff so no argument here :) [17:26:19] mhurd: i talked to may, she was okay with it iirc [17:26:22] mhurd: ;) [17:26:22] ok [17:26:24] cool [17:26:37] mhurd: damn, my 'noon' caliberation is off. THANK YOU DST [17:26:38] heh [17:26:43] haha [17:27:08] (03CR) 10Brion VIBBER: [C: 04-1] "The random works great, but when I go to History view I get a crash:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118221 (owner: 10Dr0ptp4kt) [17:27:14] mhurd: noon is a hour and half away, right? [17:27:21] 1.5 hrs [17:27:25] ya [17:27:31] heh dst [17:27:33] destroyer of schedules [17:29:16] (03CR) 10Yuvipanda: [C: 04-1] "The code shouldn't be in NavDrawerFragment. Perhaps move it to a RandomPageHandler class, similar to CaptchaHandler, perhaps" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118221 (owner: 10Dr0ptp4kt) [17:30:05] (03PS3) 10Brion VIBBER: Random articles. Because Androids like it, too. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118221 (owner: 10Dr0ptp4kt) [17:30:36] (03CR) 10Brion VIBBER: "PS3 fixes the history view." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118221 (owner: 10Dr0ptp4kt) [17:31:40] brion: I left other comments. [17:31:55] dr0ptp4kt: brion also violetto had other designs for Random. just a fyi [17:32:06] ooh [17:32:32] dr0ptp4kt: it shouldn't be doing anything other than calling out to somewhere else in navdrawerfragment. even the bus shouldn't be there. [17:32:39] dr0ptp4kt: that way when we move it later we can easily move it [17:35:22] (03CR) 10Kaldari: [C: 04-1] "I think it's a bit confusing calling it mw-mobile-skin and mw-desktop-skin. What do you think about mw-mobile and mw-desktop or mw-mobile-" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118214 (owner: 10Jdlrobson) [17:35:54] YuviPanda: so just extract the method to its own class? [17:36:10] RandomHandler randomHandler = new RandomHandler(app); randomHandler.doSomething() ? [17:36:13] brion: pretty much, yeah. [17:36:20] jdlrobson, those issues you had with RL when working on Firefox OS app are resolved? [17:36:22] can do that [17:36:25] brion: although you would initialize randomhandler oncreate [17:36:32] brion: so it can handle multiple random requests properly [17:36:51] multiple random requests? [17:37:03] brion: I think that should be handled by making the random button unclickable [17:37:14] rather than anything else [17:37:19] i don't know what you mean [17:37:45] brion: 1. I tap random button 2. App makes HTTP request to figure out random article and disables the 'Random' button 3. Article starts loading and 'Random button is re-enabled [17:37:52] brion: this way we don't let them press 'Random' 2-3 times [17:38:00] brion: the current code cancels the previous requests [17:38:19] that sounds ok to me (current code - canceling previous requests) [17:38:37] brion: why? we are making an extra request, and the first one is going to be as random as the second one [17:38:46] brion: and it isn't going to cancel the actual page load, only the request to the API [17:39:07] if it's timing out, does that mean we just have to wait? [17:39:08] brion: and .cancel does not actually cancel the HTTP request - it only cancels the onFinished from firing [17:39:09] no way to cancel it? [17:40:01] brion: that's true for page loads too [17:41:10] * brion ponders [17:41:32] brion: besides, it isn't going to end up on the left nav, I think. maybe on the bottom nav, or somewhere else. [17:46:01] jdlrobson, dr0ptp4kt what about: https://gerrit.wikimedia.org/r/#/c/103407/ ? Does the Firefox OS app need this? [17:47:44] not sure - you'll have to check with dr0ptp4kt [17:47:45] (03PS4) 10Brion VIBBER: Random articles. Because Androids like it, too. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118221 (owner: 10Dr0ptp4kt) [17:48:24] (03CR) 10Brion VIBBER: "PS4 breaks out the random logic from NavBarFragment to page.RandomHandler. Could be further improved by tweaking the menu state, should on" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118221 (owner: 10Dr0ptp4kt) [17:48:40] YuviPanda: want some more tweaks or take that as is for now? [17:50:18] brion: looking now [17:50:51] dr0ptp4kt, so https://gerrit.wikimedia.org/r/#/c/103407/ can be abandoned? [17:52:38] (03CR) 10Yuvipanda: Random articles. Because Androids like it, too. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118221 (owner: 10Dr0ptp4kt) [17:52:40] brion: one comment [17:53:08] YuviPanda: a toast maybe? [17:54:08] brion: for now I'd prefer a runtime exception. depending on where it ends up in the UI we can modify it later on :) [17:54:24] brion: hey quick question - when i tack the canned edit summary selections on to any free-form summary the user has entered, do you think i should delimit with commas or spaces... dashes... line breaks? [17:54:41] the app should not crash in this case, i don't think a runtime exception is appropriate [17:54:59] mhurd: no line breaks [17:55:04] commas maybe [17:55:07] semicolons? :) [17:55:11] that works [17:55:36] brion: can always tweak later [17:55:42] ya [17:58:47] olpc is over :( [17:59:33] YuviPanda: hey is the api key for summary just "summary"? [17:59:39] mhurd: yea [17:59:43] YuviPanda: so, toast that we can leave forever unless we want to make it fancier, or runtime exception that we'll have to change later when we go removing crashers due to failure to recover from errors? [17:59:45] yay! thx [18:00:08] brion: hard to ignore a runtime exception, but when crunch time comes easier to ignore a Toast :P [18:00:20] brion: but fine for now, with a FIXME [18:00:30] FIXME what? [18:00:52] brion: 'FIXME: Have an appropriate error UI'? [18:00:57] like a toast? [18:01:22] brion: a toast goes away in a few seconds, no? and is hard to see. no way to retry. [18:01:29] brion: but Toast is fine for now. [18:01:30] retry: push the button again [18:02:45] (03PS5) 10Brion VIBBER: Random articles. Because Androids like it, too. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118221 (owner: 10Dr0ptp4kt) [18:03:39] brion: I'll test and merge once I push my current patch up [18:03:50] thx :D [18:06:01] jgonera, i abandoned https://gerrit.wikimedia.org/r/#/c/103407/ [18:06:06] brion: yay! edit summaries save! [18:06:09] jdlrobson ^^ [18:06:17] ok [18:06:46] mhurd, YuviPanda, brion: getting caught up after flurry of deployment and scrum of scrums, will get to looking at Random things. [18:07:03] ...after reading email [18:07:15] dr0ptp4kt: no worries [18:12:33] (03PS1) 10Yuvipanda: Add autocomplete support for EditSummaries with a ContentProvider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118318 [18:12:46] brion: ^ [18:13:07] whee [18:14:00] brion: hopefully that'll make it into the build :) [18:14:09] looking it over now :D [18:14:24] brion: I'm testing the 'upgrade' db process now [18:14:39] brion: so if it crashes, test the other stuff :) I'll get it fixed before we merge this [18:16:15] (03PS1) 10Mhurd: Added edit summary interface to preview screen. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118322 [18:16:23] brion: ^ [18:16:58] (03PS2) 10Yuvipanda: Add autocomplete support for EditSummaries with a ContentProvider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118318 [18:17:31] awjr: chrismcmahon still way too many test failures then i would like :/ [18:18:05] jdlrobson: awjr how about zero test failures? https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/ [18:18:08] YuviPanda: An exception occured during performFiltering()! [18:18:09] android.database.sqlite.SQLiteException: no such table: editsummaries (code 1): , while compiling: SELECT * FROM editsummaries WHERE (summary LIKE ?) ORDER BY lastUsed DESC [18:18:19] brion: grr, that's the db upgrade [18:18:20] yeyyy :) [18:18:23] :) [18:18:26] chrismcmahon: i didn't see that one that makes me happy [18:18:28] brion: I'm testing it now. Can you test the other functionality in the meantime? [18:18:35] why did the one before fail chrismcmahon ? [18:18:38] brion: it should work - I updated the number, and the code exists... [18:18:49] YuviPanda: can't, the other functionality depends on that table [18:18:59] jdlrobson: flakyness basically [18:19:04] brion: uninstall re-install? [18:19:09] (03CR) 10Brion VIBBER: Add autocomplete support for EditSummaries with a ContentProvider (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118318 (owner: 10Yuvipanda) [18:19:16] don't want to lose my data [18:19:17] https://saucelabs.com/jobs/c2974601c54d4999bde9c733c9f9e6c1 < chrismcmahon this one for instance, according to the test it should have passed as i see the language overlay.. [18:19:20] brion: heh, ok [18:19:52] oh wait it was the browser bak button [18:19:54] (03CR) 10Brion VIBBER: [C: 04-1] "Also, the database doesn't upgrade as discussed on IRC. Fatal!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118318 (owner: 10Yuvipanda) [18:19:55] it was supposed to close [18:19:56] weird [18:20:07] jdlrobson: Chrome has been corrupting data recently. Just this morning we specified an earlier version of Chrome for the Sauce builds, this is the first build using it [18:20:21] chrismcmahon: well that sounds wonderful and promising [18:20:25] i hope they will go green for some time now [18:20:44] im very pleased to see that firefox build pass, it's been a while [18:20:50] the chrome tests have been wonky for a long time [18:20:59] (03CR) 10Yuvipanda: Add autocomplete support for EditSummaries with a ContentProvider (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118318 (owner: 10Yuvipanda) [18:21:15] YuviPanda: yeah DBOpenHelper.onUpgrade is just empty so it doesn't upgrade anything [18:21:20] brion: gaaaah [18:21:27] brion: I was looking in the wrong places. let me do it [18:21:43] kaldari: jgonera https://gerrit.wikimedia.org/r/#/c/117008/ can we get this merged [18:21:50] MaxSem: or you can just +2 it [18:21:58] brion: thanks for pointing it out [18:22:03] :) [18:22:03] (03PS4) 10Jdlrobson: Proper edit handling in case of redirects where page does not exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116912 [18:22:12] (03CR) 10MaxSem: [C: 032] Add password reset link from desktop on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 (owner: 10Jdlrobson) [18:22:18] (03CR) 10jenkins-bot: [V: 04-1] Add password reset link from desktop on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 (owner: 10Jdlrobson) [18:22:18] thanks MaxSem :) [18:22:21] (03PS2) 10Jdlrobson: Ensure the languages button is present after an edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118104 [18:22:28] duh [18:23:25] arggg of course i rebase will be required [18:23:27] on it [18:24:25] (03PS5) 10Jdlrobson: Add password reset link from desktop on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 [18:24:35] there you go MaxSem thankfully was a simple one [18:25:32] (03CR) 10MaxSem: [C: 032] Add password reset link from desktop on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 (owner: 10Jdlrobson) [18:26:07] (03PS9) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [18:26:16] (03Merged) 10jenkins-bot: Add password reset link from desktop on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117008 (owner: 10Jdlrobson) [18:27:35] brion: if you have the time, whom do I need to bribe if I want https://gerrit.wikimedia.org/r/#/c/118220/ to get reviewed and deployed? (it's a follow up on the appindexing stuff) [18:29:43] (03CR) 10Brion VIBBER: "I would recommend changing the case from Title Case to regular lowercase and removing the extra spaces after the slashes." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118322 (owner: 10Mhurd) [18:30:20] (03CR) 10Brion VIBBER: [C: 04-1] "Hmm, we seem to have lost the section marker too." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118322 (owner: 10Mhurd) [18:30:44] dennyvrandecic: ah that's the config for it, good i've been meaning to poke that :D [18:31:12] sweet. I hope I got it right, but WMF config is still a bit of a mystery for me :) [18:31:25] brion: section marker? [18:31:42] mhurd: the /* Section name */ bit that goes at the beginning [18:31:47] or ... were we missing that already? :D [18:32:08] dennyvrandecic: looks right except i think the app id string should just be 'org.wikipedia' [18:32:16] mhurd: we are doing canned edit summaries? I thought the discussion over the last few days was that we aren't? or iOS and Android are going to have different behavior? /me is confused. [18:32:34] brion: goes at beginning of edit summary? i think we were missing it already? [18:32:43] heh ok then we'll worry about fixing that later :D [18:34:27] brion: aww, you are right. I will fix that [18:34:38] brion: want me to amend the capitalization real fast? [18:34:43] mhurd: yeah that's easy [18:34:50] brion: k one sec [18:36:43] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118322 (owner: 10Mhurd) [18:37:49] (03PS2) 10Mhurd: Added edit summary interface to preview screen. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118322 [18:38:18] brion: i amended to update the l10n ^ [18:38:35] brion: thanks. I amended too [18:38:41] (03CR) 10Mhurd: "I updated the l10n..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118322 (owner: 10Mhurd) [18:38:47] mhurd: seen siebrand's note about slashes? [18:38:57] brion: ah no lemme check [18:40:44] (03CR) 10Siebrand: [C: 04-1] "Per comments on slashes in PS1." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118322 (owner: 10Mhurd) [18:40:54] amending... [18:41:21] whee [18:41:44] (03PS3) 10Mhurd: Added edit summary interface to preview screen. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118322 [18:41:59] brion: ^ amended based on siebrand's comments [18:42:31] (03CR) 10Mhurd: "Amend to fix issues Siebrand raised..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118322 (owner: 10Mhurd) [18:42:45] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118322 (owner: 10Mhurd) [18:43:02] yay! [18:43:39] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok let's take it for now and tweak further if we need. Note that /* section name */ needs to be added, was missing before too on iOS." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118322 (owner: 10Mhurd) [18:44:11] \o/ [18:44:15] 15 minutes to cutoff :D [18:46:20] (03CR) 10Brion VIBBER: [C: 031] "So +1 from me with modifications, needs a confirm from Yuvi." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118221 (owner: 10Dr0ptp4kt) [18:46:29] jdlrobson: kaldari can you guys please mail your standup notes? [18:46:32] brion: 'E/ACRA ( 8383): Caused by: android.database.sqlite.SQLiteException: not an error (code 0)' [18:46:33] ... [18:46:42] o_O [18:46:44] YuviPanda: not too worried about small diff between ios / android here or there. we have small diff in way TOC works etc. on canned summaries in particular i didn't get the sense that there was consensus not to try it. i got the opposite feeling actually [18:47:13] mhurd: *shrug*. might be location dependent, then :) [18:47:44] YuviPanda: no worries - if it doesn't go over well we can yank it by next beta release [18:47:49] mhurd: :) [18:48:22] mhurd: by 'not go over well' you mean 'everyone selects 'modified content' or some such as the edit summary hence rendering it useless'. we can measure it later on, I think. [18:48:29] awjr: sure [18:48:38] mhurd: can you tell me what are the summaries being presented? [18:48:44] mhurd agree =] also Amir and Steven think its worth testing from their email responses [18:48:51] YuviPanda: ya just a sec... [18:48:56] YuviPanda: Im talking to steven about that today and will let mhurd know [18:49:01] vbamba: ok. [18:49:30] brion: heh, trying to figure out what error 'not an error' is is weird [18:49:39] ouch [18:49:40] YuviPanda: "Fixed typos or grammar", "Linked words" and "Added or removed information" [18:49:47] 10 minutes to cutoff [18:50:30] brion: the tension! [18:50:35] :) [18:51:19] :D [18:51:32] i can always make a second beta tomorrow with fixes ;) [18:51:56] brion: yeah, it's not bothering me too much. a lot easier to make builds on Android anyway :) [18:52:03] brion: I should setup a custom auto-updater at some point. [18:52:23] (03PS1) 10Dr0ptp4kt: Update cookie flags to reflect what we really want. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/118326 [18:52:58] ^yurik would you please +2 and ld? [18:55:05] five minutes to cutoff! :) [18:56:13] violetto: before i hit buy on the camera you wanted i want to make sure your ok with the weight difference as you lug it around. the smaller one is .89lbs and the one you like 1.62lbs [18:56:17] violetto: i'm ok with either [18:56:31] just want to make sure the extra weight wont stop you from moving it around [18:58:12] awjr: https://gerrit.wikimedia.org/r/118328 < will fix officewiki [19:00:09] (03CR) 10Yurik: [C: 032] Update cookie flags to reflect what we really want. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/118326 (owner: 10Dr0ptp4kt) [19:00:11] (03Merged) 10jenkins-bot: Update cookie flags to reflect what we really want. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/118326 (owner: 10Dr0ptp4kt) [19:00:32] ok it's noon -- cutoff time! [19:00:48] we'll get the remaining patches in a -bis release if people need to test them before the next sprint [19:02:54] (03PS3) 10Yuvipanda: Add autocomplete support for EditSummaries with a ContentProvider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118318 [19:02:58] brion: heh, managed to fix it. [19:03:18] tooo laaaaate :D [19:03:48] brion: heh, fine by me. [19:04:13] seriously though we'll do a end-of-sprint update or something [19:04:20] seems like a wise idea to include final fixes anyway [19:04:42] brion: I don't think the wednesday one is supposed to be 'complete' for the sprint. [19:04:51] right, it's for testing purposes [19:05:04] brion: true! [19:05:25] brion: and I want to setup 'continuous integration' type stuff anyway. Let me see what I can do without having to deal with Jenkins [19:05:31] yeah [19:05:37] it may be easier to just build them offline and upload em :P [19:05:40] brion: considering just using https://support.google.com/googleplay/android-developer/answer/3131213?hl=en [19:05:50] ooooh [19:05:51] brion: so I can make a build as and when I finish up a new feature [19:05:55] nice [19:06:05] brion: can you review the patch right after you make the builds? [19:06:35] will do [19:06:40] brion: ty [19:07:17] brion: holy shit, the wikipedia beta app on play store has about 50k installs [19:07:30] heh [19:07:38] maybe time to start using it :D [19:07:42] brion: yeah [19:09:01] brion: am setting up alpha testing there. [19:09:54] whee [19:12:05] dr0ptp4kt: synced [19:17:54] brion: first iOS bug coming back at you guys from todays build [19:17:58] tfinc: ok beta builds are out; mail sent to mobile-l / wikitech-l [19:17:59] heh [19:18:02] that was fast :D [19:18:36] tfinc: ooh good catch [19:18:47] we have to apply some styles on the preview i think [19:18:51] yurikR, and we have liftoff. thanks man! [19:18:58] brion: ya i forgot to do that! [19:19:27] brion: i made note and will prob try to have the preview be the 1st thing to use yuvi's common css/js transforms [19:19:40] awesome [19:20:43] jdlrobson: kenanwang: as i edit on the app more not having a my contributions on mobile web is causing me to go to desktop. make me not want to [19:21:02] brion: can you apply https://groups.google.com/forum/#!forum/wpandroidapptesters [19:21:12] https://en.m.wikipedia.org/wiki/Special:Contributions/Jdlrobson < tfinc you mean like this? [19:21:17] https://en.m.wikipedia.org/wiki/Special:Contributions/Jdlrobson?mobileaction=beta [19:21:30] brion: rather, join. I made it public and made everyone able to join [19:21:50] jdlrobson: yes, make it so that i can get to it easily [19:22:01] jdlrobson: what api query gets you your contribs? [19:23:06] brion: I'm going to make abuild and push it to 'alpha' channel once this patch gets merged :) [19:23:37] tfinc: there already is - on the user profile page [19:23:48] tfinc: get kaity on it and kenan to prioritize it. Would be great to get history out too [19:24:12] tfinc: jdlrobson yes it's accessible on user profiles [19:24:18] could maybe be more obvious [19:24:30] we're looking at both article history and user profiles right now [19:24:39] jdlrobson: you mean https://en.m.wikipedia.org/wiki/Special:UserProfile/Tfinc ? [19:25:10] jdlrobson: that only shows me one edit, no diff, and not edit summaries [19:25:32] the link is not obvious but the 194 edits is a link to your contributions [19:26:07] violetto: ping!? [19:26:11] that works. i'll have to talk with Kenan and Kaity about trimming the amount of taps that takes [19:26:59] tfinc: what is this? [19:28:08] YuviPanda: joined [19:28:32] brion: https://play.google.com/apps/testing/org.wikipedia :) [19:28:37] brion: stupidly, it is a 404 otherwise [19:28:42] \o/ [19:28:58] brion: I'll make a build once the last patch gets merged [19:30:13] YuviPanda: violetto is at the fluent conference [19:30:21] jdlrobson: aaaah, right. i forgot. [19:30:26] jdlrobson: thanks for reminding :) [19:30:27] she can code now [19:30:35] jdlrobson: indeed. I'm excited! :) [19:30:42] jdlrobson: was that your influence? [19:30:42] :) [19:30:43] she's gonna render you obselete [19:30:57] no mostly jorm [19:31:02] ok i gotta grab some lunch and run a quick errand, then i'll be back to code some more reviews and commit some more gits [19:31:03] jdlrobson: aaah, right. nice [19:31:04] he's been really encouraging her [19:31:05] brionok [19:31:24] jdlrobson: :) [19:31:43] spiff! [19:31:49] jdlrobson: btw, can you join https://groups.google.com/forum/#!forum/wpandroidapptesters? am testing automatically getting the weekly builds to users via play store. [19:31:54] ok bbiab [19:32:01] jdlrobson: it is just a group, has posting disabled, so no spam! [19:32:25] YuviPanda: done! [19:32:33] jdlrobson: can you accept at https://play.google.com/apps/testing/org.wikipedia now? :) [19:32:42] jdlrobson: make sure to use the same account you are using on your phone :) [19:34:30] YuviPanda: i will in a second - too busy killing cologne blue in core [19:34:39] jdlrobson: :D alrighty! [19:34:44] jdlrobson: oooh, good luck on that :) [19:46:30] (03PS1) 10Yuvipanda: Show Edit Summary field only after preview is fetched [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118339 [20:02:14] meeeeeeeeeeeeeeeeeee [20:02:20] teeeeeeeeng! [20:03:59] MaxSem: i heard you enjoy those [20:04:06] hey brion [20:04:17] yo [20:05:35] awjr, we can't hear you [20:05:42] jgonera: are the chat 150s on? [20:05:44] we can't hear you either [20:05:45] brion: CR! :) I'm eager to setup an alpha build and see how it goes [20:06:01] jgonera: normally i can see blue lights on the chat150s but not at the moment [20:06:04] moment [20:06:13] tfinc: ^^ [20:06:27] brion: sweet [20:07:22] jgonera: i just pinged chip [20:07:36] jgonera: i dont think messing with the polycom is going to help (what kenan appears to be doing) [20:07:42] awjr, there's one blue light [20:07:48] huh [20:07:59] i see the light! [20:08:30] http://www.youtube.com/watch?v=YQWszrZHBPI [20:08:38] jgonera: kenanwang why dont you guys go ahead and get started [20:13:46] (03CR) 10Brion VIBBER: [C: 032 V: 032] "seems to work :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118318 (owner: 10Yuvipanda) [20:13:56] brion: wooo! [20:15:06] awjr, hangouts show you as muted yet I hear you? [20:16:10] MaxSem: bizarreo [20:17:29]