[00:28:26] (03PS11) 10Kaldari: Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [00:28:34] (03CR) 10jenkins-bot: [V: 04-1] Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [00:53:30] (03PS2) 10Mhurd: Interacting with edit summary interface causes nav bar text to change. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118362 [00:55:03] (03CR) 10Mhurd: "Updated to fix the issues Brion found." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118362 (owner: 10Mhurd) [00:57:25] (03PS8) 10Dr0ptp4kt: Random articles. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 [01:01:25] (03PS9) 10Dr0ptp4kt: Random articles. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 [01:09:08] (03PS10) 10Dr0ptp4kt: Random articles. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 [06:24:45] zz_yuvipanda: ping when you wakey wakey [07:05:49] hello prtksxna [07:06:00] are you aorund? [08:22:09] violetto2: wakey [08:23:50] violetto: wakey [08:23:52] violetto2: wakey [08:25:24] YuviPanda: yello! [08:25:35] violetto2: how was the conference? [08:25:56] YuviPanda: it went from meh to cool to confused [08:26:10] violetto2: heh, most conferences are like that :) [08:26:24] YuviPanda: yea.. [08:26:30] met the guys from craigslist [08:26:54] violetto2: aah! nice! [08:26:58] YuviPanda: was like.. are you guys looking to hire a designer? [08:27:02] violetto2: conferences are good for meeting people. [08:27:14] violetto2: oho :D [08:27:16] YuviPanda: and they said they didn't have any designers and aren't looking [08:27:24] YuviPanda: then i was like.. that's too bad cus i want a job [08:27:26] hahahahaha [08:27:53] then they figured out i was playing [08:27:54] violetto2: :P [08:28:10] YuviPanda: cus they can use a designer [08:28:28] violetto2: :P I've been told that by about 20 people so far :D [08:28:41] violetto2: craigslist in India is just 100% spam, so never had to check it out :D [08:28:47] YuviPanda: LOL! [08:29:11] YuviPanda: turns out i was talking to the ceo, he asked, who do you think is a good candidate, do you know any? [08:29:11] violetto2: btw, I figured out a way to get auto-updating alpha builds of the android app available to everyone :D No need to download, uninstall and re-install :D [08:29:15] violetto2: haha :D [08:29:17] then i pointed to moiz [08:29:24] violetto2: how long did it take for them to realize? [08:29:52] YuviPanda: when brandon introduced us to someone else next to me [08:30:13] YuviPanda: what should i do on my side to get the alpha builds? [08:30:48] violetto2: 1. join https://groups.google.com/forum/#!forum/wpandroidapptesters 2. opt in at https://play.google.com/apps/testing/org.wikipedia 3. install the app from link in (2) [08:31:19] violetto2: anyone on any device can do this. Will auto-update whenever I push a build. And I'll be doing it rather frequently. Once every story even :) [08:31:31] YuviPanda: doing tha tnow [08:31:35] violetto2: wheee [08:31:48] violetto2: the current app icon is still the android default one. we might want to change t hat real soon [08:32:04] YuviPanda: yea [08:33:35] violetto2: :) I'm emailing mobile-l in a moment [08:33:51] violetto2: there's also a 'Random' button now and also a 'send feedback' button [08:34:00] YuviPanda: the second link didn't work for me [08:34:06] i joined the group [08:34:45] violetto2: https://play.google.com/apps/testing/org.wikipedia [08:34:49] violetto2: try again? [08:34:54] ok [08:35:28] that worked! [08:35:30] woohoo! [08:35:35] violetto2: :D install it [08:36:48] YuviPanda: it's the old app? [08:36:58] violetto2: it should update to the new one. [08:37:14] didn't on my side [08:37:33] violetto2: give it a bit. initial install seems a bit slow since I uploaded it only a few hours ago [08:37:40] okay [08:37:46] violetto2: ooh, also - the phone you are using, it is with the same account that was shown at https://play.google.com/apps/testing/org.wikipedia [08:38:15] YuviPanda: what does that mean [08:38:36] violetto2: in your phone, go to play store, open left drawer. it will show what account is being used. [08:38:50] violetto2: and in https://play.google.com/apps/testing/org.wikipedia it will tell you what account you opted-in with. they should be the same [08:39:15] YuviPanda: ohhh i see what u mean [08:40:08] violetto2: yeah, google's multiple account support is a bit weird [08:40:17] YuviPanda: /finding a way to log on wikitesta.. [08:40:53] violetto2: yeah, I was thinking that :) [08:41:38] YuviPanda: let me google how to log out [08:41:56] violetto2: you don't need to 'log out', you can login to multiple things [08:42:23] violetto2: https://support.google.com/accounts/answer/1721977?hl=en [08:44:37] YuviPanda: i dont have wikitesta's email pw [08:44:42] do you? [08:46:02] violetto2: oh, no, me neither :| [08:46:09] violetto2: I don't know anyone who does [08:46:11] oh [08:46:18] bah i'll ask at work tmr [08:46:19] violetto2: but you can add another account on the phone. Isn't there one for the design team? [08:46:22] violetto2: ok [08:46:37] i can't find a way to add an acc on playstore [08:46:49] it's okay, i'll bring it to work tmr [08:47:02] violetto2: you need to go to phone settings, 'google' and 'add account' [08:47:05] violetto2: but yeah, it can wait :) [08:47:18] (03Abandoned) 10Zfilipin: QA: Moved Ruby code that multiple repositories use to mediawiki_selenium Ruby gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112675 (owner: 10Zfilipin) [08:51:19] YuviPanda: bam! done! [08:51:23] but stil has old app [08:51:35] i'll wait a few hours [08:52:11] violetto2: so you have signed in to play store with the design email, and also have the same one in the opt-in p0age? [08:52:33] i signed in with my email [08:52:35] yeah [08:52:39] all same mgalloway [08:53:45] violetto2: ah, ok. [08:54:09] violetto2: there should be a 'download' link at bottom of https://play.google.com/apps/testing/org.wikipedia, does clicking that give you options to upgrade? [08:54:56] let me check [08:55:28] violetto2: did you And vbamba sync up on login screen? [08:55:36] violetto2: usually we aren't changing designs this late :( [08:57:11] YuviPanda: gives me an option to update, but when i tap on it it tells me app already exists [08:57:25] violetto2: hmm, let's just wait it out then. [08:57:27] violetto2: should be up tomorrow [08:57:54] YuviPanda: she said on trello that she'll update it, but i imagine it's just what we already have plus the copy [08:58:11] violetto2: hmm, so I just reuse what we have for now? [08:59:11] YuviPanda: yes sir [08:59:17] violetto2: alright then [08:59:26] violetto2: the checklists are wildly out of date with what we have now. sigh [08:59:43] YuviPanda: which checklist? [09:01:21] YuviPanda: do you feel better with the benefits copy? [09:01:39] violetto2: checklists in the cards on https://trello.com/b/4S47MdDJ/mobile-app-sprint-26-editing-workflow-part-3 [09:02:14] oh that one [09:02:27] should ask kenan to help update [09:02:27] violetto2: nah, I don't like the 'in the future'. I am okay with just leaving that out. 'co editors' also sounds really, really weird. [09:03:31] violetto2: I just pinged him on the card [09:05:13] i mentioned that we really want to convince people with this copy. And when they already are convinced and created account based on those promises, what happens if they cannot find a way to connect with editors and don't go to desktop? [09:05:37] the only benefits i see now at the current state is IP address not showing and that your username is attached to the edit [09:06:06] violetto2: we don't actually have many advantages to logging in :P [09:06:21] YuviPanda: we do, just not in the app now [09:06:27] YuviPanda: not a whole lot to say the least [09:06:29] violetto2: and most users don't care about IP addresses. On mobile they're doubly useless since a lot of them are shared [09:06:43] violetto2: yeah, that's what I meant, Practically, 'bragging rights' is the only thing I could think of [09:06:50] YuviPanda: mhm [09:10:10] violetto2: I'm going to leave in about 10min [09:11:12] YuviPanda: ok replying on trello on the same thing [09:11:18] violetto2: sweet. [09:15:38] YuviPanda: done [09:19:06] violetto: am off now [09:19:08] ta! [09:19:26] YuviPanda: k bai! [11:25:19] (03PS1) 10Matthias Mullie: Add selectors for Parsoid-output external links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118449 [16:48:25] (03PS1) 10Zfilipin: QA: Remove dot from Cucumber feature name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118559 [16:50:16] (03PS2) 10Zfilipin: QA: Remove dot from Cucumber feature name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118559 [16:56:01] (03CR) 10Cmcmahon: [C: 032] QA: Remove dot from Cucumber feature name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118559 (owner: 10Zfilipin) [17:00:28] (03PS3) 10Zfilipin: QA: Remove dot from Cucumber feature name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118559 [17:05:58] brion: hey! [17:07:26] yo [17:08:05] brion: the alpha came through! [17:08:12] brion: at least on my device and a friends' :) [17:08:18] brion: now to check violetto's :) [17:09:10] wooo [17:11:43] (03CR) 10Cmcmahon: [C: 032] QA: Remove dot from Cucumber feature name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118559 (owner: 10Zfilipin) [17:12:02] brion: YuviPanda: hey! [17:12:23] (03Merged) 10jenkins-bot: QA: Remove dot from Cucumber feature name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118559 (owner: 10Zfilipin) [17:14:27] mhurd: if you are in the office, do you know if tfinc is there? [17:14:47] YuviPanda: i don't see him yet [17:14:52] mhurd: ok [17:16:15] YuviPanda: he just arrived [17:16:30] mhurd: ah, ok [17:17:43] YuviPanda: get my note ? [17:17:44] tfinc: can you turn video off? [17:17:48] tfinc: my hangouts seem shit [17:17:50] done [17:17:51] tfinc: yeah [17:18:01] YuviPanda: want to do it over irc ? [17:18:08] tfinc: yeah, that'll be good [17:18:10] tfinc: pm? [17:28:15] MaxSem: would you be ok if i moved our 1:1 today to 1pm PST ? [17:28:24] yes [17:28:29] brion: i fixed both the issues you found :) https://gerrit.wikimedia.org/r/#/c/118362/ [17:28:30] thanks. i know thats late for you [17:28:41] woot [17:33:49] jdlrobson: what's the story behind "geonotahack.feature"? it's been pretty flaky [17:34:52] chrismcmahon: it is a feature that is now broken on enwiki and desktop beta features and will be for the next week so i figured i should add tests. [17:35:08] it requires the server to be configured though - we might want to limit to where we run them [17:35:22] Is doesn't need to run on test2.m.wikipedia.org for example [17:36:32] ^ chrismcmahon [17:36:34] (03PS1) 10Jdlrobson: QA: Don't run the nearby pages on test2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118572 [17:37:11] (03CR) 10Cmcmahon: [C: 032] QA: Don't run the nearby pages on test2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118572 (owner: 10Jdlrobson) [17:37:43] violetto: around? [17:38:01] (03Merged) 10jenkins-bot: QA: Don't run the nearby pages on test2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118572 (owner: 10Jdlrobson) [17:39:47] chrismcmahon: the chrome build seems kind of flakey? [17:51:21] (03PS11) 10Dr0ptp4kt: Random articles. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 [17:51:37] violetto: around? [17:57:08] jdlrobson: I'm working on flaky tests this week, and editor_ve.feature seems to almost always tank on "Given I am in alpha mode": Given I am in alpha mode # features/step_definitions/common_steps.rb:77 [17:57:08] timed out after 5 seconds, waiting for {:class=>"mw-mf-settings-off", :tag_name=>"span"} to become present [17:58:44] (03PS1) 10Jdlrobson: QA: Don't run this test on test2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118576 [17:59:23] (03PS12) 10Dr0ptp4kt: Random articles. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 [18:01:56] YuviPanda: mhurd: did you guys get the updated invite for the iteration reivew ? [18:02:08] i'm the only one in r36 right now [18:02:10] tfinc: ah lemme chekc [18:02:15] making me wonder if it went out [18:02:40] tfinc: i got it [18:02:55] tfinc: turn video off again? hangouts is being terrible, even after I restarted my laptop. [18:03:10] YuviPanda: that funny enough will work for the best as r36 has no av [18:03:23] tfinc: hah! :D [18:03:27] tfinc: ok! [18:03:33] tfinc: should tell anyone else who joins remote to turn it off too [18:05:36] brion: oh, iteration review [18:05:47] tfinc: I can [18:05:50] tfinc: hear you [18:05:52] YuviPanda: great [18:06:16] YuviPanda: mhurd_ brion: http://hatjitsu.wmflabs.org/82850 for todayy [18:11:27] brion: http://hatjitsu.wmflabs.org/82850 [18:12:00] brion: turn off video? [18:15:01] brion: am I lost? [18:17:31] this is the fun of not having video :) [18:20:09] tfinc: I've significant connectivity issues. I'll follow the notes later on, I think. Can't really interact. [18:20:18] will try to get the internet sorted for tomorrow. [18:20:59] YuviPanda: ok [18:24:22] (03CR) 10Jdlrobson: [C: 04-1] "-1 pending my discussion on the bug. If Parsoid is rendering an external link it should probably identify that link with a class like ever" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118449 (owner: 10Matthias Mullie) [18:27:01] jdlrobson: do you have time to figure out why why "Given I am in alpha mode" seems to have stopped working? [18:27:11] I sent a mail about this chrismcmahon [18:27:19] and no :) [18:32:09] (03PS13) 10Dr0ptp4kt: Random articles. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 [18:32:54] ^brion, that's ready for review and captures mhurd's requirements as of latest discussion this morning from what i interpreted. [18:33:02] awesome thanks! [18:33:07] dr0ptp4kt: yay! [18:35:54] YuviPanda, do you know if the start screen is on the docket for the android mvp? if not, i'm going to talk with kenan and see if this would be viable. carolynne asked me if i could look into it after Eloquence suggested in our quarterly review to bring w0 requirements in on this piece. i explained to carolynne that the app will launch in the default language, so we don't need a language selector. just having the attribution to the carrie [18:35:54] that start screen should be sufficient imo, in addition to the main content (e.g., wotd, raotd, aotd, stream, oithers, pick one or more) [18:36:21] dr0ptp4kt: I am pretty sure it is, yeah. there's a 'visual polish' sprint the one after this one, and I think it is there. [18:36:25] (regarding lang selector, we don't need it on the home screen) [18:36:41] (home screen of the app) [18:36:45] dr0ptp4kt: yeah! [18:42:21] jdlrobson: I rather boggle that anons can turn off/on alpha features, then log in and have that state somehow perpetuate. although it seems to be inconsistent. [18:42:28] \nick kaldari_lunch [18:42:33] oops :) [18:45:42] chrismcmahon: it has nothing to do with user preferences - its a cookie [18:45:43] always has been [18:46:22] yep [18:47:26] but something funny is going on with that cookie, it seems to exist even in a FF started with a fresh profile [18:47:55] jdlrobson: is anything about alpha mode status held on the server side? [18:48:20] tfinc: mhurd suggest a spike for 'determine "current" section'? [18:48:24] (am just listening in) [18:50:13] chrismcmahon: it gets set as a cookie for the user, it then toggles on alpha/beta when it receives that header containing the cookie [18:52:21] MaxSem: any idea who can test/merge https://gerrit.wikimedia.org/r/#/c/118381/ [18:56:19] YuviPanda, poke Brad or Bri on? [18:56:29] (03CR) 10Yuvipanda: [C: 032 V: 032] Add section-0 edit button [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118363 (owner: 10Brion VIBBER) [18:56:32] or Chris... [18:56:38] MaxSem: hmm, ok! [19:00:59] brion/mhurd: any thoughts on https://gerrit.wikimedia.org/r/#/c/118213/ ? dfoy mentioned that in talking with tfinc and kenanwang it sounded like a user-agent that captures that it's expressly the official app is wanted. the trio of user-agent, x-cs, and request path format will hopefully be easily enough parseable for analytics in the w0 reports to have a separate trendline for apps. [19:01:56] dr0ptp4kt: sounds about right [19:05:59] awjr: can i ask you to sub for me to an app story estimation and iteration review tomorrow @ 1 ? [19:06:09] sure tfinc [19:06:43] awjr: added you. i'm going to talk to kenan to see if i can move it earlier for YuviPanda [19:06:44] tfinc: as scrummaster or ? [19:06:47] ok [19:06:51] awjr: correct [19:07:18] timekeeper, hat.jit.su coordinator, and mast of all things scrum [19:07:30] tfinc: ok; what do you guys do in iteration review? [19:08:04] awjr: product reviews stories in the next sprint https://trello.com/b/qb2lPChs/mobile-app-sprint-27-navigation , engineerings estimate [19:08:08] engineers* [19:08:09] tfinc: and will i need any special perms/etc for trello? [19:08:13] using hat.jit.su [19:08:29] ah ok, so 'iteration review' is a review of stories for the upcoming sprint, rather than a review of the past sprint? [19:08:31] awjr: install the scrum for chrome extension [19:08:37] awjr: correct [19:08:42] cool [19:08:53] hey violetto [19:08:56] violetto: did the app update? [19:09:23] awjr: the toughest piece of this review will be validating design alongside product and engineering. we were only able to do that for 8 story points today and thus didn't finish [19:09:30] our running average is 25 story points [19:10:42] tfinc: okidoke, and points are in the parentheses preceding the card title? [19:11:54] awjr: yup, and if you install the extension the'll be displayed in a really nice manner. i highly recommend it [19:12:01] ah yeah, i see that now [19:12:04] very cool [19:13:09] tfinc do you tend to overbudget a little for the iteration? (eg load up 30 points even though the average is 25) and if we need to find more stuff to work on, look through the backlog? [19:13:58] if so, can you add me to the backlog board? [19:15:46] (03PS5) 10Jdlrobson: Update last modified time when a template or file changes in MFResourceLoaderModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 [19:16:14] (03PS5) 10Jdlrobson: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 [19:16:16] (03PS5) 10Jdlrobson: Special:MobileWebApp and Special:Manifests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 [19:16:40] (03Abandoned) 10Jdlrobson: Add hook SkinMinerva::getDefaultModules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/112155 (owner: 10Jdlrobson) [19:17:13] awjr: I just made you admin of everything [19:17:19] :) [19:17:19] awjr: group admin, that is [19:17:38] i can feel the power surging through me [19:17:40] thanks YuviPanda [19:35:22] (03PS2) 10Jdlrobson: Surface talk page on desktop version of skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118214 [19:36:28] kaldari_lunch: can i get some vector beta review from you later and a few core changes pushed through? https://gerrit.wikimedia.org/r/#/c/117617/1 and https://gerrit.wikimedia.org/r/#/c/117904/ [19:36:46] sure [19:38:57] jdlrobson: Could you explain the commit summary what https://gerrit.wikimedia.org/r/#/c/117904/ is actually for. What HTML do we want to insert? [19:39:12] er, in the commit summary [19:39:29] brion: https://gerrit.wikimedia.org/r/#/c/118381/ ? [19:40:08] kaldari: hope that helps? [19:40:11] hmm [19:42:04] jdlrobson: Thanks, now I understand :) [19:48:37] why is gerrit so broken this week :( [19:48:50] s/this week// [19:50:29] kaldari: done :) [19:50:39] heading for lunch now [19:50:42] talks in a bits [19:52:32] jdlrobson: oops [19:52:40] jdlrobson: one more thing, you still there? [19:54:20] awjr|lunch: we try not to load it past 25 and instead lean on the backlog [20:01:08] dr0ptp4kt: getting close on the tableview alert stuff :) [20:01:30] mhurd, yeehaw [20:07:25] mhurd: do you know if May is in the office? [20:07:42] YuviPanda: not sure - i think she had a meeting? [20:08:28] tfinc, I had a network glitch, now works again [20:08:54] MaxSem: pm [20:39:18] (03CR) 10Cmcmahon: [C: 032] QA: Don't run this test on test2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118576 (owner: 10Jdlrobson) [20:39:57] (03Merged) 10jenkins-bot: QA: Don't run this test on test2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118576 (owner: 10Jdlrobson) [20:40:15] kaldari: chrome bug fixed [20:40:16] !!!! [20:40:25] yay! [20:40:35] vbamba: offers gratitudes [20:40:43] thank you thank you thank you! [20:41:07] I checked a bunch of articles, everything looks good. Going to review with Steven and post FAQ tonite [20:44:34] kaldari: use the doc to update any changes both in the 'Summary' and 'FAQ' section [20:44:45] will do [20:47:29] kaldari: Thank you for updating the doc in advance [20:48:51] (03PS1) 10Dr0ptp4kt: Support custom User-Agent. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/118594 [20:53:05] (03PS2) 10Dr0ptp4kt: Support custom User-Agent. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/118594 [20:56:06] (03PS1) 10Dr0ptp4kt: Set custom User-Agent for rebooted Android app. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118596 [20:56:59] YuviPanda, Brion: ^ and ^^ this is the android ua-setting code. [20:57:09] \o/ [21:09:14] (03CR) 10JGonera: [C: 032] Hygiene: Remove undefined test and unused rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118209 (owner: 10Jdlrobson) [21:10:54] (03CR) 10JGonera: [C: 032] Don't squash images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118401 (owner: 10Jdlrobson) [21:11:36] (03Merged) 10jenkins-bot: Don't squash images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118401 (owner: 10Jdlrobson) [21:13:04] (03CR) 10JGonera: [C: 032] Update last modified time when a template or file changes in MFResourceLoaderModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 (owner: 10Jdlrobson) [21:13:42] (03Merged) 10jenkins-bot: Update last modified time when a template or file changes in MFResourceLoaderModule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/115952 (owner: 10Jdlrobson) [21:15:47] (03CR) 10JGonera: [C: 04-1] Delay EventLogging click track until next page load (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 (owner: 10Jdlrobson) [21:20:52] (03CR) 10JGonera: [C: 04-1] Ensure the languages button is present after an edit (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118104 (owner: 10Jdlrobson) [21:20:52] brion: mailed out mobile-l! :) [21:20:52] tfinc: mailed mobile-l with instructions to opt-in to an auto-updating alpha :) do try it out [21:20:52] thanks YuviPanda [21:20:58] awesome [21:21:10] YuviPanda: will we have stats to know how many people are doing that ? [21:21:11] YuviPanda: sync up with kenan about it [21:22:20] tfinc: yeah, we will have stats. not eventlogging, but we'll have opt-in stats. we can also send a message to them all [21:23:41] tfinc: hmm, can't find him on IRC. let me drop him an email [21:24:10] sent [21:24:31] brion: am off now. night [21:25:14] mhurd: brion can you also test account creation in the apps on testwiki? I believe it will crash and fail at the moment. [21:25:19] mhurd: brion because of the API change. [21:25:35] YuviPanda: noooooooooooooooo!!!!! [21:25:38] :) [21:26:11] wheeee [21:26:59] mhurd: :) can you try it out and email me? I'm going to head off now [21:27:03] YuviPanda: should work actually [21:27:12] brion: it broke bc, right? [21:27:24] brion: oh, hmm. it didn't explicitly. just made the second request redundant. [21:27:26] it changed one case [21:27:28] yeah [21:27:31] whee [21:28:16] YuviPanda: will do [21:28:49] mhurd: ok [21:28:53] night [21:29:01] YuviPanda: 'night! [21:34:27] (03PS3) 10Jdlrobson: Ensure the languages button is present after an edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118104 [21:34:34] (03CR) 10jenkins-bot: [V: 04-1] Ensure the languages button is present after an edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118104 (owner: 10Jdlrobson) [21:38:09] (03CR) 10JGonera: [C: 04-1] Proper edit handling in case of redirects where page does not exist (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116912 (owner: 10Jdlrobson) [21:38:47] (03PS4) 10Jdlrobson: Ensure the languages button is present after an edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118104 [21:42:07] (03CR) 10JGonera: [C: 04-1] Enable Special:MobileMenu for Vector skin (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118118 (owner: 10Jdlrobson) [21:44:13] (03CR) 10JGonera: [C: 04-1] Hygiene: Kill RandomPage in favour of ArticlePage (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117371 (owner: 10Jdlrobson) [21:47:21] (03CR) 10JGonera: [C: 032] Ensure the languages button is present after an edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118104 (owner: 10Jdlrobson) [21:47:43] (03PS3) 10Jdlrobson: Hygiene: Kill RandomPage in favour of ArticlePage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117371 [21:51:10] (03Merged) 10jenkins-bot: Ensure the languages button is present after an edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118104 (owner: 10Jdlrobson) [21:56:07] (03CR) 10Jdlrobson: Proper edit handling in case of redirects where page does not exist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116912 (owner: 10Jdlrobson) [21:56:49] (03PS5) 10Jdlrobson: Proper edit handling in case of redirects where page does not exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116912 [21:56:56] (03CR) 10jenkins-bot: [V: 04-1] Proper edit handling in case of redirects where page does not exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116912 (owner: 10Jdlrobson) [22:05:24] (03PS11) 10Kaldari: QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [22:05:26] (03PS12) 10Kaldari: Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [22:05:31] (03CR) 10jenkins-bot: [V: 04-1] QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [22:05:38] (03CR) 10jenkins-bot: [V: 04-1] Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [22:08:55] (03PS12) 10Kaldari: QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [22:08:57] (03PS13) 10Kaldari: Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [22:09:37] (03CR) 10jenkins-bot: [V: 04-1] QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [22:09:41] (03CR) 10jenkins-bot: [V: 04-1] Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [22:11:27] brion: any review cycles to spare? :) [22:45:13] (03PS10) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [22:51:44] kaldari: https://gerrit.wikimedia.org/r/117904 [22:53:00] approved! [22:53:14] \o/ [22:58:36] awjr: MaxSem kaldari are you able to +2 https://gerrit.wikimedia.org/r/#/c/118328/ ? [22:58:42] or does that have to wait? [22:58:46] i always forget how stuff happens [22:58:52] and i'm not sure how we make sure it gets deployed [22:59:19] jdlrobson: Should not be +2ed until deployment time [22:59:26] ok [22:59:28] +2 means deploy, deploy means greg-g [22:59:38] * greg-g looks around [22:59:45] we'll want to schedule a deployment for it [23:00:39] greg-g: We don't have regular deployment window anymore, so when should we schedule a config deployment (not urgent)? [23:00:51] kaldari: whens good for you next week? [23:01:06] I'm fine with any day next week [23:01:16] I think we want just a LD, don't we? [23:01:26] probably [23:01:37] jdlrobson: just for clarity sake: things in the operations/mediawiki-config repo need to be sync'd out as soon as their +2/merged, as ops wants the puppet/etc stuff to be the same on machine as in master at all times [23:02:06] so, next week starts SWAT TEAM deploys... I think ;) [23:02:11] at least, ostensibly [23:02:13] you wanna take this deployment? I think you're faster than I am :) [23:02:14] I haven't warned people yet [23:02:29] MaxSem: you wanna take this deployment? I think you're faster than I am :) [23:03:03] I think MaxSem is more Swat Team material than I am [23:03:14] I can [23:05:16] so next week greg-g? [23:07:14] yeah [23:07:25] * greg-g is emailing SWAT deploy team members now [23:07:29] including MaxSem [23:13:08] whee, more responsibilities [23:27:47] (03PS1) 10Dr0ptp4kt: Add 'Send app feedback' to iOS app. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118633 [23:29:17] ^mhurd thar [23:30:45] (03CR) 10Mhurd: [C: 031] "Seems legit." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118633 (owner: 10Dr0ptp4kt) [23:34:49] hmm? We need a LD? [23:34:59] o_O [23:35:12] MaxSem: I think we want just a LD, don't we? [23:35:35] I'm confused. [23:41:51] (03PS1) 10Mhurd: Alerts now can be shown by UITableViewController too. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118637 [23:45:39] (03CR) 10Mhurd: [C: 031] "Looks solid. We can track down that weirdness with retrieveArticleForPageTitle's domain parameter in future commit. I made notes :)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118027 (owner: 10Dr0ptp4kt) [23:48:10] (03CR) 10Mhurd: [C: 031] "Looks good." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118213 (owner: 10Dr0ptp4kt) [23:50:07] brion: i +1'ed adams outstanding ios patches. a couple of them depend on my "editSummaryTweak" outstanding patch (which is good to go too i think)