[00:09:40] kaity: vbamba1: climbing? thinking about leaving at either 5:30 or 6... [00:10:10] mhurd: I really want to go again but I cant today :( [00:10:46] kaity: doh! next time! :) [00:11:43] (03CR) 10Jdlrobson: [C: 04-1] "There's an issue here - https://bugzilla.wikimedia.org/show_bug.cgi?id=62630" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 (owner: 10Jdlrobson) [00:25:42] jgonera: mark h. is climbing too! [00:36:12] (03PS1) 10Jdlrobson: Finish cleanup of new dynamic languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118649 [00:42:15] (03CR) 10Jdlrobson: "Please advise." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110649 (owner: 10Jdlrobson) [00:56:05] (03PS1) 10Dr0ptp4kt: For the Android Share feature, do not show Always option. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118652 [06:27:12] hi violetto [06:27:14] hi violetto1 [06:28:25] YuviPanda: hello! [06:29:45] violetto1: heylo! [06:30:21] violetto1: hmm brr on the play store not working. maybe as more people try it out I can see exactly what is wrong :| [06:30:57] YuviPanda: that's fine, im not that bothered with uninstalling and installing [06:31:07] works fine for now :} [06:31:13] violetto1: ok :) [06:31:29] violetto1: left nav settings. I left a comment on the card. [06:31:36] violetto1: about having the settings be a screen than inline. [06:31:41] YuviPanda: /checkin [06:32:29] violetto1: ok! [06:35:24] YuviPanda: weird.. not sure why i cannot install the latest build [06:35:28] the one that brion sent out [06:35:50] violetto1: you should uninstall any other builds you have first. they are signed differently, I think [06:37:43] YuviPanda: ok worked! [06:37:48] violetto1: woo [06:37:55] hang on, looking at card again [06:38:33] violetto1: ok! [06:38:48] violetto1: look at how settings are right now in the current app. Hopefully we can just keep it that way [06:40:40] YuviPanda: i think if time is constraint and we can use it for improving other places, i am fine with it being a separate screen [06:41:05] it'll be great if we could have it in the same space, but compared with other things, i dont think it's like super critical [06:41:17] violetto1: yeah. Android has a built in framework for doing preferences like how they are right now, and I would just want to re-use that. [06:41:24] violetto1: ok! can you respond on the card? [06:42:43] yeah, as you can see also i tried to incorporate how it is on android. what's not brought over are the chrome and being on a separate screen [06:43:33] violetto: there? [06:44:59] violetto1: hey [06:45:42] violetto1: and the color is a bit weird for me too :P But that's trivial to change, so I'm going to just follow whatever you guys decide on [06:54:52] YuviPanda: we're trying on some of our new palette :} [06:55:00] making it more inviting! [06:55:09] articles are black and white enough [06:55:28] violetto1: it doesn't look very inviting to me (reminds me of the green Gerrit used to be), but as I said, I'm not going to argue on colors :P [06:56:13] YuviPanda: im glad, cus if people dont like it and turns out it's not inviting at all, we should change it [06:56:23] to pink or something else [06:56:42] violetto1: yeah. we could make it pink striped with a bright yellow, with pulsing red/green dots. [06:56:44] :P [06:57:01] YuviPanda: that would be one of the things to do in april [06:57:05] violetto1: but yeah, it's trivial to change, and I'm going to just put on whatever hex things you tell me [06:57:11] violetto1: in fact, can you give me the hex value now? [06:57:31] violetto1: for background and foreground? [06:58:36] YuviPanda: it's 00af89 [06:58:45] text is just white [06:58:49] violetto1: ok [07:00:41] violetto1: also what are we gonna do with the search bar? [07:00:48] violetto1: mockups don't show search bar anywhere [07:00:53] violetto1: are we just going to push it to the left too? [07:02:54] YuviPanda: yeah. too many tap areas in side bar [07:03:51] plus, when users go to left drawer, they want left drawer stuff [07:03:58] violetto: bah, lost connectivity for a bit [07:04:02] violetto: 'mockups doun't show search bar anywhere'. 'are we just going to push them to the left?' [07:09:02] hi violetto1 [07:09:18] violetto1: 'mockups do not show search bar anywhere'. 'are we just going to push them with the content'? [07:09:20] YuviPanda: why hello again [07:09:28] YuviPanda: yeah [07:09:31] violetto1: ok! [07:09:37] violetto1: and no lines between the list items. [07:09:56] too many tap areas in side bar :/ [07:10:02] yeah no lines [07:10:34] violetto1: ok. [07:13:27] violetto: hey. is this you on irccloud? [07:13:40] YuviPanda: irccloud, yo! [07:13:48] violetto: flood of messages? :S [07:13:49] err [07:13:50] :D [07:13:55] YuviPanda: haha yea [07:14:12] YuviPanda: but glad i only received it now [07:14:13] ;P [07:14:17] hehe [07:14:21] violetto: hehe [07:15:02] i got oreiley's html5 cookbook today [07:15:09] YuviPanda: im going to be cookin [07:15:22] violetto: naiccce :) [07:16:06] violetto: https://www.dropbox.com/s/4yy2cs27nbyn059/Screenshot_2014-03-14-12-44-44.png [07:16:14] violetto: need to get pure white icons, I guess. [07:18:09] YuviPanda: do you got the WMFDesign dropbox? [07:18:29] violetto: no. you should invite yuvipanda@gmail.com, i kept getting invites to yuvipanda@wikimedia.org [07:19:14] YuviPanda: done [07:19:20] violetto: sweet. [07:19:28] violetto: I have to build the asset pipeline, though. next week. [07:19:34] violetto: I'll just have these shitty icons till then :D [07:20:52] YuviPanda: shitty icons sounds good to me for the first time! [07:20:55] (for now) [07:21:02] violetto: yeah. I can redo them next week. [07:21:14] YuviPanda: yeap [07:22:12] (03PS1) 10Yuvipanda: Design tweaks for nav drawer [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118670 [07:22:16] violetto: there :) [07:22:39] violetto: are we going to have the 'split' view? how did the discussion on that go? [07:22:46] (03PS14) 10Kaldari: Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [07:23:44] YuviPanda: split view on ToC or left drawer? [07:24:33] violetto: left drawer. top and bottom split [07:24:42] oh [07:25:32] YuviPanda: we decided on using line to differentiate [07:25:38] or organize [07:26:15] violetto: hmm, so what color are the lines? [07:26:25] violetto: or should I just wait for you to redo the mockup? [07:28:00] line color is 038368 [07:28:04] YuviPanda: [07:28:09] violetto: ok [07:29:14] YuviPanda: i'd love for it to be at the bottom but if it's hard to do to change gap height when swtiching from portrait and landscape then, meh [07:29:35] i can just go with line like what they wanted [07:29:40] hmm? it's not really hard, rather trivial. they will just squish up if there isn't enough space. [07:29:56] squish up as in come together. [07:30:12] YuviPanda: kenan and monte said it was going to be hard that's why we're not doing it [07:30:24] violetto: oh. technically hard you mean? [07:30:36] to change the height gap from portrait to landscape. yeah [07:30:38] i believe so [07:34:41] violetto: gah, I got dc [07:34:43] violetto: I can do it in Android if you want. Android should handle that automatically for me [07:34:45] violetto: ok, I'm just going to do the split. lines look ugly, and having the lines come up just under the text is just as much work anyway. [07:35:21] YuviPanda: yay! [07:35:23] yes please [07:35:43] violetto: ok. I'm going to get rid of the icons also and replace them with white squares for now. the shadows are irksome. [07:36:22] YuviPanda: they really make the icons pop [07:36:32] violetto: the shadows? [07:36:41] YuviPanda: ;P [07:36:49] violetto: we could have pink shadows :P [07:37:17] YuviPanda: pink marching ants [07:37:35] violetto: haha. alternating pink and fuschia marching ants. [07:37:49] YuviPanda: all these good ideas must be documented [07:37:58] violetto: indeed. this channel is logged [07:38:05] YuviPanda: done! [07:38:07] haha [07:38:16] YuviPanda: ok man im going to zzzz [07:38:17] violetto: give me a hex for a bright pink? [07:38:22] violetto: ok, give and then sleep :) [07:38:41] what about this one YuviPanda ff00ff [07:38:43] hahahaha [07:38:50] violetto: :P [07:38:57] * YuviPanda uses that [07:39:12] YuviPanda: lol! [07:39:21] ok person, i hope you feel better today [07:39:24] violetto: I'm using that color for the icons until we get proper icons :) [07:39:29] violetto: :) I hope you do too! [07:39:31] violetto: good night! [07:39:32] YuviPanda: i'll be up early manana, talk then! [07:39:38] nite! [07:39:40] violetto: night! [09:12:13] (03PS2) 10Yuvipanda: Design tweaks for nav drawer [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118670 [09:23:29] (03PS3) 10Yuvipanda: Design tweaks for nav drawer [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118670 [10:32:41] (03PS1) 10Yuvipanda: ToC design tweaks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118680 [10:33:36] (03PS1) 10MaxSem: Revert "Ensure checkToggleView() fires at appropriate time" - infinite recursion again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118681 [10:34:45] (03CR) 10MaxSem: [C: 032] Revert "Ensure checkToggleView() fires at appropriate time" - infinite recursion again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118681 (owner: 10MaxSem) [10:35:22] (03Merged) 10jenkins-bot: Revert "Ensure checkToggleView() fires at appropriate time" - infinite recursion again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118681 (owner: 10MaxSem) [10:36:40] (03PS2) 10Yuvipanda: ToC design tweaks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118680 [10:58:49] (03PS1) 10MaxSem: Revert "Ensure checkToggleView() fires at appropriate time" - infinite recursion again [extensions/MobileFrontend] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118683 [10:59:04] (03CR) 10MaxSem: [C: 032 V: 032] Revert "Ensure checkToggleView() fires at appropriate time" - infinite recursion again [extensions/MobileFrontend] (wmf/1.23wmf17) - 10https://gerrit.wikimedia.org/r/118683 (owner: 10MaxSem) [10:59:29] (03PS1) 10MaxSem: Revert "Ensure checkToggleView() fires at appropriate time" - infinite recursion again [extensions/MobileFrontend] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118684 [10:59:43] (03CR) 10MaxSem: [C: 032 V: 032] Revert "Ensure checkToggleView() fires at appropriate time" - infinite recursion again [extensions/MobileFrontend] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/118684 (owner: 10MaxSem) [11:06:34] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed. Looks okay." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118633 (owner: 10Dr0ptp4kt) [14:53:20] (03CR) 10Cmcmahon: [C: 032] Hygiene: Kill RandomPage in favour of ArticlePage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117371 (owner: 10Jdlrobson) [14:53:59] (03Merged) 10jenkins-bot: Hygiene: Kill RandomPage in favour of ArticlePage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/117371 (owner: 10Jdlrobson) [15:00:19] (03CR) 10Cmcmahon: [C: 032] Hygiene: Remove undefined test and unused rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118209 (owner: 10Jdlrobson) [15:00:24] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove undefined test and unused rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118209 (owner: 10Jdlrobson) [15:55:14] (03PS2) 10Cmcmahon: Hygiene: Remove undefined test and unused rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118209 (owner: 10Jdlrobson) [15:55:21] (03CR) 10Cmcmahon: [C: 032] Hygiene: Remove undefined test and unused rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118209 (owner: 10Jdlrobson) [15:56:05] (03Merged) 10jenkins-bot: Hygiene: Remove undefined test and unused rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118209 (owner: 10Jdlrobson) [16:11:54] (03PS1) 10Cmcmahon: QA Needs a when_present for slow browsers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118710 [16:12:28] (03CR) 10Cmcmahon: [C: 032] QA Needs a when_present for slow browsers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118710 (owner: 10Cmcmahon) [16:13:09] (03Merged) 10jenkins-bot: QA Needs a when_present for slow browsers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118710 (owner: 10Cmcmahon) [16:22:36] hey awjr [16:22:57] infinite recursion have stricken again [16:23:10] Hi MaxSem [16:23:13] Fml [16:23:31] Similar to last time? [16:27:33] I'm not at my desk/laptop yet, but I will be in maybe 15 mins MaxSem and can look into it then [16:49:45] MaxSem: where is the infinite recursion happening? [16:52:01] awjr, https://gist.github.com/MaxSem/4c9e4417e13e22e2d025 [16:54:30] MaxSem: when I hit the URL in the bug, I get properly redirected to the .m [16:54:44] yep. because I reverted it [16:54:48] s/bug/stacktrace [16:54:49] oh [16:54:49] heh [16:54:58] what was the problem commit? [16:55:11] or did you just revert to previous branch? [16:55:36] https://gerrit.wikimedia.org/r/#/c/116180/ [16:56:07] same as before [16:56:51] ok, thanks for reverting [16:57:02] i can probably spend some time reworking this later in the afternoon [16:57:06] i'm in meetings all morning [16:57:44] hmm, no brion [17:10:40] (03PS1) 10Zfilipin: WIP QA: Update mediawiki_selenium gem to honor optional useragent string per MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118720 [17:11:28] hey mhurd [17:11:32] hi violetto [17:11:34] YuviPanda: heya! [17:11:36] hmm, no brion yet [17:12:13] YuviPanda: sup [17:12:35] violetto: we need to find brion to merge it, and once we have the icons I'll make another alpha build :) [17:12:53] YuviPanda: okay! exporting as we speak [17:13:11] violetto: the navbar patch also removed some zero related notification stuff from the left nav menu. should work with dr0ptp4kt to bring them back at an appropriate place [17:13:16] s/navbar/left nav/ [17:13:39] mhurd: I wanted a break from the login stuff, and there was some quality may time available earlier today, so I finished up the left nav and ToC stories :D [17:14:00] YuviPanda: woohoo!!!! [17:14:03] nice [17:14:27] s/login/editing/ [17:14:57] violetto: can you just email me a zip this time? :D [17:15:06] YuviPanda: can [17:15:09] violetto: ty! [17:15:30] mhurd: standup? or am I in wrong hangout? [17:15:46] (03PS2) 10Dr0ptp4kt: Add 'Send app feedback' to iOS app. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/118633 [17:16:21] hey brion! [17:16:34] yo [17:16:50] brion: I finished up most of ToC and navbar yesterday :D patches await [17:16:55] awesome [17:16:57] jdlrobson: can you dbl check about whether or not we need an LD for that bug? [17:17:32] brion: awjr can you turn off video? :) i am latency constrained today [17:17:35] awjr: yep sure first thing on my list [17:17:44] sure [17:17:50] thanks dude [17:18:33] awjr: okay - so the language button doesn't open an overlay [17:18:44] it does take you to Special:MobileLanguages though [17:19:00] so it's janky but functional? [17:20:03] violetto: I might be able to participate in meetings today! My phone handles it much better than my laptop :D [17:22:00] YuviPanda: [17:22:01] https://www.dropbox.com/s/3xgmehj8pvnlm57/AndroidLeftDr.zip [17:22:06] please do! [17:22:35] awjr: users can still get languages it just looks broken and the experience is inconsistent [17:23:16] ok, i feel ambivalent/on the fence about whether or not to LD a fix then; let's get kenan to make a call (he's in the apps standup atm) [17:23:23] violetto: sweet :) [17:23:30] awjr: brion my hangout crashed midway [17:23:35] :( [17:23:38] dr0ptp4kt: you might be interested in https://gerrit.wikimedia.org/r/#/c/118670/ [17:23:38] aww [17:23:53] brion: awjr my connection isn't good enough for me to do it from laptop but good enouhg from phone [17:23:53] so [17:24:02] awjr: brion I rotated my phone accidentally and it crashed :D [17:24:06] lol [17:24:08] lol [17:24:59] (03PS15) 10Kaldari: Story 1521 WIP: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [17:26:26] also jdlrobson MaxSem kaldari any out-of-band deployments we know about coming up next week? [17:29:01] or YuviPanda brion mhurd dr0ptp4kt yurikR ^ [17:29:23] awjr: nothing that I know of, although brion / MaxSem might want to deploy the captcha related stuff in one go. [17:29:37] (03CR) 10Brion VIBBER: "Would text-overflow: ellipsis work here instead of manually cropping the strings to a char length?" (031 comment) [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/115320 (owner: 10Dr0ptp4kt) [17:29:44] awjr, nothing i know of, just the usual wednesday stuff most likely. +yurikR [17:29:47] YuviPanda: brion MaxSem bug/patchset? [17:29:47] is it that urgent? [17:29:56] cool cool thanks dr0ptp4kt [17:30:00] MaxSem: i don't think it's super-urgent [17:30:06] we can let it go through the release train [17:30:09] MaxSem: brion I don't personally care either. [17:30:10] unless we really want it now :) [17:30:29] as long as it hits test soonish we'll be fine [17:31:00] * brion charges up the ol' firefox os phone :D [17:32:02] (03CR) 10Dr0ptp4kt: Shorten text in