[00:46:59] Hey. Is there room for and more person to contribute to the Wikipedia app? [07:26:34] woo brion [07:26:40] heyyyy [07:27:32] brion: heading to sleep? :D I can't interest you with CR atm, I guess? [07:27:50] hehe sleep soon cr later [07:28:15] brion: hope you had a nice weekend :) [07:28:19] yep [07:28:21] brion: and have a good night! :D [07:28:33] brion: today's holi, so I might come back more colorful than usual :) [07:28:39] \o/ woohoo [07:29:00] happy holi days [07:31:33] brion: hah! Thanks [07:47:22] nighty night :D [09:11:42] (03PS1) 10Yuvipanda: Get rid of old values-iw and symlink it to values-he [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119015 [09:16:51] (03PS1) 10Yuvipanda: Add python script that generates pngs from svgs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119016 [09:53:14] (03PS2) 10Yuvipanda: Add python script that generates pngs from svgs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119016 [09:53:16] (03PS1) 10Yuvipanda: Add icons to left nav [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119017 [16:46:35] i have a draft proposal for wikimedia commons android app ? [16:57:38] hi nateshr_ [16:57:43] do you have a link i can look at? [16:59:40] brion:https://www.mediawiki.org/wiki/User:NateshR/Gsoc_Proposal_2014 [16:59:53] "this video call isn't available now" [17:00:48] MaxSem: apparently google services are disrupted [17:00:52] yay for the cloud [17:01:03] skype? [17:01:42] nateshr__: nice [17:01:58] brion: thanks [17:02:07] nateshr__: do you know if you can already get the info you want through the existing api or will you need server-side components to report the data sets as well? [17:02:09] I have doubts in estimated project timeline [17:02:11] hangout is broken :( [17:02:13] VE team having issues also ;/ [17:02:48] awjr_away: ^ [17:02:52] jdlrobson, I'm getting This video call isn't available right now. Try again in a few minutes. [17:02:59] I haven't got much deep but i think i'll need server-side compnents to report data [17:03:05] yeah I'm getting same thing [17:03:10] anyone able to join? [17:03:21] brion: but there are JSON api's of commons website [17:03:23] kaldari, jgonera, awjr_away, kenanwang - skype? [17:03:49] We could do a IRC hangout [17:03:50] MaxSem, can we call several people without skype premium (or whatever they call it)? [17:03:54] google services are down [17:04:01] MaxSem: Does anyone have a premium skype account? [17:04:02] IRC hangout okay? [17:04:20] I'm fine with IRC [17:04:23] I think sorta have [17:04:28] Okay let's do it here. [17:04:38] ok here is fine [17:04:50] jdlrobson: you want to go first? [17:04:56] sure [17:05:29] Since we last met: I spent most of the time finishing up code review on some bugs and getting patches merged and finalizing work on Vector Beta fixed header (Winter) [17:05:55] brion: I haven't got much deep but i think i'll need server-side compnents to report data [17:05:59] Today: I'm going to be running the retrospective, so have to do a little planning for that and reviewing any code in Gerrit for this iteration before next kick off [17:06:03] nothing blocking me [17:06:07] jgonera: you want to go next? [17:06:10] sure [17:06:12] nateshr__: *nod* i'm adding some notes on the talk page [17:06:31] spent a couple of hours (or more) with Trevor merging changes to VE related to link inspector [17:06:38] will continue with styling today [17:06:50] brion: which page ? [17:07:00] I also finished patches for the compact personal bar which are a dependency for Winter [17:07:29] EOM? [17:07:33] and I tried to figure out the next coding task for frontend candidates. I have two ideas and will post them on mobile-tech shortly [17:07:42] EOM [17:07:45] jgonera: do you need any help with that? [17:07:51] (coding task) [17:08:06] nateshr__: https://www.mediawiki.org/wiki/User_talk:NateshR/Gsoc_Proposal_2014 [17:08:19] yeah, comments before 3pm (when I'm talking with Emily) [17:08:36] jgonera: okay cool. i'll make sure i take a look [17:08:41] kaldari you want to go next? [17:08:48] sure [17:09:59] brion : recommend making the queries something that can be shared with JavaScript web code or iOS app; try to keep it non-app-specific so it can be reused later [17:10:10] brion: can you explain it a little more ? [17:10:42] (MaxSem: you may want to pre-author your message to speed this up :-)) [17:10:55] nateshr__: if you create any custom API modules, just keep them fairly generic if possible [17:11:07] like, don't build in assumptions about android screen resolution [17:11:18] Friday, I finished up the editor switcher (https://gerrit.wikimedia.org/r/#/c/111367/), but there are 2 minor issues with it: 1. The negative margins cause positioning problems for the dropdown menu in Firefox and IE, but not Chrome or Safari. 2. The behavior of the close box after switching between editors is unintuitive since we're treating each editor load as a separate page for the purposes of back-button behavior and our close box current [17:11:19] triggers back-button behavior. [17:11:21] maybe let things like that be a parameter you pass that could be different when used in another app [17:11:41] brion: as i don't have the knowledge of creating api's , so i'll have to learn about it [17:11:44] kaldari can you move the card in mingle? [17:11:50] The first issue I'm talking with design about. The second issue I need other folks input on decising how to proceed. [17:11:53] hi brion [17:11:55] nateshr__: :) [17:11:57] hey YuviPanda [17:12:00] hangouts are broken [17:12:04] We might just want to go ahead how it is, I dunno. [17:12:11] oh MaxSem i guess you're still working on it [17:12:17] brion: and what about estimated project timeline part ? [17:12:24] brion: aah [17:12:25] I mean that to go to kaldari [17:12:36] * YuviPanda shuts up while web standup goes on. [17:12:50] nateshr__: you might want to add in some time for examining the API [17:12:59] kaldari: / kenanwang do you want to discuss that issue later today and work out how best to resolve it? [17:13:06] Today, I'm going to review my editor switcher changes (since it's a lot and I haven't reviewed it thoroughly myself), then I will be reviewing other people's code until the new iteration. [17:13:10] brion: ok [17:13:20] EOM kaldari ? [17:13:27] (i don't hear your keyboard any more ;-) [17:13:27] yeah kaldari let's discuss the second message [17:13:30] brion: and what about the proposal, is it ok ? [17:13:45] MaxSem: you want to finish us off? [17:13:47] kaldari: and let's get design input on first issue [17:13:48] minifier (please review!), today participated in the first SWAT depoy ever, fixed hatjitsu that was broken by labs migration. please respond on email ASAP if you want your instances to live [17:13:51] jdlrobson: English-only movement [17:13:53] ? [17:14:05] yes :) [17:14:13] MaxSem: nice - how did the SWAT deploy go? [17:14:24] MaxSem: good to hear minifier is moving [17:14:31] MaxSem: I'll help you out with minifier reviewing [17:14:35] nateshr__: yeah [17:14:50] it was uneventful [17:14:51] brion: thanks [17:14:58] That's everyone since arthur is on vacation today. Shall we do a quick bug triage? [17:15:06] brion: if i got stuck somewhere , we'll ask ? [17:15:12] MaxSem: can you move minifier in mingle as well? [17:15:17] jdlrobson: yes [17:15:24] kenanwang: yeh we should create some cards for minifier [17:15:28] it will help move it along better [17:15:32] give it better transparency [17:15:39] we should discuss after [17:15:40] jdlrobson: oh it's time for the app sprint now [17:15:47] but not story cards I suppose? [17:15:48] nateshr__: sounds good :D [17:15:52] kenanwang: haha ok well i guess you are doing it here [17:15:58] kenanwang, only to backlog. now gotta finish writing an RFC [17:16:01] brion: thanks :) [17:16:01] so afterwards ping us for the bug triage :) [17:16:03] *the RFC [17:16:24] brion, YuviPanda, [17:16:25] brion: should i submit it after completing ? [17:16:39] hang out was done eariler [17:16:46] kenanwang: hey! [17:16:52] kenanwang: brion I'll go first. [17:16:58] seems like it's still down [17:17:06] anyone see monte? [17:17:26] we can do standup on irc but monte is not here [17:17:31] i'm not in the office yet [17:17:50] kaldari: jdlrobson is monte around? [17:17:52] hmm, yeah. [17:17:56] nateshr__: (sorry we're having a short meeting so this channel is a little busy atm :) [17:17:57] if so can you tell him to get on IRC? [17:18:04] kenanwang: he was 1s [17:18:10] brion: no problem [17:18:22] jdlrobson, kenanwang: Actually, looking at the switcher card, it looks like I'm not quite finished. Still need to add event logging and the warning message. I'll work on those today. [17:18:25] brion: thanks [17:18:38] kenanwang: no monte [17:18:41] kaldari: ok [17:18:57] well lets go ahead and start i guess [17:19:03] YuviPanda: ? [17:19:06] ok [17:19:13] ah, here's mhurd :) [17:19:14] Monte is on his way [17:19:22] YuviPanda: brion heya! [17:19:26] hey mhurd [17:19:27] found him in the kitchen looking at a broken google hangout screen [17:19:32] haha [17:19:40] heheh [17:19:49] thanks jdlrobson! [17:19:56] ok let's start [17:20:00] anyway, so, 1. Wrote up a 'PNG generator' that will generate appropriately sized assets for icons from SVGs that the designers make. Removes a tedious process from their workflow of exporting icons at various sizes. Still have some guidelines to work out, but is in mergeable state [17:20:14] 2. Left nav has proper icons now. [17:20:24] 3. Fixed some issues with search related bugs from feedback received (from ragesoss!) [17:20:33] nice! [17:20:35] \o/ [17:20:37] YuviPanda, is that something others can use or Android/Java-specific? [17:20:51] 4. Adam has requested a specific google group for the feedback channel, so the feedback form doesn't send to me :P [17:21:13] jgonera: the sizes I use it for are android specific jgonera. Can be easily extended for any set of sizes (I assume you would want it for 1x and 2x) [17:21:25] jgonera: and I'll be happy to extend it for you as well :) [17:21:44] *channeling tomasz* we have some things in the sign off column - let's get those taken care of today [17:21:52] YuviPanda, cool. sometimes I need custom size because SVGs from designers come in somewhat random sizes [17:22:08] 5. Alpha is speeding up. Have about 35 users already :) I'll be pushing another alpha to the play store once these patches get merged [17:22:14] that's about it from me. [17:22:32] YuviPanda: I'm going to sign off on the card for preview signup [17:22:38] kenanwang: sweet! :) [17:22:40] but I'm going to create another card for license [17:22:45] to track that issue [17:22:46] kenanwang: that sounds good [17:22:54] kenanwang: I'll move the login card to this sprint. [17:22:57] also, i had trouble with getting onto the alpha [17:23:05] brion: are your ios rtl changes good to go? they looked ok to me [17:23:15] kenanwang: were they resolved? [17:23:16] mhurd: i think so [17:23:26] kenanwang: the link shows the old app, but should install the new one. [17:23:47] no it installed the old app for me YuviPanda [17:23:55] mhurd: does it give you the +2 option on it or shall i do that? [17:23:55] let's talk later [17:23:58] kenanwang: ok [17:24:11] brion: you want to go? [17:24:24] brion: ah go ahead - didn't know i did it wrong hehe [17:24:57] kenanwang: looks like the two 8 pt stories are going to carry over [17:25:10] kenanwang: i'm ready to do some code review & cleanup and probably grab some of the smaller iOS bits [17:25:16] ok mhurd [17:25:19] kenanwang: also i noticed something on my calendar about setting people up for iOS beta [17:25:40] what's the plan there? [17:25:41] brion: there's a bug that you fixed about android lead section editing but i didn't see that in the last build i got [17:26:04] brion: well I wanted to talk about how we want to get these builds out to them [17:26:12] kenanwang: it was merged after that. It'll be on the alpha that goes out today. (the lead-section-editing) [17:26:14] i'm wrapping the 8pt story - do we want to do another hangout tomorrow to kick off sprint 27? [17:26:19] kenanwang: that patch looks merged, should be in your next alpha update yeah [17:26:29] should we use testflight or just email? [17:26:31] kenanwang: great i'll be in the office by then, grab me :) [17:26:38] ok [17:26:40] kenanwang: ^ [17:26:40] sounds good [17:26:49] testflight definitely [17:26:57] mhurd sounds good on doing another hangout tomorrow [17:27:06] kenanwang: i think we can blast out an invite request URL [17:27:09] i'll just have to look it up [17:27:25] ok cool brion [17:27:33] mhurd: you wanna go? [17:28:12] kenanwang: go? [17:28:19] mhurd: standup on IRC! :) [17:28:20] give your update [17:28:31] kenanwang: ah [17:29:17] so i got most of the 8pt story for prompting user to log in during edit workflow - needs a couple more hrs work so hopefully wrapping it up today [17:29:46] that's about it [17:30:03] YuviPanda: how's the "create acct auto logs user in" story coming along? [17:30:33] mhurd: it actually logs the user in right now. May did some UX nicities that I haven't added yet - did a refactory patch but that got too big, so it's in a side-branch [17:31:19] YuviPanda: cool! what should i do with the card? carry over? [17:31:25] mhurd: yeah, I think so [17:31:44] YuviPanda: done! [17:31:47] mhurd: ,brion ,YuviPanda , I'm moving stuff in ready for sign off to next sprint [17:31:57] kenanwang: ok [17:32:06] kenanwang: cool! what about the To Do stuff? [17:33:00] kenanwang: carry over or backlog? [17:34:40] i moved one over and backlogged one mhurd [17:34:43] kenanwang: thanks! [17:34:47] brion: CEEEAAARRR! [17:34:55] kenanwang: archive the board? [17:35:06] or close or whatever? [17:35:55] mhurd: kenanwang violetto can we move this week's priori meeting to thursday, instead of friday? I might have to go off early on friday, and can't stay up till 1:30AM saturday. [17:36:03] kenanwang: for metrics, we had 10 story points done [17:36:37] mhurd: sure [17:37:02] mhurd: you should let tfinc calculate it when he comes back. it's more complicated than that. I think it'll count as something like 35 or somesuch [17:37:10] YuviPanda: brion and i have an interview 10:50 to 11:35 am thursday [17:37:14] mhurd: because we signed off on about 25 or so points on last monday from the iteration before that :P [17:37:46] YuviPanda: tfinc told me to make a note of how many points we'd done. [17:37:47] YuviPanda: I'm ok moving the prioritization mhurd [17:37:48] mhurd: brion I can do post lunch on thursday. [17:38:01] mhurd: ok :) [17:38:11] YuviPanda: sounds good! [17:38:40] mhurd: kenanwang thanks! :) [17:40:44] ok packing up and heading in in a bit [17:40:47] violetto: ! [17:43:00] YuviPanda: !! [17:43:47] violetto: https://www.dropbox.com/s/runrnda2xciw7mo/2014-03-17%2009.49.46.png [17:43:51] kenanwang, is the app standup done? should we triage the bugs for web? [17:43:52] violetto: something's wrong with the icon sizes. [17:44:00] jgonera: app standup done [17:44:12] YuviPanda: those are huge [17:44:23] kenanwang, or possibly do it next standup since there are only 3 bugs? [17:44:30] violetto: yeah. those are output at 32px. [17:44:39] violetto: hmm, I guess I could make them smaller. [17:44:50] YuviPanda: i see. okay. otherwise let me know what i can do [17:46:06] violetto: can you tell me the canvas size of the 'dice_white' image, and also the bounds of the actual image itself? (i.e. without padding) [17:47:15] YuviPanda: both at 96px [17:47:35] violetto: hmm, alright then. moment [17:47:40] YuviPanda: kay [17:48:02] violetto: so whenever you build icons, you are going to *not* include padding at all unless strictly necessary (to make it square) [17:48:06] violetto: can I assume that? [17:48:10] violetto: at least for the icons I am using right now [17:49:19] YuviPanda: basically when i have a new icon, i make a 96x96px canvas, then i fit the icon in there as much as i can. the height or the width will be at 96px in all icons. does that make sense? [17:49:53] violetto: so in almost all cases, the icon will be touching the edges of the canvas [17:50:23] YuviPanda: yah [17:50:32] violetto: cool, that's what I wanted :) [17:50:38] YuviPanda: ;D [17:50:50] violetto: redoing now, let me send screenshot [17:50:53] oki [17:56:00] violetto: sent you new screenshot, still looks a *little* odd, but much better [17:57:33] YuviPanda: my email? [17:57:40] violetto: ya [17:57:52] YuviPanda: okay /waiting [18:02:26] kenanwang: When should we discuss close button behavior? [18:02:29] YuviPanda: got it, what about reducing the size of the box? [18:02:47] violetto: it's a 32dp box now, 24dp + 8dp padding [18:03:00] violetto: used to be 48dp, 32+8dp [18:03:06] YuviPanda: oh wow [18:03:40] YuviPanda: shall i then reduce the size of the icons in the svg instead? [18:03:55] i'd do that as a last option [18:04:14] violetto: I can reduce the size of the icons some more. [18:04:17] 16? [18:04:24] that means changing every single icons in the folder so they're proportionately accurate [18:04:28] kaity: I'm supposed to follow-up with you about the header styling. BTW, I discovered it's even worse than I thought. Firefox and Internet Explorer ignore the negative margin of the child element, but Chrome and Safari don't. Stupid browsers! [18:04:34] YuviPanda: yeah can try [18:04:35] violetto: my script can auto resize :P [18:04:42] oh reallss [18:04:43] hahha [18:05:01] kaldari: silly browsers! [18:05:19] violetto: :P The only thing that matters in svg now is padding and the aspect ratio of the images [18:05:37] YuviPanda: i see [18:05:47] can we keep those margins on everything for now, but for VE toolbar selected states, dont change background square behind a button [18:05:57] just change the icon itself to blue? [18:07:25] violetto: but the random 'looks' bigger than the clock, even though they are the same size. [18:07:58] YuviPanda: the random takes up most space in the 96px box [18:08:02] just illusion [18:08:35] violetto: yeah, I realized. but otherwise still 'looks' like that. [18:08:41] violetto: 'tis ok if it's ok for you :) [18:09:37] violetto: do you want me to try another color? :P [18:09:40] kaity: I experimented with it yesterday and the bug happens if anything in the toolbar has a negative margin (including the close and next buttons). Another option would be just removing the negative margins so that the buttons don't extend past the CSS box of the toolbar. [18:09:48] YuviPanda: when you increase padding for one icon, it will be the same for every other ones right? [18:10:38] violetto: yeah, I increased for everything [18:10:56] kaldari: ok lets do it [18:10:59] kaity: It may also be possible to rebuilt the toolbar differently (using absolute positioning instead of negative margins) [18:11:01] YuviPanda: in that case it sounds like I should change the sizes within the svg [18:11:17] violetto: I can change it for individual ones too [18:11:21] violetto: the script is pretty flexible :P [18:11:35] YuviPanda: in that case, increase more only for the dice and see how it looks [18:11:40] kaldari: can we make everything the same size though? like if we remove margins, can we also increase height so that it appears the same [18:11:57] violetto: I'll make it 20+12 rather than 24+8. [18:12:04] YuviPanda: kay! [18:14:03] kaity: yes, it's somewhat tricky though since the size is a combination of pixels (the graphic for the button) and ems (the margin around the toolbar). Unfortunately, you can't say "height: 40px + 0.35ems" in CSS, so we would probably need to change the margin to be in pixels as well in order to get the absolute positioning and sizing to work correctly. [18:14:36] violetto: https://www.dropbox.com/s/67k9mn2wbxz1kf8/2014-03-17%2018.14.05.png [18:14:37] kaldari: ok [18:15:42] kaity: actually, I may have misunderstood you. Are you talking about switching from negative margins to absolute positioning but keeping the whatspace around the toolbar, or are you talking about ditching the extra whitespace entirely? [18:15:53] ditching the extra white-space entirely is trivial [18:15:55] YuviPanda: whoa alot better! [18:16:05] violetto: how about the message envelope? [18:16:06] the bookmark can use some too [18:16:24] kaldari: will absolute positioning work in all browsers? [18:16:25] YuviPanda: yeah so does the envelope and user icon [18:16:34] kaity: probably [18:16:57] kaldari: is it a cleaner way to build it? sounds better to me? [18:17:00] violetto: oh, user also? [18:18:11] kaity: I wouldn't say it's cleaner, but it will probably fix this particular bug. [18:18:12] YuviPanda: yeah [18:18:16] violetto: doing [18:18:47] kaity: it'll still be a bit complicated [18:19:27] maybe we should get together with violetto and maybe another engineer to discuss? [18:19:46] kaity: sounds like a good idea [18:20:04] kaity: about header? [18:20:12] kaity: juliusz did the existing work on the header so would be good to have him involved [18:20:13] violetto: yes [18:20:22] kaity: ok! [18:20:27] not sure where he is though [18:20:28] kaldari: ok I'll set it up for today [18:20:36] kaity: Thanks! [18:20:59] vbamba: hey! [18:22:32] violetto: looks much better :D [18:23:44] violetto: https://www.dropbox.com/s/jqne71eaokfrd43/2014-03-17%2018.22.22.png [18:24:19] YuviPanda: yes!! [18:24:27] YuviPanda: awesome!!!! [18:24:33] mhurd: :) [18:24:44] YuviPanda: the bookmark can do more padding [18:24:51] and abit more to dice and envelope too [18:25:06] violetto: i don't think the envelope is fully 96x96 [18:25:12] YuviPanda: im using the clock as reference [18:25:20] YuviPanda: oh really lemme check [18:25:20] violetto: maybe the clock is wrong? [18:25:48] YuviPanda: the envelope's width is 96px [18:26:06] YuviPanda: the clock, user icon, and settings look perfect [18:29:46] violetto: sorry, got dc [18:29:49] violetto: what did you say? [18:30:00] YuviPanda: didn't realize. what did you last see me say? [18:30:27] https://www.irccloud.com/pastebin/gltkb2qF [18:32:26] violetto: ah [18:32:33] violetto: so, what do you want me to add padding for? [18:32:42] violetto: i also think it looks weird because envelope isn't fully square. [18:32:44] let me verify [18:32:54] YuviPanda: the bookmark, more to dice and envelope [18:34:46] violetto: oh, no, I think I figured out why they look a bit weird [18:34:48] fixing [18:34:55] YuviPanda: what happened? [18:34:58] okay! [18:47:28] vbamba: hmmm... maybe to keep it simple just show this (http://imgur.com/NWPujpk) every time unauthenticated user tries to sign in? that way no need to show 3rd option (the don't bug me one) [18:48:33] YuviPanda: congratulations on passing your exams at school (I forgot to tell you that) [18:48:48] preilly: ty! :) [18:48:58] preilly: it's been 2 months and I still don't have a certificate, though :( so can't start h1b [18:49:00] violetto: https://www.dropbox.com/s/uezeefuistamsgu/2014-03-17%2018.48.21.png [18:49:04] violetto: looks better! [18:49:08] YuviPanda: nothing like a glitter pen to help you make a real mark [18:49:27] preilly: hehe :D Valuble life skill, I learnt [18:50:03] mhurd: that'll add an extra click *every time* someone who is anon would want to edit, no? Will be super annoying, almost quora-ish. [18:50:30] hmm, no brion yet [18:50:39] YuviPanda: brion just arrived :) [18:50:43] hah :) [18:51:11] woo brion ;) [18:51:30] YuviPanda: soo much better [18:51:36] violetto: https://www.dropbox.com/s/uezeefuistamsgu/2014-03-17%2018.48.21.png looks much better to me. previous one was weird in padding because of stupid math error on my part :P [18:52:07] violetto: I added wrong :P 24 + 8 + 8 != 48! [18:52:22] YuviPanda: idk if the settings is small or envelope big [18:52:43] violetto: the settings is circular, envelope is full square. illusion! :P [18:52:54] brion: pushed commits! :D (No grrrit-wm yet) [18:52:56] YuviPanda: ya, may need to have that "just save my damn edit and don't bug about signing in again" after all... [18:53:05] :) [18:53:13] mhurd: yes, definitely. [18:53:26] mhurd: we want to educate them that there's an option, but not 'nag' them. [18:53:45] YuviPanda: *edu-nag*? [18:53:52] hehe [18:53:53] mhurd: no nag :) [18:54:18] whee [18:54:28] violetto: are you sure you don't want to try another color? :) [18:54:52] YuviPanda: violetto: oh, yeah, what's up with green? ;) [18:55:02] * preilly doesn't love the green [18:55:09] YuviPanda: I got an intel atom-based smartphone that runs android and firefox os :D [18:55:13] ah, fun toys to play with later [18:55:15] first, CR ! [18:55:16] brion: woooot! :) [18:55:36] brion: I've got a firefox phone if you want to play with it [18:55:43] mhurd: it's violetto's pick. I've a rule of never arguing with designers about color, since it is as close to being a literal bikeshed as possible. [18:55:51] oh hai preilly [18:56:00] brion: howdy [18:56:11] YuviPanda: hehe i have no such reservations haha [18:56:18] heh :) [18:56:19] ha ha [18:56:38] kenanwang, are you running the retrospective? I remember awjr_away asked me to run the kick off, but I can't recall if he mentioned retrospective too or not [18:58:52] jgonera: I guess I can... [18:59:08] Brion I'm heading in now [18:59:13] ok [18:59:58] kenanwang, ok, thank you [19:00:45] YuviPanda: i keep getting dc-ed [19:00:53] violetto: with irccloud? [19:00:55] violetto: or regularly? [19:00:57] YuviPanda: yeah [19:01:00] pretty regularly [19:01:17] violetto: hmm, i think it has a 1h idle limit or somesuch in free version [19:01:33] YuviPanda: not if i have my mobile app on [19:01:49] violetto: oh? Hmm, I thought that had it too [19:01:53] YuviPanda: anyway, can the bookmark get a bit shorter and the settings bigger OR envelope smaller [19:02:19] YuviPanda: but i think it's got to be the envelope smaller [19:02:32] violetto: I think that's just illusion because the bookmark and settings aren't full. [19:02:38] violetto: envelope is *already* smaller than bookark :P [19:02:56] violetto: hmm, maybe the settings and bookmark have padding in the icon itself? [19:03:01] violetto: the svg file was a bit weird for both of them, IIRC [19:03:08] violetto: can you open them in illustrator and confirm? [19:03:14] YuviPanda: yeah i'll do it now [19:03:31] violetto: *no* padding at all - they should touch as many corners as possible (all, in the case of settings icon, and at least 3 (maybe 4) in bookmark) [19:04:40] YuviPanda: height of bookmark is 96px, and you're right about the settings, there was padding. i corrected it [19:04:46] violetto: woo! [19:05:13] violetto: yeah, settings was the most obvious one. does bookmark have padding on either side? if it does, me changing size here isn't going to make differences. [19:05:41] YuviPanda: yeah bookmark has a significant horizontal padding cus it's longer than square [19:05:52] let me check what the size is [19:06:13] violetto: yeah, so I don't think I can adjust things here to make it any different. it'll look a bit weirder than the others because it has a different aspect ratio sans-padding [19:06:23] violetto: poke me when new settings svg is in dropbox? [19:06:25] YuviPanda: 15px left/right [19:06:28] mhurd: thanks for bringing this up. Its a really good optimization. thinking - ill come around in 15 minutes [19:06:31] YuviPanda: it's already in there [19:06:37] violetto: sweet, let me update. [19:07:01] vbamba: just to repeat what I told mhurd again, hopefully we don't ask that *every* time, since that is just *really* annoying :) [19:07:24] violetto: maybe move all the padding to left, have the icon touch top, right, bottom edges? [19:07:40] YuviPanda: can [19:07:42] hang on [19:07:47] violetto: [19:07:53] violetto: ok [19:07:54] YuviPanda: done and updated [19:08:10] violetto: ok, downloading in a moment [19:08:29] k! btw, do you have dropbox app on your computer? [19:08:43] did you download it or are you just viewing it online [19:08:58] vbamba: here's the built-in "action sheet" interface presenting a couple options: http://imgur.com/7DlY8uL [19:09:01] violetto: i am viewing it online. it's too big for me to download at this level. [19:09:15] YuviPanda: i see [19:10:49] violetto: it also has PSDs and stuff, and for the next month or so I'm not going to have the luxury of high bandwidth :) [19:10:49] so [19:11:31] violetto: [19:11:33] violetto: https://www.dropbox.com/s/spy3mk4iq04pxsf/2014-03-17%2019.11.06.png [19:13:15] violetto: what do you think? [19:13:29] brion: sorry to annoyingly ping you about this https://gerrit.wikimedia.org/r/#/c/118220/ [19:15:35] YuviPanda: https://gerrit.wikimedia.org/r/#/c/119015/ hebrew change seems to fail for me [19:16:24] brion: ah, hmm. [19:16:28] brion: let me take it out of the patch series for now [19:17:45] brion: and don't merge the icons yet, me and violetto are tweaking them still [19:18:00] ok [19:18:02] dennyvrandecic: moment [19:20:34] brion: also, can you try a 'right click, 'resync'' in intellij before building? [19:20:40] brion: maybe the symlink confused it? [19:20:59] ok moment [19:21:19] violetto: can you check 'clock' for extra padding in the icon as well? it should also be touching all 4 edges. [19:22:55] mhurd: i love that we're using the action sheet [19:23:37] YuviPanda: didn't realize i got dc again [19:23:39] violetto: mhurd vbamba we could use something similar to actionsheet on android too, and just add a 'remember next time' option :) [19:23:42] violetto: aaargghghg [19:23:44] YuviPanda: lol [19:23:45] lrwxr-xr-x 1 brion staff 53 Mar 17 12:13 values-iw -> /Users/ypanda/code/wikipedia/wikipedia/res/values-he/ [19:23:48] violetto: did you see my messages? [19:23:53] absolute symlink path [19:23:55] brion: grarrugh. [19:23:56] YuviPanda: checkin your messages [19:24:00] brion: call me an idiot [19:24:03] :D [19:24:12] brion: can you fix it? :) easier than me stashing and rebasing [19:24:17] ya moment [19:24:20] violetto: oh, i just slapped that together as a quick mock. vibha's ironing out details right now. action sheet does seem to do the trick though! :) [19:25:08] mhurd: yep, why make new ones when we have action sheet! we're thinking the same things for mobile flow [19:25:26] YuviPanda: cehcking clock [19:25:34] violetto: ok! [19:26:09] YuviPanda: so turns out.. clock had padding too [19:26:14] violetto: :D [19:26:17] YuviPanda: im suspecting some illustrator bug [19:26:18] violetto: so get rid of it, I'll update. [19:26:21] violetto: aah [19:26:23] violetto: possible, yeah. [19:26:26] YuviPanda: ok that fixed it [19:26:27] YuviPanda: i changed and updated too [19:26:27] violetto: ios 7 action sheets are nice and clean too [19:26:39] mhurd: yeah. i wonder if it'll work with every phone [19:26:42] or most [19:27:24] violetto: ya any ios 7 device - ios 6 devices just have old look to them, but it still works [19:27:32] violetto: mhurd on Android we can use what Chrome uses when it asks if you want to make it remember a password. Very nice and clean UI, and sortof similar to ActionSheets but with a little more customizability [19:27:42] vbamba: ^ [19:27:50] violetto: updated clock? [19:27:56] YuviPanda: yeah updated [19:27:59] brion: icon patchset almost done [19:28:04] violetto: ok, let me update [19:28:05] YuviPanda: and yeah about action sheet! [19:28:18] violetto: check out what chrome does in this case. [19:28:24] (offer to remember password) [19:29:34] YuviPanda: /checkin [19:31:01] violetto: https://www.dropbox.com/s/hve6o7imt4zbd3t/2014-03-17%2019.30.24.png [19:31:17] violetto: I think it looks fine enough to merge for now. bookmark icon is problematic, though. but that's because of its shape, I think. [19:31:25] YuviPanda: okay! [19:31:31] violetto: although I personally like them to be just a *little* bit larger. let's experiment later on :) [19:31:39] YuviPanda: agreed! [19:31:40] brion: icon changes also ready to merge / review! :) [19:31:45] \o/ [19:31:51] i'll get to them shortly [19:32:03] having some "fun" with git and the mediawiki-config repo :D [19:32:55] brion: heh :) [19:33:02] brion: poke me before mergint the generated icons tho :) [19:33:07] submodules got messed up in my local copy somehow o_O [19:34:30] brion: I've never ever managed to fix fucked up submodules. always had to reclone [19:35:16] violetto: https://www.dropbox.com/s/wkgo0prx3dslimr/2014-03-17%2019.34.40.png I like this better :D [19:35:31] violetto: Things look more in line / better when I take out the bookmarks icon. [19:36:01] YuviPanda: lol!! yes me too [19:36:26] violetto: ok, let me commit this then :D I think we should consider redoing the bookmark icon? [19:37:39] YuviPanda: i've tried to make it fatter before but it wouldn't look like bookmark anymore [19:37:45] bookmarks are usually long :/ [19:37:57] violetto: yeah, maybe we can't use a bookmark? It seems to disrupt the navbar :| [19:38:06] dennyvrandecic: ok i'm checking in #wikimedia-operations if anybody's ready to help push it [19:38:11] i've tweaked it slightly to my satisfaction :) [19:38:15] YuviPanda: i know i was aware of the problem when i was making it [19:38:24] YuviPanda: i'll see what else i can do [19:38:36] violetto: ok :) I'll leave the white box in for now. [19:38:41] YuviPanda: oki [19:38:49] violetto: aand... the color? :D [19:39:17] YuviPanda: the white color? [19:39:18] violetto: i mean, just new things to try out. our primary blue, maybe black... [19:39:21] violetto: no, the green [19:39:37] YuviPanda: can try blue [19:39:53] YuviPanda: 347BFF [19:39:53] violetto: can you give me a couple of colors to try, and I'll try and make screenshots? [19:39:57] brion: wohoo! thank you! [19:40:20] YuviPanda: yes! https://trello.com/c/IRqbu8p4/15-color-swatches [19:40:47] YuviPanda: first attachment. don't use yellow orange or red [19:40:53] but try the 2 shades [19:40:57] violetto: ok! [19:44:46] violetto: what do I use for the divider lines when I am using 347BFF? [19:45:30] YuviPanda: can you see the value next to it, the darker blue in the swatch pallete? [19:45:55] violetto: it doesn'ta ctually have a value on it, just says 'from color hsb, -30 brightness' [19:46:17] YuviPanda: yeah. ok then i'll get an exact value for u [19:46:35] violetto: thank you. having an exact value there would also be useful [19:46:47] YuviPanda: 2456B3 [19:46:56] violetto: ty [19:47:15] YuviPanda: np! [19:49:09] violetto: https://www.dropbox.com/s/0qsowzuhweqcoss/2014-03-17%2019.48.32.png vs https://www.dropbox.com/s/jir2ej9xxhe8tj1/2014-03-17%2019.47.47.png [19:50:46] YuviPanda: darker looks better, less stark, but so corporate [19:51:35] violetto: hmm, yeah, I'm not too much a fan of either. anyway, we might have to look beyond these two. Think of colors and let me know when you want to test them :) It'll be easier for me if you just gave me a bunch of 5-6 color sets and asked me to test :) [19:51:45] violetto: for today's alpha I'm just going to keep the green as is. [19:51:57] YuviPanda: okay [19:52:08] brion: I'm going to have to sleep in about 30m. Think you can review the 2 patches so I can push out an alpha? :D [19:52:29] YuviPanda: yeah looking now [19:52:33] had to reinstall librsvg [19:52:36] brion: woo! :) [19:52:37] brion: aaah [19:52:43] brion: you also need to sudo easy_install sh [19:52:49] yeah that was .... easy to install [19:52:53] brion: haha :) [19:57:12] YuviPanda: aaaaand merged! [19:57:17] violetto: yay icons! :D [19:57:28] brion: ;D! [19:57:40] brion: whee [19:58:11] my android died on me, like i need to bring it to service dead [19:58:33] brion: ok, version bump patch sent! [19:58:46] brion: hmm, don't merge it just yet, let me see if I can fix one more thing :) [19:58:56] brion: any objections to me self-merging version bump patches? [20:00:23] MaxSem: we're using the video for the kickoff [20:00:31] jdlrobson, i can haz retrospective hangout? [20:01:51] http://etherpad.wikimedia.org/p/MobileWeb-Retrospective-March-17-2014 [20:02:00] YuviPanda: go right ahead :) [20:02:13] brion: ok, let me see if I can get another he patch fixed [20:03:59] : http://etherpad.wikimedia.org/p/MobileWeb-Retrospective-March-17-2014 [20:08:57] brion: another small rtl commit! take a look? [20:09:03] brion: https://gerrit.wikimedia.org/r/119107 [20:09:04] woot [20:13:07] vbamba: violetto mhurd https://www.dropbox.com/s/1g6h5qwxmo6vu3d/2014-03-17%2020.12.20.png is what I was talking about (re: actionsheet's android equivalent). it pops up automatically whenever I visit a google site (part of chrome, though) [20:13:25] YuviPanda: i like that [20:13:56] YuviPanda: oh yeah, looks familiar [20:20:57] mhurd: violetto :) [20:32:59] brion: https://gerrit.wikimedia.org/r/119110 another minor patch that broke important functionality ('back') [20:33:54] working back might be nice :D [20:34:32] YuviPanda: merged [20:34:35] brion: woot [20:34:38] brion: ok, imma make build now [20:41:33] ragesoss: new alpha pushed out :) [20:41:59] \o/ [20:42:03] brion: mhurd violetto :) [20:42:09] brion: I should consider doing changelogs. [20:42:17] yeah :) [20:42:46] brion: although I don't know where to send them. [20:44:54] http://etherpad.wikimedia.org/p/MobileWeb-Retrospective [21:00:19] ok it's lunchtime for me [21:03:47] violetto: mhurd vbamba ok, night for me. night! [21:04:40] YuviPanda: gnight! [21:04:50] mhurd: :) night! [21:05:18] YuviPanda, should the android wikipedia feedback use getAppNameAndVersion from Utils.java so that it's easier to track down the version? also, g'night [21:05:50] dr0ptp4kt: i was going to use that, but then it wasn't very human readable so wrote whatever is being currently used instead. I'd prefer it to be human readable [21:06:08] YuviPanda, cool. have a good night's rest [21:06:34] dr0ptp4kt: ok :) Night! Check out the new left nav. I took out the W0 stuff, we need to fit it back in :( [21:06:50] YuviPanda: will do. keep pestering me, though :) [21:06:56] dr0ptp4kt: would be easier to do now, since it's no longer constrained to just a listview :) [21:07:09] YuviPanda: good. peace! [21:07:14] go to bed! [21:07:21] dr0ptp4kt: yes sir [21:11:03] hey aharoni :) fixed things! [21:11:11] heya [21:11:23] YuviPanda: I came to ask you why did you only do this for Hebrew. [21:11:32] This may also affect Indonesian and Yiddish. [21:11:36] aharoni: because i forgot :P I just did the other two [21:11:41] aharoni: and am pushing that patch right now. [21:11:45] cool [21:11:46] aharoni: will make it to next alpha. [21:11:50] great [21:12:18] aharoni: https://gerrit.wikimedia.org/r/119121 :) [21:12:30] dr0ptp4kt: do you want to do some simple android CR? :D https://gerrit.wikimedia.org/r/119121 [21:15:30] brion: I'm too sleepy to play with gerrit, but can you give dr0ptp4kt +2 rights? [21:15:48] hmmmm i have no idea how to do that offhand [21:16:17] brion: heh, I usually do that by wandering into random opsen and asking :D [21:16:24] brion: Chad might know off the top of his head [21:16:28] anyway, sleep for realz [21:16:38] sleep well :) [21:32:46] kenanwang, 13 [21:57:43] http://etherpad.wikimedia.org/p/iterationname [22:05:42] kenanwang, so will there be a VE perf meeting? [22:33:12] jgonera jdlrobson: I just updated MobileFrontend and VisualEditor to master and now mobile VE doesn't work for me. Have you guys noticed any problems with it? [23:19:43] got it working, had to update the lib/ve submodule [23:20:48] Kenan: when do you want to talk about close button behavior in the editor switcher? [23:23:47] kenanwang: ^ [23:39:42] brion, re the simulator, i realized i had js disabled. of course i can't expect simulators to launch when there's no js in the hosting environment. [23:39:57] d'oh [23:40:37] big d'oh [23:57:48] jdlrobson: o/ [23:58:21] prtksxna: hey :)