[00:03:25] I head over now kaldari [01:27:52] hello [01:28:08] prtksxna: I dont have a way to delete your personal email and it autocompletes [01:28:11] just hard to notice [01:28:22] will check in future [01:28:27] also is chicken down [01:28:28] ? [06:26:17] hey vbamba. around? [06:47:11] Hey YuviPanda [06:47:29] hi vbamba! I'm going to be with prtksxna when the initial popups deploy happens :D [06:47:53] oh sweet! [06:47:58] youre going to Bombay? [06:48:04] vbamba: I am! tomorrow afternoon [06:48:20] please enjoy some street pav bhaji for me [06:48:23] and send me photos [06:48:34] vbamba: heh! will do! I was looking forward to the vada pav :D [06:49:09] vbamba: did you get a chance to test out the latest build of the android app? I see that the anon edit workflow is being tweaked with monte [06:54:46] the best vada pav is in worli [06:54:58] ask prtksxna, he will know [06:55:04] I have to look at android build tomorrow [06:55:20] anon edit workflow is being tweaked. correct. [06:57:13] vbamba: hmm, so I'll hold off on working on it atm [06:57:23] vbamba: aaah, I've a friend who lives on the Worli seafront [06:57:46] vbamba: house on the 14th floor, glass walls. bought it cheap about 80 years ago. AMAZING PLACE. I'll try to get there this time around :) [07:00:26] YuviPanda: would be great if you could hold off, just for a bit, im talking to monte first thing tomorrow morning to review the flow we agreed on [07:01:01] vbamba: yeah, I'll find other things to poke at for the moment. I might work on the page styling a bit, since that part is shared across android and iOS [07:12:54] violetto: around? [12:34:13] [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/8_Hmdw [12:34:13] 13WikipediaMobile/06master 1456f5155 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [16:59:29] MaxSem: hey.. is there any way we could increase the nearby search radius on Wikivoyage? [16:59:35] It's clear that the existing search is way too small [17:00:00] jdlrobson, hmm, we can [17:00:19] https://en.wikivoyage.org/wiki/Special:Nearby < here i see San Francisco areas [17:00:23] but not Oakland for example [17:00:30] I think 10km is the max? [17:01:38] yes [17:01:41] it's tunable [17:01:56] lemme look up how dense it is... [17:02:08] Okay thanks I'm going to pull you into a wiki conversation on mediawiki.org too [17:02:59] not dense at all [17:03:05] let's do it [17:03:44] jdlrobson, what radius do you propose? [17:03:59] 20 for starters? [17:04:27] MaxSem: yeh upping to 20 would be a good starting point [17:12:27] YuviPanda, grrrit is still dead? [17:14:37] jdlrobson, https://gerrit.wikimedia.org/r/119313 [17:14:42] will swat it [17:18:30] YuviPanda: hey! [17:19:49] Thanks MaxSem for your speediness :) [17:20:06] MaxSem: will it support up to 20? [17:20:10] yexs [17:20:44] ggsradius may not be over 10000 (set to 20000) for users [17:20:51] or does this also tweak that? [17:27:01] hey mhurd [17:27:05] MaxSem: should be back? [17:27:07] not back? [17:27:08] hmm [17:27:25] yes [17:27:36] MaxSem: hmm, checking [17:28:06] whhyyy is my internet sooo slow [17:38:44] jdlrobson: MaxSem do you remember the bug that caused the mobile queue to be removed from OTRS? [17:38:59] YuviPanda: it was too spammy [17:39:11] jdlrobson: yeah, but there was a bug on which it was discussed [17:39:22] * jdlrobson searches his mail [17:39:41] https://bugzilla.wikimedia.org/show_bug.cgi?id=39467 < there was this [17:39:54] and https://bugzilla.wikimedia.org/show_bug.cgi?id=41502 [17:41:20] jdlrobson: thank you! :) [17:42:08] mhurd: hey! [17:42:18] YuviPanda: yo! [17:42:26] mhurd: did you subscribe to mobile-l yet? :) [17:42:38] YuviPanda: oh yeah... one sec [17:42:45] mhurd: :) [17:42:54] mhurd: you should also see the archive for the current discussion about OTRS [17:43:16] mhurd: we are trying to move all possible discussions to mobile-l than mobile-tech (yay jdlrobson!), so trying to keep things there [17:43:42] jdlrobson: google "install Chromedriver selenium". when you have it in place, set your env var BROWSER_LABEL=chrome and it should Just Work [17:47:07] YuviPanda: http://chicken.wmflabs.org/wiki/TestNavPopUps [17:47:19] Did you guys take the test page down? [17:48:19] vbamba: no, chicken is down. The labs migration took it down. [17:49:45] llaaaaabbbbbbsssssssss!!!!!!!! [17:52:09] hehe... chicken is down! [17:52:27] mhurd: heh, things like these is why we called it chicken [17:52:41] haha [17:53:28] nobody calls labs chicken [17:57:16] prtksxna: chicken being investiaged in #wikimedia-labs [17:59:36] * brion goes to coffee up [18:20:34] chrismcmahon: so yeh i've followed your checklist but it's still not working [18:23:03] export BROWSER=chrome < that's what i needed [19:55:41] vbamba: have a sec to post screenshots to the trello design board? [19:57:12] YuviPanda: brion mhurd do you guys know anything about rt 7068/https://gerrit.wikimedia.org/r/#/c/119336/ ? [19:57:45] awjr: so they moved download.wikimedia.org releases stuff to new server [19:57:59] ops got me set up on it but we should probably put tfinc on at some point to avoid spof [19:58:00] daniel was asking me if the desire was for tomasz specifically to upload the releases, or if it was going to be someone else [19:58:02] heh, that rt ticket i don't have permissions to view [19:58:09] brion ^^ [19:58:23] awjr: brion I'd like it as well, considering me and brion make most of the releases. [19:58:26] yeah it could be someone else, say yuvi :) [19:58:36] ok cool thanks brion and YuviPanda :) [19:58:39] also tfinc is on his honeymoon ;) [19:59:15] ugh my saved rt password is wrong again [19:59:17] * brion tableflips [19:59:28] hehehe [19:59:40] oh no it's right i was using the wrong username :D [19:59:47] i asked daniel to also add yvui [19:59:48] er [19:59:49] yuvi [19:59:51] also, too many things are called RT [20:00:02] Windows RT! [20:00:05] nobody likes windows rt [20:00:14] poor unloved arm processors [20:00:52] though it's mostly because the desktop is locked down to microsoft programs and nobody likes metro apps ;) [20:00:55] brion: on the other hand, everyone loves our rt [20:00:59] lol [20:03:08] brion: mhurd did you see the OTRS convo on mobile-l? I'm going to ask for 4 queues as mhurd suggested (app/os combo). [20:03:09] dr0ptp4kt: ^ [20:03:29] YuviPanda: works for me, as long as we know where they go and someone's checking them :D [20:03:40] brion: well, 'someone' would start out being *us* :P [20:03:43] and then we can draft other people in [20:03:44] hehe [20:03:46] yes [20:06:22] brion YuviPanda i said as much in a comment on https://gerrit.wikimedia.org/r/#/c/119336/ - look OK? [20:29:13] YuviPanda: cool. let mhurd and me know once it's time to update the ios code for the wikipedia app with the new wikipedia ios-specific email address. you got the android part, covered, right? i saw a revert on the android@ email patch, so figured you have it covered [20:29:34] dr0ptp4kt: yeah, but I didn't merge it :) want to merge? [20:30:49] YuviPanda, yeah, will take a look. i see i have +2 there, thx. i gotta run to another meeting atm, though [20:40:43] https://rt.wikimedia.org/m/ticket/history?id=6831 [20:40:48] ^yurik [20:41:38] oh whoa it's totally lunchtime [20:41:38] bbiab [21:05:13] (03PS23) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [21:06:12] (03CR) 10jenkins-bot: [V: 04-1] Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [21:10:52] chrismcmahon: Jenkins is giving me a weird qunit error: "ERROR: Failed to archive artifacts: log/*" [21:11:04] https://gerrit.wikimedia.org/r/#/c/111367/ [21:12:16] (03CR) 10Kaldari: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [21:13:06] kaldari: I'm stumped. I don't really deal with qunit, and that looks like a WMF Jenkins config problem or host problem. [21:15:53] chrismcmahon: NP [21:20:25] WTF [21:20:41] SSMT [21:21:17] the wiki on staging is lightning fast when queried locally but takes a good part of minute when request comes outside of labs [21:23:35] MaxSem: might be labs network issue. I remember there was/is an issue with an unplugged cable on virt1008 [21:23:36] err [21:23:37] 1007 [21:23:51] that one is fixed [21:24:22] ah, hmm [21:35:47] (03CR) 10Siebrand: "+1 for what Julius says. Also, if you think that check should be done, maybe work with Hashar on making comparing en and qqq keys a proper" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119326 (owner: 10Jdlrobson) [21:37:01] (03CR) 10Dr0ptp4kt: [V: 032] Revert "Email feedback to android@wikimedia.org." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119250 (owner: 10Yuvipanda) [21:42:09] YuviPanda: Do you guys plan to release an updated version of the Commons mobile uploader? [21:42:24] multichill: not atm, we are working on the wikipedia app. [21:42:26] multichill: why? [21:42:48] I used it for the first time since a while and I noticed it got stuck and I couldn't crop images [21:42:56] (03PS2) 10Jdlrobson: Hygiene: Add missing QQQ codes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119326 [21:43:16] (03PS4) 10Jdlrobson: Add a pre-review hook to enforce better code review practices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119327 [21:43:23] (03CR) 10Jdlrobson: [C: 032] "cherrypicked" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119327 (owner: 10Jdlrobson) [21:43:56] YuviPanda: And I checked appstore and no update.... [21:44:15] multichill: 'crop'? Is this iOS or android? [21:44:21] ios [21:44:22] (03Merged) 10jenkins-bot: Add a pre-review hook to enforce better code review practices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119327 (owner: 10Jdlrobson) [21:44:43] multichill: ah, right. On android you could just use any of the photo editor apps to do cropping, etc, and just use the commons app to upload. [21:45:01] multichill: file a bug and email mobile-l? mhurd is our iOS dev, so poking him might help too [21:45:05] I was thinking like the Facebook app [21:45:42] multichill: hmm, right. [21:45:43] awjr, did we change something with cookies again? I can't switch to mobile mode on my local instance using an ipad... [21:46:08] oh, it magically worked after a few attempts [21:46:21] jgonera: the bug that you reported that i fixed got reopened; MaxSem had to revert my change [21:46:36] i havent had the chance to try to fix it again [21:47:32] awjr, I see... [21:47:58] jgonera: it was causing another infinite recursion problem somewhere [21:48:24] my hunch is it was being caused by centralnotice but that's kinda besides the point [21:48:35] anyway, the f'd up behavior you originally reported is likely present again [21:51:45] heh, that doesn't make my life easier when testing VE on tablets ;) [21:54:35] (03PS3) 10Jdlrobson: Enable Special:MobileMenu for Vector skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118118 [21:54:40] (03PS4) 10Jdlrobson: Enable Special:MobileMenu for Vector skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118118 [22:01:11] (03PS12) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [22:02:11] (03PS13) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [22:02:32] (03CR) 10Jdlrobson: Delay EventLogging click track until next page load (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 (owner: 10Jdlrobson) [22:03:07] (03PS6) 10Jdlrobson: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 [22:03:16] (03CR) 10jenkins-bot: [V: 04-1] SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [22:03:18] (03CR) 10Jdlrobson: [C: 04-1] "Working on kaldari's review notes" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [22:05:13] (03CR) 10Kaldari: [C: 04-1] "The new functions in InlineDifferenceEngine.php could greatly benefit from some comments. In particular, it is not immediately clear what " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118744 (owner: 10Jdlrobson) [22:09:14] (03CR) 10Kaldari: [C: 032] Hygiene: Add missing QQQ codes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119326 (owner: 10Jdlrobson) [22:09:51] (03Merged) 10jenkins-bot: Hygiene: Add missing QQQ codes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119326 (owner: 10Jdlrobson) [22:15:59] (03PS1) 10Yuvipanda: Remove attribution css from bundles that do not need it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119405 [22:16:01] (03PS1) 10Yuvipanda: Add a 'wikihacks' file that contains hacks for common wiki styles. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119406 [22:16:56] brion: dr0ptp4kt_ ^ [22:17:07] ooh [22:18:32] YuviPanda, what's this now? [22:18:50] dr0ptp4kt_: just trying to spread the review load around :) [22:18:57] uh-oh, intellij 13.1 [22:18:59] time to upgrade [22:19:10] YuviPanda: oh, okay. you want me to look at 119405 and 119406? [22:19:22] dr0ptp4kt_: if you have the time, and if brion isn't looking at them :) [22:19:29] (03PS7) 10Jdlrobson: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 [22:19:31] (03PS7) 10Jdlrobson: Special:MobileWebApp and Special:Manifests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 [22:19:38] brion, want me to take 119405 and 119406? [22:19:53] dr0ptp4kt_: give them a whirl [22:20:13] dr0ptp4kt_: i tweaked perms too, you should be able to submit [22:20:36] YuviPanda: just saw that and publish-n-submitted the earlier one with the email address revert. [22:21:09] dr0ptp4kt_: woot [22:23:54] ok intellij 13.1 hasn't exploded yet.... [22:24:11] huzzah [22:24:38] brion: dr0ptp4kt_ ok, am off to sleep. cya guys tomorrow :) [22:24:46] YuviPanda: peace [22:24:56] \/ [22:24:59] bye! [22:25:20] nighty night [22:27:29] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Keepin' it simple." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119240 (owner: 10Yuvipanda) [22:41:15] dr0ptp4kt_: aha, i've got the app manager talking to my new FFOS phone running 1.3, with the debugger and everything \o/ [22:41:18] lemme finish those reviews now [22:42:02] brion, nice. [22:43:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Confirmed this now works on long pages/slow loads." [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/115313 (owner: 10Dr0ptp4kt) [22:46:05] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Confirmed this helps on long names" [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/115320 (owner: 10Dr0ptp4kt) [23:19:25] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Had some trouble testing this thanks to ..... probably caching issues. ;) As long as it loads the updated code this seems to work more or " [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/118787 (owner: 10Dr0ptp4kt) [23:20:22] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok with the followup it seems to work, let's think about cleaning up the code later for our sanity though. :D" [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/115330 (owner: 10Dr0ptp4kt) [23:21:09] i may do some cleanup on this code later, it's maddening to review because of the spaghettiness, cause it kinda got half-rewritten several times ;) [23:21:54] also there's definitely some caching fun when i update it on my test server, i'll have to fiddle with that [23:27:42] MaxSem: got a sec? [23:27:51] ыгку фц [23:27:55] o_O [23:27:55] sure awjr [23:28:30] :) [23:28:45] MaxSem: i want to fix https://bugzilla.wikimedia.org/61400 [23:28:54] i can think of a couple of different approaches [23:28:58] but wanted to run them by you [23:29:18] 1) do the view toggling as early as possible (eg when MobileContext is initialized) [23:29:42] might break tests [23:29:45] 2) create an object property that stores whether or not checkToggleView() has already been fired [23:29:55] if it's already been fired, dont do it again [23:30:13] (perhaps unless the check is overridden) [23:30:49] 2) seems the right way [23:31:01] it feels bloated to me [23:31:19] but i think will be the quickest solution [23:31:22] it will also avoid running it more than once without recursion [23:31:31] yeah :p [23:31:43] k thanks [23:31:46] i'll do 2 [23:45:59] kaldari: uhoohh https://gerrit.wikimedia.org/r/#/c/117126/7/MobileFrontend.php [23:47:29] (03PS1) 10MaxSem: Set a sane default for $wgMFNearbyEndpoint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119416 [23:47:33] jdlrobson, ^ [23:47:40] (03PS1) 10Jdlrobson: Hygiene: Reset wgMFNearbyEndpoint variable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119417 [23:47:52] MaxSem: beat me too it :) [23:48:01] (03CR) 10Kaldari: [C: 032] Set a sane default for $wgMFNearbyEndpoint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119416 (owner: 10MaxSem) [23:48:13] (03CR) 10Jdlrobson: [C: 032] Set a sane default for $wgMFNearbyEndpoint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119416 (owner: 10MaxSem) [23:48:25] (03Abandoned) 10Jdlrobson: Hygiene: Reset wgMFNearbyEndpoint variable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119417 (owner: 10Jdlrobson) [23:48:55] (03Merged) 10jenkins-bot: Set a sane default for $wgMFNearbyEndpoint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119416 (owner: 10MaxSem) [23:48:57] jdlrobson, MaxSem: seemed like a reasonable default to me :P [23:49:25] kaldari: so the problem is now Commons, Wikivoyage etc will all be hitting en.wiki [23:49:33] with jsonp which is bad [23:49:51] MaxSem: I would suggest this gets lightning deployed as I'm not sure Wikipedia.org will want all this additional traffic [23:50:06] kaldari: also all languages will now point to enwiki.. [23:50:15] jdlrobson: Ah, good point. I forgot about the sister projects [23:51:08] (03PS1) 10MaxSem: Set a sane default for $wgMFNearbyEndpoint [extensions/MobileFrontend] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/119418 [23:52:16] (03CR) 10Ori.livneh: [C: 032] Set a sane default for $wgMFNearbyEndpoint [extensions/MobileFrontend] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/119418 (owner: 10MaxSem) [23:52:54] (03Merged) 10jenkins-bot: Set a sane default for $wgMFNearbyEndpoint [extensions/MobileFrontend] (wmf/1.23wmf18) - 10https://gerrit.wikimedia.org/r/119418 (owner: 10MaxSem) [23:53:54] I assume that was just lightning deployed? [23:55:27] (03CR) 10Jdlrobson: [C: 04-1] Story 1521: Allow switching from VisualEditor to Wikitext editor (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson)