[00:13:37] (03PS1) 10Kaldari: Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 [00:14:20] (03CR) 10jenkins-bot: [V: 04-1] Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [00:16:05] (03PS2) 10Kaldari: Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 [00:21:51] kenanwang: yt? [00:22:13] Hey [00:22:32] awjr sup? [00:22:47] kenanwang: are you planning on and/or ok with using the next iteration for bug fixing/hygiene/etc since we'll be doing quarterl planning then? [00:22:51] *quarterly [00:31:37] (03PS3) 10Kaldari: Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 [00:37:25] kenanwang: Monte and I are waiting for you [00:37:34] Do not abandon us [00:38:03] Haha will find you vbamba [00:38:36] awjr I was gonna try to have us work on article history and watchlist [00:39:38] kenanwang: during the same iteration as quarterly planning? [00:40:24] That was the original plan but maybe it won't work [00:40:58] awjr [00:41:24] kenanwang: quick hangout? [00:43:35] (03CR) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [00:46:15] You can hangout me [00:46:28] Mhurd hey where are you and Vibha? [00:46:57] kenanwang: i'm at my desk [00:47:25] Really I just looked over there [00:47:33] Know where Vibha is? [00:47:47] mhurd: ^ [00:48:03] kenanwang: her stuff is here - she'll be back in a minute [00:48:45] kenanwang: she's back [00:49:33] kenanwang: i have been trying to hangout but you are not answering :( [00:51:46] everyone wants kenanwang [00:51:52] we are patiently waiting our turn [00:52:26] Weird... Let me try closing and reopening [00:52:32] heh [00:52:42] I will find you two in a minute vbamba [00:53:19] sure sure [00:56:00] kenanwang: i'll send you an email since i have a hard stop at 6 - can you take a look and respond before we get into story prio tomorrow? [00:56:50] Ok I think I might have it working now [00:56:57] oh heh let me try one more time [00:57:09] (03PS24) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [00:57:51] (03CR) 10jenkins-bot: [V: 04-1] Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [01:01:05] Ok vbamba be there in 2 [01:04:57] ok, me too [01:29:38] (03CR) 10JGonera: [C: 031] Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [01:52:26] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Remove attribution css from bundles that do not need it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119405 (owner: 10Yuvipanda) [02:20:11] (03CR) 10Dr0ptp4kt: [V: 031] "Question on whether style is necessary. I can see a few reasons why it may be necessary, but wanted to double check in case it should actu" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119406 (owner: 10Yuvipanda) [07:12:04] vbamba: heya! [07:12:17] vbamba: talk on hangout? I'm going to be in an auto sooon. [07:12:36] vbamba: going to be with prtksxna when popups/hovercards gets deployed [07:12:57] * zz_yuvipanda goes off now [07:13:02] vbamba: Are you in BOM? [07:13:09] oops zz_yuvipanda ^ [07:13:16] Man, I wish I could be [07:13:18] prtksxna: flight at 15:55 [07:13:27] yay \o/ [07:13:34] yuvi - here now [07:13:40] sorry i was fixing my internet [07:13:40] vbamba: saw my response? [07:13:49] yeah - do you have time to talk? [07:13:51] prtksxna: looking forward to working 3G :) [07:14:01] hehe [07:14:10] vbamba: yes! but on hangout text chat than IRC, if that's ok [07:14:29] vbamba: I've pinged you there [07:15:08] vbamba: I've to go off IRC now. see you on chat :) [07:15:15] ok [11:45:43] Help me in choosing mentors for my own proposal of wikimedia commons android app ? [13:16:00] (03CR) 10Siebrand: "Thanks!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119326 (owner: 10Jdlrobson) [13:22:39] (03PS1) 10Siebrand: Use __DIR__ instead of dirname( __FILE__ ) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119473 [13:23:24] (03CR) 10jenkins-bot: [V: 04-1] Use __DIR__ instead of dirname( __FILE__ ) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119473 (owner: 10Siebrand) [13:26:59] (03PS1) 10Siebrand: Migrate to JSON i18n with B/C shim [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119474 [13:27:55] (03PS2) 10Siebrand: Use __DIR__ instead of dirname( __FILE__ ) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119473 [13:28:38] (03PS2) 10Siebrand: Migrate to JSON i18n with B/C shim [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119474 [13:29:52] (03PS3) 10Siebrand: Migrate to JSON i18n with B/C shim [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119474 [14:14:45] (03CR) 10MaxSem: [C: 04-1] "The shim is not needed because MF explicitly doesn't support older MW versions." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119474 (owner: 10Siebrand) [14:15:39] (03CR) 10MaxSem: [C: 032] Use __DIR__ instead of dirname( __FILE__ ) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119473 (owner: 10Siebrand) [14:16:18] (03Merged) 10jenkins-bot: Use __DIR__ instead of dirname( __FILE__ ) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119473 (owner: 10Siebrand) [14:39:13] (03CR) 10Siebrand: "Ah, okay. Will remove it (and the i18n file reference in MF.php)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119474 (owner: 10Siebrand) [14:41:47] (03PS4) 10Siebrand: Migrate to JSON i18n [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119474 [14:54:57] (03PS1) 10Siebrand: Remove unused local variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119484 [15:04:31] (03PS7) 10Zfilipin: Using the new way of starting a custom browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119271 [15:05:20] (03PS1) 10Siebrand: Fix all CodeSniffer errors and warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 [15:06:09] (03CR) 10jenkins-bot: [V: 04-1] Fix all CodeSniffer errors and warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 (owner: 10Siebrand) [15:08:41] (03PS2) 10Siebrand: Fix all but one CodeSniffer errors and warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 [15:10:22] (03PS8) 10Zfilipin: WIP QA: Using the new way of starting a custom browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119271 [15:14:04] (03PS3) 10Siebrand: Fix all CodeSniffer errors and warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 [15:17:55] (03PS9) 10Zfilipin: QA: Using the new way of starting a custom browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119271 [15:21:28] (03PS10) 10Zfilipin: WIP QA: Using the new way of starting a custom browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119271 [15:34:35] (03PS11) 10Zfilipin: QA: Using the new way of starting a custom browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119271 [15:36:35] (03CR) 10Cmcmahon: [C: 032] "this will make the user-agent no-javascript tests pass again" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119271 (owner: 10Zfilipin) [15:37:06] (03PS4) 10Yuvipanda: Restore Wikipedia Zero status in left side navbar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119229 (owner: 10Dr0ptp4kt) [15:37:21] (03Merged) 10jenkins-bot: QA: Using the new way of starting a custom browser [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119271 (owner: 10Zfilipin) [15:38:25] (03CR) 10Yuvipanda: [C: 04-1] "Also a screenshot to help orient the designers would be nice, since it is hard to test these :)" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119229 (owner: 10Dr0ptp4kt) [16:58:24] hey [17:10:37] YuviPanda: hey [17:11:09] brion: YuviPanda: hangout standup or irc again? [17:11:42] is hangout working today? :) [17:11:48] brion: ya [17:11:58] yay [17:12:52] brion: YuviPanda: oh i hear kenan so he'll get the hangout set up... [17:12:52] whee [17:13:00] yuvi says he's out and may not be back in time [17:13:04] (in email) [17:13:43] (03PS1) 10Cmcmahon: QA: explicit navigation to Main Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119506 [17:14:23] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119506 (owner: 10Cmcmahon) [17:15:52] (03Merged) 10jenkins-bot: QA: explicit navigation to Main Page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119506 (owner: 10Cmcmahon) [17:16:34] (03PS1) 10Dr0ptp4kt: Update appcache and version. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/119507 [17:16:41] mhurd: hangout time [17:18:25] (03PS2) 10Dr0ptp4kt: Update appcache and version. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/119507 [17:18:48] (03CR) 10Dr0ptp4kt: [C: 031 V: 032] Update appcache and version. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/119507 (owner: 10Dr0ptp4kt) [17:23:26] awjr, jgonera, jdlrobson & kaldari, can you please take a look at https://www.mediawiki.org/wiki/Requests_for_comment/Minifier and tell me if I missed something fundamental? [17:23:42] sure [17:23:47] sure MaxSem [17:24:25] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Add a 'wikihacks' file that contains hacks for common wiki styles. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119406 (owner: 10Yuvipanda) [17:24:57] (03PS2) 10Jdlrobson: Hygiene: Remove unused local variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119484 (owner: 10Siebrand) [17:25:04] (03CR) 10Jdlrobson: Hygiene: Remove unused local variables (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119484 (owner: 10Siebrand) [17:25:10] (03CR) 10Jdlrobson: [C: 04-1] "See comment on PS1" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119484 (owner: 10Siebrand) [17:25:15] MaxSem: are the 'gzipped' columns meant to signify the gzipped version of the tool to the left? [17:25:24] yes [17:25:26] eg gzipped raw mediawiki js is 19.5kb [17:25:26] ke [17:25:27] er [17:25:28] k [17:25:36] (03PS4) 10Jdlrobson: Hygiene: Fix all CodeSniffer errors and warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 (owner: 10Siebrand) [17:25:38] MaxSem: it would be good to make that clearer [17:25:48] brion, mind taking a look at https://gerrit.wikimedia.org/r/#/c/119507/ ? it's just an appcache and version rev [17:26:07] dr0ptp4kt_: looks good lemme merge [17:26:14] (03CR) 10Brion VIBBER: [C: 032 V: 032] Update appcache and version. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/119507 (owner: 10Dr0ptp4kt) [17:26:23] huh i am not seeing the 'edit' tab on mw.o [17:26:30] although i see 'edit' links next to section titles [17:27:26] actually im just not seeing it on your RFC MaxSem [17:27:41] LQT [17:27:49] really? [17:27:53] MaxSem: Mainly I would like to know what the performance hit actually is. [17:28:09] like how much slower is it? [17:28:43] also, the 'MediaWiki' column in your table may be better titled 'JavaScriptMinifier' since that's how you refer to it everywhere else [17:31:48] (03CR) 10Siebrand: Hygiene: Remove unused local variables (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119484 (owner: 10Siebrand) [17:34:03] (03PS5) 10Siebrand: Hygiene: Fix all CodeSniffer errors and warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 [17:41:25] (03PS1) 10Jdlrobson: WIP: Run PHP code sniffer in the make phplint command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119512 [17:41:41] (03CR) 10Jdlrobson: [C: 04-1] "Siebrand thanks so much for this - this is great - but could you provide the config file you use for code sniffer? I'd like to formalise t" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 (owner: 10Siebrand) [17:42:34] hi violetto [17:42:46] (03CR) 10Jdlrobson: [C: 04-1] "WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119512 (owner: 10Jdlrobson) [17:42:49] YuviPanda: hi! [17:42:57] violetto: i'm in the hangout. [17:43:53] YuviPanda: i know! haha [17:43:54] violetto: I'm at prtksxna's house :) He's asking how your js stuff is going and says you shouldn't be corrupted by php [17:45:12] (03CR) 10Jdlrobson: [C: 032] "A song by thrift shop comes to mind... Thanks Siebrand!! Soooo happy right now :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119474 (owner: 10Siebrand) [17:45:51] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119474 (owner: 10Siebrand) [17:46:53] (03CR) 10Siebrand: "@Jon: I'm using the CodeSniffer repo file: gerrit ssh://gerrit.wikimedia.org:29418/mediawiki/tools/codesniffer.git" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 (owner: 10Siebrand) [17:48:13] (03CR) 10Jdlrobson: [C: 04-1] "Something not quite right with the back behaviour... Open VisualEditor, click switcher button and you get taken to wiki text editor. Now c" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [17:49:06] (03CR) 10Jdlrobson: Fix close button behavior for editors after switching (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [17:53:10] YuviPanda: lol! [17:53:14] let me show you what i did [17:53:16] hang on [17:53:16] violetto: :) [17:53:17] violetto: woo [17:54:42] YuviPanda: /sending [17:54:45] violetto: woo [17:54:59] violetto: what was the 'refinements list' you were talking about? [17:55:48] YuviPanda: under wikitext editing in "current on iOS" [17:55:57] violetto: aaah, ok [17:56:03] i just included the color swatches i showed you before [17:56:37] violetto: ah, right. sweet [17:56:51] violetto: I did a little more pagestyling stuff yesterday. The navboxes and stuff are gone now. [17:56:56] jdlrobson: pm [17:57:14] YuviPanda: what did you mean navbox? [17:57:30] violetto: do you have the app? [17:58:11] violetto: if you see http://en.wikipedia.org/wiki/Holi under the infobox you see a 'part of a series on'. that is navbox [17:58:15] violetto: that's hidden in mobile web [17:59:41] brion, thanks for +2 merge [18:00:25] YuviPanda: lemme get the phone [18:00:32] violetto: ok [18:01:10] YuviPanda: oh! i see [18:01:22] YuviPanda: does it appear in many articles? [18:01:43] violetto: yeah, a lot. and without hiding, they turn up in the lead. And they are usually very long - 5/8 screens of scrolling down [18:01:51] violetto: we should find another way to surface them [18:02:01] YuviPanda: okay i'll work on that [18:02:15] violetto: yeah, but we don't need to do them for MVP (but we could :) ) [18:02:21] violetto: but for now I've just hidden them [18:02:32] YuviPanda: sounds good [18:02:39] violetto: ok :) [18:02:41] violetto: icconnsss [18:02:42] :) [18:03:23] YuviPanda: i'll get them to you today! [18:03:33] YuviPanda: for now.. another meeting [18:03:39] violetto: heh, enjoy :) [18:03:49] >T [18:16:11] (03CR) 10Jdlrobson: [C: 032] "Okay i'm happy now. I've added a tool to make sure we all have the same coding conventions!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 (owner: 10Siebrand) [18:16:45] (03PS2) 10Jdlrobson: Tools: Run PHP code sniffer in the make phplint command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119512 [18:17:14] (03PS25) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [18:17:27] (03CR) 10jenkins-bot: [V: 04-1] Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [18:22:16] MaxSem: I'm lost - I'm trying to find the other patch set you wrote to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=61807 but it's not linked to on the bug report or in the story card [18:22:34] was it https://gerrit.wikimedia.org/r/#/c/118135/ ? [18:24:02] jdlrobson, https://gerrit.wikimedia.org/r/118135 [18:25:42] MaxSem: okay got it [18:28:40] (03CR) 10Jdlrobson: [C: 04-1] "Can you rebase?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [18:29:49] violetto: ping? [18:29:55] YuviPanda: pong [18:30:00] half meeting mode [18:30:38] violetto: ah, hmm. I just re-did the login-after-create-account process to be slightly cleaner and easier to implement. Ping me when you have some breathing room and i'll send you a build. [18:30:54] YuviPanda: send me a build! [18:31:04] violetto: hah :) yes mam! [18:31:30] (03PS1) 10Jdlrobson: QA: Stop running the basic site tests until we have shared gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119526 [18:31:47] ^ chrismcmahon awjr [18:33:13] jdlrobson: I fixed those tests this morning https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/433/ [18:34:06] chrismcmahon: are they passing everywhere now? [18:34:17] (03CR) 10Cmcmahon: [C: 04-2] "No need for this, the tests are fixed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119526 (owner: 10Jdlrobson) [18:34:21] I haven't had any emails saying they passed yet [18:34:41] last email I got was at 9:57am [18:34:43] and it failed [18:34:57] how often do the emails send? [18:40:34] (03CR) 10Kaldari: Fix close button behavior for editors after switching (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [18:41:08] (03PS4) 10Kaldari: Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 [18:41:17] (03CR) 10jenkins-bot: [V: 04-1] Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [18:42:06] (03PS5) 10Kaldari: Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 [18:42:43] (03CR) 10Kaldari: "@Jdlrobson: Looks like closeOnBack was needed after all." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [18:44:13] (03CR) 10jenkins-bot: [V: 04-1] Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [18:51:21] YuviPanda: did you send it yet? im done with meeting [18:51:34] violetto: nah, just finished verifying. sending now [18:52:29] YuviPanda: oggie [18:52:34] violetto: sending now [18:53:02] violetto: sent [18:53:30] violetto: when creating test accounts, use 'test' [18:56:03] (03PS6) 10Kaldari: Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 [18:56:05] (03PS16) 10Kaldari: QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [18:56:07] (03PS26) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [18:58:50] YuviPanda: got it [18:58:54] violetto: ok! [18:59:27] YuviPanda: you said he goes out the way he logs in, you mean the place he taps to sign in and out right? [18:59:44] YuviPanda: i like how the entire area is tappable, it's so satisfying!!!! [18:59:53] violetto: :D [19:00:33] violetto: no, I meant - first they see the login screen, then tap 'create account', then create account screen, and when account is created, back to login screen where the actual login happens. If there's any login error, it will be shown in the login screen and handled as usual, so we don't have to have two separate ways of handling login errors [19:00:38] violetto: yeah, entire screen tapping FTW [19:00:57] violetto: I really want to have some stats under the username, or maybe even link it to a sexy my contributions screen. [19:01:27] violetto: having the username also the logout link seems rather counterintuitive [19:01:40] YuviPanda: i'd like to see my contribs too [19:01:59] YuviPanda: i was thinking how often does the user really want to sign out [19:02:16] awjr: can you make sure my comments get noticed during the discussions around stories? [19:02:21] violetto: imo? mostly never. I'll be happy moving 'sign out' into settings or somesuch (GMail has it there, I think) [19:02:25] MaxSem: has the procedure for config changes changed at all with the deployment train? [19:02:35] YuviPanda: in the future we might have stuff listed in the screen when you tap on your username [19:02:38] jdlrobson: are your comments on the cards? [19:02:43] correct [19:02:48] no problem jdlrobson [19:02:49] YuviPanda: so we could just start by putting it in that page [19:02:55] the sign out link [19:03:11] violetto: I can move it, yeah. but what happens when you tap the username then? [19:03:14] awjr, commit then apply for swatting [19:03:16] violetto: we shouldn't make it a no-op. [19:03:26] YuviPanda: no-op? [19:03:31] MaxSem: what's the procedure for applying for 'swatting'? [19:03:41] jdlrobson: sounds like this is what you should do for getting htat config change out ^ [19:03:47] violetto: as in, you tap it and nothing happens. [19:03:49] https://wikitech.wikimedia.org/wiki/Deployments [19:04:20] violetto: we could do a very quick 'my contributions' screen. It's probably about 3h for me to build if we make it simple enough (edit count, paginatable list of recent edits (diffs open in external browser)) [19:04:20] YuviPanda: yeah. i know for sure in the future we would have something in the page after you tap on your username, we wouldn't want to train our users to think it's an empty link [19:04:35] YuviPanda: that would be.. bomb [19:05:03] violetto: i checked the API. if we get rid of edit count, user contribs is superfuckin trivial [19:05:03] YuviPanda: i'll put it on my to-do today for the screen where i see log out [19:05:05] jdlrobson: go ahead and schedule the config change for a swat deploy (https://wikitech.wikimedia.org/wiki/Deployments) [19:05:15] YuviPanda: let's start with soemthing :) [19:05:25] YuviPanda: im happy starting with just that [19:05:30] violetto: yeah, that's the spirit :D woohoo [19:05:37] YuviPanda: meow meow! [19:05:49] violetto: how's the create account workflow? [19:06:17] YuviPanda: i got a "cannot create account" error but doesn't tell me what's wrong [19:06:21] hang on, i'll try again [19:06:28] violetto: screenshot? [19:07:16] violetto: the text copy also probably needs tweaking. [19:07:51] YuviPanda: what time are you going to bed? maybe we can spend time tweaking these over hangout [19:08:10] YuviPanda: i'll be gone in half hour and back in 2.5 hours from now [19:08:22] violetto: i'll be around for 2.5h more, I think. [19:08:28] violetto: err, 1.5h [19:08:40] violetto: hopefully not 2.5h more, but I've an instant urge to just build a 'my contributions' screen right now. [19:08:49] violetto: :P [19:08:57] YuviPanda: lol [19:09:07] YuviPanda: can't say i've been good myself [19:09:13] YuviPanda: sent you the screenshot [19:09:17] violetto: lookindg [19:09:23] YuviPanda: i created the account with some nonsense username [19:10:10] greg-g MaxSem: I don't understand how to request a SWAT deploy from this page - https://wikitech.wikimedia.org/wiki/Deployments - can it be made more clearer? Do I just mail you? [19:10:15] violetto: where did you send screenshot? [19:10:31] ad it to the table [19:10:39] jdlrobson: does https://wikitech.wikimedia.org/wiki/SWAT_deploys help? [19:10:57] YuviPanda: yuvipanda@wikimedia [19:11:11] * greg-g should update that sidebar that still references LDs [19:11:22] violetto: hmm, don't have it yet. whatsapp? :P [19:11:50] YuviPanda: let me download on this android (i got another phone since mine died) [19:11:56] violetto: ah, ok! [19:13:06] greg-g: so I have to decipher some template wikitext and add the link?! :( [19:13:22] ah wait it's not a transclusion [19:13:35] jdlrobson: help out with VE? :P [19:13:42] Could I suggest using sections rather than a table if possible? [19:14:01] YuviPanda: i resorted to gchat, hopefully that worked [19:14:01] jdlrobson: if you mock it up on a test page, sure, if it's easier [19:14:18] violetto: ok, i just got the email [19:14:35] jdlrobson: fwiw, this is easier than it was before, mwalker made that deploy template which helps [19:14:54] violetto: hmm, right. that's for the less used error messages. I could add coverage for more error messages. [19:15:47] greg-g: yeh it's not too bad it just could be a lot easier and not that intuitive [19:15:48] YuviPanda: what was the issue in that screen, is it because im using illegal characters? [19:15:59] having separate subpages that simply list patches might be easier? [19:16:12] jdlrobson: because going to another page is easier? [19:16:17] violetto: that's possible. I don't know, that info isn't saved. I'll file a bug and check in a bit [19:16:36] * greg-g will let you ponder [19:16:46] okay. when i tap in the field wanting to change it, the pop up wouldn't disappear either [19:16:49] * greg-g needs to prep for some other things right now, unfortunately [19:16:55] YuviPanda: oh wait, that's on log in [19:17:09] greg-g: e.g. https://wikitech.wikimedia.org/wiki/Deployments/2014-03-19 [19:17:15] violetto: hmm? [19:17:26] ( Keeps it as simple and obvious as possible) [19:17:46] YuviPanda: when im signing in and did not put in the right username, it has the exclamation mark next to the field right [19:18:05] jdlrobson: /me'll steep on it [19:18:06] YuviPanda: and a pop up appears with reason why im not signed in (wrong usernmae, etc) [19:18:16] :) [19:18:26] YuviPanda: then i tap on username field to change my username, the pop up doesn't disappear [19:18:36] violetto: ah, yes. if you start typing it disappears? [19:18:55] violetto: i can make it disappear on explicit tap too, if that's what you are asking. [19:20:35] (03CR) 10Jdlrobson: "It still seems to be failing on Chrome..? https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/330" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119526 (owner: 10Jdlrobson) [19:20:42] YuviPanda: if i tap on another field it disappears. but i can see when it stays it can give useful info such as the username must have certain characters, etc [19:21:12] YuviPanda: do we have such error messages? [19:21:23] violetto: we don't, but we can make 'em. [19:21:45] violetto: if you want, I can write up an email / wiki page with our error messages and when we display them, and we can go over them and improve [19:22:04] YuviPanda: yeah [19:22:16] that would be helpful [19:22:22] violetto: yeah, will do! [19:22:30] YuviPanda: ;D [19:22:42] violetto: am moving sign out to settings page now. [19:23:27] YuviPanda: do you think that's an appropriate place to put it? [19:24:15] (03PS1) 10Kaldari: Hygiene: Switching spaces to tabs per coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119541 [19:25:19] YuviPanda: i was thinking when user taps on the username it goes to a page where they can sign out, since also that's the area where they sign in/ create acc/ makes sense to put sign out in that area of interaction too [19:25:57] violetto: ah, hmm. so we have a page where user can see their contribs as well as sign out? [19:26:08] violetto: and we can add more things there over time, like look at their talk page? [19:26:19] YuviPanda: yah [19:26:32] mhm mhm [19:27:35] jdlrobson: where's the mobile 'my contributions' page? [19:29:06] jdlrobson: I remember you showed it off at some point... [19:29:50] (03PS1) 10Yuvipanda: Fix position of logged in icon on navbar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119542 [19:29:51] (03PS1) 10Yuvipanda: Simplified new flow for Logging in after creating account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119543 [19:34:20] violetto: hmm, so if you go to 'my contributions' which wiki's contributions will you see? [19:34:32] violetto: we can't mix them up yet. [19:34:43] violetto: hmm, let's just make it primary wiki for now. we can figure out additional details later [19:38:07] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119543 (owner: 10Yuvipanda) [19:39:08] (03CR) 10Siebrand: [C: 04-1] "The JSON i18n files have spaces. I recommend this is abandoned." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119541 (owner: 10Kaldari) [19:39:12] YuviPanda: ok works for me [19:39:21] YuviPanda: i got to get off irc now for lunch meeting [19:39:25] YuviPanda: brb k [19:39:31] (03CR) 10Yuvipanda: [C: 04-2] "(Design still under discussion)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119543 (owner: 10Yuvipanda) [19:39:50] violetto: ok. let me know if the create account -> login flow is also fine by you [20:05:41] YuviPanda: where are you messages? I see alerts but can't find the room! [20:05:52] jdlrobson: where's the mobile 'my contributions' page? [20:05:55] jdlrobson: I remember you showed it off at some point... [20:06:04] It's the same [20:06:11] Special:Contributions but only in beta [20:06:13] jdlrobson: Special:Contributions? [20:06:15] jdlrobson: aaaaah [20:06:15] right [20:06:25] https://en.m.wikipedia.org/wiki/Special:Contributions/Jdlrobson?mobileaction=beta [20:06:41] jdlrobson: ty! [20:06:47] jdlrobson: Y U NO PROMOTE TO STABLE [20:08:08] (03CR) 10Dr0ptp4kt: "See inline responses." (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119229 (owner: 10Dr0ptp4kt) [20:08:24] ^YuviPanda [20:08:29] responses [20:10:21] (03CR) 10Yuvipanda: Restore Wikipedia Zero status in left side navbar. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119229 (owner: 10Dr0ptp4kt) [20:10:42] dr0ptp4kt_: ^ [20:17:17] (03CR) 10Kaldari: "Siebrand: I'm not sure I understand your objection. Yes, the files currently use spaces, but how is that an argument for not changing them" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119541 (owner: 10Kaldari) [20:20:34] (03CR) 10Cmcmahon: "It has never passed with Chrome. Only firefox supports spoofing the user agent." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119526 (owner: 10Jdlrobson) [20:20:48] chrismcmahon: so how do we stop it running on chrome builds? [20:22:39] (03PS1) 10Jdlrobson: QA: Fix Chrome builds for language browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119556 [20:35:08] (03PS1) 10Jdlrobson: QA: Increase timeouts for asynchronous steps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119557 [20:41:30] (03CR) 10Jdlrobson: [C: 04-1] "Still weirdness..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [20:44:11] (03CR) 10Dr0ptp4kt: "Posting follow up PS momentarily. Added screenshot to design board under "Left Drawer"" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119229 (owner: 10Dr0ptp4kt) [20:44:29] (03PS5) 10Dr0ptp4kt: Restore Wikipedia Zero status in left side navbar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119229 [20:45:41] ^^ and ^ YuviPanda [20:45:48] dr0ptp4kt_: woo, looking [20:47:15] vbamba: just a fyi, the deployment window for deploying Hovercards to mediawiki.org starts in about 13min :) [20:49:20] (03CR) 10Yuvipanda: [C: 032 V: 032] "Fair enough \o/" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119229 (owner: 10Dr0ptp4kt) [20:49:39] dr0ptp4kt_: ty! :) [20:50:25] YuviPanda, ty, actually [20:53:52] (03CR) 10Siebrand: "All the rest of MediaWiki isn't JSON files. So teach your IDE to use spaces for JSON files." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119541 (owner: 10Kaldari) [20:55:20] (03CR) 10Kaldari: "Siebrand: Why? What's wrong with using tabs?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119541 (owner: 10Kaldari) [20:56:12] oh man, a spaces vs tabs thing. [21:05:52] (03PS8) 10Jdlrobson: Special:MobileWebApp and Special:Manifests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 [21:06:29] (03CR) 10Jdlrobson: [C: 04-1] "Worst rebase ever" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 (owner: 10Jdlrobson) [21:06:42] (03CR) 10jenkins-bot: [V: 04-1] Special:MobileWebApp and Special:Manifests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 (owner: 10Jdlrobson) [21:09:55] (03PS9) 10Jdlrobson: Special:MobileWebApp and Special:Manifests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 [21:11:06] kenanwang: i forgot to ask this morning, but can you review the priority order of stuff in 'ready for dev'? [21:21:37] (03PS1) 10Jdlrobson: Tool: Make messages easier to create [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 [21:21:58] (03CR) 10MarkTraceur: "I gotta say, it seems silly to have a double standard." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119541 (owner: 10Kaldari) [21:22:26] (03CR) 10jenkins-bot: [V: 04-1] Tool: Make messages easier to create [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 (owner: 10Jdlrobson) [21:25:31] (03PS2) 10Jdlrobson: Tool: Make messages easier to create [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 [21:25:47] (03CR) 10jenkins-bot: [V: 04-1] Tool: Make messages easier to create [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 (owner: 10Jdlrobson) [21:27:08] kaldari: that bug I mentioned (https://bugzilla.wikimedia.org/show_bug.cgi?id=62840) seems to be related to nlwiki common.css, so disregard [21:33:48] (03PS1) 10Yuvipanda: Simplify SaneAsyncTask constructor boilerplate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119642 [21:37:28] (03CR) 10Jdlrobson: "See https://gerrit.wikimedia.org/r/119637 for a choose your own adventure approach which will automate this entire process.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119541 (owner: 10Kaldari) [21:40:29] (03CR) 10Jdlrobson: [C: 04-1] "See PS15 comments!" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [21:42:26] (03CR) 10Jdlrobson: [C: 04-1] Story 1521: Allow switching from VisualEditor to Wikitext editor (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [21:49:07] jgonera: were you and dan able to figure out what's going on with the limn graphs? [21:49:43] awjr, I'm pretty sure what's going on, I'm just not sure if I'll have time to fix it today, jdlrobson said he might have some time [21:50:00] no problem jgonera, i just wanted to make sure it was moving forward [22:04:28] (03CR) 10MaxSem: Tool: Make messages easier to create (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 (owner: 10Jdlrobson) [22:06:03] jdlrobson, is https://gerrit.wikimedia.org/r/#/c/111394/ ready? [22:22:01] MaxSem: yup [22:25:19] YuviPanda: oh yay! [22:25:28] 2 hr late reaction [22:26:14] don't see it on mediawiki though [22:28:18] (03CR) 10Jdlrobson: Tool: Make messages easier to create (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 (owner: 10Jdlrobson) [22:33:53] (03CR) 10Jdlrobson: [C: 04-1] "Gawd I need to rebase this again. Please someone review this it's been sitting here for 2 weeks now." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116912 (owner: 10Jdlrobson) [22:34:37] (03CR) 10Jdlrobson: [C: 04-1] "This also now needs another rebase sigh." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 (owner: 10Jdlrobson) [22:35:23] (03PS3) 10Jdlrobson: Tool: Make messages easier to create [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 [22:37:30] (03PS1) 10Mhurd: Added login option to wikitext editing workflow. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 [22:42:24] (03PS1) 10Jdlrobson: Tools: Relax pre-review hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119651 [22:44:58] (03PS1) 10Dr0ptp4kt: Up the version for the Settings - About screen and manifest. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/119652 [22:50:20] ^ brion, could i get a quick review on this one? [22:50:47] (03CR) 10Kaldari: [C: 04-1] Tool: Make messages easier to create (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 (owner: 10Jdlrobson) [22:52:00] kenanwang: head's up on https://bugzilla.wikimedia.org/show_bug.cgi?id=61114 [22:52:25] (03CR) 10Jdlrobson: Tool: Make messages easier to create (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 (owner: 10Jdlrobson) [22:54:16] (03PS4) 10Jdlrobson: Tool: Make messages easier to create [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 [22:55:20] (03CR) 10Kaldari: [C: 032] Tools: Relax pre-review hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119651 (owner: 10Jdlrobson) [22:56:08] (03CR) 10Kaldari: [C: 032] Tool: Make messages easier to create [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 (owner: 10Jdlrobson) [22:56:36] (03Merged) 10jenkins-bot: Tools: Relax pre-review hook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119651 (owner: 10Jdlrobson) [22:57:02] (03Merged) 10jenkins-bot: Tool: Make messages easier to create [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 (owner: 10Jdlrobson) [22:57:47] (03CR) 10Siebrand: "If it works for you, I'm fine with it. Sorting alphabetically is one way to deal with this. Another way could be that you organise it by f" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 (owner: 10Jdlrobson) [23:02:36] (03PS2) 10Mhurd: Added login option to wikitext editing workflow. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 [23:02:50] (03CR) 10Siebrand: [C: 04-1] "I'm very confused by the use of capitals. I've added questions in a few places. I'd really like to understand." (036 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 (owner: 10Mhurd) [23:05:08] (03CR) 10Siebrand: "Jon, did you read my replies?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119484 (owner: 10Siebrand) [23:06:10] (03PS3) 10Mhurd: Added login option to wikitext editing workflow. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 [23:06:52] (03PS10) 10Jdlrobson: Special:MobileWebApp and Special:Manifests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 [23:07:01] (03PS8) 10Jdlrobson: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 [23:08:07] (03CR) 10Mhurd: "Siebrand - sorry I confused you. Fixed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 (owner: 10Mhurd) [23:09:02] (03CR) 10Jdlrobson: "Siebrand can you rebase against master please? Thanks!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 (owner: 10Siebrand) [23:09:16] (03PS5) 10Jdlrobson: Enable Special:MobileMenu for Vector skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118118 [23:10:19] (03PS14) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [23:10:34] (03CR) 10jenkins-bot: [V: 04-1] Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 (owner: 10Jdlrobson) [23:11:05] (03PS15) 10Jdlrobson: Delay EventLogging click track until next page load [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116035 [23:12:43] (03PS4) 10Mhurd: Added login option to wikitext editing workflow. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 [23:14:46] (03CR) 10Mhurd: "Fixed more caps issues." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 (owner: 10Mhurd) [23:15:54] (03CR) 10Mhurd: "I updated all of the commented issues." (036 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 (owner: 10Mhurd) [23:19:44] (03PS1) 10MaxSem: Remove stray WAP messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119660 [23:26:19] (03PS2) 10Jdlrobson: Hygiene: Remove stray WAP messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119660 (owner: 10MaxSem) [23:26:29] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove stray WAP messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119660 (owner: 10MaxSem) [23:27:54] MaxSem: can you take a look at https://gerrit.wikimedia.org/r/#/c/116920/ ? [23:28:14] (03Merged) 10jenkins-bot: Hygiene: Remove stray WAP messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119660 (owner: 10MaxSem) [23:29:46] looking [23:31:47] thanks MaxSem appreciated [23:36:00] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 (owner: 10Mhurd) [23:38:59] (03PS6) 10Siebrand: Hygiene: Fix all CodeSniffer errors and warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 [23:39:04] (03CR) 10Siebrand: "Done." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 (owner: 10Siebrand) [23:40:42] jdlrobson, that change is hopeless, see my comment [23:53:09] kaldari: when is your vacation again? [23:53:24] leaving April 3 [23:53:33] getting back the night of April 23rd [23:53:50] but my vacation is only half that [23:54:08] lemme look up the vacation days.... [23:54:11] thanks! [23:55:21] (03CR) 10Dr0ptp4kt: "One comment, and several questions." (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 (owner: 10Jdlrobson) [23:56:28] (03PS5) 10Mhurd: Added login option to wikitext editing workflow. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 [23:57:53] ADP is a piece of crap [23:59:26] truth. [23:59:34] awjr: apparently there is no way to view scheduled time off in ADP [23:59:51] and the email from ADP doesn't give the dates [23:59:53] it's ok, but i can safely presume you'll be out for most of the next iteration