[00:00:02] which ends apr 14 [00:00:05] yes [00:00:10] and perhaps a bit of the iteration that follows, but not all of it [00:00:58] awjr: no, if I remember correctly, I'll be working for all of the iteration after [00:01:08] groovy kaldari [00:01:24] I think my vacation was April 3 - 11 [00:07:19] (03CR) 10Jdlrobson: Special:MobileWebApp and Special:Manifests (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 (owner: 10Jdlrobson) [00:07:32] (03PS11) 10Jdlrobson: Special:MobileWebApp and Special:Manifests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 [00:11:28] jdlrobson: I haven't compressed the SVGs. Don't we have a script for doing that somewhere? [00:14:13] (03CR) 10Dr0ptp4kt: [C: 032] Special:MobileWebApp and Special:Manifests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 (owner: 10Jdlrobson) [00:14:52] (03Merged) 10jenkins-bot: Special:MobileWebApp and Special:Manifests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 (owner: 10Jdlrobson) [00:20:50] jdlrobson: were you able to get your config change scheduled for deployment? [00:22:13] (03PS9) 10Dr0ptp4kt: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [00:29:25] jdlrobson, jgonera: Running the SVG optimizer manually from the command line works fine, but for some reason it didn't get run automatically. [00:33:27] (03PS27) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [00:33:35] (03CR) 10jenkins-bot: [V: 04-1] Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [00:35:06] prtksxna , vbamba: scap slowed to a crawl and I shot it after 63 minutes, an entire rack of servers didn't get the code... http://tinyurl.com/n3twd8k [00:36:33] only 4 people have it enabled? [00:37:51] it looking good though [00:38:03] prtksxna: any way to look any articles on mediwiki? [00:38:59] (03PS3) 10Jdlrobson: Tools: Run PHP code sniffer in the make phplint command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119512 [00:39:01] (03PS7) 10Jdlrobson: Hygiene: Fix all CodeSniffer errors and warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 (owner: 10Siebrand) [00:39:36] (03CR) 10Jdlrobson: [C: 032] "Rebased. Merging before the conflicts come back." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 (owner: 10Siebrand) [00:41:24] (03PS17) 10Kaldari: QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [00:41:26] (03PS28) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [00:41:42] (03PS1) 10Jdlrobson: Hygiene: Fix remaining php code sniffer errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119673 [00:41:45] (03Merged) 10jenkins-bot: Hygiene: Fix all CodeSniffer errors and warnings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 (owner: 10Siebrand) [00:42:54] YuviPanda: please let me know if you have any questions [00:43:00] regarding edit workflow [00:43:20] (03CR) 10Brion VIBBER: "Woo, trying this out now :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 (owner: 10Mhurd) [00:43:56] (03CR) 10Jdlrobson: "hashar looks like https://integration.wikimedia.org/ci/job/mwext-MobileFrontend-phpcs-HEAD/1152/console : SUCCESS in 4s (non-voting) can b" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119673 (owner: 10Jdlrobson) [00:48:22] blah Xcode's having an error deleting its derived data [00:48:27] * brion stabs xcode [01:00:11] (03CR) 10Brion VIBBER: "The new signin/anon option screen looks great... if I log in I'm having some troubles though, I ended up with an invalid token somehow. Mi" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 (owner: 10Mhurd) [01:03:33] (03CR) 10Krinkle: [C: 04-1] "The files are maintained by translatewiki, if anywhere, this change should be made there. As for the quoted level from the code convention" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119541 (owner: 10Kaldari) [01:09:39] (03CR) 10Brion VIBBER: "Yeah token thing still happens if I downgrade to current, so that's elsewhere in the code. I'll try and track it down after I merge this, " [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 (owner: 10Mhurd) [01:11:02] (03CR) 10Brion VIBBER: [C: 032 V: 032] Added login option to wikitext editing workflow. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119648 (owner: 10Mhurd) [01:23:14] (03PS1) 10Brion VIBBER: add a bunch of new strings files to the project so they get included in the build [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119681 [01:23:29] (03CR) 10Brion VIBBER: [C: 032 V: 032] "selfmerge :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/119681 (owner: 10Brion VIBBER) [01:30:51] man there should be a chart of the right settings options to hit in every language to get back to language selection [01:30:57] or... they should have a damn icon on the menu item [07:58:14] (03CR) 10Siebrand: "And by time of merging, PHPCS fails again. You could change this by making the job voting after fixing whatever remains. It should be easy" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119486 (owner: 10Siebrand) [08:16:38] (03CR) 10Nikerabbit: Tool: Make messages easier to create (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119637 (owner: 10Jdlrobson) [08:22:07] hey vbamba [08:22:30] vbamba: just confirming that I'll implemnent pretty much the same mockup you showed me at the beginning of that thread [10:03:02] MaxSem: ping? around? [10:03:08] yep [10:03:18] MaxSem: the diff view mobile uses, is it accessible by the API? [10:03:36] I see I can get a diff by using prop=revisions, but I don't think it's the same ones that mobile uses? [10:03:37] inline diff? no [10:03:40] or it might be and I'm just missing it. [10:03:44] hmm, ok [11:25:44] MaxSem: hmm, is *all* wikitext allowed in edit summaries? [11:30:23] MaxSem: nevermind, it can't. just read the code [14:58:20] the living styleguide is down. http://tools.wmflabs.org/styleguide/ [15:46:05] (03CR) 10MaxSem: [C: 032] Tools: Run PHP code sniffer in the make phplint command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119512 (owner: 10Jdlrobson) [15:46:14] (03CR) 10MaxSem: [C: 032] Hygiene: Fix remaining php code sniffer errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119673 (owner: 10Jdlrobson) [15:46:54] (03Merged) 10jenkins-bot: Tools: Run PHP code sniffer in the make phplint command [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119512 (owner: 10Jdlrobson) [15:46:56] (03Merged) 10jenkins-bot: Hygiene: Fix remaining php code sniffer errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119673 (owner: 10Jdlrobson) [16:41:53] (03PS1) 10Zfilipin: Added per-browser Cucumber tags [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119776 [16:45:44] (03CR) 10Cmcmahon: [C: 032] "tags for browser-specific builds now that we have a FF-only test" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119776 (owner: 10Zfilipin) [16:46:22] (03Merged) 10jenkins-bot: Added per-browser Cucumber tags [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119776 (owner: 10Zfilipin) [16:50:03] Can anyone help me in finding a mentor for my proposal this year for wikimedia commons android app - https://www.mediawiki.org/wiki/User:NateshR/Gsoc_Proposal_2014 [16:51:34] (03PS18) 10Jdlrobson: QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 [16:51:36] (03PS29) 10Jdlrobson: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 [17:08:46] (03PS10) 10Jdlrobson: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 [17:08:49] (03CR) 10jenkins-bot: [V: 04-1] SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [17:09:59] (03CR) 10Jdlrobson: [C: 04-1] "Kaldari See PS15 comments dammit!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [17:13:00] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [17:19:49] (03CR) 10Cmcmahon: [C: 04-2] "Timeouts are not browser-specific, they are caused by server behavior. Whatever is going on with the Chrome tests, this isn't the solutio" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119557 (owner: 10Jdlrobson) [17:23:13] hey nateshr_ [17:23:19] hi [17:23:32] jdlrobson: I need to rewrite half of those tests anyway. Sorry I hadn't done that yet. [17:23:34] nateshr_: I talked to brion, and I don't think either of us can mentor at the moment :( [17:24:17] YuviPanda : But I can move forward to implement this ? and any other mentor ? [17:24:55] nateshr_: can't think of anyone else who could be a mentor. Did you talk to Quim Gil? [17:25:58] Ya but he said that he has forwarded this to mobile team and i have to contact the respective mentors directly. [17:26:21] YuviPanda: ? [17:26:38] jdlrobson: Would you have any objection to me squashing the tests into the same change as the switcher? [17:26:39] nateshr_: yeah, and I guess neither of us can mentor. sorry! [17:27:11] YuviPanda: any solutions ? [17:27:27] nateshr_: nothing I can think of [17:28:07] (03PS19) 10Kaldari: QA 1521: Switch from VisualEditor to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [17:28:08] YuviPanda ; but you can try to help me out or ask any other to mentor this ? i [17:30:02] (03PS3) 10Jdlrobson: Explain deleted Revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118744 [17:30:34] nateshr_: sorry. Perhaps quim can help [17:30:37] nateshr_: good luck! [17:30:53] YuviPanda : thank you [17:33:31] (03PS20) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [17:34:57] (03Abandoned) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [17:37:12] (03Restored) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [17:41:35] (03Abandoned) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [17:44:36] awjr: if you think it is just forward it - hurray the internet :) [17:46:50] then how would anyone ever learn ;) [17:50:41] (03PS7) 10Kaldari: Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 [17:51:35] (03CR) 10Kaldari: [C: 04-1] "Still has weird problem Jon mentioned." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [17:51:39] (03CR) 10jenkins-bot: [V: 04-1] Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [17:58:30] (03PS1) 10Cmcmahon: QA: last scenario in login test has been being skipped [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119788 [17:58:51] (03CR) 10Cmcmahon: [C: 032] "maintenance, no functional changes" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119788 (owner: 10Cmcmahon) [18:00:01] (03Merged) 10jenkins-bot: QA: last scenario in login test has been being skipped [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119788 (owner: 10Cmcmahon) [18:13:31] (03PS1) 10Jdlrobson: QA: Re-enable password reset test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119791 [18:15:55] (03CR) 10Jdlrobson: [C: 04-2] Story 1521: Allow switching from VisualEditor to Wikitext editor (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [18:16:26] hmm, no br [18:31:43] (03CR) 10Jdlrobson: "@chrismcmahon I'm totally flabbergasted by your -2. In reply.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119557 (owner: 10Jdlrobson) [18:37:02] (03Abandoned) 10Jdlrobson: QA: Stop running the basic site tests until we have shared gem [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119526 (owner: 10Jdlrobson) [18:38:19] (03PS6) 10Jdlrobson: Proper edit handling in case of redirects where page does not exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116912 [18:58:11] hey brion :) [19:00:47] yo yo [19:01:48] brion: so, I managed to hack up a preliminary my contributions thing.... :P [19:01:57] oh awesome [19:02:01] brion: also there's a patch simplifying Sane AsyncTask [19:02:09] yeah i saw that in the queue [19:03:22] brion: I think the contribs stuff is general enough to make it work as page history also [19:05:48] oooooh [19:05:51] (03PS21) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [19:06:19] brion: let me put up a preliminary patch [19:06:27] brion: oh, and there's a change to the login workflow too [19:06:30] hi violetto [19:07:47] YuviPanda: yello [19:08:05] (03PS22) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [19:08:08] (03PS1) 10Yuvipanda: [WIP] Add User Contributions page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 [19:08:12] violetto: still in meetings? :) [19:08:14] brion: ^ [19:08:29] YuviPanda: ended right now ;D [19:08:36] violetto: woo! Looked at contribs? [19:08:50] (03CR) 10Yuvipanda: [C: 04-2] "- Needs proper rotate handling" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 (owner: 10Yuvipanda) [19:08:53] YuviPanda: did, about to reply your email too [19:08:59] violetto: woot! [19:09:03] violetto: imma wait then [19:09:21] oggie, gonna get some lunch and brb k [19:10:51] brion: mhurd YuviPanda have you noticed bugs coming in from bugello? [19:11:05] i am concerned that bugello has crapped the bed after the tool labs migration [19:11:18] awjr: lol [19:11:25] awjr: looks like a 'no' [19:11:39] :-/ [19:12:27] i will try to make some time today to take a closer look - worst case, i should be able to take care of it tomorrow [19:13:13] haven't noticed any lately no [19:14:29] brion: I should also start documenting the code and the js/java interfaces. mhurd will have to start using those soon [19:15:12] YuviPanda: yes, gotta start playing with those in a bit! [19:15:22] mhurd: :) [19:15:30] :D [19:17:19] https://m.mediawiki.org/w/index.php?title=MediaWiki&action=history [19:17:22] That doesn't look very mobile [19:18:08] Reedy: https://m.mediawiki.org/wiki/Special:History/Mediawiki?mobileaction=beta [19:18:31] Looks like the transfer to json worked alright [19:20:14] Reedy: did localization files just change? [19:20:26] cause mhurd just got an error back during testing about a bad magic word [19:20:30] and that's usually i18n-related :D [19:22:44] (03PS6) 10Jdlrobson: Avoid flash of styles when loading tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110649 [19:22:51] (03CR) 10jenkins-bot: [V: 04-1] Avoid flash of styles when loading tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110649 (owner: 10Jdlrobson) [19:23:16] (03PS7) 10Jdlrobson: Avoid flash of styles when loading tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110649 [19:23:23] (03CR) 10jenkins-bot: [V: 04-1] Avoid flash of styles when loading tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110649 (owner: 10Jdlrobson) [19:24:39] (03PS1) 10Cmcmahon: QA: this test now works for both FF and Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119802 [19:24:56] (03PS2) 10Yuvipanda: [WIP] Add User Contributions page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 [19:25:09] (03CR) 10Cmcmahon: [C: 032] "updated to work with both Chrome and FF, no functional changes" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119802 (owner: 10Cmcmahon) [19:25:12] brion: I hadn't scapped to go with a further wikibase update [19:25:14] should be good now [19:25:34] (03PS8) 10Jdlrobson: Avoid flash of styles when loading tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110649 [19:26:02] ah that'll do it [19:26:04] (03Merged) 10jenkins-bot: QA: this test now works for both FF and Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119802 (owner: 10Cmcmahon) [19:32:30] violetto: ping when back [19:35:41] (03PS23) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [19:40:34] brion: think you can take a look? :) [19:40:46] brion: might have minor design tweaks, so waiting on violetto, but CR! :) [19:45:22] moment [19:46:00] YuviPanda: you going to bed soon or gonna be around a bit? i might run off to lunch soon [19:46:15] brion: I'll be around for a couple of hours today. [19:46:22] ok [19:46:27] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix position of logged in icon on navbar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119542 (owner: 10Yuvipanda) [19:48:13] ok i'll take a quick peek now then test them after eating [19:49:28] brion: :D ok! [19:52:09] (03CR) 10Brion VIBBER: "don't forget the qqq :D" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 (owner: 10Yuvipanda) [19:54:52] (03CR) 10Brion VIBBER: [WIP] Add User Contributions page (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 (owner: 10Yuvipanda) [19:58:26] ok, brb [20:01:17] (03PS24) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [20:03:07] gonna run grab some eats and finish up CR from home, then run some errands [20:06:57] (03CR) 10Awjrichards: [C: 032] QA: Fix Chrome builds for language browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119556 (owner: 10Jdlrobson) [20:07:36] (03Merged) 10jenkins-bot: QA: Fix Chrome builds for language browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119556 (owner: 10Jdlrobson) [20:15:44] (03PS3) 10Yuvipanda: [WIP] Add User Contributions page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 [20:16:00] ok [20:16:02] back [20:16:19] violetto: back yet? :) [20:18:24] YuviPanda: yes [20:18:32] violetto: woo, ok :) [20:18:47] violetto: I'll wait for the email response. Also want you to OK the create account -> login interaction. [20:19:15] YuviPanda: im goign through it again [20:19:19] violetto: ok :) [20:19:44] YuviPanda: the latest build doens't have a way to sign out [20:20:04] violetto: gaaah, right. I need to find a way to let that happen... [20:20:12] YuviPanda: it's k, i'll uninstall [20:20:15] violetto: k [20:20:18] i'll address that in email too [20:20:44] violetto: okay! :) [20:21:09] violetto: also random lulz courtesy mark http://marktraceur.info/yuvi-panda-with-hair.jpg :) [20:21:30] YuviPanda: HAHAHAHAHAHAHA [20:21:36] whoa contrast [20:22:05] violetto: inorite :D I should bleach my hair at some point just to fuck around [20:24:14] YuviPanda: do it!! [20:24:16] hahahah [20:24:34] YuviPanda: ive got 3 questions for the creating account [20:24:48] violetto: ok! [20:24:56] violetto: askk [20:25:24] when im on the log in screen and have put in my details and realized i dont have an account (when i tried to sign in it says i dont exist etc). so i tap on create account [20:25:35] it brings me to this new screen where my previous input wasn't preserved [20:26:03] YuviPanda: could you instead bringing user to a new screen, add more fields to the current log in screen? [20:26:04] YuviPanda: Obligatory attribution, sec [20:26:07] violetto: ah! Ok, so I'll make it presrve username? [20:26:13] yeah and password [20:26:14] rdwrer: hehe :P [20:26:20] https://commons.wikimedia.org/wiki/File:Paris_Hilton_3.jpg + https://commons.wikimedia.org/wiki/File:Yuvi_Panda-1.jpg [20:26:23] violetto: password on one or both fields? [20:26:27] rdwrer: wait, PARIS HILTON? [20:26:28] just one [20:26:29] jeez [20:26:29] Hahahhaa [20:26:43] YuviPanda: It was the first picture on [[Blonde stereotype]] [20:26:53] rdwrer: hahahaa lol [20:27:05] rdwrer: It might come back to haunt you if I actually bleach my hair [20:27:12] Pfff [20:27:16] I look forward to this [20:27:18] YuviPanda: hahahahha [20:27:28] rdwrer: I have https://fbcdn-sphotos-c-a.akamaihd.net/hphotos-ak-ash3/t1.0-9/1978782_10151880520616191_1073448930_n.jpg now [20:27:31] rdwrer: all long and curly [20:27:32] * rdwrer totally ready to add YuviPanda's picture to [[Blonde stereotype]] [20:27:40] Yup, I know [20:28:04] violetto: anyway, so I preserve username and one password. [20:28:11] YuviPanda: yeah [20:28:19] violetto: ok, two more! :) [20:28:51] ok 2nd, captcha wasn't correct, can I instead be told in the same screen instead of going back to first create account screen? [20:29:11] YuviPanda: so i dont have to tap on "next" and repeat captcha [20:29:48] violetto: that was an API limitation, it got fixed last week. It will get deployed to testwikis this week, and I can fix it in the app end of next week, I think. [20:30:12] YuviPanda: okay sounds good then! [20:30:32] violetto: ok! You should file bugs for these though so we keep track of those. [20:30:35] YuviPanda: and then just small thing like the when i submit captcha from keyboard instead of submitting it just hides keyboard [20:30:47] violetto: yeah, 1 and 3 I can fix now. [20:31:01] violetto: but file bugs? :D [20:31:54] YuviPanda: i will! [20:31:59] violetto: ok! [20:32:03] violetto: but other than that, it's ok by you? [20:32:14] YuviPanda: i thought we had done improvements on the spaces last time [20:32:21] violetto: 'spaces'? [20:32:21] how come it's squished back in? [20:32:46] violetto: oh, spacing. This is what we ended up with that day, I think? [20:32:48] YuviPanda: https://trello.com/c/QirB96MJ/35-current-on-android [20:33:10] YuviPanda: and the error was at the bottom instead [20:33:53] violetto: yeah, so we switched the error to the current variant ( the red ! + callout) and I guess the spacing got lost in that [20:33:53] YuviPanda: we can put the icons in for hiding/showing password during last sprint? [20:33:53] violetto: file bug for this also? :D [20:33:53] violetto: yes! [20:33:57] YuviPanda: okay i'll do all that [20:34:04] other than that, you got ma OK [20:34:05] violetto: I got the icon rasterizer working on tuesday, so I can mess around with icons now [20:34:10] yay! [20:34:10] violetto: ok! can you say so on https://trello.com/c/bA3blAQG/16-2-create-account-auto-logs-user-in [20:34:54] YuviPanda: done [20:34:57] violetto: sweet [20:35:08] violetto: I'll wait for comments about my contributions :) [20:35:21] YuviPanda: kay [20:35:49] violetto: I was thinking we could maybe do a 'submenu' - tapping username expands items under it. So we can have my contributions, maybe an editing sandbox (where they can try out wikitext), later on watchlist and stuff [20:36:15] (off topic: this " Mid-March: Mobile to submit new releases to iOS and Android markets " is done right?) [20:36:48] YuviPanda: yeah sounds like a good idea [20:36:51] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 (owner: 10Yuvipanda) [20:36:52] greg-g: I would do kenanwang ^, but he's not here. [20:37:03] heh [20:37:38] (03CR) 10Yuvipanda: [WIP] Add User Contributions page (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 (owner: 10Yuvipanda) [20:37:48] greg-g: short answer is 'no'. For longer answers I refer you to our product manager, Kenan Wang. [20:38:58] YuviPanda: ty [20:54:03] YuviPanda: do you have good internet? [20:54:25] YuviPanda: writing the email and thought it'll be better if we hungout [20:55:09] violetto: I could, but prtksxna is sleeping about 5ft from me (I am being hosted at their house, and they have only one room) [20:55:21] YuviPanda: i see [20:55:27] ok what about i talk you type [20:55:31] violetto: oh yeah [20:55:33] that's cool [20:55:45] violetto: calling [20:55:54] let me finda room [20:55:58] violetto: ok [20:56:01] MaxSem do you know where X-Analytics gets updated with the beta channel info by mobile? [20:57:28] MobileContext::logMobileMode() [20:57:55] violetto: i can see and hear you [20:58:00] violetto: oh ok [20:58:04] quick errands - back in an hr [20:58:14] MaxSem, its on the backend? i thought XA gets set in varnish [20:58:26] nope [20:58:30] violetto: still looks like you are in a torture chamber :P all spikey behind. [21:00:39] violetto: ok! [21:00:57] MaxSem, do you know at what point does the logging happen? Is it after vcl_deliver in varnish? [21:01:21] no idea [21:01:27] violetto: yes [21:02:16] violetto: camera is out of focus [21:02:57] violetto: switch to group chat on hangout [21:03:10] violetto: yes! [21:06:25] violetto: I agree, but discoverability is a large problem there. [21:06:40] violetto: like how does the user know that he needs to swipe this way for 'Random'? [21:25:08] violetto: https://en.m.wikipedia.org/wiki/Special:Contributions/Yuvipanda?mobileaction=beta is mobile web my contribs [21:25:23] violetto: also what do we do when the user taps on it? :D [21:25:39] violetto: hahaha [21:25:54] violetto: we can send them to the page itself [21:26:00] violetto: or, we can send them to mobile web's diff view [21:26:15] violetto: it will open in your browser [21:26:32] violetto: it'll be terrible if it comes up in the app itself. two search bars! [21:27:30] violetto: HAHAH :D [21:27:46] violetto: the pipes are being clogged by all the next big things [21:28:09] violetto: yeah, we can easily do that, but in this case we will load all of mobile [21:28:16] violetto: and people can then tap 'back' and stuff inside the mobile web [21:28:23] violetto: and then they will be using mobile web from inside the app [21:28:49] violetto: imagine if https://en.m.wikipedia.org/wiki/Special:MobileDiff/594090224 is opened inside the app. they can use search and stuff from there [21:28:56] violetto: I'll just implement diff view :P [21:28:59] violetto: in the app [21:29:26] violetto: It'll be done by Monday. [21:29:46] violetto: I'll still be able to finish the other stuff scheduled for this sprint [21:30:01] violetto: because I finished the majority of it last friday? :) [21:30:10] violetto: anyway, sweet :) [21:30:15] violetto: can the my contributions be merged now? [21:30:18] violetto: ok! :) [21:30:24] violetto: and send the email you wrote anyway [21:30:32] violetto: bye [21:37:57] (03PS1) 10Cmcmahon: QA: wait for Chrome to finish redirecting on beta labs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119878 [21:38:42] (03PS2) 10Cmcmahon: QA: wait for Chrome to finish redirecting on beta labs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119878 [21:39:37] (03CR) 10Cmcmahon: [C: 032] "maintenance, no functional change. added implicit wait for URL to settle down." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119878 (owner: 10Cmcmahon) [21:40:16] (03Merged) 10jenkins-bot: QA: wait for Chrome to finish redirecting on beta labs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119878 (owner: 10Cmcmahon) [21:43:41] (03CR) 10Awjrichards: [C: 032] QA: Re-enable password reset test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119791 (owner: 10Jdlrobson) [21:44:19] (03Merged) 10jenkins-bot: QA: Re-enable password reset test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119791 (owner: 10Jdlrobson) [21:50:30] violetto: I'll be around for a while longer. I've to pick up a friend from the railway station for a train that's supposed to turn up at 4:20 AM, but it's currently delayed by... 4 hours :) [21:58:12] jgonera: Jon said you found out how to use class selectors in cucumber. Is there an example somewhere? [21:58:39] kaldari, in page-object you mean? there should be some tests using it already [21:59:19] kaldari, grep -nr "css:" tests/browser/ [21:59:24] jgonera: jdlrobson i've re-set up my instance and lost my language links and i totally forget how to set that up - can you refresh my memory? [21:59:43] thanks! [22:00:57] awjr: arggh we should really get this documented - i forget too [22:01:03] it involves database tweaking [22:01:18] yeah, i have… vague recollections :p [22:02:07] https://www.mediawiki.org/wiki/Manual:Guide_to_setting_up_interwiki_linking [22:02:24] jdlrobson: ^ ? [22:02:33] i *think* that's what i followed once before [22:02:54] but apparently there is also an interwiki extension [22:02:58] which may do the trick too [22:03:24] there shouldn't be.. [22:13:20] i used the extension which was easy, although it seems like a glorified way of doing it manually through the db [22:18:27] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikimediaMaintenance/d095e52de22ee71d09dbba24720f85e7d2764a4a/wikipedia-interwiki.sqlhttps://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikimediaMaintenance/d095e52de22ee71d09dbba24720f85e7d2764a4a/wikipedia-interwiki.sql [22:19:10] or we have a script in wikibase client (shoudl be moved to core), "populateInterwiki.php" [22:19:33] (03PS25) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [22:19:58] FF29 beta is out, and it has CSS vars :) [22:31:53] (03CR) 10Awjrichards: [C: 031] "When I perform this test manually, it takes 15-20 seconds from the moment I hit submit (after seeing preview) to the moment I see the toas" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119557 (owner: 10Jdlrobson) [22:34:49] (03PS8) 10Kaldari: Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 [22:35:17] (03PS9) 10Kaldari: Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 [22:35:19] (03PS26) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [22:38:53] (03CR) 10Kaldari: "Krinkle: Thanks for providing an explanation. Abandoning. FWIW, the quote was from the main coding conventions page, not from the subpages" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119541 (owner: 10Kaldari) [22:39:06] (03Abandoned) 10Kaldari: Hygiene: Switching spaces to tabs per coding conventions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119541 (owner: 10Kaldari) [22:47:14] (03PS2) 10Yuvipanda: Simplified new flow for Logging in after creating account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119543 [22:47:16] (03PS2) 10Yuvipanda: Simplify SaneAsyncTask constructor boilerplate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119642 [22:47:18] (03PS4) 10Yuvipanda: [WIP] Add User Contributions page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 [22:47:20] (03PS1) 10Yuvipanda: [WIP] Add a 'User Actions' submenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119891 [23:13:48] violetto: you got email :) check when out of meeting [23:14:07] YuviPanda: i gots it! [23:14:15] YuviPanda: /downloading [23:14:21] violetto: woot [23:44:55] (03PS3) 10Yuvipanda: Simplified new flow for Logging in after creating account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119543 [23:44:57] (03PS2) 10Yuvipanda: [WIP] Add a 'User Actions' submenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119891 [23:44:59] (03PS3) 10Yuvipanda: Simplify SaneAsyncTask constructor boilerplate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119642 [23:45:01] (03PS5) 10Yuvipanda: Add User Contributions page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 [23:45:53] (03CR) 10Yuvipanda: "May is ok with it. And add qq" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119543 (owner: 10Yuvipanda) [23:45:57] damn, no brion [23:46:02] mhurd: do you know where brion is? [23:47:54] (03CR) 10Yuvipanda: "May's ok with this for now. Also a patch to add logout back is on the way. And added qq :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 (owner: 10Yuvipanda) [23:49:16] YuviPanda: wfh for afternoon i believe [23:49:30] mhurd: ah, hmm. [23:49:33] want me to ping him for cr? [23:49:38] mhurd: that'll be nice :) [23:49:42] k [23:50:02] mhurd: I hacked together a my contributions page, btw :) I'm working on the anon editing stuff side by side as well. [23:50:10] awesome! [23:50:31] pinged [23:50:34] mhurd: :) [23:51:07] :) [23:56:29] violetto: did you check out the build? :) [23:58:01] YuviPanda: ive been trying to log in but apparnetly i dont remember my pw!!! [23:58:07] violetto: ow! [23:59:30] YuviPanda: i see [23:59:56] YuviPanda: wouldn't then history and saved pages go in there cus they're specific to you