[00:00:09] violetto: they aren't. if you log out they don't change [00:00:27] violetto: history and saved pages are device specific, not user specific [00:00:55] YuviPanda: to a user they aren't probably going to know the reason so well [00:01:22] YuviPanda: i would wonder what is the biggest reason for sectioning them like that [00:01:29] YuviPanda: but i like how it expands [00:01:34] i def think the log out should be there [00:01:39] violetto: hmm? These are also not available when they haven't logged in. Also we'll have more things there [00:02:04] violetto: yay! the arrow is shit, but I guess we can easily make a clean one [00:02:39] violetto: thoughts on not having icons for those? [00:04:18] YuviPanda: whether is it device or user specific or no-- history, saved pages and my contribs belong to me. what if we just added my contribs to the list below the line, plus it's also an easier access. [00:04:57] YuviPanda: logging out not so easy access because it's probably not a frequented action [00:05:13] YuviPanda: i already have icons for them ;D [00:05:14] violetto: fine by me, but I don't think we should expand the menu *just* for logout. We can just put log out at the bottom of the drawer. [00:05:48] YuviPanda: i dont mind that a lot [00:05:51] we can [00:05:58] violetto: alright, so let me do that then :) [00:06:19] kay! [00:06:25] violetto: :) [00:07:15] violetto: so tapping the user name does nothing? [00:07:49] YuviPanda: not now i guess. if there were more things in it, i'd have stronger feelings about putting log out in there [00:08:15] violetto: we can add User page, talk page, watchlist, and sandbox there later on. [00:08:38] YuviPanda: yeah [00:08:40] can [00:09:07] violetto: ok. I'll keep this code with the animations separately so we can still re-use this at some point. [00:11:13] YuviPanda: nais [00:11:30] violetto: ok :) Where are the my contributions and log out icons? [00:12:25] violetto: also app icon! and about page! :) [00:13:31] violetto: https://www.dropbox.com/s/aevrjul8h8vly65/Screenshot_2014-03-21-05-42-49.png for bookmark. looks ok to me [00:14:24] YuviPanda: whoa looks better [00:14:32] YuviPanda: look for puzzle_white.svg [00:14:34] (03PS4) 10Yuvipanda: Simplified new flow for Logging in after creating account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119543 [00:14:35] violetto: yup! :D [00:14:36] (03PS4) 10Yuvipanda: Simplify SaneAsyncTask constructor boilerplate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119642 [00:14:38] violetto: looking [00:14:38] (03PS6) 10Yuvipanda: Add User Contributions page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 [00:14:40] (03PS1) 10Yuvipanda: Added new bookmark icon for saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119906 [00:18:57] (03CR) 10Jdlrobson: [C: 04-1] "Please revert to PS25. You broke this one :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [00:20:24] YuviPanda: btw, uncool you're still awake [00:20:35] violetto: I'm waiting to pick up a friend from the train station [00:20:38] violetto: aaand her train is 4h late [00:20:57] YuviPanda: whoa [00:21:06] such a "friend" are you [00:21:09] suspicious [00:21:14] ;P [00:21:27] violetto: heh :) [00:21:43] violetto: I'm a good friend, I do this for all people! :) [00:21:56] YuviPanda: im gonna put that to a test some day [00:22:32] violetto: :D looking forward to it [00:23:34] YuviPanda: ok i gotta make my way home cus i got the case of hungry [00:23:34] brb k [00:23:39] violetto: https://www.dropbox.com/s/qu1q5t5oocce62c/Screenshot_2014-03-21-05-52-46.png [00:23:40] violetto: kk [00:24:23] YuviPanda: haha that icon def needs some tweaking, it looks too cloudy [00:24:27] YuviPanda: on my side not yours [00:24:35] violetto: yeah, looks like crumpled paper :D [00:24:39] violetto: i'll keep this in for now tho [00:25:59] YuviPanda: yeah. i dont know how doable now, but if its not hard can you reduce all the icon sizes by 30%? if not we can do that later [00:26:05] YuviPanda: ok off now, brb! [00:26:12] violetto: we'll tweak that later. You make your way home [00:26:13] :) [00:26:17] mhurd: did brion respond? [00:26:59] (03PS27) 10Kaldari: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [00:27:49] jdlrobson: It's reverted now [00:30:09] (03PS11) 10Dr0ptp4kt: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [00:30:50] (03CR) 10jenkins-bot: [V: 04-1] SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [00:31:09] ok where was i [00:31:13] got sidetracked [00:32:16] wooo brion! [00:32:27] hey hey sorry for the delay [00:32:31] time for some cr \o/ [00:32:45] brion: :D [00:33:53] (03PS1) 10Yuvipanda: Add My Contributions & Logout to left nav menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119910 [00:33:56] brion: I'll be on for another 30min I think [00:34:04] ok [00:34:57] (03CR) 10Yuvipanda: [C: 04-2] "Going with a pre-expanded menu for now." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119891 (owner: 10Yuvipanda) [00:34:59] ok while intellij loads i'm gonna make a coffee real quick :D [00:35:08] brion: don't get distracted again :) [00:37:09] :D [00:37:32] brion: I'll probably do an alpha build when this set gets merged [00:37:38] sweet [00:39:22] (03CR) 10Brion VIBBER: [C: 032 V: 032] Added new bookmark icon for saved pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119906 (owner: 10Yuvipanda) [00:41:56] jgonera: https://gerrit.wikimedia.org/r/119911 [00:43:02] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Nice; activities and intents used to flow data. Very Android!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119543 (owner: 10Yuvipanda) [00:43:49] oh MAN the new constructor is nicer [00:43:56] removers a lot of chained calls to get executors :D [00:44:03] brion: INORITE! [00:46:52] hm getting some test failures, lemme cross-check [00:47:29] brion: I think some of our tests have been failing for a while... :( [00:48:13] (03CR) 10Jdlrobson: [C: 032] Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [00:48:22] (03PS10) 10Jdlrobson: Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [00:48:57] yeah they're broken before too. ok i'll do some cleanup on them tonight :D [00:48:58] (03Merged) 10jenkins-bot: Story 1521: Allow switching from VisualEditor to Wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111253 (owner: 10Jdlrobson) [00:49:03] lemme do spot-checks in the app then [00:49:36] brion: ok :) [00:52:33] ok i think my phone is borked cause now nothing works [00:52:34] reboot! [00:53:13] all net communications were hanging [00:53:22] hmmmm, or maybe that's my comcast ipv6 again [00:55:12] brion: works better? [00:55:45] (03CR) 10Jdlrobson: [C: 032] Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [00:56:26] (03Merged) 10jenkins-bot: Fix close button behavior for editors after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119424 (owner: 10Kaldari) [00:57:01] ahhh that's better [00:57:08] not sure what the hell was going on but it's talking to wikipedia aagain [00:58:57] aaaand now it's back to broken [00:58:59] wtf [00:59:00] (03CR) 10Kaldari: [C: 032] Explain deleted Revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118744 (owner: 10Jdlrobson) [00:59:21] jdlrobson: what's the bug? [00:59:38] (03Merged) 10jenkins-bot: Explain deleted Revisions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/118744 (owner: 10Jdlrobson) [00:59:42] kaldari: https://bugzilla.wikimedia.org/show_bug.cgi?id=62906 [01:01:28] jdlrobson: I bet it's from the closeOnBack flag :( [01:02:11] ok working again [01:02:18] flaky usb port? i dunno :P [01:02:27] ok quick editing test then merge [01:03:14] (03CR) 10Brion VIBBER: [C: 032 V: 032] Simplify SaneAsyncTask constructor boilerplate. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119642 (owner: 10Yuvipanda) [01:03:29] now for the fun bit -- the contribs \o/ [01:08:43] ok definitely needs some work regarding namespaces [01:09:29] hmmm, and we'd have to think about how to handle multiple language contributions [01:10:35] brion: yah, for now it just shows active wiki. [01:10:57] brion: we could have a way to 'switch' wikis at some point quickly. not just for this but in general. [01:14:24] (03CR) 10Brion VIBBER: "Few things this needs fleshed out, though this won't block merging yet:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 (owner: 10Yuvipanda) [01:15:22] (03CR) 10Brion VIBBER: "activity title isn't localized" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 (owner: 10Yuvipanda) [01:17:06] (03CR) 10Yuvipanda: [C: 04-1] "Yeah, the app assumes namespace 0 in a lot of places. Needs cleaning up in general." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 (owner: 10Yuvipanda) [01:17:40] brion: fixing localization now [01:17:48] brion: i also dunno how I gave it a -1 [01:17:54] (03CR) 10Brion VIBBER: Add User Contributions page (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 (owner: 10Yuvipanda) [01:17:57] heh [01:18:00] you clicked too many things :D [01:18:27] brion: heh [01:18:45] YuviPanda: ok fix the localization at the fromHtml call on plaintext and i think we're good to go for now [01:18:48] looking forward to diffs :D [01:18:55] brion: yeah am fixing it :) [01:19:02] brion: I also just got my OTRS account :D [01:19:05] s/at the/and the/ [01:19:07] ah nice [01:19:16] i gotta check my queues and make sure i'm on the right ones [01:21:19] brion: :) [01:21:23] brion: we are getting new ones [01:21:59] (03PS2) 10Yuvipanda: Add My Contributions & Logout to left nav menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119910 [01:22:01] brion: there! [01:22:01] (03PS7) 10Yuvipanda: Add User Contributions page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 [01:23:02] whee [01:23:35] YuviPanda: *cough* My Contributiions *cough* [01:23:39] hi folk. someone awake ;-) [01:25:43] may i throw a question in? Anyone knows if the traffic between APP and wikipedia is SSL encrypted? [01:26:49] justme: in the new version of the app yes. in the version currently in the store..... i think so? but there's no login features in the release version as well, just simple browsing [01:27:39] (03PS8) 10Brion VIBBER: Add User Contributions page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 (owner: 10Yuvipanda) [01:28:20] (03CR) 10Brion VIBBER: [C: 032 V: 032] "fixed the 'My Contributiions' :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119800 (owner: 10Yuvipanda) [01:31:35] (03PS3) 10Brion VIBBER: Add My Contributions & Logout to left nav menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119910 (owner: 10Yuvipanda) [01:32:26] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add My Contributions & Logout to left nav menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119910 (owner: 10Yuvipanda) [01:34:22] thank you! but i guess this is only for user login (is that correct?), whereas the servers allow to encrypt all the traffic (e.g. with HTTPS everywhere) [01:35:16] justme: in the new app, all traffic is encrypted [01:35:26] in the old app it can switch to non-ssl in some circumstances [01:35:59] ah. i see. thanks for your hell :-) [01:36:07] :D [01:36:12] help [01:36:28] ;-) [01:36:58] hehe [01:39:08] typing in english on a tablet with non-english spell correction at half past two in the morning is not a trivial task :-) [01:52:03] (03PS1) 10Kaldari: Fixing double warning regression [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119922 [01:52:28] (03CR) 10Kaldari: [C: 032] Fixing double warning regression [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119922 (owner: 10Kaldari) [01:53:16] (03Merged) 10jenkins-bot: Fixing double warning regression [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119922 (owner: 10Kaldari) [03:14:54] YuviPanda: There *is* another room where you can sit and hangout… [06:12:29] (03CR) 10Jdlrobson: [C: 04-1] "This doesn't work. Can we please revert back to my older patch and tackle the JavaScript startup url in a separate patch." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [06:20:13] vbamba: hey! can you come to the design channel? [06:22:55] hey [06:23:05] (03PS1) 10Jdlrobson: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119938 [06:27:15] (03PS12) 10Jdlrobson: WIP: SpecialMobileWebApp: Get the startup module caching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 [06:27:17] (03PS2) 10Jdlrobson: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119938 [06:31:32] (03CR) 10Jdlrobson: [C: 04-1] "(see bug 59623)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [14:24:46] (03PS1) 10Cmcmahon: QA WIP: merge when mediawiki-selenium v 2.16 is available. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120001 [16:07:07] (03PS3) 10Jdlrobson: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119938 [16:11:58] (03CR) 10Jdlrobson: [C: 04-1] "This is still not caching any more even after removing Adam's code. Will need to investigate / revert to older patchset." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119938 (owner: 10Jdlrobson) [16:14:31] (03PS2) 10Cmcmahon: MobileFrontend and UploadWizard share upload steps. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120001 [16:15:15] (03CR) 10Cmcmahon: [C: 032] "mediawiki-selenium 2.16 is available now" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120001 (owner: 10Cmcmahon) [16:16:04] (03Merged) 10jenkins-bot: MobileFrontend and UploadWizard share upload steps. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120001 (owner: 10Cmcmahon) [16:55:12] MaxSem, we no longer set X-Analytics in the vcl_recv, so you can assume that you never get it in the incoming headers (might even be safer as this way it won't be polluted by bogus request) [17:14:40] also, MaxSem you are working on hhvm? are wi switching to hack? [17:15:03] see engineering@ [17:16:06] YuviPanda: brion standup! [17:16:14] standup! [17:21:37] MaxSem: jdlrobson jgonera kaldari brion mhurd yurik dr0ptp4kt any out-of-band, big, and/or unusual deployments coming up next week? [17:22:01] no [17:22:06] not for me at least [17:22:14] nah [17:22:21] awjr: no [17:22:56] neat thanks gents [17:24:44] awjr, nothing other than the usual wednesday work and train [17:27:53] jdlrobson, so what did you need my help with? [17:28:16] MaxSem: https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1770 [17:31:00] well [17:31:38] I tried reproducing it dozens of times myself over the last 2 years, and was never able to [17:39:32] MaxSem: what awjr said [17:39:52] chrismcmahon: what kind of machine are you on and what does cloud bees use? [17:40:09] and MaxSem what you said - i can't replicate it either [17:40:52] awjr, can we do something so that mingle stops signing us out? [17:42:34] jgonera: probably not directly [17:42:44] but we could probably file a ticket with thoughtworks [17:42:53] can we do that please? [17:42:56] mhurd: awjr i'll be about 15 mins late to meeting, some hiccups with travel [17:42:59] this is the downside to no longer hosting our own version :( [17:43:14] jgonera: http://www.thoughtworks.com/products/support [17:43:20] you can submit a ticket from there ^ [17:44:39] violetto: gotcha [17:47:29] kenanwang, mhurd: i am not on the invite for the meeting - do you guys want me there or are you good without me? [17:48:20] awjr: if you're available join in :) [17:48:39] sure thing mhurd [17:48:51] awjr, done, almost, if they really send me an email to confirm [17:48:57] mhurd: do you want me to facilitate or should i be a fly on the wall? [17:49:04] jgonera: :p [17:49:39] jgonera: hopefully you'll get some kind of response - i've gotten responses to ~75% of the tickets i've submitted but maybe 25% of those have been favorable :-/ [17:50:25] awjr: oh, facilitating would be great! [17:50:31] sure thing mhurd [17:50:53] awjr: thanks! [17:51:00] mhurd: are we looking at https://trello.com/b/MQ0Nxt48/mobile-app-sprint-28? [17:51:21] awjr: yes [17:52:09] cool [17:53:54] (03CR) 10Jdlrobson: "I stand corrected this is fine (I had made changes to core which broke it)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119938 (owner: 10Jdlrobson) [17:55:52] jdlrobson MaxSem awjr it seems inescapable that from time to time on beta labs, at line 208 of SpecialMobileOptions.php "if ( $request->getVal( 'token' ) != $context->getMobileToken() )" is true. The token for $request and the token for $context are different. that is the only possible source of the error that we see, and we see that error in the builds often. [17:56:28] i can imagine session storage being the culprit, or something weird happening with cookies [17:56:44] hmm, ok [17:57:16] chrismcmahon, unless there are multiple instances of the same browser from the same machine on that page at the same... [17:57:52] it which case it is C++ developers' favorite situation, undefined behaviour [17:58:02] MaxSem: no, when I repro locally I can guarantee only one browser from my host [18:00:30] is there a way we can ensure that session and session cookies are fully reset after each test run? [18:01:09] awjr: yes, each new scenario starts a new brower with a fresh profile [18:01:31] awjr: the profile is created the same time the browser instance is [18:01:50] chrismcmahon: then if that's working correctly, then there may be smoething wonky with session storage itself on the backend [18:02:14] awjr: ok. I have a call out in -labs, Coren might have a thought about it [18:03:23] cool chrismcmahon [18:03:31] i have no idea how session storage works on betalabs [18:04:36] thanks for the head's up violetto, see you soon [18:13:49] awjr: looks like I have to miss the meeting . I looked at trello, it looks fine to me, looks like a more engineering side work. [18:14:06] ok bummer violetto but thanks for letting us know [18:49:39] (03PS1) 10JGonera: Fix OverlayManager#replaceCurrent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120053 [18:49:56] kaldari, ^ [19:01:13] (03PS13) 10Jdlrobson: WIP: SpecialMobileWebApp: Get the startup module caching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 [19:01:15] (03PS4) 10Jdlrobson: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119938 [19:35:56] (03CR) 10Jdlrobson: [C: 04-2] "Note we will be able to extra version url using:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [19:49:06] violetto: hey can u send me that link to the page documenting the colors again? [19:50:15] mhurd: https://trello.com/c/IRqbu8p4/15-color-swatches [19:50:24] violetto: thanks!!!! [19:50:37] mhurd: ;D [19:50:46] violetto: i bookmarked it this time [19:58:44] violetto, is this something we should be using in all projects? how final is it? [20:02:27] jgonera: its the most final of all [21:29:00] (03CR) 10Kaldari: [C: 032] Fix OverlayManager#replaceCurrent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120053 (owner: 10JGonera) [21:29:41] (03Merged) 10jenkins-bot: Fix OverlayManager#replaceCurrent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120053 (owner: 10JGonera) [22:05:16] jdlrobson: can I ask you some stuff about https://gerrit.wikimedia.org/r/#/c/110649/ ? [23:06:25] mhurd: YuviPanda kenanwang i got bugello working again [23:06:27] which, yay [23:06:38] but now there are a ton of bugs on your sprint 27 board :-/ [23:06:59] awjr: hehe bugs! that's... awesome? :) [23:07:07] hehehe yeah [23:07:19] some of them are quite old and maybe you guys have already dealt with [23:07:26] how do you normally triage incoming bugs? [23:08:23] awjr: we were going through them at the tail end of our standups iirc - like mobile web [23:08:33] ok cool [23:08:47] dr0ptp4kt: yurik it appears that bugello hasn't been running for you guys for quite some time [23:09:10] dr0ptp4kt: yurik i wasa bout to make it go, but then realized that ma not be desirable [23:09:11] d'oh. any way you can remediate that? [23:09:23] dr0ptp4kt: yeah, i just wanted to make sure it was desirable before i did [23:09:24] it [23:09:33] awjr, it's fine as long as it doesn't delete things. [23:09:33] the primary reason it hasn't been working is because your board name changed [23:09:37] dr0ptp4kt: it wont [23:10:10] awjr, argh. i don't recall when that happened. that is all i know and don't know. thanks for catching it, though. [23:10:20] np dr0ptp4kt [23:10:34] even if you did have the board name right, it still would have been busted for a couple of weeks post tool labs migration [23:11:20] looks like last time it successfuly ran was 2/7 [23:11:30] anyway, i just ran it and all looks OK now [23:11:35] it only found 2 bugs, not so bad :)