[00:01:31] * jeremyb waves tfinc [00:01:40] jeremyb: greetings [00:01:58] tfinc: so, did you choose another admin? :) [00:02:04] (03PS2) 10Dr0ptp4kt: Use CirrusSearch. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/121562 [00:02:34] jeremyb: no. i asked rob about the shared admin password that you were talking about and he didn't have one. i'm guessing there isn't one and that i just need to share the pass with someone [00:02:42] jeremyb: is that how we've chosen to manage these lists ? [00:04:58] tfinc: i'm confused. there's at least 6 different passwords. tfinc's personal password for his subscription, the list admin password (shared), the list moderator password (shared, maybe not set yet), the list creator password for the whole installation (can only be used to make new lists; philippe and thehelpfulone have this), and the admin password for the whole instance [00:05:12] i was talking about the (shared) list admin password [00:05:39] jeremyb: ops had no idea what the "the (shared) list admin password" was [00:06:01] well what password do you actually have? [00:06:04] (03CR) 10Jdlrobson: [C: 032] "It is past Thursday morning and this looks good to me" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120745 (owner: 10Kaldari) [00:06:12] "tfinc's personal password for his subscription,"? [00:06:29] jeremyb: my own and the custom one for mobile-l [00:06:41] "custom"? [00:06:50] hence why i said that i didn't know the shared admin password [00:06:56] whatever i set it to when i had the list created [00:07:02] aha! [00:07:13] basically can you log in to https://lists.wikimedia.org/mailman/admin/mobile-l or not? [00:07:20] so as soon as someone tells me the shared password i can change it [00:07:21] yes [00:07:24] yay! [00:07:41] the shared password is whatever you decide to make it [00:07:46] it's per list [00:08:07] so, choose 1 or 2 other people to share it with [00:08:33] jeremyb: want it ? i'm happy to share it with you and whoever else makes sense [00:08:48] (03PS3) 10Dr0ptp4kt: Use CirrusSearch. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/121562 [00:08:51] well ideally there would be also someone more involved with mobile? [00:08:55] but i could help a little [00:09:25] i.e. i might not read the list at all for a week or two [00:15:41] jdlrobson: jgonera brion dr0ptp4kt MaxSem zz_yuvipanda : who wants to comod mobile-l with me ? [00:16:22] oh, *that's* why yuvipanda didn't tab complete :P [00:16:33] tfinc, time investment? [00:18:43] tfinc: i wonder if there would be a way to do it in shifts or on a rotating schedule or something. it's mostly killing spam, right? [00:18:46] tfinc: so, AIUI, Wikipedia used to not have admin accounts that could delete stuff. instead deletion authenticated via a shared password and all the people that could delete had the same one [00:19:18] jdlrobson jgonera FYI https://en.wikipedia.org/w/index.php?title=MediaWiki:Mobile.css&curid=37191945&diff=601499881&oldid=596037685 [00:19:33] dr0ptp4kt: i guess some is responding to spam already on the list and some is dealing with messages in the queue [00:19:50] tfinc: speaking of which, did we actually ban that spam yet? [00:20:18] StevenW, thanks [00:23:33] tfinc: i'll help. hopefully some others will join in. [00:24:04] dr0ptp4kt: thanks [00:24:10] jeremyb: i almost never have to deal with it [00:24:18] so id say just above zero [00:24:39] as i have the list discard almost anything that looks fishy [00:24:51] works really well almost all the time [00:26:48] StevenW: sigh.. was there any discussion around this? [00:27:00] No idea. Just saw it on my watchlist. [00:27:54] I wish i could comment on diffs..; [00:28:27] tfinc: i mean the conference that keeps mailing. which triggered this whole thing [00:28:39] tfinc: i can help out with that too [00:29:25] (it was at best tangentially relevant. 3 unsolicited mailings is way too much for such a thing) [00:30:13] in other news i need to go dig up some tickets to move into the new mobile queues :P [00:31:58] StevenW: responded - thanks for pointing me at it [00:32:03] np [00:34:05] (03PS1) 10Jdlrobson: Show headings in preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121564 [00:35:03] (03PS1) 10JGonera: Regression: Fix fixed header emulation on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121565 [00:39:42] awjr: yt? [00:39:56] I have a Scrum scum question for you. [00:40:11] StevenW: hello [00:40:13] what's up [00:40:22] So when you're in the middle of a sprint. [00:40:30] and you can see velocity is lower than before [00:40:43] do you ever remove things from backlog that are lower priority to reduce scope? [00:41:15] StevenW: no, you can't reliably guess a given sprint's final velocity in the middle of it [00:41:51] But I can [00:41:52] StevenW: imagine: team's velocity is 24. there are two 8 pt cards in the sprint and four 2 pt cards [00:41:55] I KNOW [00:42:08] lol ok ok [00:42:15] In this case it's a bit janky [00:42:31] we're doing ghetto velocity estimation. The number of cards completed, not points. [00:42:43] oh well that's your problem them :p [00:43:03] but anyway by now we've usually completed like 12 cards and we have three cards done. [00:43:10] So I am tempted to take some shit out. [00:43:32] StevenW: so let's say the three cards you have done were super hard but the reamining 9 are really easy [00:43:38] how do you know? [00:44:30] I think it's more like. A lot of the remaining cards are blocked on review. And some of the remaining cards are easy, but not really that important. [00:44:48] WHY CAN'T YOU JUST DITCH MOBILE AND HELP ME WAAAAH [00:44:51] ;) [00:44:54] StevenW: what do you gain by removing cards from the iteration? [00:45:02] :p [00:45:17] Hmm. Good question. [00:45:39] StevenW: conversely, i guess, what do you lose by keeping them in? [00:46:03] The possibility people go pick them up before really finishing the other cards [00:46:20] because it's easier to start something and put it up for review than unblock someone else by reviewing a bunch [00:47:14] StevenW: am i hearing correctly then that this is (in part) an issue of code not getting reviewed because people are picking up new work? [00:47:54] Yes. [00:47:58] yeah that's a hard one [00:48:03] we grapple with that too [00:48:05] I will just yell at people. [00:48:08] lol [00:48:11] and hit them with sticks [00:48:12] is that effective? [00:48:32] https://twitter.com/mfdii/status/439585397031464960 [00:48:43] lol [00:48:43] Yes. Developers fear pain. [00:48:56] well then what's the problem :p [00:48:58] Anyway, thanks for the talk. [00:49:27] (03CR) 10Jdlrobson: [C: 032] Regression: Fix fixed header emulation on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121565 (owner: 10JGonera) [00:49:55] no problem, i hope it was fruitful. but it sounds like you guys should figure out a strategy to manage the code review issue. maybe it's no one picks up new work until there are no unreviewed patches in gerrit, maybe it's taking cards out of the iteration [00:50:07] (03Merged) 10jenkins-bot: Regression: Fix fixed header emulation on iOS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121565 (owner: 10JGonera) [00:50:12] StevenW: ^^ [00:50:30] play around and see what works. keep doing if it works, stop doing it and try something else if it doesnt [00:50:44] I think taking cards out. [00:50:54] And probably doing real planning poker. [00:50:57] :) [00:51:13] But I hate this scum master business. I just want to think of new features and wave my hands. [00:51:22] like all product managers [00:51:38] the code review issue is because we are 1) siloed from other teams 2) each team does things differently so we increase the barrier to code review 3) in general developers prefer building stuff then reviewing stuff 4) developers are not being hit by sticks [00:51:47] StevenW: wearing both product and scrummaster hat is also a tough one. the roles are very different and in some ways fundamentally at odds with eachother [00:51:53] yes [00:52:04] jdlrobson: are you advocating the stick approach? [00:52:09] it's like simultaneously being a lion and a zebra [00:52:18] it's worth a go ;-) [00:52:18] (PMs are the lions.) [00:52:19] basically you just wind up eating yourself [00:52:33] while trying to run away? [00:52:48] jdlrobson: maybe i will take this advice https://twitter.com/mfdii/status/439585397031464960 [00:54:05] StevenW: are you on the mobile-l list? [00:54:09] yes [00:54:21] unfortunately. jdlrobson writes too much email. [00:54:29] lulz [00:54:30] he's almost a director. [00:54:53] * StevenW is taking off. Thanks again [00:55:04] hasta [00:56:08] o [00:56:09] i [00:56:13] i'm a robot [00:56:54] ¥[*.*]¥ [00:57:16] funny enough i write more email when i can't write code due to code review backlog :) [09:23:26] (03CR) 10Siebrand: [C: 032] "Jon forgot to remove the -2 that was on this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120745 (owner: 10Kaldari) [09:24:08] (03Merged) 10jenkins-bot: Story 1732: Make licensing agreement customizable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120745 (owner: 10Kaldari) [11:19:33] (03PS3) 10Amire80: Change capitalization to "In the news" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121394 [11:27:40] (03CR) 10Siebrand: [C: 032] Change capitalization to "In the news" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121394 (owner: 10Amire80) [11:28:17] (03Merged) 10jenkins-bot: Change capitalization to "In the news" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121394 (owner: 10Amire80) [16:43:08] (03CR) 10Awjrichards: [C: 032] Hygiene: Handle fatal errors when loading talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120864 (owner: 10Kaldari) [16:44:20] (03Merged) 10jenkins-bot: Hygiene: Handle fatal errors when loading talk page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120864 (owner: 10Kaldari) [17:24:20] jgonera, awjr: I also have two changes to WikimediaMessages that have to be merged before Tuesday. They were supposed to be merged before the MobileFrontend change, but Siebrand took my -2 off that change by mistake. The 2 changes are: https://gerrit.wikimedia.org/r/#/c/120728/ and https://gerrit.wikimedia.org/r/#/c/121106/ [17:27:27] brion: email sent :) [17:27:36] whee [17:30:53] brion: one thing to try - if you comment out line 80 of #import "TabularScrollView.m” (the makeObjectsPerformSelector line) you’ll get an actual warning in the console output [17:31:13] curious [17:31:24] brion: ya! so weird [17:32:17] brion: my gut feel is i’m doing something so spectaculary obvious that i can’t see it [17:32:30] hehe [17:32:32] we’ll see :D [17:47:03] brion: another thing to try which produces better error msg - MainMenuViewController.m’s viewWillAppear to viewDidAppear [17:47:56] hmmm [17:50:04] i don’t get why it’s complaining about nested push animation; the pushViewController calls look sane enough to me… [17:52:37] brion: i know right! i suspect that if we track it down we can then switch back to viewWillAppear… [17:52:56] brion: so… odd! [17:53:04] srsly [17:53:15] hehe [17:54:39] (03CR) 10JGonera: [C: 04-1] Hygiene: Clean up main menu css (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121550 (owner: 10Jdlrobson) [17:55:15] brion: looking through storyboard source at mainmenuviewcontroller tag… now that’s a sign of desperation [17:55:45] heh [17:58:21] brion: the storyboard stuff looks ok [17:58:43] brion: the id’s seem to reference things which exist [17:59:33] so if i just disable the animations for the login controller push and pop it doesn’t complain. :P but that seems a bad solution :) [17:59:50] brion: does it complain if you do so repeatedly? [18:00:34] waaaaaaait a minute [18:01:03] mhurd: if i do it repeatedly, every time i open a new one i have to hit the X button one more time to get it to go away [18:01:10] brion: ooooooh! [18:01:11] it looks like it’s actually pushing multiple ones onto the stack somehow… [18:01:13] wtf? [18:01:23] brion: whhhaaaa [18:01:27] inorite [18:01:56] brion: reproduced! [18:02:00] awjr: made notes and added bits to your outline [18:02:01] brion: really good catch! [18:02:06] \o/ [18:02:11] i don’t know how it’s doing that though [18:02:17] brion: now we’re getting somewhere! [18:02:17] mind bloooown [18:02:19] :D [18:02:21] lol [18:05:41] mhurd: ok I think the TabularScrollViewItemTapped notification is getting re-added every time the main menu controller gets displayed [18:05:51] brion: oh god [18:05:52] so when we go to login and come back, a second listener is registered [18:05:58] and so the listener is called twice [18:06:01] *facepalm* [18:06:23] /o\ [18:07:37] brion: ah the viewWillDisappear is removing “TopActionSheetItemTapped” and it’s not named that anymore!!!!!! [18:07:41] thanks a bunch tfinc [18:07:45] :D [18:07:49] brion: you’re right!! [18:07:57] if only it gave you a warning on trying to remove a nonexistent listener [18:08:01] that would have been easier to find :D [18:08:08] brion: hehe yea [18:08:16] debugging ftw [18:09:23] brion: thank you so much! background - i renamed the top action sheet scroll view since it can be used in other ways. xcode refactor didnt catch the string identifiers though [18:09:40] never trust the ide :D [18:10:07] brion: ya - i even renamed it in a couple places but somehow i missed 2 other places… [18:10:57] kaldari: looks like jgonera merged one of your open patches [18:11:06] kaldari: is it safe to let https://gerrit.wikimedia.org/r/#/c/121106/3 sit until siebrand can respond? [18:11:18] awjr: i added a couple more bits that managers benefit from relative to your talk. hopefully its helpful [18:11:26] yeah, I pinged Siebrand [18:11:31] also cross team collaboration [18:11:33] ok great kaldari [18:11:39] rad tfinc, thank you, i will take a look in a bit [18:11:46] If it doesn't get merged today, I'll make sure it gets merged on Monday [18:11:52] cool [18:14:48] brb coffee [18:45:55] (03PS3) 10Dr0ptp4kt: Barebones Wikipedia Zero support for FFOS. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/120975 [18:46:27] ^ brion, there's the updated ffox patch. i believe that covers the common case? [18:47:03] (03CR) 10Dr0ptp4kt: "See PS3 for the update." (031 comment) [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/120975 (owner: 10Dr0ptp4kt) [18:50:14] (03CR) 10Brion VIBBER: [C: 032 V: 032] "looks good!" [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/120975 (owner: 10Dr0ptp4kt) [18:51:30] brion, thx [18:54:57] (03PS1) 10Kaldari: Hygiene: Prevent warning when Echo is not installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121710 [18:55:13] brion, does 'submitted, merged pending' mean it was publish-submitted, or does that mean it was published, but not submitted? [18:55:21] hmm lemme check [18:55:41] dr0ptp4kt: it needs an intermediate to be merged, lemme poke that [18:55:51] brion, oh right [18:55:57] (03CR) 10Brion VIBBER: [C: 032 V: 032] Up the version for the Settings - About screen and manifest. [apps/firefox/wikipedia] - 10https://gerrit.wikimedia.org/r/119652 (owner: 10Dr0ptp4kt) [18:56:09] dr0ptp4kt: ok that seems to have done it [18:56:18] brion: thx again [18:56:28] sure :D [19:19:01] mhurd: give me a ping when the ios updates are ready, or if you need me to help poke anything else [19:19:30] brion: k - had one other weird run-loop issue that i think i just resolved. will test for a bit then submit :) [19:20:06] awesome :D [19:30:22] (03CR) 10Jdlrobson: [C: 032] Hygiene: Prevent warning when Echo is not installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121710 (owner: 10Kaldari) [19:34:28] (03Merged) 10jenkins-bot: Hygiene: Prevent warning when Echo is not installed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121710 (owner: 10Kaldari) [19:36:03] (03CR) 10Jdlrobson: [C: 032] Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121777 (owner: 10L10n-bot) [19:36:36] (03PS1) 10Jdlrobson: QA: Avoid issues for Chrome diff browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121798 [19:36:44] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121777 (owner: 10L10n-bot) [19:39:21] MaxSem: you following https://bugzilla.wikimedia.org/show_bug.cgi?id=62614#c52 ? [19:39:55] yes [19:41:17] don't quite understand what Chris is asking for [19:58:43] jgonera: BTW, did you see Trevor's split of the link styling for Apex? Roan just got it merged in VE-MW master. [20:00:57] \o/ [20:07:42] MaxSem: I think chris steipp is wanting us to log something on beta labs when the token doesn't match [20:10:02] Also MaxSem awjr can one of you poke http://www.mediawiki.org/w/index.php?title=Extension_talk:MobileFrontend&offset=20140328114338&lqt_mustshow=41364#HTTPs_in_Mobile_View_Link_41364 [20:10:06] I don't know the HTTPS code that well [20:10:09] seems to have been going on for some time [20:11:00] I'm in a meeting [20:11:22] same [20:15:19] yurik, you able to push the latest ffos app during the regular window next week? [20:17:49] mhurd: how’s it coming? anything i can help with? [20:18:26] it’s working good now! will submit in 10 minutes or so :) [20:18:51] awesome :D [20:34:17] hey mhurd [20:34:25] violetto: yo [20:35:00] mhurd: was just loooking at trello on what you guys are working on now. hows the toc or left drawer coming along? [20:37:42] violetto: ran into sticking points with left menu and had to re-write a bunch of code (see here get a sense how much had to be re-written https://github.com/montehurd/apps-ios-wikipedia/commit/a2ebdc1841b4a44241444992cc89c2cf67d93453). so basic left menu refine will be done in the next few minutes. [20:42:09] brion: sry took a few minutes longer than i expected [20:42:14] mhurd: can't wait to see it :) [20:42:16] no worries [20:48:20] (03PS1) 10Mhurd: Partial commit. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/121851 [20:48:39] brion: oh hold on i forgot commit msg [20:49:10] (03PS2) 10Mhurd: Left menu refinement. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/121851 [20:49:54] woot [20:49:59] mhurd: ok does that replace the other one? [20:50:31] brion: lemme check [20:50:38] brion: yes [20:50:49] ok go ahead and mark the other one as abandoned and i’ll test this one out [20:50:55] brion: k [20:53:16] brion: crap i forgot to make the lang picker keyboard done button hide it - adding now sry! [20:53:22] heh ok [20:53:25] so far so good otherwise [20:55:37] (03CR) 10Kaldari: [C: 032] Package issues template with issues module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121528 (owner: 10Jdlrobson) [20:56:19] (03Merged) 10jenkins-bot: Package issues template with issues module [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121528 (owner: 10Jdlrobson) [20:57:23] (03PS3) 10Mhurd: Left menu refinement. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/121851 [20:57:54] brion: ^ should fix lang done button [20:58:04] ok [20:58:46] (03Abandoned) 10Mhurd: Main menu - now with icons! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/120982 (owner: 10Mhurd) [20:59:08] brion: i abandoned the orphaned branch [20:59:13] ok [21:07:55] hey kenanwang [21:08:08] are you in the office or remote? [21:08:26] Hey remote [21:08:39] Can we do a hang out? [21:09:18] sure [21:09:24] hang on, getting my power adapter [21:15:02] (03PS4) 10Mhurd: Left menu refinement. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/121851 [21:15:11] brion: sorry found one more! [21:15:19] brion: that’s it though! [21:16:09] brion: gonna grab lunch to make sure :) [21:18:00] heh [21:21:37] (03CR) 10Brion VIBBER: [C: 032 V: 032] "\o/ yay" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/121851 (owner: 10Mhurd) [21:21:49] brion: i have a list of changes for this release if u want for the email [21:21:54] brion: yay! [21:22:00] mhurd: oh yes please [21:22:24] brion: k will email in just a sec [21:25:40] tfinc: thanks again for your input on the outline, good stuff :) [21:25:53] awjr: your welcome. good luck [21:25:58] i'm sure you'll make us proud [21:26:07] :D [21:27:13] entirely offtopic but if anyone wants to listen to some breakbeats/techno/house my brother is streaming a live set at the moment; http://www.goodfridayradio.com:8888/listen.pls [21:28:18] brion: email sent [21:28:40] thx [21:29:15] brion: i don’t mind providing these each time :) [21:29:28] :) [21:30:14] brion: i have a comma at the end of pull to refresh line - no big deal [21:42:22] yurik, yurikL: off the top of your head, do you know the average pagesize for mdot (text + images) and zerodot (text) after gzip compression? i'm going to go look for it, but was hoping you may know and have a quick answer. trying to help ingrid. [21:44:48] ok up on testflight \o/ [21:48:45] awjr: thanks for the station link [21:49:13] tfinc: no problem; turns out he's not actually dj'ing at the moment. i think he just hit shuffle on some music library :p [21:49:23] slacker [21:49:25] ;) [21:49:25] he just told me he'll probably start djing around 430 or so [21:49:28] that's what i said :p [21:51:44] brion: awesome!!!! [21:53:50] brion: mhurd: got thew build :) [21:55:46] dr0ptp4kt: not really, would have to find my excel spreadsheets. I think i sent them to zero [21:56:50] yurikL: yeah, having some problems with my spreadsheet program and broken references (file compatibilities, fun!) [21:58:15] mhurd: brion and now i get to start filing bugs :) [21:58:29] tfinc: what did you find? [21:58:33] \o/ [21:58:35] mhurd: you'll see :) [21:58:46] tfinc: sigh [21:58:51] kenanwang: ready for sign off column still looks bad [21:58:55] think you'll get to it today? [22:00:26] mhurd: brion https://bugzilla.wikimedia.org/show_bug.cgi?id=63241 [22:00:39] also, why don't we have a bot showing bugs getting cut to us in this channel ? [22:01:22] tfinc: i don’t understant that bug [22:02:27] hmm [22:02:36] tfinc: browsing history uses the search icon for searches [22:02:45] and a link icon for links [22:02:46] etc [22:02:56] brion: not sure what that means… maybe if the article didn’t have and image he’s seeing the placeholder icon? [22:03:48] brion: ooooh! i see - it needs the little “dice” icon for random! [22:06:41] brion: i need to refactor a bit to make that happen... [22:09:09] hi  [22:09:18]  recently i got an advice from a community member to concntrate my proposal on a specific point, so should i include both "annotation type captcha" and "odd one out type captcha" in the proposal and come to conclusion during community bonding period or should i remove one of the method right away? After bugzilla discussion i have narrowed down to these two points in specific [22:09:26]  i was aiming to come to final conclusion after disucssion with mentor's during community bonding period but now since we have narrowed down to some specific point, i need your advice for which approach would be best suited? [22:19:30] (03CR) 10Cmcmahon: [C: 032] "checked in FF and Chrome" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121798 (owner: 10Jdlrobson) [22:20:10] (03Merged) 10jenkins-bot: QA: Avoid issues for Chrome diff browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121798 (owner: 10Jdlrobson) [22:21:59] (03PS1) 10MaxSem: Better log failed token checks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121879 [22:23:12] (03CR) 10CSteipp: [C: 031] Better log failed token checks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121879 (owner: 10MaxSem) [22:25:39] (03PS1) 10Kaldari: Hygiene: Clean up formatting of search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121880 [22:28:22] (03CR) 10Kaldari: "The diff formatting on SearchOverlay.html looks like a total mess, but the only actual change is putting all the existing HTML inside a ne" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121880 (owner: 10Kaldari) [22:28:33] anyone wants to review ^^^? [22:33:59] MaxSem: is it actually useful to be able to compare the tokens? [22:34:11] Chris requested it [22:34:17] fair enough :) [22:35:37] jdlrobson: ready when you are [22:35:56] (03CR) 10Kaldari: [C: 032] Better log failed token checks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121879 (owner: 10MaxSem) [22:36:29] (03Merged) 10jenkins-bot: Better log failed token checks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121879 (owner: 10MaxSem) [22:36:39] thanks:) [22:38:58] tfinc: fixed that bug! :) [22:39:06] mhurd: thanks [22:39:28] mhurd: figured it was an easy fix [22:39:44] tfinc: wasn’t too bad [22:56:44] tfinc: do we have an android play store account that we can download paid apps? [22:59:30] violetto: we do not. you would have to expense them [22:59:30] (03PS1) 10Mhurd: Fix for history not showing random icon. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/121886 [23:00:14] tfinc: ah, okay [23:39:17] tfinc: if you're still interested he claims he'll be starting to actually dj in a couple of minutes [23:47:18] ok now he's actually dj'ing [23:49:43] tfinc: think i’m gonna head out - worked through lunch… stomach growling :) [23:49:47] (03CR) 10Jdlrobson: Hygiene: Clean up formatting of search overlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121880 (owner: 10Kaldari) [23:49:57] (03PS2) 10Jdlrobson: Hygiene: Clean up formatting of search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121880 (owner: 10Kaldari) [23:50:34] actually kaldari even with that patch it's not perfect.. [23:50:58] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Clean up formatting of search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121880 (owner: 10Kaldari) [23:51:52] (03CR) 10Jdlrobson: [C: 032] Hygiene: Clean up formatting of search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121880 (owner: 10Kaldari) [23:52:24] (03Merged) 10jenkins-bot: Hygiene: Clean up formatting of search overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121880 (owner: 10Kaldari)