[00:09:28] (03PS6) 10Jdlrobson: Card 1814 (Story 1747): Notification drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120733 [00:09:46] (03CR) 10Jdlrobson: Card 1814 (Story 1747): Notification drawer (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120733 (owner: 10Jdlrobson) [00:09:53] (03CR) 10Jdlrobson: Card 1814 (Story 1747): Notification drawer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120733 (owner: 10Jdlrobson) [00:13:48] (03PS2) 10Jdlrobson: QA: Make sure watchlist tests are setup correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120938 [00:14:16] (03CR) 10Jdlrobson: QA: Make sure watchlist tests are setup correctly (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120938 (owner: 10Jdlrobson) [00:26:50] so sethen http://git.wikimedia.org/tree/mediawiki%2Fextensions%2FMobileFrontend is where you will find our code [00:26:56] Awesome [00:27:01] commits and git clone link are at http://git.wikimedia.org/summary/mediawiki%2Fextensions%2FMobileFrontend [00:27:11] LESS, huh? [00:27:24] yup using LESS now. Made life a hell of a lot easier [00:27:30] Haha, I am sure! [00:27:35] Are you using OOCSS? [00:27:38] With your LESS? [00:27:41] http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend/dfe9d942779c31630533c622c7568c47ad0d55e7/README.mediawiki gives you all the details about our coding conventions etc [00:27:50] Nice. [00:28:13] sethen: not currently. I was keen to explore using it after speaking to Nicole Sullivan and another friend but never got round to working out if it would be a useful practice for us to adopt [00:28:16] would you recommend it? [00:28:38] After using it, I think it's the only way to go. It's a very simple idea with major benefits. [00:29:19] Make a base class with modifiers, in short, is the bees knees. [00:29:33] Making a base class that has modifiers*, excuse me. [00:33:31] ^ jgonera [00:33:48] it's definitely something we should explore using (oocss) [00:34:16] It's just a great concept honestly. [00:34:25] (03Abandoned) 10Jdlrobson: [WIP] Allow users to adjust the font size [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108300 (owner: 10Theopolisme) [00:34:44] yeh it sounds good on paper, i've just not got any first hand experience with it [00:34:44] Ahh I see, seems like the Makefile is a series of shell and python scripts to run. [00:35:53] (03CR) 10Theopolisme: "Will do. Sorry, https://github.com/WPAFC/afch-rewrite has been taking up all of my time... See you in a few weeks!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/108300 (owner: 10Theopolisme) [00:39:46] Am I able to ask code specific questions in this chat? [00:39:56] Or is there somewhere else this is better suited? [00:41:51] sethen: sure this is fine [00:42:09] yeh it's a helper file to help you work out how to run tests, linting etc [00:42:23] I saw a line in Class.js like Surrogate.prototype = Parent.prototype; [00:42:33] Wondering what the thought process was there [00:43:24] I'm assuming the intent is to assign the methods or properties or Parent.prototype to Surrogate.prototype [00:43:45] it's basically implementing class inheritance yeh [00:43:54] Why this over Object.create? [00:43:56] (03PS2) 10JGonera: [WIP] Base api module on mw.Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121532 [00:44:21] I feel like I have seen done this way, I just always use the Object.create myself. [00:44:26] Not sure how much of a difference it makes. [00:44:37] sethen, might be a good question. We might reevaluate browser support of Object.create, it might be OK for mobile [00:44:55] wow, that was a lot of "mights" [00:45:06] Ah, browser support makes sense. [00:45:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Base api module on mw.Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121532 (owner: 10JGonera) [00:45:49] What are the plans for the project when classes are released in ES6? [00:47:01] I would assume mobile might take some time to catch up. Curious about using transpilers and such. [00:47:29] wait until 99% of browsers used by our users support ES6 [00:47:38] transpilers? [00:47:53] oh, I see [00:48:01] I don't think we'd use anything like that [00:48:05] Ah. [00:48:22] I thought the Grunt plugin for ES6 was interesting. [00:48:29] although, who knows, if there's one if very wide adoption [00:48:37] if=with [00:48:56] Seems like ES6 is going to be such a radical shift. [00:49:06] Traceur is helping though. [00:49:52] However, I am excited about more classical than prototypal stuff. [00:50:05] Prototypical? I can never say it right. [00:53:40] Alright I am off. Thanks for links Jon, I will look over this stuff. [01:01:29] * marktraceur apparently is pinged on "traceur" [01:01:37] Oh, cool. [01:02:36] jdlrobson: http://thenextweb.com/google/2014/03/31/round-googles-jokes-april-fools-day-2014/ [01:03:00] see you sethen ! [01:03:04] good chatting :) [01:52:00] (03PS1) 10Jdlrobson: Fix watchlist tabs. Protect from future changes with browser tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122627 [06:04:13] (03PS3) 10Yuvipanda: [Gingerbread] Update the manifest to build for Android 2.3.3+ (API level 10) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122543 (owner: 10Brion VIBBER) [06:04:42] (03CR) 10Yuvipanda: [C: 032 V: 032] [Gingerbread] Update the manifest to build for Android 2.3.3+ (API level 10) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122543 (owner: 10Brion VIBBER) [06:05:32] (03PS3) 10Yuvipanda: [Gingerbread] Use compat library version of PopupMenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122544 (owner: 10Brion VIBBER) [10:23:24] (03CR) 10Yuvipanda: [C: 032 V: 032] [Gingerbread] Use compat library version of PopupMenu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122544 (owner: 10Brion VIBBER) [10:23:35] (03PS3) 10Yuvipanda: [Gingerbread] Fix explosion on calling static WebView method [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122545 (owner: 10Brion VIBBER) [13:18:11] (03PS4) 10Yuvipanda: [Gingerbread] Can't use ?attr/selectableItemBackground until v11 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122546 (owner: 10Brion VIBBER) [13:19:13] (03CR) 10Yuvipanda: [C: 04-1] [Gingerbread] Can't use ?attr/selectableItemBackground until v11 (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122546 (owner: 10Brion VIBBER) [13:28:36] (03PS2) 10Yuvipanda: Position edit icon appropriately in RTL pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122580 [13:28:38] (03PS3) 10Yuvipanda: Set text direction of edit summary field for RTL languages properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122576 [13:28:40] (03PS4) 10Yuvipanda: Make license footer display with UI lang directionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122560 [13:28:42] (03PS3) 10Yuvipanda: Set edit text box's directionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122578 [16:21:54] YuviPanda: to get it out of the way, repeating what i said on irc yesterday - not sure if it went through: tfinc is getting access to his protected drive to obtain the signing material. hence no alpha yesterday [16:22:25] YuviPanda: i have not forgotten, though. daily alphas will rule [16:23:34] YuviPanda: ps, not an april fool's joke. speaking of which, i guess i better just shut down my microblogging client now. [17:05:50] IRC so desolate [17:07:51] chirp chirp [17:08:09] * YuviPanda gets some pesticide on awjr [17:08:29] :( [17:09:01] * YuviPanda genetically engineers awjr [17:09:23] lol [17:12:16] YuviPanda: MaxSem im going to close my laptop to save battery. if you need anything, use the hangout chat - we've got it open [17:13:48] awjr_away: ok! [17:22:01] hey brion [17:22:06] yo [17:22:08] brion: rapt attention or have spare for CR? ;) [17:23:56] (03CR) 10Brion VIBBER: Make license footer display with UI lang directionality (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122560 (owner: 10Yuvipanda) [17:24:55] brion: I wonder if a case can be made for just keeping the old app as is for 2.3 [17:25:11] pretty sure we decided against that already [17:25:27] brion: yeah, but hope when it can happen :) [17:25:42] brion: anyway, I will redo that. Nice catch! [17:27:02] YuviPanda: i’ll whip out my test devices and confirm stuff actually works later [17:27:05] i’ve just got th elaptop right now [17:28:48] brion: :) ok! [17:55:03] YuviPanda man wazzup [17:55:07] ohai aharoni [17:55:23] aharoni: so, I was wondering if we should flip images in the *UI* by default and have an exceptions 'no-flip' lift [17:55:25] aharoni: or the other way around? [17:56:44] https://www.mediawiki.org/wiki/Mobile/Release_history [17:57:19] jdlrobson: bring up talk pages? [17:57:36] YuviPanda mmmmmm this is a possibility, but let me see the images. [17:57:43] aharoni: moment [17:57:48] are they in gerrit? [17:57:51] YuviPanda: I guess that's the flow work [17:57:53] aharoni: yes! [17:57:58] jdlrobson: that's not out for at least another year [17:58:05] aharoni: apps/android/wikipedia [17:58:21] aharoni: icon-svgs [17:58:37] YuviPanda: just raised [17:58:42] jdlrobson: ty [17:59:45] YuviPanda: ok, it's not bad [17:59:58] jdlrobson: we try to be symmetric I think. but sometimes not. [18:07:04] aharoni: hmm, so... [18:07:08] aharoni: flip by default? [18:35:33] (03PS1) 10Jdlrobson: Hygiene: Kill mobile.styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122869 [18:46:12] YuviPanda: osrry for disappearing. [18:46:23] so, [18:46:29] aharoni: :) 'tis k! [18:46:43] flip, but definitely not all. [18:46:52] aharoni: but by default flip? [18:46:57] how does it work in Android? [18:47:10] aharoni: android doesn't really do images-in-UI flipping by default. [18:47:14] Only Android btw? It doesn't apply to iOS? [18:47:25] aharoni: I've an image pre-processor that flips it for me [18:47:33] aharoni: I guess it applies to iOS too, but I dont know about that atm. [18:47:38] brion: nice progress on https://trello.com/c/zKClOle9/2-spike-6hr-evaluate-android-2-3-support-to-figure-out-what-is-broken [18:47:38] brion: ^ (re: flipping UI images in iOS) [18:47:47] \o/ [18:53:57] awjr: is it done? I've no idea what is happening now [18:54:10] YuviPanda: we've just been having an adhoc chat [18:54:25] MaxSem: yurik ^ [18:54:30] and i get the sense no one wants to talk anymore [18:54:34] right, and now? [18:54:37] so now we're just waiting for food to show up [18:54:43] awjr: oh, so we can go? [18:54:49] unless we are getting food :P [18:54:58] hehehe i wish we could send you food [18:55:01] * MaxSem runs away [18:55:11] heh [18:55:15] ...to his fridge [18:55:18] heh [18:55:20] YuviPanda: MaxSem yurik yeah feel free to leave, or if you want to keep hanging out i expect random mobile-lated conversation will continue [18:55:21] up to you [18:55:22] I've some cookies [18:55:35] i'm starving :( [18:55:59] awjr: I could hardly follow any of the adhoc chat because more than one person is talking and it all just blurs into one :( So I guess I should just go. [18:56:17] oh crap im sorry YuviPanda [18:56:17] awjr: heh, every year we have more and more people moving to SF :) Next time it'll just be yurik and me! [18:56:36] awjr: no it's ok :) I hate meetings with more than 3-4 in-office participants and try not to get to them anyway. [18:56:47] awjr: I think I'll find tomorrow more useful + focused. [18:57:00] awjr: I brought it up last time too, but I will again too :) [18:57:12] YuviPanda: definitely [18:57:41] awjr: ok, I'm gonna go and get some code done. Do poke me here if I am needed :) [18:57:48] awjr: thanks for running this :) [18:57:59] YuviPanda: no problem, i had very little to do with this morning ;) [18:58:04] awjr: :) [18:59:00] awjr, please ping us when something official starts [18:59:13] MaxSem: we'll be back for mobile-web specific stuff in one hour - 1pm PDT [18:59:17] ok! [18:59:31] no more apps stuff today, IIRC [18:59:55] * brion FTPs YuviPanda a sandwich [19:00:06] * YuviPanda gophers brion some cashh [19:00:18] :D [19:00:44] YuviPanda: ok i’ll poke some review after lunch and see if i can finish up the 2.3 stuff [19:00:53] brion: ! woo! [19:01:05] brion: I'm going to setup UA [19:01:22] (03PS1) 10Yuvipanda: Make convert-icons produce flipped versions of images too [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122872 [19:01:35] brion: ^ RTL flipping :) [19:03:57] nice [19:21:03] YuviPanda: Let me count how many images should be flipeed. [19:21:21] everything under 32 [19:21:29] (8) [19:21:58] 3 or 4 under 24 [19:22:28] YuviPanda: so maybe yeah... flip. [19:39:10] aharoni: hi [19:39:27] is zero going to be part of the cluster? [19:54:35] jdlrobson: heh :) [19:57:01] YuviPanda: heh? [19:57:12] YuviPanda: where in Europe will you be? [19:57:20] jdlrobson: no idea yet. [19:57:24] jdlrobson: you? [19:59:33] MaxSem: we're starting to reconvene - use the hangout link in the retrospective invite [20:16:17] YuviPanda: you gonna be in europe ? [20:16:43] thedj: yeah! :) Not sure where. Berlin most probably [20:16:57] thedj: Amsterdam maybe but that might be expensive... [20:17:29] ams is expensive yes. better go Utrecht then if .nl at all. [20:17:37] berlin is nice [20:18:44] but for a long time ? or to visit ? [20:18:57] thedj: 2 weeks [20:19:53] k. stay in touch ok ? plenty of dutchies/germans/wikimedians/glammers around in those areas :D [20:20:29] thedj: oh yeah very definitely :D I'll know in about a week what the exact plan is... [20:20:58] are you also doing zurich ? [20:21:11] thedj: oh yeah :) [20:21:15] thedj: this is right after Zurich [20:21:20] ah k [20:21:23] thedj: staying in Zurich is out of question because OMG IT IS SO EXPENSIVE :) [20:21:30] quite so yes [20:21:53] i have friends in Davos, I can only stay there by bringing food and sleeping on their couch :D [20:22:11] thedj: :) If you get a Schengen visa via a german consulate, you get to stay for the exact duration you have business there and then you gotta leave [20:22:15] switzerland gives 3 month visas [20:25:29] btw, since I know you all love the exotic nooks and crannies of software and tech..... [20:25:41] thedj: :D [20:25:45] * YuviPanda waits [20:25:50] anyone know software that displays lrm rlm and other unicode markup characters ? [20:26:58] i wanna add a gadget that makes these buggers visible, but if someone thought of a visual style to do that, then i'd love to rip them off :D [20:27:58] perhaps i should ping aharoni :D [20:28:09] thedj: aah :) I can't think of any way to make them visible. I suppose you'll have to JS replace them with printable characters... [20:29:02] yeah, that was the idea, but if there is a conventioin somewhere out there as to which printable chars, i'd like to follow it [20:29:27] yeah, aharoni or nikerabbit might know [20:37:06] dr0ptp4kt: you available? [21:24:30] MaxSem: we are reconvening [21:41:35] thedj, YuviPanda - I am not familiar with any code that implements such a thing. [22:12:23] MaxSem: sorry, i hung up and rejoined - are you still in the hangout [22:21:44] (03PS1) 10Yuvipanda: Set appropriate User Agent string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123117 [22:22:52] (03CR) 10Yuvipanda: [C: 04-2] "Need to figure out why Zero needs agent as a separate param - why can't it default to current user-agent?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123117 (owner: 10Yuvipanda) [22:24:39] mhurd: which story are your working on right now from https://trello.com/b/MQ0Nxt48/mobile-app-sprint-28-last-minute-items ? [22:25:42] mhurd: useragent discussion on mobile-l seems to have reached a satisfactory conclusion. I just sent out a final email with tl;dr. If you aren't setting UserAgent yet, do switch to it when you have the time [22:27:08] tfinc: ah - gonna jump on the css and js sync - had some toc stuff i was putting back together [22:27:14] YuviPanda: cool thanks!!! [22:27:24] YuviPanda: i’ll make a note :) [22:27:32] YuviPanda: or card [22:27:32] mhurd: can you move your card over ? [22:27:44] tfinc: done [22:27:44] mhurd: we might need to do some more header munging for CheckUser. I'll poke you again when that gets clearer [22:27:49] thanks [22:27:54] mhurd: yeah, feel free to add a card if that's how you want to track it :) [22:28:00] YuviPanda: sounds good [22:28:05] mhurd: :) [22:28:09] I should be off now [22:28:19] YuviPanda: have a good night! [22:28:24] mhurd: will do! [23:00:26] (03CR) 10Dr0ptp4kt: [C: 04-2] Set appropriate User Agent string (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123117 (owner: 10Yuvipanda) [23:09:19] (03CR) 10MaxSem: [C: 031] Hygiene: Kill mobile.styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122869 (owner: 10Jdlrobson) [23:28:04] MaxSem: you should be braver and +2 :) [23:28:22] but HACKS! [23:38:03] (03PS1) 10Kaldari: Make "Search in pages" perform a fulltext search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123135