[00:10:11] jgonera: are you around [00:10:25] vbamba, I am [00:10:37] do you have a few minutes to chat? [00:10:43] sure [00:10:57] im in the small bat cave.. [00:11:51] should i come to your desk? [00:12:03] vbamba, whatever works for you ;) should I come? [00:13:27] vbamba, quick decision, before I start working on something [00:13:59] ok you come here [00:14:10] ok, brt [00:26:30] VE on mobile is broken in my local instance. Is it broken for anyone else? (Can't test on beta labs right now since parsoid there is broken) [00:26:34] jgonera: ^ [00:27:27] I get "Exception thrown by ext.visualEditor.core. TypeError: invalid 'instanceof' operand originFn" [00:50:33] (03CR) 10Kaldari: [C: 04-1] Fix watchlist tabs. Protect from future changes with browser tests. (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122627 (owner: 10Jdlrobson) [16:56:20] (03CR) 10Jdlrobson: [C: 04-1] Make "Search in pages" perform a fulltext search (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123135 (owner: 10Kaldari) [17:00:48] YuviPanda: is there a hangout link for this morning’s mtg? [17:04:33] brion: no ther isn't [17:05:24] d'oh [17:07:14] awjr_away: no hangout on our morning invite [17:07:19] YuviPanda: brion: i'm starting a new hangout [17:07:28] ok [17:08:06] calling you guys now [17:08:23] brion: you getting my invite ? [17:08:38] YuviPanda: where you at ? [17:09:01] i’m in :D [17:09:30] YuviPanda: maield you the hangout link [17:11:32] brion: yeah got in. thanks [17:14:28] http://etherpad.wikimedia.org/p/appQ4planning [17:14:41] mhurd: http://etherpad.wikimedia.org/p/appQ4planning [17:14:47] YuviPanda: thx! [17:14:52] mhurd: :) [17:18:04] kaldari: Agouti [17:21:03] jdlrobson, jgonera, MaxSem, awjr_away: Here's the debugging patch in core: https://gerrit.wikimedia.org/r/#/c/122554/ [17:21:48] (03PS1) 10Cmcmahon: QA: set correct watchlist state before clicking watchlist icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123339 [17:22:04] kaldari: looks fine to me ^ MaxSem seems like the best to plus 2 [17:22:40] kaldari, where can we view the debug log? [17:22:44] (03PS2) 10Cmcmahon: QA: set correct watchlist state before clicking watchlist icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123339 [17:23:14] done [17:23:57] awjr_away: https://trello.com/b/h0B6QYBo/mobile-app-backlog [17:24:02] awjr_away: http://etherpad.wikimedia.org/p/appQ4planning [17:24:05] jgonera: It goes into the UDP log, although I'm not sure where you can actually view that [17:24:19] (03CR) 10Jdlrobson: "I'm not sure why this approach is better than mine.. what was wrong with my approach in your opinion?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123339 (owner: 10Cmcmahon) [17:24:34] kaldari, I think we should check that first and know how easy it is to search in this log [17:26:02] jgonera: I believe all the udp logs get written to files on femari, but I need to check [17:26:10] ok [17:27:20] (03CR) 10Jdlrobson: [C: 04-1] "This change makes me happy. Let me know when it is no longer a WIP!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121532 (owner: 10JGonera) [17:27:20] (03CR) 10Cmcmahon: [C: 04-1] "This has the side effect of removing the "?useformat=mobile" argument when opening every URL in every test." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120938 (owner: 10Jdlrobson) [17:27:20] jgonera: it will be very easy to search though, since I create a new logging group for it: https://gerrit.wikimedia.org/r/#/c/122549/1/wmf-config/InitialiseSettings.php [17:27:20] jgonera: which should mean it ends up in a separate file [17:27:21] (03CR) 10Jdlrobson: [C: 04-1] "-1ing until I can get some feedback from Chris." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123339 (owner: 10Cmcmahon) [17:27:32] oh, that's good, thanks kaldari [17:27:44] Can we make a call on https://gerrit.wikimedia.org/r/#/c/110649/ kaldari jgonera - it's been sitting there for a while. Do I abandon or do we want to give it a go? [17:28:22] I'll have to take another look [17:32:56] jdlrobson did you intend to completely remove the "?useformat=mobile" from every URL in every test with https://gerrit.wikimedia.org/r/#/c/120938/ ? I think that's what that does. [17:33:11] dr0ptp4kt: did you send the Mobile carrier info thing to mobile-l [17:34:24] * YuviPanda moves marktraceur [17:35:05] YuviPanda: i asked Philippe to provide feedback on thread and on a separate thread. if no answer today, i think we'll need to email mobile-l today [17:35:21] dr0ptp4kt: yeah, that sounds fair enough :) [17:35:35] dr0ptp4kt: it looked pretty solid to me, although I think we should just put it to mobile-l and wikitech-l at the same time [17:36:22] YuviPanda: no worries about cross-posts not getting through? i guess it happens. [17:36:42] dr0ptp4kt: yeah, not sure how to do that [17:37:07] jgonera: Looks like it should write to a new file /a/mw-log/upload.log on fluorine actually. [17:37:51] YuviPanda: i wish more of our lists would allow outside anonymous post. that way at least the messages get through. then again, i see the drawbacks. i'll just note in the email to both that it's going to both. [17:38:11] dr0ptp4kt: yeah. we might want to have it focused on one [17:41:13] YuviPanda: so mobile-l first, then wikitech-l next? [17:41:19] dr0ptp4kt: probably [17:42:03] YuviPanda: cool. in other news, when's the app follow-up session today? i know arthur said yesterday, but i forgot and can't seem to find it [17:42:15] dr0ptp4kt: right now! turn up! :) [17:42:20] kaldari: awjr: jdlrobson: can one of you guys respond to Dan on mobile-l ? [17:42:31] dr0ptp4kt: r66 [17:42:42] tfinc: you mean "[WikimediaMobile] zap MobileFrontend privacy link via LocalSetttings.php" [17:42:45] YuviPanda: would you please send me the link? [17:42:47] jdlrobson: yes [17:42:55] i responsed to him on the extensions page already but i'll send the link there [17:42:57] YuviPanda: i don't want to walk in and be disruptive [17:43:07] just tune in and be disruptive [17:43:18] dr0ptp4kt: ah [17:43:25] dr0ptp4kt: https://plus.google.com/hangouts/_/76cpivsvchhni7viikq4enel68?authuser=2&hl=en [17:43:38] YuviPanda thx [17:43:39] tfinc: haven't gotten there in my inbox yet but will when i do [17:43:42] dr0ptp4kt: yw [17:44:22] awjr: they came in 3 hours ago search for "zap MobileFrontend privacy link via LocalSetttings.php" [17:44:26] and then search on email [17:44:30] tfinc are they urgent/ [17:44:35] no [17:44:47] but its a user using MF externally that we should help [17:44:57] oh i see, i mean i know they're in my inbox i mean i just haven't gotten to them yet - there's a lot of other stuff in there ;) [17:46:02] tfinc: replied [17:46:06] thanks jdlrobson [17:46:08] tfinc: he's been pretty active in bugzilla [17:46:16] i've replied to a lot of his stuff [17:47:07] jdlrobson: he's got two other questions on list if your up for it [17:47:15] tfinc: he also opened bugs for them [17:47:17] i've replied to those [17:47:19] nice [17:47:22] thanks jdlrobson [17:47:45] mobile-l is getting quite active these days. this is good for us. thanks for pushing us toward it jdlrobson [17:53:29] +1 to tfinc. yay jdlrobson [18:01:34] (03CR) 10Kaldari: Make "Search in pages" perform a fulltext search (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123135 (owner: 10Kaldari) [18:04:34] YuviPanda: what's the url for this laundry list of things? [18:04:59] dr0ptp4kt: https://trello.com/b/h0B6QYBo/mobile-app-backlog [18:05:03] dr0ptp4kt: http://etherpad.wikimedia.org/p/appQ4planning [18:05:08] dr0ptp4kt: mostly backlog [18:05:35] YuviPanda: thx [18:09:56] jdlrobson: So I have two bugs for you this morning: https://bugzilla.wikimedia.org/show_bug.cgi?id=63408 https://bugzilla.wikimedia.org/show_bug.cgi?id=63426 [18:10:15] -commons was complaining about the typography refresh, what else is new, but I figured they had some good points to make [18:21:06] YuviPanda: i haven't forgotten about crouton. just saying. [18:21:17] YuviPanda: nor alpha build. will ask once people free if file available [18:23:47] (03PS2) 10Jdlrobson: Fix watchlist tabs. Protect from future changes with browser tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122627 [18:24:02] (03CR) 10Jdlrobson: Fix watchlist tabs. Protect from future changes with browser tests. (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122627 (owner: 10Jdlrobson) [18:24:34] (03CR) 10Jdlrobson: "Why does removing useformat=mobile matter? This is surely a good thing as it is not needed (the cookie works in its place)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120938 (owner: 10Jdlrobson) [18:25:44] dr0ptp4kt: :) [18:25:45] dr0ptp4kt: :) [18:26:14] dr0ptp4kt: you should just bring it up, I am remote too :) [18:26:18] dr0ptp4kt: re: pageview [18:27:06] dr0ptp4kt: btw, 'find in page' you can actually implement https://developer.android.com/reference/android/webkit/WebView.html#findAllAsync(java.lang.String) [18:27:42] dr0ptp4kt: and the other 'find' methods [18:28:04] YuviPanda: sweet [18:28:08] lemme add that to the card [18:28:13] dr0ptp4kt: :) [18:29:21] dr0ptp4kt: nope. you need to use history and go back. We decided it is ok for now, I think [18:29:37] YuviPanda: cool, sorry i missed that. a little late and distracted [18:29:46] dr0ptp4kt: yeah it was talked about a long time ago :) [18:41:56] jdlrobson: wait that's Jidanni?! [18:42:34] (03PS1) 10Jdlrobson: Show the correct emptywatchlist image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123368 [18:42:49] YuviPanda: hhhmmm? [18:43:08] jdlrobson: the person who is asking about mobilefrontend, had a URL called jidanni.org. [18:43:20] yes it is [18:43:23] you know him? [18:43:42] Jidanni is an ol' school mediawiki dev / user who popped up now and then with ... interesting comments [18:44:15] and hasn't appeared again in a while [18:44:35] anyway, do ignore :) [18:50:30] jdlrobson, at least he's not complaining that MF works badly in text browsers... and no, it's not a joke! [18:51:11] indeed, that's what I was asking about [18:51:22] MaxSem: different name. [18:51:24] awjr, are we remotes needed at the lunch?:) [18:51:51] MaxSem: no sir [18:52:03] sehr gut [18:52:05] MaxSem: if you want though, we can set up a hangout - up to you [18:52:11] sounds like you dont ;) [18:52:12] nah:) [18:52:26] awjr: hello, sorry forgot to reply to your parsoid/mobile browser test failling. [18:52:50] awjr: the beta cluster Parsoid daemon was refusing to start because of some missing rights. started it up and it is probably fine now [18:53:04] hashar: yeah things appear to be working normally now :) [18:53:06] hashar: thank you! [18:55:08] awjr: and a link worth bookmarking is http://ganglia.wmflabs.org/latest/?r=hour&cs=&ce=&s=by+name&c=deployment-prep&tab=m&vn= [18:55:13] awjr: that is the ganglia view for the beta cluster. [18:55:17] gotta setup nagios as well one day [18:55:48] ahha, thanks haashar [18:56:41] nagios would be useful too; esp since so many teams are relying on some semblance of stability from beta [18:58:48] jdlrobson: Strangely, I can't find a search icon anywhere in MobileFrontend. Should I request one from design or do you know where I could find an existing one? [18:58:55] jgonera: jdlrobson kaldari kaity food is here in r66, and apps convo is just wrapping up [18:59:02] can someone ping moiz? i dont see him in irc [19:02:32] (03PS2) 10Kaldari: Make "Search in pages" perform a fulltext search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123135 [19:03:04] awjr: did someone say 'Yuvi' just as I left/ [19:03:05] ? [19:04:01] YuviPanda: yeah, tomasz was saying that the scheduling the apps meeting in the AM actually had nothing to do with you and everything to do with ensuring that tomasz got first dibs on sandwiches [19:25:01] (03PS1) 10MaxSem: Fix Special:MobileDiff fatal [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123420 [19:38:04] (03PS3) 10Jdlrobson: Make "Search in pages" perform a fulltext search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123135 (owner: 10Kaldari) [19:40:20] (03CR) 10Jdlrobson: [C: 032] Make "Search in pages" perform a fulltext search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123135 (owner: 10Kaldari) [19:40:25] (03Merged) 10jenkins-bot: Make "Search in pages" perform a fulltext search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123135 (owner: 10Kaldari) [19:48:29] (03CR) 10Jdlrobson: [C: 032] "WFM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123420 (owner: 10MaxSem) [19:49:01] (03Merged) 10jenkins-bot: Fix Special:MobileDiff fatal [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123420 (owner: 10MaxSem) [20:00:02] chrismcmalunch: you still at lunch? [20:00:16] hi jdlrobson just got back [20:00:39] chrismcmahon: was keen to work out why these tests do not run for me locally https://bugzilla.wikimedia.org/63090 [20:00:55] am i using an outdated version of mediawiki gem? [20:03:13] jdlrobson: https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1799 [20:05:58] jdlrobson: have you updated your local /MobileFrontend/tests/browser/Gemfile.lock recently? [20:06:13] (03PS9) 10JGonera: Avoid flash of styles when loading tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110649 (owner: 10Jdlrobson) [20:06:44] chrismcmahon: bundle install yeh [20:06:50] chrismcmahon: brb quarter planning [20:06:53] (03CR) 10JGonera: [C: 032] Avoid flash of styles when loading tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110649 (owner: 10Jdlrobson) [20:07:55] (03Merged) 10jenkins-bot: Avoid flash of styles when loading tablets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110649 (owner: 10Jdlrobson) [20:11:58] also chrismcmahon did you see my comment about useformat=mobile on https://gerrit.wikimedia.org/r/120938 [20:12:32] jdlrobson: yeah, I did, I was about to comment, still thinking a little [20:12:43] ok cool [20:12:47] keen to get that wrapped up asap [20:17:32] jdlrobson, got the hangout link? [20:18:39] dr0ptp4kt: mw plannign ? [20:18:54] tfinc: yeah [20:18:55] dr0ptp4kt: https://plus.google.com/hangouts/_/wikimedia.org/mobile-web-q4?hceid=YXJpY2hhcmRzQHdpa2ltZWRpYS5vcmc.79guraeg8ek32qij9m87hfi0uk [20:18:57] (03CR) 10Cmcmahon: "OK by me, I assumed useformat=mobile was there for a reason, and needed to be preserved." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120938 (owner: 10Jdlrobson) [20:18:58] tfinc: thx [20:20:24] (03PS1) 10JGonera: Hygiene: Remove polyfills [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123435 [20:30:54] https://www.mediawiki.org/wiki/Mobile/Release_history#Mobile_Web [20:31:13] (03CR) 10Jdlrobson: "I might be overly paranoid but I think we should remove forEach usage in favour of $.each just to play it safe and be consistent. Should w" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123435 (owner: 10JGonera) [20:32:35] (03CR) 10JGonera: "I was actually wondering about doing the opposite: replacing $.each with .forEach. I'd rather shift towards native APIs when they're fully" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123435 (owner: 10JGonera) [20:36:42] brion: do you have everything you need for the arch meeting @ 2 ? [20:40:24] (03CR) 10Yurik: Set appropriate User Agent string (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123117 (owner: 10Yuvipanda) [21:06:50] (03PS1) 10MaxSem: Fix Special:MobileDiff fatal [extensions/MobileFrontend] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123442 [21:07:45] (03CR) 10MaxSem: [C: 032] Fix Special:MobileDiff fatal [extensions/MobileFrontend] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123442 (owner: 10MaxSem) [21:08:35] (03Merged) 10jenkins-bot: Fix Special:MobileDiff fatal [extensions/MobileFrontend] (wmf/1.23wmf20) - 10https://gerrit.wikimedia.org/r/123442 (owner: 10MaxSem) [21:14:35] zz_yuvipanda: mhurd when am i getting a real icon for the app ? [21:14:52] tfinc: on it :) [21:34:26] MaxSem: are you hearing OK? [21:34:36] awjr, not everything [21:34:43] is it anyone in particular? [21:34:47] kenan is far from the mic [21:36:35] MaxSem: ^ [21:36:49] the room's too large [21:36:55] :( [22:01:40] (03PS1) 10JGonera: Fix phpcs-related scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123458 [22:19:22] (03CR) 10JGonera: [C: 032] Show the correct emptywatchlist image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123368 (owner: 10Jdlrobson) [22:19:55] (03Merged) 10jenkins-bot: Show the correct emptywatchlist image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123368 (owner: 10Jdlrobson) [22:52:35] m0sz: that you moil ? [22:52:37] moiz [22:52:53] https://en.m.wikipedia.org/wiki/Talk:2014_Iquique_earthquake < if you think that's bad try it without the overlay [22:53:14] (compared with clicking talk on https://en.m.wikipedia.org/wiki/2014_Iquique_earthquake) [23:12:02] (03PS1) 10Jdlrobson: EventLog profile and history link clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123474 [23:14:11] (03CR) 10Jdlrobson: [C: 04-1] "Doesn't seem to work for me..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123458 (owner: 10JGonera) [23:15:59] (03CR) 10Jdlrobson: [C: 032] "My concern is consistency" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123435 (owner: 10JGonera) [23:16:42] (03Merged) 10jenkins-bot: Hygiene: Remove polyfills [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123435 (owner: 10JGonera) [23:24:52] (03CR) 10JGonera: "You must have changed something in your PHP setup. Composer is a pretty popular tool right now and I can't see any reports of it throwing " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123458 (owner: 10JGonera) [23:35:28] tfinc: any idea how we can add new components to bugzilla? [23:35:38] jdlrobson: any admin can do it [23:35:44] are you an admin? [23:35:58] jdlrobson: i was in the past. let me see if i can still do it [23:36:27] jdlrobson: yup, it lets me do it [23:36:46] (03CR) 10Jdlrobson: "Kaldari also has a mac, if he doesn't hit the same issue we should +2 a it is probably specific to my machine but I would like us to check" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123458 (owner: 10JGonera) [23:36:56] tfinc: can you add a Hygiene component to MobileFrontend [23:37:05] i think it would be useful to categorize tracking bugs to fix issues with code [23:38:03] jdlrobson: i need a "Component Description:" , "Default Assignee: " , and , Default CC List: [23:38:08] kaldari, can you check https://gerrit.wikimedia.org/r/123458 before you leave? [23:38:28] tfinc: isn't default assignee and cc list inherited? [23:38:46] jdlrobson: no clue. i havent created one of these in years [23:38:56] give me a description and then i'll see what happens if i don't fill it in [23:39:24] Description should be "Use this to raise concerns with code repository" [23:39:49] "Use this to raise concerns with code quality in the repository but which do not cause any problems with functionality" [23:39:59] we can always improve it later [23:40:08] jdlrobson: A default assignee is required for this component. [23:40:13] just add me tfinc :) [23:40:33] "The component Hygiene has been created." :) [23:40:37] Thank you! [23:41:31] oh i just worked what assignee does :)