[01:52:16] hi, is WP Zero off-topic for this channel? [01:52:35] no [01:59:47] (03PS1) 10JGonera: Hygiene: Remove old search overlay CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123505 [02:41:35] (03PS1) 10JGonera: [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 [02:41:59] (03PS2) 10JGonera: [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 [02:42:24] (03CR) 10JGonera: [C: 04-2] "WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [02:42:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [02:43:43] (03PS3) 10JGonera: [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 [02:44:14] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [02:45:16] (03PS4) 10JGonera: [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 [02:52:59] (03CR) 10JGonera: Card 1814 (Story 1747): Notification drawer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120733 (owner: 10Jdlrobson) [02:55:55] (03CR) 10JGonera: [C: 04-1] "Please see my reply in inline comment in patchset 5." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120733 (owner: 10Jdlrobson) [03:01:06] (03CR) 10JGonera: [C: 032] Fix watchlist tabs. Protect from future changes with browser tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122627 (owner: 10Jdlrobson) [03:01:41] (03Merged) 10jenkins-bot: Fix watchlist tabs. Protect from future changes with browser tests. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122627 (owner: 10Jdlrobson) [07:47:38] (03PS1) 10Siebrand: Migrate to JSON i18n [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123533 [12:17:06] (03CR) 10Raimond Spekking: [C: 04-1] "Changes in ZeroRatedMobileAccess.php are missing, arn't they?" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123533 (owner: 10Siebrand) [12:23:53] (03PS2) 10Siebrand: Migrate to JSON i18n [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123533 [12:26:56] (03CR) 10Raimond Spekking: [C: 04-1] "What about the i18n/maintenance/ directory?" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123533 (owner: 10Siebrand) [13:06:06] (03CR) 10Siebrand: "There is no $wgExtensionMessagesFiles entry for it. It's "include"d." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123533 (owner: 10Siebrand) [13:20:23] (03CR) 10Nikerabbit: [C: 04-1] "The shim does not actually fill in $messages, so maintenance/ETLZeroData.php needs to be changed to parse json files." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123533 (owner: 10Siebrand) [13:41:14] aharoni: around ? [13:41:32] matanya: kinda [13:41:50] can you please give me rights on http://he.wikipedia.beta.wmflabs.org/wiki/%D7%A2%D7%9E%D7%95%D7%93_%D7%A8%D7%90%D7%A9%D7%99 [13:42:20] as many as possible would be great, i would like to test stuff before it gets to prod [13:45:15] aharoni: ^ [13:45:38] i'm not sure that I have them myself :0 [13:45:47] or do i? [13:45:54] oh right [13:46:38] matanya: giing [13:46:40] giving [13:46:50] thanks [13:47:43] matanya: RIGHTS : YOU HAZ DEM [13:47:53] YAY :) [13:47:57] thanks again [13:48:47] matanya: if you can important a few hundreds of pages there, it would be nice [13:49:01] s/important/import/ [13:49:18] i planned to [13:49:22] cool [14:32:51] (03CR) 10Siebrand: "I'll remove that conversion and report a bug. I think it may not be used." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123533 (owner: 10Siebrand) [14:35:03] (03PS3) 10Siebrand: Migrate to JSON i18n [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123533 [14:36:13] (03CR) 10Raimond Spekking: [C: 032] Migrate to JSON i18n [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123533 (owner: 10Siebrand) [14:36:31] (03Merged) 10jenkins-bot: Migrate to JSON i18n [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123533 (owner: 10Siebrand) [15:39:55] (03PS1) 10Cmcmahon: QA WIP use API to create page, manage state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123657 [15:41:37] (03PS2) 10Cmcmahon: QA WIP use API to create page, manage state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123657 [15:59:18] (03CR) 10Cmcmahon: [C: 04-1] "Not ready for prime time" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123657 (owner: 10Cmcmahon) [16:26:14] (03PS3) 10Cmcmahon: QA WIP use API to create page, manage state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123657 [17:01:19] (03PS4) 10Cmcmahon: QA WIP use API to create page, manage state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123657 [17:13:10] (03PS5) 10Cmcmahon: QA WIP use API to create page, manage state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123657 [17:19:00] (03PS6) 10Cmcmahon: QA WIP use API to create page, manage state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123657 [17:19:33] (03Abandoned) 10Cmcmahon: QA: set correct watchlist state before clicking watchlist icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123339 (owner: 10Cmcmahon) [17:21:00] (03PS7) 10Cmcmahon: QA WIP use API to create page, manage state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123657 [17:24:38] (03PS8) 10Cmcmahon: QA WIP use API to create page, manage state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123657 [17:30:37] brion: https://developer.apple.com/wwdc/tickets/ [17:30:40] do let monte know too [17:30:56] its a random lottery this year [17:32:55] lotteries all around this year eh? [17:34:32] yup [17:35:04] that reminds me they’ve been announcing things from microsoft’s Build conference [17:35:10] windows phone 8.1 will have virtual assistant “Cortana” :D [17:35:18] mhurd: https://developer.apple.com/wwdc/tickets/ [17:35:33] brion: yes. just like the halo franchise [17:35:56] i just hope WP8.1 phones won’t suffer from rampancy when they get too old [17:36:20] tfinc: done! [17:43:29] (03PS1) 10Awjrichards: Ensure checkToggleView() fires at appropriate time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123678 [17:44:30] MaxSem: would you mind dbl checking ^^? that bug is so dumb and annoying but considering my last two attempts to fix it have been reverted, im keen to get some extra-thorough eyes on it ;) [17:44:45] :) [17:45:04] (03CR) 10Brion VIBBER: "On further investigation I think this is actually safe; it was crashing on something else and I mistook the error message. Will kill this " [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122545 (owner: 10Brion VIBBER) [17:45:26] (03PS1) 10Cmcmahon: QA WIP use API to create page, manage state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 [17:45:49] (03Abandoned) 10Cmcmahon: QA WIP use API to create page, manage state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123657 (owner: 10Cmcmahon) [17:47:16] (03CR) 10MaxSem: [C: 04-1] Ensure checkToggleView() fires at appropriate time (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123678 (owner: 10Awjrichards) [17:47:47] (03PS2) 10Brion VIBBER: [Gingerbread] Get more things using the support version of the action bar accessors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122607 [17:47:49] (03PS2) 10Brion VIBBER: [Gingerbread] work around another attr [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122606 [17:47:51] (03PS2) 10Brion VIBBER: [Gingerbread] Partial animations fixes using NineOldAndroids [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122590 [17:47:53] (03PS2) 10Brion VIBBER: [Gingerbread] Don't crash on setting zoom controls [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122591 [17:47:55] (03PS5) 10Brion VIBBER: [Gingerbread] Can't use ?attr/selectableItemBackground until v11 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122546 [17:47:57] (03PS4) 10Brion VIBBER: [Gingerbread] Work around lack of ColorDrawable.getColor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122547 [17:47:59] (03PS5) 10Brion VIBBER: [Gingerbread] Workaround for SaneAsyncTask: copy AsyncTask from KitKat [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122548 [17:48:01] (03PS2) 10Brion VIBBER: [Gingerbread] Quick hack around more missing attrs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122592 [17:48:22] (03Abandoned) 10Brion VIBBER: [Gingerbread] Fix explosion on calling static WebView method [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122545 (owner: 10Brion VIBBER) [17:54:54] (03PS16) 10Dr0ptp4kt: SpecialMobileWebApp: Get the startup module caching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [17:56:06] chrismcmahon, do we have any nearby tests on betalabs? [17:56:48] m0sz: what should be the max width of the notification drawer so I can wrap this patch up? [17:58:17] jdlrobson, would you please + 2 https://gerrit.wikimedia.org/r/111485 ? i removed the "wip" part from it. it now has more urls in the appcache manifest, and offline mode functions the same as in your earlier ps of it (i.e., half works). [17:58:59] dr0ptp4kt: already dropped my -2 and already looking [17:59:03] (03PS2) 10Awjrichards: Ensure checkToggleView() fires at appropriate time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123678 [17:59:05] but it will be blocked on the other patch [17:59:11] (https://gerrit.wikimedia.org/r/#/c/119938/4) [17:59:35] seem to be having issues with git at moment though and can't pull the code down [17:59:51] MaxSem: we have this: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/tests/browser/features/geonotahack.feature [18:00:13] chrismcmahon: this doesn't test nearby itself though [18:00:33] we did have tests but they rely on spoofing the geolocation. They got abandoned .. :( [18:01:58] jdlrobson / jgonera: hashar helped me configure jenkins to lint limn-mobile-data [18:02:11] so it'll -1 you unless flake8 passes [18:02:14] milimetric: sweet! thanks a lot! :D [18:02:15] jdlrobson: lemme know if you need anything [18:02:28] and you don't have to V +2 anymore, just C +2 and merge [18:02:33] dr0ptp4kt: you can review https://gerrit.wikimedia.org/r/#/c/119938/4) :) [18:02:34] (assuming it passes) [18:03:21] So dr0ptp4kt I'm still hit by this caching problem with the timestamp changing - Application Cache Error event: Manifest changed during update, scheduling retry [18:03:33] is there anything we can do about that? [18:03:48] we should at least add a FIXME pointing to that bug [18:03:55] as now i cannot test the cache manifest locally at all [18:06:37] jdlrobson: i don't seem to be getting that error [18:06:45] dr0ptp4kt: that [18:06:53] that's be causing your caching layer avoids it [18:07:01] jdlrobson: but i agree a fixme for further review makes sense [18:07:14] dr0ptp4kt: trying to find that bug you raised [18:07:19] about the startup url [18:08:08] jdlrobson: add the following into the comments, perhaps. here's my cache config: [18:08:24] / $wgMainCacheType = CACHE_MEMCACHED; $wgMainCacheType = 'memcached-pecl'; wgMemCachedServers = array( "127.0.0.1:11211" ); [18:09:31] jdlrobson: the bug is https://bugzilla.wikimedia.org/show_bug.cgi?id=59623 [18:09:47] not sure where the other bugs that timo may have filed are [18:10:02] dr0ptp4kt: could we stop the app loading when this is set? [18:10:10] rather is not set [18:11:05] dr0ptp4kt: it seems i was set to $wgMainCacheType = CACHE_MEMCACHED; [18:12:27] (03PS17) 10Jdlrobson: SpecialMobileWebApp: Get the startup module caching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 [18:12:34] (03CR) 10Jdlrobson: [C: 032] SpecialMobileWebApp: Get the startup module caching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [18:12:50] jdlrobson: i don't know what to think about checking the value. i doubt memcached-pecl would go away for production anytime soon, so it' sprobably safe to check for the desired value. [18:13:04] dr0ptp4kt: true. I noted in commit and +2ed [18:13:10] (and if not present, redirect or don't use a cache manifest anyway) [18:13:15] can you review the prior pathset? [18:14:00] jdlrobson: yep, will do. by induction i know it's okay, but i will look. [18:14:22] jdlrobson: uno momento [18:14:37] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove old search overlay CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123505 (owner: 10JGonera) [18:14:38] (i actually tested that previously, so i'm pretty sure it works, so i'll try again) [18:16:04] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Remove old search overlay CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123505 (owner: 10JGonera) [18:19:53] jdlrobson: i retested. ok for me to +2 https://gerrit.wikimedia.org/r/#/c/119938/4 ? [18:31:56] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123505 (owner: 10JGonera) [18:36:48] (03CR) 10Jdlrobson: Hygiene: Remove old search overlay CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123505 (owner: 10JGonera) [18:36:53] (03CR) 10Jdlrobson: [C: 032] Hygiene: Remove old search overlay CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123505 (owner: 10JGonera) [18:37:27] (03Merged) 10jenkins-bot: Hygiene: Remove old search overlay CSS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123505 (owner: 10JGonera) [18:39:34] (03CR) 10Jdlrobson: [C: 031] "Seems to work. Will let MaxSem throw down the +2 hammer." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123678 (owner: 10Awjrichards) [18:40:57] (03CR) 10Jdlrobson: [C: 04-1] "Marking as -1 whilst a WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [18:41:28] dr0ptp4kt: fine for you to +2 [18:41:45] reverts are cheap :) [18:41:55] (unless they are on a wed afternoon ;-)) [18:42:52] jdlrobson: ha! ok, one minute [18:43:14] (03CR) 10Dr0ptp4kt: [C: 032] SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119938 (owner: 10Jdlrobson) [18:43:34] jdlrobson: if you'll add your +1 to https://gerrit.wikimedia.org/r/#/c/111485/ i'll add my +2 [18:43:55] (03Merged) 10jenkins-bot: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119938 (owner: 10Jdlrobson) [18:44:09] (03Merged) 10jenkins-bot: SpecialMobileWebApp: Get the startup module caching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 (owner: 10Jdlrobson) [18:44:17] sweet [18:44:25] mobile tshirts? I vote for 4 honey badgers of Apocalypse armed with smartphones [18:45:33] heh [18:58:07] MaxSem: I vote for a mobile phone with a superman style cape riding a toilet seat in space with the earth in the background with the tagline "Wikipedia anywhere" [18:58:24] violetto would do a kick ass job of drawing one i'm sure [18:58:41] jdlrobson: why toilet seat? [18:58:44] jdlrobson: and it clearly should be batman [18:58:45] awjr: is m0sz in the office? [18:58:53] YuviPanda: i use my mobile phone on the toilet all the time [18:59:22] i'll draw something only if it's terribly wild [18:59:26] jdlrobson: while on space? :P [18:59:30] http://www.nydailynews.com/life-style/eww-people-mobile-phones-toilet-article-1.1282088 [18:59:40] YuviPanda: this is the ambition [18:59:41] jdlrobson: yeah, it's not wild enough. where are the sharks and the jellyfish and the other things [18:59:50] ooohh how about hitchhikers guide reference?! [19:00:17] yeah, THAT WILL BE FUCKING COOL [19:00:18] ish [19:00:21] jdlrobson: i havent read the book [19:00:24] (03CR) 10MaxSem: [C: 032] Ensure checkToggleView() fires at appropriate time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123678 (owner: 10Awjrichards) [19:00:28] YuviPanda: lol to the ish [19:00:30] jdlrobson: we need to fix that for violetto [19:00:58] (03Merged) 10jenkins-bot: Ensure checkToggleView() fires at appropriate time [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123678 (owner: 10Awjrichards) [19:00:59] YuviPanda: you guys making me a movie of the book? [19:01:03] cus i'll watch a movie [19:01:16] violetto: there is a movie but please please do not watch it [19:01:30] YuviPanda: haha [19:01:55] YuviPanda: but it has the hobbit in it [19:08:21] name check in metrics meeting whoop woop [19:09:16] ooh and mingle got a typography refresh haha [19:13:41] (03PS6) 10Brion VIBBER: [Gingerbread] Can't use ?attr/selectableItemBackground until v11 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122546 [19:14:01] (03PS5) 10Brion VIBBER: [Gingerbread] Work around lack of ColorDrawable.getColor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122547 [19:14:07] (03PS6) 10Brion VIBBER: [Gingerbread] Workaround for SaneAsyncTask: copy AsyncTask from KitKat [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122548 [19:14:11] (03PS3) 10Brion VIBBER: [Gingerbread] Partial animations fixes using NineOldAndroids [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122590 [19:14:15] (03PS3) 10Brion VIBBER: [Gingerbread] Don't crash on setting zoom controls [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122591 [19:33:41] tfinc: brion hangout being crashy again, retrying [19:34:11] whee [19:42:47] (03PS3) 10Brion VIBBER: [Gingerbread] Quick hack around more missing attrs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122592 [19:45:46] violetto: it'll be really cool if I can build something like codepen.io but it lets you customize your wiki experience and also let you share it with others [19:45:49] just code and css [19:45:57] YuviPanda: WHOA [19:45:59] yesh [19:46:05] violetto: yeah, so you can just prototype stuff yourself. [19:46:14] YuviPanda: yes yes [19:46:57] violetto: maybe one of the hackathon things ;) [19:47:07] YuviPanda: making this happen [19:47:18] violetto: do a design? :D [19:47:29] YuviPanda: heck yea [19:48:56] (03PS4) 10Brion VIBBER: [Gingerbread] Quick hack around more missing attrs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122592 [19:50:04] (03PS3) 10Brion VIBBER: [Gingerbread] work around another attr [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122606 [19:52:46] dr0ptp4kt: Bugs about what? [20:00:14] (03PS4) 10Brion VIBBER: [Gingerbread] work around another attr [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122606 [20:00:30] (03PS3) 10Brion VIBBER: [Gingerbread] Get more things using the support version of the action bar accessors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122607 [20:04:24] tfinc: can the room see me on a screen? [20:21:42] Krinkle, huh? [20:32:57] (03PS1) 10Brion VIBBER: [Gingerbread] Partial fixes for 'saved pages' view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123785 [20:39:45] brb lunch [20:40:32] violetto: don't take the 'kick' personally :) [20:44:21] hi mhurd [20:45:22] so I was talking to violetto, we were thinking of replacing the design meetings with just filing bugs on bugzilla. This gives us a few advantages: 1. It gets brought to trello automatically, 2. That is where volunteer testers put their bugs so no duplication 3. We have volunteer help (and our bugmaster andre__) to help us triage it 4. It makes it easy and useful to reference them from Gerrit commit messages [20:45:34] 5. Other people who want to contribute to the apps can also take it in [20:45:36] mhurd: thoughts? [20:46:01] YuviPanda: that sounds solid [20:46:10] violetto: ^ sweet [20:50:07] YuviPanda: mhurd however, it'll be nice to keep record of screen progress and for people who doesn't have the app, can we also try to upload the screens up on trello? other suggestions? [20:50:47] violetto: I don't think the interaction is clear enough from screenshots, plus I don't want to do the extra work (1. take screenshot, 2. Upload to dropbox, 3. Download from dropbox on laptop 4. Find card on trello 5. Upload on trello) [20:50:50] mhurd: ^ [20:51:23] YuviPanda: violetto: can still use the design board for posting screenshots if we want. no worry either way. [20:51:40] YuviPanda: mhurd we can try and see how that works out [20:51:53] mhurd: violetto you know you can upload images to bugzilla too, right? [20:51:59] YuviPanda: mhurd my worry is that people watching the convo might not know what we're referring to [20:52:01] 'add attachment' [20:52:10] so when filing bugs, add screenshot there? [20:52:15] YuviPanda: violetto: can still discuss stuff about the designs there too. that and the bugzilla don’t have to be mutually exclusive i think [20:52:32] mhurd: violetto indeed. But having it originate in BZ is good, I think. [20:52:43] YuviPanda: mhurd doesn't sound too bad of an idea [20:52:55] violetto: mhurd so, 1. put on bugzilla, 2. use bz attachments for screenshots [20:52:55] ? [20:53:00] YuviPanda: mhurd lets just see how this works out [20:53:02] screenshots of bugs I mean [20:53:06] yep yep [20:53:09] violetto: valid concern. can even put trello links in bugzilla reports if we want. [20:53:21] YuviPanda: can do that too [20:53:21] violetto: mhurd if we do that, then we do not have a separate process for 'in team' and 'in community' [20:53:27] it is all just 'put it on bugzilla' [20:53:38] YuviPanda: mhurd that all sounds good [20:53:42] violetto: mhurd I think that'll be massively useful to have a 'unified process' once the release hits [20:53:44] YuviPanda: sure, but trello is not exclusively in team is it? [20:54:08] mhurd: it's not but probably not so visible to them, i guess [20:54:11] mhurd: it isn't, but our community is in bugzilla :) Trello is *great* for organizing stuff, and scheduling our work and stuff, but it's not a bug reporter [20:54:18] since BZ is more commonly used [20:54:53] yeah [20:55:21] YuviPanda: as long as we’re free to put a trello link in a bz report i see no big worries. not saying that will happen all the time, but it may [20:55:21] YuviPanda: mhurd, we can try this: report everything to bugzilla with screenshots and they will get fetched into trello [20:55:21] they already do, so I guess we're good there (Bugello!!!) [20:55:23] YuviPanda: mhurd and put trello link to BZ [20:55:34] violetto: yeah i’d rather the trello design board not be a target for the bugello firehose [20:55:40] :) [20:56:21] mhurd: violetto yeah, let's start doing that and see what happens [20:56:21] mhurd: violetto if you've noticed, all of the design / bugs from tfinc, ragesoss and other folks already come in to bugzilla [20:56:21] we should just be filing bugs there and go from there. [20:56:41] YuviPanda: mhurd the interface is crappy and all but i'll stick in there. ;P [20:56:43] YuviPanda: ya, just saying i’d rather bugello not dump thing into the design board specifically [20:56:50] mhurd: oh agreed. [20:56:53] cool [20:56:54] :) [20:56:55] violetto: :) [20:57:08] YuviPanda: mhurd nice! [20:57:21] we'll try this for 2 sprints and see how this works [20:57:24] violetto: mhurd I'll mail out to mobile-tech with this since this is about cancelling a meeting. [20:57:26] we can iterate after that [20:57:35] and the bugzilla workflow is already what people outside the team use [20:57:39] just like what happened to the refinement meeting [20:58:22] yeah [21:08:38] (03PS1) 10Brion VIBBER: [Gingerbread] Fix extra action bar on 2.3 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123787 [21:19:01] YuviPanda: any idea why these customized attrs don’t seem to be working for me? https://gerrit.wikimedia.org/r/#/c/122606/ [21:20:21] (03PS2) 10Cmcmahon: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 [21:20:51] brion: looking [21:22:07] (03PS1) 10Dr0ptp4kt: Turn Wikipedia Zero toasts to croutons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 [21:23:58] brion: not sure. I never quite understood how attrs work ;) [21:24:06] hehe [21:26:04] brion: I think you need an attrs.xml file for it [21:26:06] or somesuch [21:26:14] hmmmm [21:26:17] brion: but for selectors there's a selector thing, you should just be able to copy the original thing or whatever? [21:26:42] YuviPanda: oh yeah i’m copying the original drawables/colors over [21:26:45] the question is making it work :D [21:26:51] brion: heh :D [21:27:21] brion: it just doesn't show up? [21:27:21] if i can’t get the redirected attr to work i’ll use them directly [21:27:21] it crashes inflating the layouts [21:27:21] brion: oh. [21:27:21] Caused by: android.content.res.Resources$NotFoundException: Resource is not a Drawable (color or path): TypedValue{t=0x2/d=0x7f01006a a=-1} [21:27:21] brion: I'm ok with using it directly [21:27:32] brion: since we can have them in values-v11 or whatever [21:27:33] YuviPanda: would you mind reviewing and +2'ing https://gerrit.wikimedia.org/r/#/c/123788/ ? [21:28:21] pretty please [21:28:21] with buttor and sugar and cinnamon on top [21:28:21] dr0ptp4kt: where does the crouton show? it should currently just show at top of activity, I think [21:28:27] dr0ptp4kt: shouldn't we show it right below search bar? [21:28:59] YuviPanda: it could. hang on [21:29:07] dr0ptp4kt: I think by default it attaches to top of activity. You can specify another view and have it attach to the bottom of that. [21:30:41] mhurd: violetto tfinc emailed about design refinements meeting [21:31:58] YuviPanda: thank you [21:32:05] violetto: :D :D [21:32:32] brion: so I'm thinking of adding a 'polyfills.js' and making a bundle of polyfills for older androids and have those be included only in 2.3. Thoughts? [21:32:54] YuviPanda: sounds reasonable [21:33:18] brion: in that case can we merge the outstanding patches now? :D I'd rather not do that work with these patches. [21:33:28] brion: I'm working on the polyfill now [21:33:42] i’m working on a stack of patches, so not ready to code review a different stack of patches just yet [21:34:12] brion: ah, yeah. That's ok :) Just wanted to unblock CR on polyfills - so you can do them with the expectation there'll be a different polyfill commit rather than have those committed [21:34:20] should have the polyfill thing done in 30 mins or so [21:34:24] ok [21:34:38] brion: ty! [21:35:15] violetto: brion mhurd looking forward to discussion of 3week iterations :) [21:40:30] YuviPanda: yep [21:43:58] (03PS4) 10Brion VIBBER: [Gingerbread] Get more things using the support version of the action bar accessors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122607 [21:44:00] (03PS4) 10Brion VIBBER: [Gingerbread] Partial animations fixes using NineOldAndroids [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122590 [21:44:02] (03PS4) 10Brion VIBBER: [Gingerbread] Don't crash on setting zoom controls [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122591 [21:44:04] (03PS2) 10Brion VIBBER: [Gingerbread] Partial fixes for 'saved pages' view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123785 [21:44:04] wheeeee [21:44:06] (03PS6) 10Brion VIBBER: [Gingerbread] Work around lack of ColorDrawable.getColor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122547 [21:44:08] (03PS2) 10Brion VIBBER: [Gingerbread] Copy some theme attributes directly that aren't available on v10 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123787 [21:44:10] (03PS7) 10Brion VIBBER: [Gingerbread] Workaround for SaneAsyncTask: copy AsyncTask from KitKat [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122548 [21:44:17] brion: sooo many patches :D [21:44:33] YuviPanda: those should be reasonably stable now :D [21:44:55] brion: dr0ptp4kt mhurd unrelated, but *Microsoft* might end up open sourcing Xamarin's OSS .NET for Mobile thing (https://pbs.twimg.com/media/BkT9oBcCQAAHIAV.jpg:large) so that means we can write cross platform (iOS, Android!) apps with C# [21:45:02] nothing for now, but definitely keep in mind [21:45:07] (03Abandoned) 10Brion VIBBER: [Gingerbread] work around another attr [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122606 (owner: 10Brion VIBBER) [21:45:18] (03Abandoned) 10Brion VIBBER: [Gingerbread] Quick hack around more missing attrs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122592 (owner: 10Brion VIBBER) [21:45:25] YuviPanda: hehe it’s a trap! [21:45:26] (03Abandoned) 10Brion VIBBER: [Gingerbread] Can't use ?attr/selectableItemBackground until v11 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122546 (owner: 10Brion VIBBER) [21:45:34] YuviPanda: heh nice [21:45:47] course on the downsid eyou gotta use C# or something else that compiles to .net CLR :D [21:45:59] brion: C# is a million times nicer than Java ;) [21:46:07] it's up there in my 2 or 3 most fav langauges ever [21:46:10] true it has a lot of niceties [21:46:12] brion: especially since C# 3.0 [21:46:14] LAMBDAS! [21:46:15] LINQ! [21:46:17] lambdas :DDDDD [21:46:18] yeah c# is pretty nice [21:46:19] MACROS [21:46:19] ish [21:46:25] YuviPanda: no lambdas in java?? [21:46:42] mhurd: nope. We've shitty 'inner anonymous classes' which are, shitty. [21:46:49] doh! [21:47:06] mhurd: Java is a pretty shitty language. I write ops code (in puppet!) as relief because puppet, no matter how terrible it is, can't be more terrible than Java ;) [21:47:15] oh man [21:47:40] mhurd: Java 8 has lambdas I think, but Goog can't move to it because Oracle is a dick [21:47:57] lol [21:48:00] mhurd: but they are rewriting the underlying VM anyway, I hopefully will see major changes in the next I/O [21:48:16] ooh yeah the llvm stuff? [21:48:26] mhurd: ya [21:48:42] woohoo! [22:00:38] MaxSem: heads up we are running a little late [22:00:41] meeting before us is overruning [22:01:27] (03CR) 10Jdlrobson: [C: 04-1] "Creating pages for watchlist tests seems like an unnecessary step. This also means we can't run these tests on English Wikipedia (they are" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [22:02:18] plus MaxSem please +2 this - https://gerrit.wikimedia.org/r/#/c/122869/ - our team is so slow at code review that +1's are never that useful unless you explicitly poke someone. If there is something you are worried about i urge you to poke awjr_away or jgonera explicitly so this doesn't just sit there [22:02:32] (03CR) 10MaxSem: [C: 032] Hygiene: Kill mobile.styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122869 (owner: 10Jdlrobson) [22:02:36] i had hoped this would make the deployment train today but now it hasn't :( [22:02:49] thanks maxy [22:03:36] (03Merged) 10jenkins-bot: Hygiene: Kill mobile.styles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122869 (owner: 10Jdlrobson) [22:05:50] (03PS3) 10Cmcmahon: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 [22:05:53] MaxSem: did you want to join the prioritization meeting? [22:10:06] (03CR) 10Cmcmahon: "Jon, we can do anything you want, but this is a good solution that eliminates the flakyness now and that will last into the future as we r" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [22:18:23] kaity: create a story for it:) [22:18:32] i created a bugzilla [22:18:40] but you said it was resolved? [22:19:55] jdlrobson: [22:20:19] kaity: for hiding the upload button? [22:20:26] yea [22:21:28] https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1903 < kaity [22:21:39] oh i just saw you did one too hhehe [22:21:58] couldn't take it anymore MaxSem? [22:22:21] remote meetings suck:P [22:22:48] jdlrobson: oops! thanks, yours is better [22:23:25] https://etherpad.wikimedia.org/p/MobileWeb-Q4-Planning [22:36:04] mhurd, YuviPanda, MaxSem what are the standard image sizes we should be using when requesting images? [22:36:14] good question :) [22:36:33] hehe yeah [22:36:42] jgonera: I think MaxSem would know [22:36:45] let me see if I can find out [22:36:47] 50 or 120 IMO [22:37:00] (from a perf POV) [22:37:03] MaxSem, but not for thumbnails [22:37:14] jgonera: i hear you're looking for me [22:37:18] I want to standardize the sizes that the current media viewer on mobile uses [22:37:26] for thumbnails? whatever it is in wikitext [22:37:29] marktraceur, you might know? ^ [22:37:46] Uhhhh [22:37:57] for fullscreen viewing it's trickier [22:38:02] jgonera: They're defined somewhere in MMV IIRC [22:38:15] resources/mmv/mmv.ThumbnailWidthCalculator.js [22:38:35] There are 8 widths there [22:39:10] marktraceur, awesome, thanks. that's something that you agreed on with ops? [22:39:37] "agreed" is a strong term [22:39:50] I can haz this shared? [22:39:52] jgonera: We sort of just did it, I don't know if anyone talked to ops about it [22:40:12] these sizes look sane [22:40:20] brion weighed in though [22:40:36] the smaller ones are covered by standard thumb sizes [22:40:57] the larger ones... someone would've eventually needed larger thumbs [22:46:20] (03PS1) 10Yuvipanda: Add classList polyfill [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123798 [22:46:32] aww, no brion [22:53:36] (03CR) 10Jdlrobson: [C: 04-1] "Code looks fine, although I worry about not testing this anymore on english wikipedia. That aside doesn't work for me locally.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [22:56:55] anyone willing to pull the trigger on this one ---> https://gerrit.wikimedia.org/r/123118 [23:01:49] (03CR) 10Cmcmahon: "Did you do the 'bundle' and/or 'bundle install' dance?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [23:04:07] MaxSem: the train has left, right? ;) [23:04:29] MaxSem: there you go [23:04:58] MaxSem: so I guess I can use it to get page images + search, but then it'll be slow so I''ll probably not do it :) [23:05:10] YuviPanda, thanks! And if needed I can deploy this OOB;) [23:05:15] slow? why? [23:05:16] MaxSem: no, let's not :D [23:05:25] MaxSem: well, it's more work than just returning the results, no? [23:06:47] well, it's as fast as opensearch by itself [23:07:21] of course, by combining it with other query modules the resulting request will be slower [23:07:32] but stil it's muuuuch better than 3 requests [23:11:27] (03CR) 10Jdlrobson: [C: 04-1] "Looks like Chris doesn't like this approach so marking as -1 until he decides." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120938 (owner: 10Jdlrobson) [23:11:54] MaxSem: yeah, true, but i'd rather have search results return super fast and then have images turn up slower [23:12:23]