[00:05:30] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Set appropriate User Agent string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123117 (owner: 10Yuvipanda) [00:08:31] (03PS7) 10Jdlrobson: Card 1814 (Story 1747): Notification drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120733 [00:08:33] (03PS1) 10Jdlrobson: Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 [00:08:52] (03CR) 10Jdlrobson: Card 1814 (Story 1747): Notification drawer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120733 (owner: 10Jdlrobson) [00:09:14] (03CR) 10Jdlrobson: "As Moiz mentioned, there should be max-width on the notifications: Done. We might tweak this some more later though." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120733 (owner: 10Jdlrobson) [00:10:25] jdlrobson, do you know why .listThumb in pagelist.less is in global scope? [00:12:48] jgonera: not sure. I imagine previously it was used in something other than a pageList but not sure what the current system is in [00:13:20] worth using git blame if you are not sure to piece together some clues [00:34:17] (03PS1) 10MaxSem: Don't request page images separately for search results [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123811 [00:55:53] (03PS5) 10JGonera: [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 [00:57:13] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [01:02:01] (03PS6) 10JGonera: [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 [01:02:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [01:48:26] (03CR) 10Jdlrobson: [C: 032] "Yeyyy Max is a frontend dev now :D" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123811 (owner: 10MaxSem) [01:49:02] (03Merged) 10jenkins-bot: Don't request page images separately for search results [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123811 (owner: 10MaxSem) [10:24:06] (03CR) 10Brion VIBBER: [C: 04-1] "Hebrew locale, English article. Inspector shows:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122560 (owner: 10Yuvipanda) [10:27:20] (03CR) 10Brion VIBBER: Make license footer display with UI lang directionality (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122560 (owner: 10Yuvipanda) [10:42:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] Set text direction of edit summary field for RTL languages properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122576 (owner: 10Yuvipanda) [10:51:30] (03CR) 10Brion VIBBER: [C: 04-1] "Has no visible effect on a Hebrew page on Nexus 5 / 4.4. Perhaps the gravity on the StyledTextEdit overrides the text direction here?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122578 (owner: 10Yuvipanda) [10:54:07] (03CR) 10Brion VIBBER: [C: 032 V: 032] Position edit icon appropriately in RTL pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122580 (owner: 10Yuvipanda) [10:56:00] (03CR) 10Brion VIBBER: [C: 04-1] "Was this supposed to also add the output files? They are missing." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122872 (owner: 10Yuvipanda) [11:01:43] brion, are you on Ori time now?:P [11:04:08] hehe [11:04:21] i dunno i slept a while and had a hankering for code review when i woke up ;) [14:24:52] (03PS2) 10Yuvipanda: Make convert-icons produce flipped versions of images too [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122872 [14:24:54] (03PS4) 10Yuvipanda: Add classList polyfill [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123798 [14:24:56] (03PS3) 10Yuvipanda: Position edit icon appropriately in RTL pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122580 [14:24:58] (03PS4) 10Yuvipanda: Set text direction of edit summary field for RTL languages properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122576 [14:25:00] (03PS5) 10Yuvipanda: Make license footer display with UI lang directionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122560 [14:25:02] (03PS4) 10Yuvipanda: Set edit text box's directionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122578 [15:02:50] (03PS4) 10Cmcmahon: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 [15:11:14] (03PS5) 10Cmcmahon: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 [15:12:31] (03PS6) 10Cmcmahon: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 [15:17:14] (03CR) 10Zfilipin: [C: 031] "Looks good to me!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [15:28:53] (03CR) 10Jdlrobson: [C: 04-1] "Please add a note in the README about the user needing to set up MEDIAWIKI_API_URL" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [15:30:56] (03CR) 10Jdlrobson: "(note if a user creates a page that page automatically gets added to their watchlist)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [16:33:22] hey chrismcmahon let me know if you need to talk about the above! :) [16:33:43] we probably need to make sure the page gets removed from the watch list beforehand or switch the order of the tests [16:34:51] crontab -e [16:34:56] whoops wrong window ;-) [16:35:35] jdlrobson: yeah, I updated the prefs for Selenium_user to not watch created pages automatically. (I was kind of surprised that pages created via the API would follow that rule, but that's what happened) [16:35:52] yep mediawiki is a weird beast [16:36:03] once that passes I'm happy to merge :) [16:36:20] OK [17:14:48] brb [17:17:23] brion: waiting on you on the hangout [17:30:54] (03Abandoned) 10Jdlrobson: QA: Increase timeouts for asynchronous steps [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/119557 (owner: 10Jdlrobson) [17:47:04] (03PS1) 10MaxSem: Use core message instead of mobile-frontend-privacy-link-text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123886 [17:52:36] (03PS1) 10MaxSem: Fix outdated $wgMFCustomLogos comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123888 [18:02:58] brion: kenanwang: waiting on you guys on the hangout [18:03:32] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. It's not encouraged to re-use messages across products. It's been proven this can bite you in the ass (for example whe" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123886 (owner: 10MaxSem) [18:03:40] be right there [18:03:52] Coming up stairs flyingclimber [18:03:53] were also getting a late start as yuvi is dleayed [18:05:16] (03PS7) 10Cmcmahon: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 [18:07:47] (03PS1) 10MaxSem: Refactor site notice handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123893 [18:09:20] (03CR) 10MaxSem: "In this particular case, we _want_ to reuse." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123886 (owner: 10MaxSem) [18:23:27] brion: are you in the office today? [18:23:32] no [18:23:37] brion: ah ok [18:25:39] (03CR) 10Siebrand: "Yes, Max. I hear you." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123886 (owner: 10MaxSem) [18:30:55] (03PS1) 10Dr0ptp4kt: Get rid of old ETL script. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123894 [18:31:18] (03CR) 10Dr0ptp4kt: [C: 032] Get rid of old ETL script. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123894 (owner: 10Dr0ptp4kt) [18:48:27] (03CR) 10Siebrand: [C: 04-1] "This should mention bug 63513 in the summary, and I think the i18n.php file that is present in the maintenance folder is now unused, and c" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123894 (owner: 10Dr0ptp4kt) [18:48:43] (03PS2) 10Siebrand: Get rid of old ETL script. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123894 (owner: 10Dr0ptp4kt) [18:49:06] (03CR) 10Siebrand: [C: 04-1] "Per comment on PS1." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123894 (owner: 10Dr0ptp4kt) [18:51:08] (03CR) 10Yuvipanda: Set appropriate User Agent string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123117 (owner: 10Yuvipanda) [18:55:56] (03PS7) 10JGonera: [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 [18:56:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [18:58:45] (03PS8) 10JGonera: [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 [19:18:15] (03PS1) 10JGonera: Use predefined sizes for images in media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123900 [19:34:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [19:35:48] (03CR) 10jenkins-bot: [V: 04-1] Use predefined sizes for images in media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123900 (owner: 10JGonera) [19:43:23] (03PS2) 10Jdlrobson: Fix phpcs-related scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123458 (owner: 10JGonera) [19:43:45] (03PS3) 10Jdlrobson: Fix phpcs-related scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123458 (owner: 10JGonera) [19:43:56] (03PS4) 10Jdlrobson: Fix phpcs-related scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123458 (owner: 10JGonera) [19:44:03] (03CR) 10Jdlrobson: [C: 032] Fix phpcs-related scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123458 (owner: 10JGonera) [19:48:25] (03CR) 10Jdlrobson: [C: 04-1] Fix outdated $wgMFCustomLogos comment (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123888 (owner: 10MaxSem) [19:48:50] (03PS2) 10Dr0ptp4kt: Turn Wikipedia Zero toasts to croutons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 [19:50:56] (03Merged) 10jenkins-bot: Fix phpcs-related scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123458 (owner: 10JGonera) [19:55:56] (03CR) 10Jdlrobson: [C: 032] Refactor site notice handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123893 (owner: 10MaxSem) [19:57:55] (03CR) 10jenkins-bot: [V: 04-1] Refactor site notice handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123893 (owner: 10MaxSem) [19:59:19] eh, what is it complaining about? [19:59:32] (03PS3) 10Dr0ptp4kt: Turn Wikipedia Zero toasts to croutons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 [20:00:19] YuviPanda: i had problems getting it to deterministically go below the search bar from searching & random & browsing context. so i'd like to compromise with ^, which makes the crouton bigger and the text bigger [20:00:27] gotta run [20:00:45] chrismcmalunch: still an issue with your patch set :( [20:01:41] (03CR) 10MaxSem: [C: 032] "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123893 (owner: 10MaxSem) [20:02:13] (03Merged) 10jenkins-bot: Refactor site notice handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123893 (owner: 10MaxSem) [20:02:23] aha:) [20:06:44] (03CR) 10Jdlrobson: [C: 04-1] "Still failing for me.." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [20:09:05] (03PS8) 10Cmcmahon: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 [20:09:18] chrismcmahon: idd you see my comments? [20:09:32] jdlrobson: I just now updated the README [20:09:50] chrismcmahon: i just posted some more comments.. not sure if your README comment addresses those [20:10:18] (03CR) 10Jdlrobson: [C: 04-1] "Also see earlier patchset comments" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [20:10:26] nope doesn't - there are a few more issues with it [20:10:34] happy to talk about them now to get them resolved [20:11:27] jdlrobson: you mean "a(:watch_link, css: "#ca-watch a")" ? I found that there, pretty sure I didn't write it. We can change it if you'd prefer. [20:11:46] (03CR) 10Jdlrobson: [C: 04-1] "QUnit test would be useful for this." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123900 (owner: 10JGonera) [20:12:05] chrismcmahon: yeh we should be more specific - when i run the test it clicks it too quickly [20:12:17] which takes the user to the page action=watch [20:12:31] (which doesn't always work - sometimes there is an okay button that needs clicking) [20:12:58] (03PS2) 10Jdlrobson: QA: Protect against bug 62030 happening again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116167 [20:15:20] chrismcmahon: here if you have any more questions - going to turn my attention to another card [20:16:34] jdlrobson: I see the failure, but patch 6 should handle it, where the test does "And I am on the random page/And the page is unwatched" sets the page unwatched regardless of user preference to watch created pages . Maybe I misunderstand. [20:16:58] ok trying patch 6 now - did you see my comments about the toast message and moving to watchstar_steps as well? [20:19:09] chrismcmahon: seems we could do something like 'I see a toast with message "Removed #{@random_string} from your watchlist"' [20:19:34] Or a more generic message - 'I see a toast with message "Removed $1 from your watchlist where $1 is the random string' [20:20:42] jdlrobson: I'd like to keep create_page_api_steps.rb because once it's merged in MF I'd like to move that step to the gem to use in VE and other repos. [20:21:30] jdlrobson: I've wanted that for VE for a while now, but it was immediately useful for MF [20:22:06] chrismcmahon: I don't have an issue with that one. only https://gerrit.wikimedia.org/r/#/c/123679/6/tests/browser/features/step_definitions/common_article_steps.rb and https://gerrit.wikimedia.org/r/#/c/123679/8/tests/browser/features/step_definitions/watchlist_steps.rb [20:22:16] hey brion [20:22:26] brion: I think I fixed the issue you pointed out... [20:22:37] whee [20:22:40] "the page is unwatched$" is a watch star step and it shouldn't need to visit action=watch [20:22:43] that's why it's broken [20:22:57] it should visit the page without that argument and check whether the watch list icon has the right class [20:23:15] brion: I also fixed the 'gravity' issue, I think :) let me test it out [20:23:39] \o/ [20:24:25] brion: there! [20:24:29] well, when it turns up [20:24:32] (03PS3) 10Yuvipanda: Make convert-icons produce flipped versions of images too [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122872 [20:24:34] (03PS5) 10Yuvipanda: Add classList polyfill [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123798 [20:24:36] (03PS4) 10Yuvipanda: Position edit icon appropriately in RTL pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122580 [20:24:38] (03PS5) 10Yuvipanda: Set text direction of edit summary field for RTL languages properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122576 [20:24:40] (03PS6) 10Yuvipanda: Make license footer display with UI lang directionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122560 [20:24:42] (03PS5) 10Yuvipanda: Set edit text box's directionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122578 [20:24:52] brion: there! :) [20:28:32] grrrr chrome inspector stopped working.w tf? [20:28:54] it seems to be confused by having two phones attached :D [20:36:59] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make license footer display with UI lang directionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122560 (owner: 10Yuvipanda) [20:39:24] (03CR) 10Brion VIBBER: [C: 032 V: 032] Set text direction of edit summary field for RTL languages properly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122576 (owner: 10Yuvipanda) [20:42:44] (03CR) 10Brion VIBBER: [C: 032 V: 032] Set edit text box's directionality [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122578 (owner: 10Yuvipanda) [20:43:00] (03CR) 10Brion VIBBER: [C: 032 V: 032] Position edit icon appropriately in RTL pages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122580 (owner: 10Yuvipanda) [20:46:07] jdlrobson: not sure why it's failing for you. I just ran watchstar with user preference "Add pages I create and files I upload to my watchlist" set both ways and it passed both times. [20:46:17] brion: woo! [20:46:20] woo merges I mean [20:46:29] chrismcmahon i'm running with Firefox - are you? [20:46:39] jdlrobson: yes [20:46:57] mm well https://gerrit.wikimedia.org/r/#/c/123679/8/tests/browser/features/step_definitions/watchlist_steps.rb is definitely wrong [20:47:24] it's possible going to the url with ?action=unwatch can also have the effect of unwatching the article [20:47:44] (actually not [20:47:56] "it's possible" - it DOES unwatch the article. [20:47:59] jdlrobson: it is supposed to have the effect of unwatching the article, regardless of the beginning state of the article [20:48:22] i'll have another look. Why not use the API to do this anyhow? [20:48:29] wouldn't that make more sense? [20:48:29] jdlrobson: it handle the case where the user preference for watching created articles may be set either way [20:49:13] anyway PS8 fails for me-> timed out after 5 seconds, waiting for {:text=>"Yes", :tag_name=>"button"} to become present (Watir::Wait::TimeoutError) (it doesn't have a confirmed step - that might be specific to my mediawiki setup [20:49:17] jdlrobson: make that an enhancement? I don't have a wrapper for that API call atm [20:49:40] Ahh chrismcmahon my button says "OK" [20:49:41] not "yes" [20:49:57] jdlrobson: oh, OK. need a different locator for that step then [20:50:42] chrismcmahon: we can use the api for this [20:50:54] it will get round the need for doing it via the UI (and i thought this was the whole point of this patch) [20:51:05] otherwise why wouldn't we just use the patch i setup? :) [20:51:24] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make convert-icons produce flipped versions of images too [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122872 (owner: 10Yuvipanda) [20:51:40] (03PS1) 10JGonera: Make search slightly faster [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124005 [20:51:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add classList polyfill [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123798 (owner: 10Yuvipanda) [20:51:46] jdlrobson: because the test is flaky because multiple runs of the same test at the same time on the same target page interfere with each other [20:52:01] sure but using the API will avoid issues with localization here :) [20:52:13] which would mean if we ever wanted to run tests against a rtl wiki it would be super trivial [20:52:23] (note to self we should do that btw.. :) [20:52:52] (03PS5) 10Brion VIBBER: [Gingerbread] Get more things using the support version of the action bar accessors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122607 [20:52:54] (03PS5) 10Brion VIBBER: [Gingerbread] Partial animations fixes using NineOldAndroids [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122590 [20:52:56] ok rebasing gingerbread patches [20:52:56] (03PS5) 10Brion VIBBER: [Gingerbread] Don't crash on setting zoom controls [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122591 [20:52:58] (03PS3) 10Brion VIBBER: [Gingerbread] Partial fixes for 'saved pages' view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123785 [20:53:00] (03PS7) 10Brion VIBBER: [Gingerbread] Work around lack of ColorDrawable.getColor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122547 [20:53:02] (03PS3) 10Brion VIBBER: [Gingerbread] Copy some theme attributes directly that aren't available on v10 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123787 [20:53:04] (03PS8) 10Brion VIBBER: [Gingerbread] Workaround for SaneAsyncTask: copy AsyncTask from KitKat [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122548 [20:55:31] fixing [21:08:51] (03PS8) 10JGonera: Card 1814 (Story 1747): Notification drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120733 (owner: 10Jdlrobson) [21:11:20] (03CR) 10JGonera: [C: 032] Card 1814 (Story 1747): Notification drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120733 (owner: 10Jdlrobson) [21:11:52] (03Merged) 10jenkins-bot: Card 1814 (Story 1747): Notification drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120733 (owner: 10Jdlrobson) [21:17:56] brion: spare cycles for a bit of cr? [21:22:32] mhurd: whatcha got? [21:22:46] (03PS1) 10Mhurd: Table of contents ux refinement. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/124013 [21:22:50] brion: ^ [21:22:56] \o/ [21:23:51] looking it over [21:24:03] brion: woohoo! [21:24:55] brion: gonna amend the commit message - i have a duplicate line [21:25:01] ok [21:25:16] (03PS2) 10Mhurd: Table of contents ux refinement. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/124013 [21:25:27] brion: done [21:26:25] brion: oh crap i accidentally added a debugging line when i amended just now! [21:26:35] heh [21:26:56] (03PS3) 10Mhurd: Table of contents ux refinement. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/124013 [21:27:02] brion: sorry! [21:27:04] gah [21:27:21] oooh that slide to reveal toc is kinda neat [21:28:55] brion: i’m still not happy with the toc view controller - too many tenticles between it and the web view controller - but i can refactor more later [21:29:02] my one complaint is it’s a bit choppy, especially on slower devices [21:29:13] but there’s probably some tricks to speed that up [21:29:51] brion: ya needs some more tuning. could even just make it jump to docking postition on non-retina devices or something [21:32:15] well it’s kinda sluggish on ipad 3 retina for instance :D [21:32:22] (03CR) 10Dr0ptp4kt: [C: 032] Get rid of old ETL script. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123894 (owner: 10Dr0ptp4kt) [21:32:24] (03CR) 10jenkins-bot: [V: 04-1] Get rid of old ETL script. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123894 (owner: 10Dr0ptp4kt) [21:32:27] but i really like the mechanics, if we can tune that that’ll be super awesome [21:33:58] brion: ooh good point - retina ipad == larger frame buffer for all those pixels! i have a couple quick ideas to try, but they can wait for future commit of you’re ok with that [21:34:16] yeah we can tune later [21:35:14] (03PS1) 10Dr0ptp4kt: Remove old ETL script. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/124014 [21:35:24] jdlrobson: in R33 whenever your ready [21:35:28] (03Abandoned) 10Dr0ptp4kt: Get rid of old ETL script. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/123894 (owner: 10Dr0ptp4kt) [21:36:00] (03CR) 10Dr0ptp4kt: [C: 032] Remove old ETL script. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/124014 (owner: 10Dr0ptp4kt) [21:36:02] (03Merged) 10jenkins-bot: Remove old ETL script. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/124014 (owner: 10Dr0ptp4kt) [21:37:09] mhurd: i see this also disables pinch-to-zoom on content [21:37:26] was that something we wanted to keep, or did we decide to scrap it? [21:37:58] brion: ya had to do with the web view scroll pre-empting the drag event. tabled it for now, but would like to iron it out later [21:38:19] ok [21:40:37] (03CR) 10Brion VIBBER: [C: 032 V: 032] "I love the mechanics of the toc drag reveal! Couple of notes:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/124013 (owner: 10Mhurd) [21:40:49] looks good to go for now mhurd :D [21:42:02] brion: awesome thanks! interesting idea about swapping out for static image… i think ios7 finally has a public api for getting a raster representation of a view (and all its subviews’) pixel buffer [21:42:21] that’d be handy for that kind of trick yeah :D [21:42:37] brion: will play with that later for sure!!! [21:42:51] the trick with clever animations is you gotta be *smooth as silk* or it just dosn’t feel right [21:42:57] especially on ios, apple sets the bar really high :D [21:43:14] brion: haha for sure! [22:01:56] Chrome is being SO UNHELPFUL right now [22:07:54] * chrismcmahon does 'git reset --hard' for the second time [22:10:19] (03PS9) 10Cmcmahon: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 [22:31:40] (03PS1) 10Jdlrobson: Add vendor to gitignore [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124024 [22:34:05] (03PS1) 10JGonera: Show LoadingOverlay when loading VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124025 [22:37:28] (03PS1) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 [22:37:41] (03CR) 10jenkins-bot: [V: 04-1] Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [22:42:06] (03PS2) 10Jdlrobson: Hygiene: Move main menu rule out of typography [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122445 [22:43:02] (03CR) 10Jdlrobson: [C: 032] "rebased" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122445 (owner: 10Jdlrobson) [22:43:31] (03Merged) 10jenkins-bot: Hygiene: Move main menu rule out of typography [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/122445 (owner: 10Jdlrobson) [22:45:45] (03PS2) 10Jdlrobson: Hygiene: Cleanup gitignore [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124024 [22:55:20] (03PS1) 10Jdlrobson: Make check less work again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124029 [22:55:39] (03CR) 10Jdlrobson: "Doesn't seem to be working for me Matt Flaschen - any ideas why?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124029 (owner: 10Jdlrobson) [22:57:52] (03PS10) 10Jdlrobson: QA: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [22:59:57] (03PS1) 10JGonera: Hygiene: Use a single route for wikitext editor and VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124030 [23:01:27] (03CR) 10Jdlrobson: [C: 04-1] "The last test is failing as you are trying to unwatch an already unwatched page and you seem to have missed all my comments on previous pa" (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [23:03:53] (03CR) 10Jdlrobson: [C: 032] Show LoadingOverlay when loading VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124025 (owner: 10JGonera) [23:04:24] (03Merged) 10jenkins-bot: Show LoadingOverlay when loading VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124025 (owner: 10JGonera) [23:05:26] (03CR) 10Jdlrobson: [C: 032] Make search slightly faster [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124005 (owner: 10JGonera) [23:05:58] (03Merged) 10jenkins-bot: Make search slightly faster [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124005 (owner: 10JGonera) [23:07:08] (03CR) 10MaxSem: [C: 032] Hygiene: Cleanup gitignore [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124024 (owner: 10Jdlrobson) [23:07:40] (03Merged) 10jenkins-bot: Hygiene: Cleanup gitignore [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124024 (owner: 10Jdlrobson) [23:10:44] (03PS2) 10JGonera: Use predefined sizes for images in media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123900 [23:48:53] (03CR) 10Jdlrobson: [C: 032] "Thank you!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123900 (owner: 10JGonera) [23:49:26] (03Merged) 10jenkins-bot: Use predefined sizes for images in media viewer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123900 (owner: 10JGonera) [23:49:48] jdlrobson, thank _you_, I found a small bug using this test ;) [23:51:09] jgonera: whilst testing i noticed that if an image width/height is less than the resolution the media viewer stretches it. Not sure how/if we can/should deal with that. [23:51:31] (03PS1) 10JGonera: Set main menu width in pixels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124033 [23:51:47] hm [23:51:55] can you file a bug [23:51:56] ? [23:55:46] (03CR) 10JGonera: [C: 032] Make check less work again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124029 (owner: 10Jdlrobson) [23:56:09] omggzzz i can replicate the opt into alpha bug [23:56:18] (03Merged) 10jenkins-bot: Make check less work again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124029 (owner: 10Jdlrobson)