[00:14:09] (03PS1) 10JGonera: Fix styling of "No page with this title" in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124034 [00:16:36] jdlrobson, there are 7 patches waiting for review and pre-review doesn't complain [00:17:07] try debugging the python script and see what's happening - it's probably not identifying your project for some reason [00:17:38] jdlrobson, so it works for you? [00:17:40] jgonera: i assume get_project is not returning the correct project name [00:17:43] we might have to hard code it [00:17:52] this makes sense as S Page was having issues [00:18:12] can't look at it myself as i'm currently in war room trying to work out the typography change [00:18:54] ok [00:21:05] jdlrobson, it returns MobileFrontend, without the mediawiki/extensions [00:21:12] ah that's why then :-/ [00:40:55] StevenW: https://en.wikipedia.org/w/index.php?title=MediaWiki%3AVector.css&diff=602800100&oldid=598029523 [02:23:58] (03PS1) 10Jdlrobson: Ensure switching to alpha/beta always works. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124044 [07:24:48] (03CR) 10Siebrand: "You should also remove the now unused i18n file in maintenance/." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/124014 (owner: 10Dr0ptp4kt) [09:39:59] (03PS1) 10Siebrand: Remove unused i18n file [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/124052 [13:38:39] yo ya YuviPanda [13:41:04] [ it's an Seventies Israeli pop song: http://www.youtube.com/watch?v=wER3uM3X3bA ] [13:46:10] YuviPanda: is there a recent release of the app with the newest translation and RTL bug fixes? [19:33:36] hi, hashar [19:33:38] it seems you might be busy with some important stuffs but please dont forget to review the Bug: 61597 [19:34:15] helllo [19:34:36] ah jslinting on confirmedit [19:34:45] mind, you, I have almost Zero javascript knowledge :-] [19:35:33] oh, there were some comments by matt and jgonera that needs your answer [19:35:55] neverthless i did implemented the points i were told in comments [19:36:16] the question was regarding .jshintrc file [19:39:40] see them on https://gerrit.wikimedia.org/r/#/c/122126/ [19:39:42] ahhh [19:39:45] jshint is going to kill me [19:39:57] aalekhN: sorry I have missed Gerrit email notification for that change [19:40:17] :) , it happens [19:40:31] hopefully it did not get you blocked [19:40:32] :D [19:41:01] the relevant comment is Mattflaschen one at "Hashar, what is the effect exactly for having a blank .jshintrc? Does it use the out-of-the-box jshint defaults, or some Jenkins default? I notice it doesn't seem to include onevar (maybe since core switched to jscs for that?)" [19:41:14] guess I want to raise that issue on the wikitech-l mailling list [19:41:29] any idea what "onevar" is ? [19:41:51] it must be a jshint check but I am not sure what it is verifying. Maybe only one var statement per scope [19:42:19] no idea , i think so too [19:43:54] got it onevar is the default option in jshint see this: http://www.jshint.com/docs/options/ [19:44:03] but it is depreciated [19:44:56] so when i checked the code in jshint.com i did not got any sort of errors [19:45:54] hmm [19:45:58] gotta create a test case [19:46:15] see what happens with and without the empty .jshintrc file [19:47:09] yes, maybe this may be the issue with many empty .jshintrc [19:52:28] ah onevar is deprecated ghmm [19:53:04] yup i pointed that out [19:53:11] replying on gerrit change [19:55:05] done [19:55:10] basically .jshintrc empty is fine [19:55:23] Mattflaschen is a great guy [19:55:48] yup he pointed some important points i missed in my earlier commit [19:56:55] so i guess its on mattlflaschen to review the commit right? [19:59:16] jgonera can too probably [19:59:32] ConfirmEdit is not that much active though [20:01:05] oh, cool [20:01:06] yes but i am working for the gsoc project to make confirm edit more powerful i hope i get great result from it [20:01:32] there are some major issues in confirmedit that needs to be solved [20:14:41] aalekhN: ah Gsoc. Well I am the one in charge of the Jenkins platform [20:14:58] I got some knowledge regarding tests, so feel free to poke me about getting tests for your code :-] [20:15:09] though your mentor must be able to guide you on the testing path [20:16:22] that would be a great help thanks :) [21:21:42] StevenW: We're getting a bit of feedback coming into OTRS about the font change - would you like to handle and or/review those directly? [21:22:43] No, I think a response confirming that yes it changed, and point to the FAQ + blog post, is fine. [21:23:02] I think I sent a mail about it with links, to the English OTRS volunteer mailing list. Are you on that? [21:23:06] If not I can give you the links.