[02:46:16] (03PS1) 10Theopolisme: Search: Prevent unneeded API requests when there aren't any titles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124281 [02:46:27] (03CR) 10jenkins-bot: [V: 04-1] Search: Prevent unneeded API requests when there aren't any titles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124281 (owner: 10Theopolisme) [02:47:50] (03CR) 10Theopolisme: "> Your branch is behind 'origin/master' by 436 commits, and can be fast-forwarded." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124281 (owner: 10Theopolisme) [02:52:41] (03PS2) 10Theopolisme: Search: Prevent unneeded API request when there aren't any titles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124281 [02:56:07] (03CR) 10Theopolisme: "Straightforward enough... and I thought I was being clever with the pageimages trickery in patch set 1...of course it turns out that was f" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124281 (owner: 10Theopolisme) [14:37:30] (03PS11) 10Cmcmahon: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 [14:41:23] (03PS12) 10Cmcmahon: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 [16:23:11] YuviPanda: how about changing the topic here to reflect the WP App ? [17:16:35] (03PS1) 10Dr0ptp4kt: Remove legacy i18n file in maintenance folder. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/124356 [17:21:01] (03PS2) 10MaxSem: Fix outdated $wgMFCustomLogos comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123888 [17:21:20] (03CR) 10Siebrand: "This is already submitted as https://gerrit.wikimedia.org/r/#/c/124052/" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/124356 (owner: 10Dr0ptp4kt) [17:21:34] (03CR) 10MaxSem: Fix outdated $wgMFCustomLogos comment (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123888 (owner: 10MaxSem) [17:22:14] (03Abandoned) 10Dr0ptp4kt: Remove legacy i18n file in maintenance folder. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/124356 (owner: 10Dr0ptp4kt) [17:29:08] (03PS13) 10Jdlrobson: QA: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [17:34:19] (03CR) 10Jdlrobson: [C: 031] "I still have outstanding nitpicks that I've brought up before so this is only getting a +1 from me. It works but I'm not sure it does all " (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [17:37:15] (03CR) 10Jdlrobson: [C: 032] "Theo great to see you back. Love the simplicity of this fix :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124281 (owner: 10Theopolisme) [17:37:24] YuviPanda: any sign of that diploma ? [17:37:48] (03Merged) 10jenkins-bot: Search: Prevent unneeded API request when there aren't any titles [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124281 (owner: 10Theopolisme) [17:45:54] (03CR) 10Jdlrobson: [C: 04-1] "It looks better but can we fix that 1px in stable as well to call this bug fully closed? http://imgur.com/9CzgDpJ" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124034 (owner: 10JGonera) [17:51:55] tfinc: none yet :( I checked on Thursday, I'll check again tomorrow [17:53:14] (03CR) 10Jdlrobson: [C: 032] Set main menu width in pixels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124033 (owner: 10JGonera) [17:53:36] (03PS1) 10Brion VIBBER: List layout for settings language selector is v11 again, have to duplicate it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124364 [17:54:49] (03CR) 10Jdlrobson: [C: 032] "Okay.. I'm sure there is a documentation syntax that exists for this but since I don't know it we can do this later." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123888 (owner: 10MaxSem) [17:56:02] (03Merged) 10jenkins-bot: Set main menu width in pixels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124033 (owner: 10JGonera) [17:57:20] (03Merged) 10jenkins-bot: Fix outdated $wgMFCustomLogos comment [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123888 (owner: 10MaxSem) [17:57:49] YuviPanda: see my topic about channel topic? is way out of date [17:57:59] YuviPanda: their seriously slacking with this [18:04:47] (03CR) 10Jdlrobson: [C: 032] "This is going to lead me to writing a patch to make the default editor choice sticky... ;-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124030 (owner: 10JGonera) [18:05:20] (03Merged) 10jenkins-bot: Hygiene: Use a single route for wikitext editor and VE [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124030 (owner: 10JGonera) [18:05:45] jgonera: MaxSem can we ensure https://gerrit.wikimedia.org/r/123474 gets merged before thursday - would love to start collecting data around the history link in beta [18:06:32] (03PS2) 10Jdlrobson: EventLog profile and history link clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123474 [18:07:22] jdlrobson, we can definitely try [18:07:36] chrismcmahon: https://bugzilla.wikimedia.org/63090 i still don't know why this isn't working for me [18:07:39] can we work this out today? [18:07:53] the tests won't run at all - are we sure they are running on cloudbees? [18:08:29] jgonera: also did you see your personal compact toolbar was breaking stuff? [18:09:28] jdlrobson, star stuff? [18:09:44] it was to do with event logging [18:09:51] trying to use it when unavailable or something [18:09:58] James_F cc'ed you on the bug [18:10:01] just checking you saw it [18:10:34] I haven't. I'll have a look today, thanks. [18:11:31] jdlrobson: sure. in tests/browser/Gemfile.lock what version of mediawiki_selenium do you have? [18:13:31] i have whatever is in master [18:13:53] chrismcmahon: is there any specific way i can check the installed version? [18:14:26] ~/Sites/w/extensions/MobileFrontend/tests/browser $ bundle check [18:14:26] The Gemfile's dependencies are satisfied [18:14:38] * mediawiki_selenium (0.2.16) [18:14:43] is what i get when i do bundle list [18:15:25] (03PS2) 10Brion VIBBER: [Gingerbread] List layout for settings language selector is v11 again, have to duplicate it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124364 [18:15:27] (03PS1) 10Brion VIBBER: [Gingerbread] Attempting to get edit summary memory working [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124369 [18:16:26] hmm, OK [18:17:09] jdlrobson: what happens when you type "bundle" ? [18:17:23] … Using mediawiki_selenium 0.2.16 [18:17:23] Using bundler 1.6.0 [18:17:24] Your bundle is complete! [18:17:26] Use `bundle show [gemname]` to see where a bundled gem is installed. [18:17:42] OK, strange [18:18:44] 1 scenario (1 undefined) [18:18:45] 5 steps (1 skipped, 1 undefined, 3 passed) [18:18:45] 0m22.942s [18:18:48] is what i get when i run [18:19:45] chrismcmahon: and we are totally sure these tests are running on production? [18:20:27] jdlrobson: oh hell maybe not [18:28:21] (03Abandoned) 10Brion VIBBER: [Gingerbread] Attempting to get edit summary memory working [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124369 (owner: 10Brion VIBBER) [18:30:09] mhurd: brion: you guys good for the showcase ? [18:30:21] remember to wire in to get most optimal performance [18:31:47] tfinc: not sure i have anything new and fun to show… but i’ll check [19:01:16] brion: joining us ? [20:44:03] (03CR) 10Cmcmahon: [C: 031] "+1 for now, replies inline" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [20:50:35] chrismcmahon: any ideas about those missing step definitions? [20:50:57] jdlrobson: looking at that now. Not sure, it worked at one point, and it should work now. [20:52:03] ok cool - make aure you report any findings on the bug report so they don't go lost! :) [21:12:32] (03PS2) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 [21:12:42] (03CR) 10jenkins-bot: [V: 04-1] Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [21:19:25] (03PS9) 10JGonera: [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 [21:20:15] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [21:25:57] (03PS2) 10Jdlrobson: Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 [21:25:59] (03PS3) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 [21:29:07] (03CR) 10jenkins-bot: [V: 04-1] Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 (owner: 10Jdlrobson) [21:29:10] (03CR) 10jenkins-bot: [V: 04-1] Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [21:58:51] brion: you about ? [22:01:25] (03PS1) 10Jdlrobson: Regression: Clicking hamburger 2nd time closes menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124472 [22:01:43] ^ jgonera regression! :-O [22:01:55] also did you work out the problem with your pre-review hook? [22:02:12] could you let me know what git remote -v | head -n1 | awk '{print $2}' | sed -e 's,.*:\(.*/\)\?,,' -e 's/\.git$//' returns if not [22:02:19] MaxSem: too ^ [22:02:33] $ git remote -v | head -n1 | awk '{print $2}' | sed -e 's,.*:\(.*/\)\?,,' -e 's/\.git$//' [22:02:33] MobileFrontend [22:03:06] same for me [22:03:10] jdlrobson, so it shouldn't close the menu? [22:03:56] jdlrobson, oh, it's stable only [22:04:16] it should close the menu [22:04:19] (03CR) 10JGonera: [C: 032] Regression: Clicking hamburger 2nd time closes menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124472 (owner: 10Jdlrobson) [22:04:36] jgonera: interesting… seems that for me it returns ssh://jdlrobson@gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend [22:04:47] i wonder why that is.. [22:04:50] (03Merged) 10jenkins-bot: Regression: Clicking hamburger 2nd time closes menu [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124472 (owner: 10Jdlrobson) [22:05:23] jdlrobson, what does git remote -v return for you? [22:05:49] jgonera: gerrit ssh://jdlrobson@gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend.git (fetch) [22:05:50] gerrit ssh://jdlrobson@gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend.git (push) [22:05:51] origin https://git.wikimedia.org/git/mediawiki/extensions/MobileFrontend.git (fetch) [22:05:52] origin https://git.wikimedia.org/git/mediawiki/extensions/MobileFrontend.git (push) [22:05:54] (Sorry for spam) [22:06:37] so I bet sed for Mac is different [22:06:42] let me check [22:07:12] yeah, weird, Mac's are weird [22:07:21] it seems regexes in your sed are not greedy [22:07:26] which should be the default [22:07:29] let me fix that [22:07:39] Macs* [22:09:26] jdlrobson, does this work for you? git remote -v | head -n1 | awk '{print $2}' | sed -e 's/\(ssh:.*\)\.git$/\1/' [22:10:22] actually [22:10:25] it can be simpler [22:11:20] that gives me ssh://jdlrobson@gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend [22:12:01] so isn't it what it's supposed to return? [22:14:13] jdlrobson: seems like we're ready to go for SWAT> [22:14:14] ? [22:14:23] jdlrobson, ? [22:14:25] I will make sure the change is announced. [22:14:31] jdlrobson, this one is shorter: git remote -v | head -n1 | sed -e 's/.*\(ssh:.*\)\.git.*/\1/' [22:14:39] and doesn't require awk [22:14:45] jgonera: yep that's what it is meant to return [22:14:56] sorry just had to pop to bathroom unexpectedly - loose contact lense [22:15:03] ;) [22:15:07] StevenW: I guess so - i recorded it on the deploy page [22:15:20] jgonera: if that works for you do you want to submit a patch and i'll test and get it merged [22:15:29] jdlrobson, ok, in a moment [22:21:27] Krinkle, can you re-review https://gerrit.wikimedia.org/r/#/c/116037/ ? [22:32:34] jdlrobson, something weird happens when I try to change it... I get a weird unicode char as the output in get_project() [22:34:06] (03PS1) 10JGonera: [WIP] Fix pre-review on Linux [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124482 [22:34:10] jdlrobson, ^ [22:49:23] ValueError: too many values to unpack :/ [22:51:12] jgonera: super weird [22:51:29] jdlrobson, yeah, because it's a single character [22:51:41] and has nothing to do with this command's output [22:51:53] yeh.. [22:51:54] mm [22:53:10] got it! [22:53:24] backslash is an escaping character in Python strings [22:53:32] so I'm escaping 1 in \1 [22:53:34] ahhh [22:53:35] fixing [22:55:43] jdlrobson, the script still doesn't work for me though :/ [22:55:50] even though project name is correct now [22:55:51] arrrggh what happens now? [22:55:58] project name should be mediawiki/extensions/MobileFrontend [22:56:27] jgonera: actually we could just hardcode this.. (although then it's not a generic script ;-)) [22:56:27] (03PS2) 10JGonera: [WIP] Fix pre-review on Linux [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124482 [22:56:32] it is [22:56:41] I reduced 5 to 1 and it doesn't tell me anything [22:57:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Fix pre-review on Linux [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124482 (owner: 10JGonera) [22:58:29] jdlrobson, but hardcode what? project name is fine [22:58:37] it's something else that's not working now [23:01:17] jgonera: that seems to work for me [23:01:32] there are just not more than 4 [23:02:02] jgonera: i stand corrected there are 6 open patch sets but you are working on a revised patch so it's okay [23:02:49] jgonera: if you add print open_patches above the last if statement what do you see? [23:20:00] (03PS1) 10Theopolisme: Only offer VisualEditor if installed and enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124494 [23:32:44] (03PS2) 10Jdlrobson: Only offer VisualEditor if installed and enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124494 (owner: 10Theopolisme) [23:33:13] (03CR) 10Jdlrobson: [C: 04-1] "Thanks for this Theo! Note this opens the editor with the toggle button to the left of the overlay heading - we'll probably want to disabl" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124494 (owner: 10Theopolisme) [23:33:38] (03PS3) 10Jdlrobson: Fix pre-review on Linux [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124482 (owner: 10JGonera) [23:33:54] (03CR) 10Jdlrobson: [C: 031] "Seems to work for me..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124482 (owner: 10JGonera) [23:35:16] awjr: MaxSem chrismcmahon https://gerrit.wikimedia.org/r/124044 [23:35:22] can you see if that fixes our opt into alpha woes? [23:35:35] or at least apply the patch to beta labs for a bit to see if the builds go green again.. [23:36:43] wait that patchset is going to cause problems in production [23:36:48] jdlrobson, this change would meant that opt in would work only for current wiki, instead of e.g. whole wikipedia.org [23:36:58] what max said ;) [23:37:25] that base domain thing ensures that the cookie domain is .wikipedia.org [23:37:37] awjr MaxSem 1) does that matter..? 2) Any ideas why this fixes the problem for me locally… what could be going wrong? [23:38:16] 1) maybe not anymore but it was an architecture decision that we made a long time ago 2) maybe because of how your domain is configured locally [23:38:27] re #2, what is the domain that gets set on your cookie? [23:38:33] and what is the domain of your instance? [23:38:33] 1) you'll start complaining yourself;) [23:38:37] :p [23:40:19] (03CR) 10Awjrichards: [C: 04-2] "This will cause unintended behavior in production" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124044 (owner: 10Jdlrobson) [23:41:16] jdlrobson: ^^ [23:41:30] jdlrobson, I could checkout that PS in labs for a minute... [23:42:40] MaxSem: that would be useful if chrismcmahon can get a build to run against it [23:42:45] awjr: i'm looking [23:43:01] how do i sniff on a chrome selenium driver [23:43:31] awjr: Set-Cookie:optin=beta; expires=Sat, 04-Oct-2014 23:43:09 GMT; path=/; domain=localhost; httponly [23:43:38] but the cookie hasn't set [23:43:42] (03CR) 10Krinkle: [C: 04-1] Only offer VisualEditor if installed and enabled (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124494 (owner: 10Theopolisme) [23:43:53] Cookie:mf_useformat=true; my_wiki_session=bh4o5ie6m99rc0kn2qh5o2krl4 is the next get [23:45:11] i can imagine the domain handling being what is wonking things up on betalabs since the domain is comprised of multiple subdomains - im not sure how well that case is handled either by our code or by browsers [23:46:04] in the case of localhost though, i would think that it should be fine - the cookie header you shared jdlrobson looks good to me but im not really positive [23:46:24] yeh i'm not sure what's going on [23:46:28] chrismcmahon, I'm ready for experiment, please poke me when you're ready to launch tests [23:46:50] note that if you do not have a mobile domain template defined getBaseDomain() should just use whatever domain is configured for your site (or IP address) [23:46:54] jdlrobson: ^ [23:47:04] MaxSem: in a mtg, will catch up [23:47:04] (03CR) 10JGonera: [C: 032] "Yeah, it's fine. I didn't see the revised_patch thing." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124482 (owner: 10JGonera) [23:48:35] awjr: it returns localhost [23:48:38] this is why it is super weird [23:48:44] why is that weird? [23:48:53] should it return something else? [23:50:55] because the cookie is not setting [23:51:24] jdlrobson: what domain to see you on cookies that do get successfuly set? [23:51:29] s/to/do [23:52:46] Set-Cookie:optin=beta; expires=Sat, 04-Oct-2014 23:52:12 GMT; path=/; httponly [23:52:52] sets it fine for some reason [23:52:59] (03CR) 10jenkins-bot: [V: 04-1] Fix pre-review on Linux [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124482 (owner: 10JGonera) [23:52:59] no domain? [23:53:18] jdlrobson: ^^ [23:53:28] no domain yeh [23:53:34] (03CR) 10JGonera: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124482 (owner: 10JGonera) [23:55:06] yeah the more i think about it the more i think you're on to something jdlrobson - wonky domain handling for the cookies might also explain why we haven't seen the problem manifest on wikipedia but we do on more complex domains like for betalabs [23:55:50] could onGetCacheVaryCookies have anything to do with it? [23:56:38] i dont know why it would [23:57:10] i'd have to look at the code but iirc that just manages sending cache variance headers, which should have nothing to do wiht your case [23:58:33] MaxSem: awjr jdlrobson I'm happy merging that to master so that it goes to beta for trial. the overnight test runs will tell us something and I can exercise it a lot tomorrow (in plenty of time to revert if it causes any problems) [23:59:13] chrismcmahon: i'll leave that decision up to jgonera as tech lead, but i will caution against it. master should always be in a state safe to deploy to production