[00:00:02] awjr: understood. I do think this is a legit use of beta labs though, just a rare one. [00:00:37] awjr: rules are made to be blah blah blah [00:04:11] chrismcmahon: cant we just check the change out to betalabs? [00:05:15] awjr: a) I don't think we have any mechanism to do that right now and b) if we did, it would be overwritten 3 minutes later by the automatic update to master branch unless c) we killed the update script to prevent b) [00:05:36] hmm [00:05:44] ok, well, jgonera can make the call ;) [00:07:08] awjr: srsly, I think a 24-hour probationary merge to master makes sense here: low risk, high reward if we're right. jgonera ^^ [00:07:16] chrismcmahon, I actually stopped updates before by chowning files to root [00:07:40] or course, it's very lame and causes deployment jobs to fail:) [00:07:43] MaxSem: yeah, it can be done [00:07:57] MaxSem: there are probably better ways :-) [00:15:29] brion: you about ? [00:22:08] (03CR) 10Theopolisme: Only offer VisualEditor if installed and enabled (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124494 (owner: 10Theopolisme) [00:22:15] (03PS3) 10Theopolisme: Only offer VisualEditor if installed and enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124494 [06:01:27] (03PS1) 10Yuvipanda: Don't put page title in Share Text [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124520 [07:11:54] (03PS1) 10Yuvipanda: Make new alpha release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124522 [07:12:07] (03CR) 10Yuvipanda: [C: 032 V: 032] Make new alpha release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124522 (owner: 10Yuvipanda) [07:29:08] (03PS2) 10Yuvipanda: Don't put page title in Share Text [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124520 [07:29:10] (03PS1) 10Yuvipanda: Fix margin for saved pages / history icons in RTL languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124523 [09:22:13] (03PS1) 10Yuvipanda: Fix RTL issues with username display in drawer [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124550 [09:22:15] (03PS1) 10Yuvipanda: Add apk files to gitignore [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124551 [09:22:17] (03PS1) 10Yuvipanda: Added jshintrc and fixed warning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124552 [16:13:26] (03PS2) 10Yuvipanda: Added jshintrc and fixed warnings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124552 [16:14:21] (03CR) 10jenkins-bot: [V: 04-1] Added jshintrc and fixed warnings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124552 (owner: 10Yuvipanda) [16:16:56] (03PS3) 10Yuvipanda: Added jshintrc and fixed warnings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124552 [16:23:01] (03PS1) 10Cmcmahon: QA: updated mediawiki_selenium to make uploads work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124623 [16:24:49] (03CR) 10jenkins-bot: [V: 04-1] Added jshintrc and fixed warnings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124552 (owner: 10Yuvipanda) [16:28:24] (03CR) 10Zfilipin: [C: 032] QA: updated mediawiki_selenium to make uploads work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124623 (owner: 10Cmcmahon) [16:32:44] (03PS4) 10Yuvipanda: Added jshintrc and fixed warning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124552 [16:32:49] (03CR) 10jenkins-bot: [V: 04-1] Added jshintrc and fixed warning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124552 (owner: 10Yuvipanda) [16:33:09] (03CR) 10jenkins-bot: [V: 04-1] QA: updated mediawiki_selenium to make uploads work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124623 (owner: 10Cmcmahon) [16:33:33] (03Merged) 10jenkins-bot: QA: updated mediawiki_selenium to make uploads work [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124623 (owner: 10Cmcmahon) [16:34:36] (03PS5) 10Yuvipanda: Added jshintrc and fixed warning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124552 [16:36:55] (03PS1) 10Yuvipanda: Testing jshint please ignore [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124631 [16:38:05] (03CR) 10jenkins-bot: [V: 04-1] Testing jshint please ignore [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124631 (owner: 10Yuvipanda) [16:44:28] (03Abandoned) 10Yuvipanda: Testing jshint please ignore [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124631 (owner: 10Yuvipanda) [16:47:29] (03PS1) 10Siebrand: Add punctuation to "mobile-frontend-profile-last-thank" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124635 [16:59:00] (03CR) 10MaxSem: [C: 032] Add punctuation to "mobile-frontend-profile-last-thank" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124635 (owner: 10Siebrand) [16:59:02] (03PS6) 10Yuvipanda: Added jshintrc and fixed warning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124552 [16:59:04] (03PS2) 10Yuvipanda: Fix RTL issues with username display in drawer [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124550 [16:59:06] (03PS2) 10Yuvipanda: Add apk files to gitignore [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124551 [16:59:08] (03PS3) 10Yuvipanda: Don't put page title in Share Text [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124520 [16:59:10] (03PS2) 10Yuvipanda: Fix margin for saved pages / history icons in RTL languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124523 [16:59:35] (03Merged) 10jenkins-bot: Add punctuation to "mobile-frontend-profile-last-thank" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124635 (owner: 10Siebrand) [16:59:37] (03PS14) 10Zfilipin: QA: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [17:00:58] (03CR) 10Zfilipin: "Manually rebased, there was a conflict in Gemfile.lock." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [17:01:11] (03CR) 10Zfilipin: [C: 032] QA: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [17:01:44] (03Merged) 10jenkins-bot: QA: Create pages for Watchlist tests at runtime with API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123679 (owner: 10Cmcmahon) [17:02:03] marktraceur: may I tempt you into merging https://gerrit.wikimedia.org/r/#/c/124552/ which is a trivial jshintrc addition [17:02:43] Merge requests in -mobile [17:02:47] Interesting start to the day [17:03:14] > trivial [17:03:16] > +160, -180 [17:03:45] marktraceur: heh [17:03:59] marktraceur: everything inside assets/* is ignorable. they are generated files [17:04:05] yuvipanda: onevar: false does not inspire confidence [17:04:13] marktraceur: it was intentional on my part. [17:04:29] I took MF's config and switched that [17:04:32] I'm sure but it means you're going against general code conventions [17:04:41] Same for forin I think... [17:04:42] oh dear [17:04:45] But I may be wrong [17:04:48] forin I didn't touch, it was just MF [17:04:57] yuvipanda: any sign of brion today ? [17:05:00] anyway, in that case I'm mostly just going to abandon this patch [17:05:02] tfinc: not yet [17:05:11] Oh, hm. [17:05:27] yuvipanda: Wait, abandon? Why? [17:05:30] Primarily because I don't want to get on the onevar debate again. [17:05:39] Haha [17:05:46] yuvipanda: I'm not debating you, I'm just informing you [17:05:46] :P [17:05:55] marktraceur: hehe :) I was aware... [17:06:12] The core JS and most of the extensions in Features/Platform follow one standard and now you're diverging from that standard explicitly [17:06:50] I do not want to have this discussion :P [17:07:01] I know [17:07:08] That doesn't mean you shouldn't be aware of it [17:07:08] :D [17:07:20] I did mention I was aware [17:07:41] You, ah...did. [17:07:49] aharoni: sending build now :) [17:10:08] yuvipanda: It doesn't seem trivial because it touches a bunch of code; I think I will let someone merge who can actually test it, but I will +1 [17:10:15] marktraceur: :) [17:10:20] marktraceur: ty! [17:10:21] (03CR) 10MarkTraceur: [C: 031] "Cannot test, but the code looks fine." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124552 (owner: 10Yuvipanda) [17:12:36] brion: hey! i have a patch… there’s *still* a delay issue with 3gs unfortunately, but will tackle soon [17:12:51] (03PS1) 10Mhurd: Table of contents revealed via swipe instead of drag. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/124642 [17:13:00] whee [17:13:19] brion: thought i had the delay beat :( [17:13:34] getting there :D [17:13:54] brion: at least the transition is smooth now :) [17:14:11] hi brion [17:14:26] brion: I setup jenkins jobs for the js stuff :) Runs jshint now [17:16:04] nice [17:16:10] awww, i was not selected for a WWDC ticket [17:16:18] brion: :( [17:22:33] mhurd: first cut of editing schema: https://etherpad.wikimedia.org/p/mobile-app-workflow-el-1 [17:22:42] brion: ^ [17:23:05] YuviPanda: nice!!! [17:23:28] brion: no golden ticket for me either [17:23:30] mhurd: it should give us super nice analytics with a proper 'funnel' where we can very clearly see drop off points [17:23:45] YuviPanda: that’s so cool :) [17:24:09] mhurd: yeah. but it's a bit complicated, but not too much. The only concepts are 'user token' and 'editing session token' that need to be done properly. [17:25:05] mhurd: user token is just 'device token', but generated on first launch by the app (just a random UUID). editing session token is regenerated on every 'start edit' so we know which events were part of one workflow [17:25:16] mhurd: does that make sense? I documented them in the etherpad as well [17:25:45] YuviPanda: yeah that sounds solid [17:26:54] aharoni: sent! [17:26:54] mhurd: cool. [17:27:12] yuvipanda: ack [17:27:14] yuvipanda: looks nice so far (schema) [17:27:18] mhurd: so the other thing kenan wanted was to figure out a 'pages per session' metric [17:27:27] my device is not here, so I'll take a look at it later. [17:27:28] mhurd: only issue there is to figure out how to define 'session' [17:27:32] aharoni: ty! [17:28:09] YuviPanda: “session” uuid each time app resumes? [17:28:28] mhurd: yeah but we shouldn't be making an EL call after every page view [17:28:37] that's mad plus I don't think our EL infrastructure would like that [17:28:52] would only call on suspend? [17:29:45] YuviPanda: i think there’s a “appWillSuspend” type event on ios - and i think it gives the app a second or two… [17:29:56] mhurd: can we make a reliable network call there? [17:30:03] definitely wonky on Android tho [17:30:29] YuviPanda: i *think* so, but will have to play with it [17:30:43] mhurd: hmm, actually [17:30:58] YuviPanda: ah! i think i know what to do [17:31:27] YuviPanda: just send the session log info the next time [17:31:34] next resume [17:31:42] mhurd: yeah! [17:31:55] just before generating new session uuid [17:33:47] the only thing that could potentially not capture is people so disgusted they never open the app again :) [17:34:17] (03CR) 10Jdlrobson: [C: 032] Fix pre-review on Linux [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124482 (owner: 10JGonera) [17:34:36] mhurd: moment, meeting [17:34:49] (03Merged) 10jenkins-bot: Fix pre-review on Linux [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124482 (owner: 10JGonera) [17:37:59] (03PS1) 10Jdlrobson: Card 1815: Add animations to right drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124649 [17:41:14] (03CR) 10Jdlrobson: "I assume this was a fix for bug 63090. Don't forget to mention it in the commit message, had I not seen this that bug would have not been " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124623 (owner: 10Cmcmahon) [17:45:04] (03CR) 10Jdlrobson: [C: 032] "See related bug https://bugzilla.wikimedia.org/show_bug.cgi?id=63689" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124494 (owner: 10Theopolisme) [17:45:44] (03Merged) 10jenkins-bot: Only offer VisualEditor if installed and enabled [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124494 (owner: 10Theopolisme) [17:49:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] Added jshintrc and fixed warning [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124552 (owner: 10Yuvipanda) [17:53:03] brion: I don't know if you need to do V+2 on it [17:53:32] ah does the machine do the V now? [17:53:45] brion: should. [17:56:53] grrrr my firefox session is borked [17:57:10] brion: heh [17:57:41] i seem to have an unkillable zombie process. nice [17:57:55] brion: heh. stake through the heart mabe [17:58:07] brb logout/login, followed by reboot if that doesn’t work :P [17:59:00] brion: :) [18:02:12] (03CR) 10Brion VIBBER: [C: 032 V: 032] Don't put page title in Share Text [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124520 (owner: 10Yuvipanda) [18:02:24] brion: try just C+2 next? [18:02:44] yeah yeah, force of habit [18:02:53] brion: ;) [18:03:02] brion: we should setup checkstyle for the java stuff [18:04:50] hi violetto [18:04:58] I sent a request for a small svg thing [18:05:00] yuvipanda! [18:05:13] yuvipanda: yeah i saw the email this morn [18:05:48] (03CR) 10Brion VIBBER: [C: 032] Fix margin for saved pages / history icons in RTL languages [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124523 (owner: 10Yuvipanda) [18:06:34] brion: oh, so just CR+2 from you merges it [18:06:35] nice [18:06:43] \o/ [18:06:47] brion: sweeet [18:06:49] less buttons! [18:06:58] brion: we should setup checkstyle, and then daily builds [18:08:26] (03CR) 10Brion VIBBER: [C: 032] Fix RTL issues with username display in drawer [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124550 (owner: 10Yuvipanda) [18:08:37] brion: are you in the office today? [18:08:42] (03CR) 10Brion VIBBER: [C: 032] Add apk files to gitignore [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124551 (owner: 10Yuvipanda) [18:08:49] yuvipanda: no [18:09:00] brion: hmm, ok [18:09:35] yuvipanda: so i’ve got a bunch of 2.3 fixes queued up: https://gerrit.wikimedia.org/r/#/q/project:apps/android/wikipedia,n,z [18:09:44] will you have a chance to start review on them in the next day or two? [18:09:51] brion: yeah, was looking at them now [18:09:54] thanks! [18:10:16] i’ve still got a crasher i can’t figure out in the edit summary edit box [18:10:25] but i think it’s mostly wrapped up other than that now [18:10:46] brion: how about the unit tests? [18:10:55] heh haven’t tested them actually [18:10:57] lemme try those :D [18:11:40] brion: hehe :PP please do [18:13:49] Caused by: java.lang.ClassNotFoundException: org.junit.Test in loader dalvik.system.PathClassLoader[/system/framework/android.test.runner.jar:/data/app/org.wikimedia.wikipedia.test-2.apk:/mnt/asec/org.wikipedia-1/pkg.apk] [18:14:16] * brion waves [18:14:23] waaat [18:15:10] yeah i’m googling trying to see if it’s just not supported on 2.3 or if i’ve got something set up wrong [18:15:13] (03PS8) 10Yuvipanda: [Gingerbread] Work around lack of ColorDrawable.getColor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122547 (owner: 10Brion VIBBER) [18:15:52] (03CR) 10Yuvipanda: [C: 032] [Gingerbread] Work around lack of ColorDrawable.getColor [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122547 (owner: 10Brion VIBBER) [18:16:12] (03PS1) 10Jdlrobson: Card 1757: Add EventLogging to Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124657 [18:16:14] (03PS9) 10Yuvipanda: [Gingerbread] Workaround for SaneAsyncTask: copy AsyncTask from KitKat [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122548 (owner: 10Brion VIBBER) [18:17:26] (03PS3) 10Jdlrobson: QA: Protect against bug 62030 happening again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116167 [18:17:41] chrismcmahon: can you help me get https://gerrit.wikimedia.org/r/#/c/116167/ working today? [18:17:46] it basically checks the upload progress bar shows [18:17:51] (03CR) 10Yuvipanda: [C: 04-1] "Shouldn't SaneAsyncTask inherit from this instead of the default?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122548 (owner: 10Brion VIBBER) [18:18:15] (03CR) 10Brion VIBBER: "Huh?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122548 (owner: 10Brion VIBBER) [18:18:19] (03PS6) 10Yuvipanda: [Gingerbread] Partial animations fixes using NineOldAndroids [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122590 (owner: 10Brion VIBBER) [18:18:57] jdlrobson: looking [18:19:12] yuvipanda: SaneAsyncTask never inerited from AsyncTask, it’s its own class [18:19:18] brion: gah, I meant *use* [18:19:22] there’s the backing task class which does [18:19:28] and it does use the local package copy of AsyncTask [18:19:30] brion: but yeah, looks like it is picking this up over the other one [18:19:38] I thought we had explicit imports, apparently we don't [18:19:40] do ignore [18:19:44] whee [18:19:57] (03CR) 10Yuvipanda: [C: 032] "Ignore, I was being stupid" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122548 (owner: 10Brion VIBBER) [18:20:03] \o/ [18:20:25] ok if i tweak the project settings it seems to actually bundle junit [18:20:35] and of course random things fail, as they do on 4.4 [18:20:42] because our tests currently are fragile and broken [18:23:11] brion: true [18:24:39] (03CR) 10Yuvipanda: [C: 032] [Gingerbread] Partial animations fixes using NineOldAndroids [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122590 (owner: 10Brion VIBBER) [18:24:51] wheeee [18:26:19] jdlrobson: I run the test in FF and I do not see a progress bar, just an "Uploading..." message. The path the test takes fails to trigger the progress bar. [18:26:41] oh fun, windows 8.1 update is out, now i gotta update a bunch of real and virtual machines. [18:26:43] chrismcmahon: yeh that's also technically a 'progress bar' depends on browser capabilities and configuration [18:26:57] but the user should either see the uploading message OR the progress bar [18:28:07] jdlrobson: test as written works in Chrome, fails in FF [18:28:30] yeh this is what i'm seeing [18:28:33] not sure how to rectify [18:31:23] jdlrobson: well, the behavior in Firefox is different than the behavior in Chrome also when run under Selenium, and I wonder why the Selenium run does not trigger the moving blue progress bar in FF while a manual upload in FF does trigger the progress bar. [18:35:55] jdlrobson: so when I manually upload an image I see a message "Uploading image..." then I see a blue progress bar, and I see a spinner working also. [18:36:13] chrismcmahon: so it's basically due to browser capability [18:36:44] oh but if the selenium build is different to the normal build of Firefox this is also weird [18:37:13] regardless a test to show some kind of feedback would be extremely useful. We had a bug related to this a while back where there was no feedback whatsoever :( [18:38:54] jdlrobson: a toast message containing "Success" might be worth checking for [18:38:59] downloading updates, bbiab [18:39:03] chrismcmahon: but it's more than that.. [18:39:13] chrismcmahon: the toast could take a whole minute to show [18:39:18] you need some feedback in between.. [18:40:15] jdlrobson: do we use EL for tracking login results in mobile web? [18:40:36] YuviPanda: Not for mobile web - maybe for all logins in core I'm not sure [18:40:48] jdlrobson: OK, I have an idea to try, but I [18:40:56] personally i'd love to know more about errors from login YuviPanda [18:41:05] jdlrobson: I have an idea to try but I'm starving, going to eat first [18:41:07] chrismcmahon: sweet! looking forward to seeing it! Feel free to amend my existing patch [18:41:09] chrismcmahon: me too [18:41:27] me goes to lunch [18:44:31] jdlrobson: heh, yeah. but was talking to halfak and there might be issues. [18:53:03] yuvipanda: is the last checkbox on https://trello.com/c/CFnvx8Mw/10-5-rtl-hygiene ready to check off? istr we did add flipping for the icons, are we missing any? [18:53:35] brion: I need the drawer icon, so waiting on violetto [18:53:40] ok [18:54:34] brion: we flip only svgs, not pngs and there is no svg for that [18:54:39] ah right [19:02:45] oooh, new alpha app update! [19:04:38] ragesoss: :D I'll try to do one a day now [19:05:54] (03CR) 10Yuvipanda: [C: 032] [Gingerbread] Don't crash on setting zoom controls [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122591 (owner: 10Brion VIBBER) [19:06:34] (03PS6) 10Yuvipanda: [Gingerbread] Don't crash on setting zoom controls [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122591 (owner: 10Brion VIBBER) [19:06:43] (03CR) 10Yuvipanda: [C: 032] [Gingerbread] Don't crash on setting zoom controls [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122591 (owner: 10Brion VIBBER) [19:08:42] (03CR) 10Brion VIBBER: [C: 032 V: 032] "I can confirm that delay on 3Gs but the animation itself is *much* smoother. Yay!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/124642 (owner: 10Mhurd) [19:10:11] (03PS6) 10Yuvipanda: [Gingerbread] Get more things using the support version of the action bar accessors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122607 (owner: 10Brion VIBBER) [19:11:11] (03CR) 10Yuvipanda: [C: 032] [Gingerbread] Get more things using the support version of the action bar accessors [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/122607 (owner: 10Brion VIBBER) [19:11:22] (03PS4) 10Yuvipanda: [Gingerbread] Partial fixes for 'saved pages' view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123785 (owner: 10Brion VIBBER) [19:11:58] (03CR) 10Yuvipanda: [C: 04-1] "What's the error you are seeing?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123785 (owner: 10Brion VIBBER) [19:12:14] hmm lemme check that one [19:12:25] (03PS4) 10Yuvipanda: [Gingerbread] Copy some theme attributes directly that aren't available on v10 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123787 (owner: 10Brion VIBBER) [19:12:38] (03PS3) 10Yuvipanda: [Gingerbread] List layout for settings language selector is v11 again, have to duplicate it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124364 (owner: 10Brion VIBBER) [19:14:59] yuvipanda: oh i think it was just still failing on an attr that got fixed later [19:15:12] brion: ah! and the scrollY? [19:16:04] apparently there’s no WebView.scrollY on gingerbread [19:19:57] brion: waah [19:32:35] yurik: joining us ? [19:35:53] yurik: https://etherpad.wikimedia.org/p/WikipediaZeroRetrospective [20:01:12] chrismcmalunch: can you grab the card 1801 in mingle if you are working on it? [20:20:34] YuviPanda: hey are all the “assets” folder files generated by the grunt script? [20:20:52] mhurd: www/assets? yeah [20:20:56] mhurd: err, I mean [20:20:58] mhurd: wikipedia/assets [20:20:59] yeah [20:21:06] kaity, moizsyed you might want to get onto the Migrating to Trello thread on mobile-tech [20:24:40] YuviPanda: so the assets files are actually used by the app, and the www files are only digested by grunt [20:24:47] mhurd: yup! [20:24:55] mhurd: the www files are 'compiled' into the files in asset/* [20:25:11] YuviPanda: gotcha. gonna read up on http://gruntjs.com/getting-started [20:25:17] mhurd: :) [20:25:24] YuviPanda: saw link in your readme [20:25:26] awjr, not sure whom I should poke about https://gerrit.wikimedia.org/r/#/c/116037/ [20:25:28] thanks! [20:25:29] mhurd: check out https://trello.com/c/NsCra66X/1-5-event-logging-editing-signing-in-article-navigation too, login and create account workflow cards are there as well [20:27:32] YuviPanda: lots of stuff on that card… what’s the actionable part? [20:28:24] (03CR) 10Yurik: [C: 032] Remove unused i18n file [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/124052 (owner: 10Siebrand) [20:28:29] (03Merged) 10jenkins-bot: Remove unused i18n file [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/124052 (owner: 10Siebrand) [20:28:35] YuviPanda: oh, the etherpad link? [20:28:38] mhurd: the schema design is on the etherpad. So we'll have to send events to EL matching that schema. There's also info on the etherpad about when events need to be sent and what exactly needs tracking. so looking at it and telling me 'that is hard in iOS' is thea ction item [20:28:38] mhurd: yeah [20:29:00] YuviPanda: haha, checking... [20:30:14] jgonera: if Krinkle isn't responding, maybe try roan? [20:30:15] YuviPanda: is there different item for loginSuccess and loginSuccess-when-in-edit-workflow? [20:30:35] mhurd: there is 'source' to differentiate that [20:30:46] mhurd: plus edit has a 'loginSuccess' thing as well, I think [20:31:46] mhurd: the biggest part will be the per-funnel sessionTokens and how we might need to have one token be available in another funnel (editSessionToken in login, login in Create Account, etc) [20:32:27] oh that’s right… just wondering how the source token is associated with these others [20:32:49] mhurd: hmm? [20:34:37] YuviPanda: sry i’m not too focused right now… so when i log, say, loginSuccess, do i pass it the source key? [20:34:58] mhurd: whad do you mean by 'source key'? [20:35:09] mhurd: also we could have this conversation tomorrow too if you're focused on other things atm :) [20:35:33] @jgone [20:35:39] YuviPanda: haha that’s fine too :) hangout tomorrow to chat? maybe after standup? [20:35:51] mhurd: email me questions? [20:36:03] mhurd: I'll find that easier, and I can also answer those during the day :) [20:40:35] (03PS1) 10Yuvipanda: Add proper flipped drawer indicator icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124733 [20:40:38] brion: ^ merge? I'll make an alpha after that and head to sleep :) [20:40:45] moment [20:42:13] testing... [20:42:50] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add proper flipped drawer indicator icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124733 (owner: 10Yuvipanda) [20:43:26] brion: ty [20:52:48] mhurd: also can you verify that account creation isn't broken on iOS? [20:52:57] (not now, but at some point soonish) [20:52:58] YuviPanda: k... [20:54:56] jgonera: i just poked the VE folks about that patchset in their channel, trevor is taking a look [20:55:14] thanks awjr [20:55:23] np [20:56:10] (03PS1) 10Yuvipanda: Don't restart activities on rotation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124738 [20:56:28] brion: ^ this too? :) [21:01:03] YuviPanda: broken :( [21:01:17] mhurd: yeah, figured. API changes I think. [21:01:23] YuviPanda: gah! [21:01:25] :) [21:01:34] looking [21:01:35] YuviPanda: what changed? [21:01:49] mhurd: I don't remember, but it is changes we wanted :) [21:02:01] hehe that’ll teach us [21:02:05] something about not having to solve a captcha before you get account creation errors I think [21:03:54] (03PS1) 10Jdlrobson: QA 1807: Provide tests for full text search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 [21:03:58] (03CR) 10Brion VIBBER: [C: 032 V: 032] Don't restart activities on rotation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124738 (owner: 10Yuvipanda) [21:05:10] (03PS1) 10Yuvipanda: Tag new alpha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124743 [21:05:25] (03CR) 10Yuvipanda: [C: 032] Tag new alpha [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124743 (owner: 10Yuvipanda) [21:05:31] jgonera: i think Krinkle is following up, but i gotta run to my dr appointment; i'll dbl check when im back [21:06:29] ragesoss: another alpha out! Your share text bug should be fixed in this one. [21:07:21] brion: so, I'm setting up jenkins jobs for things. [21:07:36] brion: so far jshint is enforced. I'll set up pyflake next, and checkstyle (for Java) afterwards. [21:07:48] brion: I'm also thinking of doing one for commit message formatting. What do you think? [21:07:56] \o/ [21:07:58] heh [21:08:02] like enforcing the line length? :D [21:08:06] brion: what do you think? [21:08:08] brion: unsure yet :P [21:08:19] brion: but the idea is to make it possible to auto generate changelogs [21:08:23] ooooh [21:08:25] that sounds handy [21:08:50] brion: yeah. [21:09:20] brion: and then I can write a small script that just bumps version number, builds a signed APK, makes appropriate commit, builds a CHANGELOG [21:09:32] awesome :D [21:09:47] brion: PhoneGap built their changelog from git commits but their git commit summaries were utter shit so the changelog was useless as fuck [21:10:33] hehe [21:12:55] brion: so like Bug: and Change-Id: we could have Feature: or other tags, and then group things together based on that. [21:13:03] or something along those lines. [21:13:07] om nom nom [21:14:23] brion: so, https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines + have the script strip out bug info and feature info. [21:14:24] mm [21:14:28] should be a good exercise :) [21:14:45] ++ [21:19:06] YuviPanda: did acct creation break on android too? [21:19:12] mhurd: yeah, it did. [21:19:18] I'll investigate tomorrow I think. [21:19:40] YuviPanda: good catch [21:19:45] YuviPanda: thank you [21:21:02] mhurd: :) [21:23:08] awjr_away: can you take another pass on my blog post? i took another pass on it [21:25:43] (03PS1) 10Yuvipanda: Make python files almost PEP8 compatible [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124746 [21:33:34] (03PS2) 10Yuvipanda: Make python files almost PEP8 compliant [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124746 [21:36:43] heh [21:36:49] 80-char line limit is cray-zay [21:37:08] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make python files almost PEP8 compliant [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124746 (owner: 10Yuvipanda) [21:37:17] brion: yeaah [21:37:23] brion: I also added a jenkins job for that [21:37:25] needs hashar [21:38:48] yuvipanda: on https://gerrit.wikimedia.org/r/#/c/123785/4 i think i just need to update the commit message, i think the mention of an error was leftover from when it was work-in-progress and refers to the ?attr queries in the next commit [21:38:48] brion: Java's checktyle enforcement is going to be the hardest [21:39:27] brion: hmm, so what to do with the FIXME? [21:39:39] ah [21:39:41] we could just get rid of setScrollY all together and send a message [21:39:47] indeed [21:39:47] and have JS do the scrolling [21:39:55] I think that's what we should do. [21:40:07] ok i’ll whip that up [21:41:02] brion: ok :) [21:41:24] * brion hmms [21:41:40] wait do we really need to set the scroll position to 0 anyway? are we overriding something or…. what was the purpose of that? [21:42:31] aren’t we always loading into a fresh webview, so it’ll be scrolled to 0 already? [21:43:55] brion: it's setting into scrollY which isn't 0 [21:44:07] brion: it's saved into the bundle [21:44:30] ah durrrrrr [21:44:32] * brion brainfart [21:45:01] but that brings us back to ‘is the saved scroll position useful’ [21:45:04] brion: also https://developer.android.com/reference/android/view/View.html#scrollTo(int, int) exists from level 1 [21:45:10] if we switched orientation, it’ll be wrong now [21:45:25] brion: it's not for saved pages, is it? It's if you go out and the activity dies and you come back [21:45:31] right [21:45:33] brion: true, but better than dumping you on top. [21:45:38] heh [21:45:42] if you just rotate it'll be fine now [21:45:43] ok lemme test the scrollTo and see if it works [21:46:10] ok :) [21:46:13] I'll be off now [21:46:17] night everyone :) [21:46:24] night night [21:46:36] brion: night! [21:50:12] (03PS5) 10Brion VIBBER: [Gingerbread] Partial fixes for 'saved pages' view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123785 [21:53:41] (03CR) 10Brion VIBBER: "Ok this *should* resolve the fixme, and cleans up the commit message to make more sense." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123785 (owner: 10Brion VIBBER) [22:41:39] (03PS1) 10Mhurd: Fixed account creation. Now works with updated api. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/124760 [22:44:23] tfinc: sure thing [22:44:47] jgonera: looks like Krinkle took a look at the patchset but it's now -1'd from jenkins :-/ [22:48:05] (03PS4) 10Cmcmahon: QA: Protect against bug 62030 happening again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116167 (owner: 10Jdlrobson) [22:52:54] YuviPanda: got the acct creation working i think [22:53:26] nevermind you sleep [22:58:18] (03CR) 10Cmcmahon: "After futzing with this for some time I chatted with David Burns of Mozilla on #selenium in IRC and it boils down to a bug in the Selenium" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116167 (owner: 10Jdlrobson) [22:58:57] (03CR) 10Jdlrobson: [C: 032] "WFM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116167 (owner: 10Jdlrobson) [22:59:37]