[00:00:28] MaxSem: doesn't for me :-( Maybe chrismcmahon can test it? [00:00:50] jdlrobson, well - that change still needs to be merged:) [00:01:15] it looks better to me MaxSem i'll do so [00:01:33] (03PS2) 10MaxSem: Fix setcookie() call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124780 [00:01:45] (03PS3) 10Jdlrobson: QA: update upload steps to shared descriptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124779 (owner: 10Cmcmahon) [00:01:49] just a indent fix^ [00:01:51] (03PS4) 10Jdlrobson: QA: update upload steps to shared descriptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124779 (owner: 10Cmcmahon) [00:02:01] (03Abandoned) 10Jdlrobson: Ensure switching to alpha/beta always works. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124044 (owner: 10Jdlrobson) [00:02:04] go MaxSem go :-) [00:02:41] MaxSem: should path be '/' ? [00:02:57] ah wait it's prefix.. ignore [00:03:12] (03CR) 10Jdlrobson: [C: 032] "fingers crossed for the builds" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124780 (owner: 10MaxSem) [00:03:44] (03Merged) 10jenkins-bot: Fix setcookie() call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124780 (owner: 10MaxSem) [00:22:46] (03CR) 10Jdlrobson: [C: 04-1] QA: update upload steps to shared descriptions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124779 (owner: 10Cmcmahon) [00:38:48] (03CR) 10JGonera: [C: 04-1] "If you set the duration of animation to something long (2s) you can see that the right drawer is not actually animated." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124649 (owner: 10Jdlrobson) [00:55:23] MaxSem: did you and jon figure out the cookie/token issue? [00:55:43] waiting for test results [00:55:48] cool [01:12:02] (03CR) 10JGonera: [C: 04-1] "Inline comments and:" (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [05:44:09] (03CR) 10Mattflaschen: "What errors did you hit with the new checkLess.php?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124029 (owner: 10Jdlrobson) [08:12:57] (03PS1) 10Yuvipanda: Move tox.ini up one level to make things easier for jenkins [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 [08:13:21] (03PS2) 10Yuvipanda: Move tox.ini up one level to make things easier for jenkins [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 [08:18:11] (03PS3) 10Yuvipanda: Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 [08:18:14] (03CR) 10jenkins-bot: [V: 04-1] Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 (owner: 10Yuvipanda) [08:22:18] (03PS4) 10Yuvipanda: Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 [08:22:37] (03CR) 10jenkins-bot: [V: 04-1] Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 (owner: 10Yuvipanda) [08:24:10] (03PS5) 10Yuvipanda: Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 [08:24:29] (03CR) 10jenkins-bot: [V: 04-1] Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 (owner: 10Yuvipanda) [08:26:21] (03PS6) 10Yuvipanda: Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 [08:26:26] (03CR) 10jenkins-bot: [V: 04-1] Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 (owner: 10Yuvipanda) [08:26:55] (03PS7) 10Yuvipanda: Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 [08:27:22] (03PS8) 10Yuvipanda: Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 [08:29:33] (03CR) 10Hashar: Fix tox.ini to have appropriate config for flake8 (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 (owner: 10Yuvipanda) [08:31:57] (03PS9) 10Yuvipanda: Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 [08:32:41] (03PS10) 10Hashar: Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 (owner: 10Yuvipanda) [08:33:57] (03CR) 10Hashar: [C: 032] "excellent work! :-]" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 (owner: 10Yuvipanda) [08:40:35] (03CR) 10Hashar: [C: 032] "JenkinsBot was not allowed to submit :(" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 (owner: 10Yuvipanda) [08:40:40] (03Merged) 10jenkins-bot: Fix tox.ini to have appropriate config for flake8 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124797 (owner: 10Yuvipanda) [08:41:06] yuvipanda: and Jenkins can now submit on apps/android/* \O/ [10:02:31] (03PS3) 10Yuvipanda: [WIP] Add a 'User Actions' menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119891 [10:02:33] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add a 'User Actions' menu [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/119891 (owner: 10Yuvipanda) [10:03:10] (03PS1) 10Yuvipanda: [WIP] Added checkstyle.xml config for Java coding style [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124812 [10:03:23] (03PS2) 10Yuvipanda: [WIP] Added checkstyle.xml config for Java coding style [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124812 [10:30:53] (03PS3) 10Yuvipanda: Added checkstyle.xml config for Java coding style [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124812 [11:06:39] (03CR) 10Hashar: [C: 031] "Maybe maven will use it :-)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124812 (owner: 10Yuvipanda) [11:44:16] (03PS4) 10Yuvipanda: [WIP] Added checkstyle.xml config for Java coding style [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124812 [12:46:49] (03PS5) 10Yuvipanda: [WIP] Added checkstyle.xml config for Java coding style [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124812 [16:07:43] (03CR) 10Jdlrobson: "Feedback needed so I can wrap this up." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [16:42:43] (03PS11) 10Jdlrobson: Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [16:44:48] (03CR) 10Jdlrobson: [C: 04-1] "Slight regression on the Special:Contributions page needs taking care of. Shows all my contributions as being by anonymous." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [16:55:29] (03PS1) 10Jdlrobson: Revert "Only offer VisualEditor if installed and enabled" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124881 [16:55:34] (03PS5) 10Cmcmahon: QA: update upload steps to shared descriptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124779 [16:55:51] (03PS2) 10Jdlrobson: Revert "Only offer VisualEditor if installed and enabled" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124881 [16:56:09] (03CR) 10Jdlrobson: [C: 032] Revert "Only offer VisualEditor if installed and enabled" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124881 (owner: 10Jdlrobson) [16:56:36] (03CR) 10jenkins-bot: [V: 04-1] QA: update upload steps to shared descriptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124779 (owner: 10Cmcmahon) [16:56:58] (03Merged) 10jenkins-bot: Revert "Only offer VisualEditor if installed and enabled" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124881 (owner: 10Jdlrobson) [16:59:16] (03PS6) 10Yuvipanda: Added checkstyle.xml config for Java coding style [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124812 [16:59:32] (03PS7) 10Yuvipanda: Added checkstyle.xml config for Java coding style [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124812 [17:00:38] hey brion! [17:00:50] brion: we've jenkins jobs for validating python *and* java now :) [17:01:08] yo [17:01:09] \o/ [17:01:15] brion: it's non voting for now since it still fails [17:01:27] hehe [17:01:46] brion: but the errors are mostly trivial and we can fix them and make it voting in a week or so I think [17:01:53] sweet [17:01:57] brion: also I can now figure out how to setup jenkins jobs ;) [17:02:07] brion: I should setup continuous builds there too. Isn't too hard [17:02:35] brion: https://gerrit.wikimedia.org/r/#/c/124812/ merge? :) [17:02:58] (03CR) 10Brion VIBBER: [C: 032 V: 032] Added checkstyle.xml config for Java coding style [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124812 (owner: 10Yuvipanda) [17:03:07] brion: no need to V+2 ;) [17:03:30] YuviPanda: can you poke https://gerrit.wikimedia.org/r/#/c/123785/ and beyond? thx :D [17:03:43] brion: yeah, let me :) [17:04:34] brion: commit message, Y U NO WRAP [17:04:54] brion: also why is the saved page commit also dealing with scrolling? [17:05:04] YuviPanda: because loading a saved page triggers that code path [17:05:08] iirc [17:05:11] oh, really? [17:07:14] brion: are you in the office today? [17:07:24] no [17:07:35] brion: ah, ok [17:09:12] YuviPanda: gruntjs is pretty cool! [17:09:15] (03CR) 10Jdlrobson: [C: 04-1] "Fix these two issues and I think this is good to merge :)" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124779 (owner: 10Cmcmahon) [17:09:25] mhurd: oh yeah, very :) [17:10:25] mhurd: Today I setup Continuous integration for the android repo. Gerrit won't let you merge it now if it has JS that doesn't match the standards :) [17:10:42] YuviPanda: that’s great! [17:13:07] (03PS6) 10Cmcmahon: QA: update upload steps to shared descriptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124779 [17:13:27] brion: oh, i think acct creation should be fixed: https://gerrit.wikimedia.org/r/#/c/124760/ [17:16:05] brion: YuviPanda: waiting on you guys [17:16:18] i’m in [17:18:10] (03CR) 10JGonera: "Are the buttons bigger for you than in the spec attached to the story card?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [17:22:08] jgonera: i forgot to ask during standup - it looksl ike you marked https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1538 as blocked [17:22:11] what's going on there? [17:25:46] YuviPanda, would you please review and, if appropriate, +2 merge https://gerrit.wikimedia.org/r/#/c/123788/ ? [17:25:50] YuviPanda: so your thinking of just doing the alphas instead of the wed release ? [17:26:23] YuviPanda: we noted a number of issues with the alpha releases during the last retro while the wed releases just work [17:28:02] chrismcmahon: jdlrobson so are we confident enough to close the alpha/beta toggle bug? [17:28:13] awjr: not yet [17:28:23] chrismcmahon: typo! [17:28:27] ok no problem [17:28:34] yurgh, jdlrobson I see it [17:28:39] jdlrobson: was the only thing that's changed is the patch you and MaxSem worked on yesterday? [17:29:19] jdlrobson: I am bad at multitasking [17:29:31] chrismcmahon: i'm fixing :) [17:29:41] chrismcmahon: don't worry i got this one :D [17:29:42] (03PS7) 10Jdlrobson: QA: update upload steps to shared descriptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124779 (owner: 10Cmcmahon) [17:30:03] (03CR) 10Jdlrobson: [C: 032] "\o/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124779 (owner: 10Cmcmahon) [17:30:36] (03Merged) 10jenkins-bot: QA: update upload steps to shared descriptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124779 (owner: 10Cmcmahon) [17:31:22] awjr, the watchlist has to be merged first since they share some css and logic [17:31:31] roger that jgonera, thanks [17:32:57] must find A/C controls in this room or i'll turn into an icicle [17:33:13] dr0ptp4kt: you coming to scrum of scrums? [17:33:23] chrismcmahon: is it possible to create an article only if it doesn't exist in selenium using mediawiki api? [17:33:37] awjr, i guess i am. coming [17:33:51] https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1808 < for this one chrismcmahon it would be great if we create a page with references for the purpose of it [17:33:59] but it would be silly to create a new page on every single test run [17:35:25] (03PS3) 10Jdlrobson: Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 [17:36:40] jdlrobson: what I remember from my earliest work with the API is that if you hit the 'create article' function then if the page does not exist it is created, and if the page does exist it is updated to have the content specified in the API call. if that's still true, it would be ideal for the case you're talking about. [17:37:20] jgonera: do you want to have a look at the notification drawer animation card? I'm a bit stuck on that? Also I posted some questions about the icon change awaiting your feedback. Also I was hoping to start the VE dialog story today but i have no idea where to start with that, I'm not finding it too clear what the expected behavior/outcome is. Will you be in the office this afternoon to get me up to speed with that? [17:37:28] chrismcmahon: perfect :D [17:37:44] jdlrobson, yes to all [17:37:51] jgonera: sweet [17:38:14] I have meetings 11:30-3pm but after 3pm I can help you jdlrobson [17:38:28] ok cool i can keep myself busy in QA land till then [17:47:28] YuviPanda: there? if not, brion, you able to review and +2 https://gerrit.wikimedia.org/r/#/c/123788/ ? yuvi asked me to change to croutons instead of toasts for android. hey, also, when's the next apk going out? i'm hoping it can make it into that [17:48:35] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fixed account creation. Now works with updated api. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/124760 (owner: 10Mhurd) [17:48:43] brion: yay! [17:50:54] dr0ptp4kt: lemme take a peek [17:51:01] brion, thx [17:51:53] (03PS4) 10Brion VIBBER: Turn Wikipedia Zero toasts to croutons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 (owner: 10Dr0ptp4kt) [17:54:03] (03CR) 10Yuvipanda: [C: 04-1] Turn Wikipedia Zero toasts to croutons. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 (owner: 10Dr0ptp4kt) [17:55:00] (03CR) 10Brion VIBBER: Turn Wikipedia Zero toasts to croutons. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 (owner: 10Dr0ptp4kt) [17:55:27] brion: YuviPanda: mmmm… toasty croutons…. [17:56:12] YuviPanda, what name should we use for the element? [17:56:31] dr0ptp4kt: zero_crouton_container? [17:56:46] YuviPanda, cool [17:57:00] (03PS5) 10Brion VIBBER: Turn Wikipedia Zero toasts to croutons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 (owner: 10Dr0ptp4kt) [17:57:25] (03CR) 10Brion VIBBER: "PS5 copies the Holo red/green color definitions to the local color.xml so they'll work on 2.3" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 (owner: 10Dr0ptp4kt) [17:57:35] (03CR) 10Yuvipanda: Turn Wikipedia Zero toasts to croutons. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 (owner: 10Dr0ptp4kt) [17:57:38] dr0ptp4kt: also left other comments [17:58:41] YuviPanda, cool, ah, i see [17:58:54] awjr: I probably won't make it to the vagrant meeting. Can someone send notes afterwards? [17:59:05] no problem YuviPanda [17:59:09] awjr: ty! [17:59:16] we'll keep an etherpad and i'll definitely mail out a summary [17:59:23] awjr: ty! [17:59:35] mhurd: what did you have to fix for account creation? [17:59:36] hi aharoni! [17:59:45] aharoni: did you manage to get the builds? [18:00:09] I just finished our office hour. [18:00:14] going to do it in a few minutes. [18:00:21] aharoni: woot! [18:00:32] YuviPanda: lemme check... [18:02:26] dr0ptp4kt: we have jenkins for the app repo now ;) reports checkstyle issues too [18:05:09] YuviPanda: so i think previously the api was sending both “token” and “captchaId” back, and my code was depending on that i believe. so now i first get the token by just sending server the domain, username, and pwd, then i have a dependent op that does basically what the old one did, but seeding it with the token from the first op. then *that* operation can check for/handle any "captchaId" stuff [18:06:06] YuviPanda: basically now there’s a separate token op, whereas before i did single op [18:07:06] YuviPanda: hope that made sense... [18:10:47] (03PS1) 10Jdlrobson: QA Card 1808: Add browser tests for references!! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124892 [18:10:59] ^ chrismcmahon :D :D [18:17:18] (03PS6) 10Dr0ptp4kt: Turn Wikipedia Zero toasts to croutons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 [18:17:40] ^ YuviPanda, brion - does this do it? [18:18:01] YuviPanda: regarding the jenkins piece, does that include apk builds, too? [18:19:52] hm [18:20:00] is that height in pixels or device-independent pixels? [18:21:08] jdlrobson: got a meeting and lunch here shortly, will look this afternoon [18:21:31] dr0ptp4kt: no builds yet. [18:21:33] brion: in code I think it might be pixels, and have to be multiplied by DP value which is available as a constant in WikipediaApp [18:21:41] dr0ptp4kt: builds should be easily doable now, yeah [18:22:31] YuviPanda: so grunt compiles www to assets… are you pulling www contents from server before each build? [18:22:57] mhurd: www contents live in www for now, the css will move to server at some point.. [18:23:06] (03CR) 10Brion VIBBER: Turn Wikipedia Zero toasts to croutons. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 (owner: 10Dr0ptp4kt) [18:23:11] mhurd: but the end result won't really change. we still need the autoupdate stuff at some point. [18:23:40] YuviPanda: cool. so for now i’ll just do same i guess [18:23:45] mhurd: yeah [18:23:53] YuviPanda: good first step for sure [18:24:18] mhurd: indeed. and I think the auto update stuff won't affect the current work [18:24:26] YuviPanda: cool [18:27:02] YuviPanda: how do you think i should handle things if, say, actions.js or sections.js or whatever need slightly different ios behavior? i obviously want reuse, kinda the point… but if there is divergence? [18:27:25] (03Abandoned) 10Jdlrobson: SpecialMobileWebApp: Cache last call to PageApi in localStorage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/101123 (owner: 10Jdlrobson) [18:27:38] i know the ios gruntfile.js will differ here and there [18:27:40] (03PS1) 10Jdlrobson: QA 1809: Add browser tests for section toggling \o/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124896 [18:28:43] YuviPanda: brb [18:32:36] (03PS1) 10Jdlrobson: Hygiene: Make the tests more browser agnostic! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124899 [18:41:09] (03PS7) 10Dr0ptp4kt: Turn Wikipedia Zero toasts to croutons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 [18:41:41] ^ YuviPanda + brion, i think that does it. i remembered why i was setting the font manually. would you please re-re-review? [18:43:31] YuviPanda + brion, as for doing another apk build so i can provide the url to an operator for their testing lab (i'll also provide alpha instructions), do we have any rebuilds coming up? [18:43:54] didn't want to send the opcos the sprint26 one if we have one coming soon [18:44:05] dr0ptp4kt: I pushed one to alpha yesterday night. [18:44:11] dr0ptp4kt: I think brion will make one today as well? [18:44:50] mhurd: what kind of behavior? if it is *too* divergent we would probably have ios/sections.js and android/section.js and include them, and try to avoid that as much as possible. [18:45:17] mhurd: and we can reuse the same gruntfile, I think. just add an iOS target. That's the point of a build system - to have the same base code files but make multiple target compiles off them [18:48:30] YuviPanda: ya for sure. what about the package.json? [18:48:52] mhurd: dr0ptp4kt did you guys get my messages? [18:48:53] > mhurd: and we can reuse the same gruntfile, I think. just add an iOS target. That's the point of a build system - to have the same base code files but make multiple target compiles off them [18:48:55] was my last one [18:49:24] mhurd: that's just the npm package info file. We can modify the description to get rid of the 'Android' part but otherwise it's ok I think. it is just a build time requirement, not a runtime reqirement [18:49:27] YuviPanda: not sure, please resend [18:49:35] dr0ptp4kt: I pushed one to alpha yesterday night. [18:49:40] dr0ptp4kt: I think brion will make one today as well? [18:49:45] mhurd: what kind of behavior? if it is *too* divergent we would probably have ios/sections.js and android/section.js and include them, and try to avoid that as much as possible. [18:49:47] mhurd: and we can reuse the same gruntfile, I think. just add an iOS target. That's the point of a build system - to have the same base code files but make multiple target compiles off them [18:49:55] (was just resending my messages) [18:50:11] * brion deja vu [18:50:12] YuviPanda: yeah, i saw that. brion, is that right on the apk? i'm hoping we can slip the coutrons into the app salad for the apk, then i'll share that updated apk url [18:50:24] sure i can do that [18:50:29] brion lol [18:50:30] YuviPanda: oh, thx. so yeah, the android text in the package.json being removed answers that question. [18:50:35] brion thx [18:50:48] mhurd: :) [18:51:05] YuviPanda: do you have time to finish up the 2.3 remaining commits review or shall I leave that for the next bump? [18:51:10] YuviPanda: yeah i understand the point of the build system, just wondering how and eventual divergences should be handled [18:51:25] mhurd: yeah, so I think specific files would be the way I'd prefer it rather than if / elses [18:51:47] YuviPanda: so naming convention? [18:52:00] mhurd: js/android/* for android specific ones, js/iOS/* [18:52:13] YuviPanda: k [18:52:23] mhurd: but we should try max to not have that diverge at all [18:52:29] YuviPanda: agreed [18:52:36] (03CR) 10Yuvipanda: [C: 032] [Gingerbread] Partial fixes for 'saved pages' view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123785 (owner: 10Brion VIBBER) [18:52:39] brion: merged one [18:52:41] \o/ [18:52:57] (03Merged) 10jenkins-bot: [Gingerbread] Partial fixes for 'saved pages' view [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123785 (owner: 10Brion VIBBER) [18:53:06] brion: nice to have jenkins do the merges ;) [18:53:13] brion: I am thinking of making the repo require rebase. [18:53:20] (03PS5) 10Yuvipanda: [Gingerbread] Copy some theme attributes directly that aren't available on v10 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123787 (owner: 10Brion VIBBER) [18:53:21] mmmm jenkins [18:53:50] YuviPanda: works for me, usually get cleaner commits that way [18:53:56] YuviPanda: i’ll approach any divergences as temporary, with intent to resolve as time permits [18:54:13] mhurd: hmm, ok. [18:54:28] YuviPanda: not saying there will be any, but just in case [18:54:50] YuviPanda: and i’ll ping you if i find any [18:55:03] mhurd: ok :) But we should avoid if / else random bits of code no matter what :) Any divergences should be handled at the build level and not at the runtime level [18:55:47] YuviPanda: yeah yeah, whole point of the build system etc :) [18:55:53] mhurd: :) sweet! [18:57:01] brion: are you gonna merge dr0ptp4kt's crouton patch? [18:57:21] sure, unless you prefer to :D [18:57:33] brion: nah, I'm looking at the GB patches now [18:57:44] ok moment [18:57:56] (03PS4) 10Yuvipanda: [Gingerbread] List layout for settings language selector is v11 again, have to duplicate it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124364 (owner: 10Brion VIBBER) [18:58:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] "mmmmm toast" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123788 (owner: 10Dr0ptp4kt) [18:58:26] (03CR) 10Yuvipanda: [C: 032] [Gingerbread] Copy some theme attributes directly that aren't available on v10 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123787 (owner: 10Brion VIBBER) [18:58:31] (03CR) 10jenkins-bot: [V: 04-1] [Gingerbread] Copy some theme attributes directly that aren't available on v10 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123787 (owner: 10Brion VIBBER) [18:58:33] brion: V+2 again :P [18:58:45] (03CR) 10Yuvipanda: [C: 032] [Gingerbread] List layout for settings language selector is v11 again, have to duplicate it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124364 (owner: 10Brion VIBBER) [18:58:47] (03CR) 10jenkins-bot: [V: 04-1] [Gingerbread] Copy some theme attributes directly that aren't available on v10 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123787 (owner: 10Brion VIBBER) [18:58:47] heh [18:58:49] (03CR) 10jenkins-bot: [V: 04-1] [Gingerbread] List layout for settings language selector is v11 again, have to duplicate it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124364 (owner: 10Brion VIBBER) [18:58:56] brion: that messed up jenkins' merges :( [18:59:00] what have we doooooone [18:59:32] brion: they need manual reabsing now, apparently [18:59:44] lol [18:59:44] brion: rebasing [19:01:30] YuviPanda: what should i do about the “oldDroidPolyfills” stuff? [19:01:57] mhurd: ignore it, I'll make that conditional in a moment. [19:02:16] YuviPanda: oh cool. can u update the package.json too? [19:02:39] brion: the rebase seems a bit messy, can you do a manual rebase? [19:03:10] sure sec [19:04:27] (03PS6) 10Brion VIBBER: [Gingerbread] Copy some theme attributes directly that aren't available on v10 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123787 [19:04:35] YuviPanda: how’s that? [19:05:05] (03PS5) 10Brion VIBBER: [Gingerbread] List layout for settings language selector is v11 again, have to duplicate it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124364 [19:05:17] (03CR) 10Yuvipanda: [C: 032] [Gingerbread] Copy some theme attributes directly that aren't available on v10 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123787 (owner: 10Brion VIBBER) [19:05:38] YuviPanda: sorry about the flood of questions :) are you just manually excluding the “node_modules” folder for git? [19:06:08] should prolly stick that in .gitignore [19:06:22] (03Merged) 10jenkins-bot: [Gingerbread] Copy some theme attributes directly that aren't available on v10 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/123787 (owner: 10Brion VIBBER) [19:06:44] mhurd: yup! it should be in .gitignore, I think? [19:06:52] brion: YuviPanda: perfect [19:07:04] just double checking [19:07:33] mhurd: :) I'll be around for another hour so feel free to pester [19:07:39] YuviPanda: haha thanks! [19:11:05] brion: let me know when you've rebased the final patch [19:13:48] YuviPanda: should be already i think? [19:13:55] there’s one last one that’s abandoned, don’t merge that one :) [19:14:25] (03CR) 10Yuvipanda: [C: 032] [Gingerbread] List layout for settings language selector is v11 again, have to duplicate it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124364 (owner: 10Brion VIBBER) [19:14:33] whee [19:16:30] (03Merged) 10jenkins-bot: [Gingerbread] List layout for settings language selector is v11 again, have to duplicate it [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124364 (owner: 10Brion VIBBER) [19:16:51] whee [19:17:08] brion: that's all the gb patches for now? [19:17:14] yeah [19:17:21] brion: I'll move it to ready for sign off after doing a run through with 2.3 tomorrow [19:17:28] ok [19:18:43] brion: https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/ has chart and stuff of our checkstyle errors [19:20:00] nice [19:20:24] brion: push out an alpha too when you make the build :) [19:21:29] jdlrobson, I get "No such page" message when I try to access Special:Contributions on mobile [19:22:00] jgonera: beta? http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson [19:22:12] mhurd: you want to try doing a build/testflight release now or shall we try it later? :) [19:22:25] http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson?mobileaction=beta to be specific [19:22:30] YuviPanda: which button do i push for alpha release? i haven’t used that interface before [19:22:30] brion: ya if you have time that be great! [19:22:34] ah ok, I need to provide user name ;) [19:22:35] spiff [19:22:42] lemme finish uploading this apk [19:23:00] brion: under apk there's an 'alpha testing' tab [19:23:09] brion: be very sure to upload only to alpha testing :) [19:23:20] brion: also increment the version number and the date version string [19:23:28] heh [19:23:33] bah d’oh [19:24:26] YuviPanda: The new build is much better. [19:24:33] aharoni: woot! [19:24:36] (03PS1) 10Brion VIBBER: bump version number for alpha update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124913 [19:24:48] YuviPanda: like that? [19:24:55] (03PS1) 10Yuvipanda: Remove sole tab character [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124914 [19:25:01] jdlrobson, so we want to show no user name there? [19:25:20] brion: what's 'bis'? :) [19:25:22] well it's at the top so it's unnecessary - but you'd have to check with kaity to be sure :) [19:25:44] YuviPanda: “Bis is a prefix or suffix designating the second instance of a thing, thus preceding ter. An example in recent modern usage is the ITU-T modem standard from the late 20th century, V.32bis." [19:25:50] brion: :D alright! [19:25:51] YuviPanda: I couldn't find any RTL issues there, at least in the most common functions: viewing, basic editing, and menus. [19:26:00] i guess the last 20th century is no longer “recent modern” ;) [19:26:04] jdlrobson, we haven't done any official design work on this right? so I'll just assume whatever is easier for now [19:26:05] (03CR) 10Yuvipanda: [C: 032] bump version number for alpha update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124913 (owner: 10Brion VIBBER) [19:26:06] aharoni: woooot! [19:26:06] * brion remembers his modems well [19:26:17] jgonera: correct but it's linked to from Special:UserProfile [19:26:23] so it may impact pushing that to stable [19:26:27] aharoni: where else do you think they might be hiding? [19:26:32] ok, so I'll do whatever was there before [19:26:38] there was no user name before, right [19:26:39] ? [19:26:47] YuviPanda: Really nothing I can think of now. [19:26:53] aharoni: woot! [19:27:01] I tried going to a different language and it worked well, too. [19:27:02] aharoni: wow, nice feeling, that :) [19:27:19] Thanks for all the fixes, YuviPanda , brion and everybody else. [19:27:24] :D yayyy [19:27:47] aharoni: :D [19:27:57] (03Merged) 10jenkins-bot: bump version number for alpha update [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124913 (owner: 10Brion VIBBER) [19:28:05] jdlrobson, is there any place where feed view is used without a title (with user name being the title)? [19:28:21] aharoni: much better start than the previous app :) [19:28:42] aharoni: did you try login and create account? and captcha when editing? [19:28:42] history page [19:28:45] oh man i hate it when i accidentally log in with the wrong account on the google play dev console [19:28:49] aharoni: create account is broken atm [19:28:57] YuviPanda: oh, no, I didn't. I'll try. [19:29:19] http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:History/San_Francisco?mobileaction=beta < jgonera [19:29:35] ok upload new apk to alpha… [19:30:11] I'll just style it the same way everywhere since that's what is going to happen anyway in the upcoming story [19:30:21] aharoni: ok! [19:31:50] ok apk should be up.... [19:32:06] mhurd: let’s try testflight. :D wanna try it blind over irc or should we screenshare on hangout? [19:33:26] brion: hehe maybe hangout? lemme find room... [19:33:31] ok :D [19:34:03] i’ll coffee up, moment [19:34:15] brion: k [19:35:37] (03PS1) 10Yuvipanda: Fix ordering of visibility modifiers to match JLS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124917 [19:39:26] (03PS1) 10Yuvipanda: Organize imports & remove a redundant import [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124961 [19:39:33] ah, the nectar of life. caffeiiiiiine [19:40:32] (03PS1) 10Yuvipanda: Explicitly use braces everywhere [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124976 [19:40:34] (03PS12) 10JGonera: Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 [19:41:14] jdlrobson: \o/ API call works the way it should. http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Selenium_References_test_page&action=history (just be careful about pointing it to prod wikis) [19:41:28] :D yep agreed [19:41:34] having lots of fun with it hehe :) [19:42:30] (03PS1) 10Yuvipanda: Use Java style array declarations than C style [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124983 [19:44:20] jdlrobson, watchlist patchset should be fine now, I checked watchlist in stable/beta, page history and contributions [19:45:25] YuviPanda: on the create account screen there's a paper plane button on the top of the screen. [19:45:38] if it's supposed to be like an arrow, it should point the other way. [19:45:52] Also, the app crashed when I tapped it. [19:45:55] aharoni: yeah, it is going to be replaced with a 'tick' at some point, and it will be properly mirrored (the image itself) [19:46:07] aharoni: create account is a known bug, should be fixed today or tomorrow [19:46:18] Oh, and now I see wonderful "Send Yuvi a report" dialog :) [19:46:32] aharoni: also I see that text hint on RTL is wrong way around for password text fields. Seems to be an android bug, nothing I can do about it :( [19:46:37] aharoni: :D please do send! [19:46:40] aharoni: it goes to OTRS now [19:48:20] (03PS1) 10Yuvipanda: Properly format multiline boolean checks to be more consistent [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124986 [19:49:38] (03PS1) 10Yuvipanda: Ensure that Utils class can't be instantiated [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124987 [19:50:44] (03PS1) 10Yuvipanda: Make sure that all member variables are camelCase [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124988 [19:54:33] (03PS1) 10Yuvipanda: Remove space inside array initializers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124992 [19:54:37] brion: when you're done with the release, look at the patches I've put up :) [19:54:46] brion: reducing error count with checkstyle [19:54:55] ok [19:56:55] (03PS2) 10Yuvipanda: Make sure that all member variables are camelCase [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124988 [19:56:57] (03PS2) 10Yuvipanda: Ensure that Utils class can't be instantiated [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124987 [19:56:59] (03PS2) 10Yuvipanda: Remove space inside array initializers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124992 [19:57:04] jgonera: sweet thanks [19:58:42] (03PS1) 10Yuvipanda: Remove redundant public and static modifiers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124996 [20:01:26] awjr|lunch: do we have a meeting now? [20:01:35] jdlrobson: yep [20:06:17] we got a beta release on testflight \o/ [20:09:13] http://hatjitsu.wmflabs.org/ [20:09:17] http://hatjitsu.wmflabs.org/70143 [20:17:37] (03PS1) 10Yuvipanda: Ensure that all constants are named ALL_UPPERCASE [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125000 [20:19:02] (03PS1) 10Yuvipanda: Remove stray spaces inside parens [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125001 [20:21:00] (03PS1) 10Yuvipanda: Ensure that there is always a space after a comma [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125002 [20:24:42] (03PS1) 10Yuvipanda: Check that static variables are always all caps [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125003 [20:34:18] aharoni: any luck with captcha? [20:34:31] YuviPanda: where am I even supposed to see it? [20:34:48] aharoni: 1. be anonymous (log out) 2. add an external link to testwiki or enwiki 3. try to save [20:39:08] jgonera: http://code.flickr.net/2012/06/01/parsing-exif-client-side-using-javascript-2/ "Creating an Exif parser is no simple task, but there are a few things to consider:" [20:46:02] Yuvi: can the app just copy how MFE handles nonexistent pages? [20:46:03] brion: am gonna head to sleep shortly. [20:46:10] ok [20:46:17] need me to poke anything? [20:46:20] ragesoss: how does MFE handle nonexistant pages? [20:46:38] brion: there are a lot of commits :D almost all minor, but jenkins-bot is a bit broken, and I've filed a bug [20:46:40] Picture of Rory! [20:46:47] great, i’ll poke em over in a bit [20:47:00] ragesoss: http://en.m.wikipedia.org/wiki/Testestaesdt looks not too great [20:47:38] ragesoss: and also a fair bit more work to do :D we don't actually have 'search within pages' anywhere [20:48:55] ragesoss: I do like the picture of rory idea, though. Need to find a suitable pic :( [20:49:20] Yuvi: try with Experimental enabled. [20:50:13] Never mind. [20:50:45] ragesoss: still seeing the same thing [20:50:50] Maybe that's just for real valid URLs like special pages that mfe doesn't handle. [20:51:07] right. [20:51:16] I've to also figure out what to do with url handling for special pages [20:51:23] think I'll just bounce it out to MF via a rewritten URL [20:53:17] Anyhow, yeah, just a "does not exist" msg is good for now. [20:53:33] ragesoss: yeah [20:53:40] Goodnight! [20:54:06] ragesoss: night! [20:56:10] brion: the patches that jenkins-bot has +2'd can still be merged :) I'll follow up with hashar about the rest tomorrow [20:56:13] * zz_yuvipanda goes to sleep for realz [20:57:05] (03CR) 10Cmcmahon: [C: 032] "I made a bug for QA to refactor the duplicate code out of /tests/browser/features/step_definitions/create_page_api_steps.rb later on" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124892 (owner: 10Jdlrobson) [20:57:48] (03Merged) 10jenkins-bot: QA Card 1808: Add browser tests for references!! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124892 (owner: 10Jdlrobson) [21:10:06] (03PS2) 10Jdlrobson: Hygiene: Make the tests more browser agnostic! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124899 [21:10:08] (03PS2) 10Jdlrobson: QA 1809: Add browser tests for section toggling \o/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124896 [21:10:10] (03PS1) 10Jdlrobson: QA: Make the majority of tests environment agnostic [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 [21:10:13] ^ chrismcmalunch :D [21:10:30] Is there a way using the API to create a protected page? [21:10:46] jdlrobson: no idea [21:10:51] I want to kill the need for the Barack Obama article :) [21:11:24] wait… maybe that's not needed either [21:19:32] (03PS2) 10Jdlrobson: QA: WIP Make the test environment agnostic of existing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 [21:19:50] ^ chrismcmahon could do with some helping kill on the latter TODO [21:20:18] (03CR) 10Cmcmahon: [C: 032] QA 1809: Add browser tests for section toggling \o/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124896 (owner: 10Jdlrobson) [21:20:51] (03Merged) 10jenkins-bot: QA 1809: Add browser tests for section toggling \o/ [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124896 (owner: 10Jdlrobson) [21:22:52] chrismcmahon: where is the source code for mediawiki_api ? [21:25:33] jdlrobson: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/ruby/api [21:26:49] thanks chrismcmahon [21:33:26] chrismcmahon: https://gerrit.wikimedia.org/r/125010 < untested... [21:34:12] (03PS3) 10Jdlrobson: QA: Make the test environment agnostic of existing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 [21:34:17] ^ chrismcmahon that uses it [22:01:07] brion, okay for me to share the https://releases.wikimedia.org/mobile/android/apps-android-wikipedia-sprint28.apk url witth the operator people? [22:01:49] brion: hey quick question - if i rename “Wikipedia-iOS” folder to “wikipedia” (to make it easier to sync up with gruntjs) would that mess up the l10n stuff much? [22:01:58] dr0ptp4kt: go for it [22:02:04] brion thx [22:02:14] mhurd: I think we’d have to change the configuration yeah [22:02:16] but that’s not super hard [22:03:00] brion: cool. i think i have the app working with the folder renamed (used this for a guide http://stackoverflow.com/a/16518071/135557) [22:03:50] brion: so you’d just have to change the stuff that takes the incoming translations and puts them in the proj? [22:06:59] mhurd: yeah. i’ll poke the appropriate bits for translation after merging your changes [22:07:11] brion: awesome! thanks! [22:08:34] :D [22:14:47] (03CR) 10Theopolisme: "Sorry, could you explain this? I'm not sure I understand what you mean by "since VisualEditor is not loaded by default"...does the check n" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124881 (owner: 10Jdlrobson) [22:22:15] (03CR) 10Jdlrobson: "Sure.. So we load no JavaScript related to VisualEditor at the start of the browsing session. When the edit button is clicked a call to mw" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124881 (owner: 10Jdlrobson) [22:34:24] (03CR) 10Theopolisme: "Ah, makes perfect sense in fact :P" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124881 (owner: 10Jdlrobson) [22:39:42] awjr: frustrating: https://bugzilla.wikimedia.org/show_bug.cgi?id=62614#c58 [22:41:19] awjr: it's as if something insists on keeping a token alive for ~30s after the process that needs the token is gone [22:43:49] >_< [22:44:00] jdlrobson: are you around? got a totally off-topic request [22:44:29] chrismcmahon: do you think some dedicated focus time between you, jdlrobson and chris steipp might help you get to the bottom of this? [22:44:45] we really need to move past this stupid thing [22:49:24] awjr: I'm about ready to put on my gerrit commit history boots. [22:49:58] chrismcmahon: those must be some serious boots [22:50:19] chrismcmahon: but i must confess, i don't really understand why you're putting these boots on? [22:51:07] awjr: it's tedious, but I can narrow the time when this started happening. then using that time, I can go sort through what was committed in the interval, which is also tedious. but hey, there it is. [22:51:30] roger that, that sounds good [22:51:56] awjr: I pinged csteipp over in -dev [22:52:05] awesome chrismcmahon and i just sent out an email [22:55:59] brion: have a few minutes to see if this branch (https://github.com/montehurd/apps-ios-wikipedia/tree/jsCssSync) renaming the “Wikipedia-iOS” to “wikipedia” seems ok? [22:56:08] looking [22:56:27] brion: i accidentally amended it to have the copyright changes too… sorry about that noise [22:56:44] heh no worries [22:59:02] mhurd: seems to build ok [22:59:09] awjr: we never saw the token problem before ~1month ago or so, MF is triggering something deep somewhere that no other repo is. [22:59:50] chrismcmahon: if you can reliably repro the bug locally, git bisect should help [22:59:55] brion: so many changes i’m afraid i missed something… but i guess using it’s the only way to find out [23:00:55] hehe [23:04:32] chrismcmahon: sure i'm here [23:05:45] jdlrobson: at some point could you show James Forrester how you're doing browser tests? and/or answer his questions about how to do them for VE? [23:06:00] sure thing. does James_F have any particular problems? [23:06:34] jdlrobson: vagrant enable-role browsertest && vagrant provision => non-functional vagrant instance. [23:06:35] jdlrobson: that is why a f2f thing I think would be useful, the bandwidth has been an issue, I'm not sure what the particular problems might be [23:06:54] sure James_F feel free to pencil in some time with me - maybe tomorrow/Friday? [23:07:01] James_F: i'm not using vagrant though ;-) [23:07:02] jdlrobson: Tomorrow could work. [23:07:12] jdlrobson: That'd be why you can get them to work, probably. [23:07:37] jdlrobson: AFAICT the vagrant image continues to be completely broken, and beyond my fixing. :-( [23:07:40] MaxSem: chrismcmahon awjr what does "wfSetupSession" do? [23:07:42] awjr: you about? [23:08:01] jdlrobson, initializes a session... [23:08:24] James_F: the enable-role in Ori's vagrant is probably obsolete. if you start with a regular vagrant image and just install/clone it wouldn't take long [23:08:39] MaxSem: so for an anonymous user will getMobileToken always generate a new one on beta labs potentially? [23:09:26] basically i'm wondering if for some reason the wsMobileToken session data gets killed on cloudbees causing the issue with opting into alpha [23:09:51] chrismcmahon: I tried this from my regular MW-vagrant and a new from-scratch MW-vagrant instance, without success. [23:10:43] jdlrobson, it gets called only when there's no token in current session [23:11:00] James_F: got it. that's why I'm suggesting you work with someone there in SF and jdlrobson has a lot of experience in recent times [23:11:21] chrismcmahon: Thanks. :-) [23:12:46] jdlrobson: not just Cloudbees, it's killing me locally, no Cloudbees involved [23:12:50] (03PS1) 10Jdlrobson: Opt into alpha after login [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125022 [23:12:58] ^ chrismcmahon can you try that patch [23:13:09] i'm wondering if we switched the order of these statements and that's what caused the issue [23:13:12] another stab in the dark :) [23:13:22] jdlrobson: worth trying, one sec... [23:14:35] jdlrobson: I'd still like to know the root cause, it did just show up about a month ago [23:21:22] chrismcmahon: sure [23:21:28] but if we can narrow it down to anonymous users.. [23:22:28] jdlrobson: running it a few times now [23:24:16] (03CR) 10Jdlrobson: [C: 032] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [23:26:59] (03CR) 10jenkins-bot: [V: 04-1] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [23:27:16] MaxSem: any issues with https://gerrit.wikimedia.org/r/#/c/124657// [23:30:07] jdlrobson awjr brilliant. 3 runs, 3 passes for https://gerrit.wikimedia.org/r/#/c/125022/ . doesn't fix the bug, but does fix the tests [23:32:06] huh [23:32:07] interesting [23:32:20] awjr: it kind of makes sense if you look at MobileContext::getMobiletoken [23:33:17] $token = $this->getRequest()->getSessionData( 'wsMobileToken' ) === null we do wfSetupSession when the user is anonymous [23:33:45] im trying to remember why we do that custom token handling stuff [23:33:46] and i cant [23:34:23] anyone about that can do quick hangout test with me? i've had inconsistent results today [23:36:45] (03CR) 10MaxSem: Card 1757: Add EventLogging to Special:MobileOptions (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124657 (owner: 10Jdlrobson) [23:38:49] (03CR) 10MaxSem: Card 1757: Add EventLogging to Special:MobileOptions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124657 (owner: 10Jdlrobson) [23:39:54] (03CR) 10MaxSem: Card 1757: Add EventLogging to Special:MobileOptions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124657 (owner: 10Jdlrobson) [23:40:15] sorry for spamming, my comments are flowing slowly...:) [23:42:28] (03PS1) 10Jdlrobson: Fix line height for edit summary on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125037 [23:43:29] (03CR) 10jenkins-bot: [V: 04-1] Fix line height for edit summary on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125037 (owner: 10Jdlrobson) [23:43:52] (03PS4) 10Jdlrobson: QA: Make the test environment agnostic of existing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 [23:44:30] (03Abandoned) 10Jdlrobson: Hygiene: Make the tests more browser agnostic! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124899 (owner: 10Jdlrobson) [23:45:14] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125037 (owner: 10Jdlrobson) [23:46:09] awjr: MaxSem can we merge https://gerrit.wikimedia.org/r/#/c/125022/ on the short term then? [23:46:15] it would be lovely to wake up to green tests tomorrow [23:46:17] (03CR) 10MarkTraceur: "Cool patch number bro" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125000 (owner: 10Yuvipanda) [23:47:35] (03CR) 10MaxSem: [C: 032] Opt into alpha after login [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125022 (owner: 10Jdlrobson) [23:48:06] (03Merged) 10jenkins-bot: Opt into alpha after login [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125022 (owner: 10Jdlrobson)