[00:06:44] (03PS1) 10Jdlrobson: Don't show language button after edit when no languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125044 [00:08:03] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [00:08:40] (03CR) 10jenkins-bot: [V: 04-1] Don't show language button after edit when no languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125044 (owner: 10Jdlrobson) [00:19:53] (03CR) 10Addshore: [C: 032] Remove sole tab character [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124914 (owner: 10Yuvipanda) [00:20:50] (03Merged) 10jenkins-bot: Remove sole tab character [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124914 (owner: 10Yuvipanda) [00:21:07] (03CR) 10Addshore: [C: 032] Fix ordering of visibility modifiers to match JLS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124917 (owner: 10Yuvipanda) [00:21:31] (03Merged) 10jenkins-bot: Fix ordering of visibility modifiers to match JLS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124917 (owner: 10Yuvipanda) [00:21:33] chris went? :( [00:21:44] i can't wait to see if thes tests go green [00:22:15] (03CR) 10Jdlrobson: Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [00:22:22] (03PS13) 10Jdlrobson: Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [00:22:27] (03CR) 10Jdlrobson: [C: 032] Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [00:23:07] (03Merged) 10jenkins-bot: Story 1790: Mobile watchlist changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123507 (owner: 10JGonera) [00:26:29] (03CR) 10Addshore: [C: 04-1] "A patch has been merged getting rid of these tab characters." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/98579 (owner: 10Brion VIBBER) [00:29:07] (03PS2) 10Jdlrobson: Don't show language button after edit when no languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125044 [00:30:23] jgonera: https://gerrit.wikimedia.org/r/123474 [00:30:27] please can we get this merged assap [00:30:29] i thought we had [00:30:36] i wanted to get it in for next deploy [00:30:39] to collect some data [00:30:46] (03PS3) 10Jdlrobson: EventLog profile and history link clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123474 [00:31:00] eek where did you go argz [00:31:14] dr0ptp4kt: around [00:32:43] yurikR: yep. whatup [00:33:28] weird [00:34:27] yurikR: one moment [00:35:17] yurikR: see email [00:35:48] yurikR: on its way [00:36:01] thx! [00:48:42] (03CR) 10JGonera: [C: 04-1] "Sorry, too many problems with this..." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123474 (owner: 10Jdlrobson) [02:18:15] (03PS1) 10Yurik: python scripts to upload zero configs [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/125068 [02:19:41] (03PS2) 10Yurik: python scripts to upload zero configs [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/125068 [02:20:08] (03CR) 10Yurik: [C: 032] python scripts to upload zero configs [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/125068 (owner: 10Yurik) [02:20:10] (03Merged) 10jenkins-bot: python scripts to upload zero configs [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/125068 (owner: 10Yurik) [08:56:47] (03PS2) 10Yuvipanda: Check that static variables are always all caps [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125003 [08:56:49] (03PS3) 10Yuvipanda: Make sure that all member variables are camelCase [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124988 [08:56:51] (03PS2) 10Yuvipanda: Ensure that there is always a space after a comma [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125002 [08:56:53] (03PS2) 10Yuvipanda: Remove stray spaces inside parens [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125001 [08:56:55] (03PS2) 10Yuvipanda: Ensure that all constants are named ALL_UPPERCASE [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125000 [08:56:58] (03PS2) 10Yuvipanda: Properly format multiline boolean checks to be more consistent [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124986 [08:56:59] (03PS3) 10Yuvipanda: Ensure that Utils class can't be instantiated [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124987 [08:57:01] (03PS3) 10Yuvipanda: Remove space inside array initializers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124992 [08:57:03] (03PS2) 10Yuvipanda: Use Java style array declarations than C style [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124983 [08:57:05] (03PS2) 10Yuvipanda: Explicitly use braces everywhere [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124976 [08:57:07] (03PS2) 10Yuvipanda: Organize imports & remove a redundant import [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124961 [08:57:09] (03PS2) 10Yuvipanda: Remove redundant public and static modifiers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124996 [08:59:12] addshore: thanks for the merges! :D [08:59:22] addshore: I'm going to try to get those checkstyle errors to zero in the next week and then we can make it voting [09:00:37] :) [09:00:40] yuvipanda: no problem :) [09:00:59] addshore: I fixed jenkins [09:01:41] (03CR) 10Addshore: [C: 032] Ensure that there is always a space after a comma [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125002 (owner: 10Yuvipanda) [09:02:59] (03CR) 10Addshore: [C: 032] Organize imports & remove a redundant import [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124961 (owner: 10Yuvipanda) [09:03:22] (03CR) 10Addshore: [C: 032] Explicitly use braces everywhere [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124976 (owner: 10Yuvipanda) [09:05:06] (03CR) 10Addshore: [C: 032] Use Java style array declarations than C style [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124983 (owner: 10Yuvipanda) [09:06:52] (03CR) 10Addshore: [C: 032] Properly format multiline boolean checks to be more consistent [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124986 (owner: 10Yuvipanda) [09:08:20] (03CR) 10Addshore: [C: 032] Ensure that Utils class can't be instantiated [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124987 (owner: 10Yuvipanda) [09:09:01] (03CR) 10Addshore: [C: 032] Make sure that all member variables are camelCase [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124988 (owner: 10Yuvipanda) [09:09:19] (03CR) 10Addshore: [C: 032] Remove space inside array initializers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124992 (owner: 10Yuvipanda) [09:14:54] (03CR) 10Addshore: [C: 032] Remove redundant public and static modifiers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124996 (owner: 10Yuvipanda) [09:15:37] (03CR) 10Addshore: [C: 032] Ensure that all constants are named ALL_UPPERCASE [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125000 (owner: 10Yuvipanda) [09:16:33] (03PS3) 10Addshore: Remove stray spaces inside parentheses [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125001 (owner: 10Yuvipanda) [09:16:40] (03CR) 10Addshore: [C: 032] Remove stray spaces inside parentheses [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125001 (owner: 10Yuvipanda) [09:16:50] (03PS3) 10Addshore: Check that static variables are always all caps [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125003 (owner: 10Yuvipanda) [09:17:31] addshore: jenkinsbot is broken again, it isn't merging them yet :( [09:17:47] broken how? pre merg checks stuff? [09:18:00] https://gerrit.wikimedia.org/r/#/c/125003/3/checkstyle.xml [09:18:11] addshore: it isn't being triggered. [09:18:16] addshore: hashar was debugging [09:18:16] (03CR) 10Addshore: [C: 032] Check that static variables are always all caps [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125003 (owner: 10Yuvipanda) [09:18:36] hashar: around? :D [09:19:09] addshore: yeah [09:19:11] zuul broken [09:19:14] :D [09:19:18] filled https://bugzilla.wikimedia.org/show_bug.cgi?id=63760 about it [09:19:20] it started gate-and-ausbmit jobs [09:19:21] I am taking traces [09:19:36] * yuvipanda cc's self [09:21:11] looks yummy :) [09:21:30] yuvipanda: I'll just leave them all with +2 for now ;p [09:21:45] addshore: yeah :D I'll get them merged when jenkins comes back [09:21:48] :) [09:24:04] yuvipanda: addshore: it is processing again [09:24:09] woo! [09:24:12] there is some bug around :] [09:24:43] or maybenot [09:25:32] ty hashar : D [09:25:54] oh :P [09:26:19] has it stopped again? [09:26:30] hashar: it looks like it is, but its doing them in an odd order ;p [09:26:55] the apps-android-wikipedia-tox-flake8 is stuck still [09:27:24] it ran on 4 patchsets! [09:27:31] yeah for some reason [09:27:43] but the patches that were blocked previously are still stuck :/ [09:29:55] (03Merged) 10jenkins-bot: Ensure that there is always a space after a comma [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125002 (owner: 10Yuvipanda) [09:30:06] unstuck again? :P [09:31:04] jenkins trippin [09:31:38] (03Merged) 10jenkins-bot: Organize imports & remove a redundant import [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124961 (owner: 10Yuvipanda) [09:31:40] (03Merged) 10jenkins-bot: Explicitly use braces everywhere [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124976 (owner: 10Yuvipanda) [09:32:12] addshore: do you have an android device? :D [09:32:21] I have 3 ;p [09:34:45] addshore: are you on the alpha release of the app? :) [09:34:57] Im on the something release *looks* [09:35:02] addshore: http://lists.wikimedia.org/pipermail/mobile-l/2014-March/006642.html [09:35:53] There is no group named “wpandroidapptesters.”. [09:36:07] heh, guess there should be no . there ;p [09:36:36] addshore: yeah, I need to move that to a wiki page [09:36:43] heh, and jenkins dead again [09:37:26] signed up yuvipanda :) [09:37:30] addshore: woot! [09:37:34] *waits for the update* [09:37:39] how often is the alpha updated? [09:37:49] (03Merged) 10jenkins-bot: Use Java style array declarations than C style [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124983 (owner: 10Yuvipanda) [09:37:52] (03Merged) 10jenkins-bot: Properly format multiline boolean checks to be more consistent [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124986 (owner: 10Yuvipanda) [09:37:55] (03Merged) 10jenkins-bot: Ensure that Utils class can't be instantiated [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124987 (owner: 10Yuvipanda) [09:37:57] (03Merged) 10jenkins-bot: Make sure that all member variables are camelCase [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124988 (owner: 10Yuvipanda) [09:37:57] addshore: every couple of days usually [09:38:01] spam comming in [09:38:04] :D [09:38:06] <3 spam [09:38:10] +1 spam [09:38:17] (03Merged) 10jenkins-bot: Remove space inside array initializers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124992 (owner: 10Yuvipanda) [09:38:17] addshore: let me know when you get the new one :) [09:38:20] (03Merged) 10jenkins-bot: Remove redundant public and static modifiers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/124996 (owner: 10Yuvipanda) [09:38:22] (03Merged) 10jenkins-bot: Ensure that all constants are named ALL_UPPERCASE [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125000 (owner: 10Yuvipanda) [09:38:25] (03Merged) 10jenkins-bot: Remove stray spaces inside parentheses [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125001 (owner: 10Yuvipanda) [09:38:41] 1 left! [09:38:44] addshore: what devices do you have? [09:38:57] (03Merged) 10jenkins-bot: Check that static variables are always all caps [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125003 (owner: 10Yuvipanda) [09:39:05] addshore: all merged! \o/ [09:39:07] addshore: thank you :) [09:39:19] addshore: I'll try to fix more, but also feel free to submit patches that fix warnings :D [09:39:44] HTC Desire C, 2x Nexus 7, SanFransisco 2 (ZTE Blade 2 i think?) [09:40:01] though currently only have the app on a nexus7 [09:41:12] addshore: ah, right. [09:41:37] (03PS1) 10Yuvipanda: Fix checkstyle.xml to allow underscores in static var names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125109 [09:41:39] (03CR) 10jenkins-bot: [V: 04-1] Fix checkstyle.xml to allow underscores in static var names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125109 (owner: 10Yuvipanda) [09:44:11] (03PS2) 10Yuvipanda: Fix checkstyle.xml to allow underscores in static var names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125109 [09:44:58] (03PS1) 10Yuvipanda: Fix static variable names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125110 [09:45:00] (03CR) 10jenkins-bot: [V: 04-1] Fix static variable names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125110 (owner: 10Yuvipanda) [09:45:12] (03PS2) 10Yuvipanda: Fix static variable names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125110 [09:45:16] addshore: ^ moar patches! [09:47:12] (03PS1) 10Yuvipanda: Neuter stray whitespace before semicolon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125111 [09:48:32] (03CR) 10Addshore: [C: 032] Fix checkstyle.xml to allow underscores in static var names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125109 (owner: 10Yuvipanda) [09:48:46] (03PS1) 10Yuvipanda: Remove redundant 'final' qualifiers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125112 [09:48:49] (03Merged) 10jenkins-bot: Fix checkstyle.xml to allow underscores in static var names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125109 (owner: 10Yuvipanda) [09:50:31] (03CR) 10Addshore: [C: 032] Fix static variable names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125110 (owner: 10Yuvipanda) [09:50:42] (03CR) 10Addshore: [C: 032] Neuter stray whitespace before semicolon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125111 (owner: 10Yuvipanda) [09:50:51] (03Merged) 10jenkins-bot: Fix static variable names [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125110 (owner: 10Yuvipanda) [09:51:03] (03Merged) 10jenkins-bot: Neuter stray whitespace before semicolon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125111 (owner: 10Yuvipanda) [09:51:03] urm yuvipanda https://gerrit.wikimedia.org/r/#/c/125112/ [09:51:28] oh fuck [09:51:31] xD [09:51:50] damn vim [09:51:52] (03PS1) 10Yuvipanda: Remove redundant 'final' qualifiers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125114 [09:52:17] PS1?+ [09:52:27] O_o [09:52:36] you made a new changeset xD [09:52:39] 12 vs 14 [09:52:52] (03PS1) 10Yuvipanda: Fix wider-than-necessary visibility [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125115 [09:52:56] hmm? [09:53:01] addshore: oh, yeah. [09:53:05] (03Abandoned) 10Addshore: Remove redundant 'final' qualifiers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125112 (owner: 10Yuvipanda) [09:53:11] addshore: I deleted everything in the commit message because it was hard to find the change-id [09:53:12] ;D [09:53:23] haha xD [09:53:35] (03CR) 10Addshore: [C: 032] Remove redundant 'final' qualifiers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125114 (owner: 10Yuvipanda) [09:53:41] addshore: has your device gotten the app yet? [09:54:04] nope :/ [09:54:07] addshore: a lot of the issues remaining are also issuses that need to be fixed in checkstyle.xml itself. It is errenously reporting some stuff [09:54:24] (03Merged) 10jenkins-bot: Remove redundant 'final' qualifiers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125114 (owner: 10Yuvipanda) [09:54:55] addshore: under 300 warnings!! [09:59:07] (03PS1) 10Yuvipanda: Allow inline conditionals. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125119 [10:00:24] addshore: there's 76 of the whitespaceafter errors that are bogus, and then there's field hiding which I dunno what to do about [10:01:14] addshore: anyway, try installing the app :D And let me know what you think. [10:01:18] I'm off to do some visa stuff [10:01:46] addshore: and one final commit ^ :) [10:13:16] (03CR) 10Addshore: [C: 032] Fix wider-than-necessary visibility [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125115 (owner: 10Yuvipanda) [10:13:34] (03CR) 10Addshore: [C: 032] Allow inline conditionals. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125119 (owner: 10Yuvipanda) [10:17:17] (03Merged) 10jenkins-bot: Fix wider-than-necessary visibility [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125115 (owner: 10Yuvipanda) [10:17:20] (03Merged) 10jenkins-bot: Allow inline conditionals. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125119 (owner: 10Yuvipanda) [10:55:50] (03PS1) 10Siebrand: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125162 [12:29:07] (03CR) 10Theopolisme: "Actually, maybe something like `mw.loader.store.get`" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124881 (owner: 10Jdlrobson) [14:44:16] (03CR) 10Raimond Spekking: [C: 032] Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125162 (owner: 10Siebrand) [14:44:56] (03Merged) 10jenkins-bot: Remove zh-[sg|hk] in favour of zh-han[s|t] [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125162 (owner: 10Siebrand) [15:26:35] (03PS1) 10Jdlrobson: Fix page preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125202 [15:30:57] (03PS1) 10Jdlrobson: QA: Deal with failing cloudbees test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125204 [15:31:49] (03CR) 10jenkins-bot: [V: 04-1] QA: Deal with failing cloudbees test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125204 (owner: 10Jdlrobson) [15:32:39] (03PS1) 10Jdlrobson: Hygiene: don't confuse Jenkins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125205 [15:33:02] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125204 (owner: 10Jdlrobson) [15:33:37] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: don't confuse Jenkins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125205 (owner: 10Jdlrobson) [15:33:47] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125205 (owner: 10Jdlrobson) [15:53:34] (03PS1) 10Jdlrobson: QA: Browser tests for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125211 [16:13:24] (03CR) 10Zfilipin: [C: 031] Hygiene: don't confuse Jenkins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125205 (owner: 10Jdlrobson) [16:28:42] (03CR) 10Zfilipin: [C: 032] Hygiene: don't confuse Jenkins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125205 (owner: 10Jdlrobson) [16:29:15] (03Merged) 10jenkins-bot: Hygiene: don't confuse Jenkins [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125205 (owner: 10Jdlrobson) [16:47:19] (03CR) 10Jdlrobson: [C: 031] "Siebrand I'm not sure I understand the problem here. The issue is that a user has complained that the privacy text is not the same for des" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123886 (owner: 10MaxSem) [17:26:03] chrismcmahon: hey! [17:26:12] hi jdlrobson [17:26:31] So my theory is that merging https://gerrit.wikimedia.org/r/125204 and https://gerrit.wikimedia.org/r/125202 will fix all our cloud bees tests [17:26:33] fingers crossed [17:27:05] ^ chrismcmahon any help with getting those merged and verifying those claims would be great :) [17:27:08] jdlrobson: OK. right now login is busted on beta labs, I'm trying to see if Ori can recover [17:27:21] ohhh now always something lol [17:28:11] jdlrobson: https://bugzilla.wikimedia.org/show_bug.cgi?id=63780 if you're interested [17:28:36] (Wed. night is a bad time to break beta labs, that's when all the hairy merges happen) [17:30:13] :( [17:31:39] (03CR) 10JGonera: Card 1816: Change the notifications icon in beta (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [17:43:05] jgonera: https://gerrit.wikimedia.org/r/#/c/116037/ is *almost* merged [17:43:31] jgonera: james from VE suggested we try brad jorsch for changes like this in the future too (anomie) [17:45:00] thanks awjr [18:01:00] brion: heya! [18:03:07] yo yo yo [18:04:49] (03CR) 10Cmcmahon: [C: 032] QA: Deal with failing cloudbees test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125204 (owner: 10Jdlrobson) [18:05:42] (03Merged) 10jenkins-bot: QA: Deal with failing cloudbees test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125204 (owner: 10Jdlrobson) [18:06:32] brion: addshore helped merge a number of patches :) [18:06:50] wheeee [18:06:54] * addshore waves [18:09:26] brion: addshore so very soon per-commit apks will be available at http://tools.wmflabs.org/android-sdk-builds/wikipedia-commitly.apk [18:09:36] :D [18:09:40] it's running from toollabs since jenkins was a bit too fickle for it [18:10:09] fickle? in what way? :O [18:10:50] addshore: https://gerrit.wikimedia.org/r/125241 is needed on toollabs [18:10:54] addshore: there's also no package for the android sdk [18:11:35] addshore: and it's going to ping tools.wmflabs.org for packages [18:14:10] addshore: and https://gist.github.com/yuvipanda/10408391 is required to setup the sdk [18:32:00] yuvipanda: brion mhurd: wondering where you guys are at [18:32:09] i'm on the hangout but no one else is [18:32:18] tfinc: yeah, I keep getting logged out. Should be there in a sec [18:33:28] yuvipanda: I see :) [18:33:59] I guess I have a similar thing on labs for the 'Wikidata Builds' https://github.com/wmde/puppet-builder [18:34:03] dr0ptp4kt: brion is in the office today [18:34:50] yuvipanda: thx. brion, when you have a moment, let us copy a file [18:37:01] ok :D after this mtg [18:47:30] and i can get lunch early. woot! [18:49:47] dr0ptp4kt: brion's meeting is done ;) [19:00:28] * tfinc steps away to get lunch [19:00:52] hi brion [19:00:56] brion: transferred key to dr0ptp4kt? [19:01:12] moment [19:11:16] yuvipanda: brion did not not give me the information [19:11:27] brion: ^ [19:11:39] !!boolean [19:12:33] goddamnfuck [19:12:38] * yuvipanda trouts brain [19:25:06] (03CR) 10Cmcmahon: [C: 032] QA: Browser tests for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125211 (owner: 10Jdlrobson) [19:25:51] jdlrobson: just fyi, early tomorrow Zeljko and I are planning to refactor a whole bunch of the new API stuff and put it in the shared gem. [19:25:56] (03Merged) 10jenkins-bot: QA: Browser tests for this page has issues [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125211 (owner: 10Jdlrobson) [19:28:39] MaxSem: how hard is it going to be for me to use blob delivery on Extension:MobileApp [19:28:45] MaxSem: assuming the blob delivery patch isn't merged in time [19:29:40] * MaxSem scratches head [19:29:49] yuvipanda, for what? [19:30:00] MaxSem: delivering some JSON files [19:30:08] MaxSem: I could just make an API module instead, but just exploring this too [19:30:18] yuvipanda: you need templates too? [19:30:20] I guess if I make it an API module and set caching aggressively varnish will cache it.. [19:30:25] jdlrobson: no, raw JSON [19:30:33] why don't you just expose them directly? [19:30:42] MaxSem: hmm? as in? [19:31:14] MaxSem: the client here would be the android / iOS app [19:31:18] bits.wikimedia.org/en.wikipedia.org/extensions/MobileApp/resources/foo.json [19:31:35] oh fuck. [19:31:36] right [19:31:43] and that'll be cached too [19:31:48] I'm an idiot. [19:32:16] we won't have to vary it per wiki or anything, so this is fine [19:32:18] thanks MaxSem! [19:32:37] :) [19:40:56] (03PS1) 10Brion VIBBER: [Gingerbread] Disable crashy AutoCompleteTextView in edit summary [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125271 [19:41:18] yuvipanda: ^ there’s my last gingerbread crash fix; anything else is a bug i haven’t found yet ;) [19:41:48] MaxSem: just to confirm, if I just put it in extension/MobileApp/config/android.json, I can locally get it at http://127.0.0.1:8080/w/extensions/MobileApp/config/android.json and on bits at bits.wikimedia.org/en.wikipedia.org/extensions/MobileApp/config/android.json [19:41:57] and I don't really have to set any config stuff anywhere [19:41:59] it seems to work locally [19:43:37] ok lunch timessss [19:46:19] yuvipanda, better at http://bits.wikimedia.org/static-current/extensions/MobileApp/... [19:46:45] MaxSem: right. let me test it when it goes to betalabs [19:46:51] MaxSem: today's train left no? [19:47:36] yep, there's wmf22 [19:47:42] hmm, ok! [19:47:53] I can just use betalabs to test till then :) [19:54:43] betalabs y u no deploy [19:58:10] (03CR) 10Cmcmahon: "I think it would make sense to farm out search_special_page.feature into two tests, e.g. "search_beta_mode.feature" and say "search_from_o" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 (owner: 10Jdlrobson) [19:59:52] MaxSem: hmm, http://bits.beta.wmflabs.org/static-current/extensions/MobileApp/config/android.json is a 403 [20:00:13] labs is different [20:00:22] http://bits.beta.wmflabs.org/static-master/extensions/MobileApp/config/android.json [20:00:49] MaxSem: haha! [20:00:52] MaxSem: thank you! [20:02:15] mhurd: anon editing kill switch serverside work done. Available for now at http://bits.beta.wmflabs.org/static-master/extensions/MobileApp/config/android.json [20:02:19] (ios.json for ios) [20:03:11] yuvipanda: great! when are you thinking we check it? every edit? [20:03:38] mhurd: no way. once every other day or so [20:04:15] yuvipanda: hmmm if there’s an emergency so to speak, that doesn’t seem like it would be very useful... [20:05:57] yuvipanda: i like my brakes to work when i push them :) [20:06:13] thoughts? [20:07:31] mhurd: I don't think slowing down *every* edit with an extra network call would make for a good UX [20:08:03] mhurd: and besides, it is comparable to our times on the web anyway. The 'emergency upload stop' thing took two days, for example :) [20:09:00] plus kenan doesn't expect it to be used, neither do I. Unlike uploads, the community has good tools in place to police anonymous *editing* (AF, Captcha, Titleblacklist, Spamblacklist, etc) [20:13:52] yuvipanda: ok just caught kenan as he walked by. so i had thought this would be checked when the user saves the edit, but kenan and i believe your understanding was that the edit pencil won’t show at all (or be grayed out and a tap alerts user they have to login to edit). i’m on board with that - i suggested to kenan that we just check it on app resume and he was cool with that. thoughts? [20:14:53] mhurd: yeah, pretty much that. I like the greying out idea with a message to login on tap. [20:15:07] yuvipanda: sounds good [20:15:12] mhurd: :) [20:15:15] :) [20:15:50] yuvipanda: thanks for wrangling all the server bits :) [20:17:29] mhurd: :) [20:17:49] mhurd: since iOS and Android will be hitting different URLs, we can change the config for them individually too if necessary [20:17:57] (03CR) 10Cmcmahon: [C: 04-1] "diff.feature (at least) is not passing for me, setting -1 while I investigate" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson) [20:19:38] yuvipanda: sounds good. oh, you can prob flip them to “false” for now [20:19:59] mhurd: hah! yes, let me do that [20:20:03] :) [20:24:01] mhurd: submitted a patch to flip it. The URL will change once this gets deployed (next thursday) [20:24:07] mhurd: I'll keep you informed :) [20:24:47] yuvipanda: hehe cool! [20:26:15] (03CR) 10Cmcmahon: "diff.feature does not create the page that it needs here." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson) [20:45:19] jgonera: it's merged! \o/ [20:45:33] thanks awjr ;) [20:46:35] chrismcmahon: diff.feature is not working for you..? [20:47:14] also awjr i'm happy to run stand up tomorrow if you merge this patch for me - https://gerrit.wikimedia.org/r/125202 [20:47:23] lol [20:47:25] * awjr looks [20:48:15] (03CR) 10Jdlrobson: "Yeh it gets a bit cloudy when it comes to search as it is both overlay and the special page depending on the course of events..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 (owner: 10Jdlrobson) [20:49:55] jdlrobson: diff.feature doesn't work vs. beta labs. I think it neglects to create the page with the new name that it needs. [20:50:45] it shouldn't need the page. [20:50:53] chrismcmahon: looking now [20:50:54] (03PS1) 10Brion VIBBER: Work in progress: fallback-friendly MWLocalizedString to replcae NSLocalizedString [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125326 [20:51:16] jdlrobson: if the page is not there it pops a modal dialog that kills the test [20:51:26] ahhhh the new pages stuff [20:51:30] ok yeh that makes sense [20:51:32] let me get round that [20:52:13] we should make mobile opitons look better on big displays [20:52:31] (03PS5) 10Jdlrobson: QA: Make the test environment agnostic of existing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 [20:52:33] try that chrismcmahon ^ [20:52:39] (03CR) 10jenkins-bot: [V: 04-1] QA: Make the test environment agnostic of existing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson) [20:53:58] (03PS6) 10Jdlrobson: QA: Make the test environment agnostic of existing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 [20:54:23] (03Abandoned) 10Jdlrobson: QA: Make sure watchlist tests are setup correctly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120938 (owner: 10Jdlrobson) [20:54:45] jdlrobson: OK. that was kind of a big commit... [20:54:59] chrismcmahon: ? [20:55:02] (03CR) 10Awjrichards: [C: 032] Fix page preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125202 (owner: 10Jdlrobson) [20:55:14] (03PS1) 10Yuvipanda: Add ability to read config parameters from a URL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125327 [20:55:19] jdlrobson: does that just get me Friday's standup, or Monday's too? [20:55:25] brion: ^ 'anon kill switch' patch [20:55:25] awjr: just friday [20:55:28] ;-) [20:55:32] what do i have to do for Monday? [20:55:39] (03Merged) 10jenkins-bot: Fix page preview [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125202 (owner: 10Jdlrobson) [20:55:47] i'm sure something will come up that can be exchanged for monday hehe [20:55:54] lol ok, time is running out! [20:59:59] whee [21:01:14] (03PS2) 10Yuvipanda: Add ability to read config parameters from a URL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125327 [21:02:21] yuvipanda: http? tsk tsk [21:02:27] brion: this is super flexible - so in case in the future we want to do things (say A/B test) but still be able to turn it off if necessary, we can do that easily [21:02:29] brion: https bits doesn't have a proper cert ;) [21:02:33] hehe [21:02:38] brion: on betalabes at leats [21:02:40] yeah looks good on first quick look [21:02:44] brion: once this gets deployed it'll be elsewhere [21:02:53] brion: now I need to figure out what to do when the user clicks on the edit button [21:04:35] (03CR) 10Jdlrobson: EventLog profile and history link clicks (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123474 (owner: 10Jdlrobson) [21:05:14] So in theory our browser tests should succeed on next build chrismcmahon awjr [21:08:14] hey yuvipanda [21:08:18] hi kaity! [21:09:18] I have some questions on reference stuff [21:09:38] actually I'll just send in email :) [21:09:52] kaity: yay email :) just respond on the mobile-l thread and I'll respond :D [21:22:00] jdlrobson: geonotahack.feature also failing for me out of https://gerrit.wikimedia.org/r/#/c/125008/ . I think that one depended on a js change that was merged, but the test seems to not match the current status on beta labs [21:22:38] mmm i'll take another log [21:22:58] (03PS7) 10Jdlrobson: QA: Make the test environment agnostic of existing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 [21:23:04] yuvipanda: did kenan jump on the analytics thread ? i'm not seeing any difference on https://trello.com/c/NsCra66X/1-5-event-logging-editing-signing-in-article-navigation [21:23:15] ok now it will pass https://gerrit.wikimedia.org/r/#/c/125202/ only just got merged [21:23:48] jdlrobson: heh. bryan davis just disabled the auto-update script for beta just now. [21:24:01] (03CR) 10jenkins-bot: [V: 04-1] QA: Make the test environment agnostic of existing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson) [21:24:34] tfinc: so he responded once right after standup, I responded a few minutes later but then there has been no response to my response :( [21:25:02] grr [21:25:37] tfinc: grr indeed. I don't want to have to ask a question on trello and then send an email to ask for a response on trello and then ping during a meeting to ask for a response to the email... [21:26:02] yuvipanda: yeah, no reason that this can't stay in trello [21:26:09] tfinc: indeed [21:27:51] jgonera: errggg i've got 99+ problems and a notification icon is one [21:28:03] ? [21:39:11] (03PS1) 10Yuvipanda: Support hiding edit button for anon users [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125332 [21:39:34] dr0ptp4kt: heads up I do have one additional IP range patch coming [21:39:44] dfoy: cool [21:40:58] * yuvipanda goes to sleep [21:40:59] night! [21:41:17] mhurd: for the anon kill switch, I'm just going to hide the edit button if we flip it. Patch already up. [21:41:33] mhurd: easy to do, plus we 99% won't be using it anyway. [21:41:39] and if we do need to use it, it is very effective [21:42:02] yuvipanda: snds good [21:42:12] mhurd: :) [21:42:23] yuvipanda: have a good night! [21:45:59] kaity, you there? [21:46:08] dr0ptp4kt: yep [21:46:23] dr0ptp4kt: plz2 grab hold of brion today :) [21:46:37] * zz_yuvipanda goes to sleep for realz [21:46:45] kaity: for that email, link to the attachment rather than sending the attachment. [21:46:48] (mobile-l) [21:46:53] ok cool [21:47:09] zz_yuvipanda: what for on contacting him? he didn't not line me up with the file [21:47:37] zz_yuvipanda: is there something else besides that? [21:47:54] zz_yuvipanda: was trying to be jokeful with the double negation earlier today. i have the file! [21:55:21] (03CR) 10Jdlrobson: "Weird glitch was due to a css rule in NotificationsOverlay that was too generic." (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [21:58:16] (03PS4) 10Jdlrobson: Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 [21:58:18] (03PS4) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 [21:58:53] chrismcmahon: so i wasn't sure about your comment on https://gerrit.wikimedia.org/r/#/c/124742/ - is this stopping you from merging? [21:59:29] I personally think we should just have one search feature and try to think about it as one big unit [22:01:58] jdlrobson: that particular test seems to me to be two different situations, beta and non-beta. making these short and granular is desirable [22:08:13] chrismcmahon: so my preference is keeping all features together regardless of whether they are in stable/beta/alpha [22:08:36] especially given when we promote something we end up with cleaner diffs with better revision history making it clear how those tests were derived and what they were for [22:08:54] i hinted at this in my email that if we could organize features it might be better [22:09:20] i would be open to this approach if we could do something like features/beta/search.feature features/stable/search.feature [22:38:36] * tfinc changes locations and will likely only be on 3G [22:43:53]