[00:00:48] <grrrit-wm>	 (03PS3) 10Jdlrobson: Switch to JsDuck for documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120587 
[00:15:29] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 031] "Will look closer at code tomorrow." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125343 (owner: 10JGonera)
[00:15:54] <grrrit-wm>	 (03Abandoned) 10Jdlrobson: Card 1815: Add animations to right drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124649 (owner: 10Jdlrobson)
[00:17:39] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "Small issue to fix and ready to go." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 (owner: 10Jdlrobson)
[00:20:07] <grrrit-wm>	 (03PS5) 10Jdlrobson: Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 
[00:20:15] <grrrit-wm>	 (03CR) 10Jdlrobson: Card 1905: Make content transparent when drawer open (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 (owner: 10Jdlrobson)
[00:21:15] <grrrit-wm>	 (03PS2) 10JGonera: Fix line height for edit summary on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125037 (owner: 10Jdlrobson)
[00:21:41] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Fix line height for edit summary on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125037 (owner: 10Jdlrobson)
[00:22:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Fix line height for edit summary on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125037 (owner: 10Jdlrobson)
[00:22:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix line height for edit summary on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125037 (owner: 10Jdlrobson)
[00:44:13] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "A few issues (also Max's)." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124657 (owner: 10Jdlrobson)
[14:15:06] <grrrit-wm>	 (03PS8) 10Cmcmahon: QA: Make the test environment agnostic of existing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson)
[14:42:14] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 04-1] "This sort of thing works better with smaller, more granular commits." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson)
[16:07:22] <grrrit-wm>	 (03PS1) 10Zfilipin: APIPage can create pages via API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 
[16:07:41] <grrrit-wm>	 (03PS2) 10Zfilipin: QA: APIPage can create pages via API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 
[16:17:48] <grrrit-wm>	 (03CR) 10Cmcmahon: [C: 031] "Paired with Zeljko for this, tested with the live Ruby gem. +1 for now while people look it over before merging." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 (owner: 10Zfilipin)
[16:41:00] <YuviPanda>	 addshore: did you get the update?
[16:43:19] <jdlrobson>	 YuviPanda: does the fact we are getting spam on mobile-l mean it has become a cool list !?
[16:43:32] <YuviPanda>	 jdlrobson: :D
[16:43:46] <YuviPanda>	 jdlrobson: despite my skepticism initially you seem to have succeeded
[16:44:38] <addshore>	 YuviPanda: not at home right now :P not sure :)
[16:44:50] <YuviPanda>	 addshore: :D ok!
[16:47:08] <YuviPanda>	 hi brion
[16:47:42] <brion>	 yo yo
[16:48:30] <YuviPanda>	 brion: I got the anon kill switch patches in
[16:48:57] <YuviPanda>	 brion: I'm going to look at your 2.3 patch now
[16:49:16] <brion>	 great
[16:50:22] <grrrit-wm>	 (03CR) 10Yuvipanda: [C: 032] [Gingerbread] Disable crashy AutoCompleteTextView in edit summary [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125271 (owner: 10Brion VIBBER)
[16:50:26] <YuviPanda>	 brion: there
[16:50:29] <brion>	 whee
[16:50:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: [Gingerbread] Disable crashy AutoCompleteTextView in edit summary [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125271 (owner: 10Brion VIBBER)
[16:59:19] <brion>	 oh i forgot my glasses, that’s why everything’s blurry
[16:59:20] <brion>	 brb
[17:03:45] <brion>	 morning
[17:04:37] <mhurd>	 brion: hey!
[17:06:15] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] Add ability to read config parameters from a URL [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125327 (owner: 10Yuvipanda)
[17:07:11] <YuviPanda>	 mhurd: I setup the schemas. theyre' on the card :)
[17:07:20] <mhurd>	 YuviPanda: oh awesome!
[17:07:23] <YuviPanda>	 mhurd: :)
[17:07:26] <mhurd>	 YuviPanda: thank you!
[17:07:39] <YuviPanda>	 mhurd: I also implemented kill swtich by just hiding the edit icon. Simplest to do and works in an emergency :)
[17:08:05] <mhurd>	 YuviPanda: cool. are you calling it every time the app resumes or just periodically?
[17:09:21] <YuviPanda>	 mhurd: periodically
[17:09:30] <mhurd>	 YuviPanda: cool
[17:10:09] <grrrit-wm>	 (03PS1) 10Mhurd: Renamed "Wikipedia-iOS" folder to "wikipedia". [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125419 
[17:10:11] <grrrit-wm>	 (03PS1) 10Mhurd: First pass at channeling web assets through GruntJS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125420 
[17:10:32] <mhurd>	 brion: ^ lotsa stuff :)
[17:10:44] <mhurd>	 *fingers crossed*
[17:11:00] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032] Support hiding edit button for anon users [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125332 (owner: 10Yuvipanda)
[17:11:53] <mhurd>	 brion: oh, you may have to delete xcode’s derived data from the organizer for the project
[17:11:58] <brion>	 k
[17:30:57] <grrrit-wm>	 (03PS1) 10JGonera: Fix a FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125427 
[17:35:30] <mhurd>	 brion: the css in the less file hasn’t been “lessified” yet… will need to do so and break into separate files to better sync with android in future
[17:35:48] <brion>	 ok
[17:56:05] <mhurd>	 brion: wow… i think i have the preview stuff almost done :)
[17:56:09] <brion>	 :D sweet
[17:56:40] <mhurd>	 brion: it was one of those “is this really working?” moments
[17:57:11] <brion>	 hhee
[17:58:30] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "Nothing seems to explode once derived data is cleared :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125419 (owner: 10Mhurd)
[17:59:31] <mhurd>	 brion: no explosions? michael bay would be sad
[17:59:35] <brion>	 lol
[17:59:44] <brion>	 ^%&^%&^ like once a week this hard drive unmounts spontaneously
[17:59:50] <brion>	 it makes my virtual machines unhappy when their disk disappears
[17:59:57] <brion>	 frickin off-brand electronics :D
[18:00:05] <mhurd>	 hehe
[18:00:16] <brion>	 but hey it was cheap compared to the competition
[18:00:23] <brion>	 so i guess i’ve got that going for me
[18:03:32] <mhurd>	 YuviPanda: hey if a user taps a link in the preview window, do you open the link in external browser or just ignore the link tap?
[18:04:28] <brion>	 mmmmmm npm install grunt \o/
[18:04:35] <mhurd>	 hehe
[18:06:25] <mhurd>	 brion: do you know what android does about link taps in preview?
[18:06:35] <brion>	 not offhand, lemme check
[18:06:43] <mhurd>	 brion: thx!
[18:07:19] <brion>	 mhurd: it crashes ;)
[18:07:31] <brion>	 YuviPanda: we should probably fix that to either work or not
[18:07:32] <mhurd>	 oh… i can do that too ;)
[18:07:45] <brion>	 looks like it tries to do the linkClicked event but there’s no listener on the bus
[18:08:16] * brion  whistles “events on the bus go round and round"

[18:09:21] <mhurd>	 brion: i guess it would be nice if the user could test links, but letting them navigate away from the article being edited is problematic… so do you think they should open in external browser for now?
[18:09:56] <brion>	 if it’s easy to do external browser let’s do it, and then we can decide to pull it if we want
[18:10:02] <mhurd>	 brion: k
[18:10:03] <brion>	 if it sounds hard, then make it do nothing and we can decide to add it :D
[18:10:22] <brion>	 as you say it’s problematic since you’re more likely ot end up losing your state
[18:10:29] <brion>	 if you wander away too long...
[18:10:41] <mhurd>	 brion: ya. big ol can of worms…
[18:10:45] <mhurd>	 as they say
[18:16:11] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "does not appear to explode. \o/" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125420 (owner: 10Mhurd)
[18:16:34] <brion>	 ok let’s see if i can rebase that i18n fix :D
[18:16:58] <mhurd>	 yay!
[18:17:23] <grrrit-wm>	 (03PS2) 10Brion VIBBER: Work in progress: fallback-friendly MWLocalizedString to replcae NSLocalizedString [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125326 
[18:19:23] <grrrit-wm>	 (03CR) 10Mhurd: [C: 031] "Looks good." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125326 (owner: 10Brion VIBBER)
[18:20:02] <brion>	 whee!
[18:20:07] <brion>	 lemme do the big search-replace now
[18:21:01] <mhurd>	 brion: fun times
[18:21:48] <brion>	 ‘Would you like Xcode to take automatic snapshots before Batch Find & Replace and similar operations?”
[18:21:51] <brion>	 oh Xcode sometimes i love you
[18:27:40] <mhurd>	 brion: so complications even with opening preview links in external browser… intra-page links for citations etc… thinking maybe just doing a js alert with the url may suffice for now? not ideal… but would this be ok as a first step?
[18:28:02] <brion>	 yeah that sounds like easy way to stub it out
[18:28:07] <mhurd>	 brion: cool
[18:34:16] <grrrit-wm>	 (03PS3) 10Brion VIBBER: Fallback-friendly MWLocalizedString to replace NSLocalizedString [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125326 
[18:34:28] <brion>	 commit now bigger! ;)
[18:37:12] <grrrit-wm>	 (03CR) 10Mhurd: [C: 031] "Yay!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125326 (owner: 10Brion VIBBER)
[18:37:38] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "ok let's merge this baby" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125326 (owner: 10Brion VIBBER)
[18:40:46] <YuviPanda>	 brion: it is pretty easy in android. just pop up a new activity, should be fine
[18:40:51] <YuviPanda>	 brion: need to hook up linkhandler for that instance.
[18:41:04] <YuviPanda>	 brion: I separated out link handling js to one js file for that, and then didn't do the java part
[18:41:05] <YuviPanda>	 :)
[18:41:08] <brion>	 heh
[18:41:17] <YuviPanda>	 brion: :)
[18:41:38] <YuviPanda>	 brion: mhurd I'll be spordaically available for the next few hours. Will keep checking IRC tho
[18:46:31] <mhurd>	 YuviPanda: k
[18:50:35] <mhurd>	 brion: did i do that review properly?
[18:50:47] <brion>	 mhurd: to merge you gotta give it a +2
[18:50:52] <brion>	 and …. i think also ‘verified’
[18:51:11] <brion>	 in theory at some point we can set up automatic testing to do the verification part, we just got that set up on android the other day
[18:55:28] <mhurd>	 brion: ah got it!
[18:55:32] <mhurd>	 brion: thanks
[18:56:04] <mhurd>	 brion: i’ll have a patch for you soon for the preview styling
[18:56:17] <brion>	 awesome
[18:56:25] <brion>	 i’m gonna grab a sandwich, be back in a bit
[18:58:59] <mhurd>	 brion: yay
[19:09:15] * tfinc  steps out to grab lunch

[19:11:23] <jgonera>	 jdlrobson, are you there?
[19:12:17] <jdlrobson>	 heeyyy
[19:19:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] QA: Make the test environment agnostic of existing pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson)
[19:30:24] <dr0ptp4kt>	 mhurd, for later: https://gist.github.com/anonymous/86427a5d904a2e5d0b9a
[19:31:20] <YuviPanda>	 dr0ptp4kt: make an alpha!
[19:31:26] * YuviPanda  is spordaiocally here

[19:31:43] <dr0ptp4kt>	 YuviPanda: after lunch
[19:38:48] <yurikR>	 dr0ptp4kt: do you remember why we added MediaWiki:terms-use to the zero URL?
[19:39:57] <yurikR>	 it 404s
[19:43:28] <yurikR>	 dr0ptp4kt: do you remember why we added MediaWiki:terms-use to the zero URL? it 404s
[19:58:59] <grrrit-wm>	 (03PS2) 10Jdlrobson: Fix a stylesheet FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125427 (owner: 10JGonera)
[19:59:12] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] "I renamed patchset to be more descriptive." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125427 (owner: 10JGonera)
[19:59:58] <grrrit-wm>	 (03PS1) 10Jdlrobson: Story 1538: History page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125499 
[20:00:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix a stylesheet FIXME [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125427 (owner: 10JGonera)
[20:05:26] <yurik>	 dr0ptp4kt: do you remember why we added MediaWiki:terms-use to the zero URL? it 404s
[20:13:53] <grrrit-wm>	 (03PS1) 10Mhurd: Edit preview html is now styled correctly. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125502 
[20:13:56] <mhurd>	 brion: ^
[20:13:58] <brion>	 \o/
[20:14:37] <brion>	 whoever named a method “stringByEvaluatingJavaScriptFromString” really is …. verbose
[20:14:45] <mhurd>	 brion: hehe
[20:15:31] <mhurd>	 brion: http://stackoverflow.com/a/15152232/135557
[20:17:09] <grrrit-wm>	 (03CR) 10Brion VIBBER: Edit preview html is now styled correctly. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125502 (owner: 10Mhurd)
[20:17:35] <brion>	 mhurd: daaaaaamn that’s a serious method name
[20:19:24] <grrrit-wm>	 (03CR) 10Mhurd: "Replied to comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125502 (owner: 10Mhurd)
[20:20:00] <mhurd>	 brion: ^ just replied agreeing that it was a stop-gap
[20:20:09] <brion>	 yups
[20:20:20] <brion>	 hmm i feel like these device deploys are taking forever
[20:20:40] <brion>	 mhurd: i hae the awful suspicion that we’re deploying the npm_modules directory into the app
[20:21:07] <mhurd>	 brion: did binary get bigger?
[20:21:17] <brion>	 let me try and build an archive
[20:21:56] <brion>	 26.9 MB
[20:21:56] <brion>	 !
[20:22:03] <brion>	 that’s way bigger than 2.3mb from yesterday
[20:22:51] <mhurd>	 brion: good catch!
[20:23:07] <brion>	 probably thanks to my shitty usb hub slowing down deploys ;)
[20:23:14] <mhurd>	 :)
[20:23:16] <brion>	 i’m not 100% sure all the ports are usb 2
[20:24:17] <mhurd>	 brion: hmmm how to exclude subfolder from a target’s build phase “copy bundle resources” step…?
[20:24:29] <brion>	 excellent question
[20:25:48] <mhurd>	 brion: ah! we just have to remove “www” i believe
[20:26:05] <mhurd>	 from the build phase copy list
[20:26:07] <brion>	 ahh right — we’re copying all the output from there to ‘assets’ right?
[20:27:03] <mhurd>	 brion: ya, just assets actually gets used by app. all the www stuff is for gruntjs to compile, it then outputs to assets
[20:27:14] <brion>	 great that should do it then
[20:27:26] <mhurd>	 brion: want me to submit patch?
[20:27:32] <brion>	 please do :D
[20:31:28] <grrrit-wm>	 (03PS1) 10Mhurd: Exclude gruntJS www files from build. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125503 
[20:31:33] <mhurd>	 brion: ^
[20:33:57] <brion>	 ahhhh that installs so much faster :D
[20:34:18] <brion>	 and we’re back to our svelte 2.3mb self
[20:34:39] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] "yay! fixes the accidental bloated output size :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125503 (owner: 10Mhurd)
[20:34:51] <mhurd>	 brion: yay!
[20:34:55] <grrrit-wm>	 (03PS2) 10Brion VIBBER: Edit preview html is now styled correctly. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125502 (owner: 10Mhurd)
[20:35:09] <brion>	 now let’s try that styling fix again \o/
[20:35:26] <mhurd>	 cool
[20:36:22] <grrrit-wm>	 (03CR) 10Brion VIBBER: [C: 032 V: 032] Edit preview html is now styled correctly. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125502 (owner: 10Mhurd)
[20:36:33] <mhurd>	 woohoo!
[20:56:11] <tfinc>	 brion: you in the office or remote today? i want to release the room if your not
[20:56:20] <brion>	 tfinc: remote, can release the room
[21:08:13] <dr0ptp4kt>	 yurikR, i'm here.
[21:15:20] <dr0ptp4kt>	 yurikR, for the iframe, i think it was arbitrary
[21:15:34] <dr0ptp4kt>	 yurikR, lemme know if you want me to change it to something else or if you're already on it
[21:23:23] <tfinc>	 jdlrobson: you about ?
[21:45:22] <dr0ptp4kt>	 brion, you around/
[21:45:27] <dr0ptp4kt>	 (online)?
[21:48:19] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] "Please make it look like in the assets:" (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125499 (owner: 10Jdlrobson)
[21:49:05] <grrrit-wm>	 (03PS2) 10Jdlrobson: WIP: Story 1538: History page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125499 
[21:49:22] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Sorry not completely done with this. Forgot to mark it as such." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125499 (owner: 10Jdlrobson)
[21:49:42] <jgonera>	 jdlrobson, what were the tools for UI regressions testing? PhantomCSS, wraith, huxley? anything else?
[21:49:52] <jdlrobson>	 check your mail jgonera
[21:49:57] <jdlrobson>	 there is a whole thread about it\
[21:50:17] <jgonera>	 jdlrobson, which group?
[21:50:23] <jdlrobson>	 i think it was linked i nthe story no?
[21:50:31] * jdlrobson  looks

[21:50:38] <jdlrobson>	 yeh http://www.gossamer-threads.com/lists/wiki/wikitech/440143?page=last
[21:50:53] <jgonera>	 yep, thanks
[21:56:05] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] QA: APIPage can create pages via API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 (owner: 10Zfilipin)
[22:00:26] <grrrit-wm>	 (03PS1) 10Dr0ptp4kt: Bump version for alpha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125519 
[22:08:25] <grrrit-wm>	 (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Bump version for alpha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125519 (owner: 10Dr0ptp4kt)
[22:09:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Bump version for alpha. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125519 (owner: 10Dr0ptp4kt)
[22:15:14] <grrrit-wm>	 (03CR) 10JGonera: [C: 04-1] Don't show language button after edit when no languages (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125044 (owner: 10Jdlrobson)
[22:15:30] <mhurd>	 jgonera: i think kenan is done
[22:15:42] <jgonera>	 mhurd, thanks, coming
[22:16:41] <yurik>	 dr0ptp4kt, ping?
[22:16:53] <dr0ptp4kt>	 yurik, i'm here
[22:19:00] <yurik>	 dr0ptp4kt: do you remember why we added MediaWiki:terms-use to the zero URL? it 404s
[22:19:12] <dr0ptp4kt>	 yurik, irc problems today? :)
[22:19:20] <yurik>	 seems that way
[22:19:25] <yurik>	 i post and noone is replying :)
[22:19:37] <dr0ptp4kt>	 yurik, i think it was arbitrary. if you want me to change the url lemme know, otherwise feel free to do so yourself
[22:19:54] <dr0ptp4kt>	 yurik, friday is always netsplits day it seems
[22:20:12] <yurik>	 dr0ptp4kt, well, that page does not exist - where you trying to show a page that always exists?
[22:20:34] <dr0ptp4kt>	 at the time, yes, and ideally a smaller page
[22:20:59] <yurik>	 gotcha, will have to think about it. Maybe  some special page is better
[22:22:00] <dr0ptp4kt>	 brion, i'm going to push the red button and release the newer alpha
[22:23:17] <dr0ptp4kt>	 brion, i pushed the red button and released it to alpha
[22:23:53] <dr0ptp4kt>	 YuviPanda: ^^ hope i didn't wake you up
[22:26:01] <grrrit-wm>	 (03CR) 10Jdlrobson: "fixing..." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125044 (owner: 10Jdlrobson)
[22:26:51] <grrrit-wm>	 (03CR) 10Jdlrobson: QA: APIPage can create pages via API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 (owner: 10Zfilipin)
[22:26:55] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] QA: APIPage can create pages via API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 (owner: 10Zfilipin)
[22:29:39] <grrrit-wm>	 (03PS3) 10Jdlrobson: Don't show language button after edit when no languages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125044 
[22:32:20] <jdlrobson>	 jgonera: https://gerrit.wikimedia.org/r/#/c/125343/ needs fixing - it seems to be based off an abandoned card..
[22:32:30] <jdlrobson>	 thus i can't pick to master
[22:32:50] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 04-1] "Something odd going on here. Please cherry pick to master it's based off an abandoned patchset." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125343 (owner: 10JGonera)
[22:32:51] <jgonera>	 why did you abandon it?
[22:33:12] <jdlrobson>	 because you were redoing it - why would you based it off that patch set?
[22:33:40] <jgonera>	 jdlrobson, I told you I would...
[22:33:55] <jgonera>	 I mean, I can just locally do rebase -i and squash them
[22:34:00] <jdlrobson>	 i misunderstood - makes no sense having two commits that do the same thing we should meld them together
[22:34:07] <jgonera>	 I wasn't redoing it, I was basing it off your patch
[22:34:15] <jdlrobson>	 yeh that's what i thought you'd do - or resubmit with a different change id
[22:34:34] <jgonera>	 ok, I'll do that now, but in future I'd prefer you told me when I tell you that I base it off your patch ;)
[22:34:37] <jdlrobson>	 anyway easy to fix now i know what's going on
[22:34:45] <jgonera>	 I'll do it
[22:34:59] <jdlrobson>	 ok for the record jgonera if you ever want to redo something - just take my patch amend it however you feel, then delete the change id and resubmit it
[22:35:25] <jgonera>	 jdlrobson, that was my original idea but then it grew much bigger than I expected
[22:35:43] <jdlrobson>	 anyway it just had me confused why i couldn't rebase it :)
[22:36:49] <grrrit-wm>	 (03PS3) 10JGonera: Card 1815: Add animations to right drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125343 
[22:37:00] <jgonera>	 jdlrobson, should work now ^
[22:37:21] <jdlrobson>	 anyway jenkins is broken it seems
[22:37:26] <jdlrobson>	 so i can't merge anyhow
[22:37:44] <jgonera>	 btw, jdlrobson, kss is broken in core master: https://gerrit.wikimedia.org/r/#/c/125511/
[22:37:47] <jdlrobson>	 the var_dump is still there :-S
[22:37:53] <jgonera>	 oh
[22:37:56] <jgonera>	 ok, will fix it
[22:38:21] <mhurd>	 vbamba:  http://www.custardbelly.com
[22:38:24] <jdlrobson>	 looking at the core change now
[22:38:43] <grrrit-wm>	 (03PS4) 10JGonera: Card 1815: Add animations to right drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125343 
[22:39:27] <jgonera>	 anyway, I guess we can +2 and things will get merged when jenkins is up jdlrobson 
[22:39:42] <jdlrobson>	 so do i need to now rebase all mine of yours?
[22:40:43] <grrrit-wm>	 (03CR) 10Jdlrobson: [C: 032] Card 1815: Add animations to right drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125343 (owner: 10JGonera)
[22:41:58] <jgonera>	 jdlrobson, will they all conflict?
[22:42:05] <jdlrobson>	 hope not :(
[22:42:23] <jgonera>	 is any of them bigger than this one?
[22:42:28] <jgonera>	 we can merge the biggest one first
[22:49:28] <vbamba>	 ooh thanks!
[22:52:15] <grrrit-wm>	 (03PS2) 10Jdlrobson: QA 1807: Provide tests for full text search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 
[22:52:28] <grrrit-wm>	 (03PS6) 10Jdlrobson: Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 
[22:52:42] <grrrit-wm>	 (03PS5) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 
[22:54:15] <jdlrobson>	 jgonera: yeh there is going to be a merge conflict :(
[23:09:56] <jdlrobson>	 this rebase is horrible jgonera 
[23:16:13] <jgonera>	 jdlrobson, which patch in particular?
[23:16:25] <jdlrobson>	 i'm trying to rebuse the icon patch off the animations patch
[23:16:30] <jdlrobson>	 it seems to be broken now
[23:16:31] <jdlrobson>	 :(
[23:16:38] <jgonera>	 replacing the icon?
[23:16:45] <jgonera>	 well, anyway, give me a link ;)
[23:18:37] <jdlrobson>	 no link yet as i'm still trying to rectify it
[23:22:10] <jgonera>	 ok
[23:22:29] <jgonera>	 I'll have a follow-up with Todd in a few minutes so I might not respond immediately
[23:34:09] <jdlrobson>	 ok that was the worst rebase ever
[23:34:14] <jdlrobson>	 owch.
[23:34:15] <grrrit-wm>	 (03PS6) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 
[23:35:18] <jdlrobson>	 jgonera: will you get any chance to do some code review today? Would be great to get all this code merged and finish an iteration without any outstanding stories for once
[23:35:38] <jgonera>	 is it all ready?
[23:37:07] <jgonera>	 I mean, I can do some more review today, but I can't guarantee it's all going to be +2s
[23:42:36] <jdlrobson>	 jgonera: well the making drawer transparent has been sat there for 7 days, notification icon 6 days
[23:42:49] <jdlrobson>	 the history story is almost done but i need to chat to moiz about it
[23:43:01] <jdlrobson>	 so i guess that will have to wait till monday unless he comes on irc
[23:43:08] <jgonera>	 jdlrobson, this is not fair, I reviewed the transparent thing yesterday, you can't complain...
[23:43:51] <mhurd>	 brion: hey it doesn’t look like vibha is on the testflight distro list… can’t seem to add her
[23:43:55] <jdlrobson>	 i wasn't really complaining juliusz i was just commenting they've been sitting there for a while
[23:44:08] <jdlrobson>	 and the transparent one is a tiny patch
[23:44:39] <jdlrobson>	 i fixed it up 3 minutes after you reviewed it :)
[23:44:45] <grrrit-wm>	 (03PS7) 10JGonera: Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 (owner: 10Jdlrobson)
[23:44:52] <jdlrobson>	 thanks
[23:44:56] <grrrit-wm>	 (03CR) 10JGonera: [C: 032] Card 1905: Make content transparent when drawer open [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123810 (owner: 10Jdlrobson)
[23:45:37] <jgonera>	 jdlrobson, yeah, but I do code review asynchronously, I'm not constantly in a ready state for new patches ;)
[23:46:20] <mhurd>	 brion: i think i may have figured it out
[23:48:04] <jdlrobson>	 jgonera: is moiz around?
[23:48:09] <jdlrobson>	 https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1790 < i want to know if the title should be a link
[23:48:19] <jdlrobson>	 as it doesn't look like a link and probably should be :)
[23:58:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] WIP: Story 1538: History page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125499 (owner: 10Jdlrobson)
[23:59:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: APIPage can create pages via API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125415 (owner: 10Zfilipin)