[00:42:50] jgonera: you about? [01:14:54] (03PS2) 10Dr0ptp4kt: Put fixed notification at bottom of window when W0 on. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125887 (owner: 10Mhurd) [02:09:29] (03CR) 10Mhurd: "Having some trouble testing. Maybe we could add a testing stub?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125887 (owner: 10Mhurd) [02:11:26] (03PS1) 10Mhurd: Added more logging events. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125935 [04:11:27] (03PS3) 10Kaldari: Experimental: Undo button on diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125747 [04:11:46] (03CR) 10Kaldari: Experimental: Undo button on diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125747 (owner: 10Kaldari) [04:19:04] (03PS4) 10Kaldari: Experimental: Undo button on diff page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125747 [11:33:42] (03PS1) 10Yuvipanda: Remove useless variable declaration [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/125973 [11:33:57] hi addshore. did you get the beta? :D [12:27:00] YuviPanda: yes :) [12:27:07] not looked at it yet though P [12:27:09] :P [12:27:27] addshore: :D [12:27:29] addshore: ok! [12:27:31] (03PS1) 10Yuvipanda: Fix keyboard not hiding when it should [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125975 [12:54:11] (03PS1) 10Yuvipanda: Fix Account Creation not working [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125982 [13:21:39] (03PS1) 10Yuvipanda: Fix crash when loading unreachable image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125985 [14:37:00] (03PS1) 10Zfilipin: QA: Updated Ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125999 [14:39:42] (03CR) 10Cmcmahon: [C: 032] QA: Updated Ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125999 (owner: 10Zfilipin) [15:06:19] (03PS2) 10Hashar: QA: Updated Ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125999 (owner: 10Zfilipin) [15:06:25] (03PS3) 10Hashar: QA: Updated Ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125999 (owner: 10Zfilipin) [15:07:24] (03CR) 10Hashar: [C: 032] "Regating due to a communication error between Zuul and Gerrit." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125999 (owner: 10Zfilipin) [15:08:16] (03CR) 10jenkins-bot: [V: 04-1] QA: Updated Ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125999 (owner: 10Zfilipin) [15:08:54] (03Merged) 10jenkins-bot: QA: Updated Ruby gems [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125999 (owner: 10Zfilipin) [15:20:53] hashar: hi! [15:25:09] YuviPanda_: sorry starting audios then on a board meeting then some more audio :-] Follow up by email! [15:25:16] hashar: will do :) [15:25:22] hashar: enjoy your meetings! :) [15:25:46] thanks [15:28:38] yuvipanda: and if you want us to pair, feel free to invite me via wikimedia.org calendar :] [15:28:42] (03CR) 10Cmcmahon: [C: 04-1] "editor_wikitext_saving.feature needs a "Selenium no languages test page" but the test does not create it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson) [15:29:21] ragesoss: around? [15:29:30] Yup [15:30:04] ragesoss: I fixed the crash bugs you reported. Trying to repro https://en.wikipedia.org/wiki/Wikipedia:Wikipedia_Signpost/2014-04-09/Special_report now [15:34:26] Yuvipanda: do you not get the wrong section like I do? [15:36:25] ragesoss: indeed. seems to be off by one [16:36:03] hey awjr_away ! [16:38:42] Reedy: can we get a license key for IntelliJ Ultimate? http://www.jetbrains.com/idea/buy/choose_edition.jsp?license=OPEN_SOURCE [16:39:38] I suspect so [16:40:14] * Reedy applies [16:40:17] woo! [16:40:33] Reedy: thank you :) [16:43:10] Done [16:43:24] Reedy: woo! [16:47:19] jdlrobson: late yesterday I found that Zeljko and I had committed a bug that made the (ApiPage).create call not work, but it should be fixed now with mediawiki_selenium gem version 2.20. sorry about that! [17:01:38] (03CR) 10Yuvipanda: [C: 032] Hygiene: Move wgSiteName requirement into other LocalSettings changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125858 (owner: 10Jdlrobson) [17:03:02] can't merge because of dependencies I have no idea about, but hey I tried! :) [17:12:29] tfinc: today's standup hangout needs a link [17:13:31] (03CR) 10Jdlrobson: "Not true... "I go to a page that has languages" creates the language page..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson) [17:16:01] (03PS11) 10Jdlrobson: QA: Remove dependency on San Francisco article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 [17:16:52] brion: hangout@! [17:17:17] brion: CR? :) [17:18:58] maintenance was here, sec [17:19:04] brion: ah ok! [17:22:18] YuviPanda: you there? [17:22:31] What were the dates of your last two trips to SF? [17:22:34] rfarrand: yeah! in a meeting, 2 mins. [17:22:40] (03CR) 10Cmcmahon: "Here create_page_api_steps has "I go to a page that has languages" to create "Selenium language test page"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson) [17:22:41] the one for your ERs [17:22:43] OK, no worries [17:24:49] rfarrand: september and october [17:25:57] chrismcmahon: that's a different test i think you are confused [17:26:13] the step `the page "Selenium no languages test page" exists ` also creates "Selenium no languages test page" [17:26:18] but this is unrelated to my patchset [17:26:31] jdlrobson: I see. Something is definitely going wrong here though. [17:26:45] possibly but it's creating it for me [17:27:16] chrismcmahon: does it work for you on current master? [17:27:39] jdlrobson: actually, no, something is going wrong there also [17:28:01] it looks like it should work looking at the code and it is working for me [17:28:06] are you running the latest gems? [17:28:40] rfarrand: so wikimania in august, sf in september and sf in october [17:28:46] jdlrobson: jgonera greetings - is max in the office now? [17:29:02] awjr: yup but he just stepped out to get a social security # [17:29:12] cool thanks jdlrobson [17:30:33] rfarrand: heh, the 'to' still said 'Svetlana' :) [17:34:56] YuviPanda: yeah, i have no idea how to change that… but the email goes to "Accountspayable@" [17:35:03] rfarrand: yeah, saw that :) [17:35:03] did you see the response? you are good to go [17:35:17] rfarrand: yeah, got it. I'll get it done tomorrow! [17:35:25] rfarrand: thank you! :) [17:36:05] hey mhurd. around? [17:36:11] YuviPanda: ya! [17:36:35] mhurd: so, redirects. [17:36:50] YuviPanda: ya! [17:36:53] mhurd: you will find a JSON key called 'redirected' in the response, with the value being the page it was redirected to [17:37:00] YuviPanda: k [17:37:05] mhurd: see https://en.wikipedia.org/wiki/Special:ApiSandbox#action=mobileview&format=json&page=UK§ions=0&onlyrequestedsections= [17:37:14] mhurd: no need to add an extra param to the query. [17:37:26] mhurd: so just treat that as the new title and you are good to go :) [17:37:35] YuviPanda: oh… wow. [17:37:38] YuviPanda: thanks! [17:37:41] mhurd: yw :) [17:38:19] jdlrobson: eh, I didn't have the rebased 125008 which was necessary. [17:38:34] chrismcmahon: o_O i'm confused [17:38:37] how do you check out patches? [17:41:56] (03CR) 10Mhurd: "Added thread containment note..." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125879 (owner: 10Brion VIBBER) [17:42:10] brion: ^ i added a small note [17:43:15] (03CR) 10Brion VIBBER: Set text writing direction on section editor according to content language (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125879 (owner: 10Brion VIBBER) [17:48:17] (03CR) 10Cmcmahon: [C: 032] QA: Remove dependency on San Francisco article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson) [17:48:34] (03PS3) 10Cmcmahon: QA: Make the test environment agnostic of existing pages #2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125857 (owner: 10Jdlrobson) [17:49:19] (03Merged) 10jenkins-bot: QA: Remove dependency on San Francisco article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125008 (owner: 10Jdlrobson) [17:50:49] YuviPanda: hey time for quick question about login schema? [17:51:02] mhurd: sure [17:51:37] YuviPanda: do you fire createAccountFailure only when error, but not if error is captcha required [17:51:57] mhurd: ah, good question. I think I'll have to amend that schema to account for captcha as well [17:52:03] mhurd: so captcha will have its own enums [17:52:18] YuviPanda: ah! is that easy to do? [17:52:26] (03PS2) 10Brion VIBBER: Set text writing direction on section editor according to content language [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125879 [17:52:31] mhurd: adding an enum? trivial :) I'll do that once I get done with lunch. [17:52:49] YuviPanda: k. ping me when you do? [17:52:56] mhurd: doing now [17:54:04] mhurd: https://meta.wikimedia.org/wiki/Schema:MobileWikiAppCreateAccount [17:54:52] YuviPanda: cool! [17:54:55] YuviPanda: thanks! [17:55:32] mhurd: :) I am also slightly modifying the edit schema. captchaShown instead of captchaEdit [17:56:22] mhurd: done. [17:56:35] in the keys you just added to acct creation it’s “show” not “shown”. maybe do shown in both? [17:56:41] YuviPanda: ^ [17:56:43] mhurd: gah, typo :) [17:56:51] mhurd: can you fix it? [17:56:58] YuviPanda: ya! [17:57:05] mhurd: cool! :) [17:57:11] Chicken Tikka Biryani awaits me ;) [17:57:11] brb [17:57:49] (03CR) 10Cmcmahon: [C: 04-1] "Test passes in Firefox but fails in Chrome:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125857 (owner: 10Jdlrobson) [17:58:51] chrismcmahon: mmm it was passing for me [17:58:56] let me take a look [17:59:08] (03CR) 10Cmcmahon: "also, locators should be in page object and not in the steps" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125857 (owner: 10Jdlrobson) [18:00:36] chrismcmahon: locators..? [18:01:06] jdlrobson: on(ArticlePage).overlay_element.when_present.h2_element(:text => "Nearby") [18:01:15] chrismcmahon: that has nothing to do with this test.. [18:02:08] it might be wrong but it has nothing to do with my patch hence my confusion :) [18:03:03] jdlrobson: it breaks the Page Object design pattern to have element locators in the steps and not in the page object. (and in the long run it makes maintenance difficult) [18:04:03] sure chrismcmahon but it doesn't really have anything to do with this particular patch - a bug/another patch would be better here to ensure that gets dealt with. [18:04:35] jdlrobson: I think this will need some tweaking to make it pass in Chrome, so I noted that as well [18:04:51] chrismcmahon: is it passing for you on master? [18:06:26] brb errands [18:09:02] jdlrobson: passes in master using the New York page [18:09:15] chrismcmahon: that makes no sense.. [18:10:25] chrismcmahon: it's broken for me on master [18:10:34] (chrome only) [18:10:46] so this is definitely unrelated to this patch [18:10:53] should be easy to fix [18:12:55] jdlrobson: actually, I think it might be beta labs, seems to pass for me now [18:14:35] jdlrobson: nope, it's actually flaky for me in Chrome: Scenario: Nearby button visible # features/geonotahack.feature:11 [18:14:35] When I click the nearby button # features/step_definitions/geonotahack_steps.rb:5 [18:14:35] Then I see the nearby overlay # features/step_definitions/geonotahack_steps.rb:9 [18:14:35] expected visible? to return true, got false (RSpec::Expectations::ExpectationNotMetError) [18:16:24] I've got a fix [18:16:27] ^ chrismcmahon [18:16:55] (03PS1) 10Jdlrobson: QA: Fix 'Nearby button visible' test in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126035 [18:16:58] ^ chrismcmahon [18:17:20] chrismcmahon: the problem is on master [18:19:21] (03PS2) 10Jdlrobson: QA: Fix 'Nearby button visible' test in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126035 [18:19:23] (03PS4) 10Jdlrobson: QA: Make the test environment agnostic of existing pages #2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125857 [18:20:06] (03CR) 10Jdlrobson: "Issue is unrelated. See patchset beforehand which corrects this problem." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125857 (owner: 10Jdlrobson) [18:21:40] jdlrobson: do you want to merge 126035 and then deal with 125857? [18:21:59] chrismcmahon: i've fixed the issue and rebased the original patch set off of it [18:22:08] so yes :) [18:23:48] (03CR) 10Cmcmahon: [C: 032] QA: Fix 'Nearby button visible' test in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126035 (owner: 10Jdlrobson) [18:24:06] jdlrobson: I have a meeting, I'll do more later on [18:25:27] (03PS1) 10Jdlrobson: Ensure headings are HTML when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126038 [18:25:42] (03Merged) 10jenkins-bot: QA: Fix 'Nearby button visible' test in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126035 (owner: 10Jdlrobson) [18:26:47] (03PS2) 10Mhurd: Added more logging events. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125935 [18:28:32] (03CR) 10Mhurd: [C: 031] "I like it." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125879 (owner: 10Brion VIBBER) [18:28:48] brion: ^ [18:31:53] (03CR) 10Kaldari: [C: 04-1] "Position of the red icon doesn't match the mock-ups." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [18:32:32] moizsyed: I accidently deleted the first mock-up attachment on card #1747: https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1747 [18:33:03] kaldari: hmm, and theres no undo on this thing? [18:33:12] do you remember what it was? [18:33:16] doesn't look like it [18:33:56] I have no idea. I was trying to click on it to see what it was, but I accidently clicked the delete icon next to it. [18:34:05] it was called notifs1.png [18:34:42] i got it [18:34:44] will post it [18:35:02] argh [18:35:09] but i gotta remember my mingle password [18:35:15] (03PS3) 10Kaldari: Hygiene: Move wgSiteName requirement into other LocalSettings changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125858 (owner: 10Jdlrobson) [18:35:29] (03CR) 10Jdlrobson: "In what way is the position off to you?" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [18:35:58] (03PS3) 10Jdlrobson: QA: Remove dependency on Duel Masters article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125859 [18:36:05] (03PS4) 10Jdlrobson: QA: Remove dependency on diff test page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125860 [18:36:11] (03PS4) 10Jdlrobson: QA: Remove dependency on "Foo bar" article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125861 [18:36:16] (03PS4) 10Jdlrobson: QA: Begin removing dependency on Barack Obama article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125862 [18:36:22] (03PS4) 10Jdlrobson: QA: Identify the license link better [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125863 [18:39:37] jdlrobson: wow, the positioning of the red badge is totally different in Firefox than Chrome. It's that negative margin again. [18:40:10] Firefox is positioning it 0.35ems further to the right and up, which is a lot. [18:40:14] kaldari: sigh that negative margin [18:40:25] this is why i hate negative margins [18:40:47] kaldari: i'll take a look in firefox and see what's going on [18:40:55] Yes, it causes positioning bugs everywhere [18:41:30] kaldari: ok it's just broken in the main header [18:41:57] kaldari: it's actually the table styles :( [18:42:36] I think it's the combination of both. Firefox applies negative margins to table elements differently than chrome apparently [18:43:13] especially when you start using absolute positioning as well, since it changes where the 0 coords are. [18:43:50] mmmmm [18:43:54] any idea how to remedy it? [18:44:27] jdlrobson, jgonera: My understanding is that kaity is OK with getting rid of those margins in the header. If we could get rid of them it would save us countless headaches dealing with the CSS bugs in the browsers. [18:44:52] yes get rid of them kaldari [18:44:54] (03PS3) 10Dr0ptp4kt: Put fixed notification at bottom of window when W0 on. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125887 (owner: 10Mhurd) [18:45:07] kaldari: i think i have a fix for this anyhow [18:45:07] kaldari: do we need design mockups? [18:45:43] kaldari: jdlrobson does removing them need to be in a story? [18:45:59] kaity: it would be fairly easy for us to just remove the margins for now and then we can revisit the header design whenever you like. [18:46:24] kaldari: ok [18:46:46] kaity: this would also be a good improvement for the "last modified" at top change that we are about to do, since other wise it leaves a weird looking gap above the last modified bar. [18:46:47] kaldari: will the spacing look very different though? [18:47:12] mhurd i made updates for toggling w0 state with a memory warning: https://gerrit.wikimedia.org/r/125887 [18:47:20] dr0ptp4kt: ah thanks! [18:47:26] kaity: we could keep the spacing exactly the same, but just make the lines extend all the way [18:48:23] kaldari: fix on the way [18:48:35] cool [18:48:48] (03PS8) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 [18:48:51] ^ kaldari [18:48:55] jdlrobson: I'm going to try to get through reviewing some of your QA stuff today [18:49:05] thanks kaldari that would be much appreciated. chrismcmahon has made a start [18:49:22] i think it will reduce a lot of the false failures in that the test stops using big articles like San Francisco and Barack Obama [18:49:40] (03CR) 10jenkins-bot: [V: 04-1] Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [18:49:42] (03CR) 10Dr0ptp4kt: "Commented memory toggle added. The on/off state value persists between app sessions." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125887 (owner: 10Mhurd) [18:50:06] kaldari: can we remove the 2 vertical lines? [18:50:26] jdlrobson: kaldari keep in mind that the infrastructure to make all these work was final this morning. :-) now we have that, I think we can merge a lot of what Jon has done [18:51:40] cool [18:54:00] "was final" ? [18:54:15] the 2 vertical lines? [18:54:39] (03CR) 10Brion VIBBER: [C: 032 V: 032] "merrrrge!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125879 (owner: 10Brion VIBBER) [18:54:52] (03PS1) 10Mhurd: Nav bar label can shrink text a bit for long l10n strings. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126047 [18:54:54] (03PS3) 10Brion VIBBER: Added more logging events. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125935 (owner: 10Mhurd) [18:54:59] brion: yay! [18:55:01] (03PS9) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 [18:55:25] brion: this one should be pretty quick: https://gerrit.wikimedia.org/r/126047 [18:55:48] adjustsFontSizeToFitWidth best property EVAR [18:55:59] (03CR) 10Brion VIBBER: [C: 032 V: 032] Nav bar label can shrink text a bit for long l10n strings. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126047 (owner: 10Mhurd) [18:56:14] brion: merge the small android ones too when you're done? :) [18:56:27] ok [18:58:07] (03CR) 10Brion VIBBER: [C: 032 V: 032] Added more logging events. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/125935 (owner: 10Mhurd) [18:58:14] woohoo! [19:00:29] kaldari: that event logging you put in place for uploads i'm not yet seeing anything.. [19:02:19] kaldari: nothing on log stash unless i'm searching for the wrong thing.. [19:02:21] oh yeah [19:02:34] I'll take a look... [19:03:44] jdlrobson: there's plenty of errors in the log on fluorine [19:04:29] 2014-04-15 18:53:50 mw1205 commonswiki: Filename: '1397588026908Cesaro_Wrestlemania_xXx.jpg', mDesiredDestName: '1397588026908Cesaro _ Wrestlemania xXx.jpg', comparableName: '1397588026908Cesaro___Wrestlemania_xXx.jpg' [19:04:46] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix keyboard not hiding when it should [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125975 (owner: 10Yuvipanda) [19:04:54] kaldari: are they shown on logstash? [19:04:57] brion: no more V+2 needed :P [19:05:02] bahhhhh [19:05:06] what's logstash? [19:05:36] https://logstash.wikimedia.org [19:07:13] kaldari: which log are you looking in? [19:07:40] fancy. I'm looking at /a/wm-log/upload.log [19:07:41] (03CR) 10Brion VIBBER: [C: 032] Fix Account Creation not working [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125982 (owner: 10Yuvipanda) [19:07:56] ok now i see [19:07:57] (03CR) 10Cmcmahon: [C: 032] QA: Remove dependency on Duel Masters article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125859 (owner: 10Jdlrobson) [19:08:32] ooh kaldari there are cases where the full path is used [19:09:11] kaldari: what is comparable name and desired name? [19:09:47] (03CR) 10Brion VIBBER: Fix crash when loading unreachable image (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125985 (owner: 10Yuvipanda) [19:09:50] Those are the two values that it gets compared with to determine if the filename can be used. One sec and I'll show you... [19:10:31] also kaldari these do not seem to be mobile specific [19:10:43] jdlrobson: checkout /includes/upload/UploadBase.php around line 614 [19:11:00] jdlrobson: yes, they are not mobile specific as the error comes from the uploading API [19:11:48] kaldari: i don't have a line 614.. [19:11:53] oh wait UploadBase [19:11:53] and the API only returns a generic error [19:11:59] (03CR) 10Yuvipanda: Fix crash when loading unreachable image (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125985 (owner: 10Yuvipanda) [19:12:01] brion: good catch [19:12:06] \o/ [19:12:11] kaldari: so how can we link the mobile errors to these errors? [19:12:24] jdlrobson: Check UploadBase::checkWarnings() [19:13:42] well, we could either find one manually or add another log on the mobile side. [19:14:51] I was assuming most of the badfilename errors were coming from the mobile interface, but maybe that isn't the case [19:15:53] kaldari: anything with 2014- in title we can probably safely assume is mobile [19:16:46] kaldari: http://etherpad.wikimedia.org/p/Upload_debugging [19:16:50] so let's take this as an example [19:16:52] brion: fixed [19:16:53] what's going wrong here? [19:16:57] (03PS2) 10Yuvipanda: Fix crash when loading unreachable image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125985 [19:16:59] (03PS1) 10Yuvipanda: Moved search handler to its own class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126057 [19:17:30] brion: and minor hygiene patch [19:17:35] whee [19:17:48] (03CR) 10Brion VIBBER: [C: 032] Fix crash when loading unreachable image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125985 (owner: 10Yuvipanda) [19:17:56] kaldari: super weird voodoo going on there [19:18:03] kaldari: Jenkins doesn't like me today, want to try to +2 this also? https://gerrit.wikimedia.org/r/#/c/125859/ (second time today Jenkins ignored my +2) [19:18:43] (03CR) 10Brion VIBBER: [C: 032] Moved search handler to its own class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126057 (owner: 10Yuvipanda) [19:18:49] chrismcmahon: it has a dependency [19:18:53] that's why it's ignoring it [19:19:02] jdlrobson: yeah, it'll take me a minute to figure out what's going on there. eating lunch right now. Don't you guys go to lunch when I'm not there? ;) [19:19:04] it's dependent on https://gerrit.wikimedia.org/r/#/c/125858/3 and https://gerrit.wikimedia.org/r/#/c/125857/4 [19:19:22] which haven't been +2ed or +1ed [19:23:39] jdlrobson: What the hell is going on with that file name on the Etherpad? That is super weird. [19:23:45] kaldari: exactly [19:24:40] it looks like the main problem is whitespace condensing [19:24:42] kaldari: oh wait i think line numbers are showing up there [19:24:44] 1s [19:25:44] sometimes there are more than 1 spaces in front of the date [19:26:10] (03CR) 10Cmcmahon: [C: 032] Hygiene: Move wgSiteName requirement into other LocalSettings changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125858 (owner: 10Jdlrobson) [19:27:07] mhurd: note that violetto has been filing bugs in bugzilla for the iOS app. do check out :) [19:27:19] YuviPanda: ah thanks [19:29:10] kaldari: yeh it seems it is always to do with spacing before the date [19:30:41] jdlrobson: although in the "Pagi_Nan.." one it's a double space in the middle of the filename [19:30:55] the really long one I mean [19:31:08] so could this be related to double spaces? [19:31:43] ooohh [19:31:48] kaldari i replicated it with title "double space woop woop " [19:31:59] WIN [19:33:02] (03CR) 10Cmcmahon: [C: 032] QA: Make the test environment agnostic of existing pages #2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125857 (owner: 10Jdlrobson) [19:33:16] kaldari: i'm gonna grab lunch then fix it :D [19:33:39] YuviPanda: mhurd yep i tried it today! [19:33:41] jdlrobson: cool, hopefully I'll have some of your QA stuff merged when you're done [19:33:51] violetto: :D [19:34:45] (03Merged) 10jenkins-bot: QA: Make the test environment agnostic of existing pages #2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125857 (owner: 10Jdlrobson) [19:34:54] (03Merged) 10jenkins-bot: Hygiene: Move wgSiteName requirement into other LocalSettings changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125858 (owner: 10Jdlrobson) [19:35:22] (03Merged) 10jenkins-bot: QA: Remove dependency on Duel Masters article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125859 (owner: 10Jdlrobson) [19:35:54] gaaah, our API is stupid [19:36:24] YuviPanda: :D [19:36:27] ookkk lunch [19:57:54] (03PS1) 10Yuvipanda: Do not enforce spacing around curly braces [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126068 [19:57:55] brion: ^ [19:58:03] brion: minor checkstyle change [19:58:13] (03Merged) 10jenkins-bot: Fix crash when loading unreachable image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125985 (owner: 10Yuvipanda) [19:58:18] (03Merged) 10jenkins-bot: Moved search handler to its own class [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126057 (owner: 10Yuvipanda) [20:03:59] (03PS2) 10Yuvipanda: Do not enforce spacing around curly braces [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126068 [20:07:22] (03CR) 10Brion VIBBER: [C: 032] Do not enforce spacing around curly braces [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126068 (owner: 10Yuvipanda) [20:07:44] (03Merged) 10jenkins-bot: Do not enforce spacing around curly braces [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126068 (owner: 10Yuvipanda) [20:08:38] (03PS1) 10Yuvipanda: Fix checkstyle.xml to work on older checkstyles [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126086 [20:09:05] brion: ^ the previous patch broke jenkins [20:09:10] brion: let me wait till this one passes :D [20:09:14] woops [20:10:40] brion: woo, this passes. and our warning count is now under 250! [20:11:26] (03CR) 10Brion VIBBER: [C: 032] Fix checkstyle.xml to work on older checkstyles [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126086 (owner: 10Yuvipanda) [20:11:47] (03Merged) 10jenkins-bot: Fix checkstyle.xml to work on older checkstyles [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126086 (owner: 10Yuvipanda) [20:15:12] (03PS1) 10Yuvipanda: Add spaces where required to match checkstyle. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126112 [20:16:47] (03PS1) 10Yuvipanda: Fix ordering of class definition modifier [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126113 [20:17:50] (03PS1) 10Yuvipanda: Rename static variables to match ALL_CAPS_SHOUT [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126114 [20:20:33] (03PS1) 10Jdlrobson: Avoid file names with double spaces [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126115 [20:21:25] ^ kaldari :D [20:21:37] (03PS2) 10Jdlrobson: Avoid file names with double spaces [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126115 [20:22:42] (03PS1) 10Yuvipanda: Make sure all switches have a default case [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126116 [20:23:10] (03PS1) 10Yuvipanda: Fix account creation tests so they still run [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126117 [20:23:11] brion: a bunch of minor patches, largely code formatting. [20:24:57] addshore: ^. almost close to 200 errors [20:25:18] whee [20:25:20] brion: what are your thoughts on https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/128/checkstyleResult/type.1289032088/ [20:25:26] brion: I am considering disabling it. [20:26:20] YuviPanda: yeah that just sounds annoying :D [20:26:48] brion: it can cause fuckups sometimes when you don't realize you are doing it, but in this case... [20:27:05] (03CR) 10Brion VIBBER: [C: 032] Add spaces where required to match checkstyle. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126112 (owner: 10Yuvipanda) [20:27:20] (03CR) 10Brion VIBBER: [C: 032] Fix ordering of class definition modifier [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126113 (owner: 10Yuvipanda) [20:27:27] brion: ah, hmm. let me try to tweak it [20:28:53] (03PS1) 10Yuvipanda: Ignore setter and constructors for HiddenFieldCheck [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126120 [20:28:54] brion: made it a lot less noisy! [20:29:03] (03CR) 10Brion VIBBER: [C: 04-1] "AFAIK statics are usually CAPS because they're often used as constants, which by convention are caps-ish since C days." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126114 (owner: 10Yuvipanda) [20:29:52] (03CR) 10Yuvipanda: "I think the fix in this case is to make this variable non static, and move all Zero logic into a ZeroHandler which the app holds as a sing" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126114 (owner: 10Yuvipanda) [20:30:23] (03PS2) 10Yuvipanda: Ignore setter and constructors for HiddenFieldCheck [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126120 [20:30:25] (03PS2) 10Yuvipanda: Make sure all switches have a default case [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126116 [20:30:27] (03PS2) 10Yuvipanda: Fix account creation tests so they still run [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126117 [20:30:31] brion: either way, I took that patch out of the series so we can merge the rest without having to wait on that discussion. [20:30:35] ok [20:30:42] addshore: under 100 errors! [20:30:57] (03CR) 10Brion VIBBER: [C: 032] Ignore setter and constructors for HiddenFieldCheck [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126120 (owner: 10Yuvipanda) [20:31:16] (03CR) 10Brion VIBBER: [C: 032] Fix account creation tests so they still run [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126117 (owner: 10Yuvipanda) [20:32:06] (03CR) 10Brion VIBBER: [C: 032] Make sure all switches have a default case [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126116 (owner: 10Yuvipanda) [20:35:29] (03CR) 10Cmcmahon: [C: 032] QA: Remove dependency on diff test page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125860 (owner: 10Jdlrobson) [20:37:16] awjr, should the email about kickoff go to mobile-l or mobile-tech? [20:37:29] (03Merged) 10jenkins-bot: QA: Remove dependency on diff test page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125860 (owner: 10Jdlrobson) [20:38:28] jgonera: they seem to traditionally go to mobile-tech but i see no reason why they should [20:38:44] jdlrobson: So you have to have Opera installed to run the non-JS tests? [20:38:55] kaldari: nope [20:39:02] kaldari: you have to use firefox driver [20:39:02] jgonera: mobile-tech [20:39:04] it spoofs the user agent [20:39:12] awjr: is there any reason they go to mobile-tech? [20:39:30] ok, I'll send to mobile-tech, I mean, it's pretty internal, I don't think anyone would have interest in it [20:39:55] awjr: i don't see why and they would be useful to give a heads up on what we are working on to other teams [20:41:37] jdlrobson: jgonera i think it's fine if you prefer it go to mobile-l, but i thought we were keeping team-specific stuff on mobile-tech [20:41:55] i've been sending all of our team coordination emails to mobile-tech and everyhting else to mobile-l [20:42:03] jdlrobson: I'm using the selenium webdriver with Firefox, but it says "Unable to pick a platform for the provided browser". Do I need to update my gems or install something special? [20:42:20] awjr: i don't really mind either way, i'm just making the argument that it has //some// value. [20:42:24] kaldari: it should just work.. [20:42:40] kaldari bundle install won't hurt [20:44:01] jdlrobson: did a full gem update and bundle install, but still get the same error [20:45:19] http://pastebin.com/2G6qrU6j [20:45:47] (03PS1) 10Yuvipanda: Don't count blocks as empty if they have comments in them [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126128 [20:46:09] hmm, it says undefined method 'close' [20:46:22] also [20:46:31] kaldari: Does Foo page exist? [20:46:52] yes [20:49:46] kaldari: i'm not sure then - is there a patch set you are trying to review? [20:49:56] (03PS1) 10Yuvipanda: Mark some uninheritable classes as final [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126129 [20:50:08] jdlrobson: https://gerrit.wikimedia.org/r/#/c/124742/ [20:50:14] maybe you could just remove that one for now [20:50:47] kaldari: mmm to be fair that's going to need to be rewritten [20:50:52] after all the other hygiene patches are merged [20:51:09] if you review those i'll revisit it when the majority of the other patches are merged [20:51:33] OK, I'll -1 this one for now. [20:51:34] (03CR) 10Jdlrobson: [C: 04-1] "This isn't agnostic of the test environment." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 (owner: 10Jdlrobson) [20:52:01] kaldari: do you get that error on current master though? [20:52:31] let me pull to master and try it again... [20:52:53] (03CR) 10JGonera: [C: 032] Avoid file names with double spaces [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126115 (owner: 10Jdlrobson) [20:53:31] (03Merged) 10jenkins-bot: Avoid file names with double spaces [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126115 (owner: 10Jdlrobson) [20:55:34] kaldari: did you manage to get your internet set up? [20:56:45] awjr: the tower is complete. The dish installer guy is supposed to come by any minute now [20:56:52] nice! [20:57:17]