[00:00:12] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Fix 'undefined' showing up in section titles [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126141 (owner: 10Yuvipanda) [00:00:31] (03Merged) 10jenkins-bot: Fix 'undefined' showing up in section titles [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126141 (owner: 10Yuvipanda) [00:01:05] violetto: is there a specific font icon i can look for to confirm my fontbook has your latest? (just installed, but not sure if it overwrote properly) [00:01:49] you should be able to see caret and a download icons [00:02:02] i'll find a way to attach a picture of the latest in the repo too [00:03:51] jgonera: did you see my -1 on https://gerrit.wikimedia.org/r/#/c/124034/ btw? [00:04:36] jdlrobson, I did, I'm not sure how those two things are related [00:04:48] also, this was present for a while I guess [00:05:09] and I'd rather not spend too much time if we're moving typography stuff soon [00:05:38] violetto: hmm not sure i’m seeing those… oh, one more thing - the default copywrite text (you can see if you click “i” icon the fontbook) needs to be updated [00:05:48] jgonera: well the bug talks about styling issues in the search overlay, so I was basically saying this doesn't actually fix what is reported in the bug. I can merge it but the bug can't really be called fix until typography is moved to stable [00:05:52] I even think I tried to track it down in the past but it seems to have the same dimensions, same font-size yet still renders differently [00:05:57] if it's too tricky i'm fine pushing it [00:06:02] violetto: what does the download icon look like? [00:06:12] jdlrobson, if you have time, you can have a look at it [00:07:01] jgonera: i guess i'll merge a raise another bug [00:07:06] jdlrobson, I'm wondering, maybe we should use px instead of ems for sizing... although the font size is in ems so I remember styling something was difficult using px [00:07:23] anyway, I guess the recommendation of not using px for font size is becoming obsolete nowadays [00:07:28] jdlrobson, ok [00:07:54] (03CR) 10Jdlrobson: [C: 032] "Raised a new bug for 1px bug" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124034 (owner: 10JGonera) [00:08:03] (03CR) 10Jdlrobson: "See https://bugzilla.wikimedia.org/show_bug.cgi?id=63982" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124034 (owner: 10JGonera) [00:08:23] (03Merged) 10jenkins-bot: Fix styling of "No page with this title" in search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124034 (owner: 10JGonera) [00:09:48] (03PS10) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 [00:11:59] (03PS1) 10Cmcmahon: QA tests that create pages should not run in prod [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126175 [00:13:18] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Add partial support for DISPLAYTITLE [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126146 (owner: 10Yuvipanda) [00:13:35] (03Merged) 10jenkins-bot: Add partial support for DISPLAYTITLE [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126146 (owner: 10Yuvipanda) [00:16:38] (03PS4) 10Jdlrobson: Card 1757: Add EventLogging to Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124657 [00:18:41] (03PS2) 10Jdlrobson: QA: Tests that create pages should not run in prod [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126175 (owner: 10Cmcmahon) [00:18:46] (03CR) 10Jdlrobson: [C: 032] QA: Tests that create pages should not run in prod [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126175 (owner: 10Cmcmahon) [00:19:22] (03Merged) 10jenkins-bot: QA: Tests that create pages should not run in prod [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126175 (owner: 10Cmcmahon) [00:20:52] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Kill 'scratch' directory [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126149 (owner: 10Yuvipanda) [00:21:07] (03Merged) 10jenkins-bot: Kill 'scratch' directory [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126149 (owner: 10Yuvipanda) [00:21:22] (03CR) 10MaxSem: [C: 032] Card 1757: Add EventLogging to Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124657 (owner: 10Jdlrobson) [00:22:52] (03Merged) 10jenkins-bot: Card 1757: Add EventLogging to Special:MobileOptions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124657 (owner: 10Jdlrobson) [00:23:37] (03CR) 10Jdlrobson: Ensure headings are HTML when needed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126038 (owner: 10Jdlrobson) [00:24:44] (03PS2) 10Jdlrobson: Ensure headings are HTML when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126038 [00:27:46] (03PS1) 10Dr0ptp4kt: Bump alpha to v37 2.0-alpha-2014-04-15. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126180 [00:28:03] mhurd: done! [00:28:10] violetto: yay! [00:29:27] mhurd: i included a screenshot this time so everyone can check [00:30:05] violetto: perfect! [00:30:10] violetto: will check now [00:32:33] (03PS1) 10Mhurd: Fix for alert sometimes now wrapping precisely. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126181 [00:33:27] brion: ^ pretty small patch [00:35:54] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] Bump alpha to v37 2.0-alpha-2014-04-15. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126180 (owner: 10Dr0ptp4kt) [00:36:07] brion ^ uploading new android alpha pretty soon [00:36:10] (03Merged) 10jenkins-bot: Bump alpha to v37 2.0-alpha-2014-04-15. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126180 (owner: 10Dr0ptp4kt) [00:44:22] (03PS1) 10JGonera: Story 1920: Show minor edit tags on watchlist and history pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126184 [01:25:52] (03PS1) 10Dr0ptp4kt: Structure User-Agent similarly to Android app reboot. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 [07:52:37] OMG ABOUT 50 WARNINGS ONLY! https://integration.wikimedia.org/ci/job/apps-android-wikipedia-maven-checkstyle/151/checkstyleResult/? [09:10:28] YuviPanda: gooood job! [09:10:40] hashar: :D Only about 50 or so left, and I'm killing some now [09:13:07] hashar: hopefully they can be zero and we can make it voting before end of week [09:13:38] !! [09:14:15] hashar: :) [09:14:39] hashar: also I have a shell script that gets latest android sdk and installs it. Is that enough for contint? [09:14:44] hashar: the packages seem wonky [09:16:08] YuviPanda: have you looked at the Debian packages provided in recent versions of Ubuntu? [09:16:17] hashar: https://packages.debian.org/source/sid/androidsdk-tools those? [09:17:32] yup [09:17:38] pasted some informations on the bug report [09:22:16] hashar: hmm, ok. I'll try and take a look soon [09:22:19] hashar: but first voting checkstyle! [13:00:13] (03PS1) 10Yuvipanda: Make magic numbers unmagical [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126237 [13:00:38] (03PS1) 10Yuvipanda: Fix broken tests for Page properties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126238 [13:40:59] (03PS1) 10Yuvipanda: Add Phone/Tablet modifier to UA [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126247 [15:13:11] (03PS1) 10Cmcmahon: QA license link should point to creativecommons.org [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126263 [15:25:04] (03CR) 10Cmcmahon: "the change at https://gerrit.wikimedia.org/r/#/c/125863 seems to have broken ui_links.feature. How about we just make sure the link points" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126263 (owner: 10Cmcmahon) [15:28:19] brion: hey! [15:44:10] (03CR) 10Cmcmahon: [C: 04-1] "When this test runs in beta labs, when clicking "Search in pages", the search properly returns no results." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 (owner: 10Jdlrobson) [16:17:35] (03CR) 10OliverKeyes: [C: 04-1] "Doing this effectively removes our ability to do device identification for the iPhone app; ua-parser can't see device or version (although" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 (owner: 10Dr0ptp4kt) [16:29:53] (03CR) 10Yuvipanda: "This is compliant with the UA RfC as qchris pointed out. Perhaps there's a toggle somewhere in UA parser that lets it parse these? Or is U" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 (owner: 10Dr0ptp4kt) [16:30:17] (03CR) 10Yuvipanda: [C: 031] "(Also note - Android further mentions if the device is a tablet or not. iOS probably should too)" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 (owner: 10Dr0ptp4kt) [16:33:32] (03CR) 10Yuvipanda: "QChris lays it out in http://lists.wikimedia.org/pipermail/analytics/2014-March/001730.html" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 (owner: 10Dr0ptp4kt) [16:39:20] hey YuviPanda wassap [16:39:25] hey brion! [16:39:31] brion: small patches [16:39:42] \o/ [16:39:52] ok i’ll look those over in a few [16:39:59] brion: warnings to about 50! [16:40:08] nice [16:47:18] (03PS2) 10Yuvipanda: Fix UA to provide phone/tablet info [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126247 [16:48:04] (03CR) 10OliverKeyes: "The semicolon was the problem (for android); now fixed. Will fix for iOS now." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 (owner: 10Dr0ptp4kt) [16:49:20] (03CR) 10Yuvipanda: "https://gerrit.wikimedia.org/r/126247 for the Android patch." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 (owner: 10Dr0ptp4kt) [16:50:01] (03PS1) 10Kaldari: Make sure VisualEditor is installed before trying to use it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126672 [16:50:35] (03CR) 10jenkins-bot: [V: 04-1] Make sure VisualEditor is installed before trying to use it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126672 (owner: 10Kaldari) [16:52:54] (03PS2) 10Kaldari: Make sure VisualEditor is installed before trying to use it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126672 [16:54:58] New Android alpha :D [16:55:24] ragesoss: we're pushing one out every day these days :) [17:05:58] YuviPanda: heya! [17:06:07] mhurd: heya! [17:07:09] YuviPanda: hey do you have the watchlist query already? the “titles on my watchlist” and “titles on my watchlist which have been modified recently” queries specifically [17:07:15] mhurd: I'm writing my EL stuff now. Will figure out access for me too. [17:07:21] mhurd: oh, no, haven't been looking at those at all. [17:07:32] mhurd: https://www.mediawiki.org/wiki/API:Watchlist [17:07:39] YuviPanda: ah thanks! [17:08:46] (03CR) 10OliverKeyes: "You want something like WikipediaApp/v2.0 (iPhone OS 4_4; tablet) or WikipediaApp/v2.0 (iPhone OS 4_4; mobile), which outputs:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 (owner: 10Dr0ptp4kt) [17:15:28] mmmm coffee [17:16:04] standup? [17:16:05] mhurd: I'll have EL access soon and can verify :) [17:16:10] brion: oh fuck [17:16:10] yeah [17:16:22] “You're not allowed to join this video call.” oh well so much for this working in firefox [17:19:49] jdlrobson: im not finding a card in the backlog for the typography stuff you said would fix the 1px of death - but maybe i am just not seeing it; do you see it in here? https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards?favorite_id=11180&view=Q4+Prioritization [17:20:00] (03CR) 10Jdlrobson: [C: 04-1] "Let me provide an alternative fix ." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126263 (owner: 10Cmcmahon) [17:20:08] awjr: i'll take a look in a sec [17:20:16] np [17:20:48] (03PS1) 10Jdlrobson: Flatten red links in JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126723 [17:25:09] awjr: yeh i don't see a story [17:25:16] YuviPanda: oh, who should i ping or email about getting access to check logs too? [17:25:18] so I guess one should be created! :) [17:25:41] :) [17:25:45] i'll take care of it [17:25:46] mhurd: andrew otto should know (ottomata) [17:26:03] YuviPanda: cool thanks! [17:26:18] mhurd: ask for stat1003 access. access to check logs are something else. [17:26:29] YuviPanda: oh that’s right :) [17:26:33] mhurd: :) [17:27:18] (03CR) 10Jdlrobson: [C: 032] Make sure VisualEditor is installed before trying to use it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126672 (owner: 10Kaldari) [17:27:50] (03Merged) 10jenkins-bot: Make sure VisualEditor is installed before trying to use it [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126672 (owner: 10Kaldari) [17:34:17] tfinc: can't hear you guys [17:35:01] tfinc: still can't hear you [17:35:01] YuviPanda: yeah, this mini looks all sorts of broken [17:35:01] tfinc: ah, can hear now [17:35:01] (03CR) 10Brion VIBBER: [C: 032] Fix FieldHidden warnings & turn off warnings for params [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126156 (owner: 10Yuvipanda) [17:35:03] brion: just waiting on you [17:35:08] ah moment [17:35:53] (03PS11) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 [17:36:20] (03CR) 10Jdlrobson: Card 1816: Change the notifications icon in beta (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [17:43:37] tfinc: is kenanwang in your meeting? could you get him to come on irc? I have a super quick question [17:43:56] jdlrobson: he is in the meeting [17:44:05] YuviPanda: yeh i saw [17:44:08] jdlrobson: can't right now. were in the middle of a prioritization meeting [17:44:11] ok [17:45:56] violetto: damn, I missed the joke but I heard the laughter. [17:46:38] i want to hear the joke :( [17:48:55] (03CR) 10Brion VIBBER: [C: 032] Make magic numbers unmagical [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126237 (owner: 10Yuvipanda) [17:50:39] (03CR) 10Brion VIBBER: [C: 032] Fix broken tests for Page properties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126238 (owner: 10Yuvipanda) [17:51:30] (03PS1) 10Jdlrobson: QA: Correct css selector for license link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126740 [17:51:31] ^ chrismcmahon [17:51:48] (03CR) 10Jdlrobson: "See https://gerrit.wikimedia.org/r/126740" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126263 (owner: 10Cmcmahon) [17:51:54] jdlrobson: gotcha [17:52:01] id not class! :) [17:53:33] (03CR) 10Brion VIBBER: [C: 032] Fix UA to provide phone/tablet info [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126247 (owner: 10Yuvipanda) [18:05:59] (03PS1) 10Jdlrobson: QA: Ensure wiki is setup with terms of use link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126744 [18:08:39] (03CR) 10Kaldari: [C: 032] QA: Correct css selector for license link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126740 (owner: 10Jdlrobson) [18:09:10] (03Merged) 10jenkins-bot: QA: Correct css selector for license link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126740 (owner: 10Jdlrobson) [18:09:41] brion: what device did you use? [18:09:47] * YuviPanda has a Samsung Galaxy Ace for 2.3 [18:09:51] YuviPanda: nexus one [18:09:57] yeah use something else just in case it’s different :D [18:09:58] brion: ah, cool! so that's two :) [18:10:00] :) [18:13:09] (03CR) 10Jdlrobson: [C: 04-1] "A few minor tweaks" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126184 (owner: 10JGonera) [18:15:44] YuviPanda: hello [18:15:54] chat quickly about article protection levels? [18:16:08] brion: any time to poke https://gerrit.wikimedia.org/r/#/c/126181/ and https://gerrit.wikimedia.org/r/#/c/126170/ ? [18:16:33] mhurd: in a few minutes, grabbing a quick bite [18:16:44] brion: sounds good! [18:19:28] vbamba: heya! [18:19:29] vbamba: sure@ [18:19:31] sure! [18:19:59] So even if you are logged in articles have all kinds of criteria, depending on the admin. is that accurate? [18:20:07] vbamba: indeed. [18:20:28] As a result, even logged in users will not be able to edit certain article. Correct? [18:20:32] vbamba: indeed. [18:20:39] Do we want to just show pencil icons with locks for these articles? [18:20:49] vbamba: indeed. [18:20:50] Im trying to find examples on mobile web [18:21:23] tfinc, https://rt.wikimedia.org/Ticket/Display.html?id=5003 [18:21:31] (03PS1) 10Jdlrobson: Hygiene: PHPDocs comments should not not use curly braces [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126803 [18:22:05] vbamba: India article is protected [18:22:32] vbamba: do i now have your phone number?! ;-) [18:22:39] (http://minus.com/i/PRu9xzYTFDHy) [18:22:57] shit! [18:23:19] jdlrobson: deleted [18:23:22] (03CR) 10Siebrand: [C: 04-1] Hygiene: PHPDocs comments should not not use curly braces (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126803 (owner: 10Jdlrobson) [18:25:51] YuviPanda: haha, its an old phone number [18:26:07] vbamba: still, apologies for not checking for Personal info thoroughly. New one is cropped [18:28:23] (03CR) 10MaxSem: [C: 032] Flatten red links in JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126723 (owner: 10Jdlrobson) [18:29:00] (03Merged) 10jenkins-bot: Flatten red links in JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126723 (owner: 10Jdlrobson) [18:32:52] * YuviPanda waves at vbamba [18:33:29] that why i didnt sent to mobile I [18:33:44] vbamba: yeah, figured that a bit late. Will be more careful next time :) [18:33:58] YuviPanda: its ok, [18:34:19] so conclusion for articles with any kind of protection is show pencils with locked icons? [18:34:26] vbamba: indeed. [18:34:40] ok, resolved. [18:34:44] vbamba: :) [18:35:15] violetto: vbamba I just realized we didn't talk about references *at all* [18:36:12] Is the story card for it on the backlog? [18:36:29] YuviPanda: ^ [18:37:17] vbamba: there isn't. [18:37:48] vbamba: I'm adding [18:37:49] one [18:38:18] vbamba: it's at the top of ready for prio [18:43:02] excellent, thanks [18:43:09] YuviPanda: thanks for fixing the screenshot [18:43:11] =] [18:43:19] vbamba: np! [18:43:32] May and Kiaty have worked on the design for that [18:43:50] vbamba: yeah, there was a mobile-l thread and I talked to kaity|away too. [18:44:00] vbamba: just not in trello, so missed today I guess [18:44:54] (03CR) 10MaxSem: Hygiene: PHPDocs comments should not not use curly braces (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126803 (owner: 10Jdlrobson) [18:44:56] jdlrobson: do you have a trello account? [18:45:15] awjr: yes [18:45:25] jonrobson1 [18:45:27] thnx [18:45:50] (03CR) 10Siebrand: "Please have a peak at all the consistency changes in core documenation, and see if there are any colons in there." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126803 (owner: 10Jdlrobson) [18:46:02] (03Abandoned) 10Cmcmahon: QA license link should point to creativecommons.org [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126263 (owner: 10Cmcmahon) [18:46:22] (03Abandoned) 10MaxSem: Use core message instead of mobile-frontend-privacy-link-text [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123886 (owner: 10MaxSem) [18:51:46] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Seems to work with the little fake default switch flipped :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126170 (owner: 10Dr0ptp4kt) [18:54:09] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for alert sometimes now wrapping precisely. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126181 (owner: 10Mhurd) [18:54:30] brion: woohoo! [18:54:35] brion: thx! [18:54:40] mhurd: i notice another wrapping-related problem [18:54:47] brion: ooh where? [18:54:55] on the edit summary screen, in some localizations the individual boxes are too wide [18:54:59] lemme wrassle up a screenshot [18:55:12] brion: ah! [18:55:22] brion: good catch! [18:56:39] mhurd: https://upload.wikimedia.org/wikipedia/mediawiki/b/bf/Screenshot_iOS_app_with_wide_boxes_need_wrapping.png [18:57:55] brion: ah! uicollectionview w/ flow to the rescue! [18:58:05] \o/ [19:02:20] jgonera: prioritization [19:05:07] https://trello.com/b/sFlwoPUn/mobile-web-q4-backlog [19:05:12] https://trello.com/b/NjJtUGAz/mobile-web-next-sprint-v [19:05:47] (03PS2) 10Jdlrobson: Hygiene: Cleanup PHPDocs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126803 [19:05:49] (03PS1) 10Jdlrobson: WIP: Generate PHPDoc via Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126825 [19:06:31] (03CR) 10jenkins-bot: [V: 04-1] WIP: Generate PHPDoc via Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126825 (owner: 10Jdlrobson) [19:06:59] (03CR) 10Jdlrobson: [C: 04-1] "wip" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126825 (owner: 10Jdlrobson) [19:08:49] (03PS4) 10Jdlrobson: WIP: Switch to JsDuck for documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120587 [19:09:02] (03CR) 10Jdlrobson: [C: 04-1] "Need to work out what to do about non-classes" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120587 (owner: 10Jdlrobson) [19:17:05] (03CR) 10Jdlrobson: "On beta labs I get:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 (owner: 10Jdlrobson) [19:23:42] mhurd: ping! I'm looking at EL data and not seeing anything from iOS? [19:26:26] (03CR) 10Cmcmahon: "the message you show here looks like a login failure at the API." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 (owner: 10Jdlrobson) [19:27:34] jgonera: jdlrobson http://hatjitsu.wmflabs.org/71803 [19:29:09] brion, thanks for the review [19:29:19] \o/ [19:45:36] jgonera: DeviceDetection::detectMobileDevice() [19:52:01] YuviPanda: sry was lunching :) [19:52:14] mhurd: I also have a realtime feed of it now so if you want to test in the next few mins I can just monitor for you [19:52:30] YuviPanda: oh! yeah! one sec [19:52:43] mhurd: you've to tell me which schema you are going to try as well [19:53:15] YuviPanda: k. edit schema [19:53:34] mhurd: MobileWikiAppEdit [19:53:34] right [19:53:40] YuviPanda: ya [19:53:49] clicking edit and stuff now [19:53:52] mhurd: cool I've a grep waiting so if you hit anything I should see [19:54:17] YuviPanda: nothing? [19:54:23] mhurd: nope [19:54:34] YuviPanda: hmm hold on [19:54:56] YuviPanda: hitting this endpoint: https://bits.wikimedia.org/event.gif [19:55:12] mhurd: indeed [19:55:41] YuviPanda: example url : https://bits.wikimedia.org/event.gif?%7B%22schema%22%3A%22MobileWikiAppEdit%22%2C%22event%22%3A%7B%22action%22%3A%22start%22%7D%2C%22revision%22%3A8134783%7D [19:55:50] YuviPanda: see anything i’m missing? [19:56:07] mhurd: pageNS is a required parameter, but even then it should show up [19:56:20] mhurd: editSessionToken is also a required parameter [19:57:27] YuviPanda: yeah those still need to be added. but, as you said, should it show up even w/o those? [19:57:37] mhurd: I think it should, but let me find out again [19:59:11] mhurd: try now? [19:59:17] YuviPanda: k [19:59:44] YuviPanda: nothing? [19:59:53] mhurd: ok, I see them this time. [19:59:58] YuviPanda: ah! [20:00:20] mhurd: I was looking only at the postprocessed ones [20:00:26] YuviPanda: cool! [20:00:27] mhurd: so it's hitting the server but failing validation [20:00:34] mhurd: so you need to add the other two required params [20:00:40] YuviPanda: ah. makes sense [20:00:45] kaldari: would be great to get https://gerrit.wikimedia.org/r/126174 merged before the cut off [20:00:53] it means we can push it to stable quicker ;-) [20:01:04] YuviPanda: will get those added [20:01:13] YuviPanda: hopefully by end of day [20:01:15] mhurd: ok! [20:01:29] jdlrobson: I'll try to take a look today [20:01:31] mhurd: do email to get access. It takes about 4 'business days' so the earlier you start the better [20:02:14] YuviPanda: k. i’ll email andrew [20:04:17] YuviPanda: emailed [20:04:41] mhurd: ok! :) [20:12:56] jgonera, https://gerrit.wikimedia.org/r/125929 [20:31:05] (03CR) 10JGonera: "Not sure about the need for another class (.main-header-button) for those buttons in the header. Essentially, they should both have at mos" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [20:45:31] mw-jenkinsbot: [20:45:31] thedj you may not issue bot commands in this chat! [20:45:58] hehe [20:46:57] thedj: we should talk at some point about zurich and maps and what's the best possible outcome for the event... [20:47:25] yes we should [20:47:42] the problem is when [20:48:59] :-) you are on UTC+1 ? [20:50:22] jgonera: ping [20:50:41] yes? [20:50:55] (03PS12) 10Jdlrobson: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 [20:51:07] jgonera: https://gerrit.wikimedia.org/r/#/c/124027/11..12/less/common/ui.less [20:51:13] that was why I introduced it [20:51:18] must have got lost in rebase [20:52:19] mhurd: fyi - my events aren't going through either, and am trying to fins someone in analytics to help [20:52:32] chrismcmalunch: let me know when you are back for lunch [20:52:39] keen to get to the bottom of the search test issue [20:52:57] jdlrobson: just returned [20:53:20] YuviPanda: ah. thanks for being point on this! [20:53:24] hey chrismcmahon ! so any idea why my error on https://gerrit.wikimedia.org/r/#/c/124742/ [20:53:30] did credentials on beta labs change? [20:53:56] mhurd: :D I made pageNS not required, but you should still send it every event. if it isn't there it is assumed to be main namespace [20:54:05] jdlrobson: whose credentials are you using? [20:54:15] https://gerrit.wikimedia.org/r/#/c/124742/ < also are you sure that test doesn't pass for you now? I'm wondering if search went down again [20:54:19] i can't replicate it manually [20:54:22] chrismcmahon: i'll pm you [20:54:50] YuviPanda: noted :) [20:55:15] mhurd: :) I'm eager to make sure we get this right, since mistakes mean we get invalid data that's not useful for making decisions :) [20:55:40] YuviPanda: for sure [20:57:17] jdlrobson: I wonder if CirrusSearch is the issue [21:01:05] Discussing image quality reduction RfC in #wikimedia-office in a few minutes (not here) - https://www.mediawiki.org/wiki/Requests_for_comment/Reducing_image_quality_for_mobile [21:01:27] jdlrobson: i'm on utc+2 (summertime) [21:01:28] chrismcmahon: we've in the meeting now if you want to join (about the opt in bug) [21:01:54] jdlrobson: here is a complete run of the search test from the branch https://gerrit.wikimedia.org/r/#/c/124742/ in pastebin http://pastebin.com/SQfeQr2q . I verified that the previous search test was green against beta labs. afaict, in your branch code you are searching within the text of article pages for a string that exists only as an article title [21:03:35] (03PS2) 10Dr0ptp4kt: Structure User-Agent similarly to Android app reboot. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 [21:18:00] (03CR) 10Cmcmahon: [C: 04-1] "I'm not sure what this has to do with the ui_links.feature test?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126744 (owner: 10Jdlrobson) [21:20:47] (03PS2) 10Jdlrobson: QA: Ensure wiki is setup with terms of use link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126744 [21:26:50] (03PS1) 10Yuvipanda: [WIP] Add EventLogging for Edit Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126849 [21:27:16] brion: ^ EventLogging / Funnel design. It doesn't work (investigating with analytics atm), and couple more events need to be hooked up. [21:27:21] brion: but do check out the design [21:27:33] spiff will take a peek [21:30:16] (03PS8) 10Jdlrobson: QA 1807: Provide tests for full text search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 [21:30:26] ^ chrismcmahon that should do the trick! :) [21:31:04] (03CR) 10Jdlrobson: "@chris - the issue is actually to do with terms of use. The issue with copyright link should be fixed in this rebase." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126744 (owner: 10Jdlrobson) [21:43:10] (03PS1) 10Jdlrobson: Temporarily suspend Nearby pages beta feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126850 [22:11:47] (03PS3) 10Dr0ptp4kt: Structure User-Agent similarly to Android app reboot. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 [22:11:49] (03CR) 10OliverKeyes: [C: 031] "Tested against the latest YAMLs, works fine!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 (owner: 10Dr0ptp4kt) [22:15:28] (03CR) 10JGonera: [C: 032] Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [22:15:59] (03Merged) 10jenkins-bot: Card 1816: Change the notifications icon in beta [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124027 (owner: 10Jdlrobson) [22:18:22] (03CR) 10OliverKeyes: [C: 031] Structure User-Agent similarly to Android app reboot. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 (owner: 10Dr0ptp4kt) [22:24:26] (03CR) 10JGonera: [C: 032] Temporarily suspend Nearby pages beta feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126850 (owner: 10Jdlrobson) [22:24:57] (03Merged) 10jenkins-bot: Temporarily suspend Nearby pages beta feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126850 (owner: 10Jdlrobson) [22:27:36] jdlrobson, jgonera: I tried writing a cucumber test for the editor stickiness, but it seems that cucumber resets the cookies between each scenario. You don't know any way to prevent it from reseting the cookies do you? [22:27:57] kaldari, you should not do it, scenarios must be independent [22:27:58] (03CR) 10Cmcmahon: [C: 032] QA: Ensure wiki is setup with terms of use link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126744 (owner: 10Jdlrobson) [22:27:59] kaldari: write the test so that it opens the editor twice [22:28:07] kaldari, you just have to do everything in one scenario [22:28:08] as that is the test right? [22:28:27] true I could do that [22:28:28] (03Merged) 10jenkins-bot: QA: Ensure wiki is setup with terms of use link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126744 (owner: 10Jdlrobson) [22:29:30] I was going to try to do it in separate scenarios since there's already a scenario for switching from one editor to the other, but I could just extend that one instead. [22:29:49] kaldari: jgonera if you get a chance to look at https://gerrit.wikimedia.org/r/126174 it would be great to get out that patch on the train - would mean we could push profiles, contributions and last modified bar as soon as next week :) (otherwise we'd have to wait another week) [22:30:06] (unless we're fine with pushing straight to stable via beta labs) [22:31:31] (03CR) 10JGonera: "Comment in patchset 1." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126038 (owner: 10Jdlrobson) [22:31:53] (03CR) 10JGonera: [C: 04-1] "Comment in patchset 1." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126038 (owner: 10Jdlrobson) [22:32:30] jgonera: i don't think you are following on that [22:32:46] so yes we could pass it down but i worry about side effects - as both .line, .lineHtml and .linePlain would be available [22:32:51] which is even worse [22:33:24] it gets passed to assignToParent which simply pushes it as is [22:33:47] without delete section.line it is even more confusing as now you have 3 properties [22:33:47] jdlrobson: I'm gonna look at it as soon as I finished checking this in [22:33:51] and using delete seems a bit nasty [22:34:28] (03CR) 10Jdlrobson: Ensure headings are HTML when needed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126038 (owner: 10Jdlrobson) [22:34:46] (03PS1) 10Catrope: Fix JS error in redlinks.js due to missing dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126858 [22:36:09] (03CR) 10Jdlrobson: [C: 032] Fix JS error in redlinks.js due to missing dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126858 (owner: 10Catrope) [22:36:40] (03Merged) 10jenkins-bot: Fix JS error in redlinks.js due to missing dependency [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126858 (owner: 10Catrope) [22:38:43] (03PS1) 10Kaldari: Story 1880: Make editor choice sticky [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126859 [22:43:19] hi! there's a new bug request concerning mobile access to beta.wikiversity.org: https://bugzilla.wikimedia.org/show_bug.cgi?id=63991 [22:44:36] as tfinc fortunately appeared, once again: hi! there's a new bug request concerning mobile access to beta.wikiversity.org: https://bugzilla.wikimedia.org/show_bug.cgi?id=63991 [22:44:59] DerHexer: thanks for the bug [22:45:26] or is there any easy way to reach the non-mobile version? https://beta.wikiversity.org/?action=history doesn't work (but still forwards) [22:45:47] (03CR) 10Kaldari: [C: 04-1] Story 1924: Tweaks to contributions page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126174 (owner: 10Jdlrobson) [22:46:43] (03PS5) 10Jdlrobson: Switch to JsDuck for documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120587 [22:46:45] thanks kaldari ! [22:48:29] kaldari: alpha beta or stable? [22:50:13] (03PS2) 10Jdlrobson: Story 1924: Tweaks to contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126174 [22:50:22] ^ kaldari does that work for you? [22:51:46] let's see... [22:52:11] jdlrobson: I was in alpha if it matters [22:52:21] i can't replicate it for some reason [22:52:33] not sure if the capital p is of important [22:52:43] retesting now... [22:53:36] kaldari: looking at your switcher story [22:54:06] (03PS1) 10Mhurd: Small heading style adjustment. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126863 [22:54:30] (03CR) 10Kaldari: [C: 04-1] "Still get the same notice." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126174 (owner: 10Jdlrobson) [22:57:43] jdlrobson: You may have to give up on using SpecialPage::getTitleFor since I think it wants it to be a real registered special page. You can probably just make the Title from one of the constructors in the Title class instead [22:58:35] oohhh wait there's a proper way to do this [22:58:39] kaldari: i'll take another look [22:58:53] kaldari: i have one issue with your sticky patch set - if you fix it up i promise i'll re-review by end of today :) [22:59:01] sure [22:59:04] (03CR) 10Jdlrobson: [C: 04-1] Story 1880: Make editor choice sticky (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126859 (owner: 10Kaldari) [22:59:28] ^ kaldari see that comment [22:59:33] just checking the browser tests in mean time [22:59:50] jdlrobson: oh yeah. good idea. [23:00:50] jdlrobson: I like using the strings though so it is more readable [23:01:00] even if it is a bit more fragile [23:01:20] kaldari: ok strings are fine - just wanted to suggest it :) [23:06:28] (03PS3) 10Jdlrobson: Story 1924: Tweaks to contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126174 [23:06:35] ^ kaldari that should do the job!! :D [23:06:42] (03PS2) 10Kaldari: Story 1880: Make editor choice sticky [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126859 [23:06:54] cool. back atcha ^ [23:08:22] so far, so good [23:09:36] jdlrobson: That's weird that it makes you pass the subpage as a separate param. I didn't know that either. [23:09:48] it makes more sense kaldari :) - nicer code :D [23:09:57] i don't know why i don't get the error though! [23:11:30] kaldari: 1 minor change... [23:11:49] so if a browser can run in VE it's guaranteed to have localStorage pretty much [23:11:49] (03PS9) 10Cmcmahon: QA 1807: Provide tests for full text search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 (owner: 10Jdlrobson) [23:11:57] so saving as a cookie as a full back seems unnecessary … thoughts? [23:12:10] Apart from that good to merge :) [23:12:53] jdlrobson: Thanks for writing function descriptions, BTW. It makes it faster to review your code (since I know what it's supposed to do) :) [23:13:03] :-) [23:13:28] kaldari: next stop generating phpdocumentation!! [23:13:42] so kaldari thoughts - do you want to amend or should i just pull trigger? [23:14:09] jdlrobson: so you're suggesting not having the cookie fall-back? [23:14:15] kaldari: correct [23:14:15] jdlrobson: css not quite right for search_within_pages, I updated it, it should pass now: https://gerrit.wikimedia.org/r/#/c/124742 [23:14:24] http://caniuse.com/namevalue-storage [23:14:34] chrismcmahon: css? [23:14:35] hmm, I like having it just to be paranoid :) [23:14:52] chrismcmahon: ooh i see what you mean :) [23:15:21] (03CR) 10Jdlrobson: [C: 032] Story 1880: Make editor choice sticky [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126859 (owner: 10Kaldari) [23:15:25] chrismcmahon: yeh that makes sense [23:15:25] thanks! [23:15:37] chrismcmahon: i guess there is a danger sometimes it will return results :) [23:15:39] jdlrobson: almost finished reviewing yours [23:15:52] (03Merged) 10jenkins-bot: Story 1880: Make editor choice sticky [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126859 (owner: 10Kaldari) [23:19:56] (03CR) 10Kaldari: [C: 04-1] "Need to mention in the browser test README about the requirement for the "Selenium diff test" page." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126174 (owner: 10Jdlrobson) [23:20:40] jdlrobson: ya, was failing for me on beta labs without that [23:26:22] (03CR) 10Jdlrobson: "Kaldari nope... "the page "Selenium diff test" exists" also creates the page so no need to mention it in README." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126174 (owner: 10Jdlrobson) [23:26:48] chrismcmahon: ok i'll have to look a bit carefully at what's going on there then [23:29:18] (03PS1) 10MaxSem: Use core token handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126873 [23:29:23] (03CR) 10jenkins-bot: [V: 04-1] Use core token handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126873 (owner: 10MaxSem) [23:33:39] (03PS2) 10MaxSem: Use core token handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126873 [23:33:57] jdlrobson, ^ [23:34:02] jdlrobson: hmm, I get an error when it tries to create the page… [23:34:04] And the page "Selenium diff test" exists # features/step_definitions/create_page_api_steps.rb:40 [23:34:04] NotExists (MediawikiApi::LoginError) [23:34:05] ./features/step_definitions/create_page_api_steps.rb:41:in `/^the page "(.*?)" exists$/' [23:34:44] lemme make sure I have all my proper export vars set... [23:34:51] kaldari: bundle install [23:34:56] also set the API variable [23:35:08] kaldari: in README [23:35:23] yeah, I did both of those... [23:35:34] export MEDIAWIKI_API_URL=http://en.wikipedia.beta.wmflabs.org/w/api.php [23:35:40] you did that but for your local machine? [23:35:51] export MEDIAWIKI_API_URL=http://localhost/w/api.php for me [23:38:34] jdlrobson: ah sorry, I had the wrong api URL [23:38:42] working now :) [23:39:07] (03CR) 10Kaldari: [C: 032] Story 1924: Tweaks to contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126174 (owner: 10Jdlrobson) [23:39:10] you win! [23:39:15] ;) [23:39:38] (03Merged) 10jenkins-bot: Story 1924: Tweaks to contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126174 (owner: 10Jdlrobson) [23:42:16] (03CR) 10JGonera: Story 1920: Show minor edit tags on watchlist and history pages (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126184 (owner: 10JGonera) [23:42:28] jdlrobson, responded to your comments ^ [23:46:11] (03PS3) 10Jdlrobson: Use core token handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126873 (owner: 10MaxSem) [23:48:31] kaity, moizsyed, vbamba: https://trello.com/jgonera/cards boom! [23:49:02] http://www.reactiongifs.com/wp-content/uploads/2011/09/mind_blown.gif [23:49:13] (03PS2) 10Mhurd: Small style adjustment. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126863 [23:49:42] jgonera: i feel all of this http://mindblowngifs.tumblr.com/ [23:50:07] (03CR) 10Jdlrobson: [C: 032] Use core token handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126873 (owner: 10MaxSem) [23:50:39] (03Merged) 10jenkins-bot: Use core token handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126873 (owner: 10MaxSem) [23:50:55] moizsyed, it's cool, everyone can stalk everyone: https://trello.com/moizsyed_/cards [23:51:08] some other moizsyed took moizsyed? [23:51:27] moizsyed is my account from hipmunk days [23:51:43] and its attached to my hipmunk gmail account [23:52:30] i have a lot of trello accounts [23:52:30] https://trello.com/moiz/cards [23:52:33] https://trello.com/moizsyed/cards [23:52:37] https://trello.com/moizsyed_/cards [23:54:06] lol moizsyed https://trello-avatars.s3.amazonaws.com/3d05cf41967925416dbd89e96334628b/170.png [23:54:24] it looks like the celebrities without teeth pictures! [23:54:29] HAHAHAAH [23:54:42] (03CR) 10Jdlrobson: [C: 032] "Cool thanks for checking." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126184 (owner: 10JGonera) [23:54:50] (03CR) 10jenkins-bot: [V: 04-1] Story 1920: Show minor edit tags on watchlist and history pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126184 (owner: 10JGonera) [23:55:15] http://www.buzzfeed.com/elliewoodward/photos-of-celebrities-without-teeth [23:56:25] (03CR) 10Mhurd: [C: 031] "One small comment. Looks good." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 (owner: 10Dr0ptp4kt) [23:56:48] (03CR) 10Jdlrobson: [C: 031] "I'm happy if you are Chris." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 (owner: 10Jdlrobson) [23:57:19] chrismcmahon: so is that patch ok with you? [23:57:31] jgonera: where did you go? can we chat about https://gerrit.wikimedia.org/r/#/c/126038/ [23:57:52] jdlrobson, I'm on the sofa near the door [23:57:56] k coming