[00:03:20] jdlrobson: checking... [00:08:21] (03PS4) 10Dr0ptp4kt: Structure User-Agent similarly to Android app reboot. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 [00:09:37] (03CR) 10Cmcmahon: [C: 032] "if this test fails we'll know why" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 (owner: 10Jdlrobson) [00:09:52] (03PS3) 10Jdlrobson: Ensure headings are HTML when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126038 [00:10:02] (03CR) 10Mhurd: [C: 031] "Looks good." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 (owner: 10Dr0ptp4kt) [00:10:09] (03Merged) 10jenkins-bot: QA 1807: Provide tests for full text search [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/124742 (owner: 10Jdlrobson) [00:12:03] (03PS1) 10Cmcmahon: QA: don't run tests on prod that use the API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126877 [00:21:03] (03PS1) 10JGonera: [WIP] QA: Experiments with taking and comparing screenshots [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126878 [00:21:51] (03CR) 10JGonera: [C: 04-2] "This is a proof of concept as of now. Check it out but do not merge." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126878 (owner: 10JGonera) [00:22:45] jdlrobson, whenever you have a moment, leave comments on https://gerrit.wikimedia.org/r/#/c/126878/ [00:23:02] (not super urgent, just letting you know) [00:23:10] jgonera: sweeeett!! i'll take a look first thing tomorrow. Just winding down for the day [00:24:50] sure [00:25:32] (03PS1) 10Jforrester: Fix "Nearby" Beta Feature icon to be consistent with the others [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126879 [00:25:50] (03PS1) 10MaxSem: Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126880 [00:26:32] (03CR) 10jenkins-bot: [V: 04-1] Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126880 (owner: 10MaxSem) [00:28:02] (03PS2) 10MaxSem: Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126880 [00:32:52] (03PS1) 10Catrope: Destroy the VE target after saving [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126881 [00:35:42] (03PS3) 10Reedy: Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126880 (owner: 10MaxSem) [00:49:53] mhurd: you there? [00:50:15] StevenW: ya! [00:50:42] I couldn't find a bug for this, but I thought I'd ask [00:52:10] (03CR) 10Jdlrobson: [C: 032] Destroy the VE target after saving [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126881 (owner: 10Catrope) [00:52:26] are protection settings built in to the iOS app? [00:52:39] StevenW: later this sprint iirc [00:52:43] ok [00:52:50] I won't bother filing a bug then [00:53:02] (03Merged) 10jenkins-bot: Destroy the VE target after saving [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126881 (owner: 10Catrope) [01:01:26] StevenW: thanks for checking! oh, i just checked the testflight settings and you and a few others hadn’t been properly added when we updated the dev account to “enterprise”. fixed so you should get testflight notices again [01:01:44] ah ok [01:01:49] I wondered what happened [01:02:12] StevenW: the way it manages lists is less than intuitive and i think we just missed a few :( [01:02:13] Actually when I try it I get the connect device workflow again... [01:02:33] Can I get another passcode? [01:02:40] Or can I use the same one from before? [01:03:33] i think it should be same? next build should be cut next wednesday - maybe sooner if i get a chance. [01:04:32] StevenW: your account was set up properly i believe. it was just not associated with the enterprise distro list correctly [01:50:58] (03CR) 10Legoktm: [C: 032] Fix "Nearby" Beta Feature icon to be consistent with the others [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126879 (owner: 10Jforrester) [01:51:55] (03Merged) 10jenkins-bot: Fix "Nearby" Beta Feature icon to be consistent with the others [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126879 (owner: 10Jforrester) [03:53:39] (03PS2) 10Besi: Fix typos [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125684 [03:54:55] (03CR) 10Besi: "Skipping the upsert() to update() change. Thanks for the new word I could add to my dictionary. :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125684 (owner: 10Besi) [03:55:52] (03PS3) 10Besi: Fix typos [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/125684 [05:06:25] (03CR) 10Jdlrobson: "We sould probably compress that svg... I'll submit a follow up." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126879 (owner: 10Jforrester) [07:19:53] (03PS1) 10Mhurd: Fix for bottom zero alert to play nice with TOC. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126925 [07:46:06] (03CR) 10Siebrand: [C: 04-1] "Great improvements for static code analysis. Some inconsistencies pointed out inline." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126803 (owner: 10Jdlrobson) [07:49:26] (03CR) 10Siebrand: "Needs rebase (JSON i18n)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/116156 (owner: 10JGonera) [09:53:07] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #1: ABORTED in 54 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/1/ [09:56:52] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #2: FAILURE in 1 min 4 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/2/ [10:00:20] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #3: STILL FAILING in 11 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/3/ [10:05:41] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #4: ABORTED in 2 min 12 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/4/ [10:10:08] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #5: STILL FAILING in 3 min 28 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/5/ [10:22:06] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #6: STILL FAILING in 2 min 51 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/6/ [10:31:21] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #7: ABORTED in 1 min 39 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/7/ [10:35:59] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #8: STILL FAILING in 4 min 26 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/8/ [15:40:50] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #9: STILL FAILING in 3 min 27 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/9/ [16:56:57] (03PS1) 10Jdlrobson: Compress nearby beta features svg [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127006 [16:57:09] (03CR) 10Jdlrobson: [C: 032] QA: don't run tests on prod that use the API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126877 (owner: 10Cmcmahon) [16:57:11] (03Merged) 10jenkins-bot: QA: don't run tests on prod that use the API [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126877 (owner: 10Cmcmahon) [17:04:27] (03CR) 10Jdlrobson: [C: 04-1] "I worry we are making our code a mess for the case of ProofRead page on wikisource. As discussed with Max it's important we fix this asap," [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126880 (owner: 10MaxSem) [17:25:18] (03PS1) 10Jdlrobson: Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127007 [17:25:54] (03CR) 10Jdlrobson: "Alternative here... https://gerrit.wikimedia.org/r/127007" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126880 (owner: 10MaxSem) [17:28:27] (03CR) 10Dr0ptp4kt: [C: 031] "Works for me." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126925 (owner: 10Mhurd) [17:32:16] (03PS1) 10Jdlrobson: Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127010 [17:32:51] (03CR) 10Jdlrobson: "Or https://gerrit.wikimedia.org/r/127010" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126880 (owner: 10MaxSem) [17:33:11] (03CR) 10Jdlrobson: "Choose either this one or https://gerrit.wikimedia.org/r/127007"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127010 (owner: 10Jdlrobson) [17:33:17] ^ MaxSem [17:33:43] both produce sucksier results ;} [17:35:10] kaldari cowboy hat rocks [17:37:10] vbamba: thanks :) [17:41:53] kaldari: nudges for that email about the setup where you generated glyphs [17:41:54] =] [17:42:15] Oh yeah... [17:42:23] oh good. youre not mad [17:42:27] =] [17:43:59] (03PS1) 10Yurik: made utils compatible with python2 [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/127014 [17:44:25] (03CR) 10Yurik: [C: 032] made utils compatible with python2 [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/127014 (owner: 10Yurik) [17:44:27] (03Merged) 10jenkins-bot: made utils compatible with python2 [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/127014 (owner: 10Yurik) [17:59:32] * zz_yuvipanda pings self [17:59:37] am I here? [18:00:24] looks like [18:02:53] yurik: you around? [18:07:54] (03CR) 10Jforrester: [C: 032] Compress nearby beta features svg [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127006 (owner: 10Jdlrobson) [18:08:27] (03Merged) 10jenkins-bot: Compress nearby beta features svg [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127006 (owner: 10Jdlrobson) [18:09:37] YuviPanda: are you here? [18:09:43] vbamba: indeed! [18:09:50] vbamba: 'sup [18:12:20] Wanted to ask you if you know anything about https://bugzilla.wikimedia.org/show_bug.cgi?id=63508 [18:12:27] did you guys have a chance to bring chicken back up? [18:15:41] * YuviPanda waits for vbamba to come back to reply [18:15:49] zz_prtksxna: plz2setup vibha with bouncer [18:16:46] vbamba: hey! Haven't had a change to get to that at all, sadly. [18:16:57] zz_prtksxna: asking in labs-l should help [18:17:33] whats is lab-i? [18:17:41] labs-I [18:17:51] No worries, just want to follow up [18:18:02] vbamba: it's a mailing list for users of Wikimedia Labs, where Chicken is hosted. https://lists.wikimedia.org/mailman/listinfo/labs-l [18:34:16] YuviPanda: how are we looking for Dmitry starting on Monday ? [18:34:34] err .. Tuesday [18:34:37] 4/22 [18:35:06] YuviPanda: if you have notes on what your planning lets put them up on an etherpard [18:35:34] tfinc: I don't have them in a written form but let me do that. Just fixing a crash. [18:35:54] YuviPanda: yeah, just a simple ether pad is fine to sync between you, brion, monte, etc [18:36:07] tfinc: yeah, I'll do that and email. [18:37:15] mhurd: hey! how's EL stuff going? [18:37:17] (03PS2) 10Yuvipanda: [WIP] Add EventLogging for Edit Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126849 [18:37:19] (03PS1) 10Yuvipanda: Fix crashes when only one section is in a page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127028 [18:37:21] I sorted out my issues [18:37:50] (03PS3) 10Yuvipanda: [WIP] Add EventLogging for Edit Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126849 [18:37:52] (03PS2) 10Yuvipanda: Fix crashes when only one section is in a page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127028 [18:42:17] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #10: STILL FAILING in 3 min 24 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/10/ [18:43:25] awjr, can b(ugello [18:43:36] ) [18:43:42] hi MaxSem. how's SF? [18:43:45] o_0 [18:44:01] |ingle) add PageImahes and TextExtracts bugs to mobile story wall? [18:44:06] hey YuviPanda [18:44:16] JETLAGGED SO FAR [18:44:21] :P [18:44:22] MaxSem: yeah we can do that [18:45:05] cause Hovercards started unearthing a lot of bugs in them recently [18:45:07] MaxSem: let me think a bit about how best to manage that - the first time it runs it will import all open bugs, which may be a lot [18:45:16] im in a mtg right now but i can think about it more clearly this afternoon [18:45:17] MaxSem: yeah, lots of HOverCards bugs are TE/PI bugs [19:06:22] (03Abandoned) 10Jdlrobson: Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127007 (owner: 10Jdlrobson) [19:07:50] (03Abandoned) 10MaxSem: Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126880 (owner: 10MaxSem) [19:08:15] (03CR) 10MaxSem: [C: 032] Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127010 (owner: 10Jdlrobson) [19:08:48] (03Merged) 10jenkins-bot: Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127010 (owner: 10Jdlrobson) [19:23:34] * YuviPanda pokes mhurd [19:23:55] (03PS3) 10Jdlrobson: Hygiene: Cleanup PHPDocs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126803 [19:24:07] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Cleanup PHPDocs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126803 (owner: 10Jdlrobson) [19:24:09] (03CR) 10Jdlrobson: Hygiene: Cleanup PHPDocs (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126803 (owner: 10Jdlrobson) [19:24:40] (03CR) 10Jdlrobson: [C: 04-1] "Rebase needed. Please do so and feel free to +2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126184 (owner: 10JGonera) [19:28:47] oh woah, I have a stray newline in my UA?! [19:36:00] (03PS4) 10Yuvipanda: [WIP] Add EventLogging for Edit Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126849 [19:37:20] woo, EL coming together [19:41:29] (03CR) 10CSteipp: "Sorry to be unclear in our discussion, but I wasn't saying you shouldn't do a check for anonymous users, but that you should call $user->g" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126873 (owner: 10MaxSem) [20:07:35] (03PS5) 10Yuvipanda: [WIP] Add EventLogging for Edit Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126849 [20:24:13] vbamba! [20:24:26] sorry, I got pulled into something [20:24:30] chat now? [20:27:24] (03PS1) 10MaxSem: Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127141 [20:27:37] (03CR) 10MaxSem: [C: 032] Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127141 (owner: 10MaxSem) [20:28:11] (03PS1) 10MaxSem: Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127142 [20:28:19] (03Merged) 10jenkins-bot: Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] (wmf/1.23wmf22) - 10https://gerrit.wikimedia.org/r/127141 (owner: 10MaxSem) [20:28:25] (03CR) 10MaxSem: [C: 032] Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127142 (owner: 10MaxSem) [20:29:11] (03Merged) 10jenkins-bot: Fix "Call to undefined method ProofreadPageDifferenceEngine::getWarningMessageText()" [extensions/MobileFrontend] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127142 (owner: 10MaxSem) [20:47:19] (03PS2) 10JGonera: Story 1920: Show minor edit tags on watchlist and history pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126184 [20:47:49] (03CR) 10JGonera: [C: 032] "Rebased, +2 as per Jon's comment." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126184 (owner: 10JGonera) [20:48:52] (03Merged) 10jenkins-bot: Story 1920: Show minor edit tags on watchlist and history pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126184 (owner: 10JGonera) [20:49:52] (03CR) 10Jdlrobson: "Seems to work and I think this approach could work nicely." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126878 (owner: 10JGonera) [20:52:47] yo [20:56:30] brion: yo! [20:56:49] brion: how is the last part of https://trello.com/c/IbObyKyh/24-5-rtl-hygiene going? [20:58:41] lemme make sure that’s done... [21:00:53] (03PS1) 10MaxSem: Give anons tokens too [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127153 [21:09:01] (03PS1) 10Brion VIBBER: Flip edit icon in RTL [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127155 [21:13:24] (03CR) 10Brion VIBBER: [C: 032] Fix crashes when only one section is in a page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127028 (owner: 10Yuvipanda) [21:22:18] (03CR) 10JGonera: "1) Would be hard because every developer would have to generate screenshots on different browsers after they change something in the desig" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126878 (owner: 10JGonera) [21:27:02] (03CR) 10Brion VIBBER: [C: 032 V: 032] Small style adjustment. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126863 (owner: 10Mhurd) [21:27:52] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for bottom zero alert to play nice with TOC. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126925 (owner: 10Mhurd) [21:28:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] Structure User-Agent similarly to Android app reboot. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/126188 (owner: 10Dr0ptp4kt) [21:29:03] brion thx [21:29:07] \o [21:29:10] / [21:29:14] lost an arm there [21:31:22] (03CR) 10Brion VIBBER: "Looking good so far, give a ping when it's out of work-in-progress :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126849 (owner: 10Yuvipanda) [21:35:38] kaity, moizsyed we need some mocks for https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1904 [21:36:04] I wouldn't spend a whole lot of time on it now though since it's beta and we're not sure if it will solve the problem [21:36:44] hmm [21:36:47] i can help [21:37:04] we can talk, so i can know a little more about the card [21:37:11] sure, whenever you have time [21:38:42] maybe later today [21:39:55] (03PS1) 10Theopolisme: LanguageOverlay: Only display title if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 [21:40:54] (03PS1) 10Mhurd: Further style tweaks. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127163 [21:41:08] brion: ^ :) [21:41:50] (03CR) 10Brion VIBBER: [C: 032 V: 032] Further style tweaks. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127163 (owner: 10Mhurd) [21:42:02] brion: turbo! [21:42:19] whooo [21:43:28] :) [22:31:07] (03PS4) 10Jdlrobson: Hygiene: Cleanup PHPDocs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126803 [22:50:56] (03CR) 10CSteipp: [C: 031] "Thanks!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127153 (owner: 10MaxSem) [23:01:29] violetto: hey time for quick question? [23:10:13] (03PS1) 10JGonera: [WIP] Story 1904: Filters to reduce copyvios on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127179 [23:10:51] (03CR) 10JGonera: [C: 04-2] "WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127179 (owner: 10JGonera) [23:17:03] brion, ha, just got back to irc and saw your message. i think that was the aligator chomp [23:17:15] or crocodile [23:17:43] (03PS3) 10JGonera: Base api module on mw.Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121532 [23:18:11] jdlrobson, no longer WIP: https://gerrit.wikimedia.org/r/#/c/121532/ [23:18:15] (03CR) 10jenkins-bot: [V: 04-1] Base api module on mw.Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121532 (owner: 10JGonera) [23:19:21] jdlrobson, nope, lied, still WIP [23:19:30] for some reason pre-commit didn't run qunit [23:21:26] violetto: i think i figured out how to, in code, lift the glyph off the baseline :) probably hold off on any changes? [23:36:57] mhurd: i will :} [23:43:19] mhurd: looks like brion has some code review for you :) https://trello.com/c/IbObyKyh/24-5-rtl-hygiene [23:44:56] (03CR) 10Mhurd: [C: 031] "Looks good!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127155 (owner: 10Brion VIBBER) [23:51:51] (03PS1) 10Jdlrobson: Fix more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127184 [23:51:53] (03PS1) 10Jdlrobson: QA: Add browser tests for presence of more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127185 [23:56:29] (03PS2) 10Jdlrobson: LanguageOverlay: Only display title if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 (owner: 10Theopolisme) [23:56:35] (03CR) 10Jdlrobson: [C: 032] LanguageOverlay: Only display title if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 (owner: 10Theopolisme) [23:57:02] (03CR) 10jenkins-bot: [V: 04-1] LanguageOverlay: Only display title if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 (owner: 10Theopolisme) [23:58:29] (03CR) 10Jdlrobson: [C: 04-1] "Please update qunit tests to reflect new status quo :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 (owner: 10Theopolisme) [23:59:28] (03CR) 10Jdlrobson: [C: 04-1] "Please fix the qunit tests / and any issues they may be highlighting." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121532 (owner: 10JGonera) [23:59:53] jdlrobson, I wrote here that it's still WIP