[00:00:16] and I mean, you don't have to be jenkins's proxy, it can't be merged if jenkins -1s it [00:01:40] (03PS2) 10Jdlrobson: Give anons tokens too [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127153 (owner: 10MaxSem) [00:01:44] (03CR) 10Jdlrobson: [C: 032] Give anons tokens too [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127153 (owner: 10MaxSem) [00:02:00] jgonera: sure i'm just marking it as -1 so it's out of my review queue :) [00:02:11] i can't submit patches with it in 0 status :) [00:02:21] (03Merged) 10jenkins-bot: Give anons tokens too [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127153 (owner: 10MaxSem) [00:02:22] oh, ok, maybe pre-review should check for jenkins votes too [00:02:51] (03PS3) 10Theopolisme: LanguageOverlay: Only display title if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 [00:02:52] yeh gerrit is kind of weird it treats verified differently [00:03:25] to be fair i think the review hook is doing the right thing - sometimes i like it when there is a patch that jenkins as Xed [00:03:41] as sometimes it just needs a simple rebase. In cases where the patch is fine and the rebase is simple I review it and fix it up and merge [00:04:10] sometimes jenkins is just plain broken as well :) [00:06:34] (03CR) 10Jdlrobson: [C: 032] LanguageOverlay: Only display title if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 (owner: 10Theopolisme) [00:07:01] (03CR) 10jenkins-bot: [V: 04-1] LanguageOverlay: Only display title if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 (owner: 10Theopolisme) [00:07:14] geez [00:08:58] i missed a test [00:09:01] ...oops [00:09:12] wait, maybe.. [00:09:39] no i just added it to the wrong place [00:09:42] -.- [00:12:02] jdlrobson, is there a hook or something to run the qunits before committing? [00:12:22] (03PS1) 10Mhurd: Article history interface. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 [00:12:30] brion: ^ here’s a fun one [00:24:18] jgonera: did you mention to ops that History and Watchlist and friends were being pushed to stable in next 2 weeks at scrum of scrums? [00:29:47] anyone seen kenan today? [00:35:13] jgonera: i think there has been a regression on watch list.. http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Watchlist&watchlistview=a-z&mobileaction=stable [00:35:44] info class [00:40:33] (03PS1) 10Jdlrobson: Fix css regression (watchlist margins) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127191 [00:41:30] jdlrobson, watchlist is in stable, I forgot about history and contributions [00:41:40] I guess it's OK if I mention it next time [00:42:24] jdlrobson, what is the regression? [00:42:33] https://bugzilla.wikimedia.org/show_bug.cgi?id=64081 < jgonera [01:26:37] (03PS1) 10Jdlrobson: Story 1891: Push new Watchlist feed to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127193 [01:26:40] (03PS1) 10Jdlrobson: Push search bar on special pages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127194 [01:26:42] (03PS1) 10Jdlrobson: Story 1891: Push history to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127195 [01:26:44] (03PS1) 10Jdlrobson: Story 1925: Push user contributions to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127196 [01:43:55] (03PS4) 10JGonera: Base api module on mw.Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121532 [02:02:07] (03PS1) 10Kaldari: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 [02:02:52] (03PS2) 10Kaldari: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 [03:42:15] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #11: STILL FAILING in 3 min 21 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/11/ [03:42:16] * neverett: Don't add a filter if not needed [03:42:16] * neverett: Quoted searches with accents only find accented [08:53:10] Yippee, build fixed! [08:53:10] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #12: FIXED in 31 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/12/ [09:01:26] Project UploadWizard-api-commons.wikimedia.beta.wmflabs.org build #1: FAILURE in 33 sec: https://integration.wikimedia.org/ci/job/UploadWizard-api-commons.wikimedia.beta.wmflabs.org/1/ [09:04:45] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #13: FAILURE in 3 min 8 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/13/ [09:06:16] Yippee, build fixed! [09:06:16] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #14: FIXED in 33 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/14/ [09:11:33] Project CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #15: SUCCESS in 2 min 17 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/15/ [09:28:34] Project CirrusSearch-test2.wikipedia.org-linux-firefox build #1: SUCCESS in 43 sec: https://integration.wikimedia.org/ci/job/CirrusSearch-test2.wikipedia.org-linux-firefox/1/ [09:48:51] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #1: FAILURE in 5.7 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/1/ [09:48:54] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #1: FAILURE in 5.8 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/1/ [09:52:16] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (033 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [10:41:52] (03CR) 10Siebrand: [C: 032] Hygiene: Cleanup PHPDocs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126803 (owner: 10Jdlrobson) [10:42:36] (03Merged) 10jenkins-bot: Hygiene: Cleanup PHPDocs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126803 (owner: 10Jdlrobson) [10:44:51] Project browsertests-Translate-meta.wikimedia.org-linux-firefox build #1: SUCCESS in 1 min 8 sec: https://integration.wikimedia.org/ci/job/browsertests-Translate-meta.wikimedia.org-linux-firefox/1/ [10:49:02] Project browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #1: SUCCESS in 1 min 6 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/1/ [10:51:24] Project browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox build #1: FAILURE in 19 sec: https://integration.wikimedia.org/ci/job/browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox/1/ [10:58:24] Project browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox build #2: STILL FAILING in 1 min 13 sec: https://integration.wikimedia.org/ci/job/browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox/2/ [10:58:25] zeljko.filipin: All Selenium tests should run in Firefox [11:10:44] Project browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox build #3: STILL FAILING in 5 min 41 sec: https://integration.wikimedia.org/ci/job/browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox/3/ [11:18:43] Project browsertests-Translate-sandbox.translatewiki.net-linux-firefox build #1: FAILURE in 1 min 13 sec: https://integration.wikimedia.org/ci/job/browsertests-Translate-sandbox.translatewiki.net-linux-firefox/1/ [11:30:12] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #1: FAILURE in 2 min 2 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/1/ [11:35:08] Project browsertests-Translate-sandbox.translatewiki.net-linux-firefox build #2: STILL FAILING in 14 min: https://integration.wikimedia.org/ci/job/browsertests-Translate-sandbox.translatewiki.net-linux-firefox/2/ [11:44:14] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #2: STILL FAILING in 13 min: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/2/ [13:35:48] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #2: STILL FAILING in 52 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/2/ [13:35:49] zeljko.filipin: Smoke feature needs @firefox tag to run on Wikimedia Jenkins [13:35:52] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #2: STILL FAILING in 48 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/2/ [13:35:53] zeljko.filipin: Smoke feature needs @firefox tag to run on Wikimedia Jenkins [13:41:15] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #3: STILL FAILING in 39 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/3/ [13:42:15] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #3: STILL FAILING in 1 min 37 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/3/ [13:44:39] Yippee, build fixed! [13:44:40] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #4: FIXED in 38 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/4/ [13:46:53] Yippee, build fixed! [13:46:54] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #4: FIXED in 32 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/4/ [15:22:15] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #1: FAILURE in 39 sec: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/1/ [15:41:16] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #2: ABORTED in 3 min 1 sec: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/2/ [15:41:16] zeljko.filipin: [browser test] Run all Selenium tests in Firefox [15:49:21] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #3: ABORTED in 8 min 6 sec: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/3/ [15:51:41] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #4: ABORTED in 2 min 14 sec: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/4/ [16:20:46] (03CR) 10Jdlrobson: [C: 04-1] "QUnit tests are still failing. Did you work out the problem with getting qunit to run Theo?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 (owner: 10Theopolisme) [16:22:10] (03PS3) 10Jdlrobson: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [16:22:12] (03PS1) 10Jdlrobson: Story 1921: Push user profile to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127268 [16:22:30] (03CR) 10jenkins-bot: [V: 04-1] Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [16:26:54] (03CR) 10Jdlrobson: "I rebased off profiles and contributions to ensure we don't merge this before those two features are pushed to stable (which would result " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [16:38:13] MaxSem: hey i'm gonna be in a little later today [16:38:37] MaxSem: if jgonera or tfinc is not in you'll have to setup the standup :-S [16:38:57] jdlrobson, I still have no acccount;) [16:39:08] MaxSem: no wikimedia account? [16:39:16] jdlrobson, it's all covered [16:39:20] ok sweet [16:39:20] chromebox account [16:39:24] you're not in the office today? [16:40:39] jgonera: jdlrobson: MaxSem: hey i'm gonna be in a little later today (you just missed it) [16:40:57] ok [16:44:11] (03CR) 10Jdlrobson: Story 1920: Show minor edit tags on watchlist and history pages (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126184 (owner: 10JGonera) [16:46:21] (03PS1) 10Jdlrobson: Make browser tests for watchlist and history pass again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127273 [16:47:27] MaxSem: how are you liking being in the office so far? [16:48:30] liking [16:48:53] :D [16:49:53] (03PS2) 10Jdlrobson: Fix css regression (watchlist margins) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127191 [16:49:55] (03PS2) 10Jdlrobson: Story 1891: Push new Watchlist feed to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127193 [16:51:50] (03PS2) 10Jdlrobson: Push search bar on special pages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127194 [16:51:59] (03PS2) 10Jdlrobson: Story 1891: Push history to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127195 [16:52:04] (03PS2) 10Jdlrobson: Story 1925: Push user contributions to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127196 [16:52:22] (03PS2) 10Jdlrobson: Story 1921: Push user profile to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127268 [16:54:03] (03CR) 10Jdlrobson: [C: 04-1] "Please also update the browser test features/special_history.feature , ui_links.feature and features/diff.feature" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [17:02:03] (03PS2) 10Mhurd: Article history interface. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 [17:02:22] Yippee, build fixed! [17:02:23] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #6: FIXED in 20 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/6/ [17:05:30] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [17:07:50] kenanwang: there were questions for you on the hangout [17:08:09] yeah my internet's a ilttle weird [17:16:34] mhurd: you about ? [17:16:40] mhurd: just waiting on you [17:16:47] tfinc, he's coming [17:23:04] jdlrobson, is infinite scroll fine on your local instance using latest master? [17:23:11] (03PS3) 10Jdlrobson: Push search bar on special pages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127194 [17:23:20] jgonera: gimme 1 s and i'll check [17:25:23] mhurd: can you snag a breakfast burrito for me before their all gone? [17:25:33] one more meeting before i commute in [17:31:18] tfinc: done :) [17:31:46] mhurd: thank you. i knew you would be up there before most for breakfast ::) [17:33:44] oh woooo [17:33:49] i got google i/o invite [17:34:11] tfinc: yw! [17:34:17] brion: nice!!! [17:37:03] brion: nice! [17:37:40] ah the fine print [17:37:42] “Photographs and/or video taken at Google I/O by Google, or others on behalf of Google, may include your image or likeness. You agree that Google may use such photographs and/or video for any purpose without compensation to you. “ [17:37:49] brion: when did you hear back ? [17:38:14] tfinc: it fell into my email yesterday but it was buried in other things so i didn’t see it until today [17:38:29] wonder if the'll approve mine or if i'll take Eriks [17:39:06] “Google I/O badges may contain NFC, BLE, or other RFID technologies to help us serve attendees and determine participation in various sessions and activities. “ [17:39:10] they’re tracking usssss [17:40:11] interesting. wonder how their using the data [17:53:14] hey brion / mhurd [17:53:17] sorry wasn't around for standup [17:53:24] YuviPanda: heya! [17:53:28] YuviPanda: no worry [17:53:32] :) [17:53:47] mhurd: I got the Android EL stuff working. Needed a little bit more plumbing than expected [17:53:51] and a lot more debugging :) [17:54:18] YuviPanda: awesome! [17:54:26] mhurd: how's it going iOS side? [17:55:02] YuviPanda: i have more to do on EL yet [17:55:22] YuviPanda: been working on other cards in mean time. did the schema change any more? [17:55:31] whee [17:56:50] mhurd: minor fixes (typos, minor simplifications) [17:57:08] heading into office now@ [17:58:58] YuviPanda: gotcha. i added an acceptance criteria to the existing ios EL card that i need to double check all event keys [17:59:16] mhurd: yeah. and right now IIRC your events weren't even being registered serversdie [17:59:45] YuviPanda: right because some required token keys aren’t being logged yet [18:00:02] YuviPanda: will add soon :) [18:00:14] mhurd: ok :) [18:04:10] brion: have a few minutes to check https://gerrit.wikimedia.org/r/#/c/127188/ ? [18:04:25] mhurd: in a bit, got a quick meeting first [18:04:36] brion: gotcha [18:07:55] Project browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox build #2: SUCCESS in 1 min 2 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-sandbox.translatewiki.net-linux-firefox/2/ [18:09:15] (03CR) 10MaxSem: [C: 04-1] Fix more link on history page (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127184 (owner: 10Jdlrobson) [18:10:15] (03CR) 10MaxSem: [C: 032] Make browser tests for watchlist and history pass again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127273 (owner: 10Jdlrobson) [18:11:14] (03Merged) 10jenkins-bot: Make browser tests for watchlist and history pass again [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127273 (owner: 10Jdlrobson) [18:20:37] Project browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox build #4: STILL FAILING in 5 min 44 sec: https://integration.wikimedia.org/ci/job/browsertests-TwnMainPage-sandbox.translatewiki.net-linux-firefox/4/ [18:27:16] Project browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox build #3: STILL FAILING in 8 min 23 sec: https://integration.wikimedia.org/ci/job/browsertests-UniversalLanguageSelector-commons.wikimedia.beta.wmflabs.org-linux-firefox/3/ [18:34:19] jgonera: Seen Jon around? [18:34:43] kaldari, he was on irc before, he said he would be in the office later but I haven't seen him yet [18:36:48] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox build #7: FAILURE in 23 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox/7/ [18:37:31] Project browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox build #5: SUCCESS in 38 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-test2.wikipedia.org-linux-firefox/5/ [18:42:17] (03PS3) 10Kaldari: Fix css regression (watchlist margins) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127191 (owner: 10Jdlrobson) [18:42:19] (03PS4) 10Kaldari: Push search bar on special pages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127194 (owner: 10Jdlrobson) [18:42:21] (03PS3) 10Kaldari: Story 1891: Push history to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127195 (owner: 10Jdlrobson) [18:42:23] (03PS3) 10Kaldari: Story 1921: Push user profile to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127268 (owner: 10Jdlrobson) [18:42:25] (03PS3) 10Kaldari: Story 1891: Push new Watchlist feed to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127193 (owner: 10Jdlrobson) [18:42:27] (03PS3) 10Kaldari: Story 1925: Push user contributions to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127196 (owner: 10Jdlrobson) [18:42:29] (03PS4) 10Kaldari: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 [18:50:10] Project browsertests-Translate-meta.wikimedia.org-linux-firefox build #2: SUCCESS in 1 min 16 sec: https://integration.wikimedia.org/ci/job/browsertests-Translate-meta.wikimedia.org-linux-firefox/2/ [18:51:20] jdlrobson, did you check the infinite scroll? [18:51:33] hey kaldari you were looking for me? [18:52:18] yeah, I was just running into lots of nasty merge conflcits with that change of mine that you rebased, but I think I have them all resolved now. Just fixing the browser tests now. [18:53:12] Project browsertests-Translate-sandbox.translatewiki.net-linux-firefox build #3: STILL FAILING in 21 min: https://integration.wikimedia.org/ci/job/browsertests-Translate-sandbox.translatewiki.net-linux-firefox/3/ [18:53:20] jdlrobson: BTW, photographed this cool lizard this morning before the stand-up: http://www.inaturalist.org/observations/630302 [18:53:44] kaldari: \o/ [18:53:52] dinosaur lizard!! [18:54:29] I saw a huge iguana yesterday right in front of my front door, but it ran away before I could photograph it. [18:56:14] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox build #5: FAILURE in 3 min 21 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox/5/ [18:56:52] (03PS2) 10Jdlrobson: Fix more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127184 [19:03:40] jdlrobson: What does the 'component' class mean? [19:03:53] kaldari: i would love an iguana [19:03:58] please can you bring me one back? [19:04:07] we really need an office pet [19:04:08] vbamba: they are hard to catch, but I'll try [19:04:18] i have full faith in you. [19:12:02] YuviPanda: thanks for the on boarding list. i'll review today [19:12:12] tfinc: ok! :) [19:12:21] tfinc: it's purely technical. [19:12:52] i'll balance it [19:12:57] and then we can re-use it for Bernd [19:13:18] tfinc: cool! [19:14:23] awjr: i filed a bunch of bugs last night but i dont see them on our trello board. ideas ? [19:14:25] jdlrobson, MaxSem what time do you want to get lunch? [19:14:34] Maryana, you had lunch? [19:14:38] tfinc: i can take a look shortly [19:14:41] thanks [19:14:51] jgonera: i have a lunch meeting in 15 min - sorry! [19:15:17] tfinc, mhurd you had lunch? [19:15:25] tfinc: awjr bugello looks broken, fwiw [19:15:36] jgonera: just had breakfast [19:15:36] there's usually a sensible reason for it [19:15:51] it's a little more fragile than bingle [19:16:06] so i'm going to wait a bit [19:16:15] jgonera: breakfast burrito! :) [19:17:27] jgonera, maybe at 1 [19:17:40] not really hungry yet:) [19:17:56] cool, I'll probably wait too to avoid lines [19:20:40] (03PS1) 10Jdlrobson: Fix infinite scroll on uploads page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127291 [19:20:55] jgonera: so yeh that's the issue ^ [19:21:04] jgonera: i'm meeting a friend for lunch sorry! [19:21:09] thanks jdlrobson! [19:21:19] jgonera: looks like there was a breaking change in API a week ago [19:21:48] which explains why it's working on English wikipedia [19:22:51] heh, cool we caught it just in time ;) [19:29:10] brion: which story did you pickup in https://trello.com/b/8ADlEuVo/mobile-app-sprint-29-android-to ? [19:29:34] mhurd: did we hear back from designers about https://trello.com/c/bHjJwYI7/1-2-license-text-on-every-edit ? [19:30:24] tfinc: brion: oh i did talk to vibha about it. she’s going to get us a mock [19:31:06] k [19:33:18] YuviPanda: i'm ruining all your neatly aligned numbers on https://etherpad.wikimedia.org/p/dmitry-onboarding [19:33:20] :D [19:33:32] tfinc: and then you will kill all the apostrophes [19:33:40] nom nom nom [19:36:19] YuviPanda: my big question about it is what you, brion, and i will be responsible for during the onboarding [19:37:47] (03PS5) 10Kaldari: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 [19:38:28] YuviPanda: also feel free to re-organize the list [19:38:38] (03CR) 10jenkins-bot: [V: 04-1] Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [19:40:22] (03PS1) 10Mhurd: Variety of small UX/Design tweaks. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127341 [19:42:31] (03PS4) 10Kaldari: Fix css regression (watchlist margins) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127191 (owner: 10Jdlrobson) [19:42:33] (03PS5) 10Kaldari: Push search bar on special pages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127194 (owner: 10Jdlrobson) [19:42:35] (03PS4) 10Kaldari: Story 1891: Push history to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127195 (owner: 10Jdlrobson) [19:42:37] (03PS4) 10Kaldari: Story 1921: Push user profile to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127268 (owner: 10Jdlrobson) [19:42:39] (03PS4) 10Kaldari: Story 1891: Push new Watchlist feed to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127193 (owner: 10Jdlrobson) [19:42:41] (03PS4) 10Kaldari: Story 1925: Push user contributions to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127196 (owner: 10Jdlrobson) [19:42:43] (03PS6) 10Kaldari: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 [19:43:53] (03PS7) 10Kaldari: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 [19:44:46] (03PS6) 10Yuvipanda: Add EventLogging for Edit Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126849 [19:47:04] jdlrobson: finally got all the merge conflicts resolved and browser tests passing again. I have to run to this Easter BBQ thing, but if I don't get a chance to review your changes this evening, I'll take a look at them on Sunday. [19:48:21] (03PS1) 10MaxSem: Improve diff detection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127344 [19:50:44] (03CR) 10jenkins-bot: [V: 04-1] Improve diff detection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127344 (owner: 10MaxSem) [19:56:21] kenanwang, so will you be in the office or not? [19:56:40] yeah sorry got caught up with a meeting [19:56:47] and got another one in 5 [19:56:53] kenanwang, ok, sure, will talk to you after lunch then [19:56:53] i'm coming in after that [19:56:57] ok [19:58:28] tfinc: bugello is choking on the unicode char for beta [19:58:37] (in the board title) [19:58:52] tfinc: quick fix - change the title [19:59:01] after i get through meetings i can fix the code [19:59:39] awjr: ha, ok [19:59:55] done [20:09:47] brion: thougths on trying out hiding the status bar? seems a fairly common pattern in reader-type apps… (the patch i submitted a bit ago hides it: https://gerrit.wikimedia.org/r/#/c/127341/) [20:13:49] ok tfinc looks like bugello is adding bugs again [20:14:28] awjr: yup, you just doubled our bug column [20:14:34] awjr: can you mail about the outage ? [20:14:37] yay! i think [20:14:41] sure thing [20:16:11] YuviPanda: --^ [20:17:18] tfinc: looks good. is kenan going to do a prioritization run? [20:17:29] YuviPanda: yeah, i'm going to mail about it [20:17:34] tfinc: cool [20:18:39] YuviPanda: lots of good ones for Dmitry to pickup on Tuesday [20:19:52] tfinc: :) [20:41:55] (03PS1) 10Catrope: Also destroy target when exiting without saving changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127364 [20:52:51] brion: hey! the EditFunnel patch looks done to me, take a look? [20:53:14] brion: except for... captcha events fire but the captcha itself does not. That seems broken, so I've to fix that. separate commit [20:53:18] let me note that in the commit message [20:53:50] brion: either way, do review! [20:53:51] (03PS7) 10Yuvipanda: Add EventLogging for Edit Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126849 [20:55:31] am off now. night [21:18:58] (03PS2) 10Jdlrobson: Improve diff detection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127344 (owner: 10MaxSem) [21:19:42] (03CR) 10jenkins-bot: [V: 04-1] Improve diff detection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127344 (owner: 10MaxSem) [21:20:46] (03CR) 10Jdlrobson: [C: 032] Also destroy target when exiting without saving changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127364 (owner: 10Catrope) [21:21:17] (03Merged) 10jenkins-bot: Also destroy target when exiting without saving changes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127364 (owner: 10Catrope) [21:27:36] (03CR) 10Jdlrobson: [C: 032] Base api module on mw.Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121532 (owner: 10JGonera) [21:28:12] (03Merged) 10jenkins-bot: Base api module on mw.Api [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121532 (owner: 10JGonera) [21:34:06] (03CR) 10Jdlrobson: [C: 031] "The styling appears to be different when you compare beta to stable (due to the typography changes that has currently not been pushed to s" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [22:00:10] tfinc: click talk on http://en.m.wikipedia.beta.wmflabs.org/wiki/Flow_QA?mobileaction=beta [22:00:49] jdlrobson: intriguing. talk to me about the integration here [22:01:12] They use a hook to override our talk javascript module [22:01:17] then it's just Flow [22:01:22] so flow is controlling layout here ? [22:01:32] yeh they are just adding some extra css [22:02:10] only running non-JS version at moment though [22:18:15] (03PS1) 10Mhurd: First pass at credits page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127378 [22:19:02] (03PS2) 10JGonera: [WIP] Story 1904: Filters to reduce copyvios on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127179 [22:19:04] (03PS1) 10JGonera: Consolidate how overlays are hidden [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127379 [22:20:02] brion: one more for ya ^ :) oh, gonna head out a bit early today - around 4… any time for a bit of cr between now and then? [22:24:59] (03PS1) 10Jforrester: Also destroy target when exiting without saving changes [extensions/MobileFrontend] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127380 [22:59:52] (03PS3) 10JGonera: [WIP] Story 1904: Filters to reduce copyvios on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127179 [23:09:54] (03CR) 10Jdlrobson: [C: 04-1] "You didn't actually run the tests did you.. ;-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127344 (owner: 10MaxSem) [23:38:55] kenanwang, is 11 on Monday OK for going through sign off?