[00:49:19] (03CR) 10Kaldari: [C: 04-1] "Now that disableSearchAndFooter can only used for disabling the footer, it should be renamed to just disableFooter. Alternatively, it coul" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127194 (owner: 10Jdlrobson) [08:09:08] (03PS9) 10Yuvipanda: Add EventLogging for Edit Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126849 [08:09:10] (03PS1) 10Yuvipanda: Add event logging for reading actions [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127600 [09:22:02] hola. [09:23:49] hi Amir [09:27:27] hi aharoni [09:27:28] hi multichill [09:28:00] [13WikipediaMobile] 15siebrand pushed 1 new commit to 06master: 02http://git.io/7cs2IQ [09:28:00] 13WikipediaMobile/06master 14a452252 15Siebrand Mazeland: Localisation updates from https://translatewiki.net. [09:28:46] hi YuviPanda, are you looking forward to going to the mountains? ;-) [09:28:55] multichill: :D very much! [09:29:07] multichill: I am also going to be spending some time in the UK with a friend afterwards. In Scotland. [09:29:11] multichill: hopefully I'll survive the cold [09:29:17] lol [09:29:57] :D [09:30:14] What do you guys think, shouldn't action=info return all page_props? [09:30:17] See for example https://en.wikipedia.org/w/index.php?title=Bah%C3%A1%27%C3%AD_Faith&action=info [09:30:36] It does return the wikidata id, but not the image page property [09:30:46] hmm, should I think. [09:31:07] although ideally action=info will die and we can just integrate it into the page itself somewhere (ajax?) [09:32:16] (03PS1) 10Yuvipanda: Add EL for login funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127610 [09:33:33] The image thing is part of mobile extension, right? [09:33:33] https://en.wikipedia.org/w/api.php?action=query&prop=pageprops&titles=Grote_Kerk,_Haarlem [09:34:57] YuviPanda: MobileFrontend? [09:35:09] multichill: no, it was split out into its own etension a while ago [09:35:11] multichill: PageImages [09:35:13] *extension [09:35:24] Ah, found it [09:36:38] * YuviPanda has a flight in a couple of hours [09:36:43] hmm, I should leave now, I think [09:37:18] Where are you going ? [09:38:05] YuviPanda: https://bugzilla.wikimedia.org/show_bug.cgi?id=64178 , in case you get bored :P [09:38:20] multichill: back to Mumbai. Was in Jaipur for a friend's weddin [09:38:33] * YuviPanda cc's self [09:39:46] I should go now [09:39:55] Enjoy your flight! [09:40:53] YuviPanda: I'd like to play with the language list on MobileFrontend. It has a bunch of issues. [09:40:55] How do I edit it? [09:41:20] aharoni: MobileFrontend? no idea :| [09:41:30] aharoni: haven't actually played with any MF code in a long long time [09:41:36] aharoni: email mobile-l? [09:41:41] is there anybody in this timezone who does?.. [09:41:49] looks like templates/overlays/languages.html has the relevant code, but if I change anything, it doesn't show up. [09:42:09] either it's the wrong file or it's cached somewhere. [09:42:45] aharoni: it's probably cached, yeah. they have a template thing going on [09:42:59] aharoni: sadly no. I think *everyone* who works on MF is now in SF, since Max moved last week [09:43:07] meh. [09:43:25] sorry! [09:43:38] I've to go now. cya! [10:41:22] (03PS1) 10Amire80: Replace parentheses with pipe in the language list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127612 [10:43:41] (03PS1) 10Amire80: Center the language list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127613 [16:28:06] (03PS7) 10Jdlrobson: Push search bar on special pages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127194 [16:28:12] (03CR) 10Jdlrobson: "Should be moved altogether! :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127194 (owner: 10Jdlrobson) [16:28:52] (03CR) 10jenkins-bot: [V: 04-1] Push search bar on special pages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127194 (owner: 10Jdlrobson) [16:29:55] (03PS8) 10Jdlrobson: Push search bar on special pages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127194 [16:30:11] (03PS5) 10Jdlrobson: Story 1891: Push history to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127195 [16:30:27] (03PS5) 10Jdlrobson: Story 1925: Push user contributions to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127196 [16:34:51] (03PS5) 10Jdlrobson: Story 1921: Push user profile to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127268 [16:34:57] (03PS8) 10Jdlrobson: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [16:39:50] hi jdlrobson do you know if the current test failures are the result of a bug, or is the test itself incorrect? https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox/ [16:40:11] chrismcmahon: looking! [16:40:28] looks like it might be a bug chrismcmahon [16:40:47] there was a bad rebase maybe this effected it [16:40:49] i can fix up [16:41:28] jdlrobson: thanks. the failure is definitely because of behavior of MF, but the page the test fails on looks basically OK, it's not anything catastrophic, so I wasn't sure [16:41:31] chrismcmahon: there should be an icon next to them [16:42:17] jdlrobson: cool. I'm going to file a BZ for it, I like to track issues caught by browser tests that way [16:44:41] (03CR) 10Siebrand: "Is there a bugzilla id that should be connected to this change?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127612 (owner: 10Amire80) [16:49:03] (03PS4) 10Jdlrobson: EventLog profile and history link clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123474 [16:50:31] (03CR) 10Jdlrobson: [C: 04-1] "Just noticed this seems to introduce a styling regression for me. Links in last modified bar on non-fresh pages go purple rather than blac" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [16:52:57] (03CR) 10Jdlrobson: [C: 04-1] "1 minor bit of cleanup needed! Almost there :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 (owner: 10Theopolisme) [16:54:53] (03CR) 10Jdlrobson: [C: 032] Replace parentheses with pipe in the language list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127612 (owner: 10Amire80) [16:58:04] (03CR) 10Jdlrobson: [C: 04-1] "Can you cut a bug for this and tag it design as I'm not sure about this. It doesn't look very good on a tablet screen for one and it also " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127613 (owner: 10Amire80) [16:59:00] (03Merged) 10jenkins-bot: Replace parentheses with pipe in the language list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127612 (owner: 10Amire80) [17:03:44] (03PS1) 10Yuvipanda: Make log out log out user only from this device [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127651 [17:22:48] (03PS1) 10Jdlrobson: Suppress username on contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127656 [17:23:28] jgonera: awjr hey sorry missed the standup [17:23:38] mhurd: am [17:23:43] mhurd: off for food. [17:23:44] brb [17:23:48] YuviPanda: k [17:24:04] heya kenanwang - jgonera mentioned during standup that he still needs final copy for the exif-related story [17:25:14] kenanwang: also, ready for signoff desperately needs attention [17:25:37] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed." (032 comments) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [17:27:29] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [17:27:55] (03CR) 10Siebrand: Make log out log out user only from this device (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127651 (owner: 10Yuvipanda) [17:28:31] (03CR) 10Siebrand: Article history interface. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [17:29:00] (03CR) 10Kaldari: [C: 032] Push search bar on special pages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127194 (owner: 10Jdlrobson) [17:29:32] (03Merged) 10jenkins-bot: Push search bar on special pages to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127194 (owner: 10Jdlrobson) [17:30:35] (03CR) 10Mhurd: "Quick question... just curious." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [17:34:40] (03CR) 10Brion VIBBER: [C: 032 V: 032] Flip edit icon in RTL [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127155 (owner: 10Brion VIBBER) [17:35:05] OMG KALDARI YOU JUST MERGED A REV I WAS GOING TO MINUSONE!!ONEONE [17:35:22] (03CR) 10Siebrand: Article history interface. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [17:36:23] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [17:38:03] (03CR) 10Siebrand: Article history interface. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [17:38:13] (03CR) 10Kaldari: [C: 032] Story 1891: Push history to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127195 (owner: 10Jdlrobson) [17:38:36] (03PS1) 10MaxSem: Y U NO USE PhpStorm, jdlrobson? :P [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127661 [17:38:41] (03CR) 10Mhurd: "Added Comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [17:39:12] (03PS3) 10Mhurd: Article history interface. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 [17:39:59] (03CR) 10MaxSem: [C: 032] Story 1925: Push user contributions to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127196 (owner: 10Jdlrobson) [17:40:50] brion: ok, the article history patch should be ready to review. i amended for siebrand [17:41:26] awesome i’ll poke that shortly [17:41:53] brion: woohoo! [17:44:56] hey brion [17:45:06] yo [17:45:24] brion: CR! :) [17:45:25] (03PS2) 10Yuvipanda: Make log out log out user only from this device [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127651 [17:47:59] (03Merged) 10jenkins-bot: Story 1891: Push history to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127195 (owner: 10Jdlrobson) [17:48:27] (03Merged) 10jenkins-bot: Story 1925: Push user contributions to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127196 (owner: 10Jdlrobson) [17:49:20] brion: sorry, got disconnected. Did I miss anything? [17:49:26] nope [17:50:43] brion: ok :) [17:50:47] vbamba: hey? [17:50:53] mhurd: what did you want me to ask vbamba about again? [17:51:34] YuviPanda: oh, just if you had any questions about the license text mock she uploaded. it’s here: https://trello.com/c/zHmmH2xT/74-design [17:51:50] hey YuviPanda, I am working on the app schemas, do you have 10 mins to sync up in the next hour or so? [17:52:04] mhurd: ah, right. I'll look at it in a bit! [17:52:08] DarTar: sure! can do! [17:52:16] I just finished implementing most tho [17:52:25] k sweet, give me one sec [17:52:28] DarTar: ok! [17:53:58] (03CR) 10Brion VIBBER: [C: 04-2] "Seems fine except for hiding the status bar, which is usually bad form for something that's not an immersive game or something..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127341 (owner: 10Mhurd) [17:55:17] brion: vibha and i played with a couple reader type apps and they hid it, so we thought we’d experimentally do so as well to get feedback. wanna maybe push it out with wednesday’s beta then revert if there’s a firestorm? [17:55:43] mhurd: how many people are actively testing the iOS app, btw? [17:55:56] YuviPanda: less than a dozen [17:56:00] ah, hmm. [17:56:31] YuviPanda: i was able to update the testflight distribution list, so should be more for wednesday’s release [17:56:43] hmm, alright. [17:56:44] mhurd: i’d rather just kill it with fire. hiding the system statusbar seems evil [17:57:19] brion: haha k. maybe i could instead change it to dark status bar so there’s a stronger visual separation? ok to try that? [17:57:27] sure [17:57:40] (03PS4) 10Brion VIBBER: Article history interface. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [17:57:43] YuviPanda: granted it won’t be too many more. most who signed up haven’t even downloaded [17:59:28] (03CR) 10Amire80: "Siebrand - no, no bug number." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127612 (owner: 10Amire80) [18:01:45] (03PS3) 10Jdlrobson: Fix more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127184 [18:02:07] (03CR) 10jenkins-bot: [V: 04-1] Fix more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127184 (owner: 10Jdlrobson) [18:03:23] (03CR) 10Brion VIBBER: "A few issues:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [18:03:38] (03PS2) 10Brion VIBBER: First pass at credits page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127378 (owner: 10Mhurd) [18:04:06] (03PS9) 10Kaldari: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 [18:04:41] mhurd: how are the red rocks treating you ? [18:05:59] tfinc: had a great weekend! got to lead some trad both days. a bit of sport in the shade yesterday too. my cold got a bit worse friday night, but the dry air seemed to help [18:06:17] (03CR) 10MaxSem: [C: 04-1] "It wouldn't be very good to promote to stable a page that crashes for anon profiles:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127268 (owner: 10Jdlrobson) [18:06:36] mhurd: got any photos to share with the climbing list ? [18:06:37] (03CR) 10Brion VIBBER: "Let's maybe throw in a mention that license information is available if you click through; ideal might be if we provide a clickthrough str" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127378 (owner: 10Mhurd) [18:07:42] (03CR) 10Mhurd: "Good points. For making the back button more apparent I can move the "Page history" title to the nav bar with the standard back arrow icon" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [18:07:44] (03CR) 10Jdlrobson: "COZ MAKE PHPUNIT ONLY RUNZ PHPCODESNIFFER ANDZ I DONTZ RUN AN IDE MaxSem :P" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127661 (owner: 10MaxSem) [18:08:05] (03CR) 10Mhurd: "Will do." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127378 (owner: 10Mhurd) [18:08:18] (03PS2) 10Jdlrobson: Hygiene: Y U NO USE PhpStorm, jdlrobson? :P [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127661 (owner: 10MaxSem) [18:08:20] brion: added comments. good points [18:08:25] brion: amending [18:08:30] excellent mwahahaha [18:08:37] brion: :) [18:08:45] (03CR) 10Jdlrobson: [C: 032] Hygiene: Y U NO USE PhpStorm, jdlrobson? :P [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127661 (owner: 10MaxSem) [18:10:11] (03PS4) 10Jdlrobson: Fix more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127184 [18:10:19] tfinc: yes! i took a couple pictures :) [18:10:24] (03PS2) 10Jdlrobson: QA: Add browser tests for presence of more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127185 [18:13:59] (03Merged) 10jenkins-bot: Hygiene: Y U NO USE PhpStorm, jdlrobson? :P [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127661 (owner: 10MaxSem) [18:17:20] (03PS1) 10Kaldari: Hygiene: Don't create li tag if message is blank (disabled) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127668 [18:18:28] (03PS6) 10Jdlrobson: Story 1921: Push user profile to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127268 [18:18:43] YuviPanda: did we blacklist anon editing? [18:18:47] on the test url? [18:19:01] brion: yeah, there's a cache issue on the serverside. needs to be touched. I'm prepping a patch to move it to production [18:19:06] ok [18:19:14] i’ll have to see if i can trigger the captcha logged in then [18:20:06] brion: no, you can comment out one line [18:20:53] hmm, no maxsem [18:21:19] YuviPanda: Try OuKB [18:21:29] oh, Reedy is here [18:21:44] Reedy: what's the prod equivalent of http://bits.beta.wmflabs.org/static-master/extensions/MobileApp/config/android.json [18:21:55] essentially, 'link to version of this static file in this extension' [18:22:17] $wgGroupPermissions['*']['edit'] = false; [18:22:56] Oh [18:22:58] lol [18:22:59] err [18:23:15] brion: can you take a pass on https://etherpad.wikimedia.org/p/dmitry-onboarding and note what your on the hook for ? [18:23:31] (03CR) 10Brion VIBBER: "Coupla notes:" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127420 (owner: 10Yuvipanda) [18:25:27] (03CR) 10Brion VIBBER: [C: 032 V: 032] "This still fixes the overlap issue so merging. :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127420 (owner: 10Yuvipanda) [18:26:00] YuviPanda, static-current [18:26:18] OuKB: https://bits.wikimedia.org/static-current/extensions/MobileApp/config/android.json is 404 [18:26:22] YuviPanda, also - do you want me to give Dmitry a crash course on APII? [18:26:34] OuKB: ooo, that'll be great! ^ [18:26:46] ok, I [18:26:53] 'll add it to ep [18:27:05] (03CR) 10Brion VIBBER: [C: 032 V: 032] Don't ask to log in more than once [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127421 (owner: 10Yuvipanda) [18:29:24] YuviPanda: android.json only exists in php-1.24wmf1 [18:29:42] https://bits.wikimedia.org/static-1.24wmf1/extensions/MobileApp/config/android.json [18:30:04] But it will be in static-current when 1.24wmf1 is deployed more widely [18:30:06] ie tomorrow [18:31:58] (03CR) 10Brion VIBBER: [C: 032 V: 032] "\o/" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/126849 (owner: 10Yuvipanda) [18:32:36] If major... Update version in 1.23wmf22 [18:34:29] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add event logging for reading actions [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127600 (owner: 10Yuvipanda) [18:35:48] (03PS7) 10MaxSem: Story 1921: Push user profile to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127268 (owner: 10Jdlrobson) [18:37:07] (03CR) 10Brion VIBBER: [C: 032 V: 032] Add EL for login funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127610 (owner: 10Yuvipanda) [18:37:16] (03CR) 10MaxSem: [C: 032] Story 1921: Push user profile to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127268 (owner: 10Jdlrobson) [18:37:47] (03Merged) 10jenkins-bot: Story 1921: Push user profile to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127268 (owner: 10Jdlrobson) [18:40:32] (03CR) 10Brion VIBBER: [C: 032 V: 032] Make log out log out user only from this device [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127651 (owner: 10Yuvipanda) [18:40:36] !logs [18:40:59] Reedy: aha! ty! so It'll be in -current tomorrow [18:43:21] (03PS10) 10MaxSem: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [18:43:28] (03PS1) 10Yuvipanda: Switch to prod URL for remote config [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127675 [18:43:30] brion: ^ should restore it [18:43:30] (03PS2) 10Mhurd: Variety of small UX/Design tweaks. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127341 [18:43:33] the anon editing I mean [18:43:46] brion: ^ reverted the status bar hiding [18:44:52] mhurd: https://bugzilla.wikimedia.org/show_bug.cgi?id=64177 is probably a bug on iOS as well (if you use action=logout) [18:45:26] YuviPanda: will test now... [18:45:46] mhurd: ok! Login on desktop, sign out on device, refresh page on desktop [18:45:55] YuviPanda: k [18:46:31] brion: will try dark status bar later… just reverted the hiding for now [18:47:31] (03CR) 10Brion VIBBER: "Hmmm, is that 'static-1.24wmf1' URL going to be stable? Sounds like that'll change with every version bump." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127675 (owner: 10Yuvipanda) [18:48:05] YuviPanda: not seeing it on ios [18:48:06] (03CR) 10Brion VIBBER: [C: 032 V: 032] Variety of small UX/Design tweaks. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127341 (owner: 10Mhurd) [18:48:11] mhurd: ok! [18:48:24] (03CR) 10MaxSem: [C: 04-1] "Another standard way to disable a message in MW is setting it to "-", use Message::isDisabled()?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127668 (owner: 10Kaldari) [18:49:25] (03PS1) 10Yuvipanda: Update remote config URL to stable production version [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127679 [18:49:28] brion: ^ [18:49:53] (03CR) 10MaxSem: Story 1922: Promote last modified at top to stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [18:49:59] brion: -current won't work until a couple of days, according to Reedy. so push to 1.24wmf1 and merge the other patchset when -current workos [18:50:03] brion: is that smallTweaks branch ready to merge? i’m on to updating the article history patch based on your feedback [18:50:24] “This has to be merged only 1.24wmf1 is pushed to all” [18:50:27] only -> after? [18:51:23] brion: gah, yeah. 'only after' [18:51:25] brion: let me amend [18:51:34] :D [18:51:37] brion: but yeah, we need to let that one sit for a few days, but in the meantime this patch will re-enable anon editing [18:52:23] jdlrobson, https://gerrit.wikimedia.org/r/#/c/127656/1/includes/specials/SpecialMobileContributions.php <-- I wonder if comment should say that it overrides a var from the parent class [18:52:52] ok [18:53:04] (03CR) 10JGonera: [C: 032] Fix infinite scroll on uploads page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127291 (owner: 10Jdlrobson) [18:53:16] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok followup commit will make this stable once it's set up :D" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127675 (owner: 10Yuvipanda) [18:53:37] (03Merged) 10jenkins-bot: Fix infinite scroll on uploads page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127291 (owner: 10Jdlrobson) [18:53:39] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [18:54:10] (03PS1) 10Yuvipanda: Remove white square next to 'log out' icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127680 [18:57:19] (03PS2) 10Jdlrobson: Suppress username on contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127656 [19:01:25] (03CR) 10Brion VIBBER: [C: 04-1] "This looses the spacing that the icon would have provided and looks pretty terrible." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127680 (owner: 10Yuvipanda) [19:02:06] (03PS2) 10Yuvipanda: Remove white square next to 'log out' icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127680 [19:02:08] brion: oops, meant to set it to 'invisible' [19:03:19] brion: updated nw [19:03:32] thx :D [19:04:21] brion: create account EL isn't done yet :) but is trivial, let me finish that in a bit [19:04:27] ok [19:04:45] (03CR) 10Brion VIBBER: [C: 032 V: 032] Remove white square next to 'log out' icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127680 (owner: 10Yuvipanda) [19:04:48] MaxSem: http://wwwapps.ups.com/WebTracking/track?track=yes&trackNums=1ZEV85026770888490&loc=en_us :) [19:05:06] :) [19:05:22] brion: pfft v+2 :) [19:05:37] mhurd: you set up with +2 now ? [19:05:46] woops [19:05:52] tfinc: no we still gotta do that [19:06:00] brion: what does it take these days? [19:06:06] do we just need to poke someone ? [19:06:08] brion: he should just get added to the wmf ldap group. brings in ability to get lots of things done. [19:06:28] i got no idea how to do ldap groups, i only know the page to request access on :D [19:06:28] marktraceur: do you know whom to poke to get people added to the wmf ldap group? [19:06:39] tfinc: brion: YuviPanda: lunchtime! [19:06:40] https://www.mediawiki.org/wiki/Gerrit/Project_ownership <- [19:06:42] brion: heh :D I remember someone from ops or someuch did it [19:07:07] brion: yeah, so wmf ldap gives you that, plus a bunch of other things (graphite access, etc). All WMF employees are supposed to have it (engineering staff at least) [19:07:38] so………………….. email it? [19:08:45] anyway i added on https://www.mediawiki.org/wiki/Gerrit/Project_ownership#mhurd_.28Wikipedia_for_iOS.29 [19:09:00] brion: ah, ok! apparently it requires an RT ticket [19:09:01] oh well [19:09:11] boo RT [19:09:34] heh [19:11:19] brion: apparently shouldn't take too long (see -staff). I'll have monte send it in when he comes back [19:11:29] ok [19:15:28] (03CR) 10JGonera: [C: 04-1] "A few minor things." (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [19:16:06] brion: before we push an alpha I want to make sure we have opt out. We should probably do that for iOS too [19:16:21] ah yeah [19:16:23] wise [19:18:49] glad were figuring this out now before dmitry joins .. you knwow .. tomorrow :D [19:29:45] (03CR) 10JGonera: [C: 032] Suppress username on contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127656 (owner: 10Jdlrobson) [19:31:20] (03Merged) 10jenkins-bot: Suppress username on contributions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127656 (owner: 10Jdlrobson) [19:38:55] (03CR) 10Kaldari: Story 1922: Promote last modified at top to stable (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [19:58:47] YuviPanda! [19:58:55] violetto! [19:59:11] YuviPanda: can you send me the latest build peas! [19:59:38] violetto: moment! [19:59:50] YuviPanda: oraits [20:00:15] (03CR) 10Kaldari: Story 1922: Promote last modified at top to stable (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [20:05:56] (03PS11) 10Kaldari: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 [20:09:24] brion: YuviPanda: tfinc: back from lunch [20:10:15] YuviPanda: Wh...no [20:10:25] marktraceur: found out! [20:10:30] YuviPanda: My first guess would be ^d, but it would probably be wrong [20:10:52] marktraceur: yeah, apparently you need to file an RT ticket [20:17:02] violetto: http://tools.wmflabs.org/android-sdk-builds/wikipedia.apk [20:18:53] mhurd: welcome back [20:19:08] tfinc: :) [20:20:53] mhurd: did you start the process for access to eventlogging data? [20:21:20] mhurd: first they'll ask tomasz and then there's a 3 day waiting period, I think. [20:21:57] 3 day waiting period? what is this like buying a gun? :P [20:22:14] brion: hehe :D It's shell access [20:22:18] :D [20:25:13] YuviPanda: andrew said create an RT request ticket, so i emailed access-requests@rt.wikimedia.org to get login access to RT. got the following response: “RT could not load a valid user, and RT's configuration does not allow for the creation of a new user for your email” [20:25:57] YuviPanda: have tons of other stuff to finish so wasn’t able to figure out what to do about that yet [20:26:04] mhurd: please respond to andrew with that. he'll figure that out I guess. [20:26:22] YuviPanda: will do [20:26:25] mhurd: true, but since you would need this to verify that your events are going through properly without depending on me it would be nice to get this done so there is no dependency ther. [20:26:27] YuviPanda: thank you very much sir [20:26:31] violetto: yw :) [20:26:36] YuviPanda: true [20:26:40] YuviPanda: will do [20:26:46] violetto: I'll setup a self-serve type thing soon, so you can always hit a URL and get the latest master [20:28:40] YuviPanda: i can appreciate that! [20:32:50] (03CR) 10JGonera: [C: 04-1] "Two more replies in patchset 10 (lastEdited.js and diff.feature)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [20:34:32] ahh Google i/o is being bitchy as i submitted an app under my @wikimedia. if i use my @gmail i get the right prompt [20:34:39] going to wait a day before i use our code [20:34:41] just in case ... [20:39:02] (03PS5) 10Mhurd: Article history interface. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 [20:40:15] mhurd: just verifying that your back tomorrow for the candidate interview loop [20:40:26] tfinc: yes [20:40:42] (03CR) 10Mhurd: "Moved "Page history" to nav bar with standard back arrow." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [20:43:11] brion: ignore that last commit - it seemed to have changed a bunch of the lang files for some reason... [20:43:28] ok i think i see the basic schema for the saved & history pages on ios [20:43:37] should be possible to extract the data out [20:44:18] brion: cool! let me know if you need anything for injecting into core data schema [20:44:27] ok [21:01:42] ok i’m gonna run some errands then see if i can get the data import working [21:02:07] mhurd: anything else i should poke at other than second review pass over the history & about pages? [21:03:05] brion: oh, just a sec - i’m going to abandon that article history patch and submit new one… [21:03:14] ah ok [21:03:18] then i shall let you do that :D [21:03:38] brion: sry bout that! it’ll be there in just a minute... [21:03:49] no worries [21:04:16] ok be back online in a bit [21:04:26] (03Abandoned) 10Mhurd: Article history interface. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127188 (owner: 10Mhurd) [21:05:02] (03Abandoned) 10Mhurd: First pass at credits page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127378 (owner: 10Mhurd) [21:05:23] (03PS1) 10Mhurd: Article history interface. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127792 [21:05:53] (03CR) 10Mhurd: "Brion had commented:" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127792 (owner: 10Mhurd) [21:07:51] (03CR) 10Mhurd: "This patch addresses the "no clear back button" issue." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127792 (owner: 10Mhurd) [21:12:10] (03CR) 10Theopolisme: "Re about trailing commas and jshint. Fix forthcoming :P" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 (owner: 10Theopolisme) [21:13:45] (03PS5) 10Theopolisme: LanguageOverlay: Only display title if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 [21:13:53] (03CR) 10jenkins-bot: [V: 04-1] LanguageOverlay: Only display title if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 (owner: 10Theopolisme) [21:14:03] ^ I've configured pywikibugs to notify this channel on "Wikimedia Mobile", "Commons App", "Wikipedia App", "MobileFrontend" bugs. I hope that's a sensible/useful set. [21:14:20] jgonera: Your replies at https://gerrit.wikimedia.org/r/#/c/127197/10 didn't seem to post [21:14:26] I don't see any new ones [21:14:42] right, I probably posted it using the patchset 11 button... [21:14:42] (03PS2) 10Mhurd: Article history interface. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127792 [21:14:45] gotta love gerrit [21:14:53] (03CR) 10JGonera: Story 1922: Promote last modified at top to stable (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [21:16:55] YuviPanda: are the crash emails still just going to you? [21:18:40] (03PS6) 10Theopolisme: LanguageOverlay: Only display title if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 [21:21:14] (03PS1) 10MaxSem: Special-case history and diff desktop links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127794 [21:21:33] 4MobileFrontend 3beta: Mobile history desktop link doesn't point to right place - 10https://bugzilla.wikimedia.org/64112 (10Gerrit Notification Bot) 5NEW>3PAT [21:21:33] 4MobileFrontend 3beta: Mobile history desktop link doesn't point to right place - 10https://bugzilla.wikimedia.org/64112#c2 (10Gerrit Notification Bot) Change 127794 had a related patch set uploaded by MaxSem: Special-case history and diff desktop links https://gerrit.wikimedia.org/r/127794 [21:27:53] (03CR) 10JGonera: [C: 032] LanguageOverlay: Only display title if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 (owner: 10Theopolisme) [21:28:25] (03Merged) 10jenkins-bot: LanguageOverlay: Only display title if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127162 (owner: 10Theopolisme) [21:31:19] (03PS12) 10Kaldari: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 [21:43:06] (03PS1) 10Mhurd: First pass at credits page. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127798 [21:44:57] (03CR) 10Mhurd: "Updated to move "Credits" title to nav bar with standard back arrow." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127798 (owner: 10Mhurd) [21:47:45] (03PS1) 10Jdlrobson: Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 [21:50:20] (03CR) 10MaxSem: [C: 032] Fix more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127184 (owner: 10Jdlrobson) [21:50:48] 4MobileFrontend 3beta: "more" link on Special:History doesn't work - 10https://bugzilla.wikimedia.org/63968 (10Jon) 5PAT>3RES/FIX [21:50:51] (03Merged) 10jenkins-bot: Fix more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127184 (owner: 10Jdlrobson) [21:51:18] 4MobileFrontend 3beta: "more" link on Special:History doesn't work - 10https://bugzilla.wikimedia.org/63968#c3 (10Gerrit Notification Bot) Change 127184 merged by jenkins-bot: Fix more link on history page https://gerrit.wikimedia.org/r/127184 [21:51:48] 4MobileFrontend 3beta: last contribution summary shows the username but should not - 10https://bugzilla.wikimedia.org/64189 (10Jon) 5PAT>3RES/FIX [21:56:18] (03CR) 10Kaldari: "@MaxSem: That's actually what I was going to do first, but then I discovered that if you prevent SkinMinerva::prepareMobileFooterLinks fro" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127668 (owner: 10Kaldari) [21:57:36] 4Wikipedia App 3Generic: App crashes at launch on Android 4.4.2 - 10https://bugzilla.wikimedia.org/64208 (10May Tee-Galloway) 3NEW p:3Unprio s:3normal a:3None No chance to see launch screen at all [21:58:24] (03PS1) 10Jdlrobson: Add user icon to left of contributions title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127803 [22:01:34] YuviPanda: i haven't had a chance to look at the build cus it keeps crashing! [22:01:57] (03CR) 10MaxSem: "Note that it still performs another request for search results while it's now doable with the main request." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 (owner: 10Jdlrobson) [22:03:21] (03CR) 10MaxSem: [C: 032] Hygiene: Don't create li tag if message is blank (disabled) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127668 (owner: 10Kaldari) [22:03:53] (03Merged) 10jenkins-bot: Hygiene: Don't create li tag if message is blank (disabled) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127668 (owner: 10Kaldari) [22:05:27] violetto: oh? [22:05:31] violetto: send crash report? [22:07:17] (03CR) 10MaxSem: [C: 031] Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 (owner: 10Jdlrobson) [22:07:55] James_F|Away: what's https://gerrit.wikimedia.org/r/127380 all about? Are you planning to LD it? [22:10:08] (03CR) 10Jdlrobson: [C: 032] Consolidate how overlays are hidden [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127379 (owner: 10JGonera) [22:10:39] (03Merged) 10jenkins-bot: Consolidate how overlays are hidden [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127379 (owner: 10JGonera) [22:16:22] (03CR) 10Jdlrobson: [C: 031] "Any chance of some tests for the diff page?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127794 (owner: 10MaxSem) [22:20:43] brion: heya! i resubmitted those 2 patches w/ both now using nav bar for title w back arrow. [22:21:08] great! lemme fire up the iphone and test those [22:21:35] brion: a couple of your comments remain to be addressed, but just let me know if they’re blockers [22:21:46] jdlrobson: Yeah. [22:22:07] jdlrobson: It's the cause of a fatal in prod. [22:22:21] jdlrobson: Roan can say more. [22:23:19] (03PS1) 10Yuvipanda: Add EventLogging for Create Account funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127810 [22:23:22] brion: ^ last in the series. [22:25:16] (03PS2) 10Yuvipanda: Add EL for CreateAccount Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127810 [22:25:24] MaxSem: https://twitter.com/mahemoff/status/458341461764104193 do we have anything like that? [22:26:00] mhurd: ok the arrow is so much clearer now :D thanks [22:26:13] brion: yay! [22:26:29] brion: did same for credits page [22:26:36] 4Wikipedia App 3Generic: Search field doesn't disable when search selection has been made - 10https://bugzilla.wikimedia.org/64209 (10May Tee-Galloway) 3NEW p:3Unprio s:3normal a:3None The cursor still blinks and tends to be distracting while reading the article. [22:30:12] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok much better with the arrow :D Other bits can be fixed up later." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127792 (owner: 10Mhurd) [22:30:57] brion: thx! [22:31:25] jdlrobson, replied [22:32:25] Thanks MaxSem :D [22:33:51] (03CR) 10Brion VIBBER: [C: 032 V: 032] "Ok let's keep it simple then :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/127798 (owner: 10Mhurd) [22:34:26] brion: cool. can tweak it later :) [22:34:30] (03CR) 10Brion VIBBER: [C: 032] Add EL for CreateAccount Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127810 (owner: 10Yuvipanda) [22:38:35] (03PS1) 10Yuvipanda: Allow people to opt out of EventLogging [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127813 [22:39:29] violetto: hey can you point me to the svg to use for the app icon? no rush - prob won’t get to it until tomorrow [22:39:45] (03PS3) 10Yuvipanda: Remove white square next to 'log out' icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127680 [22:39:47] (03PS2) 10Yuvipanda: Allow people to opt out of EventLogging [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127813 [22:39:49] (03PS3) 10Yuvipanda: Add EL for CreateAccount Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127810 [22:39:51] (03PS2) 10Yuvipanda: Update remote config URL to stable production version [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127679 [22:39:53] (03PS1) 10Yuvipanda: Add CreateAccountFunnel file that was missed in previous commit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127816 [22:39:54] what the fuck, gerrit?! [22:39:58] aaah [22:39:58] right [22:40:00] hmm [22:40:28] (03PS2) 10Yuvipanda: Add CreateAccountFunnel file that was missed in previous commit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127816 [22:40:30] (03PS4) 10Yuvipanda: Remove white square next to 'log out' icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127680 [22:40:32] (03PS3) 10Yuvipanda: Allow people to opt out of EventLogging [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127813 [22:40:34] (03PS4) 10Yuvipanda: Add EL for CreateAccount Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127810 [22:40:59] kenanwang: how goes working through the bug column on https://trello.com/b/8ADlEuVo/mobile-app-sprint-29-android-to-b ? [22:41:59] (03PS4) 10Yuvipanda: Allow people to opt out of EventLogging [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127813 [22:42:01] (03PS5) 10Yuvipanda: Add EL for CreateAccount Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127810 [22:42:41] (03Abandoned) 10Yuvipanda: Add CreateAccountFunnel file that was missed in previous commit [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127816 (owner: 10Yuvipanda) [22:42:49] brion: ok, I think they are all actionable now :D [22:44:32] wheee [22:44:40] brion: we have opt out! [22:46:18] * brion waits for jenkins [22:51:18] 4Wikipedia App 3Generic: App crashes at launch on Android 4.4.2 - 10https://bugzilla.wikimedia.org/64208#c1 (10Yuvi Panda) 5NEW>3RES/FIX I had sent her a bad build. Fixed now :) [22:53:47] (03CR) 10Catrope: [C: 032] Also destroy target when exiting without saving changes [extensions/MobileFrontend] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127380 (owner: 10Jforrester) [22:54:23] (03Merged) 10jenkins-bot: Also destroy target when exiting without saving changes [extensions/MobileFrontend] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127380 (owner: 10Jforrester) [22:58:48] 4Wikipedia App 3Generic: Some pages appear too wide and contents can't be scrolled left/right correctly - 10https://bugzilla.wikimedia.org/64130#c1 (10kenan wang) 5NEW>3ASS We're going to fix this in the next 2 weeks. Thanks! [22:59:10] mhurd: okay [22:59:18] 4Wikipedia App 3Generic: [Android] Can't scroll wide tables to the right - 10https://bugzilla.wikimedia.org/64075#c1 (10kenan wang) We're fixing this in the next two weeks. [22:59:22] violetto: cool thx [22:59:48] 4Wikipedia App 3History: iOS app: Should have a "clear all" button for browsing history - 10https://bugzilla.wikimedia.org/63970#c2 (10kenan wang) We will be working on this in the next 3 weeks. [23:00:09] violetto: if you want an “app icon” card on the design board let me know, or feel free to make one [23:00:19] 4Wikipedia App 3Generic: [Android] Opening special pages crashes the app - 10https://bugzilla.wikimedia.org/63451#c2 (10kenan wang) Yes. We are working on this in the next 2 weeks. [23:00:33] 4Wikipedia App 3Generic: App crashes if you open a non-existing page - 10https://bugzilla.wikimedia.org/62639#c4 (10kenan wang) Yes. We are working on this in the next 2 weeks. [23:02:15] mhurd: i'll see where it fits, since the board sorted by pages and app icon isnt a page [23:02:22] mhurd: what do you think [23:02:53] violetto: good point. hmm… [23:03:12] violetto: can prob make and exception for icon ;) [23:03:49] violetto: your call [23:03:58] mhurd: yeah, maybe i'll just attach it to the sprint board [23:04:08] violetto: cool [23:27:44] (03CR) 10Kaldari: [C: 04-1] EventLog profile and history link clicks (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123474 (owner: 10Jdlrobson) [23:41:42] (03PS1) 10Kaldari: Fixing icons in editor switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127830 [23:42:03] 4MobileFrontend 3alpha: Editor switcher icons are incorrect in wikitext editor - 10https://bugzilla.wikimedia.org/64106#c2 (10Gerrit Notification Bot) Change 127830 had a related patch set uploaded by Kaldari: Fixing icons in editor switcher https://gerrit.wikimedia.org/r/127830 [23:42:03] 4MobileFrontend 3alpha: Editor switcher icons are incorrect in wikitext editor - 10https://bugzilla.wikimedia.org/64106 (10Gerrit Notification Bot) 5NEW>3PAT [23:45:13] (03CR) 10Kaldari: [C: 032] Add user icon to left of contributions title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127803 (owner: 10Jdlrobson) [23:45:44] (03Merged) 10jenkins-bot: Add user icon to left of contributions title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127803 (owner: 10Jdlrobson) [23:55:42] kaldari, so what's the reason for creating a new div and removing the old one in that patch? [23:55:44] (03PS1) 10Jdlrobson: Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 [23:55:45] (last edited) [23:56:06] 4MobileFrontend 3Hygiene: Nearby is not a PageList - 10https://bugzilla.wikimedia.org/64212 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon The nearby list of results looks like the search and watchlist components (i.e. is a PageList) It however uses its own code and thus doesn't do things like add a watch s... [23:56:21] (03CR) 10jenkins-bot: [V: 04-1] Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 (owner: 10Jdlrobson) [23:57:57] jgonera: that's not introduced in that patch, it's just moved to stable [23:58:21] But it's because the top-bar version has 2 links rather than 1 [23:58:36] well yeah, but we can still just replace the contents of this div [23:58:51] anyway, I'll merge it and maybe do a follow up (unless I'm missing something) [23:58:54] in the 1 link version there is no div, just an anchor tag [23:59:00] oh [23:59:09] I see, so $lastModified is an anchor? [23:59:17] so that's what I was missing ;) [23:59:21] (03PS5) 10Jdlrobson: EventLog profile and history link clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123474 [23:59:34] yeah