[00:00:03] maybe we should make the 2 versions more similar though so it is less confusing [00:01:52] (03PS1) 10Catrope: Followup db0dd687: fix JS error on save [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127834 [00:03:31] (03CR) 10JGonera: [C: 032] Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [00:03:41] kaldari, yeah, we could [00:04:03] 4MobileFrontend 3stable: Watchstar flickers - 10https://bugzilla.wikimedia.org/64083#c2 (10Jon) 5NEW>3PAT Fixed by https://gerrit.wikimedia.org/r/#/c/127800/ [00:04:15] (03Merged) 10jenkins-bot: Story 1922: Promote last modified at top to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127197 (owner: 10Kaldari) [00:06:20] (03CR) 10JGonera: [C: 032] Fixing icons in editor switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127830 (owner: 10Kaldari) [00:06:50] (03Merged) 10jenkins-bot: Fixing icons in editor switcher [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127830 (owner: 10Kaldari) [00:07:03] 4MobileFrontend 3alpha: Editor switcher icons are incorrect in wikitext editor - 10https://bugzilla.wikimedia.org/64106#c3 (10Gerrit Notification Bot) Change 127830 merged by jenkins-bot: Fixing icons in editor switcher https://gerrit.wikimedia.org/r/127830 [00:07:04] (03CR) 10JGonera: [C: 032] Followup db0dd687: fix JS error on save [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127834 (owner: 10Catrope) [00:07:36] (03Merged) 10jenkins-bot: Followup db0dd687: fix JS error on save [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127834 (owner: 10Catrope) [00:08:12] jgonera: Is https://gerrit.wikimedia.org/r/#/c/126038/3 OK to merge. It says you discussed with Jon in person so I assume you reached agreement? [00:09:09] kaldari, yeah, if it works, it's fine [00:09:56] jdlrobson, you have to configure your editor to remove trailing whitespace ;) [00:11:21] 4MobileFrontend 3stable: some upload errors reporting undefined/undefined as error text - 10https://bugzilla.wikimedia.org/64213 (10Jon) 3NEW p:3Unprio s:3normal a:3None select * from MobileWebUploads_7967082 where event_action = 'error' and timestamp > 20140401000000 and event_errorText ='undefined/... [00:13:03] 4MobileFrontend 3General/Unknown: File upload token errors - 10https://bugzilla.wikimedia.org/62587#c6 (10Jon) Update: upload/error/badtoken 120 edit/error/badtoken 4 select event_errorText, count(*) from MobileWebUploads_7967082 where event_action = 'error' and timestamp > 20140401000000 group by ev... [00:13:09] (03PS1) 10Catrope: Followup db0dd687: fix JS error on save [extensions/MobileFrontend] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127836 [00:13:17] (03CR) 10Catrope: [C: 032 V: 032] Followup db0dd687: fix JS error on save [extensions/MobileFrontend] (wmf/1.24wmf1) - 10https://gerrit.wikimedia.org/r/127836 (owner: 10Catrope) [00:14:03] 4MobileFrontend 3Feature requests: Special pages missing "Desktop" view link at bottom - 10https://bugzilla.wikimedia.org/56139 (10Jon) 5PAT>3RES/FIX [00:14:09] jgonera: doh new files [00:14:18] 4MobileFrontend 3Feature requests: Make search possible from special pages - 10https://bugzilla.wikimedia.org/51424 (10Jon) 5PAT>3RES/FIX [00:15:33] 4MobileFrontend 3stable: some upload errors reporting undefined/undefined as error text - 10https://bugzilla.wikimedia.org/64213#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1949 [00:17:23] jgonera: whitespace?? where? [00:17:41] jdlrobson, nevermind, fixing it. but just configure it for future ;) [00:17:50] it's new files where it catches me :-/ [00:17:58] give me a pre-commit hook! [00:18:23] (03CR) 10Kaldari: [C: 032] Ensure headings are HTML when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126038 (owner: 10Jdlrobson) [00:18:34] (03PS6) 10JGonera: EventLog profile and history link clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123474 (owner: 10Jdlrobson) [00:18:58] (03CR) 10JGonera: [C: 032] EventLog profile and history link clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123474 (owner: 10Jdlrobson) [00:19:33] (03Merged) 10jenkins-bot: Ensure headings are HTML when needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126038 (owner: 10Jdlrobson) [00:19:49] 4MobileFrontend 3stable: HTML Headings rendered via JavaScript differ from Server side rendering - 10https://bugzilla.wikimedia.org/63017#c5 (10Gerrit Notification Bot) Change 126038 merged by jenkins-bot: Ensure headings are HTML when needed https://gerrit.wikimedia.org/r/126038 [00:19:49] (03Merged) 10jenkins-bot: EventLog profile and history link clicks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/123474 (owner: 10Jdlrobson) [00:34:48] 4MobileFrontend 3stable: HTML Headings rendered via JavaScript differ from Server side rendering - 10https://bugzilla.wikimedia.org/63017 (10Jon) 5PAT>3RES/FIX [00:37:48] 4MobileFrontend 3alpha: Editor switcher icons are incorrect in wikitext editor - 10https://bugzilla.wikimedia.org/64106 (10Jon) 5PAT>3RES/FIX [00:46:06] 4MobileFrontend 3stable: Footer hidden on diff - 10https://bugzilla.wikimedia.org/64108#c2 (10Jon) Not sure how to fix this in long term. Jared ? [00:53:10] (03PS1) 10Jdlrobson: Push new page feed style tweaks to stable for history and watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127845 [01:10:35] 4MobileFrontend 3Hygiene: Avoid CSS rule duplication by using more descriptive classes - 10https://bugzilla.wikimedia.org/64217 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon I tried out csscss [1] and ran it against default CSS /w/load.php?debug=true&lang=en&modules=tablet.styles%7Cmediawiki.ui.button%7Cmo... [01:11:18] 4MobileFrontend 3Hygiene: Avoid CSS rule duplication by using more descriptive classes - 10https://bugzilla.wikimedia.org/64217#c1 (10Jon) Ori this tool might be of interest to you. [02:04:30] (03CR) 10Kaldari: [C: 04-1] Special-case history and diff desktop links (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127794 (owner: 10MaxSem) [02:10:03] 4Wikipedia App 3Generic: [Android] Can't scroll wide tables to the right - 10https://bugzilla.wikimedia.org/64075 (10Andre Klapper) p:5Unprio>3High [02:10:03] 4Wikipedia App 3Generic: [Android] Opening special pages crashes the app - 10https://bugzilla.wikimedia.org/63451 (10Andre Klapper) p:5Unprio>3High [02:10:04] 4Wikipedia App 3History: iOS app: Should have a "clear all" button for browsing history - 10https://bugzilla.wikimedia.org/63970 (10Andre Klapper) p:5Unprio>3High [02:10:18] 4Wikipedia App 3Generic: Some pages appear too wide and contents can't be scrolled left/right correctly - 10https://bugzilla.wikimedia.org/64130 (10Andre Klapper) p:5Unprio>3High [04:32:53] 4MobileFrontend 3Hygiene: Avoid CSS rule duplication by using more descriptive classes - 10https://bugzilla.wikimedia.org/64217#c2 (10Ori Livneh) (In reply to Jon from comment #1) > Ori this tool might be of interest to you. Yes, definitely. How do we get more people to use it? Do you think there's a way th... [07:10:08] 4MobileFrontend 3stable: Footer hidden on diff - 10https://bugzilla.wikimedia.org/64108#c3 (10Jared Zimmerman (WMF)) Should be prioritized on Trello. [11:46:23] yuvipanda? :) [11:46:37] addshore: hmm? [11:46:59] do we have an intellij 13 license? :P [11:47:26] addshore: Reedy has applied for the ultimate. IntelliJ 13 itself is free, I use that version now [11:48:00] ahh! I currently have 12 ultimate and it just asked me to upgrade and get a new licence :) [11:48:05] addshore: aah! [11:50:37] (03CR) 10Siebrand: [C: 04-1] "L10n reviewed. Please slap me if my inline comment is incorrect :)." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127813 (owner: 10Yuvipanda) [11:51:14] (03CR) 10Yuvipanda: Allow people to opt out of EventLogging (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127813 (owner: 10Yuvipanda) [11:52:01] (03PS5) 10Yuvipanda: Allow people to opt out of EventLogging [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127813 [11:52:24] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127813 (owner: 10Yuvipanda) [12:31:16] 404, link broken [12:31:47] ty Steinsplitter [14:33:07] (03PS1) 10Cmcmahon: QA: test needs a Given that visits a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/128460 [14:33:57] (03PS2) 10Cmcmahon: QA: test needs a Given that visits a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/128460 [14:37:57] (03CR) 10Cmcmahon: "The step "I click on "Foo" in the main navigation menu" is a verb, so should always be a When statement not a Given statement." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/128460 (owner: 10Cmcmahon) [15:27:28] hmm, no maxsem [15:36:01] (03CR) 10Jdlrobson: [C: 032] "Beat me to it! Thanks Chris!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/128460 (owner: 10Cmcmahon) [15:36:35] (03Merged) 10jenkins-bot: QA: test needs a Given that visits a page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/128460 (owner: 10Cmcmahon) [15:37:48] (03Restored) 10Yuvipanda: mobileview: return editable status [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [15:38:04] (03PS2) 10Yuvipanda: mobileview: return editable status [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [15:39:48] (03CR) 10Yuvipanda: "@Jdlrobson: We need this to provide an accurate display of wether a page is editable or not by a user. MobileView output is already varied" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [15:40:20] jdlrobson: ^ [15:40:48] So YuviPanda my view is it should be done in a way that is future proof [15:40:58] add the username to the request [15:41:37] hmm, I like that idea too [15:41:42] it just seems to b easing for future trouble [15:41:56] i mean there was a mail this week about caching multimedia api requests [15:42:04] what if we wanted to start caching API requests for page views? [15:42:14] at the moment we theoretically could but that would stop this [15:43:50] jdlrobson: IIRC mobileview is *already* cached for anons [15:43:55] jdlrobson: and uncached for users [15:45:39] $this->getMain()->setCacheMode( 'anon-public-user-private' ); [15:46:10] jdlrobson: either way, I think passing the username is a good idea. let me ammend commit [15:46:29] ok i'm fine with that then i'll switch down to a -1 [15:47:27] (03CR) 10Jdlrobson: [C: 04-1] "Put username in the request - it's more descriptive and wouldn't get in the way of us caching for logged in users at a future date if we w" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [15:51:29] ok better get ready for office! [15:54:41] 4MobileFrontend 3stable: Footer hidden on diff - 10https://bugzilla.wikimedia.org/64108#c4 (10Jon) It's currently down as something we should work. I just need a short term workaround if nothing else (maybe hide the footer?). [16:09:40] MaxSem: hey! [16:13:07] (03CR) 10MaxSem: "Nope, that's not how cache is varied: there's cache mode for every API module which is already set to anon-public-user-private." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [16:28:32] (03CR) 10Yuvipanda: "What Max said. Our Varnish is set to vary on our auth cookie, so most logged in requests don't get served from varnish anyway." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [16:53:22] Howdy, all! [16:54:10] dbrant: greetings and welcome [16:54:13] yuvipanda: --^ [16:55:01] hello dbrant! [16:55:08] dbrant: welcome! [16:55:09] <- excited [16:55:34] thanks! Looking forward to getting crackin. [16:55:34] dbrant: i'm going to leave you in yuvipanda capable hands while i commute into the office [16:55:47] dbrant: :D [16:56:10] dbrant: can you tell me what TZ you are in? [16:56:17] wanted to make sure you morning was going along well before i left [16:56:28] yuvipanda: need anything from me before i sign off ? [16:56:46] tfinc: nah, I'm fine :) [16:56:51] tfinc, roger that; I've been studying the Office Wiki all morning! [16:57:35] yuvipanda: I'm in EST (gmt-4) [16:58:04] dbrant: cool! I'm on IST (+0530) but I'm usually up very late (2AM or so). [16:58:41] dbrant: first time on IRC? [16:59:09] yo dbrant [16:59:20] yuvipanda: I used it about 15 years ago... ;) [16:59:35] Hey MaxSem! [17:00:41] dbrant: hah! [17:00:50] dbrant: I'll get you in on the private staff channel in a little while :) [17:01:19] yuvipanda: great, thanks [17:01:59] dbrant: :) Have you had a chance to play around with the app yet? [17:02:44] dbrant: can you try to join #wikimedia-staff [17:02:45] ? [17:04:58] yuvipanda: I've installed IntelliJ, cloned the repo, and built/installed the app. [17:05:28] yuvipanda: I'll just need some guidance re your workflow with Gerrit; I haven't used it before. [17:06:13] don't forget you can ask us all;) [17:06:44] dbrant: sweet! [17:07:01] dbrant: yeah, gerrit is used by everyone at the WMF so just asking in general is going to get an answer most of the time [17:07:01] OuKB: I would expect nothing less! [17:07:23] dbrant: you should also join #wikimedia-dev. Random mediawiki discussion happens there. Good place to idle in [17:07:56] dbrant: did you sign up for a gerrit account? [17:08:38] yuvipanda: yep, and I've cloned the repo from there (I think) [17:09:17] dbrant: ah sweet! what's your username? I'll get you setup with merge rights [17:09:50] yuvipanda: it's dbrant [17:10:40] dbrant: cool. I guess you have keys and all set up and working (since you were able to clone from it) [17:10:47] dbrant: https://www.mediawiki.org/wiki/Gerrit/Tutorial is a good resource, albeit a bit long winded. [17:11:42] just ry it and ask us if you have problems [17:11:48] yeah [17:13:00] dbrant: hey! [17:14:11] mhurd: hey Monte! glad to be joining you guys [17:14:23] yuvipanda: yes, I followed the tutorial, set up keys, etc. [17:14:41] dbrant: glad we got you! [17:14:43] The only hang-up was installing git-review on my Mac, but I think I've got it [17:14:51] YuviPanda: heya! [17:15:06] dbrant: ah, cool! git-review can be a bit of a pain sometimes, but there are always ways around it :) [17:15:34] dbrant: if you're looking for a small patch to get through Gerrit, https://bugzilla.wikimedia.org/show_bug.cgi?id=63812 sounds small and self contained enough [17:20:40] jdlrobson: ping! Me and MaxSem responded to that patch. Adding it as a query param will have absolutely no differences with our caching infrastructure. [17:21:57] furthermore, that's not how things work [17:22:36] e.g. action=parse also returns stuff depending on user prefs but requires no user parameter [17:23:02] MaxSem: mobileview also returns it. if you set a preferred language variant that is respected [17:23:06] I found that out accidentally [17:23:24] yeah, and that's by design [17:23:27] 4Wikipedia App 3Generic: The search bar shouldn't be covered by the left panel - 10https://bugzilla.wikimedia.org/63812 (10Dmitry Brant) a:3Dmitry Brant [17:25:54] вау, you even take bugs before working on them!:P [17:26:05] inorite! awesome! :D [17:26:09] MaxSem: also note new bugbot :D [17:26:23] lol what's the proper procedure? [17:26:48] dbrant: taking is, but we usually are too lazy for that :) [17:27:08] what panda said [17:27:11] dbrant: ah, so we also use trello to figure out who is working on what at a point so we don't step on each other's toes. [17:27:24] dbrant: https://trello.com/b/8ADlEuVo/mobile-app-sprint-29-android-to-b is this sprint's board. [17:27:36] dbrant: there's a meeting setup on your calendar for us to go through those tomorrow, I think [17:29:22] dbrant: so we'd just move the card from 'to do' to 'doing'. [17:30:10] yuvipanda: I see; I'll need to familiarize myself with that, too [17:30:29] dbrant: yeah. I can add you to the boards if you tell me what your trello account name is. [17:31:16] mhurd: you have +2 rights now! [17:31:38] yuvipanda: it's @dmitrybrant [17:31:55] YuviPanda: yay! i have doubled [17:32:24] mhurd: :) You actually have +2 rights on *all* repos now, except operations. [17:32:43] dbrant: added! [17:32:47] yuvipanda: got it! [17:32:51] dbrant: woo! [17:34:23] dbrant: move the card over to 'doing' and assign it to yourself on trello. should be easy to track. [17:34:58] dbrant: when someone enters a bug in bugzilla, it automatically comes over to the 'doing' column. Discussion, etc happens in bugzilla, but tracking of what state something is in happens on trello. [17:35:26] (03CR) 10Jdlrobson: "Personally regardless of what the cache does now, I think we should be building our API in a future proof way and having a property that g" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [17:36:10] yuvipanda: I assume "assign" means "add member"? [17:36:14] (03CR) 10MaxSem: "It IS already future proof." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [17:36:24] dbrant: ah yes! [17:37:33] (03CR) 10Yuvipanda: "What MaxSem said." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [17:38:22] YuviPanda: oh, andrew said they changed the rt sign-up request email address but the wiki still had the old one. so that ball should be rolling again :) [17:38:31] mhurd: ok! [17:38:42] YuviPanda: you were right about it taking a few days [17:38:56] mhurd: yeah, there's a policy of a '3 day wait' as well, and that's *after* the request is in. [17:39:07] YuviPanda: extra fun :) [17:39:09] mhurd: :) [17:39:22] dbrant: you should also have merge rights now :) [17:39:35] yuvipanda: alright! It will probably take me a little while to study the code before I can contribute meaningfully [17:39:43] dbrant: merge everything [17:39:46] dbrant: sure! take your time! [17:39:54] dbrant: and feel free to ask us questions. [17:40:04] fantastic [17:40:17] dbrant: the code quality is... okay, but not 'great'. And documentation isn't up to where I'd want it to be, so poke me whenever [17:40:33] dbrant: I'll be around for another 2-3 hours on IRC, and then available on email. [17:40:40] yuvipanda: will do :) [17:41:04] dbrant: :) [17:41:11] hey brion! dbrant is here! :) [17:41:18] yayyyy! [17:41:25] Hey brion! [17:41:31] welcome aboard :D [17:41:49] thanks! Yuvi has been showing the ropes [17:42:06] :D [17:42:13] brion: mhurd has +2 on everything now. I got him on the ldap group [17:42:20] ah great [17:42:27] do we know how to set people up on that for future reference? D: [17:42:28] :D [17:42:50] brion: yeah. RT ticket saying 'X is with us, please add him to the wmf ldap group'. I've already gotten dbrant on as well. [17:43:01] heh ok [17:49:08] jgonera: around? [17:49:43] jgonera: take a look at https://gerrit.wikimedia.org/r/#/c/109939/? I'm inclined to merge it, but jdlrobson wanted you to have a look. [17:49:43] yuvipanda, more or less, what's up? [17:49:58] heh vmware is having an “earth day” sale [17:49:59] wtf? [17:50:23] yuvipanda, I'll take a look but not right now, OK? [17:51:23] jgonera: alright! later today would be great :) [17:51:42] sure [17:51:46] jgonera: ty! [17:55:57] yuvipanda: any reason we don't add "gen-external-apklibs" to .gitignore? [17:56:33] dbrant: mostly because I hadn't gotten around to it :) feel free to! [18:10:30] * yuvipanda is going to get food, will brb in about 30m [18:11:28] (03PS1) 10Yurik: Wrapped URL as a mobile link in SpecialMobileLanguages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/128956 [18:12:34] (03PS2) 10Yurik: Wrapped URL as a mobile link in SpecialMobileLanguages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/128956 [18:13:32] (03PS1) 10Dbrant: Added "gen-external-apklibs" to .gitignore. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/128957 [18:31:59] (03CR) 10GWicke: Push new page feed style tweaks to stable for history and watchlist (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127845 (owner: 10Jdlrobson) [18:54:56] * YuviPanda|Fooood is back [18:55:25] dbrant: woo patch! [18:55:46] dbrant: so we have jenkins running some checks on every patch (not running tests yet). you can see the reports at the comment it left on https://gerrit.wikimedia.org/r/#/c/128957/ [18:56:18] YuviPanda: ok; do I need to add a reviewer? [18:56:49] dbrant: you can if you want to. me and brion. there's a tool that automatically adds people as reviewers, let me find it [18:57:34] (03CR) 10Yuvipanda: [C: 032] "woo first patch! :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/128957 (owner: 10Dbrant) [18:57:58] (03Merged) 10jenkins-bot: Added "gen-external-apklibs" to .gitignore. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/128957 (owner: 10Dbrant) [18:58:58] YuviPanda: so, is that pretty much the whole cycle? [18:59:04] dbrant: yeah. [18:59:27] YuviPanda: alright! I might get the hang of this, after all. [18:59:32] dbrant: fairly lightweight. there are comments / reviews, and you can amend the commit as well. [18:59:51] dbrant: :D [19:01:28] jgonera: could you take a look at https://gerrit.wikimedia.org/r/#/c/127845/ [19:01:48] just keen to get the stable push wrapped up for thursday's train [19:01:57] cc awjr and kaldari when he is back [19:04:05] (03CR) 10Jdlrobson: [C: 032] Wrapped URL as a mobile link in SpecialMobileLanguages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/128956 (owner: 10Yurik) [19:04:07] jdlrobson: i think you may have linked the wrong bug? https://gerrit.wikimedia.org/r/#/c/127845/1 [19:05:10] * tfinc smiles as he watches the patch sets fly by  [19:05:29] (03Merged) 10jenkins-bot: Wrapped URL as a mobile link in SpecialMobileLanguages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/128956 (owner: 10Yurik) [19:09:37] dbrant: you should have two mailing list invites sitting in your inbox one for mobile-tech and another for mobile-l [19:10:25] tfinc: got it! thanks [19:10:38] jdlrobson: is this how you're getting to milan? http://seat61.com/BerninaExpress.htm#.U1a-WuZdXys [19:11:47] dbrant: mobile-l is the primary list. For all discussions. mobile-tech is 'administrivia' - standup status, vacation time, planning a meeting, etc. mobile-l is public and open to all (community, volunteers, etc) while mobile-tech is private and team only. [19:17:43] foods! brb [19:18:13] foods is good idea. [19:34:40] (03CR) 10Awjrichards: [C: 04-1] "This patchset does not seem to actually correspond to the bug referenced in the commit message" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127845 (owner: 10Jdlrobson) [19:40:26] 4MobileFrontend 3stable: Do not redirect undo edits to mobile editor - 10https://bugzilla.wikimedia.org/64256#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1950 [19:45:26] 4MobileFrontend 3stable: Message key instead of text is shown for the error message of missing undo support in the mobile editor - 10https://bugzilla.wikimedia.org/64257#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile... [19:54:50] (03CR) 10Jdlrobson: Experimental: Undo button on diff page (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125747 (owner: 10Kaldari) [19:55:22] (03PS2) 10Jdlrobson: Push new page feed style tweaks to stable for history and watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127845 [19:55:54] awjr: looking... [19:57:11] Zürich HB - Firenze S. M. N. Via Milano Centrale Mon, 12.05.14, 09:09 - 14:55 Hour [19:57:15] doesn't say what kind of train :( [19:58:46] well sounds like it is an awesome route ;) [20:11:22] dbrant: I'll be around for another 30m or so before heading off. Do let me know if there's anything I can do to help :) [20:12:33] YuviPanda: i’m just continuing to look through the code. thanks for all the help so far [20:12:44] dbrant: :) cool! [20:18:08] hey brion! CR? [20:25:24] hey violetto! [20:29:06] (03PS5) 10Yuvipanda: Remove white square next to 'log out' icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127680 [20:29:47] (03PS6) 10Yuvipanda: Add EL for CreateAccount Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127810 [20:30:06] (03PS6) 10Yuvipanda: Allow people to opt out of EventLogging [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127813 [20:30:39] dbrant: I've added you as reviewer to a couple of patches. Do take a look when you've the time, and leave comments / merge. [20:30:45] YuviPanda: hey you! [20:30:50] violetto: new icon? [20:31:29] YuviPanda: just saw your trello comment. attaching now [20:31:38] is dmitry here? [20:32:06] violetto: I am! [20:32:21] dbrant: why hello! [20:32:30] nice to have you here [20:33:21] violetto: thanks! glad to be here [20:37:51] (03PS6) 10Jdlrobson: Switch to JsDuck for documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120587 [20:37:53] (03PS1) 10Jdlrobson: Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 [20:38:11] 3MobileFrontend / 3Hygiene: Avoid CSS rule duplication by using more descriptive classes - 10https://bugzilla.wikimedia.org/64217#c3 (10Gerrit Notification Bot) Change 129032 had a related patch set uploaded by Jdlrobson: Create script for checking css rule duplication https://gerrit.wikimedia.org/r/129032 [20:38:11] 3MobileFrontend / 3Hygiene: Avoid CSS rule duplication by using more descriptive classes - 10https://bugzilla.wikimedia.org/64217 (10Gerrit Notification Bot) 5NEW>3PAT [20:38:59] (03CR) 10jenkins-bot: [V: 04-1] Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (owner: 10Jdlrobson) [20:45:57] (03CR) 10Siebrand: "L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127813 (owner: 10Yuvipanda) [20:53:22] jgonera did you work on Compact Personal Bar? the icons in its menu aren't appearing on en-beta, https://bugzilla.wikimedia.org/show_bug.cgi?id=64260 ErikB has a fix to core [20:54:43] spagewmf, weird, they did before. I'll have a look at it [21:05:31] brion: yo [21:08:31] (03CR) 10Dbrant: [C: 031] Remove white square next to 'log out' icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127680 (owner: 10Yuvipanda) [21:08:41] 3Wikipedia App / 3Generic: [Android] Log out has no icon - 10https://bugzilla.wikimedia.org/64078#c2 (10Gerrit Notification Bot) Change 127680 merged by Dbrant: Remove white square next to 'log out' icon https://gerrit.wikimedia.org/r/127680 [21:09:19] dbrant: you should be able to give it +2 to merge it. [21:11:29] YuviPanda: noted [21:13:31] (03CR) 10Dbrant: [C: 032] Add EL for CreateAccount Funnel [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127810 (owner: 10Yuvipanda) [21:16:24] (03CR) 10Dbrant: [C: 032] Allow people to opt out of EventLogging [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127813 (owner: 10Yuvipanda) [21:24:36] tfinc: yo [21:25:00] brion: i didn't see an email go through about the app saved pages migration, did you send it out ? [21:25:17] not yet [21:26:08] lemme grab my notes [21:35:20] (03PS1) 10Jdlrobson: Hygiene: Ensure bridge css never makes it on to Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129043 [21:35:47] jgonera: https://gerrit.wikimedia.org/r/127845 [21:36:13] tfinc: note sent to mobile-l [21:36:51] (03PS2) 10MaxSem: Special-case history and diff desktop links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127794 [21:37:26] (03CR) 10jenkins-bot: [V: 04-1] Special-case history and diff desktop links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127794 (owner: 10MaxSem) [21:45:33] (03PS3) 10MaxSem: Special-case history and diff desktop links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127794 [21:46:10] (03CR) 10jenkins-bot: [V: 04-1] Special-case history and diff desktop links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127794 (owner: 10MaxSem) [21:46:25] fuck you jerkins [21:47:05] heh jerkins [21:47:07] doh [21:49:18] (03PS4) 10MaxSem: Special-case history and diff desktop links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127794 [21:51:39] violetto: I added the icon :) [21:51:50] violetto: but now, I need two variants - one saying 'alpha' and one saying 'beta' [21:52:55] (03CR) 10JGonera: [C: 04-1] "One more question: what does it return for anonymous users? Because if the value depends on IP and we serve everything from cache for anon" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [21:53:43] (03CR) 10Yuvipanda: "All anon users are treated exactly the same and have exactly the same rights, so for anons this won't break cache." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [21:53:49] jgonera: responded. [21:54:25] YuviPanda, so it doesn't check for blocked IPs? [21:54:34] OuKB: ^ [21:56:00] hmm, waitasec... [21:57:18] (03PS1) 10Yuvipanda: Add new app icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129046 [21:57:26] dbrant: CR? ^ [21:57:26] 3Wikipedia App / 3Generic: App Icon Should be 'W' not generic Android icon - 10https://bugzilla.wikimedia.org/61259#c1 (10Gerrit Notification Bot) Change 129046 had a related patch set uploaded by Yuvipanda: Add new app icon https://gerrit.wikimedia.org/r/129046 [21:57:41] 3Wikipedia App / 3Generic: App Icon Should be 'W' not generic Android icon - 10https://bugzilla.wikimedia.org/61259 (10Gerrit Notification Bot) 5NEW>3PAT [21:59:04] (03PS3) 10Yuvipanda: Update remote config URL to stable production version [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127679 [21:59:23] (03PS4) 10Yuvipanda: Update remote config URL to stable production version [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127679 [21:59:29] brion: ^ [21:59:35] the URL works now [21:59:37] \o/ [21:59:46] (03CR) 10Dbrant: [C: 032] Add new app icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129046 (owner: 10Yuvipanda) [21:59:55] (03CR) 10Brion VIBBER: [C: 032 V: 032] Update remote config URL to stable production version [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/127679 (owner: 10Yuvipanda) [22:00:07] coool! [22:00:24] dbrant: we use the google play alpha release feature for alpha testing. I'm going to make a build now and update. [22:00:51] dbrant: we don't have a way to get the signing keys to you yet, but I think you'll be in the SF office at some point in the near future and can pick up the keys there :) [22:01:47] YuviPanda: sounds good [22:01:52] dbrant: :) [22:02:24] violetto: the new icon looks terrible on history page, and all pages in the action bar. [22:02:32] violetto: rather, it's terrible on all white backgrounds [22:02:49] violetto: my screenshot feature seems broken :( Not sure how to show it [22:03:31] do we need a separate icon for the actionbar then? [22:03:41] (03CR) 10JGonera: [C: 032] Push new page feed style tweaks to stable for history and watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127845 (owner: 10Jdlrobson) [22:03:49] brion: yeah, probably [22:03:54] Take a pic with your laptop cam YuviPanda [22:03:55] (03CR) 10JGonera: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127845 (owner: 10Jdlrobson) [22:04:04] violetto: hehe :D let me figure something out [22:04:15] (03Merged) 10jenkins-bot: Push new page feed style tweaks to stable for history and watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127845 (owner: 10Jdlrobson) [22:04:26] YuviPanda: ok! [22:04:26] 3MobileFrontend / 3stable: Wrong user icons in watchlist and page history - 10https://bugzilla.wikimedia.org/64202#c3 (10Gerrit Notification Bot) Change 127845 merged by jenkins-bot: Push new page feed style tweaks to stable for history and watchlist https://gerrit.wikimedia.org/r/127845 [22:04:33] YuviPanda: asm? ddms? [22:04:58] * brion starts spouting random letters in the hopes they help [22:05:13] brion: yeah, asm [22:06:13] 3Wikipedia App / 3Generic: New icon looks wobbly on light backgrounds - 10https://bugzilla.wikimedia.org/64263 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None Created attachment 15168 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15168&action=edit Screenshot of icon in actionbar Such as the... [22:06:29] violetto: https://bugzilla.wikimedia.org/show_bug.cgi?id=64263 [22:06:41] 3Wikipedia App / 3Generic: New icon looks wobbly on light backgrounds - 10https://bugzilla.wikimedia.org/64263#c1 (10Yuvi Panda) Created attachment 15169 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15169&action=edit Screenshot of icon in recently used lists [22:11:24] awjr: btw, wikibugs is now in python, rewritten, and running on toollabs. It has available, as a redis channel, almost-realtime stream of parsed bug reports coming in. You could potentially switch bugello / bingle to that at some point [22:11:35] awjr: https://github.com/valhallasw/pywikibugs is the code [22:11:45] very cool YuviPanda [22:11:59] awjr: yeah, so you could move comments, etc very easily [22:12:38] YuviPanda: I'll fix it. Does a single svg file works or do you need them in multiple size pngs as well [22:12:46] Latter is abit time consuming [22:12:52] oh goodie, it’s time to update to ios 7.1.1 [22:12:54] violetto: nah, android svg is fine. [22:13:02] that's pretty slick YuviPanda - the whole thing is based off emails from bz? [22:13:08] awjr: yup. [22:13:19] awjr: it subscribes to the bugmail, and as soon as it hits it is put into redis [22:13:21] awjr: and then parsed. [22:13:34] violetto: just make sure the aspect ratios are fine and we're good. [22:13:42] violetto: I've a script that automatically makes pngs :) [22:14:32] (03PS1) 10Yuvipanda: Actually change the app icon to the new one [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129051 [22:14:55] YuviPanda: mhurd violetto https://twitter.com/JoeNintendoe/status/458730584379228160 [22:15:26] 3MobileFrontend / 3stable: Wrong user icons in watchlist and page history - 10https://bugzilla.wikimedia.org/64202 (10Jon) 5PAT>3RES/FIX [22:15:43] jdlrobson: 404? [22:16:00] https://twitter.com/JoeApplecake/status/458730739371356161 [22:16:05] think he must have edited [22:16:18] YuviPanda: ok. Benny is helping me set up gerrit, brb [22:16:25] violetto: woot! [22:17:40] jdlrobson: ty! I've responded [22:19:13] (03PS1) 10Yuvipanda: Make convert-icons.py script Python 3.0 compatible [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129052 [22:23:16] (03PS1) 10Yuvipanda: Provide appropriate padding for login benefits message [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129053 [22:24:49] (03PS2) 10Yuvipanda: Add new app icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129046 [22:25:29] (03PS2) 10Yuvipanda: Provide appropriate padding for login benefits message [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129053 [22:25:31] (03PS2) 10Yuvipanda: Make convert-icons.py script Python 3.0 compatible [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129052 [22:25:33] (03PS3) 10Yuvipanda: Add new app icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129046 [22:25:40] (03Abandoned) 10Yuvipanda: Actually change the app icon to the new one [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129051 (owner: 10Yuvipanda) [22:26:26] (03CR) 10Yuvipanda: [C: 032] "Carry over from previous patchset (which didn't merge because of rebase issues)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129046 (owner: 10Yuvipanda) [22:26:43] (03Merged) 10jenkins-bot: Add new app icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129046 (owner: 10Yuvipanda) [22:26:46] (03PS3) 10MaxSem: mobileview: return editable status [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 [22:26:56] 3Wikipedia App / 3Generic: App Icon Should be 'W' not generic Android icon - 10https://bugzilla.wikimedia.org/61259#c2 (10Gerrit Notification Bot) Change 129046 merged by jenkins-bot: Add new app icon https://gerrit.wikimedia.org/r/129046 [22:27:48] (03PS1) 10Yuvipanda: Bump version for new alpha release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129054 [22:29:36] (03CR) 10Yuvipanda: mobileview: return editable status (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [22:30:31] dbrant: brion another couple of patches before I make the build. small ones. [22:31:04] dbrant: so all code needs to be merged by someone other than you. No self merging, except for super trivial stuff (missing comma in a doc string, version bumps, etc) [22:31:53] YuviPanda: right [22:33:41] (03CR) 10Dbrant: [V: 032] Provide appropriate padding for login benefits message [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129053 (owner: 10Yuvipanda) [22:34:10] dbrant: so V+2 is set by the bot after running automated tests / checks. After CR you should set C+2 :) [22:34:23] YuviPanda: yep, that was accidental [22:34:29] dbrant: ah, ok! [22:35:46] (03CR) 10Dbrant: [C: 032] Make convert-icons.py script Python 3.0 compatible [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129052 (owner: 10Yuvipanda) [22:38:17] (03PS4) 10MaxSem: mobileview: return editable status [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 [22:38:19] (03CR) 10Dbrant: [C: 032] Provide appropriate padding for login benefits message [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129053 (owner: 10Yuvipanda) [22:42:20] (03CR) 10Yuvipanda: [C: 032] Bump version for new alpha release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129054 (owner: 10Yuvipanda) [22:42:39] (03Merged) 10jenkins-bot: Bump version for new alpha release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129054 (owner: 10Yuvipanda) [22:47:21] (03PS3) 10MaxSem: Improve diff detection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127344 [22:51:07] jgonera_, https://en.wikipedia.org/wiki/User:MaxSem/common.js [22:51:36] jgonera_: any objections to merging the canedit API patch now? [22:52:16] violetto: \o/ test commit! [22:55:26] (03CR) 10JGonera: [C: 04-1] "Not sure about that. So we're basically lying for anon users by using 127.0.0.1 for all of them? Seems hacky..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [23:00:36] (03CR) 10Yuvipanda: "For anons this will check protection and report correctly, but will report block wrong. Perhaps we can find a way to not count block at al" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [23:01:32] jdlrobson: https://twitter.com/JoeApplecake/status/458736796722294784 :) [23:05:40] (03PS1) 10Jdlrobson: Hygiene: Clean up profile page dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129064 [23:05:43] 3MobileFrontend / 3beta: Buttons don't have mediawiki ui styling in beta and alpha - 10https://bugzilla.wikimedia.org/64264 (10Kaity Hammerstein) 3NEW p:3Unprio s:3normal a:3None Created attachment 15170 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15170&action=edit button is too rounded, t... [23:05:59] brion: dbrant|away tfinc mhurd off to sleep. night! [23:06:08] tfinc: I pushed out another alpha build :) [23:06:44] violetto: we currently have 42 testers and we didn't push much anywhere. Once we get the icons in plase I'll push a little wider for alpha testers so we get at least a 100 or so [23:07:01] ok off for real now [23:07:28] (03PS4) 10Jdlrobson: Improve diff detection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127344 (owner: 10MaxSem) [23:07:41] 3MobileFrontend / 3stable: No mobile diff redirect - 10https://bugzilla.wikimedia.org/63999#c3 (10Gerrit Notification Bot) Change 127344 had a related patch set uploaded by Jdlrobson: Improve diff detection https://gerrit.wikimedia.org/r/127344 [23:08:34] (03CR) 10Jdlrobson: [C: 032] Improve diff detection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127344 (owner: 10MaxSem) [23:10:26] 3MobileFrontend / 3beta: Buttons don't have mediawiki ui styling in beta and alpha - 10https://bugzilla.wikimedia.org/64264#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1952 [23:12:15] (03Merged) 10jenkins-bot: Improve diff detection [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127344 (owner: 10MaxSem) [23:12:26] 3MobileFrontend / 3stable: No mobile diff redirect - 10https://bugzilla.wikimedia.org/63999#c4 (10Gerrit Notification Bot) Change 127344 merged by jenkins-bot: Improve diff detection https://gerrit.wikimedia.org/r/127344 [23:13:16] (03PS1) 10Jdlrobson: Regression: Push history back to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129069 [23:14:41] 3MobileFrontend / 3stable: No mobile diff redirect - 10https://bugzilla.wikimedia.org/63999 (10Max Semenik) 5PAT>3RES/FIX [23:15:43] 3MobileFrontend / 3beta: Main page "this page needs help" typography is incorrect - 10https://bugzilla.wikimedia.org/64265 (10Kaity Hammerstein) 3NEW p:3Unprio s:3normal a:3None Created attachment 15171 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15171&action=edit current screenshot The m... [23:16:41] 3MobileFrontend / 3beta: Main page "this page needs help" typography is incorrect - 10https://bugzilla.wikimedia.org/64265#c1 (10Kaity Hammerstein) Created attachment 15172 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15172&action=edit original design [23:18:50] (03CR) 10Jdlrobson: [C: 032] Special-case history and diff desktop links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127794 (owner: 10MaxSem) [23:19:31] (03Merged) 10jenkins-bot: Special-case history and diff desktop links [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127794 (owner: 10MaxSem) [23:19:41] 3MobileFrontend / 3beta: Mobile history desktop link doesn't point to right place - 10https://bugzilla.wikimedia.org/64112#c3 (10Gerrit Notification Bot) Change 127794 merged by jenkins-bot: Special-case history and diff desktop links https://gerrit.wikimedia.org/r/127794 [23:20:26] 3MobileFrontend / 3beta: Main page "this page needs help" typography is incorrect - 10https://bugzilla.wikimedia.org/64265#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1953 [23:21:56] 3MobileFrontend / 3beta: Mobile history desktop link doesn't point to right place - 10https://bugzilla.wikimedia.org/64112 (10Jon) 5PAT>3RES/FIX [23:23:36] (03CR) 10MaxSem: [C: 032] Hygiene: Clean up profile page dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129064 (owner: 10Jdlrobson) [23:24:14] (03CR) 10MaxSem: [C: 032] Regression: Push history back to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129069 (owner: 10Jdlrobson) [23:26:21] (03Merged) 10jenkins-bot: Hygiene: Clean up profile page dead code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129064 (owner: 10Jdlrobson) [23:26:23] (03Merged) 10jenkins-bot: Regression: Push history back to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129069 (owner: 10Jdlrobson) [23:27:48] (03CR) 10MaxSem: [C: 04-1] "This would break Nearby on non-Vector skins." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129043 (owner: 10Jdlrobson) [23:28:16] OuKB: lies [23:28:23] rly> [23:28:25] ? [23:28:36] the mobile bridge is specifically for Nearby pages beta feature [23:28:39] try it [23:28:50] (which is only enabled on vector skin) [23:29:12] well, have you tried navigating to nearby in monobook? [23:31:07] (03CR) 10MaxSem: [C: 032] Hygiene: Ensure bridge css never makes it on to Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129043 (owner: 10Jdlrobson) [23:31:48] (03Merged) 10jenkins-bot: Hygiene: Ensure bridge css never makes it on to Minerva skin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129043 (owner: 10Jdlrobson) [23:38:18] brion: hey any thoughts on hiding status bar just during the editing workflow? [23:42:00] (03CR) 10MaxSem: Create script for checking css rule duplication (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (owner: 10Jdlrobson) [23:44:01] (03CR) 10MaxSem: [C: 032] "Let's just merge this and fix stuff in followups. Rebasing this must be a huge pain." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120587 (owner: 10Jdlrobson) [23:44:50] (03Merged) 10jenkins-bot: Switch to JsDuck for documentation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/120587 (owner: 10Jdlrobson) [23:51:43] OuKB, what flag do I need to set to enable common.js on my local wiki? [23:52:37] jgonera, $wgAllowUserJs && $wgAllowUserCss