[00:09:01] jdlrobson: just saw your email about special:contributions - do we need a lightning deploy? [00:09:14] awjr: no it got caught before the train [00:09:20] hence the urgency but max has merged it so we are good [00:09:28] great [00:09:38] thanks for catching and fixing! [00:16:58] 3MobileFrontend / 3beta: Talk broken on pages which don't have talk pages - 10https://bugzilla.wikimedia.org/64268 (10Jon) 3NEW p:3Unprio s:3normal a:3None Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Forty-seven_Roninsasasassa?mobileaction=beta Click talk See infinite ajax loader. Uncaught Ty... [00:20:26] 3MobileFrontend / 3beta: Talk broken on pages which don't have talk pages - 10https://bugzilla.wikimedia.org/64268#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1954 [00:25:43] 3MobileFrontend / 3Hygiene: Rewrite ImageOverlay to use OverlayNew - 10https://bugzilla.wikimedia.org/64269 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon Rewrite existing overlays to use OverlayNew [00:29:12] (03PS1) 10Jdlrobson: Hygiene: Rewrite ContentOverlay as child of OverlayNew, kill LoadingOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129083 [00:29:40] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Rewrite ContentOverlay as child of OverlayNew, kill LoadingOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129083 (owner: 10Jdlrobson) [00:29:56] 3MobileFrontend / 3Hygiene: Rewrite ImageOverlay to use OverlayNew - 10https://bugzilla.wikimedia.org/64269#c1 (10Jon) This is the only overlay to use the old code given https://gerrit.wikimedia.org/r/129083 is merged. [00:30:28] (03PS2) 10Jdlrobson: Hygiene: Rewrite ContentOverlay as child of OverlayNew, kill LoadingOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129083 [00:46:24] (03PS2) 10Jdlrobson: Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 [00:46:26] (03PS1) 10Jdlrobson: Hygiene: Introduce is-border-box class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129084 [00:46:28] (03PS1) 10Jdlrobson: Hygiene: Standardise on our icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [00:47:09] (03CR) 10Jdlrobson: [C: 04-2] "Breaks media viewer - see https://bugzilla.wikimedia.org/show_bug.cgi?id=64269" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [00:47:42] (03CR) 10jenkins-bot: [V: 04-1] Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (owner: 10Jdlrobson) [00:48:28] 3MobileFrontend / 3stable: MediaViewer doesn't use LoadingOverlay - 10https://bugzilla.wikimedia.org/64271 (10Jon) 3NEW p:3Unprio s:3normal a:3None Clicking on an image doesn't instantly show an overlay or a spinner so it is not clear that anything has happened. [00:48:48] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Standardise on our icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [00:50:26] 3MobileFrontend / 3stable: MediaViewer doesn't use LoadingOverlay - 10https://bugzilla.wikimedia.org/64271#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1955 [00:50:48] (03PS2) 10Jdlrobson: Hygiene: Introduce is-border-box class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129084 [00:51:49] (03PS2) 10Jdlrobson: Hygiene: Standardise on our icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [00:52:39] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Standardise on our icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [01:13:56] 3MobileFrontend / 3stable: Do not redirect undo edits to mobile editor - 10https://bugzilla.wikimedia.org/64256#c2 (10Jon) 5NEW>3RES/WON There is no editor on the mobile site that supports undo. Redirecting to desktop would be an experience we should avoid. Undo for mobile is planned. Let's do that inst... [06:18:28] 3MobileFrontend / 3Feature requests: configuration variable to turn on or off particular footer links (both on desktop and mobile) - 10https://bugzilla.wikimedia.org/64275 (10Dan Jacobson) 3NEW p:3Unprio s:3normal a:3None On my wiki there are two links in the Mobile menu, about and disclaimers. I do... [06:20:26] 3MobileFrontend / 3Feature requests: configuration variable to turn on or off particular footer links (both on desktop and mobile) - 10https://bugzilla.wikimedia.org/64275#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobi... [06:20:41] 3MobileFrontend / 3Feature requests: Obey meaning of single "-" in MediaWiki:Privacy just as in desktop - 10https://bugzilla.wikimedia.org/63414#c6 (10Dan Jacobson) OK made bug 64275. [07:39:26] 3Wikipedia App / 3Generic: New icon looks wobbly on light backgrounds - 10https://bugzilla.wikimedia.org/64263#c2 (10May Tee-Galloway) Created attachment 15175 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15175&action=edit App launch icon This should fix it [08:19:56] 3MobileFrontend / 3stable: Do not redirect undo edits to mobile editor - 10https://bugzilla.wikimedia.org/64256#c3 (10Liangent) (In reply to Jon from comment #2) > There is no editor on the mobile site that supports undo. Redirecting to > desktop would be an experience we should avoid. > > Undo for mobile i... [09:04:38] hi YuviPanda [09:04:43] hi matanya! [09:05:00] got my crash report? [09:07:20] matanya: uh, no. when did you send it? [09:07:27] last night [09:07:51] and you must change the crash report message it is confusing [09:10:54] matanya: yeah, I should [09:10:59] matanya: hmm, OTRS seems to be eating these :| [09:13:47] matanya: I don't see it in OTRS :| [09:18:27] 3MobileFrontend / 3Feature requests: Mobile watchlist just says "Anonymous", doesn't show IP address in overview - 10https://bugzilla.wikimedia.org/56812#c7 (10CapnZapp) Hi, Completely new to mobile wiki editing and this site. Was baffled by the decision to not show the ip numbers of anonymous edits, and... [09:20:34] YuviPanda: was sent to mobile-adroid-wikipedia@wikimedia.org [09:20:45] matanya: adroid? [09:20:54] *an [09:21:21] hmm, now to look through spam [09:21:43] it was sent from see pm [09:22:27] matanya: yeah, searcihing [09:24:08] matanya: I see those when I search for it. [09:24:14] matanya: ' USER_COMMENT=searched for user talk page' [09:24:15] right? [09:24:19] yes [09:24:23] that one [09:26:04] matanya: hmm, so I don't see it in the queue but searching for it lets me see it [09:26:15] matanya: it's in 'Junk' [09:26:28] shame on OTRS [09:27:03] matanya: heh [09:28:44] matanya: ah, so that's a known bug, scheduled to be fixed today or tomorrow [09:28:57] matanya: happens when you try to open an article that does not exist [09:28:57] ok, thank you [09:29:11] matanya: https://bugzilla.wikimedia.org/62639 [09:34:24] thanks, i'll pull the next release when it is out [09:39:15] matanya: :) [09:39:29] matanya: I pushed one out earlier today. It doesn't have a fix for this but you should upgrade anyway [09:39:46] is it in releases.w.o? [09:40:53] matanya: ah, no. [09:41:04] matanya: let me email that to you atm. I'm writing a 'release script' that does those things [09:41:19] thanks for that too :) [10:09:11] 3Wikipedia App / 3Generic: New icon looks wobbly on light backgrounds - 10https://bugzilla.wikimedia.org/64263#c3 (10Yuvi Panda) Created attachment 15178 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15178&action=edit Screenshot of icon in actionbar [10:15:14] 3Wikipedia App / 3Generic: Editing a section newly added from another device crashes the app - 10https://bugzilla.wikimedia.org/64282 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Repro: 1. Create a page with section 0 only 2. Open it in the app 3. Add a new section to that page on computer 4. Null... [10:15:41] 3Wikipedia App / 3Generic: New icon looks wobbly on light backgrounds - 10https://bugzilla.wikimedia.org/64263#c4 (10Yuvi Panda) Created attachment 15179 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15179&action=edit Screenshot of icon in intent chooser [10:16:11] 3Wikipedia App / 3Generic: New icon looks wobbly on light backgrounds - 10https://bugzilla.wikimedia.org/64263#c5 (10Yuvi Panda) Better but still very patchy looking. For the actionbars we can perhaps just get rid of the background, be consistent with the main page. Only need to fix for intent chooser. [10:17:17] (03PS1) 10Yuvipanda: Update launcher icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129137 [10:27:37] YuviPanda: installed, now testing [10:30:44] matanya: woot! [11:04:10] (03PS1) 10Zfilipin: Updated Ruby gems [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/129144 [11:10:22] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/46714 (owner: 10Hashar) [11:10:34] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/46714 [11:10:39] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/46714 (owner: 10Hashar) [11:16:22] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/46714 (owner: 10Hashar) [11:25:20] (03PS1) 10Yuvipanda: Bump version for release 2.0-alpha-2014-04-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129150 [14:33:38] good morning dbrant! [14:33:59] hello! [14:36:49] * YuviPanda waves at dbrant [14:37:55] YuviPanda: what's up! [14:38:11] dbrant: had a nice evening nap, just woke up :) Writing a script to automate our release process now. [14:38:16] dbrant: how's your day been? [14:39:08] YuviPanda: alright; just completing more HR paperwork [14:44:43] dbrant: ah! ok! [15:12:43] Reedy: any news from JetBrains? [15:14:16] Nope [15:14:50] Reedy: ok! [15:50:36] (03PS1) 10Jdlrobson: QA: Restore correct Gemfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129193 [15:51:56] (03PS3) 10Jdlrobson: Hygiene: Standardise on our icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [15:51:58] (03PS3) 10Jdlrobson: Hygiene: Introduce is-border-box class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129084 [15:52:00] (03PS3) 10Jdlrobson: Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 [15:52:02] (03PS3) 10Jdlrobson: Hygiene: Rewrite things as Overlaynew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129083 [15:52:04] (03PS1) 10Jdlrobson: CSS Regression: Restore blue tutorial button in beta/alpha Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129194 [15:52:06] (03PS1) 10Jdlrobson: Rewrite MediaViewer as OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129195 [15:52:08] (03PS1) 10Jdlrobson: Hygiene: Merge Overlay and OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129196 [15:52:10] (03PS1) 10Jdlrobson: Hygiene: Cleanup blockquote rules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129197 [15:52:11] 3MobileFrontend / 3stable: MediaViewer doesn't use LoadingOverlay - 10https://bugzilla.wikimedia.org/64271 (10Gerrit Notification Bot) 5NEW>3PAT [15:52:11] 3MobileFrontend / 3Hygiene: Rewrite ImageOverlay to use OverlayNew - 10https://bugzilla.wikimedia.org/64269 (10Gerrit Notification Bot) 5NEW>3PAT [15:52:12] (03PS1) 10Jdlrobson: Hygiene: Introduce cloaked-element class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129198 [15:52:12] 3MobileFrontend / 3stable: MediaViewer doesn't use LoadingOverlay - 10https://bugzilla.wikimedia.org/64271#c2 (10Gerrit Notification Bot) Change 129195 had a related patch set uploaded by Jdlrobson: Rewrite MediaViewer as OverlayNew https://gerrit.wikimedia.org/r/129195 [15:52:13] 3MobileFrontend / 3Hygiene: Rewrite ImageOverlay to use OverlayNew - 10https://bugzilla.wikimedia.org/64269#c2 (10Gerrit Notification Bot) Change 129195 had a related patch set uploaded by Jdlrobson: Rewrite MediaViewer as OverlayNew https://gerrit.wikimedia.org/r/129195 [15:52:38] (03PS2) 10Jdlrobson: Hygiene: Cleanup blockquote rules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129197 [15:53:14] (03CR) 10jenkins-bot: [V: 04-1] Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (owner: 10Jdlrobson) [15:53:26] (03PS1) 10Yuvipanda: Bump version for release 2.0-alpha-2014-04-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129199 [15:53:39] (03CR) 10Jdlrobson: [C: 04-2] "WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (owner: 10Jdlrobson) [16:10:30] (03Abandoned) 10Yuvipanda: Bump version for release 2.0-alpha-2014-04-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129150 (owner: 10Yuvipanda) [16:10:34] (03Abandoned) 10Yuvipanda: Bump version for release 2.0-alpha-2014-04-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129199 (owner: 10Yuvipanda) [16:13:22] (03PS1) 10Yuvipanda: Bump version for release 2.0-alpha-2014-04-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129201 [16:17:28] (03PS1) 10Yuvipanda: Bump version for release 2.0-alpha-2014-04-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129202 [16:19:39] (03PS1) 10Yuvipanda: Bump version for release 2.0-alpha-2014-04-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129203 [16:19:41] (03PS1) 10Yuvipanda: Adds script that makes it easier to make a release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129204 [16:19:43] (03CR) 10jenkins-bot: [V: 04-1] Bump version for release 2.0-alpha-2014-04-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129203 (owner: 10Yuvipanda) [16:19:54] (03Abandoned) 10Yuvipanda: Bump version for release 2.0-alpha-2014-04-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129201 (owner: 10Yuvipanda) [16:20:08] (03Abandoned) 10Yuvipanda: Bump version for release 2.0-alpha-2014-04-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129202 (owner: 10Yuvipanda) [16:20:33] (03PS2) 10Yuvipanda: Adds script that makes it easier to make a release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129204 [16:20:35] (03Abandoned) 10Yuvipanda: Bump version for release 2.0-alpha-2014-04-23 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129203 (owner: 10Yuvipanda) [16:41:08] hey brion! [16:41:13] yo yo [16:41:30] (03CR) 10Kaldari: [C: 04-1] Hygiene: Introduce cloaked-element class (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129198 (owner: 10Jdlrobson) [16:41:32] brion: I made a script that does releases! [16:42:00] \o/ [16:42:06] soon we will have no more need for hu-mans [16:42:49] (03CR) 10Yuvipanda: "I also do not think that having the username be a query param will help in this particular situation - since it will require that the clie" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [16:43:00] brion: heh. [16:48:26] 3MobileFrontend / 3Feature requests: Mobile watchlist just says "Anonymous", doesn't show IP address in overview - 10https://bugzilla.wikimedia.org/56812#c8 (10Jon) @CapnZapp the original rationale can be found in comment 3 (#c3) This has been revisited recently and is now shown as to editors it /is/ import... [16:54:12] (03CR) 10Kaldari: [C: 032] CSS Regression: Restore blue tutorial button in beta/alpha Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129194 (owner: 10Jdlrobson) [16:54:45] (03Merged) 10jenkins-bot: CSS Regression: Restore blue tutorial button in beta/alpha Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129194 (owner: 10Jdlrobson) [16:55:11] 3MobileFrontend / 3stable: Do not redirect undo edits to mobile editor - 10https://bugzilla.wikimedia.org/64256#c4 (10Jon) I'm confused... are you visiting the desktop site and finding yourself being redirected to mobile? If so this sounds like another bug - once you are in desktop skin you should never be r... [17:16:46] “Your profile can not be used because it is from a newer version of Google Chrome.” [17:16:47] whaaaaaa [17:17:39] YuviPanda: poke poke [17:17:42] standup time [17:18:02] brion: yeah, on the way. loading terribly it is [17:19:01] awjr: chrismcmahon jgonera kaldari can one of you merge https://gerrit.wikimedia.org/r/129193 asap so we can check state of browser tests? [17:20:43] (03CR) 10Cmcmahon: [C: 032] QA: Restore correct Gemfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129193 (owner: 10Jdlrobson) [17:21:13] (03Merged) 10jenkins-bot: QA: Restore correct Gemfile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129193 (owner: 10Jdlrobson) [17:21:38] thanks chrismcmahon [17:21:56] jgonera: awjr kaldari so thoughts about working off a branch other than master until thursday to avoid breaking existing functionality? [17:22:45] MaxSem too ^ [17:23:06] jdlrobson: can you explain your thoughts/motivations again? [17:25:14] email? [17:25:56] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129196 (owner: 10Jdlrobson) [17:27:11] 3Wikipedia App / 3Generic: Handle Edit Conflicts on the Mobile App in some way - 10https://bugzilla.wikimedia.org/64281 (10Yuvi Panda) [17:28:05] hey MaxSem! [17:28:17] yo YuviPanda [17:28:29] awjr: so basically I'm working on some big refactorings [17:28:33] and i don't want to break things [17:28:46] but i want to get these big changes merged sooner rather than later [17:28:56] 3Wikipedia App / 3Generic: Handle Edit Conflicts on the Mobile App in some way - 10https://bugzilla.wikimedia.org/64281#c1 (10Yuvi Panda) Currently we just ignore Edit Conflicts and just overwrite the conflicting edit. This is 'bad' and we should get to have some way of both: 1. Letting the user know that a... [17:29:12] jdlrobson: what's the deal with the branch? The audio was choppy when you mentioned it on the hangout [17:31:36] kaldari: ^ [17:32:00] ? [17:32:16] ah [17:32:46] dbrant: welcome to day 2 [17:32:52] kaldari: when are you coming back to SF ? [17:33:02] tfinc: this weekend [17:33:11] so I'll be back on Monday [17:33:20] * YuviPanda is still in Mumbai by the sea [17:33:40] tfinc: thanks! having my HR hangout now [17:34:39] jdlrobson: I'm fine with that. How long do you think we would be working on the non-master branch? [17:34:44] YuviPanda: joining me on hangout ? [17:34:49] i almost melted flying through mumbai… and that was at like midnight in november [17:35:14] tfinc: oh damn, yes [17:35:20] tfinc: moment [17:35:42] kaldari: just until Thursday morning [17:35:44] so today [17:35:53] (03PS4) 10Jdlrobson: Hygiene: Standardise on our icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [17:35:55] (03PS2) 10Jdlrobson: Hygiene: Introduce cloaked-element class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129198 [17:38:34] (03CR) 10Kaldari: [C: 04-1] Hygiene: Introduce cloaked-element class (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129198 (owner: 10Jdlrobson) [17:41:56] 3MobileFrontend / 3stable: Do not redirect undo edits to mobile editor - 10https://bugzilla.wikimedia.org/64256#c5 (10Liangent) Step 1: Go to a page in mobile Step 2: Click history ("last edited" link) Step 3: Click an undo link It now says "unsupported". [17:43:37] (03PS1) 10Jdlrobson: Fix style guide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129209 [17:44:26] 3MobileFrontend / 3stable: Do not redirect undo edits to mobile editor - 10https://bugzilla.wikimedia.org/64256#c6 (10Jon) The history link is going to be mobile optimised in a week. There will be no undo action at first launch on this history page. See http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:His... [17:44:58] kaldari: so how would this work? [17:46:25] you can create a separate branch through gerrit, and then you have to check it out locally [17:47:01] MaxSem can probably walk you through it [17:47:27] * MaxSem hides [17:47:38] mmm [17:47:40] And then once you it's finished you just have to merge it back into master [17:47:58] kaldari: this is all assuming that my big patches will get merge today ;- [17:48:06] the alternative would be to get the branch cut before [17:48:08] (03CR) 10Dbrant: [C: 032] Adds script that makes it easier to make a release [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129204 (owner: 10Yuvipanda) [17:48:10] if that is an option [17:48:31] jdlrobson: Yeah, if you think this refactoring is only going to take a day, you could just do that [17:48:37] (03PS3) 10Jdlrobson: Hygiene: Introduce cloaked-element class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129198 [17:48:45] (03CR) 10Dbrant: [C: 032] Update launcher icon [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129137 (owner: 10Yuvipanda) [17:48:47] kaldari: how can we get the branch cut now? [17:49:09] chrismcmahon: is it possible to run some manual tests via cloudbees? [17:49:16] to check it's working again? [17:49:32] you mean the deployment branch? [17:49:35] jdlrobson: want me to kick off a build? [17:49:40] chrismcmahon: please [17:49:44] kaldari: yeh the deployment branch [17:49:58] it gets cut automatically [17:50:22] at least I think that's how it works now [17:50:37] awww :/ [17:50:57] kaldari: https://gerrit.wikimedia.org/r/129209 and https://gerrit.wikimedia.org/r/129197 can get merged safely [17:52:37] jdlrobson: 1.24wmf1 was the last deployment branch to get cut [17:53:34] jdlrobson, my issue with separate branch: why would it make things easier? if we cut off the other branch on, say Monday, we have the same problem: everything has to be perfect on Friday [17:53:39] jdlrobson: 1.24wmf2 should get cut automatically tomorrow [17:54:15] jgonera: basically I don't want to endanger the code going on to the deployment train tomorrow by big changes such as merging overlay and overlay new code [17:54:26] i'm looking at ways we can safely merge that code and give us time to identify any issues [17:54:43] jdlrobson, sure, but you would "endanger" it anyway, just on a different date [17:55:07] jgonera: sure but it gives us a week to inspect and react to broken browser tests [17:55:07] jdlrobson, I think creating another branch doesn't solve the problem, modifying how deployment train works could [17:55:14] jgonera: sure [17:55:20] please review: https://gerrit.wikimedia.org/r/#/q/owner:%22MaxSem+%253Cmaxsem.wiki%2540gmail.com%253E%22+status:open+%28project:mediawiki/extensions/TextExtracts+OR+project:mediawiki/extensions/PageImages%29,n,z [17:55:31] jdlrobson, how? will you be using the deployment branch all the time to see if nothing is broken there? [17:55:33] jgonera: let me put it this way.. would you be happy merging changes that merge overlay and overlay new code today or would you rather merge it tomorrow [17:55:39] jgonera: Not necessarily. You could keep that branch separate for a while, but have it deployed onto beta labs or somewhere for testing [17:55:59] kaldari, jdlrobson sure, but who would do that testing? [17:56:00] (03PS2) 10Jdlrobson: Hygiene: Merge Overlay and OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129196 [17:56:14] jgonera: well cloudbees would run it's tests [17:56:27] jgonera: that's true, if no one is actually using it, there's no point in having a separate branch [17:56:30] it takes time to run them though [17:56:34] jdlrobson, I know what the problem is, I'm just saying that another branch doesn't seem like the right solution [17:56:51] jgonera: sure and i wasn't saying it was - hence why i asked if the deployment branch could be cut now [17:56:58] as that would be an alternative solution [17:57:06] oh, I see [17:58:10] that will work for this particular case though, let's talk more in the office, it's easier than typing [17:58:11] it's probably a bad idea to cut the deployment branch early [17:58:37] as it will probably get recut automatically anyway [17:59:06] :-/ [17:59:27] kaldari: there must be a way to block a deployment of current master [17:59:34] greg-g: you around? [18:00:13] 3MobileFrontend / 3stable: Do not use comma-separator message in "7 bytes added, 8 days ago" (mobile diff) - 10https://bugzilla.wikimedia.org/64302 (10Liangent) 3NEW p:3Unprio s:3normal a:3None I'm not sure about the correct alternative, but in some languages, comma-separator is translated as "the pu... [18:00:14] jdlrobson: yeah, you can block the deployment, but the branch cutting is automatic I believe [18:00:26] 3MobileFrontend / 3stable: Do not use comma-separator message in "7 bytes added, 8 days ago" (mobile diff) - 10https://bugzilla.wikimedia.org/64302#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1957 [18:00:41] 3MobileFrontend / 3stable: Do not use comma-separator message in "7 bytes added, 8 days ago" (mobile diff) - 10https://bugzilla.wikimedia.org/64302 (10Liangent) [18:00:47] jdlrobson: not really, Deskana is my surrogate for most things [18:02:11] greg-g: roger [18:03:00] I'm at that WikiLead thing today and tomorrow (and yesterday), and I shoulnd't be on IRC right now ;) [18:03:26] 3MobileFrontend / 3stable: Do not redirect undo edits to mobile editor - 10https://bugzilla.wikimedia.org/64256#c7 (10Liangent) (In reply to Jon from comment #6) > The history link is going to be mobile optimised in a week. There will be no > undo action at first launch on this history page. > See http://en.... [18:04:06] kaldari: jgonera gonna ask roan [18:05:23] jdlrobson: Reedy would also be a good person to talk to - im not sure if he still does but i know he was managing the deployment branch cuts previously [18:05:59] kaldari: jgonera awjr it seems that our deployment strategy is that lame. Roan suggests not merging till tomorrow [18:06:39] yeah, it is. we should probably talk to the right people about changing it a bit, it's not something our team alone can do [18:06:53] MaxSem: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=San_Francisco&action=history&mobileaction=toggle_view_desktop is redirecting to article page rather than history.. any ideas why? [18:07:21] looking [18:07:42] it used to be that you could specify a specific branch from which to deploy jdlrobson, kaldari, MaxSem, jgonera [18:08:03] awjr, but then we jumped on the train [18:08:06] we could conceivably cut a branch from master right now and ask Reedy or whomever to cut the deployment branch from that branch rather than master [18:08:33] we'll have to fix their scripts too, I suspect [18:09:42] i wonder if any teams are doing development in a branch that's *not* master [18:09:55] that would be another way to mitigate this [18:10:21] but it's kinda last minute to change our workflow to try and fix this for tomorrow's deployment [18:10:32] awjr: fundraising might be [18:11:55] FR are way too separate from everyone [18:11:58] ...else [18:12:33] * awjr shrugs [18:13:17] jdlrobson: what will you do for now? [18:14:19] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129196 (owner: 10Jdlrobson) [18:25:11] awjr: i'm lost for ideas other than blocking till tomorrow on certain patch sets getting code reviewed :( [18:26:58] (03PS1) 10MaxSem: Fix fatal in Special:MobileLanguages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129223 [18:29:41] awjr: i'm talking with Deskana about whether it's possible to cut earlier [18:31:21] (03CR) 10Jdlrobson: [C: 032] Fix fatal in Special:MobileLanguages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129223 (owner: 10MaxSem) [18:32:11] (03PS1) 10MaxSem: Fix check for empty title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129225 [18:32:21] (03Merged) 10jenkins-bot: Fix fatal in Special:MobileLanguages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129223 (owner: 10MaxSem) [18:32:28] (03PS3) 10Jdlrobson: QA: Add browser tests for presence of more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127185 [18:32:40] chrismcmahon: https://gerrit.wikimedia.org/r/#/c/127185/ [18:35:45] (03CR) 10Jdlrobson: [C: 04-1] Fix check for empty title (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129225 (owner: 10MaxSem) [18:36:57] (03PS2) 10MaxSem: Fix check for empty title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129225 [18:40:04] dbrant: https://trello.com/b/h0B6QYBo/mobile-app-backlog [18:49:52] dbrant: YuviPanda http://hatjitsu.wmflabs.org/47345 [18:55:44] 3MobileFrontend / 3stable: mobileview fails on content pages redirecting to special pages - 10https://bugzilla.wikimedia.org/64305 (10Max Semenik) 3NEW p:3Unprio s:3normal a:3None Example: https://en.wikipedia.org/w/api.php?action=mobileview&page=User%3APurplebackpack89%2FC&redirects=yes&prop=section... [18:56:07] YuviPanda, any suggestions on what to return in ^^ ? [18:56:46] MaxSem: what is ^^ referring to? [18:56:49] https://gerrit.wikimedia.org/r/#/c/129225/? [18:57:00] yes [18:57:06] er [18:57:07] no [18:57:13] YuviPanda, https://bugzilla.wikimedia.org/64305 [18:58:48] MaxSem: ah, right. redirect: "Special:Contributions/something", special: true [18:58:48] ? [18:58:59] MaxSem: similar to mainpage: "" [18:59:42] 3MobileFrontend / 3alpha: VisualEditor Mobile: "Success! Your edit was saved" message stays in the VE mode unless user scrolls down the page - 10https://bugzilla.wikimedia.org/64270#c1 (10Roan Kattouw) a:3None We should probably dismiss this message when the user opens VE again. Sounds like this code is i... [19:00:26] 3MobileFrontend / 3stable: mobileview fails on content pages redirecting to special pages - 10https://bugzilla.wikimedia.org/64305#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1959 [19:00:27] 3MobileFrontend / 3alpha: VisualEditor Mobile: "Success! Your edit was saved" message stays in the VE mode unless user scrolls down the page - 10https://bugzilla.wikimedia.org/64270#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/pro... [19:00:31] MaxSem: in fact a general "specialpage": "" would be useful as well, I think [19:07:26] 3MobileFrontend / 3stable: mobileview fails on content pages redirecting to special pages - 10https://bugzilla.wikimedia.org/64305#c2 (10Max Semenik) MaxSem: ah, right. redirect: "Special:Contributions/something", special: true ? MaxSem: similar to mainpage: "" ... [19:10:52] dbrant: if your up for it the web team is doing their review estimation meeting @ 1 today. you could passively observe it before the app teams does ours tomorrow [19:11:13] dbrant: i'll add you. up to you if you want to see it or not [19:11:15] awjr: --^ [19:11:29] dbrant: awjr == Arthur [19:11:36] tfinc: thx [19:13:23] lunch then back to sqlite \o/ brb [19:14:31] dbrant: i also added you as optional to the mobile web standups so that you can get more exposure to other teams [19:20:12] * awjr waves [19:46:16] brion: i should have the edit patch ready in next hr [19:46:46] spiff [19:46:58] sqlite stuff is taking a little longer than expected so it may not make it in today’s release [19:47:56] brion: no worry! could even tag team it? you could extract and i could import? [19:48:15] mhurd: could do that. gimme a bit to finish up the export parts [19:48:33] brion: cool. no rush [19:50:47] (03CR) 10Jdlrobson: [C: 032] Fix check for empty title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129225 (owner: 10MaxSem) [19:51:18] (03Merged) 10jenkins-bot: Fix check for empty title [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129225 (owner: 10MaxSem) [19:55:30] (03PS1) 10Jdlrobson: Pass undo message to JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129267 [19:55:41] 3MobileFrontend / 3stable: Message key instead of text is shown for the error message of missing undo support in the mobile editor - 10https://bugzilla.wikimedia.org/64257 (10Gerrit Notification Bot) 5NEW>3PAT [19:55:41] 3MobileFrontend / 3stable: Message key instead of text is shown for the error message of missing undo support in the mobile editor - 10https://bugzilla.wikimedia.org/64257#c2 (10Gerrit Notification Bot) Change 129267 had a related patch set uploaded by Jdlrobson: Pass undo message to JavaScript https://gerr... [19:59:38] (03CR) 10MaxSem: [C: 032] Pass undo message to JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129267 (owner: 10Jdlrobson) [20:01:44] (03Merged) 10jenkins-bot: Pass undo message to JavaScript [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129267 (owner: 10Jdlrobson) [20:01:56] 3MobileFrontend / 3stable: Message key instead of text is shown for the error message of missing undo support in the mobile editor - 10https://bugzilla.wikimedia.org/64257#c3 (10Gerrit Notification Bot) Change 129267 merged by jenkins-bot: Pass undo message to JavaScript https://gerrit.wikimedia.org/r/129267 [20:02:11] 3MobileFrontend / 3stable: Message key instead of text is shown for the error message of missing undo support in the mobile editor - 10https://bugzilla.wikimedia.org/64257 (10Jon) 5PAT>3RES/FIX [20:03:44] https://trello.com/b/sFlwoPUn/mobile-web-q4-backlog [20:04:55] https://trello.com/b/NjJtUGAz/mobile-web-next-sprint-v [20:18:54] sqlite3 uses ‘const unsigned char *’ for strings [20:18:56] whyyyyyyyyy [20:19:04] i have to cast them to ‘const char *' [20:23:21] mhurd: did you see the email asking about maryana’s access on testflight? if you can’t figure that out poke me and i’ll see if i can find it :) [20:23:37] we might hae to add her back to the new ‘internal’ list and re-whitelist her [20:23:43] brb [20:23:46] * Maryana perks up [20:23:49] brion: just saw it [20:23:51] yes please! [20:23:55] jdlrobson: I have no idea what you guys are looking at [20:24:07] https://trello.com/c/TXRBDuld/4-13-add-references-through-visual-editor [20:24:09] kaldari: https://trello.com/b/NjJtUGAz/mobile-web-next-sprint-v [20:24:10] Maryana: i think you should be set. we should cut another build later today [20:24:10] kaldari: ^^ [20:24:22] thanks! [20:24:22] mhurd: awesomesauce [20:24:42] kaldari: i love your new gchat icon [20:25:47] vbamba: hey do you have a sec to email me the license copy? [20:26:11] vbamba: lots to type out :) [20:28:43] 3MobileFrontend / 3stable: MobileOptions checkbox toggles should be refactored and put in mediawiki.ui - 10https://bugzilla.wikimedia.org/64313 (10Jon) 3NEW p:3Unprio s:3normal a:3None Looking at the CSS for the beta / alpha/ image toggle buttons https://en.m.wikipedia.org/w/index.php/Special:Mobile... [20:29:28] mhurd: hm, it's still not letting me install the latest version.. but if y'all are cutting a new version later today, i'll just wait patiently and try to get on that one :) [20:30:26] 3MobileFrontend / 3stable: MobileOptions checkbox toggles should be refactored and put in mediawiki.ui - 10https://bugzilla.wikimedia.org/64313#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1960 [20:31:39] Maryana: *fingers crossed* [20:31:51] Maryana: still learning my way around testflight [20:32:14] it's pretty.. funky [20:32:20] Maryana: ping me tomorrow if you’re still not getting anything after today’s build [20:32:29] Maryana: ya. silliness [20:32:30] will do! [20:35:41] 3MobileFrontend / 3Feature requests: replace ≡ (hamburger menu) with wikifont W symbol for site drawer. - 10https://bugzilla.wikimedia.org/63978 (10Jon) [20:36:41] 3MobileFrontend / 3General/Unknown: Beta Features: The blue geonotahack icon appears in the wrong place in RTL wikis - 10https://bugzilla.wikimedia.org/61134#c4 (10Jon) 5NEW>3RES/WOR The nearby beta feature is disabled for the time being. This should be addressed in the next iteration of work. [20:38:11] 3MobileFrontend / 3stable: File upload token errors - 10https://bugzilla.wikimedia.org/62587 (10Jon) [20:38:56] 3MobileFrontend / 3Feature requests: Lots of background images not using data URI embedding - 10https://bugzilla.wikimedia.org/64101 (10Jon) [20:40:24] http://hatjitsu.wmflabs.org/92021 [20:40:32] MaxSem|wtf: jgonera kaldari jdlrobson ^ [20:40:41] 3MobileFrontend / 3beta: Nearby close button and entries could use feedback effects - 10https://bugzilla.wikimedia.org/58483#c2 (10Jon) 5NEW>3RES/WOR Closing since the nearby beta feature is now disabled. Will be revisited as part of the big redesign https://www.mediawiki.org/wiki/Beta_Features/Nearby_Pa... [20:44:43] 3MobileFrontend / 3Hygiene: Move Nearby code to Geodata extension - 10https://bugzilla.wikimedia.org/64316 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon This would require moving some of our code and putting it into a new extension. This would probably be a useful for code sharing between Flow, MobileFron... [20:50:58] 3MobileFrontend / 3stable: Desktop history link doesn't toggle to correct mobile place - 10https://bugzilla.wikimedia.org/64317 (10Jon) 3NEW p:3Unprio s:3normal a:3None Go to http://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Forty-seven_Ronin&action=history Click mobile view Get desktop histor... [20:52:43] 3MobileFrontend / 3stable: mobileaction parameter causes all other parameters to be lost in redirect - 10https://bugzilla.wikimedia.org/64318 (10Jon) 3NEW p:3Unprio s:3normal a:3None Visit http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Forty-seven_Ronin&action=edit&mobileaction=toggle_view_de... [20:55:26] 3MobileFrontend / 3stable: mobileaction parameter causes all other parameters to be lost in redirect - 10https://bugzilla.wikimedia.org/64318#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1962 [20:55:26] 3MobileFrontend / 3stable: Desktop history link doesn't toggle to correct mobile place - 10https://bugzilla.wikimedia.org/64317#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1961 [20:59:13] 3Wikipedia App / 3Generic: Replace floppy disk and trash icons on editing, history screens. - 10https://bugzilla.wikimedia.org/64320 (10May Tee-Galloway) 3NEW p:3Unprio s:3normal a:3None Created attachment 15180 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15180&action=edit Editing screen (... [20:59:42] App has an icon! \o/ [20:59:56] 3Wikipedia App / 3Generic: Replace floppy disk and trash icons on editing, history screens. - 10https://bugzilla.wikimedia.org/64320#c1 (10May Tee-Galloway) Created attachment 15181 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15181&action=edit History (replace trash icon) [21:00:02] (03PS1) 10Mhurd: Edit workflow design refinement. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129300 [21:01:09] brion: ^ this should be close :) i’ll hook up the actual license copy tomorrow if that’s ok [21:01:15] yay! [21:01:30] i’m still fighting with sqlite, but i think my main crasher turned out to be failing to initialize a variable [21:01:43] which in objective-c just means “nothing happens” cause you can send messages to nil [21:01:45] *$^(*#&(*$ [21:01:57] brion: hehe i feel your pain :) [21:02:15] :) [21:02:27] brion: was able to iron out a couple ios 6/7 differences with nav styling with that patch too. if it’s good to go i’ll cut build soon as we merge [21:02:58] nice [21:16:14] (03PS2) 10Mhurd: Edit workflow design refinement. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129300 [21:16:38] brion: hey i amended ^ to use better placeholder icons for the bottom 2 main menu items [21:17:02] whee [21:21:56] 3Wikipedia App / 3Generic: Replace floppy disk and trash icons on editing, history screens. - 10https://bugzilla.wikimedia.org/64320#c2 (10May Tee-Galloway) .WikiFont-tick:before { content: "\e002"; } .WikiFont-trash:before { content: "\e500"; } bit.ly/WikiFont ------------------- Constructive (last... [21:25:49] (03CR) 10Brion VIBBER: [C: 032 V: 032] Edit workflow design refinement. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129300 (owner: 10Mhurd) [21:26:03] brion: yay! [21:26:16] brion: working on release notes now [21:26:20] spiff [21:26:34] brion: will ping u if i get stuck releasing :) [21:26:35] go ahead and release this version and we’ll have the migration in the next one [21:26:37] still finishing that up [21:26:38] :D ok [21:26:41] brion: k [21:35:08] violetto: hey! [21:35:23] YuviPanda! [21:36:21] violetto: saw my responses on the icon thread? [21:36:31] hang on [21:37:08] YuviPanda: no, where? [21:37:13] violetto: in bugzilla? [21:37:26] violetto: https://bugzilla.wikimedia.org/show_bug.cgi?id=64263 [21:38:43] (03PS1) 10Brion VIBBER: Work in progress: data migration from old app [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129307 [21:40:16] YuviPanda: i need to cc myself on the bugs i fil [21:40:17] file [21:40:26] 3Wikipedia App / 3Generic: New icon looks wobbly on light backgrounds - 10https://bugzilla.wikimedia.org/64263#c6 (10May) It looked fine on my phone, what do you mean by patchy looking..? That sounds good with removing the background on action bars. [21:40:30] violetto: no you should be getting those emails by defualt I think [21:40:34] violetto: 'reporter' is treated specially [21:40:44] violetto: check if you have it filtered or somesuch? [21:40:57] YuviPanda: previously i had to cc myself otherwise i wouldn't get anything [21:41:12] violetto: it might be a preference tweak tho [21:41:27] violetto: it looks like a patch? :D [21:41:33] YuviPanda: didn't see in spam either, let me check [21:41:40] the prefs [21:42:37] violetto: ok [21:42:49] YuviPanda: no problems with my prefs, that's odd [21:43:37] kaity: can you help us out with design input on https://bugzilla.wikimedia.org/64108 ? [21:43:57] 3MobileFrontend / 3stable: mobileaction parameter causes all other parameters to be lost in redirect - 10https://bugzilla.wikimedia.org/64318#c2 (10Max Semenik) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 64317 *** [21:43:57] 3MobileFrontend / 3stable: Desktop history link doesn't toggle to correct mobile place - 10https://bugzilla.wikimedia.org/64317#c2 (10Max Semenik) *** Bug 64318 has been marked as a duplicate of this bug. *** [21:45:42] YuviPanda: i forgot on android it doesn't cut the launcher icon shape, hang on [21:45:50] awjr: sure let me take a look [21:46:01] violetto: ok [21:46:07] YuviPanda: does it put a background shadow by default? [21:46:14] violetto: nope [21:46:24] violetto: nothing is done to it, IIRC [21:46:39] thanks kaity :) [21:55:12] tfinc: going to run to dr appt. my patch got merged and i put together build release notes. will cut build right after dr appt [21:55:22] mhurd: thanks for the heads up [21:55:26] i'm eager to play with it [21:55:41] tfinc: new android build went out. ragesoss is playing with it :) [21:55:44] I sent notes to mobile-l too [21:55:51] tfinc: yw :) brd [21:55:54] *brb* [21:58:07] Yuvipanda: haven't actually played with it yet, just noticed the icon. [21:58:28] ragesoss: ah :) violetto is still tweaking it [21:58:33] It's pretty close to non-beta release, right? [21:58:48] ragesoss: well, it's pretty close to a beta on the play store release [21:59:22] As in, normal play release without sign up as a tester? [21:59:26] ragesoss: yeah [21:59:33] ragesoss: the 'Wikipedia App (Beta)' [22:00:40] Excellent. [22:01:36] ragesoss: :) [22:02:41] 3Wikipedia App / 3Generic: New icon looks wobbly on light backgrounds - 10https://bugzilla.wikimedia.org/64263#c7 (10May) Created attachment 15184 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15184&action=edit App launch icon [22:03:11] 3Wikipedia App / 3Generic: New icon looks wobbly on light backgrounds - 10https://bugzilla.wikimedia.org/64263#c8 (10May) Created attachment 15185 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15185&action=edit App launch icon [22:09:12] (03PS1) 10Yuvipanda: Update icon to latest version [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129310 [22:09:13] violetto: ^ [22:09:50] YuviPanda: woop [22:09:53] making beta one now [22:10:19] violetto: coool! [22:10:23] violetto: also make an alpha one [22:18:08] (03PS1) 10Yuvipanda: Make Crash reporter use Holo theme [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129311 [22:18:13] violetto: I'm heading to sleep [22:18:22] dbrant: tfinc violetto night! [22:18:34] YuviPanda: later! [22:18:39] goodnight YuviPanda [22:18:52] dbrant: do merge these two when you have the time to look over them :) [22:18:55] bye [22:48:29] (03PS1) 10MaxSem: Stop special-casing history views in shouldDisplayMobileView() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129318 [22:48:52] (03PS4) 10JGonera: Story 1904: Filters to reduce copyvios on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127179 [22:49:04] (03CR) 10MaxSem: [C: 04-2] Stop special-casing history views in shouldDisplayMobileView() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129318 (owner: 10MaxSem) [22:49:44] jdlrobson if you have a moment check https://gerrit.wikimedia.org/r/127179 probably worth merging sooner than later taking into account community's irritation with copyvios [22:50:05] (03CR) 10JGonera: Story 1904: Filters to reduce copyvios on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127179 (owner: 10JGonera) [22:50:17] jgonera: sure i'll take a look [22:50:38] jgonera: are you updating the limn graph? [22:50:44] jdlrobson, doing that now [22:51:07] also jgonera you seem to be adding it to stable? story says beta.. [22:51:26] jdlrobson, you mean the exif library itself? [22:51:27] (03PS2) 10MaxSem: Stop special-casing history views in shouldDisplayMobileView() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129318 [22:51:41] jgonera: the whole thing was suppose to be beta only for time being until we got the design right [22:51:41] (03CR) 10MaxSem: Stop special-casing history views in shouldDisplayMobileView() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129318 (owner: 10MaxSem) [22:51:47] unless i'm misunderstanding [22:51:50] jdlrobson, ^ [22:51:51] only just glossing through [22:52:09] jdlrobson, it doesn't run in stable, the exif library is loaded though [22:52:18] mmm not sure how i feel about that [22:52:51] jdlrobson, should I create a separate module for those two files? not sure how I would split the code in the overlay out [22:53:13] jgonera: i'd suggest so.. i guess this library is written fro desktop so i get a bit cautious about throwing an external library straight into core [22:53:18] *stable [22:53:38] jdlrobson, I'll do that. what do you mean by "written for desktop"? [22:54:00] also jgonera what license is this code? [22:54:24] what code? exif-js? MIT [22:55:34] jgonera: we should probably include the license in here - i'm no expert but i'm pretty sure we can't just whack it in [22:56:09] jdlrobson, we're not doing it for any other library [22:56:18] jgonera: Hogan has its license at the top.. [22:56:39] jQuery does [22:56:41] we don't have any other external libraries that i know of..? [22:57:02] well, we have the ones I wrote but I won't sue WMF [22:57:24] anyway, I'd appreciate an asynchronous CR so if you can write all of that down in gerrit it would make my life easier ;) [22:57:28] jgonera: sure [23:00:01] jdlrobson, jquery in core doesn't seem to have the license included [23:00:48] moment does though [23:00:50] I'll add it [23:01:50] (03CR) 10Jdlrobson: [C: 04-1] "Some minor concerns." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127179 (owner: 10JGonera) [23:03:00] (03PS3) 10Jdlrobson: Stop special-casing history views in shouldDisplayMobileView() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129318 (owner: 10MaxSem) [23:03:11] 3MobileFrontend / 3stable: Desktop history link doesn't toggle to correct mobile place - 10https://bugzilla.wikimedia.org/64317#c3 (10Gerrit Notification Bot) Change 129318 had a related patch set uploaded by Jdlrobson: Stop special-casing history views in shouldDisplayMobileView() https://gerrit.wikimedia.... [23:04:51] (03CR) 10Jdlrobson: [C: 032] Stop special-casing history views in shouldDisplayMobileView() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129318 (owner: 10MaxSem) [23:05:22] (03Merged) 10jenkins-bot: Stop special-casing history views in shouldDisplayMobileView() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129318 (owner: 10MaxSem) [23:05:41] 3MobileFrontend / 3stable: Desktop history link doesn't toggle to correct mobile place - 10https://bugzilla.wikimedia.org/64317#c4 (10Gerrit Notification Bot) Change 129318 merged by jenkins-bot: Stop special-casing history views in shouldDisplayMobileView() https://gerrit.wikimedia.org/r/129318 [23:05:56] 3MobileFrontend / 3stable: Desktop history link doesn't toggle to correct mobile place - 10https://bugzilla.wikimedia.org/64317 (10Jon) 5PAT>3RES/FIX [23:09:51] mhurd: just saw the new build come through [23:09:52] Maryana: just sent build. did you get a email? [23:10:03] tfinc: yay! [23:21:24] mhurd: hows the iconfont working out? [23:21:30] did you get to try them yet [23:22:24] violetto: the release i just cut uses it for the little smiley faces on the article history interface. will update more places to use it soon [23:23:58] mhurd: okay. btw, i just updated the app icons [23:24:01] launchers [23:24:10] violetto: it’s pretty great. oh cool! [23:24:19] violetto: checking update… [23:24:35] https://trello.com/c/U8vGqn3c/9-1-app-icon-should-be-w-not-generic-icon mhurd [23:26:57] violetto: thx! [23:27:53] mhurd: np! haven't seen much uploads on trello on either both of you, any updates on what's been happening? [23:28:39] violetto: did u get the test flight email from a few minutes ago? good summary there [23:29:19] violetto: will try to post more screenshots to design board later too [23:30:14] mhurd: ah! you sent a new build. [23:30:39] mhurd: it's alright if it's extra time to upload. I can just send bugs :) [23:31:43] 3Wikipedia App / 3Generic: Left drawer text is running too close to the right edge! - 10https://bugzilla.wikimedia.org/64335 (10May) 3NEW p:3Unprio s:3normal a:3None Created attachment 15190 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15190&action=edit Left drawer screenshot Use same padd... [23:35:55] mhurd: yes! thank you -- installing now :D [23:38:43] 3Wikipedia App / 3Generic: Left drawer should animate from left instead of right - 10https://bugzilla.wikimedia.org/64336 (10May) 3NEW p:3Unprio s:3normal a:3None Especially since the icon is on the left [23:40:45] Maryana: yay! [23:41:28] 3Wikipedia App / 3Generic: Unable to swipe back from "Browsing history" and "Saved pages" view - 10https://bugzilla.wikimedia.org/64337 (10May) 3NEW p:3Unprio s:3normal a:3None I'm unable to go back to the previous screen to exit the view when I swipe to go back [23:43:11] 3Wikipedia App / 3Generic: Unable to swipe back from "Browsing history" and "Saved pages" view - 10https://bugzilla.wikimedia.org/64337#c1 (10May) I'm also unable to go back to the previous screens by swiping on any screens