[00:07:44] (03PS1) 10Jdlrobson: WIP: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 [00:07:46] (03PS1) 10Jdlrobson: WIP: Use Mantle version of Class and eventemitter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 [00:07:48] (03PS1) 10Jdlrobson: WIP: Use the View in Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129337 [00:08:00] (03CR) 10Jdlrobson: [C: 04-2] "Proof of concept.. thoughts?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [00:08:10] (03CR) 10Jdlrobson: [C: 04-2] "Proof of concept.. thoughts?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (owner: 10Jdlrobson) [00:08:16] (03CR) 10Jdlrobson: [C: 04-2] "Proof of concept.. thoughts?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129337 (owner: 10Jdlrobson) [00:08:18] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add template dependency to Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [00:08:23] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use Mantle version of Class and eventemitter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129336 (owner: 10Jdlrobson) [00:08:30] (03CR) 10jenkins-bot: [V: 04-1] WIP: Use the View in Mantle extension [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129337 (owner: 10Jdlrobson) [00:12:58] 3Wikipedia App / 3Generic: Keyboard doesn't hide when I navigate to left drawer - 10https://bugzilla.wikimedia.org/64339 (10May) 3NEW p:3Unprio s:3normal a:3None Created attachment 15191 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15191&action=edit Keyboard [00:15:45] (03PS1) 10MaxSem: Hygiene: Fix tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129338 [00:16:17] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Fix tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129338 (owner: 10MaxSem) [00:18:06] (03PS2) 10MaxSem: Hygiene: Fix tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129338 [00:18:38] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Fix tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129338 (owner: 10MaxSem) [00:20:34] (03PS3) 10MaxSem: Hygiene: Fix tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129338 [00:22:29] quick review please ^^^ :) [00:24:43] 3Wikipedia App / 3Generic: Content doesn't realign after zooming out - 10https://bugzilla.wikimedia.org/64340 (10May) 3NEW p:3Unprio s:3normal a:3None Created attachment 15192 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15192&action=edit Content sticks to side The ability to zoom in on th... [00:25:58] 3Wikipedia App / 3Generic: ToC taking up too much horizontal space - 10https://bugzilla.wikimedia.org/64341 (10May) 3NEW p:3Unprio s:3normal a:3None Created attachment 15193 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15193&action=edit Left drawer Can we make it so it looks the same as wh... [00:26:11] 3Wikipedia App / 3Generic: ToC taking up too much horizontal space - 10https://bugzilla.wikimedia.org/64341#c1 (10May) Created attachment 15194 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15194&action=edit ToC [00:28:13] 3Wikipedia App / 3Generic: Search field too small of a target - 10https://bugzilla.wikimedia.org/64342 (10May) 3NEW p:3Unprio s:3normal a:3None Created attachment 15195 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15195&action=edit Search field too small Use the same vertical space as list... [00:30:16] (03PS1) 10Mhurd: Launch icon set. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129343 [00:39:43] 3Wikipedia App / 3Generic: Edit buttons adding too much clutter to page, very distracting reading experience - 10https://bugzilla.wikimedia.org/64343 (10May) 3NEW p:3Unprio s:3normal a:3None Created attachment 15196 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15196&action=edit 1 We need t... [00:40:11] 3Wikipedia App / 3Generic: Edit buttons adding too much clutter to page, very distracting reading experience - 10https://bugzilla.wikimedia.org/64343#c1 (10May) Created attachment 15197 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15197&action=edit 2 [00:43:26] (03CR) 10Jdlrobson: [C: 032] Hygiene: Fix tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129338 (owner: 10MaxSem) [00:44:04] (03Merged) 10jenkins-bot: Hygiene: Fix tests isolation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129338 (owner: 10MaxSem) [00:49:42] (03PS5) 10JGonera: Story 1904: Filters to reduce copyvios on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127179 [00:55:09] (03CR) 10Jdlrobson: [C: 032] Story 1904: Filters to reduce copyvios on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127179 (owner: 10JGonera) [00:55:51] (03Merged) 10jenkins-bot: Story 1904: Filters to reduce copyvios on mobile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127179 (owner: 10JGonera) [00:57:38] (03PS1) 10MaxSem: Hygiene: remove deadbeef, fix returns [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129352 [01:13:49] (03PS1) 10Jdlrobson: WIP: Fix talk overlay for new pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129358 [02:26:43] (03CR) 10Kaldari: [C: 032] Hygiene: Introduce cloaked-element class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129198 (owner: 10Jdlrobson) [02:35:26] 3Wikipedia App / 3Generic: Keyboard doesn't hide when I navigate to left drawer - 10https://bugzilla.wikimedia.org/64339#c1 (10May) Created attachment 15199 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15199&action=edit 2 It also doesn't hide if I exit out of the search mode by tapping on the arti... [06:35:41] 3Wikipedia App / 3Generic: App Icon Should be 'W' not generic Android icon - 10https://bugzilla.wikimedia.org/61259 (10Yuvi Panda) 5PAT>3RES/FIX [06:47:48] (03PS1) 10Yuvipanda: Fix crash when number of sections change between edits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129378 [06:48:11] 3Wikipedia App / 3Generic: Editing a section newly added from another device crashes the app - 10https://bugzilla.wikimedia.org/64282#c1 (10Gerrit Notification Bot) Change 129378 had a related patch set uploaded by Yuvipanda: Fix crash when number of sections change between edits https://gerrit.wikimedia.or... [07:19:26] 3Wikipedia App / 3Generic: Log out should only log me out from the current device - 10https://bugzilla.wikimedia.org/64177#c1 (10Yuvi Panda) 5NEW>3RES/FIX Fixed in latest build. [07:47:17] (03PS1) 10Yuvipanda: Amend crash report dialog text to be less cute [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129380 [08:06:01] (03CR) 10Siebrand: [C: 032] Amend crash report dialog text to be less cute (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129380 (owner: 10Yuvipanda) [08:29:27] (03CR) 10Siebrand: Edit workflow design refinement. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129300 (owner: 10Mhurd) [08:33:27] (03CR) 10Mhurd: "Added comment." (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129300 (owner: 10Mhurd) [08:50:51] (03PS1) 10Mhurd: Wikifont now used for main menu icons. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129385 [08:53:36] (03PS1) 10Mhurd: Added missing "the" to license copy. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129386 [08:58:58] (03CR) 10Siebrand: [C: 032] Added missing "the" to license copy. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129386 (owner: 10Mhurd) [11:50:41] 3MobileFrontend / 3Feature requests: Allow configuration of the mobilefrontend menu - 10https://bugzilla.wikimedia.org/63459#c2 (10Ricordisamoa) Discussion on MediaWiki.org: https://www.mediawiki.org/wiki/Thread:Extension_talk:MobileFrontend/How_do_you_Customize_the_Menu%3F [13:37:22] MaxSem, good morning [13:37:32] do you know if http lib has a notion of "session" [13:38:03] session is a server-side concept [13:38:12] http just passes cookies for it [13:39:02] MaxSem, yes, i guess i'm talking about an automatic cookie management [13:39:07] like a "request" lib for python [13:39:17] neveer used [13:39:34] it seems the http::get creates a new object every time [13:39:49] and i would have to manually handle cookie operations [13:40:39] (trying to implement api login from php) [13:41:01] curl then [13:45:52] we have this complex multi-http lib support... guess i can simply ignore it [13:46:26] Ш рфв фт шьзкуыыышщт ерфе щгк реез сдшууте рфтвдуы сщщлшуы [13:46:45] I had an impression that our http client handles cookies [14:23:05] (03PS1) 10Cmcmahon: QA: comment is obsolete, bug is fixed, tag is added [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129427 [16:23:11] 3MobileFrontend / 3General/Unknown: create a book should be possible from mobile - 10https://bugzilla.wikimedia.org/60249#c3 (10Nemo) p:5Low>3Normal s:5enhanc>3normal This is not a Collection bug, Special:Book works perfectly on mobile. The issue is MobileFrontend killing links to it too aggressively... [16:25:26] 3MobileFrontend / 3General/Unknown: create a book should be possible from mobile - 10https://bugzilla.wikimedia.org/60249#c4 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1963 [16:25:56] 3MobileFrontend / 3General/Unknown: download a book from mobile should be possible - 10https://bugzilla.wikimedia.org/60250#c4 (10Nemo) p:5Low>3Normal s:5enhanc>3normal This is not a Collection bug, Special:Book works perfectly on mobile. The issue is MobileFrontend killing download links and even te... [16:30:27] 3MobileFrontend / 3General/Unknown: download a book from mobile should be possible - 10https://bugzilla.wikimedia.org/60250#c5 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1964 [16:51:14] (03PS1) 10Jdlrobson: QA: Fix the diff test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129458 [16:51:50] (03CR) 10Jdlrobson: [C: 032] QA: comment is obsolete, bug is fixed, tag is added [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129427 (owner: 10Cmcmahon) [16:52:22] (03Merged) 10jenkins-bot: QA: comment is obsolete, bug is fixed, tag is added [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129427 (owner: 10Cmcmahon) [16:52:43] (03CR) 10Jdlrobson: [C: 032] Hygiene: remove deadbeef, fix returns [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129352 (owner: 10MaxSem) [16:53:01] ^ chrismcmahon awjr_away help us get the tests passing again! [16:53:15] (03Merged) 10jenkins-bot: Hygiene: remove deadbeef, fix returns [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129352 (owner: 10MaxSem) [16:53:31] jdlrobson: what do you need help with? [16:53:39] chrismcmahon: https://gerrit.wikimedia.org/r/129458 [16:53:46] didn't get updated when we pushed history to stable [16:54:37] kk [17:00:34] (03PS1) 10Jdlrobson: Hygiene: JSDuck cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129459 [17:09:21] brion: YuviPanda: heya! [17:09:27] * brion waves [17:10:22] brion: check this out: https://gerrit.wikimedia.org/r/#/c/129385/ got may’s wikifont to replace all the main menu icons :) [17:10:34] heh awesome :D [17:10:41] brion: deleting files makes me happy [17:14:46] :D [17:31:01] hey mhurd! [17:31:13] YuviPanda: hey! [17:31:19] 'sup [17:31:25] hey dbrant! [17:31:35] YuviPanda: just read the bugzilla thread on the protection status api patch [17:31:38] YuviPanda: hello! [17:31:44] dbrant: hey! [17:32:05] mhurd: ah, yeah. we need to resolve that properly to get a 'proper' solution, otherwise it is going to give us inaccurate results. [17:32:18] mhurd: hey! [17:32:28] dbrant: how's it going? [17:33:10] YuviPanda: think the issue will get resolved soon? [17:33:27] mhurd: yeah, sould be. but even if it does it's gonna take a while to get deployed, so not this iteration [17:33:47] YuviPanda: not bad; continuing to digest all of the app code... [17:34:28] dbrant: cool! It's not the best code around (plenty of room for improvement!) but it's not too bad... [17:34:34] one question I had: how does Wipikedia Zero become "enabled"? [17:34:45] YuviPanda: should we move those protection status cards to backlog or something? [17:35:09] dbrant: ah, so that is one of the slightly messier parts of the code. It looks for a header in API responses and then enables itself based on that. [17:35:40] YuviPanda: so how does one "test" it? [17:36:18] dbrant: ah, so that's the terrible thing. You need to 1. whitelist your IP in our prod setup (Adam does this), 2. use the app from that IP [17:36:54] dbrant: so I haven't tested it too well, and it does make me a fair bit nervous. I don't have a stable IP so I can't really test it properly, but we've set up one of my VPSes to be whitelisted, so I should be able to tunnel through and test at some point. [17:37:20] YuviPanda: dbrant: adam added a flag to the ios version for faking it out to test all the interface stuff. may want on android too? [17:37:23] dbrant: and as for what wikipedia zero is - it is a program that lets some people access wikipedia free of charge on certain carriers. [17:37:51] mhurd: ah, yeah, that shouldn't be too hard to add. Should poke him when he gets back. [17:39:56] YuviPanda: see my wikifont patch? having lots of fun deleting pngs :) that font is great [17:40:16] mhurd: :D nice! [17:41:22] YuviPanda: oh for batching launch icons of various sizes, are you using grunt to make pngs from svg? [17:41:40] mhurd: I've a python script that makes *all* my pngs from svgs, and also does RTL flipping :) [17:42:29] YuviPanda: oh cool! [17:42:57] YuviPanda: soon i hope to have no pngs :) well, except for the launch icon set [17:43:03] mhurd: Icon fonts are good on the web because they let you have vector rendering with only one http request. but doesn't make too much sense on Android, since its Vector rendering is shit, extra requests aren't a thing, and I have a nice PNG pipeline anyway. [17:44:36] hi, when was the last depl of mobile ext? [17:44:40] at least we don’t have to maintain any 9-patches. [17:44:51] YuviPanda: general svg vector rendering may be not so great, but i’d guess font rendering is pretty solid, no? [17:45:10] mhurd: ask violetto about it. lots of terrible rendering bugs that were very intermittent. [17:45:41] mhurd: also, how would you add a new icon to the fontfile? how is it built? [17:45:43] YuviPanda: rendering bugs make me sad [17:46:37] YuviPanda: designer would add it i guess [17:46:55] yeah, I don't feel very comfortable having such a manual and intensive process there either. [17:47:27] I do not know how difficult it is to add an icon to a font and rebuild it. [17:47:39] the current process for me is that may sends me an svg and that is the end of story. [17:48:29] YuviPanda: i get the feeling the bulk of the process is creative. may sends me a font with new icon and i smile a lot [17:49:19] YuviPanda: no worries about some divergence here at all though. fun to try stuff [17:49:24] :) indeed [18:00:11] 3MobileFrontend / 3Feature requests: create a book should be possible from mobile - 10https://bugzilla.wikimedia.org/60249 (10Jon) [18:00:27] 3MobileFrontend / 3Feature requests: download a book from mobile should be possible - 10https://bugzilla.wikimedia.org/60250 (10Jon) [18:02:23] brion: can i bug you for some cr? :) [18:02:54] YuviPanda & mhurd, for the font, you tell me what icon you need and I'll give you the icon .class [18:03:06] i'll do all the updating on my side [18:03:15] violetto: cool! [18:03:24] so you guys won't have to download anything, just plug it in [18:03:25] sure moment :D [18:03:25] violetto: lemme send you a screenshot here... [18:03:29] violetto: cool. Android will still be on svg for a while tho [18:03:32] mhurd: ok! [18:03:39] violetto: also what are they built from? where is the source? [18:03:41] YuviPanda: whenever you can :) [18:03:54] can you modify the fontfile from just the resultant file? [18:03:56] anyone can change the .ttf file [18:04:04] ah, that's good to know [18:04:34] either way, it's a pain in Android and in some cases not supported (god knows what I'll have to do to make that work in actionbars), so for the foreseeable future android will probably stick to svg [18:05:00] ^ [18:05:11] blaaaah xcode isn’t seeing my iphone [18:05:16] YuviPanda: ok [18:05:33] YuviPanda: so anyone can edit the .ttf with any font program out there [18:05:37] i use font forge [18:05:43] violetto: check out the icons i chose for the bottom two entries here: https://trello.com/c/6TdkRHcf/68-current-on-ios [18:05:58] maybe i have a bad port on this usb hub [18:06:00] violetto: are these the correct icons or do you want to add a coullpe [18:06:31] (03PS1) 10Jdlrobson: WIP Experiment: Ajax login form on HTTPS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129480 [18:06:39] mhurd: history of changes i'll need to make anew one for that [18:06:44] or we might not need it [18:07:02] (03CR) 10Jdlrobson: [C: 04-2] "i18n and a whole host of other stuff need to be fixed first" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129480 (owner: 10Jdlrobson) [18:07:04] (03CR) 10jenkins-bot: [V: 04-1] WIP Experiment: Ajax login form on HTTPS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129480 (owner: 10Jdlrobson) [18:07:21] violetto: need history of changes and credits icons. will go with these for today, but feel free to add new ones and let me know [18:07:30] kaldari: https://gerrit.wikimedia.org/r/#/c/129209/1 whimper whimper [18:07:42] mhurd: okay [18:09:47] (03CR) 10Jdlrobson: [C: 04-2] "Still work in progress" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129358 (owner: 10Jdlrobson) [18:15:01] mhurd: xcode is not talking to my devices well today, i’m still trying to get anything to run :P [18:15:13] for good measure ima reboot :P [18:15:14] brb [18:15:33] brion: weird! [18:15:48] brb. heading in to office [18:20:19] c’mon xcode [18:20:22] do your thing! [18:21:25] ‘copying symbol files’ my ass... [18:21:38] lemme remove the device and readd it [18:24:03] (03PS2) 10Jdlrobson: Fix talk overlay for new pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129358 [18:24:35] (03CR) 10Jdlrobson: "ready for reviww" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129358 (owner: 10Jdlrobson) [18:29:02] (03CR) 10Brion VIBBER: "Do we want to suppress the shiny effect on iOS 6 or leave it?" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129343 (owner: 10Mhurd) [18:30:19] (03CR) 10jenkins-bot: [V: 04-1] Fix talk overlay for new pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129358 (owner: 10Jdlrobson) [18:34:05] (03CR) 10MaxSem: [C: 032] QA: Fix the diff test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129458 (owner: 10Jdlrobson) [18:34:39] (03Merged) 10jenkins-bot: QA: Fix the diff test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129458 (owner: 10Jdlrobson) [18:41:09] kaldari: you there? [18:41:14] howdy [18:41:22] kaldari! [18:41:25] dbrant: done. your on the board [18:41:30] kaldari: want to help me unleash refactoring hell on mobilefrontend? [18:41:34] tfinc: thx! [18:41:38] beginning with https://gerrit.wikimedia.org/r/#/c/129209/ [18:41:45] hehe, sounds like fun [18:41:56] gonna end up with super clean code! w00t [18:42:34] i'm twiddling my thumbs at moment trying to restrain myself from going too crazy and spending too much time rebasing [18:44:06] jdlrobson: what's with all the 'visible' classes? [18:44:15] kaldari: mm? [18:44:28] oohh kaldari they are needed apparently to make overlays visible in the kss style guide [18:44:29] should everything be visible by default :) [18:44:32] try running it before and after it was broken [18:44:42] oh, weird [18:44:45] i just want to get the style guide working again [18:45:14] (03CR) 10Kaldari: [C: 032] Fix style guide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129209 (owner: 10Jdlrobson) [18:45:23] https://gerrit.wikimedia.org/r/129197 is also a tiny one [18:45:31] all those rules are in typography.less [18:45:46] (03Merged) 10jenkins-bot: Fix style guide [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129209 (owner: 10Jdlrobson) [18:45:58] (03Merged) 10jenkins-bot: Hygiene: Introduce cloaked-element class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129198 (owner: 10Jdlrobson) [18:46:55] (03PS3) 10Jdlrobson: Hygiene: Cleanup blockquote rules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129197 [18:47:03] (03PS4) 10Jdlrobson: Hygiene: Cleanup blockquote rules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129197 [18:47:41] (03CR) 10Kaldari: [C: 032] Hygiene: Cleanup blockquote rules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129197 (owner: 10Jdlrobson) [18:47:50] OuKB: could you help out with https://gerrit.wikimedia.org/r/129459 - it's js but it's documentation [18:48:18] (03Merged) 10jenkins-bot: Hygiene: Cleanup blockquote rules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129197 (owner: 10Jdlrobson) [18:48:36] (03CR) 10MaxSem: [C: 032] Hygiene: JSDuck cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129459 (owner: 10Jdlrobson) [18:49:07] (03Merged) 10jenkins-bot: Hygiene: JSDuck cleanup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129459 (owner: 10Jdlrobson) [18:49:07] kaldari: so then it gets a bit tricker - https://gerrit.wikimedia.org/r/#/c/129083/3 I want to merge the Overlay code [18:50:06] jdlrobson: OK, lemme finish up the little patch I'm working on first. Won't take long... [19:01:43] (03PS1) 10Kaldari: Improve error reporting for image uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 [19:01:56] 3MobileFrontend / 3stable: some upload errors reporting undefined/undefined as error text - 10https://bugzilla.wikimedia.org/64213#c2 (10Gerrit Notification Bot) Change 129492 had a related patch set uploaded by Kaldari: Improve error reporting for image uploads https://gerrit.wikimedia.org/r/129492 [19:03:51] jdlrobson: if you'll review https://gerrit.wikimedia.org/r/#/c/129492/ I'll review your overlay clean-up now :) [19:04:07] mine is easy though [19:08:01] dbrant: YuviPanda mhurd brion http://hatjitsu.wmflabs.org/11404 [19:12:42] kaldari: sure just got back from lunch [19:14:32] om nom nom sammich time [19:14:39] kaldari: this if statement confuses me lots [19:17:09] (03CR) 10Kaldari: [C: 04-1] Hygiene: Rewrite things as Overlaynew (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129083 (owner: 10Jdlrobson) [19:19:07] jdlrobson: well, if we get an XHR object with an error, we want to use that primarily. If there isn't anything defined in the XHR, we resort to the status message, which is something like "error", "parseerror", timeout", etc. and if it was an HTTP error, we also want the error code tacked on. [19:19:19] jdlrobson: Do you want me to add that to a comment? [19:20:35] (03CR) 10Jdlrobson: [C: 031] Improve error reporting for image uploads (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 (owner: 10Kaldari) [19:20:42] ^ kaldari had some thoughts around error handling [19:20:48] in theory, that complicated if statement should give us usuable error info no matter what, but just in case, I threw in the 'unknown' else case as well [19:21:04] kaldari: agreed on outcome i'm just wondering if there is a more elegant way to do it [19:21:15] hey OuKB [19:21:25] * OuKB hides [19:22:05] * YuviPanda lures OuKB with vodka and +5 -2000 patches [19:22:25] OuKB: the canedit patch. [19:22:45] can't fight the whole humankind [19:23:13] jdlrobson: in theory I could check for !== undefined instead, but I opted for === string to match the existing logic that was there, just testing the value isn't good, as some browsers may throw a JS warning. [19:23:32] if the property is undefined [19:23:58] OuKB: any way to do that at all while also keeping our current cache variance? [19:24:14] well [19:24:23] it's already properly varied [19:24:33] OuKB: yeah, but anons get a 'wrong' answer [19:24:42] well [19:24:42] ah, that [19:24:49] specifically blocked IPs get a wrong answer [19:24:59] but I'm ok with that, since that will get rejected when they try to edit anyway [19:25:06] OuKB: also does quickUserCan check for blocks? [19:25:50] this is supposed to work like our desktop editing interface: if you're anon, you get no warning of block until you try to edit [19:25:59] yes it does [19:26:05] ahh, hmm [19:26:35] (03CR) 10Jdlrobson: Hygiene: Rewrite things as Overlaynew (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129083 (owner: 10Jdlrobson) [19:27:06] (03PS4) 10Jdlrobson: Hygiene: Rewrite things as Overlaynew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129083 [19:27:20] (03CR) 10Kaldari: Improve error reporting for image uploads (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 (owner: 10Kaldari) [19:27:28] afk, meeting [19:28:24] (03CR) 10Jdlrobson: Improve error reporting for image uploads (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 (owner: 10Kaldari) [19:28:43] (03PS2) 10Jdlrobson: Rewrite MediaViewer as OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129195 [19:28:48] (03PS3) 10Jdlrobson: Hygiene: Merge Overlay and OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129196 [19:28:52] brion: xcode wrangled? [19:33:19] mhurd: yeah will finish CR when done w/ lunch :D [19:33:56] brion: lunch! i should eat one of those… [19:35:10] (03PS2) 10Kaldari: Improve error reporting for image uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 [19:35:31] jdlrobson: I opted for your method :) [19:35:50] (03CR) 10jenkins-bot: [V: 04-1] Improve error reporting for image uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 (owner: 10Kaldari) [19:36:12] kaldari: jshint requires you wrap them in braces [19:36:26] ah yeah... [19:36:37] hey dbrant! [19:36:47] there's a couple of minor patches you should CR when you have the time :) [19:37:01] hey dr0ptp4kt! meet dbrant, the new person on the android team! [19:37:02] (03CR) 10Jdlrobson: [C: 04-1] Improve error reporting for image uploads (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 (owner: 10Kaldari) [19:37:19] dbrant: dr0ptp4kt works on the wikipedia zero stuff and wrote most of the wikipedia zero parts on the app. do bug him for questions about that [19:37:26] dbryant, hello! [19:37:36] YuviPanda: thanks for the irc intro [19:37:52] dr0ptp4kt: hello! It's Adam, right? [19:38:07] dbrant, yep [19:38:16] (03PS3) 10Kaldari: Improve error reporting for image uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 [19:38:41] YuviPanda: where do I view the patches for CR? [19:38:49] (03CR) 10jenkins-bot: [V: 04-1] Improve error reporting for image uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 (owner: 10Kaldari) [19:39:03] dbrant: ah, let me add you as reviewer [19:39:08] dbrant: the automatic reviewer bot doesn't seem to be working [19:39:44] dbrant: done [19:39:57] YuviPanda: on it... [19:40:12] dbrant: also the search box in gerrit.wikimedia.org has a rather powerful query language you can use. project:apps/android/wikipedia status:open should give you all open patches, for example [19:40:27] (03PS5) 10Jdlrobson: Hygiene: Standardise on our icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [19:40:29] (03PS4) 10Jdlrobson: Hygiene: Introduce is-border-box class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129084 [19:40:31] (03PS2) 10Jdlrobson: Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 [19:40:33] (03PS2) 10Jdlrobson: Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 [19:40:46] (03PS2) 10Mhurd: Launch icon set. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129343 [19:41:05] (03CR) 10Dbrant: [C: 032] Amend crash report dialog text to be less cute [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129380 (owner: 10Yuvipanda) [19:41:30] brion: i updated the icon set patch to turn off the glossy effect stuff [19:41:57] (03CR) 10jenkins-bot: [V: 04-1] Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 (owner: 10Jdlrobson) [19:42:06] dbrant: so, gerrit has 'dependent commits'. a commit can't be merged until all its dependent commits are merged. [19:44:09] (03CR) 10Dbrant: [C: 032] Update icon to latest version [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129310 (owner: 10Yuvipanda) [19:44:14] (03CR) 10Jdlrobson: [C: 04-1] "Seems to break when editing a page." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 (owner: 10Jdlrobson) [19:45:01] (03PS4) 10Kaldari: Improve error reporting for image uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 [19:45:03] (03CR) 10Dbrant: [C: 032] Make Crash reporter use Holo theme [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129311 (owner: 10Yuvipanda) [19:45:50] (03CR) 10Dbrant: [C: 032] Fix crash when number of sections change between edits [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129378 (owner: 10Yuvipanda) [19:46:11] 3Wikipedia App / 3Generic: Editing a section newly added from another device crashes the app - 10https://bugzilla.wikimedia.org/64282#c2 (10Gerrit Notification Bot) Change 129378 merged by Dbrant: Fix crash when number of sections change between edits https://gerrit.wikimedia.org/r/129378 [19:47:13] 3MobileFrontend / 3stable: "Desktop" link on history view points to article view - 10https://bugzilla.wikimedia.org/64383 (10Liangent) 3NEW p:3Unprio s:3normal a:3None On http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:History/San_Francisco at the bottom, the "Desktop" link points to http://en.wi... [19:47:15] jdlrobson: I'm gonna run get some lunch now [19:47:26] kaldari: k [19:50:26] 3MobileFrontend / 3stable: "Desktop" link on history view points to article view - 10https://bugzilla.wikimedia.org/64383#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1965 [19:55:28] 3Wikipedia App / 3Generic: Following a link pointing to http://en.wikipedia.org/wiki/ crashes the app - 10https://bugzilla.wikimedia.org/64384 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Not sure whether this is the same as bug 63965. [19:58:13] 3Wikipedia App / 3Generic: Support interwiki prefixes in search - 10https://bugzilla.wikimedia.org/64387 (10Liangent) 3NEW p:3Unprio s:3enhanc a:3None When I type "de:foobar" when my language is set to English, it could be nice to open page "foobar" in German. [20:01:12] 3Wikipedia App / 3Generic: Viewing the file description page displays a double header - 10https://bugzilla.wikimedia.org/63292 (10Kunal Mehta (Legoktm)) 5RES/?>3VER [20:01:29] (03CR) 10Brion VIBBER: "I can see the change in the info.plist but it doesn't seem to remove the glossy effect either on simulator or device..." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129343 (owner: 10Mhurd) [20:02:26] 3Wikipedia App / 3Generic: Following a link pointing to http://en.wikipedia.org/wiki/ crashes the app - 10https://bugzilla.wikimedia.org/64384#c1 (10Yuvi Panda) Nah, different. This is because it tries to parse the title and fails miserably. Maybe I should treat empty titles the equivalent of Main page [20:02:26] brion: oh, sometimes you have to delete app and do clean build, delete derived data from organizer too for good measure :) [20:02:36] bah [20:02:37] :D [20:04:39] mhurd: is it working for you ? deleting and removing derived data not having any effect so far [20:04:48] brion: checking... [20:05:06] brion: was it on ios6 you’re seeing it? [20:05:11] yeah [20:05:14] 7 doesn’t do glossy [20:05:16] brion: k [20:05:32] YuviPanda: hi [20:05:39] hi liangent! [20:05:49] brion: mhurd liangent has been uncovering lots of bugs in the app and reporting them :) [20:05:56] awesome [20:05:58] dbrant: ^ [20:06:02] liangent: woohoo! thanks! [20:06:05] liangent: dbrant is the new Android engineer on the team :) [20:06:06] good! [20:06:29] brion: aw crap… glossy mess :( [20:06:35] brion: prodding... [20:06:37] :( [20:07:18] mhurd: http://stackoverflow.com/questions/18800087/icon-already-includes-gloss-effects-doesnt-work-on-ios-6-compiled-on-xcode-5/18931407#18931407 may help [20:07:39] brion: ah! [20:08:01] \o/ [20:08:27] brion: it works! [20:08:39] woot [20:08:45] (03PS3) 10Mhurd: Launch icon set. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129343 [20:08:48] brion: ^ [20:10:18] (03CR) 10Brion VIBBER: [C: 032 V: 032] "lookin' awesome now :D" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129343 (owner: 10Mhurd) [20:10:22] brion: yay! [20:10:44] liangent: the bug with sections crashing should be fixed in the next build that's gonna go out soon [20:11:02] (03CR) 10Brion VIBBER: [C: 032 V: 032] Added missing "the" to license copy. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129386 (owner: 10Mhurd) [20:14:14] (03CR) 10Brion VIBBER: [C: 032 V: 032] "yum, icon fonts! for reference, it may be better to use the code points \u0123 or whatever instead of pasting raw characters, since they w" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129385 (owner: 10Mhurd) [20:14:25] brion: good point [20:17:12] YuviPanda: soon? it's just 3 days after the previous release [20:17:34] liangent: should be out in a few hours. I try to push out as much as possible [20:20:28] 3Wikipedia App / 3Generic: iOS app: Clicking on an image in an article no longer goes to file description page - 10https://bugzilla.wikimedia.org/64389 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3minor a:3None Prior to alpha #12 (I think it worked in #11), if you clicked on an image, you'd go to the... [20:24:41] 3MobileFrontend / 3stable: mobileaction parameter causes all other parameters to be lost in redirect - 10https://bugzilla.wikimedia.org/64318#c3 (10Jon) 5RES/DUP>3REO This doesn't look fixed to me. [20:26:04] brb errands [20:27:28] 3Wikipedia App / 3Generic: iOS app: Credits screen needs improvement - 10https://bugzilla.wikimedia.org/64391 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Created attachment 15205 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15205&action=edit Current iOS credits pane The Cred... [20:27:46] (03PS3) 10Jdlrobson: Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 [20:27:48] (03PS3) 10Jdlrobson: Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 [20:27:57] 3Wikipedia App / 3Generic: iOS app: Credits screen needs improvement - 10https://bugzilla.wikimedia.org/64391#c1 (10Kunal Mehta (Legoktm)) Created attachment 15206 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15206&action=edit Commons app credits pane [20:30:17] (03PS3) 10Jdlrobson: Fix talk overlay for new pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129358 [20:30:55] (03PS5) 10Jdlrobson: Hygiene: Introduce is-border-box class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129084 [20:31:08] (03PS6) 10Jdlrobson: Hygiene: Standardise on our icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [20:32:09] (03PS4) 10Jdlrobson: Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 [20:34:47] (03CR) 10JGonera: [C: 04-1] "I don't think this approach is good because it break the consistency of "stage" being always the first part and "type" being always the se" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 (owner: 10Kaldari) [20:35:35] (03CR) 10jenkins-bot: [V: 04-1] Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (owner: 10Jdlrobson) [20:38:28] 3MobileFrontend / 3Hygiene: MobileOptions checkbox toggles should be refactored and put in mediawiki.ui - 10https://bugzilla.wikimedia.org/64313 (10Jon) a:3Jon [20:38:35] YuviPanda: is it better to send feedback to bugzilla or otrs next time? [20:38:57] most of replies I got are from bugzilla... [20:40:00] (03CR) 10JGonera: [C: 032] Fix talk overlay for new pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129358 (owner: 10Jdlrobson) [20:40:08] liangent: yeah, if you can bz you should bz [20:40:33] (03Merged) 10jenkins-bot: Fix talk overlay for new pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129358 (owner: 10Jdlrobson) [20:44:34] YuviPanda: but usually I don't bother to get a backtrace somehow to attach when using bz... [20:45:01] liangent: yeah, I usually try to respond to bugs that I don't know yet on OTRS. [20:45:08] liangent: these I just haven't gotten around to yet. [20:45:49] (03CR) 10JGonera: [C: 04-1] "Breaks layout in user profiles + inline comment." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129084 (owner: 10Jdlrobson) [20:53:03] (03PS6) 10Jdlrobson: Hygiene: Introduce border-box class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129084 [20:56:35] (03PS7) 10Jdlrobson: Hygiene: Standardise on our icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [20:56:37] (03CR) 10JGonera: [C: 04-1] Hygiene: Standardise on our icons (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [20:58:03] any redesign plan of the new icon? [20:58:11] it looks ugly in a white background [20:58:27] liangent: yeah, we put up a little more things around it and it looks ok now [20:58:35] liangent: I'm pusing a release out now, should have the new icon [20:59:43] (03PS2) 10Brion VIBBER: Work in progress: data migration from old app [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129307 [20:59:50] rebasing whee [21:00:07] YuviPanda: haven't appeared yet. tell me when it's done :) [21:00:10] (03PS1) 10Yuvipanda: Bump version for release 2.0-alpha-2014-04-24 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129576 [21:07:58] 3Wikipedia App / 3Generic: iOS app: Missing home / go to Main Page button - 10https://bugzilla.wikimedia.org/64394 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None There's no button in the menu to take the user back to the Main Page. In the web interface, it's labeled "Home". [21:10:30] jgonera: head's up in case you haven't seen this: https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/404/testReport/junit/(root)/Image%20uploads%20copyvio%20notice/Opening_upload_preview_and_confirming__image_without_EXIF_/ [21:12:29] 3Wikipedia App / 3Generic: Android app: Missing home / go to Main Page button - 10https://bugzilla.wikimedia.org/64395 (10Liangent) 3NEW p:3Unprio s:3normal a:3None +++ This bug was initially created as a clone of Bug #64394 +++ There's no button in the menu to take the user back to the Main Page. I... [21:12:41] 3Wikipedia App / 3Generic: Android app: Missing home / go to Main Page button - 10https://bugzilla.wikimedia.org/64395 (10Liangent) [21:12:42] 3Wikipedia App / 3Generic: iOS app: Missing home / go to Main Page button - 10https://bugzilla.wikimedia.org/64394 (10Liangent) [21:13:12] ^ ^ [21:13:34] YuviPanda: still not done? [21:13:51] liangent: oh, I pushed it out. takes a hour or two for play to get it through [21:14:05] liangent: I'll email you the apk too. signed with same key [21:14:55] thx [21:16:56] tfinc: just forwarded you a copy [21:21:49] awjr: seems a chrome specific bug - probably worth stopping the test from running there -passes fine on firefox [21:23:59] YuviPanda: how up to date is https://etherpad.wikimedia.org/p/dmitry-onboarding ? i haven't seen a change to it for a while [21:29:11] awjr, do you remember why is there $temporary parameter to MobileContext::toggleView()? [21:29:36] hmm [21:29:41] lemme take a look [21:29:47] it's not used ATM [21:30:10] (03PS1) 10Dr0ptp4kt: Redirect users to upload.wikimedia.org for direct links if okay. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/129578 [21:30:23] brb errands [21:31:23] OuKB: i have no recollection - but i'm not sure i actually added that. i have a really vague recollection of jdlrobson adding something along those lines way back when [21:31:40] git blame is your friend [21:32:14] whatever happens, blame Domas [21:32:20] lol [21:33:58] tfinc: i'm currently using https://bugzilla.wikimedia.org/show_bug.cgi?id=63812 to whet my palate with the app code... [21:34:09] i guess i did add the temporary param OuKB jdlrobson https://gerrit.wikimedia.org/r/#/c/4761/ [21:35:17] i really don't remember the motivation for that and of course i didnt explain it in the commit message [21:36:04] ok, I'll kill it [21:36:06] but i suspect it had something to do either with testing or for third party sites (or local set up) [21:36:08] thanks [21:36:17] but even in the commit in which it was introduced, it wasn't used [21:36:20] maybe it was never used [21:36:24] and i just thought it would be handy [21:36:26] no clue [21:36:28] should be safe to destroy [21:39:36] tfinc: ah, didn't realize I should update that. will do [21:40:33] tfinc: seems pretty accurate now [21:42:56] (03PS5) 10Jdlrobson: Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 [21:42:58] (03PS1) 10Jdlrobson: WIP: Add the cover element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129583 [21:43:08] (03CR) 10Jdlrobson: [C: 04-2] "Experimenting" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129583 (owner: 10Jdlrobson) [21:44:36] (03CR) 10jenkins-bot: [V: 04-1] Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (owner: 10Jdlrobson) [21:45:17] (03PS1) 10Jdlrobson: QA: Stop copyvio test running in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129586 [21:45:18] ^ awjr [21:45:27] (03CR) 10jenkins-bot: [V: 04-1] WIP: Add the cover element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129583 (owner: 10Jdlrobson) [21:45:29] (03PS1) 10MaxSem: Hygiene: remove unused parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129587 [21:47:16] (03CR) 10Jdlrobson: [C: 032] Hygiene: remove unused parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129587 (owner: 10MaxSem) [21:47:43] kaldari: i fixed your issues in https://gerrit.wikimedia.org/r/#/c/129083/ [21:47:43] tfinc: btw i went ahead and created the issue you mentioned the other day against bingle: https://github.com/wikimedia/bingle/issues/30 [21:48:05] jdlrobson: ah cool [21:48:25] jdlrobson: too much of a pita to get it to work with chrome too? [21:48:35] I'll take a look in a minute. I'm doing some deeper troubleshooting on the uploading per jgonera. [21:48:35] awjr: i just want the tests passing for the time being [21:48:40] i'll raise a bug [21:49:09] (03Merged) 10jenkins-bot: Hygiene: remove unused parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129587 (owner: 10MaxSem) [21:49:18] jdlrobson: since jgonera wrote the test, let's give him a chance to either fix it for chrome, or merge your change [21:49:28] awjr: it's unlikely to be fixed today [21:49:38] i'd personally rather have tests passing since this is a false positive [21:49:43] https://bugzilla.wikimedia.org/show_bug.cgi?id=64397 will ensure we get this fixed [21:49:43] 3MobileFrontend / 3Hygiene: Copyvio tests do not work on Chrome - 10https://bugzilla.wikimedia.org/64397 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon See https://wmf.ci.cloudbees.com/job/MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome/404/testReport/junit/(root)/Image%20uploads%20copyvio%20not... [21:49:52] awjr: it's running successfully on firefox [21:49:55] jdlrobson: i leave the call to the tech lead ;) [21:50:02] pffft [21:52:28] 3MobileFrontend / 3Hygiene: Get PHP documentation generating - 10https://bugzilla.wikimedia.org/64398 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon We currently document some of our PHP code but there is no incentive to do this correctly or at all. We should add a command to the Makefile to do this. Proo... [21:52:38] (03Abandoned) 10Jdlrobson: WIP: Generate PHPDoc via Makefile [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/126825 (owner: 10Jdlrobson) [21:52:41] 3Wikipedia App / 3Generic: Android app: Missing home / go to Main Page button - 10https://bugzilla.wikimedia.org/64395#c1 (10Yuvi Panda) Why? [21:53:41] 3Wikipedia App / 3Generic: New icon looks wobbly on light backgrounds - 10https://bugzilla.wikimedia.org/64263#c9 (10Yuvi Panda) 5NEW>3RES/FIX Ok, this looks okay I think. Yay! :) [21:54:26] 3Wikipedia App / 3Generic: An "undefined" appears on zhwiki main page in the app - 10https://bugzilla.wikimedia.org/63963 (10Yuvi Panda) 5PAT>3RES/FIX [21:55:56] 3Wikipedia App / 3Generic: [iOS] On preview app show [EDIT] link and takes me to the api - 10https://bugzilla.wikimedia.org/62571#c1 (10Yuvi Panda) Is this iOS OR Android? This has been fixed in Android for a while. [22:03:04] violetto: have you seen http://tools.wmflabs.org/reasonator/?q=Q42 [22:03:33] (03CR) 10Kaldari: Base api module on mw.Api (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/121532 (owner: 10JGonera) [22:04:38] jgonera: not sure if this is related to the 'undefined/undefined' errors or not^ [22:05:13] (03PS5) 10Jdlrobson: Hygiene: Rewrite things as Overlaynew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129083 [22:05:25] (03PS3) 10Jdlrobson: Rewrite MediaViewer as OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129195 [22:05:31] (03PS4) 10Jdlrobson: Hygiene: Merge Overlay and OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129196 [22:05:36] (03PS4) 10Jdlrobson: Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 [22:05:43] (03PS4) 10Jdlrobson: Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 [22:13:09] jdlrobson: is Juliusz around? [22:14:35] where'd everybody go? :P [22:15:14] i'm here! [22:15:20] but that doesn't help you :( [22:15:31] vbamba: around? [22:15:48] MaxSem: you see juliusz in the office? [22:15:57] yes [22:16:11] jgonera ^^ [22:16:23] kaldari: ^^ [22:16:47] awjr, I was talking to Trevor [22:16:53] no problem :) [22:17:16] no worries jgonera, just helping kaldari track you down :) [22:17:27] just wanted you to take a look at https://gerrit.wikimedia.org/r/#/c/121532/4/javascripts/common/api.js [22:17:43] kaldari, what browser? [22:17:51] firefox or chrome [22:17:57] did you update core? [22:18:21] you need to have https://gerrit.wikimedia.org/r/#/c/116037/ [22:18:25] ah [22:18:29] lemme do that [22:18:34] sorry [22:19:22] does it work now? [22:20:09] one sec… still pulling [22:20:40] awjr, kaldari what's wrong with the test? [22:20:49] ok, found the link [22:21:06] jgonera: you talking about the upload/exif test? [22:21:10] yes [22:21:19] but I got it [22:21:24] jgonera: jdlrobson said it's just broken for chrome but seems to be fine for firefox [22:21:36] jgonera: jdlrobson submitted a patch to disable the test in chrome for now [22:21:39] definitely works for me in Firefo [22:21:47] jgonera: https://gerrit.wikimedia.org/r/#/c/129586/1 [22:21:49] haven't tested in Chrome [22:22:06] man gerrit is being slow! [22:22:29] or maybe I'm just trying to use the internet in the jungle :P [22:22:48] lulz [22:22:55] YuviPanda: was in a meeting, i didn't see it until right now [22:23:02] what is that [22:23:21] vbamba: it's a nicer wikidata display system [22:23:23] awjr: and there's no one around to swordfight in the meantime :( [22:23:43] 3MobileFrontend / 3stable: Upload workflow broken on Uploads page for second upload - 10https://bugzilla.wikimedia.org/64400 (10Jon) 3NEW p:3Unprio s:3normal a:3None In stable... go to uploads page. Upload an image. Now click the upload button again. Nothing happens. Click back button. Get Cancel upl... [22:24:37] kaldari: :'( [22:25:06] violetto: also alpha / beta icons? [22:25:09] * YuviPanda pokes vbamba again [22:25:13] 3Wikipedia App / 3Generic: Save button should be disabled before content is loaded - 10https://bugzilla.wikimedia.org/64401 (10Liangent) 3NEW p:3Unprio s:3normal a:3None or a blank textbox is submitted. [22:25:26] 3MobileFrontend / 3stable: Upload workflow broken on Uploads page for second upload - 10https://bugzilla.wikimedia.org/64400#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1966 [22:25:42] Receiving objects: 93% ... [22:25:59] YuviPanda: it's already on trello board [22:26:08] violetto: oh. i didn't notice :| [22:26:36] Receiving objects: 99% [22:26:47] finally! [22:26:52] violetto: which color is alpha and which is beta? [22:27:13] alpha is orange beta is blue [22:27:14] violetto: ok, blue is beta? [22:27:20] YuviPanda: yup [22:27:36] violetto: cool [22:27:54] violetto: the shadow levels on them are different. is that intentional? [22:28:06] violetto: blue has deeper shadow than orange. [22:28:10] jgonera: works great now. Thanks! [22:28:43] 3Wikipedia App / 3Generic: Press save button continuously (read as "crazily") crashes the app - 10https://bugzilla.wikimedia.org/64402 (10Liangent) 3NEW p:3Unprio s:3normal a:3None java.lang.NullPointerException at org.wikipedia.editing.EditPreviewFragment.displayPreview(EditPreviewFragment.java:... [22:29:39] YuviPanda: i'll check in a bit [22:29:43] violetto: ok! [22:29:48] (03PS5) 10Kaldari: Improve error reporting for image uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 [22:30:21] (03CR) 10jenkins-bot: [V: 04-1] Improve error reporting for image uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 (owner: 10Kaldari) [22:31:48] (03PS6) 10Kaldari: Improve error reporting for image uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 [22:33:17] (03PS1) 10Yuvipanda: Don't enable 'save' button until wikitext is loaded [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129597 [22:33:26] 3Wikipedia App / 3Generic: Save button should be disabled before content is loaded - 10https://bugzilla.wikimedia.org/64401#c1 (10Gerrit Notification Bot) Change 129597 had a related patch set uploaded by Yuvipanda: Don't enable 'save' button until wikitext is loaded https://gerrit.wikimedia.org/r/129597 [22:36:10] (03PS1) 10JGonera: Fix failing photo copyvio browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129599 [22:36:25] awjr, kaldari, jdlrobson ^ [22:40:01] (03PS1) 10Yuvipanda: Fix language links filter styling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129600 [22:40:11] 3Wikipedia App / 3Generic: Search field too small of a target - 10https://bugzilla.wikimedia.org/64342#c1 (10Gerrit Notification Bot) Change 129600 had a related patch set uploaded by Yuvipanda: Fix language links filter styling https://gerrit.wikimedia.org/r/129600 [22:47:47] (03PS2) 10Jdlrobson: QA: Fix failing photo copyvio browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129599 (owner: 10JGonera) [22:47:56] 3Wikipedia App / 3Generic: Support interwiki prefixes in search - 10https://bugzilla.wikimedia.org/64387#c1 (10Yuvi Panda) Hmm, so I can hack this by checking all pages for a prefix that is : but that sounds very hacky. [22:49:35] (03CR) 10Jdlrobson: [C: 032] QA: Fix failing photo copyvio browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129599 (owner: 10JGonera) [22:49:43] 3Wikipedia App / 3Generic: Editing a protected page using an unprivileged account crashes the app - 10https://bugzilla.wikimedia.org/64405 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Editing a titleblacklist-protected title worths trying. [22:50:02] (03Abandoned) 10Jdlrobson: QA: Stop copyvio test running in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129586 (owner: 10Jdlrobson) [22:50:43] (03Merged) 10jenkins-bot: QA: Fix failing photo copyvio browser test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129599 (owner: 10JGonera) [22:50:56] 3MobileFrontend / 3Hygiene: Copyvio tests do not work on Chrome - 10https://bugzilla.wikimedia.org/64397#c1 (10Jon) 5NEW>3RES/FIX Hopefully fixed by https://gerrit.wikimedia.org/r/129599 [22:52:36] (03PS4) 10Jdlrobson: QA: Add browser tests for presence of more link on history page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127185 [22:53:53] kaity|away: are you there? [22:53:56] moizsyed: or you? [22:54:03] sup? [22:54:12] https://bugzilla.wikimedia.org/show_bug.cgi?id=64108 < this bug [22:54:19] what should i do about it moizsyed ? [22:54:37] any ideas? [22:54:40] taking a look [22:54:43] would hiding it be an okay solution? [22:55:39] which footer is this [22:55:43] can i see a screenshot [22:55:45] or a link [22:59:11] 3Wikipedia App / 3Generic: Editing a protected page using an unprivileged account crashes the app - 10https://bugzilla.wikimedia.org/64405#c1 (10Liangent) Also happens when the user is blocked [22:59:37] (03PS1) 10Yuvipanda: Handle spamblacklist responses appropriately [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129603 [22:59:56] 3Wikipedia App / 3Generic: Triggering spam blacklist during edit crashes the app - 10https://bugzilla.wikimedia.org/64404#c1 (10Gerrit Notification Bot) Change 129603 had a related patch set uploaded by Yuvipanda: Handle spamblacklist responses appropriately https://gerrit.wikimedia.org/r/129603 [23:00:25] be back in a minute... [23:01:11] 3Wikipedia App / 3Generic: Editing a saved page crashes the app - 10https://bugzilla.wikimedia.org/64403#c1 (10Yuvi Panda) Should probably just disable editing completely on saved pages. Saved pages are a terrible terrible feature. Should die in a fire sometime. [23:01:30] YuviPanda: fixed! [23:05:00] (03PS1) 10Cmcmahon: QA: don't sleep, wait. updated FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129605 [23:13:45] (03PS1) 10Yuvipanda: Don't store user info if it was not a successful login [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129608 [23:13:50] (03PS1) 10Yuvipanda: Minor style fixes for filter edittext in language prefs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129609 [23:13:56] 3Wikipedia App / 3Generic: Username in a failed login is still remembered and shown at the top of the left panel - 10https://bugzilla.wikimedia.org/64407#c1 (10Gerrit Notification Bot) Change 129608 had a related patch set uploaded by Yuvipanda: Don't store user info if it was not a successful login https:/... [23:14:30] sorry moizsyed was talking to jimmy [23:14:38] image is on the bug - https://bug-attachment.wikimedia.org/attachment.cgi?id=15137 [23:14:56] 3Wikipedia App / 3Generic: It is useless to ask user to repeat password if the first password is already shown in plain text - 10https://bugzilla.wikimedia.org/64408#c1 (10Yuvi Panda) I kinda agree. Adding designers in cc. [23:16:40] violetto: see https://bugzilla.wikimedia.org/show_bug.cgi?id=64408 [23:19:56] 3Wikipedia App / 3Generic: It is useless to ask user to repeat password if the first password is already shown in plain text - 10https://bugzilla.wikimedia.org/64408#c2 (10Liangent) Just a note that it's in the registration interface. [23:22:13] 3Wikipedia App / 3Generic: Registration using a username containing a hash "#" succeed, and any character after the hash is ignored - 10https://bugzilla.wikimedia.org/64409 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Afterwards it trys to autologin using the username with hash then fails. [23:26:41] 3Wikipedia App / 3Generic: It is useless to ask user to repeat password if the first password is already shown in plain text - 10https://bugzilla.wikimedia.org/64408#c3 (10May) I agree since repeating password is just to make sure you did not mistype. But are we showing passwords in plain text anywhere? Or d... [23:28:57] 3Wikipedia App / 3Generic: It is useless to ask user to repeat password if the first password is already shown in plain text - 10https://bugzilla.wikimedia.org/64408#c4 (10Liangent) (In reply to May from comment #3) > Or did you mean after a > user turns on the "show password" icon? yeah [23:32:18] (03PS1) 10MaxSem: Preserve URL parameters when toggling view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129612 [23:32:52] (03CR) 10jenkins-bot: [V: 04-1] Preserve URL parameters when toggling view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129612 (owner: 10MaxSem) [23:33:03] fuck you jerkins [23:34:56] (03PS2) 10MaxSem: Preserve URL parameters when toggling view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129612 [23:36:12] mhurd: I fixed the spamblacklist [23:36:33] YuviPanda: you! you should be fixing sleep :) [23:36:48] YuviPanda: also, awesome! [23:36:52] mhurd: yeah, a lot of bugs came in from liangent and I was just fixing them as I went. [23:39:13] YuviPanda: ok I stopped .. waiting for you to clear backlog [23:39:48] liangent: nah, keep going. The account creation stuff I'm fixing now. [23:42:05] YuviPanda: well there's no more bugs I can find now [23:42:15] liangent: woo! that's... good? :) [23:42:42] liangent: the user editing crashing bugs are kinda dependent on https://gerrit.wikimedia.org/r/#/c/109939/ [23:42:48] liangent: although I guess I shouldn't crash either way [23:45:52] YuviPanda: hm if you depend on that fix you'll still crash when a sysop protects the page in meantime [23:46:40] liangent: yeah, so I've to do this anyway (hence the 'kinda dependent') but would be nice to not let people go that far [23:47:25] YuviPanda: another thing, what if a page is deleted after user started browsing or editing? [23:48:38] liangent: would crash, I think. [23:49:11] or in the case of editing, does the app recreate the page? [23:49:43] YuviPanda: ^ [23:50:11] liangent: I don't know yet. Haven't tried [23:52:47] liangent: attempting to create a user account with a '#' just gives me a 'can not create account' [23:53:12] YuviPanda: in app? [23:53:16] liangent: yeah. [23:53:37] liangent: it gave me a 'createaccount-hook-aborted' error [23:53:48] so I guess that's the serverside API telling me to get lost [23:54:00] liangent: is there a place online where the allowed username ranges are present? [23:54:20] liangent: I've fixed the issue where Yuvipand is shown as yuvipanda [23:55:30] YuviPanda: I dunno. there's even a $wg to modify the set of disallowed chars [23:55:37] hmm, yeah [23:57:01] YuviPanda: username Liangent-app2#test doesn't this work? [23:57:11] (03PS1) 10Yuvipanda: Use username returned from create account API call [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129618 [23:57:13] liangent: ah, I tried yuvitest5# [23:57:27] 3Wikipedia App / 3Generic: Registration using a username containing a hash "#" succeed, and any character after the hash is ignored - 10https://bugzilla.wikimedia.org/64409#c1 (10Gerrit Notification Bot) Change 129618 had a related patch set uploaded by Yuvipanda: Use username returned from create account AP... [23:57:29] (03PS2) 10Jdlrobson: WIP Experiment: Ajax login form on HTTPS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129480 [23:58:00] liangent: yuvitest4#yr also gave me a 'cannot create account' [23:58:09] (03CR) 10jenkins-bot: [V: 04-1] WIP Experiment: Ajax login form on HTTPS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129480 (owner: 10Jdlrobson) [23:59:23] liangent: is 'Main page' guaranteed to at least be a redirect to the main page on most wikis? [23:59:29] YuviPanda: yuvitest4foobar#yr [23:59:53] it trys to register yuvitest4 which is occupied