[00:00:29] liangent: ah, hmm. so to me it registered yuvitestfoobar and logged me in appropriately (after the new patch) [00:00:39] liangent: I should do client side validation of the characters, I think [00:01:23] for main page, no [00:01:50] liangent: yeah, probably need a script or somesuch... [00:02:05] zhwiki community doesn't like them and it keeps being deleted as crossnamespace redirect [00:02:59] now main page on zhwiki redirects to an article describing "main page of websites" [00:03:33] maybe you can fetch MediaWiki: mai [00:03:40] (03CR) 10Jdlrobson: [C: 04-1] "Doesnt' seem to work for me in Chrone.." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129605 (owner: 10Cmcmahon) [00:03:49] liangent: yeah, I had a script that did it but now can't find it [00:03:53] mediawiki:mainpage and cache it heavily [00:04:14] YuviPanda: ^ [00:04:29] (03CR) 10Jdlrobson: [C: 04-1] Preserve URL parameters when toggling view (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129612 (owner: 10MaxSem) [00:04:53] liangent: I was going to more just grab them at compile time and bundle them in. We'll update them every release and if a wiki moves them it usually leaves a redirect... [00:05:05] (03CR) 10MaxSem: Preserve URL parameters when toggling view (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129612 (owner: 10MaxSem) [00:05:42] liangent: I'm wondering what the behavior for special pages should be [00:05:59] (03PS3) 10MaxSem: Preserve URL parameters when toggling view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129612 [00:06:11] 3MobileFrontend / 3stable: mobileaction parameter causes all other parameters to be lost in redirect - 10https://bugzilla.wikimedia.org/64318#c4 (10Gerrit Notification Bot) Change 129612 had a related patch set uploaded by MaxSem: Preserve URL parameters when toggling view https://gerrit.wikimedia.org/r/129... [00:06:15] Hmm when zhwiki's main page got moved to Wikipedia namespace, its original title was rewritten to an article at the same time.. [00:06:50] liangent: maybe having the app do things like this will make them re-consider :) [00:07:22] YuviPanda: shown as transclued view? [00:07:40] liangent: hmm? [00:08:08] show the special page as if it's transcluded [00:08:35] {{special:something}} you know this? [00:08:44] liangent: aaah. yeah. [00:08:55] liangent: hmm, but then the actions won't really work in the app [00:09:00] I can't think of a better way to handle them [00:09:10] liangent: I am probably going to figure a way out to pop them back to the browser [00:09:26] (03CR) 10Jdlrobson: [C: 032] "WFM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 (owner: 10Kaldari) [00:09:29] liangent: there's no way to exclude these [00:09:45] action specials are usually not transcludable [00:09:57] liangent: the new icon should also be better looking in white backgrounds [00:09:58] (03Merged) 10jenkins-bot: Improve error reporting for image uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129492 (owner: 10Kaldari) [00:10:11] right [00:10:11] 3MobileFrontend / 3stable: some upload errors reporting undefined/undefined as error text - 10https://bugzilla.wikimedia.org/64213#c3 (10Gerrit Notification Bot) Change 129492 merged by jenkins-bot: Improve error reporting for image uploads https://gerrit.wikimedia.org/r/129492 [00:10:25] and what's "exclude them"? [00:10:38] liangent: exclude Special pages from opening in the app [00:10:53] liangent: like, if you go to mobile web and tap something (like Special:Nearby) it tries to open it in the app or even crashes [00:12:00] is it possible to embed a webview control? [00:12:18] liangent: it is, but then login etc inside that is a problem [00:12:33] liangent: that might end up being the long term solution, though. Once I figure a way out to log you in. [00:12:44] can you assign cookies to the webview then? [00:12:47] liangent: hmm, perhaps if I share auth cookies with the webview it'll act logge din [00:12:48] liangent: yeah [00:13:22] liangent: but then, how do you go back into the app? I'll have to find some way to capture regular links, etc, back into the app [00:13:48] liangent: ok, I'll think about it. Now off to sleep. it's almost 6 AM :| [00:13:51] but be careful if user accesses special:logout :p [00:14:02] * prtksxna kicks YuviPanda  [00:14:08] liangent: haha :D [00:14:14] liangent: yeah, it's a land full of mines [00:14:16] landmines [00:14:22] I'll have to tread carefully [00:14:25] I'm out now. night [00:14:44] prtksxna: BE HAPPY. I AM SLEEPING. [00:14:52] * prtksxna is happy [00:15:41] (03CR) 10Jdlrobson: [C: 031] "Arthur can you take a look?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129612 (owner: 10MaxSem) [00:38:37] (03PS8) 10Jdlrobson: WIP Hygiene: Standardise on our icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [01:21:59] (03PS1) 10Dbrant: Navigation pull-out menu no longer occludes Search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129632 [01:22:12] 3Wikipedia App / 3Generic: The search bar shouldn't be covered by the left panel - 10https://bugzilla.wikimedia.org/63812#c1 (10Gerrit Notification Bot) Change 129632 had a related patch set uploaded by Dbrant: Navigation pull-out menu no longer occludes Search bar. https://gerrit.wikimedia.org/r/129632 [01:52:28] (03CR) 10Dbrant: [C: 032] Bump version for release 2.0-alpha-2014-04-24 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129576 (owner: 10Yuvipanda) [01:53:22] (03CR) 10Dbrant: [C: 032] Don't enable 'save' button until wikitext is loaded [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129597 (owner: 10Yuvipanda) [01:53:41] 3Wikipedia App / 3Generic: Save button should be disabled before content is loaded - 10https://bugzilla.wikimedia.org/64401#c2 (10Gerrit Notification Bot) Change 129597 merged by Dbrant: Don't enable 'save' button until wikitext is loaded https://gerrit.wikimedia.org/r/129597 [01:54:43] (03CR) 10Dbrant: [C: 032] Fix language links filter styling [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129600 (owner: 10Yuvipanda) [01:54:56] 3Wikipedia App / 3Generic: Search field too small of a target - 10https://bugzilla.wikimedia.org/64342#c2 (10Gerrit Notification Bot) Change 129600 merged by Dbrant: Fix language links filter styling https://gerrit.wikimedia.org/r/129600 [01:56:46] (03CR) 10Dbrant: [C: 032] Handle spamblacklist responses appropriately [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129603 (owner: 10Yuvipanda) [01:56:57] 3Wikipedia App / 3Generic: Triggering spam blacklist during edit crashes the app - 10https://bugzilla.wikimedia.org/64404#c2 (10Gerrit Notification Bot) Change 129603 merged by Dbrant: Handle spamblacklist responses appropriately https://gerrit.wikimedia.org/r/129603 [01:57:53] (03CR) 10Dbrant: [C: 032] Don't store user info if it was not a successful login [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129608 (owner: 10Yuvipanda) [01:58:11] 3Wikipedia App / 3Generic: Username in a failed login is still remembered and shown at the top of the left panel - 10https://bugzilla.wikimedia.org/64407#c2 (10Gerrit Notification Bot) Change 129608 merged by Dbrant: Don't store user info if it was not a successful login https://gerrit.wikimedia.org/r/129608 [01:59:30] (03CR) 10Dbrant: [C: 032] Minor style fixes for filter edittext in language prefs [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129609 (owner: 10Yuvipanda) [02:01:40] (03CR) 10Dbrant: [C: 032] Use username returned from create account API call [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129618 (owner: 10Yuvipanda) [02:01:57] 3Wikipedia App / 3Generic: Registration using a username containing a hash "#" succeed, and any character after the hash is ignored - 10https://bugzilla.wikimedia.org/64409#c2 (10Gerrit Notification Bot) Change 129618 merged by Dbrant: Use username returned from create account API call https://gerrit.wikime... [02:53:29] (03PS2) 10Dbrant: Navigation pull-out menu no longer occludes Search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129632 [02:53:31] (03PS1) 10Dbrant: Proper Back button functionality when no article is loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129633 [07:27:14] 3MobileFrontend / 3General/Unknown: mobile response: Error, edit not saved - 10https://bugzilla.wikimedia.org/64416 (10John Mark Vandenberg) 3NEW p:3Unprio s:3normal a:3None After trying to edit a page, after a very long delay from reading the same page, the error "Error, edit not saved" occurs and t... [07:30:26] 3MobileFrontend / 3General/Unknown: mobile response: Error, edit not saved - 10https://bugzilla.wikimedia.org/64416#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1967 [08:22:20] (03PS1) 10Mhurd: Fix for crash if no login token retrieved. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129643 [08:35:58] 3Wikipedia App / 3Generic: Clicking a link in edit preview crashes the app - 10https://bugzilla.wikimedia.org/64418 (10Liangent) 3NEW p:3Unprio s:3normal a:3None After it recovered from crash (by clicking cancel in the dialog for example), clicking edit crashes it again. [08:39:58] 3Wikipedia App / 3Generic: Placeholders should be created for images before they're loaded - 10https://bugzilla.wikimedia.org/64419 (10Liangent) 3NEW p:3Unprio s:3normal a:3None So the page doesn't jump when images are being loaded. [08:47:13] 3Wikipedia App / 3Generic: RTL support in the app - 10https://bugzilla.wikimedia.org/64420 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Previously I thought there must already be a bug... but I can't find it now? RTL attribute must not be configured per site. Because of content handler and language... [08:53:13] 3Wikipedia App / 3Generic: In settings / language, clicking OK without selecting an item crashes the app - 10https://bugzilla.wikimedia.org/64422 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Select the last item in the original list first, input en in the input box, then click ok. The case that a f... [09:02:13] 3Wikipedia App / 3Generic: Clicking on red links crash the app - 10https://bugzilla.wikimedia.org/64423 (10Liangent) 3NEW p:3Unprio s:3normal a:3None On page https://zh-classical.wikipedia.org/wiki/%E9%9B%BB%E6%BC%BF android.content.ActivityNotFoundException: No Activity found to handle Intent { act... [09:02:41] 3Wikipedia App / 3Generic: Clicking on red links crashes the app - 10https://bugzilla.wikimedia.org/64423 (10Liangent) [09:20:43] 3Wikipedia App / 3Generic: Following a link which can't be handled on the device crashes the app - 10https://bugzilla.wikimedia.org/64424 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Try a worldwind:// link for example. [09:36:44] 3Wikipedia App / 3Generic: Various links on image page crash the app - 10https://bugzilla.wikimedia.org/64425 (10Liangent) 3NEW p:3Unprio s:3normal a:3None And the page itself isn't very usable. [09:40:56] 3Wikipedia App / 3Generic: The search bar shouldn't be covered by the left panel - 10https://bugzilla.wikimedia.org/63812#c2 (10Liangent) (In reply to Gerrit Notification Bot from comment #1) > Change 129632 had a related patch set uploaded by Dbrant: > Navigation pull-out menu no longer occludes Search bar.... [09:41:41] 3Wikipedia App / 3Generic: The search bar shouldn't be covered by drawers - 10https://bugzilla.wikimedia.org/63812 (10Liangent) [09:52:43] Dbrant: talking to me? [10:19:06] (03CR) 10Siebrand: "i18n/L10n issues inline." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129603 (owner: 10Yuvipanda) [11:22:41] 3Wikipedia App / 3Generic: Registration using a username containing a hash "#" succeed, and any character after the hash is ignored - 10https://bugzilla.wikimedia.org/64409#c3 (10Liangent) I'm not sure whether it's good to truncate their user name silently, but it's the behavior on desktop too... [12:18:56] (03PS1) 10Amire80: Remove spurious whitespace in the spamblacklist string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129677 [12:21:45] zz_yuvipanda: https://gerrit.wikimedia.org/r/129677 [13:03:11] 3Wikipedia App / 3Generic: RTL support in the app - 10https://bugzilla.wikimedia.org/64420 (10Sam Reed (reedy)) [13:05:57] 3Wikipedia App / 3Generic: Show canonical user name instead of user's raw input - 10https://bugzilla.wikimedia.org/64412 (10Sam Reed (reedy)) s:5normal>3enhanc [13:09:41] 3MobileFrontend / 3Hygiene: Get PHP documentation generating - 10https://bugzilla.wikimedia.org/64398 (10Sam Reed (reedy)) p:5Unprio>3Normal s:5normal>3enhanc [13:47:40] (03CR) 10Dbrant: "Missing class" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129603 (owner: 10Yuvipanda) [14:04:56] hey dbrant! [14:05:09] yuvipanda: hey! [14:05:11] (03CR) 10Yuvipanda: [C: 032] Remove spurious whitespace in the spamblacklist string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129677 (owner: 10Amire80) [14:05:21] dbrant: saw your email. I missed doing a git add on it I think. [14:05:24] dbrant: I'll submit a new patch [14:05:39] (03Merged) 10jenkins-bot: Remove spurious whitespace in the spamblacklist string [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129677 (owner: 10Amire80) [14:06:11] yuvipanda: I added a "comment" in gerrit, too. (didn't realise I could do that) [14:06:21] dbrant: so when we do CR we usually also download the patchset and test that it works as it is supposed to, and -1 it if it has issues. So it isn't just verifying code quality but also making sure that it works as it should. [14:06:40] dbrant: ah! yeah. You can also give it a CR-1 for things that need improving and a CR-2 for things that need complete rewrites [14:07:14] yuvipanda: so how come jenkins didn't complain about it? [14:07:38] dbrant: ah, so that I need to fix. Jenkins doesn't build it yet. Just does checkstyle [14:07:46] yuvipanda: i see! [14:07:48] dbrant: because our jenkins machines don't have the android libraries on them. [14:08:24] dbrant: I'll try to get that sorted next week. There's a patch in progress for it somewhere [14:09:09] dbrant: also in the commit message, you can add a 'Bug: ' and gerrit will automatically link to the bug [14:09:21] dbrant: so we should do it when we are making a commit specifically to deal with a bug [14:10:11] yuvipanda: yep, I did that for the patch I submitted yesterday [14:10:26] dbrant: ah, cool. just saw that [14:10:40] yuvipanda: this is a very well-oiled system, so far [14:10:52] dbrant: gerrit or the code? :D [14:11:34] yuvipanda: the patch/integration/review process [14:11:47] dbrant: yeah! it's been refined over a year or so now, and is pretty neat [14:19:24] dbrant: so I'll try to get jenkins to actually *build* it. should help catch these things [14:20:29] yuvipanda: ok! and I'll get in the habit of physically testing the code for review. [14:22:27] dbrant: cool! I test on a N4 mostly. [14:23:18] dbrant: and also there's no rush to merge things mostly. we'd rather redo things and land a day or two later than merge RIGHT NOW. [14:23:31] yuvipanda: I have a Galaxy S III, and several others [14:23:34] dbrant: ah cool! [14:23:56] dbrant: our Java checkstyle errors are also non-zero. Need to fix those up at some point as well. [14:24:49] (03PS1) 10Yuvipanda: Add missing CreateAccountSuccessResult [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129689 [14:25:40] dbrant: the missing file! ^ [14:25:45] dbrant: I"ll CR your two patches in a momen5 [14:25:46] t [14:29:05] yuvipanda: how about SpamBlacklistEditResult? [14:32:28] (03PS1) 10Yuvipanda: Add another missing file [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129690 [14:32:29] dbrant: oh that push failed. coming through now [14:32:31] dbrant: ther [15:01:26] aharoni: thanks for the aptch :D [15:01:27] *patch [15:01:33] you're welcome [15:01:41] aharoni: I need to setup a jenkins job that'll prevent merges if there's no qq [15:02:26] I am aharoni the obsessed translator who checks translatewiki several times a day to find whether such problems slipped through siebrand and raimond :) [15:02:48] aharoni: :D [15:02:56] aharoni: there's missing qq for several strings I need to add :( [15:18:41] 3MobileFrontend / 3General/Unknown: mobile response: Error, edit not saved - 10https://bugzilla.wikimedia.org/64416#c2 (10Jon) Thanks a bunch for this report. I suspect this is due to our token handling. Will dig deeper and get to bottom of this. [16:08:13] yuvipanda: it's more eager to have jenkins try to build before merge ... [16:08:17] https://gerrit.wikimedia.org/r/129689 and https://gerrit.wikimedia.org/r/129690 [16:09:05] *urgent [16:12:02] (03CR) 10Dbrant: [C: 032] Add missing CreateAccountSuccessResult [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129689 (owner: 10Yuvipanda) [16:12:18] (03CR) 10Dbrant: [C: 032] Add another missing file [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129690 (owner: 10Yuvipanda) [17:01:56] 3MobileFrontend / 3Feature requests: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c29 (10Steinsplitter) 5NEW>3RES/FIX https://gerrit.wikimedia.org/r/#/c/127179/ [17:04:25] https://gerrit.wikimedia.org/r/#/c/127179/ thank you mobile team! :-) [17:23:53] (03Abandoned) 10Yuvipanda: [WIP] Add bundle output JS for iOS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/118137 (owner: 10Yuvipanda) [17:32:26] 3MobileFrontend / 3General/Unknown: mobile response: Error, edit not saved - 10https://bugzilla.wikimedia.org/64416#c3 (10Max Semenik) (In reply to Jon from comment #2) > Thanks a bunch for this report. I suspect this is due to our token handling. > Will dig deeper and get to bottom of this. At its roots, t... [18:34:34] (03PS9) 10Jdlrobson: Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [18:35:24] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for crash if no login token retrieved. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129643 (owner: 10Mhurd) [18:35:53] (03PS1) 10Mhurd: Variety of small style / UX tweaks from Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129727 [18:35:57] brion: yay! [18:36:10] brion: ^ one more for ya :) [18:36:10] :) [18:36:38] ugh why does mac os x make me choose not to open iphoto for *every phone i ever connect* once [18:36:47] more to the point, why do i have so many damn phones ;) [18:36:53] hehe [18:37:47] i picked up the cheapest-model windows phone device to play with the early-release windows phone 8.1 [18:37:59] they finally mostly merged the windows phone application model with the windows tablet one [18:38:10] dbrant|lunch: back! [18:38:12] so my laptop crashed [18:38:14] and wouldn't start again [18:38:16] white screen of death [18:38:16] brion: it had to happen sooner or later [18:38:17] d’oh [18:38:26] yuvipanda: ouch [18:38:26] and then I found out [18:38:31] that if I unplug my *keyboard* [18:38:32] and restart [18:38:34] it strted back up [18:38:39] and I can plug my keyboard back in again [18:38:42] this was reproducible. [18:38:45] Evil keyboard. [18:38:46] lol [18:38:53] if I turned it off, and tried to turn it back on with the keyboard plugged in, white screen of death [18:38:58] unplug, restart, it's all good [18:38:59] WTF APPLE [18:39:08] yuvipanda: just never type anything [18:39:18] :) [18:39:21] mhurd: it's trying to cure my carpel tunnel [18:39:25] hehe [18:39:26] Typing is overrated. [18:39:27] typing is so outmoded [18:39:28] Wait... [18:39:37] just pick up the mouse and say “computer!” [18:39:44] Deskana: http://www.kinesis-ergo.com/shop/images/1463/advantage-black.jpg/ is my keyboard. definitely looks evil [18:39:45] Your product manager is installing the iOS app. BE AFRAID. [18:39:52] :D [18:40:00] Deskana: you already had the Android app. AM NOT AFRAID! [18:40:03] that keyboard *does* belong in an evil lair [18:40:13] yuvipanda: I wasn't your product manager then. NOW HE SHOULD BE AFRAID. [18:40:19] dont we have like 3 pm’s right now :) [18:40:25] brion: keyboard not elegant enough for apple [18:40:37] Deskana: better? [18:40:47] mhurd: only 2 now, since Maryana is Maryana_lunch [18:40:50] AfraidPanda: Yes. [18:40:53] AfraidPanda: http://www.theonion.com/video/apple-introduces-revolutionary-new-laptop-with-no,14299/ [18:40:53] hehe [18:41:05] Deskanafraid: I was thinking about it early today morning [18:41:15] Deskanafraid: and decided that 'Mr. Garry sir' is a better fit than Garry sir [18:42:02] I would say that it suits your Indian accent... but I think the last time a Briton had that realisation, we colonised India. [18:42:05] So I must be careful. [18:42:06] Deskanafraid: you should consider changing your nick to GarrySir or MrGarrySir :P [18:42:34] Deskanafraid: haha! Are you coming to Zurich? [18:42:46] YuviPanda: Unfortunately not. I applied, but didn't get accepted. [18:42:51] Deskanafraid: :( [18:42:53] Deskanafraid: Wikimania? [18:43:04] YuviPanda: Yeah, that's a definite. [18:43:23] Deskanafraid: coool! So I can go around and call you Sir there :D [18:43:39] Deskanafraid: I'm also spending a week and a half in Glasgow and a few days in London after Zurich [18:44:08] i gotta save my money for post-wikimania, i’m heading straight back after zurich :) [18:44:27] brion: I've a friend to stay with in both cases and I'd still be able to work, so yay [18:44:34] cool! [18:44:44] you international nomad, you [18:45:12] YuviPanda: Glasgow is lovely. It's actually similar in a lot of ways to Manchester. [18:45:19] YuviPanda: Well, definitely more so than London. [18:45:31] Deskana: so I might end up spending a day in Manchester (or Newcastle) as well [18:45:45] Eugh, Newcastle. [18:45:51] YAY MANCHESTER [18:45:55] haha [18:45:58] is that a football thing? [18:46:20] I'll be staying with a friend who I met via Ingress. She's a Londoner who moved to Glasgow like a decade ago. [18:46:21] (03CR) 10Brion VIBBER: "looks good! the arrow icon is clearer than the eye icon too, though i liked the preview idea i'm not sure it was clear. good improvements" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129727 (owner: 10Mhurd) [18:46:52] (03PS6) 10JGonera: Hygiene: Rewrite things as Overlaynew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129083 (owner: 10Jdlrobson) [18:46:54] (03PS5) 10JGonera: Hygiene: Merge Overlay and OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129196 (owner: 10Jdlrobson) [18:46:56] (03PS4) 10JGonera: Rewrite MediaViewer as OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129195 (owner: 10Jdlrobson) [18:47:08] i thought manchester was an industrial hellhole? or am i thinking of liverpool [18:47:19] (03CR) 10JGonera: [C: 032] Hygiene: Merge Overlay and OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129196 (owner: 10Jdlrobson) [18:48:04] brion: That depends. Sounds like you've been listening to some Southern bias to me. :P [18:48:09] (03CR) 10Brion VIBBER: [C: 032 V: 032] Variety of small style / UX tweaks from Vibha. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129727 (owner: 10Mhurd) [18:48:11] hehe [18:48:21] brion: I bet all the popular football club city names are industrial hellholes. Otherwise why would they have to distract themselves in *that* way? :P [18:48:28] lol [18:48:37] YuviPanda: I don't really like football. I just also don't really like Newcastle. :P [18:48:55] Deskana: I learnt recently that Cricket is a 'posh people sport' in the UK. explains so many things... [18:49:22] That's a stereotype... but as with many stereotypes, there's a certain truth to it, yeah. [18:50:23] Deskana: :) [18:51:29] mhurd: And yeah, you do have three PMs right now... but within a few weeks it'll be just one for Apps (me) with Maryana acting as my wisened advisor. :) [18:52:26] Deskana: TIL the difference between wizened and wisened [18:53:32] Right, lunch! [18:54:24] * YuviPanda offers Deskana some tea [18:54:38] (*$&#(*$&#(*&$(*#&$$*#& [18:54:49] ok this patch doesn’t work because i’m checking out in the wrong project [18:54:52] i need more coffee [18:55:07] brion: haha [18:56:53] (03PS3) 10Brion VIBBER: Navigation pull-out menu no longer occludes Search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129632 (owner: 10Dbrant) [18:57:01] rebase [18:59:44] (03CR) 10Brion VIBBER: [C: 032] Navigation pull-out menu no longer occludes Search bar. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129632 (owner: 10Dbrant) [18:59:52] ok jenkins, do your thing [18:59:56] 3Wikipedia App / 3Generic: The search bar shouldn't be covered by drawers - 10https://bugzilla.wikimedia.org/63812#c3 (10Gerrit Notification Bot) Change 129632 merged by Brion VIBBER: Navigation pull-out menu no longer occludes Search bar. https://gerrit.wikimedia.org/r/129632 [19:03:38] (03PS2) 10Yuvipanda: Proper Back button functionality when no article is loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129633 (owner: 10Dbrant) [19:03:52] (03CR) 10Yuvipanda: [C: 032] Proper Back button functionality when no article is loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129633 (owner: 10Dbrant) [19:03:57] yay [19:04:11] (03Merged) 10jenkins-bot: Proper Back button functionality when no article is loaded. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129633 (owner: 10Dbrant) [19:05:16] oh that’s interesting, i just noticed my apps-android-wikipedia is pulled from github rather than gerrit, so its ‘origin’ and ‘gerrit’ can be slightly out of sync. good to notice that [19:07:00] brion: ooh. good catch [19:07:27] when in doubt, ‘git pull gerrit master’ :D [19:08:34] ok gonna grab a bite then back to the migration code… [19:12:52] brion: :D I have that for a lot of repos [19:12:58] brion: I also don't use git-review at all (PoS!) [19:13:04] so my workflow is probably not standard at all [19:13:19] (03PS1) 10Jdlrobson: Hygiene: Kill the confusingly named KeepGoingDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129730 [19:13:27] ^ kaldari_afk ^ :D [19:14:41] awjr: can you take a look at max's patch today? [19:14:49] (link is https://gerrit.wikimedia.org/r/129612) [19:14:56] i just wanted another opinion [19:15:12] (same with Max's https://gerrit.wikimedia.org/r/#/c/109939/) [19:17:04] jdlrobson: see if kaldari_afk can help out [19:21:26] 3MobileFrontend / 3stable: some upload errors reporting undefined/undefined as error text - 10https://bugzilla.wikimedia.org/64213 (10Jon) 5PAT>3RES/FIX [19:22:41] 3MobileFrontend / 3beta: Talk broken on pages which don't have talk pages - 10https://bugzilla.wikimedia.org/64268#c2 (10Jon) 5NEW>3RES/FIX Fixed by https://gerrit.wikimedia.org/r/129358 [19:26:14] (03Restored) 10Jdlrobson: QA: Stop copyvio test running in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129586 (owner: 10Jdlrobson) [19:27:06] (03PS1) 10Jdlrobson: Revert "QA: Fix failing photo copyvio browser test" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129732 [19:28:41] 3MobileFrontend / 3Hygiene: Copyvio tests do not work on Chrome - 10https://bugzilla.wikimedia.org/64397#c2 (10Jon) 5RES/FIX>3REO Patch didn't fix it so reverting. [19:56:42] dbrant: do you see a vague scrollbar in the left nav? [19:57:23] YuviPanda: don't think so... not sure what you mean [19:57:45] dbrant: open the leftnav, and just attempt to scroll it. [19:57:54] dbrant: you'll see a scrollbar, even though there is nothing to scroll [19:58:05] dbrant: at least that's the case on my N4. Does your S3 have stock or touchwiz? [19:58:28] YuviPanda: ah yes, the scrollbar appears momentarily [19:58:51] dbrant: yeah. let me file a bug. we should get rid of it at some point [20:00:07] (03PS1) 10Yuvipanda: Use user's normalized name everywhere [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129805 [20:00:26] 3Wikipedia App / 3Generic: Show canonical user name instead of user's raw input - 10https://bugzilla.wikimedia.org/64412#c1 (10Gerrit Notification Bot) Change 129805 had a related patch set uploaded by Yuvipanda: Use user's normalized name everywhere https://gerrit.wikimedia.org/r/129805 [20:01:28] 3Wikipedia App / 3Generic: Scrollbar visible in left nav - 10https://bugzilla.wikimedia.org/64444 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None Left nav menu has a scrollbar visible if you attempt to scroll, even though there is nothing to scroll. [20:01:54] YuviPanda: ^ I can't see it here [20:02:11] liangent_: this might've been triggered by a commit I just merged. unsure. [20:03:21] YuviPanda: does the app send assertions in edit requests? [20:03:25] don't bother to actually test it [20:04:01] liangent_: are assertions available onwiki? [20:04:06] liangent_: I don't [20:04:17] liangent_: although it should ideally fail with an 'invalid token!' error, no? [20:04:24] since I'm using the API and sending a user's token for an anon edit [20:04:25] kaldari_afk: when will you no longer be afk? [20:04:35] liangent_: so if it is happening then it's some bug in the 'revalidate!' code [20:06:39] YuviPanda: although it should ideally fail with an 'invalid token!' error, no? << not really. how heavily do you cache tokens?? [20:06:43] (03PS3) 10Brion VIBBER: Work in progress: data migration from old app [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129307 [20:07:19] liangent_: until invalidated [20:07:26] 3MobileFrontend / 3General/Unknown: mobile response: Error, edit not saved - 10https://bugzilla.wikimedia.org/64416#c4 (10Jon) Looking at errors from last month - bad token and edit conflicts are our greatest reason for errors: badtoken 2123 editconflict 1199 http 341 We should probably be cleverer... [20:07:52] YuviPanda: then what happens when badtoken is returned? [20:08:27] liangent_: it tries to re-login using same username and token [20:08:33] liangent_: and, uh, crashes if it can't :P [20:08:43] not the best, yeah [20:11:04] YuviPanda: a caveat is that when you misread a failed login as a successful one (or simply before that bug was fixed), +\ is cached as the user's token [20:11:32] and this just matches the current auth status (unlogged in) [20:11:56] liangent_: ah, hmm. [20:12:02] liangent_: yeah, that code is something I'll need to investigate [20:16:06] (03CR) 10Jdlrobson: [C: 032] Revert "QA: Fix failing photo copyvio browser test" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129732 (owner: 10Jdlrobson) [20:16:31] jgonera: if you want to +2 so I don't get shouted at for self merging ;-) https://gerrit.wikimedia.org/r/129586 [20:16:42] (03Merged) 10jenkins-bot: Revert "QA: Fix failing photo copyvio browser test" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129732 (owner: 10Jdlrobson) [20:16:50] mhurd: so i’m taking a look over the save code paths which i’m a little rusty on… if i understand correctly, i have to load the page up into a web view to push it into the caching database, then attach a ‘Saved’ record to it to keep it in the saved list? [20:17:10] (03CR) 10Jdlrobson: "The change got reverted - https://gerrit.wikimedia.org/r/129732" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129605 (owner: 10Cmcmahon) [20:18:01] brion: lemme check… shouldn’t need to load it, but i may need to add a cleaner interface for that… [20:18:09] ok [20:21:42] (03PS2) 10Jdlrobson: QA: Stop copyvio test running in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129586 [20:25:39] YuviPanda: and, session invalidation (maybe by sysadmins) may happen between login and the first edit :p [20:26:51] hmm logging out on desktop invalidates mobile session too, right? [20:27:20] liangent_: yeah [20:27:28] brion: want me to try slapping together a quick import method? think you’ll just want to pass it title and domain? [20:28:04] mhurd: sure, title & lang is exactly what i’m extracting — see the DataMigrator class in https://gerrit.wikimedia.org/r/#/c/129307/ [20:28:13] cool [20:28:30] i’ll poke over in androidland while you’re looking at that :D [20:28:48] ooh, old app used eclipse. let’s see if i can install updates without exploding [20:29:01] brion: sounds good [20:30:16] brion: you don't need eclipse! [20:30:30] brion: android update project -p . && ant debug install should just work [20:30:39] true :D [20:30:46] (03PS6) 10JGonera: Hygiene: Merge Overlay and OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129196 (owner: 10Jdlrobson) [20:30:48] (03PS5) 10JGonera: Rewrite MediaViewer as OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129195 (owner: 10Jdlrobson) [20:30:56] brion: friends don't let friends use eclipse :P [20:31:01] hehehe [20:31:14] brion: also, I just started using adb wirelessly [20:31:17] brion: OMG IT IS SO AWESOME [20:31:20] nice! [20:31:20] dbrant: ^ [20:31:51] (https://stackoverflow.com/questions/2604727/how-can-i-connect-to-android-with-adb-over-tcp was what I used) [20:32:16] heh… the menu icons in the old app show super tiny on xxhdpi display because we didn’t include appropriately sized icons and our plugin didn’t scale them [20:32:39] https://bugzilla.wikimedia.org/show_bug.cgi?id=64446 always forget to log this, because I don't have network to log it when I see it [20:33:16] why didn't wikibugs report this bug? [20:34:06] (03PS1) 10Yuvipanda: Fix crash when links are clicked in preview pane [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129816 [20:34:22] liangent_: yeah, I think I'll just hide contributions for now. not fleshed out well enough. [20:34:27] 3Wikipedia App / 3Generic: Clicking a link in edit preview crashes the app - 10https://bugzilla.wikimedia.org/64418#c1 (10Gerrit Notification Bot) Change 129816 had a related patch set uploaded by Yuvipanda: Fix crash when links are clicked in preview pane https://gerrit.wikimedia.org/r/129816 [20:35:46] YuviPanda: yeah actually contribution list, especially just "own contribution", is not so useful on mobile [20:35:52] liangent_: yup. [20:35:56] liangent_: it also needs a diff view and stuff [20:36:00] hmm [20:36:06] and before that bug was fixed, I can abuse it to view another user's contribs in the app :p [20:36:22] YuviPanda: new app’s scripts/pullfiles.bash is failing to decompress for me trying to pull files from the old app [20:36:25] zlib.error: Error -3 while decompressing data: incorrect header check [20:36:40] brion: oh. that's... weird. [20:37:18] i think it’s got more text header before the gzip stuff or something [20:37:19] (03PS1) 10Yuvipanda: Hide My Contributions list for MVP [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129817 [20:37:24] (03PS7) 10JGonera: Hygiene: Rewrite things as Overlaynew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129083 (owner: 10Jdlrobson) [20:37:31] liangent_: there. my contributions gone! [20:37:42] brion: oh? apk things should be the same throughout... :| [20:37:47] (03CR) 10JGonera: [C: 032] Hygiene: Rewrite things as Overlaynew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129083 (owner: 10Jdlrobson) [20:37:49] brion: LET US BLAME PHONEGAP! [20:37:56] (03PS6) 10JGonera: Rewrite MediaViewer as OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129195 (owner: 10Jdlrobson) [20:38:04] (03CR) 10JGonera: [C: 032] Rewrite MediaViewer as OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129195 (owner: 10Jdlrobson) [20:38:19] (03PS7) 10JGonera: Hygiene: Merge Overlay and OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129196 (owner: 10Jdlrobson) [20:38:29] (03Merged) 10jenkins-bot: Hygiene: Rewrite things as Overlaynew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129083 (owner: 10Jdlrobson) [20:38:29] YuviPanda: https://gerrit.wikimedia.org/r/#/c/129816/1/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java huh you actually follow that link? [20:38:44] and edit contents are thrown? [20:38:48] liangent_: yeah? [20:38:56] (03Merged) 10jenkins-bot: Rewrite MediaViewer as OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129195 (owner: 10Jdlrobson) [20:38:57] liangent_: nope. you can hit 'back', they should be preserved [20:39:12] 3MobileFrontend / 3Hygiene: Rewrite ImageOverlay to use OverlayNew - 10https://bugzilla.wikimedia.org/64269#c3 (10Gerrit Notification Bot) Change 129195 merged by jenkins-bot: Rewrite MediaViewer as OverlayNew https://gerrit.wikimedia.org/r/129195 [20:39:12] 3MobileFrontend / 3stable: MediaViewer doesn't use LoadingOverlay - 10https://bugzilla.wikimedia.org/64271#c3 (10Gerrit Notification Bot) Change 129195 merged by jenkins-bot: Rewrite MediaViewer as OverlayNew https://gerrit.wikimedia.org/r/129195 [20:39:46] YuviPanda: what if I start another edit afterwards? [20:40:10] liangent_: that's fine too. it is a stack. you keep hitting back until you hit this one again [20:40:22] hmm [20:40:32] liangent_: or at least, in theory, that should be fine. I tested it with just one page link following + back and it worked [20:40:44] YuviPanda: or use the left drawer to logout, or switch to another use, or something? [20:40:51] *another user [20:40:58] liangent_: ah, so switching to another user will be wonky. it'll try to save as that new user [20:41:04] liangent_: same as if you log out [20:41:17] YuviPanda: i think i have to disable my screen lock so i can get an unecrypted backup... [20:41:21] (03PS3) 10Jdlrobson: QA: Stop copyvio test running in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129586 [20:41:30] brion: oh, can't you just keep it on and not give it a passphrase? [20:41:40] (03CR) 10JGonera: [C: 032] QA: Stop copyvio test running in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129586 (owner: 10Jdlrobson) [20:41:48] no it fails if my passphrase doesn’t match my encryption unlock [20:41:49] shit [20:41:56] i can’t disable unlock cause of the encryption [20:42:02] ok lemme just try another device ;) [20:42:09] the dangers of developing on your primary phone [20:42:18] (03Merged) 10jenkins-bot: QA: Stop copyvio test running in Chrome [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129586 (owner: 10Jdlrobson) [20:42:28] brion: heh [20:42:38] YuviPanda: in current app, the editing interface locks the left drawer, so there're no such things [20:42:54] liangent_: indeed, but if you can navigate to another page you can open the left drawer [20:44:19] ah, touchwiz [20:44:24] making android shittier since 200whatever [20:46:39] brion: gah, the drawer only has 'setListener' events, so I can't have more than one listener in different fragments for the same control [20:46:41] * YuviPanda stabs android [20:46:48] ouch [20:47:02] make a trunk listener that forwards :D [20:47:11] ding dong, nokia’s mostly dead. :( http://arstechnica.com/information-technology/2014/04/microsoft-is-now-a-phone-company-as-nokia-deal-closes/ [20:47:16] brion: so much java boilerplate [20:48:19] at least windows phone 8.1 is an improvement to develop for; no more silverlight-only [20:48:27] and you can share code with windows 8.1 tablet apps [20:48:58] not that there’s any demand for such apps ;) [20:49:40] whatever genius at samsung decided their back and menu buttons should be hidden until you touch them should be smacked [20:49:51] ^ [20:49:57] YuviPanda: I don't have such an account to test, but how are non-SULed users handled? [20:50:18] brion: ok i have basic import working - will clean it up a bit and send your way [20:50:35] mhurd: awesome :D [20:50:36] thanks! [20:50:47] liangent_: unknown. haven't tested. app assumes users have same user name and account on all wikis [20:50:58] so it'll just log in as the same username as you first logged in to the app as [20:51:05] YuviPanda: ok, pullfiles works on my galaxy s4 mini which isn’t encrypted. yay! [20:51:17] brion: np! had to refresh on core data stuff… glad we don’t touch that code every day :) [20:51:29] ok, slightly different file layout but the websql bits are probably about the same once i open them [20:51:30] :D [20:53:04] YuviPanda: hm you login separately for each wiki, and don't make use of wildcard central auth cookies? [20:53:39] liangent_: atm no. my cookie handling code is hand rolled (I know, terrible, but there weren't any widely used android libs for that yet), and it doesn't support wildcards [20:53:47] https://bugzilla.wikimedia.org/show_bug.cgi?id=64447 why do I always encounter these bug even when I don't intentionally find bugs [20:54:26] 3Wikipedia App / 3Generic: TOC is not updated in post-edit page content update - 10https://bugzilla.wikimedia.org/64447#c1 (10Yuvi Panda) I should stop making Page a final object. should fix most of these. [20:55:43] (03PS1) 10Dbrant: OK button is now disabled if no language is selected. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129819 [20:55:46] (03CR) 10Jdlrobson: [C: 032] "I COMMAND THEEE TO MERGE" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129196 (owner: 10Jdlrobson) [20:55:56] 3Wikipedia App / 3Generic: In settings / language, clicking OK without selecting an item crashes the app - 10https://bugzilla.wikimedia.org/64422#c1 (10Gerrit Notification Bot) Change 129819 had a related patch set uploaded by Dbrant: OK button is now disabled if no language is selected. https://gerrit.wiki... [20:56:01] kaldari_afk: kaldari_afk [20:56:21] (03Merged) 10jenkins-bot: Hygiene: Merge Overlay and OverlayNew [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129196 (owner: 10Jdlrobson) [20:58:36] YuviPanda: I wonder why a toc without right margin appear for one second when an edit is done? [20:59:20] liangent_: yeah, ToC is a little wobbly too. Unsure what to do there [20:59:32] liangent_: I see the flicker, no idea why [21:00:57] 3Wikipedia App / 3Generic: Android app: Missing home / go to Main Page button - 10https://bugzilla.wikimedia.org/64395#c2 (10Yuvi Panda) 5NEW>3RES/WON I don't think we should. Perhaps elsewhere somewhere later, but a dedicated button on the left nav that takes the user to a single page doesn't seem worthy. [21:01:03] YuviPanda: and recently (after the update yesterday), the app stops responding after being used for a while [21:01:15] liangent_: define 'a while' [21:01:21] liangent_: and that sounds super serious :| [21:01:33] YuviPanda: switching to another app then switching back fixes that, but it reappears after some time [21:01:56] liangent_: sounds like a leak. ugh. file a bug? and also see if you can get some estimated times? [21:02:18] when it's "not responding", ANR dialog doesn't appear, but the interface freezes [21:03:08] nice, colons in filenames :D [21:03:41] 3Wikipedia App / 3Generic: Contribution list crashes when network connection is down - 10https://bugzilla.wikimedia.org/64446#c1 (10Yuvi Panda) I've 'fixed' this for now by hiding 'My contributions' all together. Too half baked to go out atm. [21:04:10] dbrant: think you can CR some of the patches I've up? do take your time if you're in the middle of something now :) [21:04:37] YuviPanda: let's see... [21:05:17] dbrant: they are 'dependent' patche. in the gerrit interface you can see the unmerged parents and children. [21:05:38] sigh ArrayList arr = new ArrayList(); [21:05:39] YuviPanda: got java.lang.RuntimeException: Adding window failed just now [21:05:40] * brion stabs Java [21:05:55] no type inference? really? [21:06:05] when I keep using the app while the app is freezing from time to time [21:06:05] well it’s no worse than obj-c [21:06:14] liangent_: so the IllegalFragmentException I've a good idea what is causing it (uncancelled asynctasks), but window I can't. [21:06:17] previously I just kill it and start it again [21:06:28] liangent_: is this in short period (a few mins?) [21:06:30] liangent_: or longer? [21:06:51] YuviPanda: what perioud? [21:06:54] *period [21:07:08] liangent_: period of using the app after which the freezes start [21:07:11] 3Wikipedia App / 3Generic: RTL support in the app - 10https://bugzilla.wikimedia.org/64420#c1 (10Yuvi Panda) Can you give me examples? Do we have sites that have different directionalities for different variants? [21:07:15] YuviPanda: yeah [21:07:29] liangent_: hmm, file a bug. I'll take a profiler to it in a day or two [21:07:50] YuviPanda: does java.lang.RuntimeException: Adding window failed indicate OOM or something? [21:07:54] (03CR) 10Dbrant: [C: 032] Use user's normalized name everywhere [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129805 (owner: 10Yuvipanda) [21:08:03] dbrant: are you testing these as well? :) [21:08:11] 3Wikipedia App / 3Generic: Show canonical user name instead of user's raw input - 10https://bugzilla.wikimedia.org/64412#c2 (10Gerrit Notification Bot) Change 129805 merged by Dbrant: Use user's normalized name everywhere https://gerrit.wikimedia.org/r/129805 [21:08:23] dbrant: we don't really have a QA team so we're kinda our own QA. [21:08:31] YuviPanda: i am checking them out and running on the device [21:08:35] dbrant: cool! [21:08:36] YuviPanda: kkwiki [21:08:44] YuviPanda: will you CR mine? [21:09:07] dbrant: they were merged earlier, I think [21:09:07] YuviPanda: it uses language converter for latn, cryl and arab [21:09:20] latn and cyrl are ltr, while arab is rtl [21:09:24] dbrant: oh, no, didn't see the new one! [21:09:25] YuviPanda: i just submitted another [21:09:26] dbrant: doing now [21:09:34] hmm, grrrit-wm missed it [21:09:42] YuviPanda: https://kk.wikipedia.org/w/index.php?title=%D0%AF%D0%BD%D0%B3-%D0%AF%D1%85%D0%B0_%28%D0%AE%D1%80%D0%B5%D0%B4%D0%B5%D0%B9-%D0%AF%D1%85%D0%B0_%D1%82%D0%B0%D1%80%D0%BC%D0%B0%D2%93%D1%8B%29&variant=kk-latn [21:09:43] https://kk.wikipedia.org/w/index.php?title=%D0%AF%D0%BD%D0%B3-%D0%AF%D1%85%D0%B0_%28%D0%AE%D1%80%D0%B5%D0%B4%D0%B5%D0%B9-%D0%AF%D1%85%D0%B0_%D1%82%D0%B0%D1%80%D0%BC%D0%B0%D2%93%D1%8B%29&variant=kk-arab [21:10:08] liangent_: ugh. [21:10:11] liangent_: file a bug? [21:10:24] liangent_: I honestly don't think we'll get to it for first release, but should get to it at some point. [21:10:31] liangent_: so in this case it should be defined by... what? [21:11:16] (03PS5) 10Jdlrobson: Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 [21:11:22] (03PS5) 10Jdlrobson: Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 [21:11:26] 3Wikipedia App / 3Generic: RTL support in the app - 10https://bugzilla.wikimedia.org/64420#c2 (10Liangent) (In reply to Yuvi Panda from comment #1) > Can you give me examples? Do we have sites that have different > directionalities for different variants? kkwiki uses language converter for latn, cyrl and ar... [21:11:55] YuviPanda:
or
[21:12:07] liangent_: is that part of what the API returns? [21:12:09] I'm not aware of its equivalent in mobileview [21:12:50] (03CR) 10Yuvipanda: [C: 04-1] "setFilter is doing too many things, and I wouldn't expect a set function to return value." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129819 (owner: 10Dbrant) [21:12:59] dbrant: ^ [21:14:01] dbrant: suggested a different approach that'll simplify the UI a bit as well [21:14:29] brion: can we assume that all saved articles from the old app were from wikipedia.org? [21:14:42] 3Wikipedia App / 3Generic: [Android] Unnecessary 'ok' box for language select - 10https://bugzilla.wikimedia.org/64076#c1 (10Yuvi Panda) *** Bug 60742 has been marked as a duplicate of this bug. *** [21:14:42] 3Wikipedia App / 3Generic: Language Selection should not require user to press OK - 10https://bugzilla.wikimedia.org/60742#c1 (10Yuvi Panda) 5NEW>3RES/DUP *** This bug has been marked as a duplicate of bug 64076 *** [21:14:44] (03CR) 10Yuvipanda: "It'll also help fix https://bugzilla.wikimedia.org/show_bug.cgi?id=64076 as well." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129819 (owner: 10Dbrant) [21:15:07] mhurd: yeah only wikipedia supported [21:15:13] could be any language, but only wikipedia [21:15:16] keeps things simple :D [21:15:17] brion: cool one less parameter [21:15:21] :) [21:15:23] aharoni: an RTL bug you didn't spot! https://bugzilla.wikimedia.org/show_bug.cgi?id=64420 [21:15:36] YuviPanda: aha, I'll do it that way. [21:15:43] YuviPanda: missed your pings yesterday. Are you around later today? [21:15:53] (03CR) 10Dbrant: [C: 032] Fix crash when links are clicked in preview pane [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129816 (owner: 10Yuvipanda) [21:15:55] vbamba: hey! no, I'll be out in about 15m. [21:16:11] 3Wikipedia App / 3Generic: Clicking a link in edit preview crashes the app - 10https://bugzilla.wikimedia.org/64418#c2 (10Gerrit Notification Bot) Change 129816 merged by Dbrant: Fix crash when links are clicked in preview pane https://gerrit.wikimedia.org/r/129816 [21:17:28] 3Wikipedia App / 3Generic: App stops responding after being used for a while - 10https://bugzilla.wikimedia.org/64450 (10Liangent) 3NEW p:3Unprio s:3normal a:3None In 2014-4-22 => 2014-4-25 upgrade. Switching to another app then switching back fixes that, but it reappears after some time. When it's... [21:20:51] (03CR) 10Dbrant: [C: 04-1] ""My Contributions" still visible. (is it enabled programmatically?)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129817 (owner: 10Yuvipanda) [21:20:58] YuviPanda: does aharoni try to cc all rtl bugs? [21:21:12] liangent_: he definitely does, yeah [21:21:56] 3Wikipedia App / 3Generic: [Android] Unnecessary 'ok' box for language select - 10https://bugzilla.wikimedia.org/64076#c2 (10Liangent) Resolving this fixes bug 64422. [21:22:26] YuviPanda: what's MVP [21:22:42] liangent_: ah, right. I should stop using that [21:22:44] liangent_: 'first release' [21:22:45] minimal viable product ;) [21:23:26] yeah, but to me it always sounded a bit weird in the context of the wikipedia app [21:23:32] I mean, we know that wikipedia is fairly viable... [21:23:40] lol [21:24:05] dbrant: gah, good catch. let me fix that [21:25:15] dbrant: fixed [21:25:19] (03PS2) 10Yuvipanda: Hide My Contributions list for MVP [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129817 [21:25:39] dbrant: did you figure out how to 'amend' a patch and submit a new version for review? [21:25:53] YuviPanda: figuring it out now... [21:26:04] dbrant: ok. let me know if you want help. [21:26:14] dbrant: I also highly reccomend the Pro Git book I linked you to when you have the time. [21:27:26] (03CR) 10Dbrant: [C: 032] Hide My Contributions list for MVP [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129817 (owner: 10Yuvipanda) [21:27:50] dbrant: woot! [21:28:32] i've got to step out for a while; i'll have to finish my patch later [21:28:41] dbrant: alright. I'll head to sleep soon. [21:28:54] I'll make a release before that as well. [21:29:04] dbrant: have a good weekend! [21:29:16] liangent_: I'm going to make another release and then head off [21:29:27] YuviPanda: you too! thanks for helping make my first week great [21:29:38] (03CR) 10JGonera: [C: 032] "Why does this depend on the watchstar patch?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129084 (owner: 10Jdlrobson) [21:29:39] dbrant: \o/ [21:29:40] (03PS1) 10Dr0ptp4kt: Make action=mobileview GET, not POST. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129823 [21:29:46] dbrant: hopefully secondweek would be awesome too! [21:30:44] YuviPanda: is it a good idea to make a http version of the app? [21:30:50] so I can wireshark it... [21:31:02] liangent_: I can make you a one off build. [21:31:16] liangent_: I'll email you one in a few mins? [21:31:18] or make it switchable eg in preferences [21:31:33] (03PS1) 10Yuvipanda: Fix broken test for loginFix broken test for loginFix broken test for loginFix broken test for loginFix broken test for loginFix broken test for loginFix broken test for loginFix broken test for login [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129824 [21:31:35] liangent_: nah, that sounds bad. [21:31:35] brion: around? [21:31:47] dr0ptp4kt: yeah but i’ve got a meeting with tomasz [21:31:48] having no ui is fine [21:31:52] be available in a bit [21:31:56] ok, VIM fail [21:32:03] liangent_: hmm? [21:32:04] (03PS2) 10Yuvipanda: Fix broken test for login [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129824 [21:32:05] and it's tweakable in a rooted phone :p [21:32:06] (03CR) 10jenkins-bot: [V: 04-1] Fix broken test for login [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129824 (owner: 10Yuvipanda) [21:32:11] brion, cool, was just gonna see if you could quick review the conversion from POST to GET for the action=mobileview on iOS [21:32:21] (03CR) 10JGonera: [C: 04-1] "I don't see any replies to my inline comments from patchset 6." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [21:32:27] brion: no rush, that is [21:33:08] (03PS3) 10Yuvipanda: Fix broken test for LoginTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129824 [21:33:29] dr0ptp4kt: can you merge ^? [21:33:33] dr0ptp4kt: just a syntax unbreakage. [21:34:13] YuviPanda: you asking about https://gerrit.wikimedia.org/r/129824 ? [21:34:21] dr0ptp4kt: yeah [21:34:44] dr0ptp4kt: btw, there's a script called make-release.bash in scripts/ to make a release :) [21:34:45] YuviPanda: gimme a minute or two. want to run the test [21:34:52] dr0ptp4kt: ah, cool! [21:34:56] YuviPanda: that's cool, good to know [21:37:09] dr0ptp4kt: ah, hmm. it fails [21:39:31] dr0ptp4kt: updated commit message :) [21:39:34] (03PS4) 10Yuvipanda: Fix broken test for LoginTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129824 [21:39:35] dr0ptp4kt: and some code as well [21:41:35] I feel the settings interface is too crowded with a lot of Wikipedia Zero text [21:41:55] maybe let it get a separated interface? [21:41:59] liangent_: file a bug! [21:42:02] liangent_: and yeah, I agree [21:44:12] (03CR) 10Yuvipanda: "POST also bypasses cache completely everywhere, so shouldn't be used." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129823 (owner: 10Dr0ptp4kt) [21:44:28] 3Wikipedia App / 3Generic: Too much text is placed in the settings interface for Wikipedia Zero - 10https://bugzilla.wikimedia.org/64453 (10Liangent) 3NEW p:3Unprio s:3normal a:3None The interface looks so crowded. If there're more text than switches, maybe use a screen with full of explanation of W... [21:48:10] YuviPanda: any idea why R.string.test_username|password isn't resolving? [21:48:31] YuviPanda: gotta talk to dan. be back in 5-10 [21:48:34] dr0ptp4kt: ok! [21:50:26] 3Wikipedia App / 3Generic: App stops responding after being used for a while - 10https://bugzilla.wikimedia.org/64450 (10Liangent) s:5normal>3major [21:50:40] I'm bumping severity ^ [21:51:10] dr0ptp4kt: ok i’ll take a peek in a moment [21:52:17] mhurd: do you remember if there was a reason we made the action=mobileview API hit a post request instead of a get? [21:52:25] (03PS1) 10Mhurd: Object for bulk importation of saved pages records. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129831 [21:52:32] brion: ^ [21:52:38] woot thanks :D [21:52:46] brion: hmmm no i don’t recall... [21:52:56] could have been oversight [21:52:59] i have the vaguest memory of some sort of escaping issue on the parameters [21:53:04] which might be something we can fix proper [21:53:26] 3MobileFrontend / 3Hygiene: MobileOptions checkbox toggles should be refactored and put in mediawiki.ui - 10https://bugzilla.wikimedia.org/64313#c2 (10Juliusz Gonera) See https://trello.com/c/4GEeWAws/17-toggle-controls [21:53:36] brion: POSTs will fuck with the cache [21:53:39] so shouldn't [21:53:52] YuviPanda: take that cache! ;) [21:54:01] YuviPanda: will fix [21:54:14] mhurd: :) dr0ptp4kt already left a patch [21:54:29] YuviPanda: oh cool! [21:54:52] mhurd: https://gerrit.wikimedia.org/r/#/c/129823/1 [21:55:13] 3Wikipedia App / 3Generic: "Clear search field" icon in search field doesn't disappear even when there isn't an input when reading article - 10https://bugzilla.wikimedia.org/64454 (10May) 3NEW p:3Unprio s:3normal a:3None Created attachment 15211 --> https://bugzilla.wikimedia.org/attachment.cgi?id=... [21:56:14] (03CR) 10Brion VIBBER: [C: 032 V: 032] "I have the vaguest memory there was a parameter escaping issue somewhere that we worked around by going POST, so keep an eye out for regre" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129823 (owner: 10Dr0ptp4kt) [21:56:29] 3Wikipedia App / 3Generic: When there is one character search term, "clear search field" icon doesn't appear - 10https://bugzilla.wikimedia.org/64455 (10May) 3NEW p:3Unprio s:3normal a:3None Created attachment 15212 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15212&action=edit One search t... [21:56:56] 3MobileFrontend / 3stable: Footer hidden on diff - 10https://bugzilla.wikimedia.org/64108#c5 (10Jon) Moiz suggests hiding it for the time being until we have a more long term solution. [21:58:14] 3Wikipedia App / 3Generic: In left drawer, username should be bold not italicized - 10https://bugzilla.wikimedia.org/64456 (10May) 3NEW p:3Unprio s:3normal a:3None Created attachment 15213 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15213&action=edit Left drawer [21:58:50] brion: i think the importer should be pretty robust… [21:59:33] YuviPanda: i'm back, what's the deal with the strings resolution? i tried re-making and re-building, but to no avail [21:59:45] dr0ptp4kt: are you doing it in wikipedia-it/res/values? [21:59:50] dr0ptp4kt: and not in wikipedia/res/values [22:00:00] dr0ptp4kt: specifically, wikipedia-it/res/values/strings.xml [22:00:13] YuviPanda: that would be the running context, yeah, right, i suppose i better update that, hang on [22:02:43] 3Wikipedia App / 3Generic: Apps should find a way to support CheckUser and work properly - 10https://bugzilla.wikimedia.org/64458 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None We have cleaner UAs that make CheckUser much harder to do anything with. [22:02:56] 3Wikipedia App / 3Generic: Apps should find a way to support CheckUser and work properly - 10https://bugzilla.wikimedia.org/64458#c1 (10Yuvi Panda) Details at http://lists.wikimedia.org/pipermail/mobile-l/2014-March/006795.html [22:03:31] Deskana: just remembered, https://bugzilla.wikimedia.org/show_bug.cgi?id=64458 [22:03:46] YuviPanda: Yeah, I just saw that. [22:03:55] Deskana: yeah, I forgot to file a bug. [22:04:01] Deskana: I distinctly remember you saying 'but I am not your PM' :P [22:04:13] Haha, yes. [22:04:28] Well, as of right now, I'm not! Kenan is, then Maryana for a sprint. [22:04:28] how times change, Garry Sir [22:04:37] Deskana: right, but still. [22:04:40] YuviPanda: ^ include a device identifier ? [22:04:42] We can discuss this in... whatever meeting it's appropriate to discuss this in. [22:04:50] * Deskana is still learning the meeting process. [22:04:51] in UA [22:05:08] Deskana: I proposed a thing in the ML that seemed acceptable to everyone. [22:05:18] liangent_: why mess up UA? it is super clean now. [22:06:10] YuviPanda: well UA is not shown to anybody except for checkusers [22:06:27] liangent_: there was a super long thread about this exact thing in mobile-l [22:06:40] liangent_: http://lists.wikimedia.org/pipermail/mobile-l/2014-March/ [22:07:33] ok then I'll keep silent.. [22:07:44] liangent_: :D [22:07:50] dr0ptp4kt: thoughts on other operations get vs post? [22:08:09] mhurd: for the MW API, everything should be GET by default unless otherwise noted [22:08:23] liangent_: or rather, in general, for HTTP, all read actions should be GET and write actions POST [22:08:25] err [22:08:26] mhurd: ^ [22:08:35] YuviPanda: cool [22:08:40] YuviPanda: thx [22:10:28] 3MobileFrontend / 3stable: bugello test - 10https://bugzilla.wikimedia.org/64459 (10Arthur Richards) 3NEW p:3Unprio s:3normal a:3None is this thing on? [22:13:48] liangent_: mailed you a http build [22:15:09] liangent_: you'd need to uninstall the thing you have now to try this [22:15:11] liangent_: this is the latest build tho [22:15:26] 3MobileFrontend / 3stable: bugello test - 10https://bugzilla.wikimedia.org/64459#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1968 [22:19:54] (03PS7) 10Jdlrobson: Hygiene: Introduce border-box class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129084 [22:20:00] (03CR) 10Jdlrobson: [C: 032] Hygiene: Introduce border-box class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129084 (owner: 10Jdlrobson) [22:20:39] (03Merged) 10jenkins-bot: Hygiene: Introduce border-box class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129084 (owner: 10Jdlrobson) [22:29:37] (03PS6) 10Jdlrobson: WIP:Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 [22:30:10] (03CR) 10jenkins-bot: [V: 04-1] WIP:Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 (owner: 10Jdlrobson) [22:31:45] (03PS7) 10Jdlrobson: Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 [22:32:13] 3MobileFrontend / 3stable: User link in diff doesn't go to user profile - 10https://bugzilla.wikimedia.org/64462 (10Maryana Pinchuk) 3NEW p:3Unprio s:3normal a:3None Steps to repro: On master branch, go to a diff in stable. Tap on the user link - you'll go to the user page (or create page if user pa... [22:32:30] i'm in ur product, filin ur bugz [22:33:31] Maryana: coming to zurich? [22:33:37] i am :) [22:33:41] Maryana: woot! [22:33:53] (03PS6) 10Jdlrobson: Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 [22:35:27] 3MobileFrontend / 3stable: User link in diff doesn't go to user profile - 10https://bugzilla.wikimedia.org/64462#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1969 [22:35:27] kaldari_afk: you're still afk? [22:36:11] 3MobileFrontend / 3stable: User link in diff doesn't go to user profile - 10https://bugzilla.wikimedia.org/64462#c2 (10Jon) Fail. [22:36:58] liangent_: how do you make the IME 'tall enough'? [22:37:07] YuviPanda: huh, i dunno. so i moved the xml elements or the u/p from wikipedia-it/res/values/credentials.xml to wikipedia-it/res/values/strings.xml, but no luck after making again. in intellij how do i tell it to use the wikipedia-it module's res/values instead of the wikipedia res/values? [22:37:42] YuviPanda: what happens when you run the testLogin test from intelliJ? [22:37:48] i'm on ps4 [22:38:13] dr0ptp4kt: it fails at the line checking the token, and I get the wrong token as well [22:38:19] dr0ptp4kt: try a clean maybe/ [22:38:19] ? [22:38:25] YuviPanda: BLARGH [22:38:28] YuviPanda: k, hang on [22:38:47] dr0ptp4kt: also, either way, can you merge it? since 1. without this it doesn't even compile, and 2. the test failing seems to have been failing for a while [22:38:57] dr0ptp4kt: all our tests don't pass at all. I need to spend some time making sure they do [22:39:01] dr0ptp4kt: and write some more as well [22:40:24] YuviPanda: my current IME is "tall enough" [22:40:49] and some IMEs have configurable height see Hacker's Keyboard [22:41:43] YuviPanda: i'll do that, you revert if jenkins goes bananas, ok? [22:41:48] dr0ptp4kt: ok! [22:42:01] liangent_: ah, hmm. anyway let me put that in a scrollbar [22:42:33] YuviPanda! [22:42:42] violetto! [22:43:58] 4.13am YuviPanda [22:44:07] violetto: I know, I should sleep [22:44:14] violetto: I'll make a release just before I do [22:44:46] (03PS1) 10Mhurd: More GET not POST fixes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129843 [22:45:00] brion: ^ moar! [22:45:36] (03CR) 10Dr0ptp4kt: [C: 032 V: 032] "Per IRC chat, +2'ing to get this to a compiling state, with knowledge that R.java in wikipedia-it is misbehaving on local IDE and needs to" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129824 (owner: 10Yuvipanda) [22:45:51] jdlrobson: oops forgot to change my nick back [22:46:17] (03Merged) 10jenkins-bot: Fix broken test for LoginTask [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129824 (owner: 10Yuvipanda) [22:46:25] kaldari: https://gerrit.wikimedia.org/r/129730 should make you happy [22:46:40] yay! [22:46:53] brion: chance to poke that importer? [22:47:09] brion: curious if it does the trick :) [22:47:11] YuviPanda: I think I may want to force the app to run in landscape and see what happens [22:47:22] liangent_: ah, hmm. [22:47:35] YuviPanda: are you asleep? [22:47:44] mhurd: maybe [22:47:54] YuviPanda: the correct answer is “yes” [22:48:06] ;) [22:48:59] jdlrobson: testing it now [22:50:26] 3MobileFrontend / 3stable: mobileview fails on content pages redirecting to special pages - 10https://bugzilla.wikimedia.org/64305#c3 (10Juliusz Gonera) Max, not sure what are the steps to reproduce the bug. If I go to the mobile version of https://en.wikipedia.org/wiki/User:Purplebackpack89/C everything see... [22:51:26] 3MobileFrontend / 3Feature requests: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c30 (10Juliusz Gonera) Just a heads up that the an experimental fix for this has been merged into the beta mode of mobile, but it will still take a while until it gets to stable. [22:51:44] YuviPanda: I guess the app fails too [22:51:50] liangent_: on landscape? [22:51:58] no [22:51:58] MobileFrontend / stable: mobileview fails on content pages redirecting to special pages - https://bugzilla.wikimedia.org/64305#c3 [22:52:30] and it works well in landscape [22:52:31] liangent_: ah. yeah, it would [22:53:00] I created a squared AVD [22:53:08] let me test the app in it :) [22:56:26] 3MobileFrontend / 3Feature requests: Filter for New User uploads in Mobile Web - 10https://bugzilla.wikimedia.org/62598#c31 (10Steinsplitter) still take a while... monts, weeks? [22:58:05] liangent_: haha :D [23:02:34] (03CR) 10Kaldari: [C: 04-1] "The messages are mixed up now. When it asks you if you are happy with the random page you've been given, the button that for "No, gimme an" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129730 (owner: 10Jdlrobson) [23:03:34] liangent_: did you get the http version? [23:03:47] YuviPanda: got it [23:03:56] liangent_: sweet :) [23:04:06] YuviPanda: and the launcher just fails in a square screen [23:04:16] E/AndroidRuntime( 2034): Caused by: java.lang.IllegalArgumentException: width and height must be > 0 [23:04:22] liangent_: hah! [23:04:32] liangent_: sent full stacktrace to OTRS? [23:04:43] liangent_: I don't think we'll support square screens for first release either [23:04:59] what stacktrace? [23:05:07] I haven't started the Wikipedia app yet [23:05:12] and I can't find a way to start that [23:05:22] because launcher doesn't work [23:05:25] liangent_: oh wait, the *launcher* fails [23:05:26] ah, right [23:05:28] nevermind. [23:05:33] i misread that [23:06:20] YuviPanda: what's the package and main activity name? [23:06:26] I think I have to start it using am start [23:06:28] liangent_: org.wikipedia and PageActivity [23:07:11] 3MobileFrontend / 3stable: Do not use comma-separator message in "7 bytes added, 8 days ago" (mobile diff) - 10https://bugzilla.wikimedia.org/64302#c2 (10Max Semenik) How serious is the impact, how many languages are affected in practice? And what is your suggestion, create a new message just for this specif... [23:07:43] YuviPanda: Error: Activity class {org.wikipedia/org.wikipedia.PageActivity} does not exist. ? [23:08:06] I think I adb install'ed it correctly [23:08:30] liangent_: ah, org.wikipedia.page.PageActivity apparently [23:10:15] YuviPanda: so now, the login interface it not scrollable either [23:10:21] so I can't see the password box [23:10:42] overlapped by IME [23:11:09] liangent_: can you file one bug with list of things that aren't scorllable? [23:11:09] the same in registration interface [23:11:35] YuviPanda: maybe reused the captcha one? [23:12:39] liangent_: yeah. [23:12:43] liangent_: just retitle it as well [23:14:11] 3Wikipedia App / 3Generic: The login form, registration form and registration captcha form are not scrollable - 10https://bugzilla.wikimedia.org/64406#c1 (10Liangent) When the viewport is not tall enough, some elements can't be seen. [23:15:24] jgonera: hey you around? [23:15:38] kenanwang, yes [23:17:15] YuviPanda: there's something wrong in edit preview, but I don't know how to describe it :/ [23:18:31] basically the viewport doesn't shrink after ime is shown [23:26:11] 3Wikipedia App / 3Generic: The login form, registration form and registration captcha form are not scrollable - 10https://bugzilla.wikimedia.org/64406#c2 (10Liangent) There's something wrong in edit preview, but I don't know how to describe it. Basically the viewport doesn't shrink after IME is shown. [23:27:29] 3Wikipedia App / 3Generic: Odd to find "Article history", "save page", and "search English language wiki" in left drawer where site wide navigation is found listed in the same way. - 10https://bugzilla.wikimedia.org/64465 (10May) 3NEW p:3Unprio s:3normal a:3None I know where these list items are foun... [23:28:56] 3Wikipedia App / 3Generic: Odd to find "Article history", "save page", and "search English language wiki" in left drawer where site wide navigation is found listed in the same way. - 10https://bugzilla.wikimedia.org/64465#c1 (10May) The same goes to "warn if leaving Wikipedia Zero" in the native Settings app... [23:29:09] liangent_: take a screenshot? [23:31:44] dbrant|bbl: ah, so the scrollbar is there because 'Log Out' is not visible when logged in. But I can't scroll to it either :| [23:33:05] off to sleep folks. night [23:40:56] 3MobileFrontend / 3stable: Do not use comma-separator message in "7 bytes added, 8 days ago" (mobile diff) - 10https://bugzilla.wikimedia.org/64302#c3 (10Liangent) (In reply to Max Semenik from comment #2) > How serious is the impact, An incorrect punctuation is used. > how many languages are affected in p... [23:43:14] liangent_: are the edits you are making being attributed to you? [23:43:18] liangent_: can you verify? [23:43:23] and they aren't revealing your IP? [23:45:23] ok, sleep for reals [23:46:03] (03CR) 10Jdlrobson: Hygiene: Standardise on our icon usage (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [23:46:56] 3MobileFrontend / 3stable: Do not use comma-separator message in "7 bytes added, 8 days ago" (mobile diff) - 10https://bugzilla.wikimedia.org/64302#c4 (10Liangent) So currently text near mobile-frontend-diffview-bytesadded / mobile-frontend-diffview-bytesremoved is lego work. This message should be written a... [23:49:26] 3MobileFrontend / 3stable: Do not use comma-separator message in "7 bytes added, 8 days ago" (mobile diff) - 10https://bugzilla.wikimedia.org/64302#c5 (10Liangent) (In reply to Liangent from comment #4) > "mobile-frontend-diffview-subtitle": "$1 {{PLURAL:$1|byte|bytes}} added, > $2", > "mobile-fronte... [23:51:31] (03PS10) 10Jdlrobson: Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [23:52:11] (03CR) 10jenkins-bot: [V: 04-1] Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [23:57:14] jgonera: I went ahead and triaged the bugs [23:57:24] I'm a little bit confused about where the sign off column is now [23:57:41] kenanwang, I sent you an SMS, we already did everything with Maryana [23:57:49] there's nothing left to triage as far as I know [23:59:50] (03PS2) 10Jdlrobson: Hygiene: Kill the confusingly named KeepGoingDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129730