[04:15:03] (03PS1) 10Mhurd: License prompt when saving edits when logged in. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130029 [06:01:31] (03PS2) 10Mhurd: License prompt when saving edits when logged in. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130029 [06:03:19] (03PS3) 10Mhurd: License prompt when saving edits when logged in. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130029 [06:18:10] hello prtksxna [06:18:23] vbamba: o/ [07:59:34] (03PS1) 10Mhurd: Made main nav use wikifont! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130040 [08:08:09] (03PS2) 10Mhurd: Made main nav use wikifont! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130040 [08:17:50] (03PS3) 10Mhurd: Made main nav use wikifont! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130040 [09:52:56] zz_prtksxna: looking at code now [11:47:10] 3MobileFrontend / 3General/Unknown: mainspace Special:Random instead of filespace Special:Random in mobile (browser) Commons sidebar - 10https://bugzilla.wikimedia.org/64543 (10Stöger Florian D. M.) 3UNC p:3Unprio s:3normal a:3None The "Random" link in the mobile (browser) Commons sidebar leads to a... [11:48:38] 3MobileFrontend / 3General/Unknown: mainspace Special:Random instead of filespace Special:Random in mobile (browser) Commons sidebar - 10https://bugzilla.wikimedia.org/64543 (10Steinsplitter) 5UNC>3NEW [11:50:23] 3MobileFrontend / 3General/Unknown: mainspace Special:Random instead of filespace Special:Random in mobile (browser) Commons sidebar - 10https://bugzilla.wikimedia.org/64543#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mo... [12:48:39] 3MobileFrontend / 3Feature requests: Review permission system for anonymous editing on mobile - 10https://bugzilla.wikimedia.org/53076#c23 (10Mariofan13) Preventing IP edits is against the principle of Wikipedia. And it makes no sense to prevent IPs form using the mobile editor, because they can edit withthe... [17:10:00] (03PS1) 10Jdlrobson: Link to profile page from diff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130100 (https://bugzilla.wikimedia.org/64462) [17:11:13] brion: hey! [17:11:42] wazzap [17:11:47] yuvi’s gonna be late [17:12:13] brion: oh ya just saw his email [17:12:53] brion: a couple fun patches in the queue :) [17:13:29] brion: oh, did you need the importer to import a thumbnail per article? [17:13:45] oh that might be a nice addition [17:13:56] didn’t quite get a chance to finish everything up, got distracted with my research projects on the weekend :P [17:14:01] brion: presently the thumb gets loaded w everything else if they tap on a saved article in “saved pages” [17:14:08] brion: no worry! [17:14:11] if we can preload that that’d be awesomer though :D [17:14:13] yeah [17:14:23] brion: can add it a bit later [17:14:26] k [17:16:26] brion: dbrant : waiting for you guys on the hangout [17:30:46] brion: if the coffee’s kicked in, could i pester you for early cr? :) [17:30:53] indeed! [17:30:57] brion: yay! [17:34:02] (03CR) 10Brion VIBBER: [C: 04-1] "Preview should probably stay as a post, since the wikitext chunk may be pretty long and there may or may not be a limit on URL length some" (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129843 (owner: 10Mhurd) [17:34:18] brion: ah, will amend [17:34:27] ok [17:36:33] (03PS1) 10Mhurd: Fix for article history using article domain not search domain. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130108 [17:38:19] (03PS2) 10Mhurd: More GET not POST fixes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129843 [17:38:24] brion: ^ amended [17:38:34] \o/ [17:43:37] (03CR) 10Brion VIBBER: [C: 032 V: 032] "seems to work nicely!" [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130029 (owner: 10Mhurd) [17:59:48] (03CR) 10Jdlrobson: [C: 032] Hygiene: PhpDoc, unused variables, etc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129865 (owner: 10MaxSem) [18:01:28] brion: the wikifont for nav patch took way less time than i’d anticipated - got it to prevent button animations from exceeding the button bounds too [18:01:37] ! cool [18:02:24] brion: tested on ios6 too so i think it’s good to go [18:02:38] (03CR) 10Brion VIBBER: [C: 032 V: 032] More GET not POST fixes. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129843 (owner: 10Mhurd) [18:02:43] great lemme pull it up [18:03:39] too bad we can’t just use SVGs directly as images… but the icon font sure simplifies things too :D [18:04:57] kaity|away: haha unbelizable [18:05:39] brion: hehe yeah using the font seems sneaky, but it seems to work [18:05:48] heh http://arstechnica.com/security/2014/04/windows-0day-flash-bug-under-active-attack-threatens-os-x-linux-too/ [18:05:49] oh flash [18:06:00] why you gotta be so insecure [18:11:10] (03CR) 10Brion VIBBER: [C: 032 V: 032] Made main nav use wikifont! [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130040 (owner: 10Mhurd) [18:11:34] brion: woohoo! [18:11:56] mhurd: the right-facing arrow icon is a different style, that’s ok right? [18:12:14] brion: yeah the arrow from the font looks a bit different [18:12:23] ok as long as it’s not a surprise :D [18:12:39] brion: yeah i’m guessing they’ll rev that a bit [18:13:51] brion: the font also only has a left facing arrow so i’m doing an affine xf to fake out the right facing arrow. this morning i requested a right facing arrow character so this hack won’t be necessary [18:14:04] heh [18:14:05] brion: but it works for now [18:14:05] ok :D [18:14:21] it’s a-fine a-transformation! [18:14:27] hehe [18:15:14] brion: oh 2 more patches in the queue, but they’re tiny [18:16:15] brion: if they look good, i’ll cut another build [18:16:41] (03PS2) 10Brion VIBBER: Fix for article history using article domain not search domain. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130108 (owner: 10Mhurd) [18:16:43] (rebase) [18:18:22] (03CR) 10Brion VIBBER: [C: 032 V: 032] Fix for article history using article domain not search domain. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130108 (owner: 10Mhurd) [18:18:30] brion: yay! [18:26:38] violetto: hey may! did u see my email? [18:26:40] flash, a runtime built by folks who wanted flashy stuff and didn't know how to build a runtime :( [18:28:54] hey mhurd! i did. i wonder if there is a way to make the icon flip instead of creating for each direction? [18:29:35] violetto: i’m flipping it now, just thought it would be simpler not to [18:30:28] mhurd: oh, is it a tedious step? [18:31:31] violetto: not especially. but it may be more tedious when using on web, for instance. [18:44:04] violetto: for reference — what are you using to edit the font? [18:44:17] is the .ttf the original file or is there a project file or something you’re generating from? [18:44:43] brion: im using a combination of font forge and glyph [18:45:21] brion: the original file is an otf but im pretty sure you can open the ttf in any font making program to edit [18:45:31] spiffy [18:45:56] thanks! [18:45:59] (03Merged) 10jenkins-bot: Hygiene: PhpDoc, unused variables, etc [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129865 (owner: 10MaxSem) [18:47:00] jgonera: https://gerrit.wikimedia.org/r/125269 [19:04:40] brion: hmm… the series of tubes must be clogged - cut new build and testflight says it sent all the emails but i don’t see email yet… [19:05:45] brion: nvmd. just got email [19:11:39] (03Abandoned) 10Jdlrobson: QA: don't sleep, wait. updated FIXMEs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129605 (owner: 10Cmcmahon) [19:16:41] tfinc: do you have the url for which foundation devices are “checked out” by whom? [19:17:19] tfinc: *mobile testing devices* [19:18:30] hey brion [19:18:48] hey dbrant, mhurd [19:18:52] what did I miss? [19:18:55] * YuviPanda goes to trello board [19:18:56] YuviPanda: heya! [19:19:03] YuviPanda: you missed all the things [19:19:05] YuviPanda: hey! [19:19:45] dbrant: I added you as a reviewer to a smallish patch :) [19:19:51] I had forgotten to do that [19:20:22] YuviPanda: maryanna’s going to try to get andoid build on her test device to sign off the 3 android stories awaiting signoff [19:20:43] mhurd: cool. [19:20:45] YuviPanda: she may ping you [19:20:53] mhurd: I'll pre-empt the ping, yeah [19:20:58] YuviPanda: hehe [19:21:05] pre-ping? [19:21:52] heh [19:22:55] and Deskana already has the app on his tablet [19:23:12] YuviPanda: nice! [19:23:18] YuviPanda: I've picked up a difficulty(3) card... [19:23:28] foods! [19:23:28] YuviPanda: we'll see if that was a mistake [19:23:30] brb [19:24:11] dbrant: :D ok! [19:24:33] YuviPanda: So what happens with all the things that were "To Do" in sprint 29? [19:24:44] dbrant: mostly they get moved over to the next sprint [19:24:48] and put in its todo [19:24:59] and if product owner thinks some are not important enough they get moved back to backlog [19:25:21] YuviPanda: got it... [19:27:04] hey vbamba [19:29:10] (03CR) 10Dbrant: [C: 032] Mark non-cancelable dialogs as non-cancelable [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/129888 (https://bugzilla.wikimedia.org/64469) (owner: 10Yuvipanda) [19:29:29] dbrant: sweet! [19:32:53] YuviPanda: yo [19:32:59] YuviPanda: can you mail in your status? [19:34:11] YuviPanda: what is the status of https://trello.com/c/u4W0dU0l/6-2-license-text-on-every-edit I'd like to close sprint 29 [19:43:45] tfinc: I commented asking for input from vbamba and no response yet. we should just move it over [19:44:06] tfinc: mailing in now [19:44:41] YuviPanda: moved [19:46:46] hey Maryana [19:52:17] yo YuviPanda [19:52:27] i'm charging up an android test device :) [19:52:30] nice [19:52:33] Maryana: what device is it? [19:52:36] when it's got juice, imma try to get the latest build [19:52:48] err… i forget.. mhurd handed it to me [19:53:53] YuviPanda: thanks. you keeping dbrant busy ? [19:53:56] :D [19:54:08] * MaxSem bites YuviPanda to see if he's still there [19:54:18] * YuviPanda gives MaxSem cognac [19:54:33] MaxSem: the canedit patch! [19:54:53] * tfinc separates YuviPanda and MaxSem into separate sand boxes  [19:55:01] * tfinc watches them throw sand back and forth  [19:55:03] you just need to bludgeon jdlrobson and jgonera to make it happen!:P [19:55:17] * YuviPanda pokes jdlrobson and jgonera [19:55:21] dbrant: welcome to week 2 [19:55:33] dbrant: we have our check in tomorrow but feel free to let me know if you need anything [19:55:42] dbrant: otherwise i leave you in YuviPanda capable paws [19:55:56] MaxSem, YuviPanda is it fixed? I'll have a look at it later today [19:56:00] tfinc: thanks; there's definitely no shortage of things to be done! [19:56:30] jgonera: there's no way to 'fix' it, I think. It won't work for anon blocks, but I don't htink there's any way to do that without killing cache [19:56:58] so my patch returns this information for anons sans block status [19:57:23] dbrant: :) I investigated that card before, I am pretty sure the crash is because I'm not accounting for a missing page at all in the LeadSectionTask (or somesuch) in PageViewFragment [19:57:37] it just shouldn't lie, so either that property has some value that means "don't know" for anons, or the property is not present at all [19:57:44] MaxSem, YuviPanda ^ [19:57:54] jgonera: it knows for anons. it takes protection status into account, and titleblacklist and such [19:57:58] jgonera: that apply blanket for all anons [19:58:04] YuviPanda: yep, that's where I'm at. [19:58:25] jgonera: of the many factors it takes into account, blocking is the only thing that's varies by IP and hence won't be accurate [19:58:37] I'll have a look at it later [19:59:29] Maryana: :) let me know if you run into issues installing. [19:59:42] YuviPanda: now, bouncing Special pages to the external browser might be problematic... because our intent filter matches any path that begins with "/wiki/" [20:00:11] YuviPanda, I actually wanted to talk about the sections bug [20:00:21] I don't touch this stuff at all [20:00:45] we could also use an embedded browser [20:00:47] the problem is that parser doesn't return section title HTML at all:P [20:01:01] dbrant: ah, yeah. so there are two ways we can go at it. one is that we can customize the intent chooser to ignore us. the other is that we can redirect to "/w/index.php?title=". That won't be caught by our filter, but caught by browsers [20:01:09] <YuviPanda> dbrant: I like the first way better since it is less hacky. [20:01:19] <YuviPanda> MaxSem: yeah, so you parse <h> tags and segment them accordingly [20:01:31] <dbrant> YuviPanda: I'll try that... [20:01:35] <MaxSem> ??? [20:01:51] <YuviPanda> MaxSem: as in, mobileview determines sections by <hX> no? [20:02:09] <MaxSem> nope, it uses the array returned by parser [20:02:16] <YuviPanda> oh [20:02:32] <YuviPanda> then why don't the numbers match some of the time? [20:03:09] <YuviPanda> MaxSem: oh wait [20:03:13] <YuviPanda> MaxSem: we're talking about two separate bugs [20:03:15] <MaxSem> we have to be creative sometimes to correllate secton chunks from HTML withthat array [20:03:15] * YuviPanda facepalm [20:03:31] <YuviPanda> MaxSem: you are talking about "line": not having tags in it, right? [20:03:44] <MaxSem> https://bugzilla.wikimedia.org/show_bug.cgi?id=64467 [20:04:06] <grrrit-wm> (03PS4) 10Brion VIBBER: Work in progress: data migration from old app [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/129307 [20:04:07] <YuviPanda> MaxSem: right. [20:04:20] <brion> ok that’s just rebased to include the other classes [20:04:39] <YuviPanda> MaxSem: so how does mobileview detect "line":? [20:04:51] <MaxSem> it receives it from parser [20:04:54] <YuviPanda> brion: any progress on the android extraction part? I could do the actual import part [20:05:03] <MaxSem> whole sectionprop actually [20:05:10] <MaxSem> in one epic array [20:06:00] <YuviPanda> MaxSem: and the parser strips html from 'line':? [20:06:10] <brion> partway done, will pull it up later [20:06:25] <YuviPanda> brion: ok! [20:06:31] <MaxSem> yes, it's essentially what you see in TOC [20:07:21] <YuviPanda> MaxSem: aaaaah, hmm. [20:07:30] <YuviPanda> MaxSem: so using it for titles is a bit, wrong almost, I guess? [20:07:41] <MaxSem> yes [20:07:41] <YuviPanda> MaxSem: so the right way to do it is to not turn noheadings on and just style them appropriately? [20:07:55] <MaxSem> I think you should request HTML with <h*> tags [20:08:02] <MaxSem> and reformat them [20:08:23] <YuviPanda> yeah, that sounds like the way to go [20:42:12] <grrrit-wm> (03PS1) 10Dbrant: Fixed crash on nonexistent and Special pages (pages with no mobile view) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130213 (https://bugzilla.wikimedia.org/62639) [20:48:39] <grrrit-wm> (03CR) 10Yuvipanda: [C: 04-1] "Should also consider splitting this into two commits - one for special pages and one for missing pages." (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130213 (https://bugzilla.wikimedia.org/62639) (owner: 10Dbrant) [20:48:52] <YuviPanda> hey dbrant [20:48:56] <YuviPanda> how's working with git been [20:49:43] <dbrant> YuviPanda: getting more comfortable with it... [20:50:27] <YuviPanda> dbrant: cool :) [20:51:36] <YuviPanda> dbrant: you can split the commit with some git-fu. git reset HEAD^ [20:51:46] <YuviPanda> dbrant: should uncommit your changes, and then you can make new commits with 'git commit -p' [20:57:37] <YuviPanda> dbrant: I'll head off in a few mins :) [20:58:02] <dbrant> YuviPanda: hmm, so any ideas for handling Special pages, assuming we can’t base it on the URL? [20:58:32] <YuviPanda> dbrant: A couple of ways. 1. List all the possible language ways of spelling 'Special' (this isn't *that* hard) and then check for those. [20:58:55] <YuviPanda> dbrant: the other one is to fix the API to return a marker when something is a special page but that means that the user will have to wait for a HTTP request to complete before they are redirected [20:59:37] <grrrit-wm> (03PS1) 10Mhurd: When keyboard appears on edit, scroll cursor above keyboard. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130219 [21:00:08] <dbrant> YuviPanda: then I’ll investigate the former. [21:00:29] <YuviPanda> dbrant: yeah. either way it should be split up to two patches so we can merge the non-existing page patch separately [21:00:44] <dbrant> YuviPanda: will do [21:01:39] <YuviPanda> dbrant: :) we have a bunch of python scripts under scripts/ that generate static data (language lists, etc). Perhaps we can add one there that generates this list in android resource xml form [21:01:43] <grrrit-wm> (03PS1) 10Mhurd: Update icon set from design svg. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130220 [21:02:15] <mhurd> brion: couple super small patches for ya [21:02:51] <YuviPanda> dr0ptp4kt: dude I just realized your nick is dropped packet [21:02:54] * YuviPanda facepalms [21:03:30] <dr0ptp4kt> YuviPanda: ha [21:04:10] <awjr> jgonera: kickoff [21:04:29] <mhurd> vbamba: got that cursor scrolling issue finally fixed [21:05:25] <wikibugs> 3MobileFrontend / 3Feature requests: Tables in mobile - 10https://bugzilla.wikimedia.org/36936#c35 (10Christopher Yeleighton) 5NEW>3RES/INV This bug is invalid, both title and description carry no useful information whatsoever. If you follow the text, you come to the conclusion that the bug is about tab... [21:05:34] <awjr> https://trello.com/b/NjJtUGAz/mobile-web-current-sprint-22-v [21:09:09] <wikibugs> 3MobileFrontend / 3General/Unknown: table width is marked !important - 10https://bugzilla.wikimedia.org/64516#c6 (10Christopher Yeleighton) 5RES/DUP>3REO The only workaround for what? I reverted your duplication assignment because the other bug is not a bug. I do not know what it is. [21:09:31] <YuviPanda> dbrant: ah, so there's an API query that lists it for each website [21:09:32] <YuviPanda> https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&meta=siteinfo&format=json&siprop=namespaces&siinlanguagecode=de [21:09:44] <YuviPanda> dbrant: that's the API sandbox, lets you play around with the API [21:10:10] <YuviPanda> dbrant: so we would have to write a script that hits that URL for every wiki and figure out what special maps to [21:10:11] <YuviPanda> ugh [21:10:22] <dbrant> YuviPanda: hmm… [21:11:03] <YuviPanda> dbrant: have you written python much? [21:11:16] <YuviPanda> I can write it rather quickly tomorrow if you want me to [21:11:40] <dbrant> YuviPanda: ^ that would help [21:11:46] <mhurd> YuviPanda: is that for the name of main pages for each domain? [21:12:01] <YuviPanda> mhurd: no, this is the Special page detection, which is something iOS might be affected by too [21:12:08] <mhurd> YuviPanda: ah [21:12:21] <mhurd> YuviPanda: keep me posted? [21:12:33] <mhurd> :) [21:12:56] <YuviPanda> mhurd: go to https://test.wikipedia.org/wiki/Test_special on the iOS app and click the link [21:12:59] <YuviPanda> mhurd: and see what happens [21:13:06] <mhurd> YuviPanda: k [21:13:24] <wikibugs> 3MobileFrontend / 3General/Unknown: table width is marked !important - 10https://bugzilla.wikimedia.org/64516#c7 (10Christopher Yeleighton) (In reply to Jon from comment #5) > I would suggest in the meantime it might be useful to get an admin to add a > helper css class that helps tables override this on mo... [21:13:27] <YuviPanda> mhurd: the expected behavior is to bounce them out to safari where MF will handle it or they see the desktop site till MF handles it [21:14:01] <mhurd> YuviPanda: oh if the link is tapped? [21:14:05] <YuviPanda> mhurd: yes [21:14:24] * YuviPanda pokes vbamba [21:14:55] <mhurd> YuviPanda: ah, i get a page doesn’t exist msg [21:15:09] <YuviPanda> mhurd: right. but that page does exist. [21:15:15] <mhurd> YuviPanda: ah [21:15:29] <mhurd> y u no work [21:15:30] <YuviPanda> go to it in your browser (mobile or dektop) and it'll work [21:15:51] <YuviPanda> so for these we need to parse them out and send them off to the browser explicitly [21:16:15] <mhurd> YuviPanda: so anything starting with “special:” ? [21:16:35] <YuviPanda> mhurd: so there's that catch. the answer is 'anything starting with any of the 200 languages' words for special': [21:16:43] <mhurd> YuviPanda: oh god [21:16:49] <dbrant> mhurd: (in all translations of “special”!) [21:16:57] <mhurd> YuviPanda: really? uuuuuuuuhhhhhhhhhggggg [21:17:00] <mhurd> :) [21:17:27] <YuviPanda> mhurd: https://de.wikipedia.org/wiki/Spezial:Beobachtungsliste is a special page in german wiki [21:17:36] <mhurd> YuviPanda: can we have an api for “gimme special word for domain” - oh and “gimme main page for domain” too [21:17:54] <YuviPanda> mhurd: indeed, I just pasted the API for the former a while ago [21:17:58] <YuviPanda> https://en.wikipedia.org/wiki/Special:ApiSandbox#action=query&meta=siteinfo&format=json&siprop=namespaces&siinlanguagecode=de [21:18:14] <YuviPanda> mhurd: however, these pretty much never change, so we can write a script that puts them in a form we can ship with the app [21:18:25] <mhurd> YuviPanda: oh nice [21:18:33] <YuviPanda> mhurd: same for main page [21:19:36] <mhurd> YuviPanda: so static files for both. cool. [21:19:48] <YuviPanda> mhurd: yeah. I can give you JSON and XML for Android [21:19:58] <mhurd> YuviPanda: yay! thx! [21:20:11] <YuviPanda> mhurd: yw :) do mention this on the card? [21:20:31] <mhurd> YuviPanda: i’ll make note on the ios card… [21:21:07] <YuviPanda> mhurd: sweet :) [21:21:50] <mhurd> YuviPanda: on https://trello.com/c/D9emSwPi/4-1-main-page i added “Yuvi will provide json file for main page names by domain.” [21:21:57] <YuviPanda> mhurd: cool. [21:22:05] <YuviPanda> mhurd: do you have a card for handling special pages? [21:22:13] <mhurd> YuviPanda: lemme check… [21:22:58] <mhurd> YuviPanda: i dont see one [21:23:18] <YuviPanda> mhurd: https://trello.com/c/dCiVr7C0/7-3-app-crashes-if-you-open-a-non-existing-page has both android and ios colors, I think it wasn't split [21:23:47] <mhurd> YuviPanda: ah [21:24:28] <mhurd> YuviPanda: i added note to that card as well [21:24:45] <YuviPanda> mhurd: cool. you should split that off for iOS [21:24:49] <YuviPanda> s/split/duplicate/ [21:24:51] <mhurd> YuviPanda: will do [21:26:22] <mhurd> YuviPanda: how high on the todo list was that card? [21:28:11] <mhurd> YuviPanda: i just put it beneath the “main page” story. hope that’s roughly where it had been prority-wise… [21:28:27] <mhurd> *priority* [21:28:32] <YuviPanda> mhurd: yeah, cool [21:28:38] <YuviPanda> mhurd: dbrant so the plot slightly thickens [21:28:48] <mhurd> YuviPanda: eh? [21:28:59] <YuviPanda> mhurd: dbrant https://test.wikipedia.org/wiki/Spezial:Test is a valid 'regular' page that we should deal with regularly, even though it starts with the word for 'Special': in german [21:29:11] <YuviPanda> this is because it is in a wiki that does not have german as the default content language [21:29:21] <dbrant> YuviPanda: aah!! [21:29:26] <YuviPanda> so to detect special pages we have to match language code with the word for special in that language [21:29:55] <YuviPanda> dbrant: so the data we need to bundle should have both language code and 'special' word and then check [21:30:19] <YuviPanda> dbrant: there's no hashmap fast-loading with Android resources as there is for arrays :( [21:31:06] <awjr> http://hatjitsu.wmflabs.org/53202 [21:31:13] <mhurd> YuviPanda: oh that’s how i thought you said it worked - one “special” word per domain [21:31:31] <YuviPanda> mhurd: yeah, but I was hoping to just do a simple array search and not worry about languages [21:31:39] <YuviPanda> so it's slightly more complex [21:31:55] <YuviPanda> but matching with domain name does mean we can do it in a simple hash lookup than to have a array search, so I guess it is ok [21:32:05] <dbrant> poppycock. [21:32:23] <mhurd> YuviPanda: just to make sure i understand - for each domain code there’s one “special” word [21:32:27] <YuviPanda> mhurd: yup [21:32:33] <mhurd> YuviPanda: k [21:32:45] <YuviPanda> dbrant: so I had this slightly-but-not-too crazy idea, which is to just generate a Java file with the data :D [21:33:06] <dbrant> YuviPanda: why not! [21:33:10] <mhurd> YuviPanda: that’s crazy talk! ;) [21:33:23] <YuviPanda> dbrant: yeah, then we can use whatever data structure we want [21:33:30] <YuviPanda> mhurd: :) [21:33:42] <YuviPanda> dbrant: and it'll be rather fast too :) [21:34:19] <awjr> http://etherpad.wikimedia.org/p/MobileWeb_Iteration_name [21:34:30] <dbrant> YuviPanda: yay [21:38:25] <YuviPanda> dbrant: I'm heading to sleep for real now. should have the script done tomorrow. [21:38:36] <YuviPanda> dbrant: do split out the patch tho. [21:38:37] <YuviPanda> night! [21:38:41] <dbrant> YuviPanda: k; later! [21:38:53] <mhurd> YuviPanda: gnight! [21:39:24] <wikibugs> 3MobileFrontend / 3General/Unknown: table width is marked !important - 10https://bugzilla.wikimedia.org/64516#c8 (10Christopher Yeleighton) (In reply to Jon from comment #5) > I would suggest in the meantime it might be useful to get an admin to add a > helper css class that helps tables override this on mo... [21:45:36] <YuviPanda> Maryana: I added and removed you from backlog (ol' turn-it-off-and-on-again :) ). not sure if it would work but worth a try [21:45:50] <Maryana> sadly, no change :( [21:46:15] <YuviPanda> Maryana: :( [21:46:25] * Maryana kicks trello [22:05:30] <grrrit-wm> (03PS1) 10Dbrant: Fixed crash on nonexistent pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130226 (https://bugzilla.wikimedia.org/62639) [22:06:24] <wikibugs> 3MobileFrontend / 3General/Unknown: table width is marked !important - 10https://bugzilla.wikimedia.org/64516#c9 (10Philippe Verdy) See also https://meta.wikimedia.org/wiki/Help_talk:Table#Table_width_in_Mobile_View [22:11:46] <grrrit-wm> (03CR) 10Yuvipanda: [C: 04-1] Fixed crash on nonexistent pages. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130226 (https://bugzilla.wikimedia.org/62639) (owner: 10Dbrant) [22:31:54] <wikibugs> 3MobileFrontend / 3General/Unknown: table width is marked !important - 10https://bugzilla.wikimedia.org/64516#c10 (10Philippe Verdy) In general the "!important" specifier in **all** global CSS stylesheets (notably non specific ones like here that just target very generic elements outside any context) is an e... [22:51:43] <grrrit-wm> (03PS1) 10Mhurd: Defined WikiFont characters rather than pasting raw chars. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130237 [22:59:59] <tfinc> mhurd: i'm goign to be a couple of minutes late [23:00:10] <mhurd> tfinc: no worry [23:03:32] <grrrit-wm> (03PS2) 10Dbrant: Fixed crash on nonexistent pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130226 (https://bugzilla.wikimedia.org/62639) [23:03:58] <wikibugs> 3MobileFrontend / 3stable: bugello test!!! - 10https://bugzilla.wikimedia.org/64574 (10Arthur Richards) 3NEW p:3Unprio s:3normal a:3None eh? [23:04:10] <wikibugs> 3MobileFrontend / 3stable: bugello test!!! - 10https://bugzilla.wikimedia.org/64574#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/jBJ1Sou2 [23:05:10] <wikibugs> 3MobileFrontend / 3stable: bugello test!!! - 10https://bugzilla.wikimedia.org/64574#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/9SjdsJYR [23:05:39] <wikibugs> 3MobileFrontend / 3stable: bugello test!!! - 10https://bugzilla.wikimedia.org/64574 (10Arthur Richards) 5NEW>3RES/INV [23:07:11] <wikibugs> 3MobileFrontend / 3alpha: VE link inspector - after selection, search field is buggy - 10https://bugzilla.wikimedia.org/64575 (10Kaity Hammerstein) 3NEW p:3Unprio s:3normal a:3None I selected a word and tapped link tool. I selected a article to link to, then changed my mind and tapped into the search... [23:08:10] <wikibugs> 3MobileFrontend / 3alpha: VE link inspector - after selection, search field is buggy - 10https://bugzilla.wikimedia.org/64575#c1 (10Kaity Hammerstein) This was on IOS [23:10:24] <wikibugs> 3MobileFrontend / 3alpha: VE link inspector - after selection, search field is buggy - 10https://bugzilla.wikimedia.org/64575#c2 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/s0KRAIIC [23:17:44] <grrrit-wm> (03PS1) 10Dbrant: Disabling the "delete" button when History or Saved Pages is empty. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130245 [23:18:25] <wikibugs> 3MobileFrontend / 3alpha: VE - Close button doesn't work - 10https://bugzilla.wikimedia.org/64576 (10Kaity Hammerstein) 3NEW p:3Unprio s:3normal a:3None When I make an edit in VE then tap close I get a dialogue that says "Are you sure you want to abandon your edit?" I tapped "OK" but I went back to V... [23:20:24] <wikibugs> 3MobileFrontend / 3alpha: VE - Close button doesn't work - 10https://bugzilla.wikimedia.org/64576#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/BvlISgqx [23:20:38] <wikibugs> 3MobileFrontend / 3General/Unknown: table width is marked !important - 10https://bugzilla.wikimedia.org/64516#c11 (10Jon) 5REO>3RES/INV Hi Philippe, with no disrespect, I don't think you truly understand the scale of the problem here and you make many assumptions. Let me try to elaborate. Inline styles... [23:35:26] <wikibugs> 3MobileFrontend / 3Hygiene: Tables on mobile are a big fat mess - 10https://bugzilla.wikimedia.org/64577 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon == Background == Many tables generated by wikitext are bigger than 320px. On a 320px screen, this causes the entire viewport to grow to the size of the tab... [23:35:39] <wikibugs> 3MobileFrontend / 3General/Unknown: table width is marked !important - 10https://bugzilla.wikimedia.org/64516#c12 (10Jon) Bug 64577 [23:36:00] <grrrit-wm> (03PS1) 10MaxSem: Don't misuse comma-separator message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130252 (https://bugzilla.wikimedia.org/64302) [23:38:11] <wikibugs> 3MobileFrontend / 3Hygiene: Kill hacks.less - 10https://bugzilla.wikimedia.org/64578 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon The MobileFrontend extension has a file called hacks.less http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend/8d9184c2d4af6e460ccea44be32b88db6565afc7/less%2... [23:38:24] <wikibugs> 3MobileFrontend / 3Hygiene: Tables on mobile are a big fat mess - 10https://bugzilla.wikimedia.org/64577#c1 (10Jon) Note: The existing hack makes use of !important as this is the only way to override an inline style. See also bug 64578