[00:04:39] 3MobileFrontend / 3alpha: VE link inspector - after selection, search field is buggy - 10https://bugzilla.wikimedia.org/64575 (10James Forrester) [00:12:41] awjr: welcome to trello. you'll like life here :) [00:12:49] :) [00:13:05] i've never looked back since putting the app team on it a year ago [00:13:06] tfinc on minor annoyance i discovered today is that priority doesn't get perserved when moving cards around [00:13:11] nope [00:13:28] which is tough when you're moving cards around and aren't the product owner [00:14:52] tfinc: on a related note, i haven't updated the code for the apps team's instance of bugello. if you guys want things updated, lemme know [00:15:01] awjr: updated for what ? [00:15:17] tfinc: the features i described in the email i sent out on friday [00:15:33] awjr: why do they have to be a separate code base/instance? [00:15:46] tfinc they don't [00:15:51] lets collapse them [00:16:40] tfinc: i kept them separate for now to prevent anything blowing up for others as a result of the changes since i dont want have to firefight for other teams' usage of the tool [00:18:23] anyway tfinc i should have some time tomorrow to make sure an upgrade for apps goes ok [00:21:09] 3MobileFrontend / 3Feature requests: Tables in mobile - 10https://bugzilla.wikimedia.org/36936#c36 (10Axel Boldt) 5RES/INV>3REO Admittedly the initial description of the bug was poor, but the discussion describes the problem and outlines several possible solutions. This is a MAJOR issue of the mobile pla... [00:39:12] dr0ptp4kt: hey can i pester you for a minute when you have some time? [00:39:27] mhurd, you can pester any time. but it's never a pester [00:39:30] now is good [00:52:30] mhurd https://github.com/wikimedia/apps-android-wikipedia/blob/master/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java#L270 [00:54:54] (03PS1) 10Jdlrobson: WIP: Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 [04:09:54] 3MobileFrontend / 3Hygiene: Tables on mobile are a big fat mess - 10https://bugzilla.wikimedia.org/64577#c2 (10Jon) *** Bug 36936 has been marked as a duplicate of this bug. *** [04:09:55] 3MobileFrontend / 3Feature requests: Tables in mobile - 10https://bugzilla.wikimedia.org/36936#c37 (10Jon) 5REO>3RES/DUP I've done a better job of summarising on bug 64577 hopefully that will inject some new life into solving this bug :) *** This bug has been marked as a duplicate of bug 64577 *** [12:20:38] (03PS1) 10Brion VIBBER: Tie together the migrator and the importer [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/130326 [13:12:42] (03PS1) 10Yurik: Added an ability to login into the zero config server [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130330 [14:43:26] 3MobileFrontend / 3alpha: beta labs: VE does not load - 10https://bugzilla.wikimedia.org/64607 (10Chris McMahon) 3NEW p:3Unprio s:3normal a:3None as a logged in user with alpha mode set, attempt to edit a page. the VE controls never appear, user sees only a spinner forever. [14:45:24] 3MobileFrontend / 3alpha: beta labs: VE does not load - 10https://bugzilla.wikimedia.org/64607#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/lTCoRTO5 [14:46:39] 3MobileFrontend / 3alpha: beta labs: VE does not load - 10https://bugzilla.wikimedia.org/64607#c2 (10Chris McMahon) no fatal errors appear in the logs on beta labs [15:54:32] (03PS1) 10Dbrant: Hiding the "repeat password" field when "display password" enabled [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130368 (https://bugzilla.wikimedia.org/64408) [16:03:22] hey dbrant! [16:03:31] YuviPanda: hello! [16:03:51] dbrant: looking at the patch now [16:04:16] YuviPanda: ok; there are a couple others, too [16:07:58] (03CR) 10Yuvipanda: [C: 04-1] Disabling the "delete" button when History or Saved Pages is empty. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130245 (owner: 10Dbrant) [16:15:17] (03PS2) 10Dbrant: Disabling the "delete" button when History or Saved Pages is empty. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130245 [16:33:01] (03CR) 10MaxSem: [C: 04-1] Link to profile page from diff (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130100 (https://bugzilla.wikimedia.org/64462) (owner: 10Jdlrobson) [16:55:47] dbrant: sorry, was fighting with my keyboard. back to CR nwo. [16:56:02] YuviPanda: who won? [16:56:17] dbrant: me. I cleared macro memory and it started working again [16:56:25] (command keys weren't working properly, and it was driving me nuts) [17:05:18] Reedy: heard back from jetbrains? [17:07:33] I don't think so :/ [17:08:06] brion: YuviPanda: dbrant: heya! [17:08:13] mhurd: hello! [17:15:05] YuviPanda: you about? [17:15:15] mhurd: hey! yeah [17:15:26] still fighting with the keyboard [17:15:38] oh? broken? [17:16:18] mhurd: no, weird registering issues [17:16:23] YuviPanda: ah [17:16:40] mhurd: this keyboard has its own memory, so I cleared that and things were working. [17:16:48] wonky again. now to clear everything [17:17:52] YuviPanda: gah! <—typing this word quickly is perilous - the “h” is very close to the “y” [17:18:03] mhurd: gay! [17:18:04] :P [17:18:08] :D [17:18:11] hehe [17:18:18] i’m too fast [17:18:37] hehe :) [17:18:42] ok, found out how to reset [17:19:42] oh, anyway, can you maybe shed some light on why i get “There is no section # in ****” errors when i try to edit some sections. I thought it was related to redirect handling, but I’m seeing it even after handling redirects… [17:20:56] YuviPanda: yay reset! [17:21:36] (03PS2) 10Jdlrobson: Rewrite Nearby as a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130270 [17:21:38] (03PS1) 10Jdlrobson: Add frontend caching layer to nearby API calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130383 [17:22:10] dr0ptp4kt: I’m looking to schedule a test of the language switch bug fix - when will the patches on the train be live? [17:22:15] (03CR) 10Jdlrobson: [C: 031] "@liagent does this solve the problem?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130252 (https://bugzilla.wikimedia.org/64302) (owner: 10MaxSem) [17:24:26] brion: any pointers on the “no section” question above? [17:24:52] i suspect i’m doing something silly [17:28:33] (03PS1) 10Jdlrobson: Hide footer on diff pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130386 (https://bugzilla.wikimedia.org/64108) [17:31:38] (03CR) 10Jdlrobson: Link to profile page from diff (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130100 (https://bugzilla.wikimedia.org/64462) (owner: 10Jdlrobson) [17:31:43] (03PS2) 10Jdlrobson: Link to profile page from diff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130100 (https://bugzilla.wikimedia.org/64462) [17:32:35] awjr Maryana: sigh.. i just realized we never added the push new typography for tablets to stable card :( [17:32:43] every day that's not in stable a fairy dies [17:33:14] hm, i thought that card was slotted in for this sprint..? [17:33:32] noop [17:33:42] but according to the q4 backlog it's pretty high in the must have column [17:34:12] ah, ok. i remembered looking at it & talking about it w/kenan [17:34:27] just wasn't sure where or when :) [17:34:47] * Maryana shuffles some stuff around in the backlog [17:38:54] (03CR) 10MaxSem: [C: 032] Hide footer on diff pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130386 (https://bugzilla.wikimedia.org/64108) (owner: 10Jdlrobson) [17:39:09] (03CR) 10MaxSem: [C: 032] Link to profile page from diff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130100 (https://bugzilla.wikimedia.org/64462) (owner: 10Jdlrobson) [17:39:31] (03Merged) 10jenkins-bot: Hide footer on diff pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130386 (https://bugzilla.wikimedia.org/64108) (owner: 10Jdlrobson) [17:39:34] mhurd: success! [17:39:43] YuviPanda: :) keyboard? [17:40:00] (03Merged) 10jenkins-bot: Link to profile page from diff [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130100 (https://bugzilla.wikimedia.org/64462) (owner: 10Jdlrobson) [17:40:02] mhurd: yeah! I needed to connect it to a computer, press f7, and wait for the computer to restart [17:40:14] mhurd: but my mac has a bug where if the keyboard is connected to it when starting up it did not start :P [17:40:18] so got my friend's machine, and did it [17:40:22] ah [17:40:47] on to CR [17:40:55] mhurd: you wanted to grab me for somesuch, no? [17:41:04] YuviPanda: oh, yeah, i asked a questions above [17:41:20] about weird section edit errors [17:41:24] oh [17:41:26] * YuviPanda scrolls up [17:41:46] mhurd, you might love this: https://github.com/facebook/pop [17:41:54] mhurd: can you tell me which page it was occuring in? [17:41:55] mhurd https://code.facebook.com/posts/234067533455773/introducing-pop-the-animation-engine-behind-paper/ [17:42:01] mhurd: and how are you counting section ids? [17:42:04] violetto: oh, yeah, i saw that! [17:42:05] * YuviPanda waves at violetto [17:42:07] YuviPanda: see my email? i wasn't able to get the android test build (and neither could howie) :( [17:42:30] Maryana: yeah, just finished fighting with my keyboard. I'll respond in a few mins [17:42:38] YuviPanda! [17:42:42] violetto!! [17:42:44] YuviPanda: so on the test wiki main page i see 8 or so sections, and when i try to edit the latter sections i see the error [17:42:56] YuviPanda: how did you do the waves at violetto thing [17:43:14] * dbrant waves at violetto [17:43:15] YuviPanda: am i showing sections which should not be shown perhaps [17:43:31] violetto: start a message with /me [17:43:34] * YuviPanda waves frantically [17:43:58] * violetto  [17:44:16] * violetto waves back frantically at YuviPanda and dbrant and mhurd [17:44:22] XD! [17:44:23] * mhurd : is this thing on [17:44:24] :D [17:44:43] * YuviPanda wonders if mhurd was checking if mhurd was on [17:45:02] mhurd: jared & i went to a quartz composer class last evening [17:45:14] * mhurd : waves at self [17:45:18] mhurd: another way of prototyping [17:45:21] mhurd: no colons! :D [17:45:26] violetto: quartz composer is AWESOME [17:45:37] mhurd: yes i know, so excited about it [17:45:54] YuviPanda: you’re a wizard [17:46:22] * YuviPanda puts on his robe and wizard hat [17:47:04] YuviPanda: hehe… so, any clues on the error? [17:47:10] YuviPanda: http://facebook.github.io/rebound/! [17:47:39] mhurd: I think it has to do with how mobileview treats transclusion [17:47:52] mhurd: let me demonstrate [17:49:10] mhurd: ahh, hmm. I wonder if __NOEDITSECTION__ is interfering with section numbering [17:49:16] MaxSem: ^ [17:49:17] * YuviPanda checks [17:49:36] uh? [17:50:24] oh wait. [17:50:27] i'm so confused now [17:50:39] 3MobileFrontend / 3stable: User link in diff doesn't go to user profile - 10https://bugzilla.wikimedia.org/64462 (10Jon) 5PAT>3RES/FIX [17:51:10] 3MobileFrontend / 3stable: Footer hidden on diff - 10https://bugzilla.wikimedia.org/64108 (10Jon) 5PAT>3RES/FIX [17:51:11] 3MobileFrontend / 3alpha: “0 bytes added” should be specially handled and show something better - 10https://bugzilla.wikimedia.org/64616 (10Liangent) 3NEW p:3Unprio s:3normal a:3None At least not a green UP icon. [17:51:39] mhurd: anyway, let me do some CR and come back to this. also explaining the problem to MaxSem should help too [17:51:54] mhurd: MaxSem knows the API far better than I do on virtue of having written it [17:54:16] (03CR) 10Yuvipanda: [C: 04-1] "It should also disable the ToC when it is not found. Also triggers same behavior as https://bugzilla.wikimedia.org/show_bug.cgi?id=64277 w" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130226 (https://bugzilla.wikimedia.org/62639) (owner: 10Dbrant) [17:55:39] 3MobileFrontend / 3alpha: “0 bytes added” should be specially handled and show something better - 10https://bugzilla.wikimedia.org/64616#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/x9L7jrPo [17:56:48] violetto: nice! [17:56:55] violetto: we can easily incorporate those into the app at some point [17:57:36] (03CR) 10Jdlrobson: [C: 04-1] "Needs rebase.. sorry Max. Please poke Kaldari or Arthur to look at this and get it merged after rebasing." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129612 (https://bugzilla.wikimedia.org/64318) (owner: 10MaxSem) [17:59:36] (03PS2) 10Jdlrobson: Center the language list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127613 (https://bugzilla.wikimedia.org/64617) (owner: 10Amire80) [17:59:41] 3MobileFrontend / 3stable: List of languages looks strange when mixes RTL and LTR languages - 10https://bugzilla.wikimedia.org/64617#c1 (10Jon) It doesn't look very good on a tablet screen for one and it also creates an inconsistency with the other lists we have e.g. nearby, watchlist and pages. Adding a sm... [17:59:42] 3MobileFrontend / 3stable: List of languages looks strange when mixes RTL and LTR languages - 10https://bugzilla.wikimedia.org/64617 (10Jon) 3NEW p:3Unprio s:3normal a:3None Copying from Amir: Items in the language list are in a mix of RTL and LTR languages. This makes the list somewhat strangely ali... [18:02:03] (03CR) 10Yuvipanda: [C: 032] Disabling the "delete" button when History or Saved Pages is empty. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130245 (owner: 10Dbrant) [18:02:51] dbrant: left some comments on one. testing the other before merging [18:02:56] (03Merged) 10jenkins-bot: Disabling the "delete" button when History or Saved Pages is empty. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130245 (owner: 10Dbrant) [18:12:50] YuviPanda, figured it out: transclusion. I expained this to Monte [18:13:07] see, I used that word! But I had no idea how transclusion was affecting it [18:13:24] MaxSem: so this is what I was asking. are the section numbers in mobileview not equivalent to section numbers that action=edit takes? [18:14:00] they are. but you need to take fromtitle and index into account [18:21:00] MaxSem: oh? [18:21:06] * YuviPanda looks [18:21:26] when you edit a transcluded section, you're actually editing another page [18:21:51] (03CR) 10Yuvipanda: [C: 04-1] "Hmm, this feels very jarring. A fade or slide perhaps?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130368 (https://bugzilla.wikimedia.org/64408) (owner: 10Dbrant) [18:23:54] jgonera: Maryana https://bugzilla.wikimedia.org/show_bug.cgi?id=64618 [18:23:56] 3MobileFrontend / 3stable: Eventlogging for uploads seems to be broken - 10https://bugzilla.wikimedia.org/64618 (10Jon) 3NEW p:3Unprio s:3normal a:3None MobileWebUploads_8209043 has hardly any entries since Thursday's deployment. This could be related to the EventLogging outage or the change in schem... [18:23:58] ^ milimetric any ideas? [18:25:20] eek. probably related to the db1047 migration [18:25:24] 3MobileFrontend / 3stable: Eventlogging for uploads seems to be broken - 10https://bugzilla.wikimedia.org/64618#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/yn0aE67e [18:25:35] i will bump the analytics list [18:26:02] Maryana: jgonera also changed the schema so it could also be that :-S (i hope not!) [18:26:12] jdlrobson: the problems from the migration are not resolved yet [18:26:27] db1047 is still coming back up and catching up with db1048 last I heard [18:26:31] springle is on it [18:26:37] but he ran into a lot of issues [18:26:55] MaxSem: thx for the help - i think i have a handle on it :) [18:27:08] should i still ping the A-team list, milimetric? [18:27:13] i take responsibiltiy though, I think if we do this type of thing in the future (which I hope we don't), we'll try to plan it better and have backups for situations like this [18:27:15] or are y'all on it? :) [18:28:40] Maryana: you mean the analytics list? You can but I think the only one that knows how to fix it is springle and he's been working on it [18:28:57] all the analytics devs are aware of it (nuria, qchris, and me) and we'll relay any messages from Sean [18:31:09] 3MobileFrontend / 3stable: Bad filename upload error - 10https://bugzilla.wikimedia.org/62241#c15 (10Jon) 5ASS>3RES/FIX Okay so since code was merged on 15th it rode deployment train on 17th reaching all wikis by 24th Since that day [1] there have been no badfilename errors whatsoever but various other... [18:31:36] ok, no sweat. don't want to bug you guys. [18:32:28] Maryana: so I've been unable to repro that bug (play store not working) :( And so far all the people who have run into it are from the office. [18:32:30] not sure what's up [18:32:42] Maryana: I'll just put the latest build up on releases.wikimedia.org and send the link [18:32:47] no prob, you can bug away, when you said A-team I wasn't sure if you meant (http://www.extratextual.tv/wp-content/uploads/2013/07/key_art_the_a_team.jpg) or us :) [18:32:50] Maryana: and modify release process to make sure it is put up [18:33:24] milimetric: wait, so you're not mr. t? [18:33:30] this changes everything [18:33:33] milimetric: that is what she meant I think. I remember seeing that picture on a slide when the then CTO of WMF gave a talk at FOSS.in many many years ago and deciding to come online and see what I can hack on :D [18:33:58] YuviPanda: ok, thanks! [18:34:22] got it - brb gotta take some protein and crush some bicep curls [18:34:47] dbrant: I left some comments. I'm writing that python script now [18:35:04] YuviPanda: great; thanks [18:35:14] dbrant: also have you explored dependent commits on gerrit? [18:35:23] dbrant: for this it was not necessary, but in some cases it can be really useful [18:36:29] (03CR) 10Dr0ptp4kt: [C: 032] Added an ability to login into the zero config server [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130330 (owner: 10Yurik) [18:36:41] (03Merged) 10jenkins-bot: Added an ability to login into the zero config server [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130330 (owner: 10Yurik) [18:37:25] YuviPanda: is it just doing another git-review on a branch that's currently being reviewed? [18:38:19] dbrant: pretty much. it pushes two individual patchsets up for review, and then gerrit shows them as being 'dependent' on each other [18:39:02] dbrant: and the commit that 'depends on' the other commit can't be merged until the commit it depends on is merged [18:39:27] YuviPanda: makes sense... [18:39:32] dbrant: this lets us do a feature as a series of small commits and review them individually than to put up an entire story in one big commit [18:43:11] 3Wikipedia App / 3Generic: Jump to destination wiki directly for inline interwiki links - 10https://bugzilla.wikimedia.org/64620 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Instead of treating it as an external link. [18:43:27] YuviPanda: so on redirects am i correct in saying the way you handle them on android is - as soon as you get article data back you just treat everything as if the redirected title was the one loaded in the first place? [18:43:40] mhurd: pretty much [18:44:03] MaxSem: are there any other index prefixes which are possible besides “T-“? [18:44:14] YuviPanda: cool thanks [18:44:17] no, afaik [18:44:22] MaxSem: thx [18:52:24] 3Wikipedia App / 3Generic: Wikipedia Mobile app crashing on startup on Android 4.4 - 10https://bugzilla.wikimedia.org/57516#c1 (10Liangent) 5NEW>3RES/WON The old app is no longer maintained. [18:52:40] YuviPanda: so for transclusion handling it seems what i need to do is request the “fromtitle” for sections and on wikidata load/save use that title with the api calls. does that sound about right? [18:52:55] MaxSem: ^ [18:55:34] yes [18:56:26] brion: some super small patches in the cr queue for ya [18:57:20] YuviPanda: yo [18:57:34] brion: gonna need to make a couple small core data schema changes this afternoon for handling section transclusion and page redirects. yay [18:57:36] YuviPanda: dbrant: can you guys get the app install working for howie and Maryana ? [18:57:41] i really want to make sure their up to date [18:57:51] we can't be spinning their wheels [18:58:13] * Deskana grabs his tablet. [18:59:24] kaity: lunch? [18:59:26] Well all that time ago I followed Yuvi's instructions and they worked for me. [18:59:35] moizsyed: vbamba lunch [19:00:36] violetto: yes [19:05:17] Deskana: your tablet is auto updating fine, right? [19:05:32] YuviPanda: Well, no. I had to go to Google Play to get it updated. [19:05:46] YuviPanda: But none of my apps auto-update. So that's probably a setting on my side. [19:05:48] Deskana: oh, so you had to go and hit the 'update' button in the app listing on play? [19:05:54] Deskana: aaah, yeah. you probably have it turned off [19:06:23] The date of my build makes me think it's the right one, so I'm unsure what their issue was. [19:06:44] Deskana: you can see the date in the left nav when you slide out. [19:06:48] Deskana: are you in the office at the moment? [19:07:04] Deskana: if you are, can you walk by and grab their devices and see if you can find an 'update' button on the play store listing? [19:07:18] YuviPanda: No, I'm not. Had to get up super early for a meeting so I stayed at home. [19:07:29] Deskana: maybe there's an EMP field around the office [19:07:37] let me make them one off builds anyway. [19:08:05] Deskana: oh fuck after seeing the date I just realized I signed my visa documents today as month 05 [19:08:10] thinking we are in may [19:08:11] fuck [19:09:11] Oops. [19:09:41] Deskana: the UK Visa staff were the most useless. I signed right in front of her eyes and she didn't say a thing. [19:09:44] oh well [19:09:54] 'Rejected: The Doctor detected' [19:10:08] I'd like to think they're sensible enough to not make a fuss over that... [19:10:17] but b'cracies man. [19:10:27] Maryana: do you have your test device handy? [19:10:46] Maryana: and if so, can you open up google play, search for 'wikipedia', and see if it has an 'update' button? [19:11:23] Deskana: I just realized, that the people who haven't managed to get auto update working were all people who tried the WMF test device (kenan, may, Maryana, howie). [19:11:27] maybe something's up with that [19:13:16] Oh, cool. [19:13:28] The Android app is written in Java. [19:13:33] Deskana: indeed. [19:13:38] * Deskana likes Java. [19:13:44] YOU MONSTER! [19:13:50] :P [19:14:26] Do you use Eclipse? [19:14:39] Deskana: no. IntelliJ [19:14:47] Deskana: IntelliJ + Maven [19:18:05] Are most Android apps written in Java? [19:18:09] Deskana: yeah. [19:18:15] Deskana: in fact, android *itself* is written in Java [19:18:21] most of the UI parts, at least [19:18:28] the core is all C/C++/Linux-kernel-fu. [19:18:35] I've been toying with the idea of teaching myself PHP to do some MediaWIki development... but fuck PHP. [19:18:38] I much prefer this idea. [19:18:41] woot! [19:18:54] Deskana: if you like Java I think you'll enjoy IntelliJ [19:19:02] which is a wonderful IDE [19:19:08] Does Android use Swing? [19:19:13] Or is that just for desktop? [19:19:46] Deskana: Swing is just for desktop, and even that is unmaintained now. SWT or somesuch is more popular now. [19:19:50] Deskana: Android has its own thing [19:20:13] Deskana: https://developer.android.com/training/index.html is wonderful resource, I highly reccomend [19:21:05] Wow, Swing is deprecated? Shows how out of touch I am. [19:21:08] Well, cool. Thanks! [19:22:18] Deskana: :D apparently the new 'GUI Library' is JavaFX http://www.oracle.com/technetwork/java/javafx/overview/faq-1446554.html#6 [19:22:48] Deskana: I'll be *very* happy to help with anything if you plan on spending some time doing Android stuff [19:23:45] I must focus on product management, but in my spare time I may dabble. We'll see. :) [19:24:05] Deskana: :) [19:24:47] Deskana: I'll be happy to help, as well [19:32:33] (03PS1) 10Yuvipanda: Bump version number for 2.0-alpha-2014-04-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130433 [19:32:55] dbrant: can you merge? just pushing out another android alpha release [19:33:07] dbrant: we should set you up with the keys when you visit SF :) [19:33:24] so far we've managed to avoid having to transfer the key over the internets, and I think we can keep doing that [19:35:18] yuvipanda do you have time for 1 question? [19:35:23] (03CR) 10Dbrant: [C: 032] Bump version number for 2.0-alpha-2014-04-29 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130433 (owner: 10Yuvipanda) [19:35:26] nuria: sure! [19:35:40] on the topic of apps 'pageviews' [19:35:55] are those now being reported somewhere? [19:36:09] nuria: not that I know of particularly, no [19:36:15] as of recent? [19:36:18] nuria: there was a mobile-l conversation where Oliver said something [19:36:40] nuria: http://lists.wikimedia.org/pipermail/mobile-l/2014-April/007049.html plus followups [19:36:47] ok [19:37:03] do apps use the api? yes.. right ( I know.... i ask this before) [19:37:09] nuria: yes, they do :) [19:37:12] *i have asked [19:37:21] nuria: they make two requests per page, and the requests are differentiatable [19:37:53] ok, and those are reported right? [19:38:19] mhurd: when you get a chance to look it over, i submitted a basic version of the migration & import hooked together — https://gerrit.wikimedia.org/r/#/c/130326/ [19:38:33] nuria: I have no idea, no. [19:38:41] nuria: oliver would be the one to know, I think. [19:38:49] okeis, will look at e-mail threda [19:38:51] *thread [19:38:54] nuria: :) [19:38:58] mhurd: it seems to work nicely as far as importing the entries, but the user has to manually load the pages before they’re available offline. do you think we need to run a batch import, or is that good enough? [19:39:04] gracias [19:39:07] nuria: :) [19:48:41] Maryana: I just pushed out an alpha update, should be on your device in a few hours or so [19:48:45] Maryana: assuming you have auto update turned on [19:49:02] brion: ping! [19:49:05] kk, will look out for it [19:49:07] yo [19:49:08] brion: I can't upload stuff into releases.wm.o [19:49:15] brion: since it is all owned by you! [19:49:19] are page titles supposed to be blue? [19:49:22] brion: and I'm not part of the mobileupld group either [19:49:25] YuviPanda: it should be group-owned [19:49:30] ah then we have to add you to the group :D [19:49:34] Maryana: supposedly. [19:49:34] file RT ticket i guess? :P [19:49:41] brion: it is group owned, yeah [19:49:48] brion: yeah. in the mean time can you upload a file for me? [19:49:50] YuviPanda: … according to whom? ;) [19:49:52] sure thing [19:50:06] Maryana: it was violetto's design, I believe [19:50:34] it's confusing. makes it look like a link [19:50:39] Maryana: I totally agree :) [19:50:57] Maryana YuviPanda what's happening [19:51:07] violetto: Maryana also does not like the blue colored titles. [19:51:26] yeah, it looks too much like a link [19:51:27] Maryana: I've found life to be better when you don't argue about colors with designers, so all the colors in the app are pretty much as I got them :D [19:51:36] colors, and fonts [19:51:39] especially fonts. [19:51:40] :D [19:51:55] YuviPanda: i just joined this convo, i need some context! [19:51:59] violetto: ah, so [19:52:01] are we talking about the article? [19:52:06] violetto: yes we are [19:52:10] in the android app [19:52:17] violetto: and Maryana thinks they look too much like a link [19:52:22] YuviPanda: in that case, we have decided to make it all #333 [19:52:31] alright then [19:52:59] YuviPanda: i didn't get around to changing all the assets cus it'll be easier if we just did everything face to face [19:53:02] or over hangout [19:53:03] i just started playing w/the android version, & that's just the first thing that jumped out at me [19:53:22] violetto: what assets? [19:53:28] violetto: and also what do you mean by 'make it all'? [19:53:40] Maryana: it was clear that we weren't doing any visual design refinements before the visual styling sprint [19:53:48] body and headings [19:54:00] is it this sprint? [19:54:10] all assets as in everything on the "design assets by page" trello board [19:54:39] violetto: I'm still confused. so you want to change all icons and such to #333? [19:54:47] YuviPanda: wouldn't it be better if we make visual changes over hangout [19:54:55] YuviPanda: nope, just text [19:55:04] violetto: oh. [19:55:19] let's not worry about it for now. it just confused me! [19:55:25] violetto: hmm, right. yeah, changing the assets sounds like a terrible idea without too much value [19:55:31] this should go into a story for the next sprint [19:55:33] violetto: file a bug so we won't forget? [19:56:20] YuviPanda: sure [19:56:39] tfinc: i think bugello is sending new bugs into the last sprint -- is that intended? [19:57:29] (03PS1) 10Yuvipanda: Change page title to #333 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130473 [19:57:31] (03PS1) 10Yuvipanda: Remove second copy of abusefilter.css & preview.css [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130474 [19:58:11] 3Wikipedia App / 3Generic: All text on article pages to #333 - 10https://bugzilla.wikimedia.org/64623 (10May) 3NEW p:3Unprio s:3normal a:3None Headings and body copy [19:58:16] brion: you haz email [19:58:39] brion: can you upload it and send me a link so I can email out to mobile-l? [19:58:58] Maryana: thats easy to fix [19:59:03] let me take care of it [19:59:09] YuviPanda: still waiting for it [19:59:14] fixed [19:59:18] cool [19:59:22] aha got it [19:59:29] gmail is always _sliiiightly_ laggy on binary attachments [19:59:34] bugello will add bugs to the highest numbered sprint that its been added to as a memember [19:59:36] i just added it [20:01:50] YuviPanda: ok uploaded and chgrp'd [20:02:04] don’t forget to send in a ticket for access to the group for future :D [20:06:10] tfinc: ok, sprint 29 is all clear now [20:15:48] vbamba: ping:? [20:22:37] Maryana: would be nice to get some input / progress on https://trello.com/c/u4W0dU0l/19-2-license-text-on-every-edit [20:24:50] where can i see how this is proposed to look like? [20:25:22] Maryana: vibha's comment. scroll down [20:25:32] Maryana: links to https://trello.com/c/zHmmH2xT/74-design [20:25:37] Maryana: which has the designs [20:25:38] ah, k, got it [20:25:50] Maryana: it already is a bit inconsistent (no canned summaries in Android, for example) [20:27:06] YuviPanda: for the saved pages migration, should i try to actually fetch the remote pages at migration time, or just insert SavedPage records and let them get filled in on visit? (assuming that will work) [20:27:29] brion: we definitely should fetch them at migration time, put up a progress bar, all that jazz, I think. [20:27:34] ok [20:27:39] i’ll go whole-hog then :D [20:27:40] brion: filled in on visit sounds like the worst, since we show that it exists and then it doesn't [20:27:47] hehe yeah [20:28:05] brion: should still split it up into one thing that just reads the older data and another part that actually does the import [20:28:14] i’m wondering if we should make that something you can cancel or delay though [20:28:14] brion: and we should keep them in a package by themselves (savedpagesimport?) [20:28:37] yeah i’ve got a simple DataMigrator class that reads the old data, it should stay encapsulated pretty well [20:28:39] brion: we should, because the network can fail during first import [20:28:44] yeah [20:28:47] or just not be available [20:28:51] if we updated online, then launched offline [20:29:32] would it be insane to have a little popup bar at the bottom of the screen or something with the ‘finish migrating data’ button? or should we keep that someplace like the main menu [20:29:37] or on the saved pages specifically [20:30:03] brion: let's get it running first and then figure out the UI [20:30:04] i’m still thinking about best way to do that on ios too, currently it’s inserting the records but i haven’t added the fetch yet. same UI questions on that side [20:30:08] ok [20:30:09] YuviPanda: lemme chat w/vibha about this.. i'm having trouble understanding what's going on in the flows, which is for android/iOS, etc. [20:30:16] Maryana: cool [20:30:19] i'll get back to you by EOD [20:30:31] Maryana: do try out the current flows on android and iOS as well, since sometimes they differ (and sometimes are buggy) [20:30:44] i didn't see any license text on android [20:30:49] is there supposed to be? [20:30:58] Maryana: no, it isn't. hence my questions on the card before I implement it. [20:31:36] gotcha. i just meant there's not even the cc-by-sa icon, which IIRC is in the current ios build [20:32:22] ok i’m gonna grab some lunch then back to the migration code [20:32:26] Maryana: what CC-By-SA icon? I've not heard of that until now :| [20:33:11] Maryana: the one on the top bar? I remember seeing it in some screenshots but that was a long time ago, nothing in any designs. [20:33:21] Maryana: anyway do talk to vibha and respond on the card :) I should be asleep in about 30m hopefully [20:33:35] oh, nm, i imagined it [20:33:40] just checked and it's not there [20:33:59] will do [20:34:30] Maryana: ah, ok. [20:35:19] Maryana: you didn't fully imagine it. we both saw https://trello-attachments.s3.amazonaws.com/52e98a603e6d08a53861025b/531799dfc55d38b46d5cddba/2872x1483/3b90091140d8eddc18b515ddb5534103/StopGap_SignedoutEditing.png :) [20:35:26] hehe [20:35:31] inception! [20:35:37] hehe :) [20:35:39] cardception [20:40:25] brion: woot to see migrating app data move to CR [20:41:59] dbrant: also, i have yet to give you props on your Euler avatar image [20:42:02] dbrant: well played [20:42:42] tfinc: ty! ;) [20:44:14] awjr: do you happen to have a link to the (defunct) MW mingle board? [20:45:23] dbrant: do you do project Euler? [20:46:04] YuviPanda: I used to... I did all the problems up to 300. [20:46:14] dbrant: oh wow [20:46:33] dbrant: I've done about 20, but my math is not even close to good enough. I usually use it as a way to test out a new language. [20:46:56] YuviPanda: ...but the problems get too contrived to be fun anymore. [20:47:19] dbrant: yeah. they got that way for me at 30 :D [20:51:08] dbrant: I've a couple of smaller patches up for review. do take a look when you've the time. [20:51:41] YuviPanda: ok. I'm about to drop one like it's hot. [20:51:52] mmm! [20:52:33] brion: sry was afk [20:54:34] (03PS3) 10Dbrant: Fixed crash on nonexistent pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130226 (https://bugzilla.wikimedia.org/62639) [20:56:23] brion: meeting - will cr more right after [20:56:31] YuviPanda: ^ so, this takes care of disabling ToC on nonexistent pages, and it also seems to fix https://bugzilla.wikimedia.org/show_bug.cgi?id=64277, but I'm not sure why. [20:56:47] brb [20:57:09] dbrant: yeah, I'm not sure why that happens at all [20:57:12] looking at new PS now [21:00:11] (03CR) 10Yuvipanda: "Minor nit, otherwise looks good." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130226 (https://bugzilla.wikimedia.org/62639) (owner: 10Dbrant) [21:00:20] dbrant: woot. minor nitpick. am testing it now. [21:01:05] Maryana: aye [21:01:20] it's gonna look really weird though [21:01:21] https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/grid?aggregate_property%5Bcolumn%5D=story+points&aggregate_type%5Bcolumn%5D=sum&color_by=type&filters%5B%5D=%5BType%5D%5Bis%5D%5BStory%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BTask%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BBug%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BInfrastructure%5D&filters%5B%5D=%5BIteration%5D%5Bis%5D%5B%28Current+iteration%29%5D&group_by%5Blane%5D=status&lanes=Ready+for+D [21:02:04] actually it should look normal now, basically in the state we last left it [21:05:29] YuviPanda: so should 'DisableableSlidingPaneLayout' also be 'styled' in some way? [21:05:40] YuviPanda: or do you mean just put it in that package? [21:05:55] dbrant: put it in that package, yeah. [21:06:05] dbrant: we can rename that package to something else too if we want. [21:06:14] I can't think of anything right now, though. [21:07:18] alright; need to step out for a dinner date. I can CR those when I return [21:07:43] dbrant: cool! I'll test it in the meantime as well. [21:13:11] YuviPanda: ok i’m thinking for the migration… first step, add ‘saved’ entries’ second step: go through all saved entries and refresh them (showing a progress bar, cancel, and all that). this would go a long way towards providing a general ‘refresh all old saved pages’ feature if we want one too [21:13:23] YuviPanda: does that make sense or should i do both pieces of the migration together for sure? [21:13:37] brion: yeah, that sounds solid. [21:13:41] excellent [21:14:02] brion: hmm, we should also have a 'version' field in the saved page table, so we can upgrade the backing store without having to upgrade them all at once later on in the future [21:14:18] brion: and we can also use that as a way to track the pages that need fetching [21:14:36] hmmm yeah prolly [21:14:51] there’s a timestamp but that’s pretty vague [21:15:47] brion: yeah, that's useless I think. we need an explicit 'version' thing there [21:15:58] brion: should make future migrations much easier and foolproof too [21:16:04] whee [21:16:38] brion: ok, so one commit just for that, and then one that brings in old data into new data (and gives it a version number of 0 or something), and then we do the UI [21:17:07] \o/ [21:17:27] brion: easier to review / merge too [21:32:48] brion: YuviPanda: have you ever seen Evernote do its internal data store upgrades across versions ? [21:32:58] tfinc: hmm, no. [21:33:01] i have not [21:33:02] * YuviPanda uses Keep [21:33:03] its really good and i never worry about it [21:33:14] but its effectively doing the same thing as were doing here [21:33:16] ‘not destroying your data’ is always a nice feature [21:33:21] upgrade its internal data store for 'stuff' [21:33:38] i've never had issues with it and i never worry about it [21:33:42] (03CR) 10MaxSem: "Do we have any stats on how much is this going to reduce the number of requests?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130383 (owner: 10Jdlrobson) [21:33:51] we need ours to be as reliable for the migration and going forward [21:40:23] awjr: so for the stuff in the done pile from last sprint that's supposed to go out to stable, will that happen on thursday for enwiki? [21:40:34] deployment train, how does it work? [21:40:36] ;) [21:40:40] Maryana: depends on when it was merged [21:40:48] Maryana: sec [21:41:44] err, centralnotice seems to be showing up on mw.org on mobilefrontend [21:42:06] the message about the phabricator rfc [21:45:04] brion: testing the import stuff [21:48:36] brion: seems solid. i don’t have ios 6 device w/ me at the moment. is good w 6? [21:49:40] brion: as to the offline availability, i’m down with handling that, if we want to, as separate commit [21:51:02] mhurd: sounds good. i might get to it tonight, but will poke android into shape first [21:51:07] whee [21:51:18] seems to work on 6 as well yeah [21:52:19] uh-oh rebase error :D [21:53:09] brion: i may already have methods in place to do the bulk of the retrieving for offline availability stuff… will have to check [21:53:24] mhurd: worst case i’ll just load them up in web views in sequence ;) [21:53:27] but ncie if we can avoid that [21:54:26] brion: hehe, yeah, def avoid that :) [21:55:34] brion: wanna merge your importer for now? [21:55:41] yeah i’m tidying up the rebases now [21:55:45] ah [21:56:49] ok … grrrit-wm poke poke we miss you where are you? [21:56:59] brion: hehe [21:56:59] it must be behind :D [21:57:34] ah i’ve got an irc rfc meeting, be back in a while [21:57:41] brion: oh, time to cr those 3 other small ios patches from yesterday? [21:57:49] ah ok [21:57:51] will after [21:57:55] :) [22:03:45] (03CR) 10Jdlrobson: "No stats - but a no brainer. If a user clicks refresh on nearby and they are still at the same location there is no point in hitting the a" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130383 (owner: 10Jdlrobson) [22:14:58] 3MobileFrontend / 3stable: Close icon in references drawer doesn't work - 10https://bugzilla.wikimedia.org/64629 (10Juliusz Gonera) 3NEW p:3Unprio s:3normal a:3None Open a reference, try to close it with X. Doesn't work. [22:15:25] 3MobileFrontend / 3stable: Close icon in references drawer doesn't work - 10https://bugzilla.wikimedia.org/64629#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/MRyRKOhg [22:17:12] 3MobileFrontend / 3beta: JavaScript doesn't work on Special:MobileDiff - 10https://bugzilla.wikimedia.org/64630 (10Juliusz Gonera) 3NEW p:3Unprio s:3normal a:3None Uncaught Error: Unknown dependency: mobile.mobilediff.scripts [22:20:25] 3MobileFrontend / 3beta: JavaScript doesn't work on Special:MobileDiff - 10https://bugzilla.wikimedia.org/64630#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/dqnajTy3 [22:25:40] (03CR) 10JGonera: [C: 04-1] ".background-image() mixin should not be used more than once with the same image. Right now there are 2 instances with edit.png and 3 insta" (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 (owner: 10Jdlrobson) [22:29:26] 3MobileFrontend / 3stable: Article titles not centered vertically in search overlay - 10https://bugzilla.wikimedia.org/64633 (10Juliusz Gonera) 3NEW p:3Unprio s:3normal a:3None Created attachment 15246 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15246&action=edit It's a file. It's nice. It... [22:30:25] 3MobileFrontend / 3stable: Article titles not centered vertically in search overlay - 10https://bugzilla.wikimedia.org/64633#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/VvhmjsYY [22:32:39] 3MobileFrontend / 3beta: JavaScript doesn't work on Special:MobileDiff - 10https://bugzilla.wikimedia.org/64630#c2 (10Jon) I can't replicate this on current master... [22:33:33] good night everyone [22:33:40] 3MobileFrontend / 3Hygiene: Tables on mobile are a big fat mess - 10https://bugzilla.wikimedia.org/64577#c3 (10Christopher Yeleighton) (In reply to Jon from comment #1) > Note: The existing hack makes use of !important as this is the only way to > override an inline style. See also bug 64578 You start an ar... [22:40:01] MaxSem: https://bugzilla.wikimedia.org/show_bug.cgi?id=51584 [22:40:26] 3MobileFrontend / 3Hygiene: Tables on mobile are a big fat mess - 10https://bugzilla.wikimedia.org/64577#c4 (10Christopher Yeleighton) I can see from your description that the problem is that the flowing text on a page containing a table becomes too wide. Maybe it would be better to limit the text width and... [22:51:10] MaxSem: http://stackoverflow.com/a/15152232 [22:56:56] 3MobileFrontend / 3General/Unknown: table width is marked !important - 10https://bugzilla.wikimedia.org/64516#c13 (10Christopher Yeleighton) A bug should be declared INVALID when it is irrelevant, bogus, unintelligible, if it gets the facts wrong. What is your reason for invalidating this one? I disagree wi... [22:59:43] jgonera: would you mind covering me at standup tomorrow AM? i have a minor dog emergency and have to take her to the vet in the morning [22:59:57] sure awjr [23:00:02] thanks jgonera, i appreciate it [23:05:28] (03CR) 10JGonera: "Two inline comments (especially the one about docs)." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [23:05:39] brion: woohoo importer! [23:10:41] 3MobileFrontend / 3Hygiene: QUnit tests hit API - 10https://bugzilla.wikimedia.org/64635 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon Visit http://localhost.beta/w/index.php/Special:JavaScriptTest/qunit?r=4# Watch all the requests to the api. These should all be stubbed. [23:14:44] MaxSem: did i already ask if section “level” and “id” are always integers? (transclusion “T-“ index values have me questioning my assumptions) [23:15:03] level is [23:15:07] ...I think [23:16:11] 3MobileFrontend / 3Hygiene: Upstream getToken code in MobileFrontend into core - 10https://bugzilla.wikimedia.org/64636 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon In MobileFrontend we have support for requesting cross domain tokens using centralauth token. This should be upstreamed into core. [23:17:08] MaxSem: hmm level seems to be a string… [23:17:48] eh [23:18:01] but string containing numbers:P [23:18:10] it's PHP! [23:19:04] (03PS1) 10Jdlrobson: Deal better with expired edit tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) [23:19:25] mhurd, https://test.wikipedia.org/wiki/For_Monte [23:20:03] (03CR) 10jenkins-bot: [V: 04-1] Deal better with expired edit tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) (owner: 10Jdlrobson) [23:20:26] 3Wikipedia App / 3Generic: iOS Alpha: Clicking on a revision in page history does nothing, should show revision or diff - 10https://bugzilla.wikimedia.org/64637 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None What it says on the tin. [23:20:39] 3Wikipedia App / 3Generic: iOS Alpha: Clicking on a revision in page history does nothing, should show revision or diff - 10https://bugzilla.wikimedia.org/64637 (10Dan Garry) p:5Unprio>3Normal [23:21:51] tfinc: Can I just add acceptance criteria to things or do I only do it in the meeting? [23:22:07] tfinc: There's an extra acceptance criteria I want to add to "handle redirect!" in the current sprint. [23:23:14] The reason I'm asking is I don't want to add an acceptance criteria and surprise the relevant engineer if, say, they only check the acceptance criteria in the meeting. [23:23:33] What's the process? [23:24:03] Deskana: good question [23:24:50] Deskana: if a story has already been started then id recommend creating a new story and then putting it into the next sprint [23:24:56] 3MobileFrontend / 3Feature requests: mobileview should return __NOEDITSECTION__ status - 10https://bugzilla.wikimedia.org/64638 (10Max Semenik) 3NEW p:3Unprio s:3normal a:3None ...to avoid us being silly and suggesting people to edit sections on main pages and portals. Will probably require a core tw... [23:25:14] if it hasn't been started then i'd consider adding it and then asking the engineers to re-estimate. then you can decide if you still want it [23:25:24] 3MobileFrontend / 3Feature requests: mobileview should return __NOEDITSECTION__ status - 10https://bugzilla.wikimedia.org/64638#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/JKM73Wdn [23:26:10] Deskana: does that answer your question ? [23:26:33] It's not clear whether it's a separate story to me. [23:27:01] So, the acceptance criteria I wanted to add was "If you find a page by a redirect, viewing page history shows the redirect of the target page, not the history of the redirect" [23:27:12] Deskana: is the story already being worked on ? [23:27:18] I'm not clear whether that's implicit in "handle redirects!" or not. [23:27:22] Yeah, it's assigned to mhurd. [23:27:35] Deskana: i'm guessing its this one https://trello.com/c/7aZObVbl/2-2-handle-redirects which monte was ready to finish up [23:27:36] So I guess I'll file a separate bug for it. We can just close the card if it ends up being handled. [23:27:39] mhurd: --^ [23:27:43] yup [23:27:55] Okay. That's very helpful. [23:27:57] since the story is already getting worked on lets wait and see if its still an issue [23:27:57] Thanks! [23:29:39] 3Wikipedia App / 3Generic: iOS: When a page is found via a redirect, viewing the page history should show the history of the target page, not the redirect - 10https://bugzilla.wikimedia.org/64639 (10Dan Garry) p:5Unprio>3Normal [23:29:41] 3Wikipedia App / 3Generic: iOS: When a page is found via a redirect, viewing the page history should show the history of the target page, not the redirect - 10https://bugzilla.wikimedia.org/64639 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None What it says on the tin. [23:29:46] Deskana: tfinc: hmm i’m not sure about the page history redirect issue - so yeah probably separate card [23:30:20] mhurd: Great. Thanks. [23:30:36] Deskana: tfinc: having said that, hopefully the patch i’m working on now will clear the issue up :) [23:31:15] yup, we'll test on the next build and *if* its an issue we'll cut a new story or bug [23:33:01] MaxSem: hehe section “number”… happens to be a string :) [23:33:09] Is it preferred to file a bug and wait for Bugello or just write a card? [23:36:24] jdlrobson, I can't find the patch with VE help button, can you send me a link? [23:36:51] jdlrobson, ^ [23:36:55] jdlrobson_, ^ [23:37:10] Deskana: either one is fine [23:38:41] (03PS8) 10Jdlrobson: Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 [23:41:37] (03CR) 10MaxSem: Deal better with expired edit tokens (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) (owner: 10Jdlrobson) [23:42:21] (03PS7) 10Jdlrobson: Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 [23:43:09] 3MobileFrontend / 3beta: JavaScript doesn't work on Special:MobileDiff - 10https://bugzilla.wikimedia.org/64630#c3 (10Juliusz Gonera) You're in beta, right? [23:44:09] 3Wikipedia App / 3Generic: iOS: When editing a protected page, it should be obvious that the page is protected - 10https://bugzilla.wikimedia.org/64640 (10Dan Garry) p:5Unprio>3Normal [23:44:11] 3Wikipedia App / 3Generic: iOS: When editing a protected page, it should be obvious that the page is protected - 10https://bugzilla.wikimedia.org/64640 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Admins have the ability to edit pages that are protected. When they can do is governed by policy. On t... [23:44:50] violetto: i just saw jared's email about changes to design roles, i'll add you to the mobile web meetings [23:44:54] 3Wikipedia App / 3Generic: iOS: When editing a protected page, it should be obvious that the page is protected - 10https://bugzilla.wikimedia.org/64640 (10Dan Garry) [23:44:54] 3MobileFrontend / 3stable: API action=mobileview should support being able to return protection status of a page - 10https://bugzilla.wikimedia.org/59240 (10Dan Garry) [23:45:03] kaity: and for you - shall i remove you from the mobile web meetings or do you want to stay on? [23:45:25] (03PS2) 10Jdlrobson: Deal better with expired edit tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) [23:48:12] (03CR) 10jenkins-bot: [V: 04-1] Deal better with expired edit tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) (owner: 10Jdlrobson) [23:48:33] awjr: No, I'll keep going to meetings for the next couple sprints until the cards I've started are completed [23:49:30] okidoke [23:49:39] 3MobileFrontend / 3beta: JavaScript doesn't work on Special:MobileDiff - 10https://bugzilla.wikimedia.org/64630#c4 (10Jon) Yep. Nothing.. [23:49:48] oh i missed jared's footnote which basically said as much :p [23:51:09] 3MobileFrontend / 3beta: JavaScript doesn't work on Special:MobileDiff - 10https://bugzilla.wikimedia.org/64630#c5 (10Juliusz Gonera) Keeps happening for me every single time. [23:54:54] 3MobileFrontend / 3beta: JavaScript doesn't work on Special:MobileDiff - 10https://bugzilla.wikimedia.org/64630#c6 (10Jon) 5NEW>3RES/INV Update your Thanks extension See https://gerrit.wikimedia.org/r/#/c/111147/ [23:57:01] jdlrobson, I can't find the patch with VE help button, can you send me a link? [23:57:26] https://gerrit.wikimedia.org/r/#/c/125269/