[00:03:27] (03PS1) 10Jdlrobson: Close toasts on a click event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130782 (https://bugzilla.wikimedia.org/64270) [00:16:03] (03PS2) 10Jdlrobson: Close toasts on a click event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130782 (https://bugzilla.wikimedia.org/64270) [00:16:05] (03PS1) 10Jdlrobson: Fix the reference close button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130786 (https://bugzilla.wikimedia.org/64629) [00:16:33] greg-g, so I have to cherry-pick all the patches onto 1.24wmf2? [00:16:58] there are 9 patches since the branch was cut, 6 of them are relevant, the remaining 3 are not but look very minor [00:17:19] either that, or force it to ride the train via messing with the configs (cc James_F ) [00:22:09] jgonera: Could you not just feature-flag it on non-test wikis until next Thursday? [00:22:27] James_F, I'm cherrypicking now, will see how hard it is [00:22:35] OK. [00:26:20] greg-g, James_F does that look fine: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/VectorBeta+branch:wmf/1.24wmf2+topic:cpb-cherry,n,z ? [00:26:24] (03PS1) 10Kaldari: Make sure mobile VisualEditor is only loaded when appropriate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130794 (https://bugzilla.wikimedia.org/64681) [00:27:14] (03PS3) 10Jdlrobson: Close toasts on a click event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130782 (https://bugzilla.wikimedia.org/64270) [00:27:16] (03PS2) 10Jdlrobson: Fix the reference close button [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130786 (https://bugzilla.wikimedia.org/64629) [00:29:27] that's a ton... jgonera, not really a fan of that. [00:29:41] that's basically skipping all of our production site testing [00:29:43] greg-g, I know, although most of them are several lines long... [00:30:29] let's go with option 2: manual rollout via feature flag [00:30:30] well, we're enabling the beta feature anyway, so we either enable it broken and janky or not [00:30:47] which tells me it wasn't ready, honestly :) [00:31:14] Or, it's also a problem of reusing the VectorBeta extension [00:31:22] well, it wasn't since I worked on it for the past week [00:31:23] hm [00:31:37] should it be a separate extension for every beta feature? [00:31:45] IF this was a new extension that hasn't been on production at all yet, and was only merged/enabled in wmf3, then the config would be a no-op on wmf2 (fine) and work on wmf3 (fine) [00:32:03] ideally, in my opinion, jdlrobson disagress for reasonable reasons [00:32:09] (overhead) [00:33:01] (I might drop off at any minute, tethering on cell, if I don't respond that's why) [00:33:04] I kind of agree with jdlrobson because of how small this is [00:33:07] I see [00:33:12] who should make the final call then? [00:33:52] oh wait, I missed one of your messages [00:34:05] ok, so I should modify the config patch? [00:34:10] greg-g, ^ [00:34:27] well, me really, and I'm not really a fan of all those merges last minute before enwiki. Yeah, config it to be testwikis only (test, test2, mw, testwikidata) [00:34:52] * greg-g wonders what the status of that per-phase config file is.... [00:35:07] (which would make this a ton easier) [00:35:37] ok, are those the exact identifiers for those wikis? [00:35:52] "task add "ask reedy about the per-phase config file thing, if that was ever a thing" proj:wmf.releng pri:H due:tomorrow" :) [00:35:56] no [00:36:13] 3MobileFrontend / 3Hygiene: Tables on mobile are a big fat mess - 10https://bugzilla.wikimedia.org/64577#c5 (10Jon) Created attachment 15261 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15261&action=edit When zoomed out [00:36:28] 3MobileFrontend / 3Hygiene: Tables on mobile are a big fat mess - 10https://bugzilla.wikimedia.org/64577#c6 (10Jon) Created attachment 15262 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15262&action=edit when zoomed in without the !important hack [00:37:22] greg-g, and where can I find the exact identifiers? [00:37:25] James_F, ^ [00:37:58] 3MobileFrontend / 3Hygiene: Tables on mobile are a big fat mess - 10https://bugzilla.wikimedia.org/64577#c7 (10Jon) Which text would you limit? I've added the above two attachments which demonstrate the effect of dropping these rules. We could maybe considering use max-width instead.. ? [00:37:59] jgonera: Identifiers of what? [00:38:03] testwiki, test2wiki, mediawikiwiki, testwikidatawiki [00:38:08] jgonera: Oh, the test wikis? Yeah, what greg-g said. [00:38:13] 3MobileFrontend / 3General/Unknown: table width is marked !important - 10https://bugzilla.wikimedia.org/64516#c14 (10Jon) Having more than one bug around tables that can't be fixed mutually exclusively won't get this bug fixed any quicker, if anything it will add to confusion. I think it's important to colle... [00:38:13] ok [00:38:34] thanks much jgonera [00:38:51] sorry about this, my assumptions got the best of me this tie [00:38:54] +m [00:39:01] * greg-g doesn't wear ties [00:39:48] ok, going offline for the last bit of the journey, will be online tonight [00:39:56] ok, no worries, next time stop me from cherrypicking as soon as I mention that there are 6 patches ;) [00:40:08] haha will do :) [00:43:41] greg-g, James_F this looks ok? https://gerrit.wikimedia.org/r/#/c/130266 [00:44:04] jgonera: LGTM. [00:44:14] ok, cool ;) [00:48:07] eek. some major regressions in search behavior with the new Android build. [00:51:11] (03CR) 10Jdlrobson: [C: 04-1] Make sure mobile VisualEditor is only loaded when appropriate (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130794 (https://bugzilla.wikimedia.org/64681) (owner: 10Kaldari) [00:53:14] (03CR) 10Jdlrobson: mobileview: return editable status (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109939 (owner: 10MaxSem) [00:58:03] (03PS3) 10Dbrant: Hiding the "repeat password" field when "display password" enabled [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130368 (https://bugzilla.wikimedia.org/64408) [00:58:15] (03CR) 10Kaldari: Make sure mobile VisualEditor is only loaded when appropriate (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130794 (https://bugzilla.wikimedia.org/64681) (owner: 10Kaldari) [01:00:59] 3Wikipedia App / 3Search: Content before colon does not show up in search - 10https://bugzilla.wikimedia.org/64688 (10Sage Ross) 3NEW p:3Unprio s:3major a:3None If I begin typing something and some of the results include a colon, everything up to the colon gets removed from the displayed results. Fo... [01:03:32] (03PS4) 10Dbrant: Hiding the "repeat password" field when "display password" enabled [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130368 (https://bugzilla.wikimedia.org/64408) [01:03:58] (03PS2) 10Kaldari: Make sure mobile VisualEditor is only loaded when appropriate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130794 (https://bugzilla.wikimedia.org/64681) [01:13:14] 3Wikipedia App / 3Generic: Broken anchor links open in browser and redirect to wikipedia.org landing page - 10https://bugzilla.wikimedia.org/64690 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None If an article has abbreviated anchor links, such as [[#foo]] in the article "bar", but there is no correspo... [01:25:00] 3Wikipedia App / 3Generic: Links to pages without mobile view unexpectedly toss to browser - 10https://bugzilla.wikimedia.org/64691 (10Sage Ross) 3NEW p:3Unprio s:3normal a:3None Now that bug 62639 is resolved, if a link (or a search result) is tapped and the app doesn't know how to handle the page (... [01:25:42] 3Wikipedia App / 3Generic: App crashes if you open a non-existing page - 10https://bugzilla.wikimedia.org/62639#c9 (10Sage Ross) 5PAT>3RES/FIX Resolved the latest build, but see bug 64691 related to the way it was resolved. [01:45:58] 3MobileFrontend / 3Feature requests: Sometimes closing an overlay triggers browser back behavior - 10https://bugzilla.wikimedia.org/60848#c10 (10Jon) *** Bug 64686 has been marked as a duplicate of this bug. *** [02:40:45] 3Wikipedia App / 3Generic: RTL support in page body in the app (language variant issues) - 10https://bugzilla.wikimedia.org/64420#c9 (10Liangent) (In reply to Yuvi Panda from comment #8) > @liangent: Looks good to me? This was RTL wiki in LTR device. Hmm it seems you're testing it using hi, but I'm using ar. [02:59:03] 3Wikipedia App / 3Generic: Page content is duplicated on main page - 10https://bugzilla.wikimedia.org/64694 (10Liangent) 3NEW p:3Unprio s:3normal a:3None Tested on zhwiki [03:04:33] 3Wikipedia App / 3Generic: "Full article" links on zhwiki main page don't work - 10https://bugzilla.wikimedia.org/64695 (10Liangent) 3NEW p:3Unprio s:3normal a:3None They're located after ">>". [08:23:18] (03PS1) 10Yuvipanda: Upgrade Android Saripaar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130814 (https://bugzilla.wikimedia.org/64615) [08:23:44] 3Wikipedia App / 3Generic: Page content is duplicated on main page - 10https://bugzilla.wikimedia.org/64694#c1 (10Yuvi Panda) Caused by https://bugzilla.wikimedia.org/show_bug.cgi?id=64663 [08:24:30] 3Wikipedia App / 3Generic: RTL support in page body in the app (language variant issues) - 10https://bugzilla.wikimedia.org/64420#c10 (10Yuvi Panda) Indeed. I can repro LTR issues with ar. I'll take a look. [09:07:51] (03PS1) 10Yuvipanda: Show namespaces in search results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130817 (https://bugzilla.wikimedia.org/64688) [09:08:29] 3Wikipedia App / 3Generic: Keyboard doesn't hide when I navigate to left drawer - 10https://bugzilla.wikimedia.org/64339 (10Yuvi Panda) 5PAT>3RES/FIX [09:10:59] 3Wikipedia App / 3Generic: Main Page ToC is empty - 10https://bugzilla.wikimedia.org/64693 (10Yuvi Panda) [09:10:59] 3Wikipedia App / 3Generic: No ToC is shown on main page - 10https://bugzilla.wikimedia.org/64693#c1 (10Yuvi Panda) ToC is empty on the main page since there is only one section. It should either: 1. Show individual sections (needs fixing action=mobileview) 2. Not let you see ToC I'm inclined towards (2) [09:17:38] wireless usb debugging is the best [14:35:15] 3Wikipedia App / 3Generic: Main Page ToC is empty - 10https://bugzilla.wikimedia.org/64693#c2 (10Sage Ross) I can imagine at some point down the road including additional information in the ToC drawer, such recent changes to the page, page view stats (we can hope, can't we?) and other advanced tools for powe... [15:00:16] 3MobileFrontend / 3Hygiene: Tables on mobile are a big fat mess - 10https://bugzilla.wikimedia.org/64577#c8 (10Christopher Yeleighton) Yes, I thought about max-width, except that I do not want to get stung by folks who insist on supporting ancient browsers. I also understand that the scroll bars are not sho... [15:24:13] hey YuviPanda! [15:24:30] dbrant: hey! [15:24:36] dbrant: good morning! [15:25:16] dbrant: nice refactoring work with the create account patch [15:25:41] YuviPanda: oh good; I was hoping it wasn't too much [15:26:13] YuviPanda: I just thought that the Utils file was getting too diverse. [15:26:13] dbrant: ideally it would be in another commit but it's ok. You should mention it in the commit message though [15:26:18] dbrant: yeah, agreed. [15:26:26] there's some saved pages stuff there I need to move out [15:26:56] YuviPanda: could I get your opinion re: https://bugzilla.wikimedia.org/show_bug.cgi?id=64691 [15:27:45] YuviPanda: if we're going to have a dialog asking if the user if they want to visit an external link, then do we still need the WP-Zero interstitial dialog? [15:28:00] dbrant: I'll respond, but I don't like the dialog idea at all. [15:29:26] dbrant: too much work. Also I remember some websites doing that (you are about to leave X, are you sure?) which I always hated. [15:29:36] dbrant: I'd most probably close it as WONTFIX at some point [15:29:45] dbrant: the Zero interstitial makes sense since there is monetary cost involved [15:30:42] ragesoss: ^ [15:31:05] dbrant: although, I think, if we can somehow figure out if that is an external link, noting that subtly might be a good idea [15:31:34] I don't like dialogs if I know I'm going to end up outside the app before clicking. [15:31:45] 3Wikipedia App / 3Generic: Display indicator if any action will open in an external browser - 10https://bugzilla.wikimedia.org/64691 (10Yuvi Panda) [15:32:00] but I also don't like not knowing at any moment whether clicking a link will toss me out of the app. [15:32:29] 3MobileFrontend / 3Feature requests: MobileFrontend doesn't support PostgreSQL - 10https://bugzilla.wikimedia.org/46745#c4 (10Andre Klapper) (In reply to Jon from comment #2) > Status? Do we really want to fix this? And who is "we"? Mobile team? Community? If mobile team wouldn't want to fix it, would it st... [15:32:30] 3Wikipedia App / 3Generic: Display indicator if any action will open in an external browser - 10https://bugzilla.wikimedia.org/64691#c1 (10Yuvi Panda) I think an interstitial is too drastic, but displaying an icon or somesuch might not be a bad idea, provided we can make that determination very fast. [15:32:38] because part of the benefit of the app is that it's more responsive than a browser, and the time it takes to switch to browser and load is quite annoying. [15:33:08] ragesoss: I retitled and such. Is this acceptable? [15:33:21] yeah, that's a good solution. [15:33:29] YuviPanda: so, like, a special icon next to external links? [15:33:37] and I assume that over time, more and more of the links will actually be handle-able by the app. [15:33:48] dbrant: well, all links that are external (including special pages) should have an indicator of some sort [15:34:23] dbrant: we could probably do it next sprint or so. I want us to fix all the crashing bugs first [15:36:30] 3Wikipedia App / 3Generic: Various links on image page crash the app - 10https://bugzilla.wikimedia.org/64425#c1 (10Yuvi Panda) Can't really fix the page much this iteration, but we can definitely make sure the links don't crash. [15:38:09] dbrant: am wondering how to handle https://bugzilla.wikimedia.org/show_bug.cgi?id=64403 [15:38:52] edit numbers will be out of whack, etc [15:39:39] YuviPanda: I'm not quite sure I understand the necessity of "saving" pages... [15:39:51] dbrant: me neither. I detest that 'feature'. [15:40:07] dbrant: maybe I can convince Maryana or Deskana to let us remove it at some point. [15:40:51] dbrant: Ideally we could convert them into bookmarks of some sort [15:41:24] dbrant: if we want to save a page, sharing it with pocket works great. or any of the similar apps. [15:41:39] hmm, let's at least rename them to be bookmarks, [15:41:44] YuviPanda: so we're actually saving the full content of the page? not just a bookmark? [15:41:50] dbrant: indeed [15:41:52] and the images [15:42:05] and it doesn't auto update. [15:42:23] X( [15:42:52] dbrant: yeah. [15:44:24] dbrant: gah, my trackpad seems to have died. let me restar [15:44:24] t [15:44:27] stupid OS X [15:49:16] dbrant: back [15:52:58] ggah, fucking OS X AGAIN [15:53:00] 3MobileFrontend / 3Feature requests: MobileFrontend doesn't support PostgreSQL - 10https://bugzilla.wikimedia.org/46745#c5 (10Jon) It's an open question. We can be anyone. I don't know how much work is involved in this and I wasn't sure who cared about this and there has been no activity on the bug since it... [15:53:01] keeps freezing my mouse [15:53:19] lol [15:59:18] (03CR) 10Yuvipanda: [C: 032] Hiding the "repeat password" field when "display password" enabled [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130368 (https://bugzilla.wikimedia.org/64408) (owner: 10Dbrant) [15:59:36] :) [16:00:09] (03Merged) 10jenkins-bot: Hiding the "repeat password" field when "display password" enabled [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130368 (https://bugzilla.wikimedia.org/64408) (owner: 10Dbrant) [16:00:16] dbrant: :) [16:00:18] dbrant: I have a couple of patches waiting for CR, can you take a look? [16:00:24] dbrant: I'm also going to rename 'Saved Pages' to bookmarks [16:00:25] YuviPanda: sure [16:00:43] YuviPanda: good idea; that's what they should be [16:00:49] dbrant: yeah, agreed [16:01:07] dbrant: once on an early early version of the old phonegap app, we broke saved pages migration due to a phonegap bug [16:01:19] dbrant: and people complained. and ever since then I've been failing in my quest to get rid of that misfeature. [16:01:43] YuviPanda: ha! [16:05:55] YuviPanda: so what's android-saripaar? [16:06:52] YuviPanda: nm, I looked it up [16:07:58] dbrant: :) [16:08:22] YuviPanda: does IntelliJ fetch the updated dependencies automatically? [16:08:39] dbrant: ah, right. right click the project in the left pane and select 'maven -> reimport' [16:08:43] or something like that. [16:08:47] should make it re-read the POM files [16:10:22] (03CR) 10Dbrant: [C: 032] Upgrade Android Saripaar [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130814 (https://bugzilla.wikimedia.org/64615) (owner: 10Yuvipanda) [16:13:54] (03CR) 10Dbrant: [C: 032] Show namespaces in search results [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130817 (https://bugzilla.wikimedia.org/64688) (owner: 10Yuvipanda) [16:24:44] (03PS1) 10Yuvipanda: Rename Saved Pages to Bookmarks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130855 [16:24:45] dbrant: ^ [16:24:59] dbrant: the 'import saved pages' card is in progress with brion, so I don't want to rename the files now [16:25:08] since that'll be a painful merge [16:25:31] YuviPanda: go ahead, i’ll clean it up [16:26:25] brion: alright then! [16:26:50] brion: I'm going to rewrite the tablename too [16:26:55] wheeee [16:27:05] brion: I don't think we need to migrate people who were in the alpha. As long as we don't crash it's cool [16:27:28] yeah that’s fine [16:37:30] 3MobileFrontend / 3Hygiene: Tables on mobile are a big fat mess - 10https://bugzilla.wikimedia.org/64577#c9 (10Jon) Luckily I don't care too much for ancient browsers - especially in this case as it doesn't effect readability. Luckily in mobile these are not such an issue - most mobile devices support max-wi... [16:41:17] 3MobileFrontend / 3Hygiene: Manage z-index with LESS variables - 10https://bugzilla.wikimedia.org/64707 (10Jon) 3NEW p:3Unprio s:3normal a:3Jon z-index's can be a pain and result in z-index wars where the z-index continues to get upped! Let's create some LESS variables that define logical layers for... [16:44:30] (03CR) 10Jdlrobson: [C: 04-1] "Comments on JS from PS1 still stand." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130794 (https://bugzilla.wikimedia.org/64681) (owner: 10Kaldari) [16:52:45] 3MobileFrontend / 3alpha: VE - Close button doesn't work - 10https://bugzilla.wikimedia.org/64576#c2 (10Jon) Kaity - where are you seeing this? I cannot replicate this issue on current master. [17:05:22] (03PS1) 10Jdlrobson: QA: Use less specific selector for VE tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130864 [17:06:08] Maryana: tfinc can you mention who all are in the office? [17:06:44] Maryana: ty! [17:09:17] Deskana: dammit, I was gonna name you MrGarrySir [17:09:31] :) [17:18:22] jdlrobson: Hey Jon, I think you missed my comment in the previous commit: https://gerrit.wikimedia.org/r/#/c/130794/2/javascripts/modules/editor/editor.js [17:18:54] jdlrobson: the 2nd param isn't a default fallback, it's a cookie flag [17:23:04] YuviPanda, brion, dbrant|lunch: I like how bug 1 is still "NEW". [17:23:15] Deskana: forevernew [17:23:15] lol [17:23:23] wontfix? ;) [17:23:25] :D [17:24:05] It should be RESOLVED INVALID due to the only fix being to stop time. [17:29:00] 3MobileFrontend / 3Feature requests: MobileFrontend doesn't support PostgreSQL - 10https://bugzilla.wikimedia.org/46745#c6 (10Arthur Richards) At the risk of speaking for the WMF mobile team's product owner, this is not something the mobile team will work on - at least not in an organized/prioritized/etc way... [17:37:41] dr0ptp4kt, are we doing anything with the check? [17:37:56] what's that? [17:38:08] you talking about the automation script yurikR? [17:38:30] dr0ptp4kt, there is something on my calendar that you organized [17:38:44] yurikR, just sent an email about that. looks like no luck on either front [17:38:47] see email [17:39:03] thx, i guess we should wait for the new cert [17:40:35] dbrant|lunch: thoughts on spending some time documenting the app code, cleaning it up a bit, and fixing our tests? [17:42:31] (03PS4) 10MaxSem: Preserve URL parameters when toggling view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129612 (https://bugzilla.wikimedia.org/64318) [17:46:52] YuviPanda: I'll continue trying to add good comments / javadoc with every modification that I make... [17:46:59] dbrant: woo! [17:47:05] dbrant: feel free to refactor as you see fit too [17:47:19] Deskana: damn, I just realized I haven't replied to a bunch of the older mails [17:47:36] dbrant: https://trello.com/b/Id6qXKSY/mobile-app-latest-design-assets-by-page [17:47:46] YuviPanda: ...as for high-level documentation, I still need to learn more of the code! [17:48:08] Deskana: OTRS was sending them to spam for a while, and then pajz helped me bring them back and I forgot to do anothe rpass [17:49:01] YuviPanda: when's a good time for you during the day to sync up w/me & vibha? [17:49:14] we should probably just schedule a regular checkin [17:49:23] mornings? [17:49:31] (sf time mornings, that is) [17:52:39] Maryana: ah, hmm. DST messes things up a bit, but right before SF lunch would be ideal time [17:52:57] Maryana: 11AM PDT? [17:53:22] Maryana: also we shouldn't solely rely on that. I've been trying to switch my sleep cycle to 'normal', and that definitely requires async comms... [17:55:53] hmm, ok [17:56:00] it's pretty tough to do async design discussions [17:56:08] not impossible, but definitely a lot harder [17:56:51] Maryana: true, and I am usually on for another two hours (or three) at the least [17:58:51] dbrant: brion here's a saved pages proposal: 1. Call it 'Bookmarks, 2. Get rid of locally saving them offline, 3. Make sure we import them from the old app [17:59:01] hehe [17:59:03] that works :D [17:59:05] dbrant: brion if there's demand from users for an offline saving capability later on, we can add that [17:59:09] dbrant: thoughts? [17:59:15] brion: this also means people won't lose their saved pages from old app. [17:59:18] YuviPanda: agreed! [17:59:38] Maryana: you guys ok with that? [18:00:05] much less complexity, and I've no idea where to even begin with making saved pages editable [18:00:18] they are currently also a subotpimal experience - they are 'stuck' where you first saved them, and auto update is a lot of work [18:00:23] which we aren't doing [18:00:32] and users have no idea they are reading an outdated version [18:00:47] also, on Android, it is *super trivial* to just 'add to Pocket' and read it there (which is what I do) [18:02:03] Deskana: ^ (re: bookmarks) [18:02:32] doing this will also give us a solid feature that works great, rather than a complex flaky feature. [18:02:34] DOWNSCOPE! :) [18:04:25] makes sense to me [18:04:29] wooot! [18:04:32] FINALLY WE KILL THAT MONSTER [18:04:41] I actually very literally did a fistbump into the air [18:04:47] :) [18:04:52] LET ME EXORCISE IT FROM TEH CODE [18:05:02] yay dbrant and brion :) [18:05:17] Maryana: thank you :) [18:05:20] hehehe [18:05:21] np! [18:05:24] ^^^ [18:05:26] ok that’ll make the rest of my day faster :D [18:05:39] :D [18:05:48] brion: I've renamed them all. NOW KILLING CODE [18:05:57] your job, let me make it easier [18:05:59] brion: can you wait a bit and rebase on top of mine? [18:06:03] yeah [18:06:09] should be done shortly [18:47:35] (03PS1) 10Yuvipanda: KILL SAVED PAGES, MAKE THEM JUST BOOKMARKS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130872 [18:47:36] dbrant: brion ^ WOO WOOOO! [18:47:43] \o/ [18:59:18] jgonera: https://bugzilla.wikimedia.org/show_bug.cgi?id=64709 < so I think this is the reason for slow VE [19:00:36] (03CR) 10Siebrand: [C: 031] "L10n reviewed." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130855 (owner: 10Yuvipanda) [19:01:04] (03PS2) 10Yuvipanda: KILL SAVED PAGES, MAKE THEM JUST BOOKMARKS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130872 [19:01:29] (03CR) 10Dbrant: KILL SAVED PAGES, MAKE THEM JUST BOOKMARKS (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130872 (owner: 10Yuvipanda) [19:02:31] dbrant: hah! We missed each other by a few seconds :D [19:02:36] dbrant: PS2 fixes exactly that [19:02:47] HappyPanda: ^ read my mind, apparently [19:02:52] dbrant: :D [19:16:08] jdlrobson, will have a look [19:18:40] dbrant: we should also set you up with access to our cluster [19:19:11] HappyPanda: cool! [19:19:53] dbrant: I'll send off the email for that shortly. [19:27:03] dbrant: sent. you'd have to put up your ssh key somewhere in a specific place, let me find the docs [19:27:46] HappyPanda: thanks! [19:28:15] dbrant: think you can CR the KILL patches anytime in the next 30mins? would love to make a release before I head to bed [19:28:44] dbrant: alright, you've to put your ssh public key on your officewiki user page. [19:29:04] HappyPanda: of course! [19:29:37] (03CR) 10Dbrant: [C: 032] KILL SAVED PAGES, MAKE THEM JUST BOOKMARKS [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130872 (owner: 10Yuvipanda) [19:31:00] dbrant: has a dependent change as well, I think [19:31:16] HappyPanda: ah, damn it [19:34:20] (03CR) 10Dbrant: [C: 032] Rename Saved Pages to Bookmarks [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130855 (owner: 10Yuvipanda) [19:40:03] brion: can you tell mhurd when he turns up? [19:45:33] dbrant: hmm, did you get the response email from andrew? [19:45:36] or is that coming just to me? [19:45:47] I didn't get it [19:49:02] dbrant: gah. [19:56:05] dbrant: re-added. [19:56:14] HappyPanda: got it [19:56:19] dbrant: cool [19:59:28] HappyPanda: still around? [19:59:38] matanya: yeah [19:59:50] intersted in bugs in the new app? [20:00:42] HappyPanda: ^ [20:00:48] matanya: ofcourse! :D [20:01:25] HappyPanda: on every page: last modified January 1 1979 [20:01:30] *1970 [20:01:37] matanya: yeah, I noticed that. let me file a bug to investigate [20:01:41] sounds like epoch to me [20:03:01] HappyPanda: opening specials pages open a browser without any notice, might be costy on data plans. you should warn before you do so [20:03:10] matanya: ah, hmm. question is how. [20:03:20] matanya: also how will it be costlier than browsing regular pages? [20:03:41] HappyPanda: if the are saved pages [20:03:52] HappyPanda: is there a reason why when i switch languages via the "search xx language wiki", the interface stays in english? [20:03:57] matanya: ah, so the saved pages were fairly very buggy. [20:04:05] matanya: so we've decided to make them just 'bookmarks' [20:04:40] HappyPanda: so rename the feature, this is confusing [20:04:49] matanya: indeed, we just did. out in next build. [20:04:56] Maryana: ah, so you've to switch that in the android settings [20:05:03] Maryana: UI language is systemwide, we can't change it per-app [20:05:15] Maryana: settings language is just which wiki you are browsing [20:05:20] even "search wikipedia"? [20:05:29] can't that string be localized? [20:05:47] (i'm actually looking at the ios app at the mo, but i'm betting this applies in android, too) [20:06:15] (03PS3) 10Kaldari: Make sure mobile VisualEditor is only loaded when appropriate [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130794 (https://bugzilla.wikimedia.org/64681) [20:06:16] Maryana: we can specifcally hard code that to be 'content language' if we want [20:06:44] Maryana: but in general, we can't switch the UI language in the app. It's phone-wide. [20:06:45] HappyPanda: when saving an edit, clicking done on the keyboard doesn't save, you need to explicitly click the disk icon [20:07:21] matanya: let me file the bug. [20:07:26] Maryana: I would think that a non-English user would have set her phone's UI language before installing our app. [20:07:49] that is mostly the case dbrant [20:08:09] Maryana: by default when your phone's UI is set to a language, the app's content is also set to that language [20:08:15] (at least on Android) [20:08:22] I think that is the case on iOS as well. [20:08:47] HappyPanda: all none namespace 0 pages go to the browser? [20:09:28] ok - how do the language wiki defaults work? is everything going to enwiki by default? [20:09:48] (just trying to make this less confusing for multilinguals) [20:10:14] owww, some template are broken [20:10:31] Maryana: 1. if your UI language has a corresponding wiki language, it is set to that wiki, 2. if not, english [20:10:43] Maryana so if my phone is set to german I'll default to dewiki [20:11:19] so then why do we need this language-switching feature? :) [20:12:20] Maryana: ah, so two things. 1. So you can search other language wikis without switching your entire phone to that language (quick look in german, for example), 2. We support way more languages than Android does [20:12:41] Maryana: if I want to search Hindi or Tamil wikipedia, 99.99% of Android phones have no way for you to set UI language to that, and I hence can't go to those wikis [20:12:57] That makes sense. But for the first release I feel like we're tripping over ourselves in complexity. [20:13:00] right. what i mean is, why do we need it in the MVP. it's a useful feature for a small number of users, i agree. but it's very complex from a UI standpoint [20:13:18] small number == everyone outside USA? [20:13:22] Maryana: without that feature, nobody can access any wiki that's not in the 10-15 that Android supports [20:13:25] It's not a small number of users. [20:13:29] But that doesn't matter. [20:13:33] Maryana: so anyone not in the US or Europe is not really gonna be able to do anything [20:13:39] brion: yuvi just said your phone UI will usually match your default wiki [20:13:46] For the first release we should be sharply focussed on what we need to get this out of the door. [20:13:48] except in cases like some indic languages [20:13:55] Maryana: yeah, but choices of language in the phone UI is severely limited. [20:14:19] Maryana: my phone has support for about 25 or so. Until two android releases ago it was like 13 or 12 [20:15:10] kk -- just to clarify, i'm not saying this isn't a useful thing! i just want to make sure i understand why & for whom it's useful, and we make it as simple to understand & use as possible at first if we do include it in the first release [20:15:37] keep in mind that removing it will require work, whereas leaving it is free ;) [20:15:54] but yeah it’s tricky to get a good mental model and i’d love to make it easier to use [20:15:57] Maryana: I understand! :D [20:16:04] Maryana: we should probably also document this somewhere. [20:16:23] HappyPanda: Sure. But we need an actual decision to document first. [20:16:23] new trello card :) [20:16:36] we can make a stub for the backlog [20:16:50] Deskana: more like documention of what the code does and why. [20:19:17] What I think would work is having a button labelled something like "Wiki: English Wikipedia:. [20:19:35] That way we can support the language switching and people know what's happening when they switch to a different language. [20:20:02] Deskana: Maryana indeed, I agree. This 'UI Language vs Content Language' was a big point of confusion for a lot of people with the old phonegap app as well. [20:20:25] Deskana: Maybe do what Mobile web does, and display the language name in search bar? [20:20:30] If you want your app in a different language then change the settings in your phone. But letting you use different Wikipedias, that we can do. [20:20:31] yeah, what Deskana said. and also, instead of returning to the menu, maybe it can then just take you to the search page? [20:21:04] what's super confusing for me is 1) i switch the language, 2) i return to the menu interface where the language is the same! [20:21:20] if i just got taken to a search page in the language i'd chosen, it'd be fine [20:21:31] Maryana: That's why I think "Wiki: X Wikipedia" is better prose for the button. [20:21:49] Maryana: Then they know they're switching to a different wiki, not changing a setting for the display language of the app. [20:21:58] +1 [20:21:58] I could do that, yeah [20:22:11] *boom* [20:22:13] product management [20:22:15] :D [20:22:27] Holy shit was that a product decision I just made? [20:22:37] I'm not used to this. [20:22:47] It never happens in Platform. [20:23:01] Deskana: should it be 'Wiki:' or 'Wikipedia:' or 'Wikipedia Language'? [20:23:08] :) [20:23:17] SOMEONE JUST MANAGED A PROJECT WHAT THE HECK [20:23:25] *cough* Product [20:23:27] :) [20:23:31] pro-something [20:23:37] brion: WFM :) [20:23:40] :D [20:23:41] juse use PM to be safe [20:23:50] yeah, private messages are safer :P [20:23:59] haha [20:24:04] prime ministers, however, have lots of hangers-on who may listen in [20:24:27] The thing I like about the "Wiki: X Wikipedia: is it preserves the string "X Wikipedia" which is important for brand identity. [20:24:40] "Wikipedia: English" is shorter and snappier but we lose that identity. [20:24:43] do you need the "wiki:" part then? [20:24:54] how about just English Wikipedia, Svenska Wikipedia, etc.? [20:25:00] Deskana: so this is the standard android settings pattern, which is that you have the name of the preference in large and the selection in small beneath it. [20:25:15] using that makes setting up these screens much easier, and also makes it consistent [20:25:26] Maryana: I think a button labelled "English Wikipedia" would be confusing. Imagine you go to the settings of the app and see a button labelled "English Wikipedia". Would you know what pressing it would do? [20:25:26] so we need a title. [20:26:42] ‘Search language’? ‘Article language’? [20:26:49] i dare not say ‘Content language’ that’s jargon [20:27:15] "search another wiki"? [20:27:20] "search in another language?" [20:27:22] "Wikipedia language" [20:27:29] I have a screenshot, let me show [20:28:20] Maryana: Deskana https://imgur.com/frnnjEr [20:28:32] tapping it brings up the dialog [20:28:52] HappyPanda: That's super helpful. Thanks. [20:30:39] (03PS1) 10Yuvipanda: Tweak verbiage for default wikipedia to use [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130965 [20:31:04] Deskana: ^ haz patch. I can tweak verbiage as you see fit, trivial. [20:32:12] matanya: and no, not all non 0 namespace. Only Special: pages should go to the browser [20:32:20] HappyPanda: I'll ponder it. Thanks! [20:32:20] matanya: and non-existant pages [20:32:26] thanks [20:32:34] Deskana: in the mean time, can I get this merged, since it is an improvement over the current status quo? [20:34:14] HappyPanda: Go for it. [20:34:26] HappyPanda: I'm drawing on the whiteboard trying to figure out what's even better! [20:34:30] matanya: https://bugzilla.wikimedia.org/show_bug.cgi?id=64714 for the other bug you reported [20:34:32] 3Wikipedia App / 3Generic: Pressing 'done' on save workflow should perform the current affirmative action - 10https://bugzilla.wikimedia.org/64714 (10Yuvi Panda) 3NEW p:3Unprio s:3normal a:3None Rather than just hide keyboard and make me press the action bar button again. [20:34:44] thanks HappyPanda [20:34:46] Deskana: :) Do keep in the "title\nvalue" paradigm though. Android standard, default controls, etc [20:35:14]