[00:02:06] MaxSem: As PM for Hovercards, thanks for your work on PageImages and TextExtracts. :) [00:05:34] awjr: congrats http://hire.jobvite.com/CompanyJobs/Careers.aspx?c=qSa9VfwQ&cs=9UL9Vfwt&page=Job%20Description&j=oSrSYfwT&s [00:20:22] MaxSem: https://gerrit.wikimedia.org/r/#/c/129088/2/ExtractFormatterTest.php [00:20:34] (03CR) 10Spage: "the MANTLE test is order-dependent." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129335 (owner: 10Jdlrobson) [00:20:44] (03PS1) 10Jdlrobson: Fix 2nd upload from Special:Uploads page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130985 (https://bugzilla.wikimedia.org/64400) [00:23:08] kaldari, replied [00:23:13] thanks! [00:24:43] MaxSem: Ah! [00:29:55] tfinc :D [00:30:09] resumes are coming in [00:30:10] MaxSem: added another comment [00:30:49] ah, makes sense [00:33:16] jdlrobson: Why do we load a spinner when people click on the watchstar icon. That seems pretty weird to me. [00:34:51] don't we spin it kaldari? [00:35:15] first we show the regular spinner, then we show the spnining star [00:35:59] jdlrobson: anyway, not directly related to your patch, but just wanted to mention that it bothers me :) [00:36:24] mm that is weird [00:36:28] raise a bug under hygiene or something [00:38:10] jdlrobson: looks like https://gerrit.wikimedia.org/r/#/c/125269/ is now merged - can we move the card out of 'awaiting final code review'? [00:46:31] (03PS1) 10Dr0ptp4kt: WIP: DO NOT MERGE! MCC-MNC logging. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 [00:46:53] (03CR) 10Dr0ptp4kt: [C: 04-2] "Don't merge yet." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [00:51:16] (03PS2) 10Dr0ptp4kt: WIP: DO NOT MERGE! MCC-MNC logging. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 [00:56:11] (03CR) 10Kaldari: [C: 04-1] Watchstar refactor - now with tests! (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 (owner: 10Jdlrobson) [00:58:12] (03CR) 10Kaldari: Watchstar refactor - now with tests! (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 (owner: 10Jdlrobson) [01:04:49] (03CR) 10Kaldari: Watchstar refactor - now with tests! (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 (owner: 10Jdlrobson) [01:17:50] (03CR) 10Dbrant: [C: 032] Bump version to 2.0-alpha-2014-05-01 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/130979 (owner: 10Yuvipanda) [02:12:19] (03PS3) 10Dr0ptp4kt: WIP. DO NOT MERGE YET. MCC-MNC logging. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 [02:53:11] (03PS4) 10Dr0ptp4kt: WIP. DO NOT MERGE YET. MCC-MNC logging. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 [02:57:35] (03PS5) 10Dr0ptp4kt: WIP. DO NOT MERGE YET. MCC-MNC logging. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 [02:59:16] (03Abandoned) 10Dr0ptp4kt: Make Wikipedia Zero a regular fixture on Wikipedia for Android. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/120585 (owner: 10Dr0ptp4kt) [04:49:32] (03PS2) 10Jdlrobson: QA: Tests for 2nd upload from Special:Uploads page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130985 (https://bugzilla.wikimedia.org/64400) [05:20:47] 3MobileFrontend / 3Feature requests: Mantle: support handlebars compilation - 10https://bugzilla.wikimedia.org/64735 (10spage) 3NEW p:3Unprio s:3normal a:3None Handlebars templates can be precompiled into JavaScript, see http://handlebarsjs.com/precompilation.html . The compiler uses nodejs, so it m... [05:25:30] 3MobileFrontend / 3Feature requests: Mantle: support handlebars compilation - 10https://bugzilla.wikimedia.org/64735#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/7eTXMkkI [05:30:32] 3Wikipedia App / 3Settings: Android: Change language setting prose - 10https://bugzilla.wikimedia.org/64736 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None In the settings menu on the Android app, change the prose for the language selection to the following: Top level: Wikipedia language Sublevel: En... [05:30:45] 3Wikipedia App / 3Settings: Android: Change language setting prose - 10https://bugzilla.wikimedia.org/64736 (10Dan Garry) p:5Unprio>3Normal [05:58:18] 3MobileFrontend / 3stable: [dismiss] does not dismiss banner on mobile - 10https://bugzilla.wikimedia.org/64737 (10Nicolas Raoul) 3UNC p:3Unprio s:3normal a:3None Created attachment 15275 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15275&action=edit Not dismissed Steps to reproduce: 1. Go... [06:00:29] 3MobileFrontend / 3stable: [dismiss] does not dismiss banner on mobile - 10https://bugzilla.wikimedia.org/64737#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/cM6a95iD [06:03:02] 3Wikipedia App / 3Generic: iOS: Long, single word article titles are not displayed correctly - 10https://bugzilla.wikimedia.org/64738 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Because the title of the article [[Lopado­temacho­selacho­galeo­kranio­leipsano­drim­hypo­trimmato­silphio­parao­melito­... [06:08:17] 3Wikipedia App / 3Generic: iOS: Long article titles cause button prose to be very long - 10https://bugzilla.wikimedia.org/64739 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None The article [[Another Demonstration of the Cliff-Guibert Fire Hose Reel, Showing a Young Girl Coming from an Office, Detaching... [12:18:56] aha! gotcha aharoni [13:50:37] * PissedPanda waves at dbrant [13:51:06] YuviPanda: hey! why pissed? [13:51:18] dbrant: Visas are horrible horrible things [13:51:42] YuviPanda: ah I see... [13:52:16] have spent close to 500$ on a UK visa and still not gotten it, and had to cancel a bunch of travel plans, and I might not make it to zurich because the UK embassy might not getting my passport back to me in time [13:52:34] that's not cool! [13:52:38] yeah [13:52:59] dbrant: I called their helpline. They charged my credit card about 40USD and gave me no info [13:53:07] about 25$ of that phonecall was just me trying to tell them my email address [13:53:11] what idiots! [13:54:52] well I hope you get it in time... [13:56:29] dbrant: yeah, I hope so too [13:56:39] dbrant: since that's another 2000$ USD worth of tickets [13:56:57] :(( [13:57:04] (03CR) 10Yurik: [C: 04-1] WIP. DO NOT MERGE YET. MCC-MNC logging. (033 comments) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [13:58:41] * Steinsplitter buys for YuviPanda virtual grappa. [13:58:56] * YuviPanda drinks [13:58:59] UK embassy is evil :P [13:58:59] thanks Steinsplitter [13:59:05] oh yeah, definitely [13:59:15] I'm pissed mostly because this is after spending *so much money* [14:00:15] dbrant: what're you working on today? [14:12:57] YuviPanda: I was thinking of looking into this: https://trello.com/c/tRMHtPgN/32-edit-link-loads-the-wrong-section-in-some-cases [14:14:08] YuviPanda: Also, I found an old device onto which I was able to load Android 2.3... so I could do some testing [14:17:25] Yuvipanda and dbrant: the app is becoming really solid. The only showstopper I see is how it handles wide tables. The TOC swipe action totally disrupts the ability to drag around the tables (unless you figure out the awkward workaround of starting with a vertical swipe and then moving to horizontal). [14:18:27] dbrant: ah, so there's some info about that from max in the bug linked, I think [14:18:32] err, from monte [14:18:58] dbrant: that would need some API level fixes, I think. Go for it! [15:31:27] YuviPanda: do you think we should have an OK/Cancel dialog for logging out? [15:41:03] (03PS1) 10Dbrant: Setting dialog titles correctly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131063 [15:55:36] dbrant: hey [15:55:48] dbrant: hmm, possibly, yeah. [15:55:57] dbrant: it's a bit sudden now [15:56:25] (03CR) 10Yuvipanda: [C: 032] "Whoops!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131063 (owner: 10Dbrant) [15:57:00] dbrant: can you also take a look at https://trello.com/c/xqpwtw7u/25-android-app-does-not-realize-when-it-has-been-logged-out when you have the time? [15:57:22] seems to be a problem with the code in EditSectionActivity that re-logs you in if you get an invalid edit token or somesuch [15:57:29] YuviPanda: i will try [15:57:33] and the LoginTaskTest has also been failing, so this might be related [15:57:35] (03Merged) 10jenkins-bot: Setting dialog titles correctly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131063 (owner: 10Dbrant) [15:57:53] we sadly have our own cookie persistance code (grrr!) so might be a bug htere too [16:03:17] (03PS1) 10Yuvipanda: Navigate to Main Page when user changes content language [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131066 (https://bugzilla.wikimedia.org/64736) [16:05:14] (03PS1) 10Yuvipanda: Rename SavePageEvent to BookmarkPageEvent [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131067 [16:25:38] (03CR) 10Jdlrobson: [C: 032] "GSD" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130252 (https://bugzilla.wikimedia.org/64302) (owner: 10MaxSem) [16:26:42] (03Merged) 10jenkins-bot: Don't misuse comma-separator message [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130252 (https://bugzilla.wikimedia.org/64302) (owner: 10MaxSem) [16:27:26] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Making our use of local storage more robust (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130978 (owner: 10Kaldari) [16:37:13] (03CR) 10Jdlrobson: Watchstar refactor - now with tests! (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 (owner: 10Jdlrobson) [16:38:39] (03PS1) 10Dbrant: For API10 compatibility. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131073 [16:39:05] 3MobileFrontend / 3stable: Do not use comma-separator message in "7 bytes added, 8 days ago" (mobile diff) - 10https://bugzilla.wikimedia.org/64302 (10Jon) 5PAT>3RES/FIX [16:39:35] 3MobileFrontend / 3stable: Upload workflow broken on Uploads page for second upload - 10https://bugzilla.wikimedia.org/64400#c3 (10Jon) I can't replicate this bug. Here's a test that prove it's working okay. [16:40:07] (03PS10) 10Jdlrobson: Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 [16:40:09] (03PS8) 10Jdlrobson: Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 [16:41:09] (03PS11) 10Jdlrobson: Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 [16:41:16] (03PS9) 10Jdlrobson: Rewrite Search using a PageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127833 [16:41:33] (03PS14) 10Jdlrobson: Hygiene: Standardise on our icon usage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129085 [16:41:40] (03CR) 10Dbrant: ""RequestMainPageEvent" class is missing" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131066 (https://bugzilla.wikimedia.org/64736) (owner: 10Yuvipanda) [16:41:47] (03PS6) 10Jdlrobson: Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) [16:42:47] (03CR) 10jenkins-bot: [V: 04-1] Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) (owner: 10Jdlrobson) [16:50:07] (03PS1) 10Jdlrobson: Hygiene: Remove redundant code in getDefaultModules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131077 [16:56:28] (03CR) 10MaxSem: [C: 032] Hygiene: Remove redundant code in getDefaultModules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131077 (owner: 10Jdlrobson) [16:57:04] (03Merged) 10jenkins-bot: Hygiene: Remove redundant code in getDefaultModules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131077 (owner: 10Jdlrobson) [17:03:54] (03PS6) 10Dr0ptp4kt: MCC-MNC logging. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 [17:04:43] dbrant: gah. my git workflow uses git commit -p, which is *amazing* but I sometimes keep forgetting to add new files [17:05:29] YuviPanda: np [17:06:05] dbrant: updated [17:10:54] YuviPanda: where? [17:11:48] dbrant: hmm, my push failed [17:11:50] investigating [17:13:17] (03PS2) 10Yuvipanda: Navigate to Main Page when user changes content language [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131066 (https://bugzilla.wikimedia.org/64736) [17:13:19] (03PS2) 10Yuvipanda: Rename SavePageEvent to BookmarkPageEvent [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131067 [17:13:51] dbrant: there [17:14:00] mhurd: after standup, go over scnr stuff for mcc-mnc code logging? [17:14:09] dr0ptp4kt: ya! [17:14:16] mhurd: word [17:17:43] kaldari: which bug was it? [17:17:43] i fell off the call, reconnecting... [17:18:07] one sec... [17:19:51] awjr: actually, both of these bugs were missing: https://bugzilla.wikimedia.org/show_bug.cgi?id=64669 https://bugzilla.wikimedia.org/show_bug.cgi?id=64679 [17:19:59] hrm [17:20:29] kaldari: Jon's working on that bug [17:20:31] awjr: looks like one of them is already in "In development" because Jon took it [17:20:36] The double tap [17:20:38] kaldari it's there: https://trello.com/c/Uhb0gL0Y/44-bug-64669-sidebar-links-require-2-clicks-in-ios [17:20:39] Yep :) [17:20:54] and the other is in the bug backlog: https://trello.com/c/Ic55CTkD/140-bug-64679-this-page-has-issues-link-looks-like-a-link-but-is-actually-a-giant-invisible-button [17:21:04] which apparently i did on weds [17:21:14] the other one says "Card not found" when I try to open the Trello card for it [17:21:43] kaldari: try again? [17:22:35] awjr: I guess those must have been handled on Weds when I was sick [17:22:40] :) [17:22:46] kaldari: are you seeing both the cards in trello now? [17:22:54] yes, I can see them now [17:23:20] good - kaldari the bug backlog had a bad visibility set and you weren't a member on the board which is probably why you weren't seeing it [17:23:22] both fixed now [17:23:33] ah cool. Thanks! [17:23:37] np [17:23:53] kaldari: if you're concerned about the prioritization/backloggyness of either of those, let maryana now [17:23:56] s/now/know [17:24:12] I think they are fine :) [17:24:14] (03CR) 10MaxSem: Create script for checking css rule duplication (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) (owner: 10Jdlrobson) [17:24:31] MaxSem: I don't plan on merging that EVER! hence the -2 :) [17:24:37] awjr: for some reason I thought I had reported them on Thurs [17:24:47] It's there. [17:24:47] (03PS7) 10Jdlrobson: DO NOT MERGE: Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) [17:24:56] MaxSem: yeh and i -2ed it :) [17:24:58] kaldari: delirium from illness? [17:25:08] i'm using it to work some shit out [17:25:10] must be [17:25:22] kaldari: what was th ebug ? [17:25:22] IF I CAN COMMENT I COMMENT:P [17:25:36] jdlrobson: it's the one you're already working on :) [17:25:43] ahh [17:25:56] I thought I had reported it Thurs instead of Weds [17:31:14] (03CR) 10Dr0ptp4kt: "Removing -2. The code in the dependent patch will go out ahed of or in close proximity to this patch, which will be before the production " [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [17:33:47] brion: looks like the mic, keyboard and trackpad on my laptop is dead!?! [17:34:01] urrrrrrrk [17:34:18] applecare time? [17:35:04] brion: yeah, but I'm in Mumbai, my flight is from Chennai on Wednesday, and my passport is still with the UK High Commission [17:35:23] ugh [17:35:59] spent close to 700 USD on my visa related things for just the UK [17:36:06] so much to just pop over and visit a friend [17:40:06] (03CR) 10Kaldari: [C: 032] Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 (owner: 10Jdlrobson) [17:45:14] YuviPanda: i moved that license text story to the next sprint. i want to check in w/legal on exactly what we need (read: how little we can get away with) there ;) [17:45:47] Maryana: :) So Vibha and Kenan did that as well, and apparently it was a long process. Might want to check in with them [17:46:11] hey Deskana! [17:46:23] three people talk to a lawyer & they all come back with 3 different stories :) [17:47:29] Maryana: :) I vaguely remember kenan saying there were some emails, so unsure if they could be of any use. [17:47:37] Maryana: but yay to getting that story clearer :) [17:47:42] awjr, Maryana: James_F resolved the problems I had with references, so I will work on this story today [17:47:54] jgonera: oh, cool! thanks [17:48:24] wth is wmf-insecte? [17:48:25] hmm [17:48:37] yay! great news, thanks jgonera [17:48:48] Hmm... [17:48:52] Am I here or not? [17:48:56] Wifi is being weird. [17:49:01] (03CR) 10Dbrant: Navigate to Main Page when user changes content language (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131066 (https://bugzilla.wikimedia.org/64736) (owner: 10Yuvipanda) [17:49:07] I am here! [17:49:09] Deskana: your Visa to IRC has been granted and you may enter [17:49:19] Yay! [17:49:21] YuviPanda: wmf-insecte is a browser test IRC bot. [17:49:26] I am now a Resident Alien of the Internet. [17:49:39] YuviPanda: Named in French because hashar thought it was amusing. [17:49:50] James_F: haha! [17:50:06] Deskana: indeed. you have reasonable rights, including the right to fill out a lot of paperwork :) [17:52:05] 3MobileFrontend / 3stable: sidebar links require 2 clicks in iOS - 10https://bugzilla.wikimedia.org/64669#c2 (10Jon) http://www.nczonline.net/blog/2012/07/05/ios-has-a-hover-problem/http://stackoverflow.com/questions/18047353/fix-css-hover-on-iphone-ipad-ipod http://stackoverflow.com/questions/21786375/ios-7... [17:52:16] (03PS3) 10Yuvipanda: Navigate to Main Page when user changes content language [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131066 (https://bugzilla.wikimedia.org/64736) [17:52:18] (03PS3) 10Yuvipanda: Rename SavePageEvent to BookmarkPageEvent [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131067 [17:52:23] dbrant: updated [17:52:45] (03PS1) 10Jdlrobson: Hygiene: Refactor main menu code [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131088 [17:52:47] (03PS1) 10Jdlrobson: Add iOS hover bug fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131089 (https://bugzilla.wikimedia.org/64669) [17:53:40] (03PS2) 10Jdlrobson: Add iOS hover bug fix [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131089 (https://bugzilla.wikimedia.org/64669) [17:54:14] (03CR) 10Dbrant: [C: 032] Navigate to Main Page when user changes content language [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131066 (https://bugzilla.wikimedia.org/64736) (owner: 10Yuvipanda) [17:54:22] (03CR) 10Jdlrobson: [C: 032] "come on jenkkinss" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 (owner: 10Jdlrobson) [17:55:02] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE: Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) (owner: 10Jdlrobson) [17:55:11] kaity|away: can you still replicate https://bugzilla.wikimedia.org/64576 ? [17:55:17] (03Merged) 10jenkins-bot: Watchstar refactor - now with tests! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/127800 (owner: 10Jdlrobson) [17:56:44] (03CR) 10Dbrant: [C: 032] Rename SavePageEvent to BookmarkPageEvent [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131067 (owner: 10Yuvipanda) [17:57:00] YuviPanda, dbrant: The regular releases we've got going are awesome. [17:57:21] (03CR) 10Jdlrobson: [C: 032] "It has tests so I'll just merge. I'll see if I can verify it on beta labs when it gets merged there." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129612 (https://bugzilla.wikimedia.org/64318) (owner: 10MaxSem) [17:57:26] Deskana: :) [17:58:05] 3MobileFrontend / 3stable: Watchstar flickers - 10https://bugzilla.wikimedia.org/64083 (10Jon) 5PAT>3RES/FIX [17:58:13] (03PS2) 10Dbrant: For API10 compatibility. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131073 [17:58:44] jdlrobson, are you still logging things from your dev wiki into production EL? [17:59:20] 3MobileFrontend / 3stable: [dismiss] does not dismiss banner on mobile - 10https://bugzilla.wikimedia.org/64737#c2 (10Jon) How is the banner generated? Via CentralNotice? If so can you link us to the banner of meta wiki? [17:59:41] jgonera: when i'm testing yeh. by default it logs to eventlog.log [18:00:06] jdlrobson, why don't you use the dev server? [18:01:07] YuviPanda: poke poke meeting [18:02:50] 3MobileFrontend / 3stable: [dismiss] does not dismiss banner on mobile - 10https://bugzilla.wikimedia.org/64737#c3 (10Matt Walker) Jon; this is actually a dismissable site notice on enwikivoyage: https://en.wikivoyage.org/wiki/MediaWiki:Sitenotice [18:03:44] brion: yeah, turning up [18:03:51] yay [18:04:24] brion: what did I miss? [18:04:30] YuviPanda: not much [18:04:45] next sprint will concentrate on ios ui issues, then the one after that android user interface issues [18:04:52] jgonera: dev server as in eventlog.log ? [18:05:06] jdlrobson, no, eventlogging-devserver [18:05:15] YuviPanda: wrt design, we'll be a bit iOS centric this sprint, but then we'll be more Android centric the next sprint. [18:05:29] Deskana: ah, hmm. [18:05:54] i suppose i could i just like to make 100% sure. Do you see a problem with this? [18:06:35] Deskana: remember for android we can push out the 'beta' that gives us 10k users, so we should do that sooner. [18:07:07] jgonera https://bugzilla.wikimedia.org/show_bug.cgi?id=55577 [18:08:18] jdlrobson, that still doesn't answer my question of why one wouldn't use eventlogging-devserver ;) [18:08:30] Deskana: re: regular releases, totally! :D [18:08:40] oh, right, didn't see this [18:09:07] I mean, yes, I see a problem with this. it's just like if you were creating bogus pages on enwiki just to make sure that everything works ok in production [18:11:50] 3MobileFrontend / 3stable: [dismiss] does not dismiss banner on mobile - 10https://bugzilla.wikimedia.org/64737#c4 (10Ryan Kaldari) 5UNC>3RES/DUP *** This bug has been marked as a duplicate of bug 64716 *** [18:12:17] (03Merged) 10jenkins-bot: Preserve URL parameters when toggling view [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129612 (https://bugzilla.wikimedia.org/64318) (owner: 10MaxSem) [18:15:05] (03CR) 10Kaldari: Hygiene: Making our use of local storage more robust (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130978 (owner: 10Kaldari) [18:20:12] (03PS3) 10Kaldari: Hygiene: Making our use of local storage more robust [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130978 [18:20:50] 3MobileFrontend / 3stable: mobileaction parameter causes all other parameters to be lost in redirect - 10https://bugzilla.wikimedia.org/64318#c6 (10Jon) 5PAT>3RES/FIX Verified on labs. [18:21:05] 3MobileFrontend / 3stable: mobileaction parameter causes all other parameters to be lost in redirect - 10https://bugzilla.wikimedia.org/64318 (10Jon) 5RES/?>3VER [18:26:07] aww “Adobe AIR Support Ending in BlackBerry OS 10.3.1” [18:26:53] (03CR) 10MaxSem: Hygiene: Making our use of local storage more robust (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130978 (owner: 10Kaldari) [18:27:55] MaxSem: good idea [18:30:02] brion, let me guess... our app uses it? :P [18:30:21] no, no BB 10 version ever got finished :) [18:30:24] but it amuses me [18:30:32] i still get their app world emails every couple months [18:30:45] "wow, they had it in the first place" [18:30:49] lol [18:31:51] 3Wikipedia App / 3Generic: Opening many pages in succession breaks rendering - 10https://bugzilla.wikimedia.org/64762 (10Dmitry Brant) 3NEW p:3Unprio s:3major a:3None If I keep following links in pages, and go about 5 or 6 pages deep, the WebView stops rendering the page properly (random blank rectan... [18:35:05] 3Wikipedia App / 3Generic: Opening many pages in succession breaks rendering - 10https://bugzilla.wikimedia.org/64762#c1 (10Yuvi Panda) So the problem is that we don't kill PageViewFragments when they aren't shown on screen - we add fragments than replace them. The reason being that I'm unclear about the lif... [18:35:12] (03PS1) 10Kaldari: Promoting copyvio EXIF confirm message to stable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131106 [18:36:32] Maryana: Deskana can you turn off screensharing? [18:36:38] Maryana: Deskana unless it's going to be used again. [18:36:46] woo! [18:36:50] 3Wikipedia App / 3Generic: Opening many pages in succession breaks rendering - 10https://bugzilla.wikimedia.org/64762#c2 (10Dan Garry) I can't replicate this on my Nexus 7. I've clicked on about 30 links and everything's still working. [18:37:35] 3Wikipedia App / 3Generic: Opening many pages in succession breaks rendering - 10https://bugzilla.wikimedia.org/64762#c3 (10Dan Garry) (In reply to Dan Garry from comment #2) > I can't replicate this on my Nexus 7. I've clicked on about 30 links and > everything's still working. Er, I may have to take that... [18:46:10] Deskana: do you want to put the blanking bug in this sprint? It's a bit low on Android points, and that is a fair bit of technical work that doesn't need design / product interaction [18:47:57] YuviPanda: mhurd brion dbrant http://hatjitsu.wmflabs.org/21525 [18:48:27] tfinc: I've abstained [18:48:37] YuviPanda: me & Deskana will try to scrub the BZ backlog & add more android stuff for you :) [18:48:42] Maryana: woot [18:48:42] don't worry [18:50:21] We can put you to work. :P [18:50:30] :) [18:51:15] (03PS3) 10Yuvipanda: For API10 compatibility. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131073 (owner: 10Dbrant) [18:51:21] (03CR) 10Yuvipanda: [C: 032] For API10 compatibility. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131073 (owner: 10Dbrant) [18:54:21] 3MobileFrontend / 3stable: [dismiss] does not dismiss banner on mobile - 10https://bugzilla.wikimedia.org/64737#c5 (10Jon) I'm pretty sure it's not a dupe of that. No local storage issues in console.... [18:54:51] (03Merged) 10jenkins-bot: For API10 compatibility. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131073 (owner: 10Dbrant) [18:55:20] 3MobileFrontend / 3stable: [dismiss] does not dismiss banner on mobile - 10https://bugzilla.wikimedia.org/64737#c6 (10Jon) 5RES/DUP>3REO My local storage has plenty of space... must be something different? [18:59:16] YuviPanda: Ah, sweet, so you've got a JSON file for each wiki's main page name? [18:59:23] Deskana: yeah [18:59:29] YuviPanda: Did you generate that using Wikidata? [19:00:11] Deskana: no, I've a script that hits siteprop of everything :P [19:00:20] Pfff. :P [19:00:40] (03PS1) 10MaxSem: mobileview: respect onlyrequested sections on main page too [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131113 (https://bugzilla.wikimedia.org/64663) [19:00:48] If it works... [19:01:15] Deskana: the other cool thing is that in the languages list in settings [19:01:20] Deskana: the languages are ordered on size of wiki :P [19:01:38] Deskana: that was trivial to do with wikistats.wmflabs.org [19:04:36] 3Wikipedia App / 3Generic: Opening many pages in succession breaks rendering - 10https://bugzilla.wikimedia.org/64762#c4 (10Dmitry Brant) I have the following devices, all of which exhibit this behavior after 6 pages: Samsung Galaxy Note 2 Galaxy S3 Galaxy S4 Moto Droid [19:16:33] YuviPanda: setting the previous WebView to GONE when loading a new page seems to solve it. I'll whip up a patch... [19:17:07] (03PS1) 10MaxSem: Hygiene: doc, unused vars, duplicate array element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131119 [19:32:27] dbrant: ah, nice. perhaps we should set the entire fragment to GONE as well? [19:32:54] dbrant: we should still fix it at some point, though. Unsure how. I haven't profiled (should!) but creating a new webview instance for everything should have some terrible memory reprucussions [19:32:59] YuviPanda: precisely what I'm doing :) [19:33:06] dbrant: woo :) [19:33:12] YuviPanda: yes, for sure [19:35:48] (03CR) 10Jdlrobson: [C: 032] Hygiene: doc, unused vars, duplicate array element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131119 (owner: 10MaxSem) [19:36:59] (03CR) 10Jdlrobson: [C: 032] Hygiene: Making our use of local storage more robust [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130978 (owner: 10Kaldari) [19:37:13] (03Merged) 10jenkins-bot: Hygiene: doc, unused vars, duplicate array element [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131119 (owner: 10MaxSem) [19:37:38] (03Merged) 10jenkins-bot: Hygiene: Making our use of local storage more robust [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130978 (owner: 10Kaldari) [19:37:55] (03CR) 10Jdlrobson: [C: 031] "Needs testing vigorously against various devices before pushing to stable." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131106 (owner: 10Kaldari) [19:39:38] (03PS1) 10Dr0ptp4kt: Support custom headers above and beyond User-Agent. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/131122 [19:39:50] 3Wikipedia App / 3Generic: Opening many pages in succession breaks rendering - 10https://bugzilla.wikimedia.org/64762#c5 (10Dan Garry) On my Nexus 7 it took around 35 pages for this to happen. [19:40:43] milimetric: is it possible to force a rerun of the daily limn graphs? [19:41:15] (03CR) 10Yuvipanda: [C: 04-1] "If we do this we should definitely stop special casing User-Agent." [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/131122 (owner: 10Dr0ptp4kt) [19:42:35] YuviPanda: regarding 'special casing', are you talking about its specific constructor? note that there are two new constructors in there. what do you have in mind? [19:42:51] dr0ptp4kt: get rid of all references to userAgent. Just treat it as any other custom header [19:43:20] dr0ptp4kt: so constructure, the code that adds User-Agent to headers, etc. [19:43:21] YuviPanda: oh, so add it to the HashMap, [19:43:26] dr0ptp4kt: yeah, pretty much [19:43:30] k, hang on [19:44:43] kaity|away: you there? [19:45:50] 3MobileFrontend / 3alpha: VE - Close button doesn't work - 10https://bugzilla.wikimedia.org/64576#c3 (10Jon) 5NEW>3RES/WOR Can't get hold of you today kaity. It seems fixed to me, but let me know if it isn't by reopening this bug and if so specifically where (wikipedia? mediawiki.org? beta labs?) and wha... [19:47:42] (03PS1) 10Dbrant: Hiding page fragment when obscured by a new page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131130 (https://bugzilla.wikimedia.org/64762) [19:56:05] (03PS2) 10Dr0ptp4kt: Support custom headers above and beyond User-Agent. [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/131122 [19:56:20] YuviPanda: ^^ [19:56:42] (03CR) 10Dr0ptp4kt: "I think PS2 address this." [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/131122 (owner: 10Dr0ptp4kt) [19:58:27] (03CR) 10Nemo bis: "Any reason not to sample this log?" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [20:11:02] (03CR) 10Dr0ptp4kt: "Good question. It's possible we may have situations where operators have not lots of users on them accessing Wiki(m|p)edia properties, so " [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [20:12:43] (03PS7) 10Dr0ptp4kt: MCC-MNC logging. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 [20:21:55] (03CR) 10Nemo bis: "Sounds sensible. Thanks." (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [20:28:52] dr0ptp4kt: the tests pass, I assume? The patch looks good to me. [20:32:09] awjr|lunch: hangout added to invite [20:34:38] (03PS1) 10MaxSem: Reorganise test directories [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131211 [20:40:31] https://docs.google.com/a/wikimedia.org/presentation/d/1dM7LO4zx0dhh3Bf8kd8JP_LimaNPycYULHVWLop2Ftw/edit#slide=id.p [20:40:33] awjr: ^^ [20:40:34] ? [20:43:05] https://docs.google.com/a/wikimedia.org/presentation/d/1YVYrXstxQ_u0MO-YWHGNR1VuWK4_zD1LW0_C4PcaJaM/edit?usp=drive_web <- this? awjr [20:43:36] no Maryana [20:43:45] heh [20:43:50] :p [20:44:50] (03PS3) 10MaxSem: Deal better with expired edit tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) (owner: 10Jdlrobson) [20:58:00] (03PS1) 10Dbrant: Fixed action bar icon titles in Bookmarks and Create Account [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131218 [20:58:26] YuviPanda: the tests passed when i ran them with mvn install [20:58:34] dr0ptp4kt: cool [21:18:12] (03PS1) 10Dbrant: Restricting the navbar and ToC to a reasonable width. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131219 [21:21:21] YuviPanda: mind merging https://gerrit.wikimedia.org/r/#/c/131122/ ? [21:21:41] (03CR) 10Yuvipanda: [C: 032 V: 032] "wooooo!" [apps/android/java-mwapi] - 10https://gerrit.wikimedia.org/r/131122 (owner: 10Dr0ptp4kt) [21:21:42] dr0ptp4kt: there. [21:21:52] YuviPanda: thanks! [21:22:00] dr0ptp4kt: :) I should push it to the remote repo soon [21:22:09] (03CR) 10jenkins-bot: [V: 04-1] Deal better with expired edit tokens [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) (owner: 10Jdlrobson) [21:46:10] (03CR) 10Yurik: [C: 04-1] "one minor thing, but seems ok otherwise, will test it shortly" (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [21:47:44] (03CR) 10Dr0ptp4kt: MCC-MNC logging. (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [21:50:29] awjr: how was the birds eye view in R32 after a full meeting ? [21:50:43] (03PS8) 10Dr0ptp4kt: MCC-MNC logging. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 [21:51:06] (03CR) 10Dr0ptp4kt: "Try that." [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [21:52:23] dr0ptp4kt: did you have a chance to review https://docs.google.com/a/wikimedia.org/document/d/1xZJ9NloNXG0yRF6FERlAKW96woCn7ENkwvwG8asotdc/edit?disco=AAAAAKLGUuQ ? [21:52:44] (03CR) 10Yurik: "looks good codewise, will need to figure out how to test it and merge it" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [21:53:16] tfinc: yes. i changed just a few words. [21:53:23] thanks [21:54:03] tfinc: it was ok once i got used to it, but i prefer being at eye level [21:54:21] awjr: dos anyone sell a below tv mount ? [21:54:25] i felt ultra-big brother and it was harder to feel present [21:54:26] because that would work even better [21:54:30] * awjr shrugs [21:54:32] i presume so [22:26:28] (03PS1) 10Yuvipanda: Add StyleBundle classes + injection methods to CommunicationBridge [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131229 [22:26:57] (03CR) 10jenkins-bot: [V: 04-1] Add StyleBundle classes + injection methods to CommunicationBridge [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131229 (owner: 10Yuvipanda) [22:27:36] aww jenkins-bot [22:28:48] (03PS2) 10Yuvipanda: Add StyleBundle classes + injection methods to CommunicationBridge [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131229 [22:28:48] actually good catch jenkins! [22:29:06] (03CR) 10jenkins-bot: [V: 04-1] Add StyleBundle classes + injection methods to CommunicationBridge [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131229 (owner: 10Yuvipanda) [22:29:10] oh what now [22:30:03] (03PS3) 10Yuvipanda: Add StyleBundle classes + injection methods to CommunicationBridge [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131229 [22:31:19] (03PS4) 10Yuvipanda: Add StyleBundle classes + injection methods to CommunicationBridge [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131229 [22:32:35] dbrant|bbl: doing CR now. [22:33:57] (03CR) 10Dr0ptp4kt: "I added the dependent patch to SWAT for Monday, 5-May-2014. https://wikitech.wikimedia.org/wiki/Deployments#Week_of_May_5th" [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [22:39:04] (03CR) 10Yuvipanda: [C: 032] "I still can't verify it since on my nexus the app just freezes until exited and entered back again after about 10 page navigations :(" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131130 (https://bugzilla.wikimedia.org/64762) (owner: 10Dbrant) [22:39:21] (03Merged) 10jenkins-bot: Hiding page fragment when obscured by a new page. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131130 (https://bugzilla.wikimedia.org/64762) (owner: 10Dbrant) [22:39:38] (03CR) 10Yuvipanda: "But merging since the code looks ok and I might as well check if it fixes things for other people." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131130 (https://bugzilla.wikimedia.org/64762) (owner: 10Dbrant) [22:40:16] (03CR) 10Yuvipanda: [C: 04-1] Fixed action bar icon titles in Bookmarks and Create Account (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131218 (owner: 10Dbrant) [22:41:46] (03PS2) 10Yuvipanda: Restricting the navbar and ToC to a reasonable width. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131219 (owner: 10Dbrant) [22:42:19] (03CR) 10Yuvipanda: "(PS2 is just a rebase removing a dependency)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131219 (owner: 10Dbrant) [22:42:39] (03CR) 10Yuvipanda: [C: 032] "Might need different treatment on Tablets but looks good on my phone! :)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131219 (owner: 10Dbrant) [22:42:55] (03Merged) 10jenkins-bot: Restricting the navbar and ToC to a reasonable width. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131219 (owner: 10Dbrant) [22:42:59] Deskana: a potential fix for the page whiting bug has been merged, but for me it still 'freezes' before it whites out. [22:43:03] Deskana: pushing out a release anyway. [22:44:45] (03PS1) 10Yuvipanda: Bumped version number for 2.0-alpha-2014-05-02 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131231 [22:45:10] (03CR) 10Yuvipanda: [C: 032] Bumped version number for 2.0-alpha-2014-05-02 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131231 (owner: 10Yuvipanda) [22:45:28] (03Merged) 10jenkins-bot: Bumped version number for 2.0-alpha-2014-05-02 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131231 (owner: 10Yuvipanda) [22:45:55] ragesoss: re: earlier comment about app lookins solid - yay! :D Do keep filing bugs, though! I'm sure there are quite a few. [22:49:43] Deskana: I've also added you as 'owner' for the alpha testers group [22:49:56] Deskana: these are the people who have signed up and downloaded the alpha build [22:52:11] YuviPanda: of course. Is Deskana the Android PM now? [22:52:39] ragesoss: soon. Maryana is the PM for this sprint, Deskana is 'shadowing' this sprint [22:52:40] I think [22:53:26] ragesoss: pushed out another alpha :) No big changes tho. [22:53:34] Basically in 6 working days, I will be the PM for both iOS and Android. [22:53:36] ragesoss: also do try opening a lot of pages in quick succession and tell us what happens [22:55:04] ragesoss: btw, I killed the 'My Contributions' page a while back. Needed a lot more work before it can be solid. [22:55:17] App freezes! [22:55:55] YuviPanda: Me and Maryana are doing the signoff column in the current sprint. [22:56:04] Deskana: oh, cool. [22:56:05] Now, I mean. [22:56:25] Deskana: I just pushed out 2014-05-02 which should have *all* the stories. Otherwise it might be missing 2-3. [22:56:38] productbot engage! [22:57:09] titles not in blue = <3 [22:57:20] Maryana: :) we should perhaps still differentiate them in some way tho :) [22:58:05] 3Wikipedia App / 3Generic: app crashes on {{disambiguation}} pages with no section headers - 10https://bugzilla.wikimedia.org/63986#c1 (10Sage Ross) 5NEW>3RES/WOR Don't know what the fix was, but this no longer crashes the app. [22:58:50] 3Wikipedia App / 3Generic: app crashes on {{disambiguation}} pages with no section headers - 10https://bugzilla.wikimedia.org/63986#c2 (10Yuvi Panda) It actually crashed on all pages with just one section, this was fixed last week. [23:00:29] Maryana: and Deskana: in case you're taking votes, these are mine for the top Android issues left: [23:00:31] https://bugzilla.wikimedia.org/show_bug.cgi?id=63526 [23:00:43] https://bugzilla.wikimedia.org/show_bug.cgi?id=63133 [23:00:56] ragesoss: duly noted! [23:03:11] YuviPanda: Hmm. [23:03:25] 'sup, Deskana [23:03:43] YuviPanda: wrt the user+name@gmail.com one... I can't actually register dan+garry@gmail.com with gmail. :P [23:03:45] (03CR) 10MaxSem: MCC-MNC logging. (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [23:03:50] 3Wikipedia App / 3Generic: Scrolling is broken for In-article scrollable elements - 10https://bugzilla.wikimedia.org/63526#c1 (10Sage Ross) There is an awkward workaround: you can begin swiping vertically and then continue into a horizontal swipe to avoid pulling back the whole article and revealing the TOC. [23:04:04] YuviPanda: It is, ironically, not a valid email address. :P [23:04:13] Deskana: if you register dan@gmail, you automatically get dan+(anything)@gmail.com [23:04:18] Deskana: aha! So you don't. but if you send me an email to yuvipanda+something@gmail.com, it will deliver to yuvipanda@gmail.com [23:04:21] Deskana: what ragesoss said [23:04:30] Oh, right! [23:04:31] that's why you can't register it but it is a valid email address [23:04:33] So why do you want to do that? [23:04:37] Deskana: filtering [23:04:41] ^ [23:04:47] Deskana: and finding out which bastards were selling out my email to ad agencies [23:04:48] Fucking sweet. [23:04:54] You learn something new every day. [23:05:11] Deskana: :D [23:06:13] I think craigslist still doesn't let you use +foo addresses. [23:06:56] YuviPanda: When I sign things off do you want me to also check the bug and RESOLVE FIXED anything that I sign off? [23:07:03] YuviPanda: Or would you prefer to do it? [23:07:15] YuviPanda: I'm more than happy to since I already check bugzilla for every bug anyway. [23:07:17] Deskana: so usually I do that when the bug gets merged, but if you want we can change protocol to have you do that [23:07:21] Deskana: yeah, that'll be nice :) [23:07:49] 3Wikipedia App / 3Search: Content before colon does not show up in search - 10https://bugzilla.wikimedia.org/64688 (10Dan Garry) 5PAT>3RES/FIX [23:08:05] 3Wikipedia App / 3Generic: user+name@gmail.com is not considered a valid email address - 10https://bugzilla.wikimedia.org/64615 (10Dan Garry) 5PAT>3RES/FIX [23:08:35] 3Wikipedia App / 3Settings: Android: Change language setting prose - 10https://bugzilla.wikimedia.org/64736 (10Dan Garry) 5PAT>3RES/FIX [23:08:36] 3Wikipedia App / 3Generic: It is useless to ask user to repeat password if the first password is already shown in plain text - 10https://bugzilla.wikimedia.org/64408 (10Dan Garry) 5PAT>3RES/FIX [23:10:53] (03PS3) 10Jdlrobson: QA: Remove dependency on Barack Obama article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125864 (https://bugzilla.wikimedia.org/56057) [23:10:55] (03PS1) 10Jdlrobson: Show toast when a page is protected [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131235 (https://bugzilla.wikimedia.org/64643) [23:11:05] 3Wikipedia App / 3Generic: Tapping the screen while a page is loading makes the loading icon replaced by a horizontal line - 10https://bugzilla.wikimedia.org/64277 (10Dan Garry) 5NEW>3RES/FIX [23:11:22] (03CR) 10Jdlrobson: "No longer a WIP I took another approach." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/125864 (https://bugzilla.wikimedia.org/56057) (owner: 10Jdlrobson) [23:12:28] Fix a bug, find a bug. [23:12:35] 3Wikipedia App / 3Generic: When "Could not reach the network" is shown, it shouldn't be possible to pull out the TOC drawer - 10https://bugzilla.wikimedia.org/64647 (10Dan Garry) 5NEW>3RES/FIX [23:12:39] (03CR) 10Jdlrobson: [C: 04-1] "Dependency needs to be merged first." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/130522 (https://bugzilla.wikimedia.org/64416) (owner: 10Jdlrobson) [23:13:51] Deskana: I'm gonna head to sleep in about 5m. do let me know if there's anything I can clarify / help with [23:14:09] YuviPanda: Well, I don't really know how to sign off on the #333 one. [23:14:17] Deskana: well, does it look not blue? [23:14:18] :D [23:14:40] Deskana: essentially, the page title used to look blue [23:15:05] Oh, well, that's easy then. [23:15:38] Deskana: Main Page will be displayed twice, but that's a bug in MobileView that MaxSem already has a patch for [23:16:36] YuviPanda: I think we're good. Go sleep. [23:16:45] YuviPanda: And let me know how the passport thing goes. [23:17:00] Deskana: yeah, will do :) Gonna be a terrible weekend. [23:18:08] Deskana: I'll stick around for a couple of mins till they are all cleared off, I think :) [23:18:23] * YuviPanda goes to grab water, will brb in a min [23:19:13] Maryana: looks like people are looking at history and diff pages [23:19:19] http://mobile-reportcard.wmflabs.org/graphs/diff-activity hard to see with the outage problem but big spike [23:19:22] 3Wikipedia App / 3Search: Android: "Network error. Tap to try again." bar is too persistent - 10https://bugzilla.wikimedia.org/64773 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None When there's a network error and you try and search, you get a "Network error. Tap to try again." dropdown which is reall... [23:20:06] YuviPanda: I'm afraid I'm just filing new bugs. :P [23:20:14] Deskana: :D [23:21:50] 3Wikipedia App / 3Search: Android: "Network error. Tap to try again." bar is too persistent - 10https://bugzilla.wikimedia.org/64773#c1 (10Yuvi Panda) Yeah, fade out slowly after search loses focus seems like a good thing. I wonder if hitting back should also close it. Probably not? [23:24:05] 3Wikipedia App / 3Search: Android: "Network error. Tap to try again." bar is too persistent - 10https://bugzilla.wikimedia.org/64773#c2 (10Dan Garry) (In reply to Yuvi Panda from comment #1) > I wonder if hitting back should also close it. Probably not? Yeah, probably not; the back button needs a strong men... [23:24:33] YuviPanda: Is "overfill menu" the correct term for the menu at the top right? [23:24:35] I forget what you called it. [23:24:37] Overflow? [23:24:40] Deskana: overflow [23:25:08] jdlrobson and jgonera, are you now satisfied with https://gerrit.wikimedia.org/r/131113 ? [23:25:48] Deskana: https://developer.android.com/design/patterns/actionbar.html [23:26:14] Deskana: the entire 'design android' site is a pretty good resource that documents common android patterns, many with built in support in the Android SDK itself that makes it easy to use the [23:26:52] 3Wikipedia App / 3Generic: Android: When overflow menu is disabled due to network error, it stays disabled even on articles it should be usable on - 10https://bugzilla.wikimedia.org/64774 (10Dan Garry) 3NEW p:3Unprio s:3normal a:3None Steps to reproduce: 1) Go to [[Main page]]. 2) Turn off wifi. 3)... [23:28:05] Deskana: alright, I'm off to sleep :) night! [23:28:11] YuviPanda: Good night. :) [23:33:02] (03PS1) 10Jdlrobson: i18n: Remove closing bracket on language list [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131237 [23:47:05] 3Wikipedia App / 3Generic: Keyboard doesn't hide when I navigate to left drawer - 10https://bugzilla.wikimedia.org/64339#c4 (10Dan Garry) 5RES/FIX>3REO It would be better if the keyboard closed first, then the drawer came in. It works the other way around at the minute. [23:50:35] 3Wikipedia App / 3Generic: App Icon is Flipped for RTL - 10https://bugzilla.wikimedia.org/64684#c3 (10Dan Garry) Amir, can you test that this fix works now? You'd know better than I. [23:51:04] 3Wikipedia App / 3Generic: Clicking a link that is a relative URL but not to a wiki page crashes the app - 10https://bugzilla.wikimedia.org/64423#c3 (10Dan Garry) Liangent, we think this is fixed. Can you test it for us and let us know? You'd know better than I would whether we've been successful. [23:55:06] (03PS1) 10Kaldari: Adding a jQuery plug-in for client-side storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131239 [23:55:39] (03CR) 10jenkins-bot: [V: 04-1] Adding a jQuery plug-in for client-side storage [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131239 (owner: 10Kaldari) [23:58:01] (03CR) 10Dr0ptp4kt: "See next patchset." (031 comment) [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991 (owner: 10Dr0ptp4kt) [23:58:08] (03PS9) 10Dr0ptp4kt: MCC-MNC logging. [extensions/ZeroRatedMobileAccess] - 10https://gerrit.wikimedia.org/r/130991